Re: [EXT] Re: [PATCH v1 1/1] net/qede: fix redundant condition in debug code

2022-01-10 Thread Igor Russkikh
> On Tue, Nov 30, 2021 at 10:29 PM Anatoly Burakov > wrote: >> >> Expression "a && 1" is equivalent to just "a", so fix the accidental >> inclusion of a literal in code. >> >> Cc: sta...@dpdk.org >> >> Fixes: ec55c118792b ("net/qede: add infrastructure for debug data >> collection") >> Cc: rm..

RE: [EXT] [PATCH v1 1/1] net/qede: fix redundant condition in debug code

2022-01-10 Thread Rasesh Mody
> From: Anatoly Burakov > Sent: Tuesday, November 30, 2021 10:29 PM > > External Email > > -- > Expression "a && 1" is equivalent to just "a", so fix the accidental > inclusion of > a literal in code. > > Cc: sta...@dpdk.org >

Re: [PATCH 1/2] net/cnxk: update meter bpf ID in rq

2022-01-10 Thread Jerin Jacob
On Tue, Nov 30, 2021 at 12:47 PM Sunil Kumar Kori wrote: > > >-Original Message- > >From: Rakesh Kudurumalla > >Sent: Tuesday, November 30, 2021 12:12 PM > >To: Nithin Kumar Dabilpuram ; Kiran Kumar > >Kokkilagadda ; Sunil Kumar Kori > >; Satha Koteswara Rao Kottidi > > > >Cc: dev@dpdk.or

RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails

2022-01-10 Thread Rakesh Kudurumalla
ping > -Original Message- > From: Rakesh Kudurumalla > Sent: Monday, December 13, 2021 12:10 PM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > Cc: sta...@dpdk.org; dev@dpdk.org; david.march...@redhat.com; > ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; > ajit.khapa...@broa

RE: [dpdk-dev] [dpdk-users] A question about the link status of the intel E810 nic can not be up?

2022-01-10 Thread Zhang, Qi Z
> -Original Message- > From: wangyunjian > Sent: Monday, January 10, 2022 11:20 AM > To: dev@dpdk.org; us...@dpdk.org; Yang, Qiming ; > Zhang, Qi Z > Cc: Huangshaozhang ; dingxiaoxiong > > Subject: [dpdk-dev] [dpdk-users] A question about the link status of the intel > E810 nic can no

Re: [dpdk-dev] [RFC PATCH] ethdev: mtr: enhance input color table features

2022-01-10 Thread Jerin Jacob
On Tue, Dec 7, 2021 at 11:52 PM Dumitrescu, Cristian wrote: > > HI Jerin, Hi Chistian, > > Sorry for my delay. I am currently in vacation until the beginning on January > 2022, so my response is slower than usual. I was too on vacation. > > Thanks for the explanation of the capabilities you

RE: [PATCH v2] net/ice: fix Tx Checksum offload

2022-01-10 Thread Zhang, Qi Z
> -Original Message- > From: Liu, KevinX > Sent: Sunday, December 12, 2021 10:35 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Liu, KevinX > ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix Tx Checksum offload > > The tunnel packets is missing some infor

Re: [RFC] mempool: modify flush threshold

2022-01-10 Thread Bruce Richardson
On Sat, Jan 08, 2022 at 12:00:17PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 7 January 2022 16.12 > > > > On Tue, Dec 28, 2021 at 03:28:45PM +0100, Morten Brørup wrote: > > > Hi mempool maintainers and DPDK team. > > > > > > Does a

RE: [PATCH] net/iavf: fix segmentation offload condition

2022-01-10 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Monday, November 22, 2021 11:30 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; Nicolau, Radu > > Subject: [PATCH] net/iavf: fix segmentation offload condition > > Apply segmentation offload when requested for

RE: Understanding Flow API action RSS

2022-01-10 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Sunday, January 9, 2022 3:03 PM > Subject: RE: Understanding Flow API action RSS > > Hi Ori, > > On Sun, 9 Jan 2022, Ori Kam wrote: > > > Hi Stephen and Ivan > > > >> -Original Message- > >> From: Stephen Hemminger > >>

RE: [PATCH] common/qat: enable gen4 b devices

2022-01-10 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, December 28, 2021 9:50 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] common/qat: enable gen4 b devices > > This commit enables CPM2.0b devices in Intel QuickAssis

RE: [PATCH] mempool: optimize incomplete cache handling

2022-01-10 Thread Morten Brørup
+Bruce; you seemed interested in my work in this area. > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Monday, 10 January 2022 08.27 > > On Fri, Jan 7, 2022 at 2:16 PM Morten Brørup > wrote: > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > Sent: Thursday, 6 January 202

Re: Rss hash on mellanox 100G card

2022-01-10 Thread Medvedkin, Vladimir
Hi Yaron, On 09/01/2022 13:20, Yaron Illouz wrote: I am using Mellanox Technologies MT27800 Family [ConnectX-5], using dpdk 19 with multi rx queue with rss port_conf.rx_adv_conf.rss_conf.rss_hf=(ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP) I analyze traffic and need all packet of same session to

axgbe PMD fixes and updates

2022-01-10 Thread ssebasti
Updates to axgbe pmd driver >From sseba...@amd.com # This line is ignored. From: sseba...@amd.com Reply-To: Subject: axgbe PMD fixes and updates In-Reply-To:

[PATCH v1 1/6] net/axgbe: always attempt link training in KR mode

2022-01-10 Thread ssebasti
From: Selwin Sebastian Link training is always attempted when in KR mode, but the code is structured to check if link training has been enabled before attempting to perform it.Since that check will always be true, simplify the code to always enable and start link training during KR auto-negotiati

[PATCH v1 2/6] net/axgbe: toggle PLL settings during rate change

2022-01-10 Thread ssebasti
From: Selwin Sebastian For each rate change command submission, the FW has to do a phy power off sequence internally. For this to happen correctly, the PLL re-initialization control setting has to be turned off before sending mailbox commands and re-enabled once the command submission is complete

[PATCH v1 3/6] net/axgbe: simplify mailbox interface rate change code

2022-01-10 Thread ssebasti
From: Selwin Sebastian Simplify and centralize the mailbox command rate change interface by having a single function perform the writes to the mailbox registers to issue the request. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 95 -- 1 f

[PATCH v1 6/6] net/axgbe: alter the port speed bit range

2022-01-10 Thread ssebasti
From: Selwin Sebastian Newer generation Hardware uses the slightly different port speed bit widths, so alter the existing port speed bit range to extend support to the newer generation hardware while maintaining the backward compatibility with older generation hardware. The previously reserved b

[PATCH v1 4/6] net/axgbe: reset PHY Rx when mailbox command timeout

2022-01-10 Thread ssebasti
From: Selwin Sebastian Sometimes mailbox commands timeout when the RX data path becomes unresponsive. This prevents the submission of new mailbox commands to DXIO. This patch identifies the timeout and resets the RX data path so that the next message can be submitted properly. Signed-off-by: Sel

[PATCH v1 5/6] net/axgbe: add support for new port mode

2022-01-10 Thread ssebasti
From: Selwin Sebastian Add support for a new port mode that is abackplane connection without support for auto negotiation. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c

RE: [PATCH] dma/idxd: fix burst capacity calculation

2022-01-10 Thread Pai G, Sunil
Hi Bruce, Kevin This patch seems to have uncovered a bug in the driver. On applying, the idxd_burst_capacity API seems to return 0 for cases even when there are batch descriptors and ring space available. Seems like there is a wraparound missing when calculating the descriptor ring space, causin

Re: [PATCH] dma/idxd: fix burst capacity calculation

2022-01-10 Thread Bruce Richardson
On Mon, Jan 10, 2022 at 01:09:02PM +, Pai G, Sunil wrote: > Hi Bruce, Kevin > > This patch seems to have uncovered a bug in the driver. > On applying, the idxd_burst_capacity API seems to return 0 for cases even > when there are batch descriptors and ring space available. > Seems like there i

RE: [PATCH] dma/idxd: fix burst capacity calculation

2022-01-10 Thread Pai G, Sunil
Hi Bruce, > what values for the write_idx and ids_returned vars give this error, and how > does masking help? I'd expect masking to increase the number of times the > function returns zero, rather than decreasing it. Here are the values from the idxd dump: dev_capa: 0x50051 - mem2mem sva han

RE: [PATCH v3 2/2] examples/l3fwd: add config file support for EM

2022-01-10 Thread Ananyev, Konstantin
> Add support to define ipv4 and ipv6 forwarding tables > from reading from a config file for EM with a format > similar to l3fwd-acl one. > > With the removal of the hardcoded route tables for IPv4 > and IPv6 from 'l3fwd_em', these routes have been moved > to a separate default config file fo

RE: [dpdk-dev] [PATCH] ring: fix error return value when creating ring

2022-01-10 Thread Ananyev, Konstantin
> The error value returned by rte_ring_create_elem() should be positive > integers. However, if the rte_ring_get_memsize_elem() function fails, > a negative number is returned and is directly used as the return value. > As a result, this will cause the external call to check the return > value to f

RE: [PATCH] ring: update Doxygen comments re RING_F_EXACT_SZ

2022-01-10 Thread Ananyev, Konstantin
> - Add RING_F_EXACT_SZ description to rte_ring_init and > rte_ring_create param comments. > - Fix ring size comments. > > Signed-off-by: Robert Sanford > --- Acked-by: Konstantin Ananyev > 2.7.4

Re: [PATCH v1] maintainers: update for testpmd

2022-01-10 Thread Ferruh Yigit
On 1/7/2022 9:10 AM, Li, Xiaoyun wrote: -Original Message- From: Zhang, Yuying Sent: Friday, January 7, 2022 16:54 To: dev@dpdk.org; Li, Xiaoyun ; Yigit, Ferruh ; tho...@monjalon.net Cc: Zhang, Yuying Subject: [PATCH v1] maintainers: update for testpmd Add Yuying Zhang as a co-maintain

RE: Understanding Flow API action RSS

2022-01-10 Thread Ivan Malov
Hi Ori, Many-many thanks for your commentary. The nature of 'queue' array in flow action RSS is clear now. I hope PMD vendors and API users share this vision, too. Propably, this should be properly documented. We'll see what we cad do in that direction. Please see one more question below. On M

RE: [PATCH 1/1] ring: fix off by 1 mistake

2022-01-10 Thread Ananyev, Konstantin
> When enqueueing/dequeueing to/from the ring we try to optimize by manual > loop unrolling. The check for this optimization looks like: > > if (likely(idx + n < size)) { > > where 'idx' points to the first usable element (empty slot for enqueue, > data for dequeue). The correct compariso

Re: [PATCH] dma/idxd: fix burst capacity calculation

2022-01-10 Thread Bruce Richardson
On Mon, Jan 10, 2022 at 01:44:06PM +, Pai G, Sunil wrote: > Hi Bruce, > > > what values for the write_idx and ids_returned vars give this error, and how > > does masking help? I'd expect masking to increase the number of times the > > function returns zero, rather than decreasing it. > > > H

RE: Understanding Flow API action RSS

2022-01-10 Thread Ori Kam
Hi Ian, > -Original Message- > From: Ivan Malov > Subject: RE: Understanding Flow API action RSS > > Hi Ori, > > Many-many thanks for your commentary. > > The nature of 'queue' array in flow action RSS is clear now. > I hope PMD vendors and API users share this vision, too. > Propably

[PATCH] net/sfc: validate queue span when parsing flow action RSS

2022-01-10 Thread Ivan Malov
The current code silently shrinks the value if it exceeds the supported maximum. Do not do that. Validate the value. Fixes: d77d07391d4d ("net/sfc: support flow API RSS action") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_flow.c | 8 +

RE: [PATCH v3] net/ixgbe: add vector Rx parameter check

2022-01-10 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, December 14, 2021 3:29 PM > To: Rong, Leyi ; Bin Zheng > ; dev@dpdk.org > Cc: lian...@liangbit.com; sta...@dpdk.org; jia@intel.com > Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check > > > -Original Messa

RE: [PATCH 1/1] mempool: implement index-based per core cache

2022-01-10 Thread Ananyev, Konstantin
> Current mempool per core cache implementation stores pointers to mbufs > On 64b architectures, each pointer consumes 8B > This patch replaces it with index-based implementation, > where in each buffer is addressed by (pool base address + index) > It reduces the amount of memory/cache require

RE: [RFC 1/3] ethdev: support GRE optional fields

2022-01-10 Thread Sean Zhang (Networking SW)
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Sunday, January 9, 2022 8:30 PM > To: Sean Zhang (Networking SW) ; Matan Azrad > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Ferruh Yigit ; Andrew > Rybchenko > Cc: dev@dpdk.org > Subject: RE: [RFC 1/3] ethdev: support GRE optional fi

[PATCH] app/testpmd: update raw flow to take hex input

2022-01-10 Thread nipun . gupta
From: Nipun Gupta This patch enables method to provide key and mask for raw rules to be provided as hexadecimal values. There is new parameter pattern_mask added to support this. Signed-off-by: Nipun Gupta --- app/test-pmd/cmdline_flow.c | 15 +++ doc/guides/testpmd

[PATCH] examples/l3fwd: fix Rx burst size for event mode

2022-01-10 Thread nipun . gupta
From: Nipun Gupta While dequeing the packets from the event device, burst size is provided in the API. This was not getting properly conigured in the application. This patch correctly configures the burst size. Fixes: aaf58cb85b62 ("examples/l3fwd: add event port and queue setup") Cc: sta...@dpd

[PATCH] vdpa/sfc: make MCDI memzone name unique

2022-01-10 Thread abhimanyu.saini
From: Abhimanyu Saini Buffer for MCDI channel is allocated using rte_memzone_reserve_aligned with zone name 'mcdi'. Since multiple MCDI channels are needed to support multiple VF(s) and rte_memzone_reserve_aligned expects unique zone names, append PCI address to zone name to make it unique. Sign

RE: [RFC 1/3] ethdev: support GRE optional fields

2022-01-10 Thread Ori Kam
Hi Sean, > -Original Message- > From: Sean Zhang (Networking SW) > Sent: Tuesday, January 11, 2022 5:45 AM > Subject: RE: [RFC 1/3] ethdev: support GRE optional fields > > Hi Ori, > > > -Original Message- > > From: Ori Kam > > Sent: Sunday, January 9, 2022 8:30 PM > > To: Sean

RE: [dpdk-dev] [dpdk-users] A question about Mellanox ConnectX-5 and ConnectX-4 Lx nic can't send packets?

2022-01-10 Thread Dmitry Kozlyuk
Hello, Thanks for attaching all the details. Can you please reproduce it with --log-level=pmd.common.mlx5:debug and send the logs? > For example, if the environment is configured with 10GB hugepages > but each hugepage is physically discontinuous, this problem > can be reproduced. What the hugep