RE: [PATCH v2 1/4] doc: arm64 cross build CFLAGS/LDFLAGS alternatives

2021-12-15 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Tuesday, December 7, 2021 7:05 PM > To: tho...@monjalon.net; david.march...@redhat.com; Honnappa > Nagarahalli ; Ruifeng Wang > ; ferruh.yi...@intel.com; jerinjac...@gmail.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v2 1/4] doc:

Re: [PATCH] ring: fix overflow in memory size calcuation

2021-12-15 Thread Liang Ma
On Tue, Dec 14, 2021 at 11:30:16AM +0800, Zhihong Wang wrote: > Parameters count and esize are both unsigned int, and their product can > legally exceed unsigned int and lead to runtime access violation. > > Fixes: cc4b218790f6 ("ring: support configurable element size") > Cc: sta...@dpdk.org > >

RE: [PATCH v2 2/4] doc: arm64 cross build binary names update

2021-12-15 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Tuesday, December 7, 2021 7:05 PM > To: tho...@monjalon.net; david.march...@redhat.com; Honnappa > Nagarahalli ; Ruifeng Wang > ; ferruh.yi...@intel.com; jerinjac...@gmail.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v2 2/4] doc:

Re: [PATCH v3] net/ixgbe: add vector Rx parameter check

2021-12-15 Thread Liang Ma
On Fri, Dec 10, 2021 at 04:22:09PM +0800, Bin Zheng wrote: > Under the circumstance that `rx_tail` wrap back to zero > and the advance speed of `rx_tail` is greater than `rxrearm_start`, > `rx_tail` will catch up with `rxrearm_start` and surpass it. > This may cause some mbufs be reused by applicat

[Bug 910] [build] meson build not support some c_args

2021-12-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=910 Bug ID: 910 Summary: [build] meson build not support some c_args Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

RE: [PATCH] ring: fix overflow in memory size calcuation

2021-12-15 Thread Morten Brørup
> From: Liang Ma [mailto:lian...@liangbit.com] > Sent: Wednesday, 15 December 2021 09.01 > > On Tue, Dec 14, 2021 at 11:30:16AM +0800, Zhihong Wang wrote: > > Parameters count and esize are both unsigned int, and their product > can > > legally exceed unsigned int and lead to runtime access violat

RE: [PATCH v2 3/4] doc: arm64 cross build numactl compilers

2021-12-15 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Tuesday, December 7, 2021 7:05 PM > To: tho...@monjalon.net; david.march...@redhat.com; Honnappa > Nagarahalli ; Ruifeng Wang > ; ferruh.yi...@intel.com; jerinjac...@gmail.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v2 3/4] doc:

RE: [PATCH v2 4/4] docs: add an example arm64 cross file

2021-12-15 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Tuesday, December 7, 2021 7:05 PM > To: tho...@monjalon.net; david.march...@redhat.com; Honnappa > Nagarahalli ; Ruifeng Wang > ; ferruh.yi...@intel.com; jerinjac...@gmail.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v2 4/4] docs

Re: [PATCH 01/12] net: add string to IPv4 parse function

2021-12-15 Thread Bruce Richardson
On Tue, Dec 14, 2021 at 06:31:06PM +0100, Morten Brørup wrote: > > From: Ronan Randles [mailto:ronan.rand...@intel.com] > > Sent: Tuesday, 14 December 2021 15.13 > > > > Added function that accepts ip string as a parameter and returns an ip > > address represented by a uint32_t. Relevant unit test

RE: [PATCH 01/12] net: add string to IPv4 parse function

2021-12-15 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 15 December 2021 10.27 > > On Tue, Dec 14, 2021 at 06:31:06PM +0100, Morten Brørup wrote: > > > From: Ronan Randles [mailto:ronan.rand...@intel.com] > > > Sent: Tuesday, 14 December 2021 15.13 > > > > > > Added functio

Re: [PATCH 01/12] net: add string to IPv4 parse function

2021-12-15 Thread Bruce Richardson
On Wed, Dec 15, 2021 at 10:35:44AM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Wednesday, 15 December 2021 10.27 > > > > On Tue, Dec 14, 2021 at 06:31:06PM +0100, Morten Brørup wrote: > > > > From: Ronan Randles [mailto:ronan.rand...@intel.c

RE: 19.11.11 patches review and test

2021-12-15 Thread Jiang, YuX
> -Original Message- > From: Jiang, YuX > Sent: Tuesday, December 14, 2021 3:14 PM > To: christian.ehrha...@canonical.com; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Govindharajan, Hariprasad > ; Hemant A

[Bug 795] [dpdk-19.11] unit_tests_power/power_cpufreq: unit test failed

2021-12-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=795 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

Re: [PATCH v4 1/2] net: add functions to calculate UDP/TCP cksum in mbuf

2021-12-15 Thread Singh, Aman Deep
On 12/3/2021 5:08 PM, Xiaoyun Li wrote: Add functions to call rte_raw_cksum_mbuf() to calculate IPv4/6 UDP/TCP checksum in mbuf which can be over multi-segments. Signed-off-by: Xiaoyun Li --- doc/guides/rel_notes/release_22_03.rst | 10 ++ lib/net/rte_ip.h | 186

Re: [PATCH v3] eal: allow to exclude memseg from core dump

2021-12-15 Thread Jerin Jacob
On Tue, Dec 14, 2021 at 8:49 PM Gaoxiang Liu wrote: > > Some DPDK application is allocated storage partition of 8G(or smaller) > If coredump happens, the application doesn't work because of > insufficient storage space. > The patch provides a config that means whether the memseg memory > is allowe

Re: [PATCH 00/12] add packet generator library and example app

2021-12-15 Thread Jerin Jacob
On Tue, Dec 14, 2021 at 7:42 PM Ronan Randles wrote: > > This patchset introduces a Gen library for DPDK. This library provides an easy > way to generate traffic in order to test software based network components. > > This library enables the basic functionality required in the traffic > generato

Re: [PATCH 05/12] gen: add raw packet data API and tests

2021-12-15 Thread Jerin Jacob
On Tue, Dec 14, 2021 at 7:43 PM Ronan Randles wrote: > > From: Harry van Haaren > > This commit adds a new API to gen, allowing the caller to set > raw packet data with a size. Tests are added to test the new > API with randomized packet data. > > Signed-off-by: Harry van Haaren > --- > } > > @

RE: [PATCH 02/12] net: add function to pretty print IPv4

2021-12-15 Thread Ananyev, Konstantin
> > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 15 December 2021 04.21 > > > > On Wed, 15 Dec 2021 01:06:14 + > > "Ananyev, Konstantin" wrote: > > > > > > -Original Message- > > > > From: Morten Brørup > > > > Sent: Tuesday, December 14, 2021 5

Re: 19.11.11 patches review and test

2021-12-15 Thread Christian Ehrhardt
On Wed, Dec 15, 2021 at 12:04 PM Jiang, YuX wrote: > > > -Original Message- > > From: Jiang, YuX > > Sent: Tuesday, December 14, 2021 3:14 PM > > To: christian.ehrha...@canonical.com; sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Akhil Goyal ; Ali Alnubani ; > > Walker, Ben

Re: 19.11.11 patches review and test

2021-12-15 Thread Christian Ehrhardt
On Tue, Dec 14, 2021 at 3:52 PM Ferruh Yigit wrote: > > On 12/14/2021 2:46 PM, Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt > > wrote: > >> > >> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit > >> wrote: > >>> > >>> On 12/14/2021 11:39 AM, Christian Ehrhardt wr

RE: [PATCH] ring: fix overflow in memory size calcuation

2021-12-15 Thread Ananyev, Konstantin
> Parameters count and esize are both unsigned int, and their product can > legally exceed unsigned int and lead to runtime access violation. > > Fixes: cc4b218790f6 ("ring: support configurable element size") > Cc: sta...@dpdk.org > > Signed-off-by: Zhihong Wang > --- > lib/ring/rte_ring.c

Re: [PATCH 00/12] add packet generator library and example app

2021-12-15 Thread Bruce Richardson
On Wed, Dec 15, 2021 at 06:01:23PM +0530, Jerin Jacob wrote: > On Tue, Dec 14, 2021 at 7:42 PM Ronan Randles wrote: > > > > This patchset introduces a Gen library for DPDK. This library provides an > > easy > > way to generate traffic in order to test software based network components. > > > > Th

Re: [PATCH v3] eal: allow to exclude memseg from core dump

2021-12-15 Thread Dmitry Kozlyuk
2021-12-15 17:36 (UTC+0530), Jerin Jacob: [...] > > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c > > index 68ae93bd6e..44227aee95 100644 > > --- a/lib/eal/unix/eal_unix_memory.c > > +++ b/lib/eal/unix/eal_unix_memory.c > > @@ -83,10 +83,13 @@ eal_mem_set_dump(void *v

Re: 19.11.11 patches review and test

2021-12-15 Thread Ferruh Yigit
On 12/15/2021 1:17 PM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 3:52 PM Ferruh Yigit wrote: On 12/14/2021 2:46 PM, Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt wrote: On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit wrote: On 12/14/2021 11:39 AM, Chr

Re: 20.11.4 patches review and test

2021-12-15 Thread Xueming(Steven) Li
On Fri, 2021-12-10 at 11:35 +, Jiang, YuX wrote: > > -Original Message- > > From: Jiang, YuX > > Sent: Thursday, December 9, 2021 6:01 PM > > To: Xueming Li ; sta...@dpdk.org; Lin, Xueqin > > > > Cc: dev@dpdk.org; Abhishek Marathe > > ; > > Ali Alnubani ; Walker, Benjamin > > ; David

Re: 20.11.4 patches review and test

2021-12-15 Thread Xueming(Steven) Li
Hi Pei, Appreciate you and Redhat contribution! On Mon, 2021-12-13 at 22:27 +0800, Pei Zhang wrote: > Hello Xueming, > > The testing with dpdk 20.11.4-rc1 from Red Hat looks good. We tested > below 20 scenarios and all got PASS on RHEL8: > > (1)Guest with device assignment(PF) throughput testin

Re: [PATCH v3] eal: allow to exclude memseg from core dump

2021-12-15 Thread Dmitry Kozlyuk
2021-12-14 23:18 (UTC+0800), Gaoxiang Liu: > Some DPDK application is allocated storage partition of 8G(or smaller) > If coredump happens, the application doesn't work because of > insufficient storage space. > The patch provides a config that means whether the memseg memory > is allowed to exclude

[PATCH 0/7] net/bonding: fixes and LACP short timeout

2021-12-15 Thread Robert Sanford
This patchset makes the following changes to net/bonding: - Clean up minor errors in spelling, whitespace, C++ wrappers, and comments. - Replace directly overwriting of slave port's rte_eth_conf by copying it, but only updating it via rte_eth_dev_configure(). - Make minor changes to allocation

[PATCH 1/7] net/bonding: fix typos and whitespace

2021-12-15 Thread Robert Sanford
- Clean up minor typos in comments, strings, and private names. - Fix whitespace in log messages and function formatting (open brace after a new line). - Move closing C++ wrapper to the end of rte_eth_bond_8023ad.h. Signed-off-by: Robert Sanford --- app/test-pmd/cmdline.c

[PATCH 2/7] net/bonding: fix bonded dev configuring slave dev

2021-12-15 Thread Robert Sanford
- Replace directly overwriting of slave port's private rte_eth_conf by copying it, and then updating it via rte_eth_dev_configure(). Signed-off-by: Robert Sanford --- drivers/net/bonding/rte_eth_bond_pmd.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-)

[PATCH 3/7] net/bonding: change mbuf pool and ring allocation

2021-12-15 Thread Robert Sanford
- Turn off mbuf pool caching to avoid mbufs lingering in pool caches. At most, we transmit one LACPDU per second, per port. - Fix calculation of ring sizes, taking into account that a ring of size N holds up to N-1 items. Signed-off-by: Robert Sanford --- drivers/net/bonding/rte_eth_bond_802

[PATCH 4/7] net/bonding: support enabling LACP short timeout

2021-12-15 Thread Robert Sanford
- Add support for enabling LACP short timeout, i.e., link partner can use fast periodic time interval between transmits. Signed-off-by: Robert Sanford --- drivers/net/bonding/eth_bond_8023ad_private.h | 3 ++- drivers/net/bonding/rte_eth_bond_8023ad.c | 28 +++ dri

[PATCH 5/7] net/bonding: add LACP short timeout to tests

2021-12-15 Thread Robert Sanford
- Add "set bonding lacp timeout_ctrl on|off" to testpmd. - Add "test_mode4_lacp_timeout_control" to app/test. Signed-off-by: Robert Sanford --- app/test-pmd/cmdline.c | 77 ++ app/test/test_link_bonding_mode4.c | 65 +++

[PATCH 6/7] net/bonding: add bond_8023ad and bond_alb to doc

2021-12-15 Thread Robert Sanford
- Add bond_8023ad and bond_alb to API documentation. Signed-off-by: Robert Sanford --- doc/api/doxy-api-index.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index 4245b96..830235c 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api

[PATCH 7/7] Remove self from Timers maintainers.

2021-12-15 Thread Robert Sanford
Signed-off-by: Robert Sanford --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 18d9eda..32663b0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1613,7 +1613,6 @@ F: examples/vm_power_manager/ F: doc/guides/sample_app_ug/vm_power_management.rst

[dpdk-kmods] linux/igb_uio: fix build for switch fall through

2021-12-15 Thread Ferruh Yigit
Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't take any fall through comments into account but only uses compiler 'fallthrough' attribute to document fall through action is intended. "falls through" comment was used in the code which is causing a build error now, this pat

Re: [dpdk-kmods] linux/igb_uio: fix build for switch fall through

2021-12-15 Thread Stephen Hemminger
On Wed, 15 Dec 2021 18:48:59 + Ferruh Yigit wrote: > Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't > take any fall through comments into account but only uses compiler > 'fallthrough' attribute to document fall through action is intended. > > "falls through" commen

Re: [dpdk-kmods] linux/igb_uio: fix build for switch fall through

2021-12-15 Thread Ferruh Yigit
On 12/15/2021 7:20 PM, Stephen Hemminger wrote: On Wed, 15 Dec 2021 18:48:59 + Ferruh Yigit wrote: Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't take any fall through comments into account but only uses compiler 'fallthrough' attribute to document fall through ac

Re: [dpdk-kmods] linux/igb_uio: fix build for switch fall through

2021-12-15 Thread Stephen Hemminger
On Wed, 15 Dec 2021 21:04:30 + Ferruh Yigit wrote: > On 12/15/2021 7:20 PM, Stephen Hemminger wrote: > > On Wed, 15 Dec 2021 18:48:59 + > > Ferruh Yigit wrote: > > > >> Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't > >> take any fall through comments into ac

[PATCH v1] net/iavf: remove the extra symbol '+'

2021-12-15 Thread Haiyue Wang
This extra symbol '+' should be added when patch was reapplied, and the compiler treats it as unsigned type, so the code still runs well. Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_vchnl

RE: [PATCH v1] net/iavf: remove the extra symbol '+'

2021-12-15 Thread Xing, Beilei
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, December 16, 2021 12:44 PM > To: dev@dpdk.org > Cc: Wang, Haiyue ; sta...@dpdk.org; Wu, Jingjing > ; Xing, Beilei ; Sinha, Abhijit > ; Doherty, Declan ; > Nicolau, Radu > Subject: [PATCH v1] net/iavf: remove the extra symbol '

RE: 20.11.4 patches review and test

2021-12-15 Thread Jiang, YuX
> -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, December 15, 2021 10:45 PM > To: Lin, Xueqin ; Jiang, YuX ; > sta...@dpdk.org > Cc: Stokes, Ian ; dev@dpdk.org; > ktray...@redhat.com; abhishek.mara...@microsoft.com; > d...@linux.vnet.ibm.com; NBU-Contact-Thomas Monjalon (

NVIDIA roadmap for 22.03

2021-12-15 Thread Lior Margalit
Please find below NVIDIA roadmap for 22.03 release: rte_flow new APIs: [1] Support for template API (item and action) to optimize the insertion rate. The combination of item and action templates along with shared flow rule attributes allows the PMD/HW to prepare all the reso

Re: 19.11.11 patches review and test

2021-12-15 Thread Christian Ehrhardt
On Wed, Dec 15, 2021 at 3:44 PM Ferruh Yigit wrote: > > On 12/15/2021 1:17 PM, Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 3:52 PM Ferruh Yigit wrote: > >> > >> On 12/14/2021 2:46 PM, Christian Ehrhardt wrote: > >>> On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt > >>> wrote: >