RE: [PATCH] compress/mlx5: fix double close for context device

2021-11-25 Thread Matan Azrad
From: Michael Baum > The context of the device opens once in the common probe and closes with > its removal. > > If the probe of one of the drivers fails, it releases its resources and then > the > common closes the context. > But mistakenly in the compress probe, if ther isn't enough capabili

Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

2021-11-25 Thread Awan, Arsalan
Hi Chandu, Do we have an update on this? Can we go ahead with this patch for now as it does not break anything else, but fixes the problem. DPDK will be working fine as is on the e3000. This patch only adjusts the code for the v1000 and it works fine and there isn't a difference in the approa

[PATCH v2] compress/mlx5: fix double close for context device

2021-11-25 Thread michaelba
From: Michael Baum The context of the device opens once in the common probe and closes with its removal. If the probe of one of the drivers fails, it releases its resources and then the common closes the context. But mistakenly in the compress probe, if there isn't enough capabilities to support

RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

2021-11-25 Thread Namburu, Chandu-babu
[Public] Hi Arsalan, We have identified fix for this issue and will submit the patch for community review asap. Thanks, Chandu -Original Message- From: Awan, Arsalan Sent: Thursday, November 25, 2021 1:42 PM To: Namburu, Chandu-babu ; dev@dpdk.org Cc: Somalapuram, Amaranath ; Sebastia

Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

2021-11-25 Thread Awan, Arsalan
Thanks, Chandu! This will help a lot! Regards, Arsalan From: Namburu, Chandu-babu Sent: Thursday, November 25, 2021 1:23 PM To: Awan, Arsalan; dev@dpdk.org Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy Subject: RE: [PATCH] ne

Re: [PATCH] common/mlx5: fix error handling in multi-class probe

2021-11-25 Thread Thomas Monjalon
24/11/2021 23:02, michae...@nvidia.com: > From: Michael Baum > > The common drivers_probe function calls in a loop to all probe functions > for classes requested by the user. After it manages to probe them all, > it updates this on the device in the "classes_loaded" field. > > If one of them fai

Re: [PATCH] net/mlx5: fix devargs validation for multiclass probe

2021-11-25 Thread Thomas Monjalon
25/11/2021 07:16, michae...@nvidia.com: > From: Michael Baum > > The mlx5_args function reads the devargs and checks if they are valid > for this driver and if not it returns an error. > > This was normal behavior as long as all the devargs come to this driver, > but since it is possible to run

Re: [dpdk-dev] [pull-request] dpdk-next-eventdev - v21.11 rc4

2021-11-25 Thread Thomas Monjalon
23/11/2021 17:47, Jerin Jacob Kollanukkaran: > The following changes since commit 0c6e27549c03695f85d949f5195a166b449b419c: > > version: 21.11-rc3 (2021-11-17 20:19:47 +0100) > > are available in the Git repository at: > > http://dpdk.org/git/next/dpdk-next-eventdev > > for you to fetch cha

Re: [dpdk-dev] [PATCH] maintainers: update for driver testing tool

2021-11-25 Thread Thomas Monjalon
22/10/2021 10:57, Ferruh Yigit: > On 10/22/2021 8:19 AM, Aman Singh wrote: > > For test-pmd adding Aman Singh > > > > Signed-off-by: Aman Singh > > Thanks Aman for volunteering. > > Acked-by: Ferruh Yigit I'll take this opportunity to update the section title. v2 coming.

[PATCH v2] maintainers: update for testpmd

2021-11-25 Thread Thomas Monjalon
From: Aman Singh Add Aman Singh as co-maintainer of testpmd. Make the title description more accurate for this tool. Signed-off-by: Aman Singh Acked-by: Ferruh Yigit Signed-off-by: Thomas Monjalon --- v2: update the section title --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 d

RE: [PATCH] MAINTAINERS: update entry for compressdev

2021-11-25 Thread Zhang, Roy Fan
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, October 6, 2021 5:26 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Zhang, Roy Fan > ; ashish.gu...@marvell.com > Subject: [PATCH] MAINTAINERS: update entry for compressdev > > Replacing myself with Fan as compressdev API maintainer

RE: [EXT] [PATCH v2] compress/mlx5: fix double close for context device

2021-11-25 Thread Akhil Goyal
> From: Michael Baum > > The context of the device opens once in the common probe and closes with > its removal. > > If the probe of one of the drivers fails, it releases its resources and > then the common closes the context. > But mistakenly in the compress probe, if there isn't enough capabil

RE: [EXT] [PATCH] examples/ipsec-secgw: set L4 length for TSO packets

2021-11-25 Thread Akhil Goyal
> Using RTE_MBUF_F_TX_TCP_SEG requires L4 length to be set. > Fixes: a7f32947a316 ("examples/ipsec-secgw: support TCP TSO") > > Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal > --- Applied to dpdk-next-crypto Thanks.

RE: [PATCH] common/mlx5: fix error handling in multi-class probe

2021-11-25 Thread Matan Azrad
From: Thomas Monjalon > 24/11/2021 23:02, michae...@nvidia.com: > > From: Michael Baum > > > > The common drivers_probe function calls in a loop to all probe > > functions for classes requested by the user. After it manages to probe > > them all, it updates this on the device in the "classes_lo

RE: [PATCH] net/mlx5: fix devargs validation for multiclass probe

2021-11-25 Thread Matan Azrad
From: Thomas Monjalon > 25/11/2021 07:16, michae...@nvidia.com: > > From: Michael Baum > > > > The mlx5_args function reads the devargs and checks if they are valid > > for this driver and if not it returns an error. > > > > This was normal behavior as long as all the devargs come to this > > d

Re: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok

2021-11-25 Thread Thomas Monjalon
22/10/2021 02:11, Jerin Jacob: > On Wed, Oct 20, 2021 at 7:58 PM Andrew Rybchenko > wrote: > > On 10/20/21 5:26 PM, Bruce Richardson wrote: > > > Since we allow line lengths of up to 100, and the CI checkpatches job > > > only check for that amount, the rest of our tooling and docs should > > > re

Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control

2021-11-25 Thread Jerin Jacob
On Wed, Nov 24, 2021 at 9:30 PM Ori Kam wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, November 24, 2021 12:48 PM > > > > On Wed, Nov 24, 2021 at 3:01 PM Ori Kam wrote: > > > > > > Hi Jerin, > > > > > > > -Original Message- > > > > From: Jerin Jaco

Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-11-25 Thread Thomas Monjalon
17/09/2021 13:03, Jerin Jacob: > On Fri, Sep 17, 2021 at 4:32 PM Ashwin Sekhar T K wrote: > > > > Update word list with Marvell specific acronyms. > > > > CPT -> Cryptographic Accelerator Unit > > CQ -> Completion Queue > > LBK -> Loopback Interface Unit > > LMT -> Large Atomic Store Unit > >

Re: [PATCH] devtools: add acronyms in dictionary for commit checks

2021-11-25 Thread Thomas Monjalon
10/11/2021 18:41, Ferruh Yigit: > FD -> File Descriptor > GUID-> Globally Unique Identifier > Netlink -> Linux Netlink socket family > PCIe-> Peripheral Component Interconnect Express > > Signed-off-by: Ferruh Yigit Applied, thanks.

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was introduced by [1]. This action provides an unified way to perform various arithmetic and transfer operations over packet network header fields and packet metadata. [1] commit 641dbe4fb053

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Somnath Kotur
On Thu, Nov 25, 2021 at 5:23 PM Ferruh Yigit wrote: > > On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > > introduced by [1]. This action provides an unified way > > to perform various arithmetic and transfer operations over > > pack

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are are not populated in the primary during the probe they are populated during the queue_setup, add

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: @@ -3331,6 +3430,9 @@ struct rte_flow_action_set_tag { }; /** + * @deprecated + * @see RTE_FLOW_ACTION_TYPE_MODIFY_FIELD + * * @warning * @b EXPERIMENTAL: this structure may change without prior notice * @@ -3355,6 +3457,9 @@ str

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ori Kam
Hi > -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 25, 2021 2:19 PM > Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow > actions > > On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: > > @@ -3331,6 +3430,9 @@ struct rte_flow_action_set_tag

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 6d087c64ef..d04a606b7d 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -101,6 +101,20 @@ Deprecation N

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 12:29 PM, Ori Kam wrote: Hi -Original Message- From: Ferruh Yigit Sent: Thursday, November 25, 2021 2:19 PM Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: @@ -3331,6 +3430,9 @@ struct

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Thomas Monjalon
25/11/2021 13:31, Ferruh Yigit: > On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index 6d087c64ef..d04a606b7d 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_note

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Thomas Monjalon
25/11/2021 12:53, Ferruh Yigit: > On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > > introduced by [1]. This action provides an unified way > > to perform various arithmetic and transfer operations over > > packet network header field

[PATCH] examples/ipsec-secgw: wrong offload flag used for TSO IPv6

2021-11-25 Thread Radu Nicolau
RTE_MBUF_F_TX_OUTER_IP_CKSUM should not be set for IPv6 packets. Fixes: a7f32947a316 ("examples/ipsec-secgw: support TCP TSO") Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec_process.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec

[PATCH] update Intel roadmap for 22.03

2021-11-25 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- Cc: John McNamara The patch will need a rebase after v21.11, sending anyway to share the roadmap early with community. --- content/roadmap/_index.md | 10 ++ 1 file changed, 10 insertions(+) diff --git a/content/roadmap/_index.md b/content/roadmap/_index

Re: [PATCH v2] maintainers: update for testpmd

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 10:01 AM, Thomas Monjalon wrote: From: Aman Singh Add Aman Singh as co-maintainer of testpmd. Make the title description more accurate for this tool. Signed-off-by: Aman Singh Acked-by: Ferruh Yigit Signed-off-by: Thomas Monjalon --- v2: update the section title --- MAINTAI

RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 25, 2021 13:54 > To: Andrew Rybchenko ; Ajit Khaparde > ; Somnath Kotur > ; Rahul Lakkireddy > ; Slava Ovsiienko > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > dev@dpdk.org > Subject: Re: [PATCH v3] ethdev: deprecate h

RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 25, 2021 2:47 PM > To: Ori Kam ; Slava Ovsiienko > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; David > Marchand > ; Andrew Rybchenko ; > dev@dpdk.org; Ray Kinsella > Subject: Re: [PATCH v3] ethdev: deprecate header

RE: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control

2021-11-25 Thread Ori Kam
Hi Jerin, I think that we are not on the same page and I'm missing some critical info to decide on the best approch. Can we please have a short meeting so you can explain to me about this feature? I think it will be good if Thomas, Ferruh and Andrew could join. Best, Ori > -Original Messa

RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, November 25, 2021 15:07 > To: Andrew Rybchenko ; Ajit Khaparde > ; Somnath Kotur > ; Rahul Lakkireddy > ; Slava Ovsiienko ; > Ferruh Yigit > Cc: dev@dpdk.org; Ori Kam > Subject: Re: [PATCH v3] ethdev: deprecate header fields

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 1:06 PM, Thomas Monjalon wrote: 25/11/2021 12:53, Ferruh Yigit: On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was introduced by [1]. This action provides an unified way to perform various arithmetic and transfer operations

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 1:56 PM, Ori Kam wrote: -Original Message- From: Ferruh Yigit Sent: Thursday, November 25, 2021 2:47 PM To: Ori Kam ; Slava Ovsiienko Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; David Marchand ; Andrew Rybchenko ; dev@dpdk.org; Ray Kinsella Subject: Re: [PATCH v3] eth

[PATCH v1] gpudev: remove unnecessary rte_gpu_wmb

2021-11-25 Thread eagostini
From: Elena Agostini Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts. It causes a performance degradation in case of NVIDIA GPU V100. This change doesn't affect any functionality as the status resides in CPU registered memory. Fixes: c7ebd65c1372 ("gpudev: add communication

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 2:13 PM, Slava Ovsiienko wrote: -Original Message- From: Thomas Monjalon Sent: Thursday, November 25, 2021 15:07 To: Andrew Rybchenko ; Ajit Khaparde ; Somnath Kotur ; Rahul Lakkireddy ; Slava Ovsiienko ; Ferruh Yigit Cc: dev@dpdk.org; Ori Kam Subject: Re: [PATCH v3] ethd

RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 25, 2021 16:41 > To: Slava Ovsiienko ; NBU-Contact-Thomas > Monjalon (EXTERNAL) ; Andrew Rybchenko > ; Ajit Khaparde > ; Somnath Kotur > ; Rahul Lakkireddy > > Cc: dev@dpdk.org; Ori Kam > Subject: Re: [PATCH v3] ethdev:

[PATCH v3] app/test-gpudev: remove all memory leaks

2021-11-25 Thread eagostini
From: Elena Agostini Remove all memory leaks in case of errors in test-gpudev application. Fixes: e818c4e2bf50 ("gpudev: add memory API") Fixes: c7ebd65c1372 ("gpudev: add communication list") Signed-off-by: Elena Agostini --- app/test-gpudev/main.c | 17 - 1 file changed, 16

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 1:56 PM, Slava Ovsiienko wrote: -Original Message- From: Ferruh Yigit Sent: Thursday, November 25, 2021 13:54 To: Andrew Rybchenko ; Ajit Khaparde ; Somnath Kotur ; Rahul Lakkireddy ; Slava Ovsiienko Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; dev@dpdk.org Subject: Re: [P

Re: [PATCH v2] maintainers: update for testpmd

2021-11-25 Thread Thomas Monjalon
25/11/2021 14:40, Ferruh Yigit: > On 11/25/2021 10:01 AM, Thomas Monjalon wrote: > > -Driver testing tool > > +Networking features testing tool > > "Networking features" scope is a little wide. > Not sure if "Networking features" or "Networking drivers" suits better, > according previous title it

Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions

2021-11-25 Thread Thomas Monjalon
25/11/2021 16:14, Ferruh Yigit: > On 11/25/2021 1:56 PM, Slava Ovsiienko wrote: > > From: Ferruh Yigit > >> On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: > >>> The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > >> introduced by > >>> [1]. This action provides an unified way to perform

Re: [PATCH v2] maintainers: update for testpmd

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 3:20 PM, Thomas Monjalon wrote: 25/11/2021 14:40, Ferruh Yigit: On 11/25/2021 10:01 AM, Thomas Monjalon wrote: -Driver testing tool +Networking features testing tool "Networking features" scope is a little wide. Not sure if "Networking features" or "Networking drivers" suits bet

RE: release candidate 21.11-rc4

2021-11-25 Thread Stokes, Ian
> Hi all, > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v21.11-rc4 > > There are 46 new patches in this snapshot, for last critical fixes and > some documentation updates. > > Release notes: > https://doc.dpdk.org/guides/rel_notes/rele

Re: [PATCH v2] maintainers: update for testpmd

2021-11-25 Thread Ferruh Yigit
On 11/25/2021 4:04 PM, Ferruh Yigit wrote: On 11/25/2021 3:20 PM, Thomas Monjalon wrote: 25/11/2021 14:40, Ferruh Yigit: On 11/25/2021 10:01 AM, Thomas Monjalon wrote: -Driver testing tool +Networking features testing tool "Networking features" scope is a little wide. Not sure if "Networking

Re: [PATCH v11 0/5] drivers/net: add NXP ENETFEC driver

2021-11-25 Thread Ferruh Yigit
On 11/15/2021 3:05 PM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with p

Re: [PATCH v2] maintainers: update for testpmd

2021-11-25 Thread Thomas Monjalon
25/11/2021 17:31, Ferruh Yigit: > On 11/25/2021 4:04 PM, Ferruh Yigit wrote: > > On 11/25/2021 3:20 PM, Thomas Monjalon wrote: > >> 25/11/2021 14:40, Ferruh Yigit: > >>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote: > -Driver testing tool > +Networking features testing tool > >>> > >>> "

Re: [PATCH] devtools/cocci: add script for ethdev namespace

2021-11-25 Thread Ferruh Yigit
On 11/23/2021 8:47 AM, Aman Singh wrote: The cocci script is to help add prefix 'RTE_ETH' namespace to enum & macro of ethdev library. It helps in automating these changes for applications. The script won't make changes in the code comment part. Usage: spatch

[PATCH] common/mlx5: fix MR lookup on slow path

2021-11-25 Thread Dmitry Kozlyuk
Memory region (MR) was being looked up incorrectly for the data address of an externally-attached mbuf. A search was attempted for the mempool of the mbuf, while mbuf data address does not belong to this mempool in case of externally-attached mbuf. Only attempt the search: 1) for not externally-att

RE: [PATCH v2] net/ice: track the DCF state of PF

2021-11-25 Thread Wang, Haiyue
> -Original Message- > From: Yu, DapengX > Sent: Wednesday, November 24, 2021 16:12 > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; > sta...@dpdk.org > Subject: [PATCH v2] net/ice: track the DCF state of PF > > From: Dapeng Yu > > When VF is reset,

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control

2021-11-25 Thread Jerin Jacob
On Thu, Nov 25, 2021 at 7:32 PM Ori Kam wrote: > > Hi Jerin, > > I think that we are not on the same page and I'm missing some critical info > to decide > on the best approch. > > Can we please have a short meeting so you can explain to me about this > feature? > > I think it will be good if Tho