22/10/2021 02:11, Jerin Jacob: > On Wed, Oct 20, 2021 at 7:58 PM Andrew Rybchenko > <andrew.rybche...@oktetlabs.ru> wrote: > > On 10/20/21 5:26 PM, Bruce Richardson wrote: > > > Since we allow line lengths of up to 100, and the CI checkpatches job > > > only check for that amount, the rest of our tooling and docs should > > > reflect this reality. Therefore we can: > > > > > > * adjust the editorconfig to use that value, to save editors (e.g. vim) > > > from automatically wrapping lines at 80 characters when typing. > > > [Since python checkers all seem to expect 79 character lines max, add > > > for python only a 79-char max line length.] > > > > > > * change the default line length setting in checkpatches script to 100 > > > so as it matches CI and pre-merge checks. > > > > > > * update the docs to clarify that while 80 chars is recommended, up to > > > 100 characters is acceptable. > > > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > > > Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > > Acked-by: Jerin Jacob <jer...@marvell.com>
Acked-by: Chenbo Xia <chenbo....@intel.com> Acked-by: Chengwen Feng <fengcheng...@huawei.com> Acked-by: Conor Walsh <conor.wa...@intel.com> As long as we keep a preference/recommandation for 80 chars, I'm fine. In general I like short lines, but I dislike some "forced" wrapping. So allowing for longer lines and trusting authors to do what fits best is a good call. Acked-by: Thomas Monjalon <tho...@monjalon.net> Applied, thanks.
