[PATCH] ethdev: deprecate header fields and metadata flow actions

2021-11-23 Thread Viacheslav Ovsiienko
There generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was introduced by [1]. This action provides the unified way to perform various arithmetic and transfer operations over packet network header fields and packet metadata. [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow action") On

RE: [PATCH] crypto/ipsec_mb: fix cipher key setting

2021-11-23 Thread Power, Ciara
>-Original Message- >From: De Lara Guarch, Pablo >Sent: Monday 22 November 2021 17:47 >To: Zhang, Roy Fan ; Power, Ciara > >Cc: dev@dpdk.org; De Lara Guarch, Pablo ; >sta...@dpdk.org >Subject: [PATCH] crypto/ipsec_mb: fix cipher key setting > >When authenticating with SNOW3G, KASUMI and ZU

[PATCH] devtools/cocci: add script for ethdev namespace

2021-11-23 Thread Aman Singh
The cocci script is to help add prefix 'RTE_ETH' namespace to enum & macro of ethdev library. It helps in automating these changes for applications. The script won't make changes in the code comment part. Usage: spatch

[PATCH] app/testpmd: fix hex string parser input length

2021-11-23 Thread Gregory Etelson
Current hex string parser assumes input has even characters number. The parser fails input string with odd length. The patch parses hex stringhs with even and odd length. Cc: sta...@dpdk.org Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Signed-off-by: Gregory Et

[PATCH v3] doc: add mlx5 PMD flex item documentation

2021-11-23 Thread Gregory Etelson
Describe firmware configuration requirements. List mlx5 hardware and PMD limitations. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko Acked-by: Raslan Darawsheh --- v2: Style fixes. v3: Update hardware and port support. --- doc/guides/nics/mlx5.rst | 17 + 1 file

Re: [PATCH] kni: fix kernel deadlock due to async changes

2021-11-23 Thread Ferruh Yigit
On 10/11/2021 7:35 AM, Sahithi Singam wrote: From: Sahithi Singam mailto:sahithi.sin...@oracle.com>> Async user request changes resulted in a kernel deadlock when used with linux kernel version>= 5.12. Starting from linux kernel version 5.12, a new global semaphore dev_addr_sem was introduced

Re: [PATCH] kni: restrict bifurcated device support

2021-11-23 Thread Ferruh Yigit
On 10/9/2021 3:03 AM, Stephen Hemminger wrote: On Sat, 9 Oct 2021 00:58:30 +0100 Ferruh Yigit wrote: To enable bifurcated device support, rtnl_lock is released before calling userspace callbacks and asynchronous requests are enabled. But these changes caused more issues, like bug #809, #816.

Re: [dpdk-dev] [PATCH] doc: note KNI alternatives and deprecation plan

2021-11-23 Thread Ferruh Yigit
On 7/30/2021 1:48 PM, Olivier Matz wrote: Hi Ferruh, Few minor comments below. On Wed, Jun 23, 2021 at 06:31:42PM +0100, Ferruh Yigit wrote: Add a note that KNI kernel module will be moved to dpdk-kmods git repo and there is a long term plan to deprecate it. Also add some more details on the

Re: [PATCH] kvargs: fix device iterator match from arguments

2021-11-23 Thread Olivier Matz
Hi Xueming, On Mon, Nov 22, 2021 at 02:12:50PM +0800, Xueming Li wrote: > Device iterator RTE_DEV_FOREACH() failed to return devices from > classifier like "class=vdpa", because matching name from empty kvargs > returns no result. If device name not specified in kvargs, the function > should itera

Re: [dpdk-dev] [PATCH] doc: note KNI alternatives and deprecation plan

2021-11-23 Thread Ferruh Yigit
On 8/20/2021 1:58 PM, David Marchand wrote: On Wed, Jun 23, 2021 at 7:32 PM Ferruh Yigit wrote: Add a note that KNI kernel module will be moved to dpdk-kmods git repo and there is a long term plan to deprecate it. Also add some more details on the alternatives to KNI and cons of the KNI again

Re: [PATCH] doc: add build_root to STRIP_FROM_PATH

2021-11-23 Thread Luca Boccassi
On Mon, 2021-11-22 at 21:16 +0100, Timothy Redaelli wrote: > examples.dox is built inside builddir and so doxygen generates some > dir_HASH.html that includes the builddir name and this may prevent DPDK > documentation to be correctly generated in some distributions, for > example CentOS Stream 9 a

Re: [PATCH] doc: add build_root to STRIP_FROM_PATH

2021-11-23 Thread David Marchand
Hello Timothy, On Mon, Nov 22, 2021 at 9:17 PM Timothy Redaelli wrote: > > examples.dox is built inside builddir and so doxygen generates some > dir_HASH.html that includes the builddir name and this may prevent DPDK > documentation to be correctly generated in some distributions, for > example C

Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control

2021-11-23 Thread Jerin Jacob
On Sun, Nov 21, 2021 at 3:20 PM Ori Kam wrote: > > Hi Jerin, Hi Ori, > > Sorry for my late response, Thanks for the review. > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, November 17, 2021 11:49 AM > > To: Jerin Jacob > > Subject: Re: [dpdk-dev] [RFC PATCH] ethde

[PATCH v8 01/10] doc: add skeleton for eventdevs feature matrices

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch adds skeleton for feature matrices for event dev and Rx/Tx adapters. Along with, .ini files are added for all supported PMDs. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc

[PATCH v8 02/10] doc: update eventdev feature matrix for octeontx

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for octeontx platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Reb

[PATCH v8 03/10] doc: update eventdev feature matrix for octeontx2

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for octeontx2 platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Re

[PATCH v8 04/10] doc: update eventdev feature matrix for cnxk

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for cnxk platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Rebased

[PATCH v8 05/10] doc: update eventdev feature matrix for dpaa

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for dpaa platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Rebased

[PATCH v8 06/10] doc: update eventdev feature matrix for dpaa2

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for dpaa2 platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Rebase

[PATCH v8 07/10] doc: update eventdev feature matrix for SW

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for sw platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Rebased t

[PATCH v8 08/10] doc: update eventdev feature matrix for opdl

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for opdl platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Rebased

[PATCH v8 09/10] doc: update eventdev feature matrix for dsw

2021-11-23 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for dsw platform. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adapter capabilities for SW driver v6: - Rebased

[PATCH v8 10/10] devtools: check event device doc tables

2021-11-23 Thread skori
From: Sunil Kumar Kori In this commit, check is added for event device, Rx, Tx, Crypto and Timer adapters tables for all supported drivers. Signed-off-by: Sunil Kumar Kori --- v8: - Fix script dump for dsw and SW driver - Review comments incorporated v7: - Rebased to 21.11 rc3 - Fix Tx adap

Re: [PATCH] kvargs: fix device iterator match from arguments

2021-11-23 Thread Xueming(Steven) Li
On Tue, 2021-11-23 at 11:25 +0100, Olivier Matz wrote: > Hi Xueming, > > On Mon, Nov 22, 2021 at 02:12:50PM +0800, Xueming Li wrote: > > Device iterator RTE_DEV_FOREACH() failed to return devices from > > classifier like "class=vdpa", because matching name from empty kvargs > > returns no result.

[PATCH v2] app/testpmd: fix hex string parser input length

2021-11-23 Thread Gregory Etelson
Current hex string parser assumes input has even characters number. The parser fails input string with odd length. The patch parses hex stringhs with even and odd length. Cc: sta...@dpdk.org Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Signed-off-by: Gregory Et

[PATCH v2 1/2] doc: note KNI alternatives

2021-11-23 Thread Ferruh Yigit
Add more information on alternatives of KNI and the cons of KNI against these alternatives. Signed-off-by: Ferruh Yigit --- Cc: Olivier Matz Cc: David Marchand Cc: Stephen Hemminger Cc: Elad Nachman Cc: Igor Ryzhov Cc: Dan Gora --- doc/guides/nics/tap.rst | 2 ++ ...

[PATCH v2 2/2] doc: announce KNI deprecation

2021-11-23 Thread Ferruh Yigit
Announce the KNI kernel module move to out of dpdk repo and announce long term plan to deprecate the KNI. Signed-off-by: Ferruh Yigit --- Cc: Olivier Matz Cc: David Marchand Cc: Stephen Hemminger Cc: Elad Nachman Cc: Igor Ryzhov Cc: Dan Gora Dates are not discussed before, the patch aims t

Re: [PATCH] kvargs: fix device iterator match from arguments

2021-11-23 Thread Olivier Matz
On Tue, Nov 23, 2021 at 11:25:22AM +, Xueming(Steven) Li wrote: > On Tue, 2021-11-23 at 11:25 +0100, Olivier Matz wrote: > > Hi Xueming, > > > > On Mon, Nov 22, 2021 at 02:12:50PM +0800, Xueming Li wrote: > > > Device iterator RTE_DEV_FOREACH() failed to return devices from > > > classifier li

[PATCH] common/mlx5: fix shared MR ranges allocation

2021-11-23 Thread Bing Zhao
Memory regions (MRs) were allocated in one chunk of memory with a mempool registration object. However, MRs can be reused among different mempool registrations. When the registration that allocated the MRs originally was destroyed, the dangling pointers to the MRs could be left in other registrati

Re: [PATCH] kvargs: fix device iterator match from arguments

2021-11-23 Thread Xueming(Steven) Li
On Tue, 2021-11-23 at 13:31 +0100, Olivier Matz wrote: > On Tue, Nov 23, 2021 at 11:25:22AM +, Xueming(Steven) Li wrote: > > On Tue, 2021-11-23 at 11:25 +0100, Olivier Matz wrote: > > > Hi Xueming, > > > > > > On Mon, Nov 22, 2021 at 02:12:50PM +0800, Xueming Li wrote: > > > > Device iterator

RE: [PATCH] crypto/ipsec_mb: fix cipher key setting

2021-11-23 Thread Zhang, Roy Fan
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, November 22, 2021 5:47 PM > To: Zhang, Roy Fan ; Power, Ciara > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] crypto/ipsec_mb: fix cipher key setting > > When authenticating with SNOW3G,

RE: [PATCH] doc: support IPsec Multi-buffer lib v1.1

2021-11-23 Thread Zhang, Roy Fan
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, November 18, 2021 2:34 PM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] doc: support IPsec Multi-buffer lib v1.1 > > Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD > docu

RE: [PATCH] net/mlx4: fix empty ETH spec with VLAN support

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Xiaoyu Min > Sent: Monday, November 22, 2021 3:53 PM > To: Matan Azrad ; Slava Ovsiienko > ; Dekel Peled > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx4: fix empty ETH spec with VLAN support > > When the ETH spec is empty MLX4 PMD doesn't

RE: [PATCH] net/mlx5: fix flow mark value missing on combination split

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Monday, November 22, 2021 4:23 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix flow mark value missing on combination split > > If the

RE: [PATCH v3] net/mlx5: fix refcount on detached indirect action

2021-11-23 Thread Slava Ovsiienko
> -Original Message- > From: Dariusz Sosnowski > Sent: Monday, November 22, 2021 19:10 > To: Matan Azrad ; Slava Ovsiienko > ; Dmitry Kozlyuk > Cc: Raslan Darawsheh ; dev@dpdk.org; > sta...@dpdk.org > Subject: [PATCH v3] net/mlx5: fix refcount on detached indirect action > > This patch f

[PATCH v2] net/mlx5: fix multi segment packet wraparound

2021-11-23 Thread Dariusz Sosnowski
This patch fixes the assertion failure triggered when the user configured minimum inline length requirements and the application transmitted multi segment packets. Failure was triggered when space left in TX queue was not enough to cover this requirement. This patch limits the length of data to be

[PATCH v2] doc: add examples.dox path to STRIP_FROM_PATH

2021-11-23 Thread Timothy Redaelli
examples.dox is built inside builddir/doc/api and so doxygen generates some dir_HASH.html that includes the builddir name and this may prevent DPDK documentation to be correctly generated in some distributions, for example CentOS Stream 9 and RHEL9, since the builddir includes the architecture. Th

Re: [PATCH v2] doc: add examples.dox path to STRIP_FROM_PATH

2021-11-23 Thread Luca Boccassi
On Tue, 2021-11-23 at 15:48 +0100, Timothy Redaelli wrote: > examples.dox is built inside builddir/doc/api and so doxygen generates > some dir_HASH.html that includes the builddir name and this may prevent > DPDK documentation to be correctly generated in some distributions, for > example CentOS St

[PATCH v4] net/mlx5: fix refcount on detached indirect action

2021-11-23 Thread Dariusz Sosnowski
This patch fixes segfault which was triggered when port, with indirect actions created, was closed. Segfault was occurring only when RTE_LIBRTE_MLX5_DEBUG was defined. It was caused by redundant decrement of RX queues refcount: - refcount was decremented when port was stopped and indirect actions

[PATCH] examples/power: revert "add wakeup log"

2021-11-23 Thread David Hunt
This reverts commit 931e3a994597acb9ffa827376206e8aa324476b7. Wakeup happens quite often (several hundred times a second) in l3fwd-power example app in PMD power management mode, so this message is appearing too often to be useful. This patch reverts that info message addition. Fixes: 931e3a99459

[PATCH] net/mlx5: fix RSS validation for meter hierarchy

2021-11-23 Thread Bing Zhao
In a meter hierarchy, all the meters are marked with having RSS if the final meter's termination action is RSS. When validating a flow rule with meter hierarchy, the RSS action should not be fetched from the current meter if it is not the final one. The fate action union is next meter ID instead

[PATCH v2] net/mlx5: fix RSS validation for meter hierarchy

2021-11-23 Thread Bing Zhao
In a meter hierarchy, all the meters are marked with having RSS if the final meter's termination action is RSS. When validating a flow rule with meter hierarchy, the RSS action should not be fetched from the current meter if it is not the final one. The fate action union is next meter ID instead

Re: [PATCH] kni: restrict bifurcated device support

2021-11-23 Thread Stephen Hemminger
On Tue, 23 Nov 2021 09:54:01 + Ferruh Yigit wrote: > On 10/9/2021 3:03 AM, Stephen Hemminger wrote: > > On Sat, 9 Oct 2021 00:58:30 +0100 > > Ferruh Yigit wrote: > > > >> To enable bifurcated device support, rtnl_lock is released before calling > >> userspace callbacks and asynchronous r

[PATCH] app/testpmd: fix scheduling send burst interval

2021-11-23 Thread Viacheslav Ovsiienko
The first "set txtimes" command parameter specifies the time interval between scheduled send bursts for single queue. This interval should be the same for all the forwarding ports. It requires to maintain the timing related variables on per queue basis instead of per core, as currently implemented.

Re: [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices

2021-11-23 Thread Jerin Jacob
On Fri, Oct 22, 2021 at 1:18 PM wrote: > > From: Sunil Kumar Kori > > Patch adds skeleton for feature matrices for event dev > and Rx/Tx adapters. > > Along with, .ini files are added for all supported PMDs. > > Signed-off-by: Sunil Kumar Kori Series Acked-by: Jerin Jacob Series without patch

[PATCH v2] kni: restrict bifurcated device support

2021-11-23 Thread Ferruh Yigit
To enable bifurcated device support, rtnl_lock is released before calling userspace callbacks and asynchronous requests are enabled. But these changes caused more issues, like bug #809, #816. To reduce the scope of the problems, the bifurcated device support related changes are only enabled when i

[dpdk-dev] [pull-request] dpdk-next-eventdev - v21.11 rc4

2021-11-23 Thread Jerin Jacob Kollanukkaran
The following changes since commit 0c6e27549c03695f85d949f5195a166b449b419c: version: 21.11-rc3 (2021-11-17 20:19:47 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 04d069510508837cf92f7bf76e0a5207f5c73d59: doc: up

Re: [PATCH] kni: restrict bifurcated device support

2021-11-23 Thread Ferruh Yigit
On 11/23/2021 4:22 PM, Stephen Hemminger wrote: On Tue, 23 Nov 2021 09:54:01 + Ferruh Yigit wrote: On 10/9/2021 3:03 AM, Stephen Hemminger wrote: On Sat, 9 Oct 2021 00:58:30 +0100 Ferruh Yigit wrote: To enable bifurcated device support, rtnl_lock is released before calling userspac

Re: [PATCH v3] kni: allow configuring the kni thread granularity

2021-11-23 Thread Ferruh Yigit
On 11/22/2021 5:31 PM, Ferruh Yigit wrote: On 11/8/2021 10:13 AM, Tudor Cornea wrote: The Kni kthreads seem to be re-scheduled at a granularity of roughly 1 millisecond right now, which seems to be insufficient for performing tests involving a lot of control plane traffic. Even if KNI_KTHREAD_R

RE: [PATCH v2] examples/ptpclient: fix delay request message

2021-11-23 Thread Nipun Gupta
Acked-by: Nipun Gupta > -Original Message- > From: vanshika.shu...@nxp.com > Sent: 22 November 2021 13:01 > To: dev@dpdk.org; tho...@monjalon.net > Cc: Nipun Gupta ; david.march...@redhat.com; > sta...@dpdk.org; Vanshika Shukla > Subject: [PATCH v2] examples/ptpclient: fix delay request

Re: [PATCH v3] doc: add mlx5 PMD flex item documentation

2021-11-23 Thread Ferruh Yigit
On 11/23/2021 9:29 AM, Gregory Etelson wrote: Describe firmware configuration requirements. List mlx5 hardware and PMD limitations. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko Acked-by: Raslan Darawsheh --- v2: Style fixes. v3: Update hardware and port support. Patch is al

[PATCH 0/3] fix MPRQ prepare

2021-11-23 Thread michaelba
From: Michael Baum Prepare Multy-Packet RQ and fix missing devargs check. Michael Baum (3): common/mlx5: add min WQE size for striding RQ net/mlx5: improve stride parameter names net/mlx5: fix missing adjustment MPRQ stride devargs drivers/common/mlx5/mlx5_devx_cmds.c | 16 ++ drivers/c

[PATCH 1/3] common/mlx5: add min WQE size for striding RQ

2021-11-23 Thread michaelba
From: Michael Baum Some devices have a WQE size limit for striding RQ. On some newer devices, this limitation is smaller and information on its size is provided by the firmware. This patch adds the attribute query from firmware: the minimum required size of WQE in a strided RQ in granularity of

[PATCH 2/3] net/mlx5: improve stride parameter names

2021-11-23 Thread michaelba
From: Michael Baum In the striding RQ management there are two important parameters, the size of the single stride in bytes and the number of strides. Both the data-path structure and config structure keep the log of the above parameters. However, in their names there is no mention that the valu

[PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs

2021-11-23 Thread michaelba
From: Michael Baum In Multy-Packet RQ creation, the user can choose the number of strides and their size in bytes. The user updates it using specific devargs for both of these parameters. The above two parameters determine the size of the WQE which is actually their product of multiplication. If

RE: [PATCH] crypto/ipsec_mb: fix cipher key setting

2021-11-23 Thread Akhil Goyal
> > Subject: [PATCH] crypto/ipsec_mb: fix cipher key setting > Acked-by: Fan Zhang Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH] crypto/mlx5: fix max number of QPs capability

2021-11-23 Thread Akhil Goyal
> An indirect mkey is created for each descriptor in a QP, number of > descriptors per QP is configured by the user on QP setup callback. > In mlx cryptodev autotest, the max number of QPs (provided by the driver) > is created, and due to mkey resource limits, QPs creation fail which leads > to the

RE: [EXT] [PATCH] drivers/crypto: fix ipsec inner ip header ttl decrement option

2021-11-23 Thread Akhil Goyal
> Subject: RE: [EXT] [PATCH] drivers/crypto: fix ipsec inner ip header ttl > decrement option > Title updated Applied to dpdk-next-crypto > > dpaa, dpaa2 and caam_jr drivers decrement the inner IP header > > TTL for all packets and ignoring the dec_ttl option of SA. > > > > In this patch, using t

RE: [EXT] [PATCH] drivers/crypto: no support for SA lifetime

2021-11-23 Thread Akhil Goyal
> dpaa, dpaa2 and caam_jr drivers do not support > SA expiry. Title and description updated. Applied to dpdk-next-crypto > > Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal

RE: [PATCH] doc: support IPsec Multi-buffer lib v1.1

2021-11-23 Thread Akhil Goyal
> > Subject: [PATCH] doc: support IPsec Multi-buffer lib v1.1 > > > > Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD > > documentation > > guides with information about the latest Intel IPSec Multi-buffer > > library supported. > > > > Signed-off-by: Pablo de Lara > > --- > Acked-by: F

Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control

2021-11-23 Thread Ajit Khaparde
On Tue, Nov 23, 2021 at 2:58 AM Jerin Jacob wrote: > > On Sun, Nov 21, 2021 at 3:20 PM Ori Kam wrote: > > > > Hi Jerin, > > Hi Ori, > > > > > Sorry for my late response, > > Thanks for the review. > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Wednesday, November 17,

Re: [PATCH] kni: restrict bifurcated device support

2021-11-23 Thread Stephen Hemminger
On Tue, 23 Nov 2021 16:51:27 + Ferruh Yigit wrote: > >>> > >>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c > >>> index 611719b5ee27..d47fc6133cbe 100644 > >>> --- a/kernel/linux/kni/kni_net.c > >>> +++ b/kernel/linux/kni/kni_net.c > >>> @@ -838,6 +838,14 @@ kni_net_in

[PATCH v2 1/5] common/cnxk: add REE HW definitions

2021-11-23 Thread lironh
From: Liron Himi adding REE (Regular Expression Engine) HW definitions Signed-off-by: Liron Himi --- drivers/common/cnxk/hw/ree.h | 126 +++ drivers/common/cnxk/hw/rvu.h | 5 ++ 2 files changed, 131 insertions(+) create mode 100644 drivers/common/cnxk/hw/ree.

[PATCH v2 0/5] regex/cn9k: use cnxk infrastructure

2021-11-23 Thread lironh
From: Liron Himi 4 patches add support for REE into cnkx infrastructure. the last patch change the octeontx2 driver to use the new cnxk code. in addition all references to octeontx2/otx2 were replaced with cn9k. v2: - fix review comments. - split original patch. - add the driver patch. Liron Hi

[PATCH v2 2/5] common/cnxk: add REE mbox definitions

2021-11-23 Thread lironh
From: Liron Himi add REE mbox definitions Signed-off-by: Liron Himi --- drivers/common/cnxk/roc_mbox.h | 100 + 1 file changed, 100 insertions(+) diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h index b63fe108c9..e97d93e261 100644 --

[PATCH v2 3/5] common/cnxk: add REE support

2021-11-23 Thread lironh
From: Liron Himi extend cnxk infrastructure to support REE Signed-off-by: Liron Himi --- drivers/common/cnxk/roc_ree.c | 647 + drivers/common/cnxk/roc_ree.h | 137 ++ drivers/common/cnxk/roc_ree_priv.h | 18 + 3 files changed, 802 insertions(+) crea

[PATCH v2 4/5] common/cnxk: link REE support to ROC files

2021-11-23 Thread lironh
From: Liron Himi add references to REE files from ROC files Signed-off-by: Liron Himi --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 4 drivers/common/cnxk/roc_constants.h | 2 ++ drivers/common/cnxk/roc_platform.c | 1 + drivers/common/cnxk/roc_

[PATCH v2 5/5] regex/cn9k: use cnxk infrastructure

2021-11-23 Thread lironh
From: Liron Himi update driver to use the REE cnxk code. replace octeontx2/otx2 with cn9k Signed-off-by: Liron Himi Change-Id: I79c3e1e2850e6274afcf86bb406cd04a2c698402 --- MAINTAINERS | 8 +- doc/guides/platform/cnxk.rst | 3 + .../regexd

Re: [PATCH v2] doc: add examples.dox path to STRIP_FROM_PATH

2021-11-23 Thread David Marchand
On Tue, Nov 23, 2021 at 3:49 PM Timothy Redaelli wrote: > > examples.dox is built inside builddir/doc/api and so doxygen generates > some dir_HASH.html that includes the builddir name and this may prevent > DPDK documentation to be correctly generated in some distributions, for > example CentOS St

RE: [EXT] [PATCH v3] app/test-crypto-perf: fix segment size for IPsec operation

2021-11-23 Thread Akhil Goyal
> Application calculates segment size based on buffer size plus > digest size only, But if the operation mode is IPsec then > packet length can be increased by some more bytes depends upon > the algorithm. > > In this patch, increasing segment size with RTE_PKTMBUF_HEADROOM > when there is no user

Re: [PATCH] kvargs: fix device iterator match from arguments

2021-11-23 Thread Olivier Matz
Hello Xueming, On Tue, Nov 23, 2021 at 12:49:32PM +, Xueming(Steven) Li wrote: > On Tue, 2021-11-23 at 13:31 +0100, Olivier Matz wrote: > > On Tue, Nov 23, 2021 at 11:25:22AM +, Xueming(Steven) Li wrote: > > > On Tue, 2021-11-23 at 11:25 +0100, Olivier Matz wrote: > > > > Hi Xueming, > > >

[PATCH] net/mlx5: fix segfault on close after failed start

2021-11-23 Thread Dmitry Kozlyuk
If mlx5_rxq_start() failed and rxq_ctrl was not initialized, mlx5_rxq_obj_verify() would segfaul in an attempt to dereference it. Add a check that rxq_ctrl is not NULL before accessing its members. Fixes: 09c2555303be ("net/mlx5: support shared Rx queue") Cc: xuemi...@nvidia.com Signed-off-by: Dm

RE: [PATCH v2] net/mlx5: fix RSS validation for meter hierarchy

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Tuesday, November 23, 2021 6:05 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org; Li Zhang ; Shun Hao > > Subject: [PATCH v2] net/mlx5: fix RSS validation for meter hierarchy > > In a m

RE: [PATCH v2] net/mlx5: fix multi segment packet wraparound

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Tuesday, November 23, 2021 3:58 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix multi segment packet wraparound > > This patch fixes the asser

RE: [PATCH v4] net/mlx5: fix refcount on detached indirect action

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Tuesday, November 23, 2021 5:38 PM > To: Matan Azrad ; Slava Ovsiienko > ; Dmitry Kozlyuk > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v4] net/mlx5: fix refcount on detached indirect action > > This

RE: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Tuesday, November 23, 2021 8:38 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Michael > Baum ; sta...@dpdk.org > Subject: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs > > From: Mi

Re: [PATCH v8 03/11] app/test: replace POSIX specific code

2021-11-23 Thread Dmitry Kozlyuk
2021-10-25 19:45 (UTC-0700), Jie Zhou: > - Include rte_os_shim.h > - Replace sleep and usleep with rte_delay_us_sleep > - #ifndef RTE_EXEC_ENV_WINDOWS for POSIX code only > > Signed-off-by: Jie Zhou > --- This patch can be combined with the previous one: they serve the same purpose---to remove U

Re: [PATCH v8 04/11] app/test: exclude ENOTSUP as failure

2021-11-23 Thread Dmitry Kozlyuk
2021-10-25 19:45 (UTC-0700), Jie Zhou: > Check rte_errno to exclude ENOTSUP as failures in test_memory.c > > Signed-off-by: Jie Zhou > --- > app/test/test_memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_memory.c b/app/test/test_memory.c > index

Re: [PATCH v8 06/11] app/test: temporarily "skip" one cmdline test case

2021-11-23 Thread Dmitry Kozlyuk
2021-10-25 19:45 (UTC-0700), Jie Zhou: > cmdline tests pass except one failure at the test_cmdline_socket_fns > test case with error: failed to open /dev/null for reading! Can't it be something like this? #ifndef RTE_EXEC_ENV_WINDOWS #define NULL_INPUT "/dev/null" #else #define NULL_INPUT "NUL" #

Re: [PATCH v8 10/11] app/test: replace .sh scripts with .py scripts

2021-11-23 Thread Dmitry Kozlyuk
2021-10-25 19:46 (UTC-0700), Jie Zhou: > - Add python script to check if system supports hugepages > - Remove corresponding .sh scripts > - Replace calling of .sh with corresponding .py in meson.build > > Signed-off-by: Jie Zhou > --- > app/test/has-hugepage.sh | 11 --- > app/test/has_h

[PATCH 0/2] next/mlx5: fix indirect RSS reference counting

2021-11-23 Thread Dmitry Kozlyuk
Dmitry Kozlyuk (2): net/mlx5: fix indirect RSS creation when port is stopped net/mlx5: fix RxQ reference counting for indirect RSS drivers/net/mlx5/mlx5_rxq.c | 56 + 1 file changed, 32 insertions(+), 24 deletions(-) -- 2.25.1

[PATCH 1/2] net/mlx5: fix indirect RSS creation when port is stopped

2021-11-23 Thread Dmitry Kozlyuk
mlx5_ind_table_obj_setup() was incrementing RxQ reference counters even when the port was stopped, which prevented RxQ release and triggered an internal assertion. Only increment reference counter when the port is started. Fixes: ec4e11d41d12 ("net/mlx5: preserve indirect actions on restart") Sig

[PATCH 2/2] net/mlx5: fix RxQ reference counting for indirect RSS

2021-11-23 Thread Dmitry Kozlyuk
mlx5_ind_table_obj_modify() was not changing the reference counters of neither the new set of RxQs, nor the old set of RxQs. On the other hand, creation of the RSS incremented the RxQ refcnt. If an RxQ was present in both the initial and the modified set, its reference counter was incremented one e

RE: [PATCH] common/mlx5: fix shared MR ranges allocation

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Tuesday, November 23, 2021 2:49 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; Dmitry Kozlyuk > > Subject: [PATCH] common/mlx5: fix shared MR ranges allocation > > Memory regions (MRs) were allocated in

RE: [PATCH] net/mlx5: fix segfault on close after failed start

2021-11-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, November 23, 2021 10:22 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Xueming(Steven) Li > ; Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH] net/mlx5: fix segfault on close after failed start > > If mlx5_rxq_start() fa

[PATCH] net/ice: fix Tx checksum offload capability

2021-11-23 Thread Qi Zhang
Add missing capability for outer UDP Tx checksum. Also fixed the feature list in ice_dcf.ini Fixes: bf89db4409bb ("net/ice: complete device info get in DCF") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- doc/guides/nics/features/ice_dcf.ini | 5 + drivers/net/ice/ice_dcf_ethdev.c | 1

Re: release candidate 21.11-rc3

2021-11-23 Thread Thinh Tran
Hi IBM - Power Systems DPDK 21.11-rc3 * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. Systems tested: - IBM Power9 PowerNV 9006-22P OS: RHEL 8.4 GCC: gcc version 8.4.1 20200928 (Red Hat 8.4.1-1) NICs: - Mellanox Technologies MT28800 Fa

[PATCH] net/mlx5: fix GRE item matching

2021-11-23 Thread Alexander Kozyrev
GRE protocol type is implicitly set in the matching translation in case an application doesn't specify any type explicitly in a flow rule. It is extracted from the inner header type, but this type may be absent. In this case, GRE item matching is broken. Check if we have the inner header type befor

[PATCH] ip_frag: add fragmenting IPv4 header optional field

2021-11-23 Thread Huichao Cai
According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process. Signed-off-by: Huic

[PATCH] test/ipfrag: check fragment IPv4 header options

2021-11-23 Thread Huichao Cai
Add some test data for the IPv4 header optional field fragmenting. Signed-off-by: Huichao Cai --- Depends-on: patch-104642 (ip_frag: add fragmenting IPv4 header optional field) app/test/test_ipfrag.c | 269 + 1 file changed, 250 insertions(+), 19

Re: [PATCH] test/ipfrag: check fragment IPv4 header options

2021-11-23 Thread David Marchand
On Wed, Nov 24, 2021 at 8:00 AM Huichao Cai wrote: > > Add some test data for the IPv4 header optional field fragmenting. > > Signed-off-by: Huichao Cai > --- > Depends-on: patch-104642 (ip_frag: add fragmenting IPv4 header optional field) Please submit those changes as a single patch. Thanks.

RE: [dpdk-dev] [Bug 826] red_autotest random failures

2021-11-23 Thread Liguzinski, WojciechX
Hi, Thanks Lincoln, I will also have a try with such script. Cheers, Wojciech From: Lincoln Lavoie Sent: Friday, November 19, 2021 6:26 PM To: Dumitrescu, Cristian Cc: Thomas Monjalon ; David Marchand ; Ajmera, Megha ; Singh, Jasvinder ; Liguzinski, WojciechX ; dev ; Aaron Conole ; Yigit,

[dpdk-dev] [PATCH ] common/cnxk: fix nibble parsing order when dumping MCAM

2021-11-23 Thread psatheesh
From: Satheesh Paul Fix the order in which layer flags and layer type fields are parsed when dumping the MCAM data. Fixes: 9869c39918 ("common/cnxk: support flow entry dump") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc_mcam_dump.c | 40