On Tue, Nov 23, 2021 at 2:58 AM Jerin Jacob <jerinjac...@gmail.com> wrote:
>
> On Sun, Nov 21, 2021 at 3:20 PM Ori Kam <or...@nvidia.com> wrote:
> >
> > Hi Jerin,
>
> Hi Ori,
>
> >
> > Sorry for my late response,
>
> Thanks for the review.
>
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjac...@gmail.com>
> > > Sent: Wednesday, November 17, 2021 11:49 AM
> > > To: Jerin Jacob <jer...@marvell.com>
> > > Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow
> > > control
> > >
> > > On Tue, Oct 5, 2021 at 6:32 PM <jer...@marvell.com> wrote:
> > > >
> > > > From: Jerin Jacob <jer...@marvell.com>
> > > >
> > > > rte_eth_dev_priority_flow_ctrl_set() based API is not generic as it
> > > > can not support other than VLAN priority mapping to PFC traffic class.
> > > >
> > > > Introducing RTE_FLOW_ACTION_TYPE_PFC_SET_TC rte_flow action to
> > > > set the traffic class as per 802.1Qbb specification. This will enable,
> > > > Traffic class(8bit) to be selected based on any packet field like DSCP.
> > > >
> > > > Also, making it as rte_flow action will enable fine control on
> > > > traffic class selection to a specific queue or VF etc.
> > > >
> > > > Signed-off-by: Jerin Jacob <jer...@marvell.com>
> > >
> > > Ping. If there are no comments on RFC, Planning to send v1 for 22.02.
> >
> > All the set type of functions are going to be deprecated.
> > you should use RTE_FLOW_ACTION_TYPE_MODIFY_FIELD.
> >
> > What is the item that you are matching on when using rte_flow? Is it part
> > of the tci in the vlan item?
>
> TC can be VLAN TCI field or DSCP field in IP header or any other field
> in packet.
> We need to set the traffic class as per 802.1Qbb specification, May I
> know how the "modify"
> attribute helps here. It should be a "set" operation. Right?
I think "set" is appropriate.
