[dpdk-dev] [PATCH v2] kni: allow configuring the kni thread granularity

2021-11-02 Thread Tudor Cornea
The Kni kthreads seem to be re-scheduled at a granularity of roughly 1 millisecond right now, which seems to be insufficient for performing tests involving a lot of control plane traffic. Even if KNI_KTHREAD_RESCHEDULE_INTERVAL is set to 5 microseconds, it seems that the existing code cannot resch

[dpdk-dev] [PATCH] doc: remove deprecation notices for eventdev

2021-11-02 Thread jerinj
From: Jerin Jacob All deprecation notice targeted for v21.11 of eventdev has been committed in the following commits, remove deprecation notices. Fixes: 3c838062b91 ("eventdev: introduce event vector Rx capability") Fixes: 929ebdd5430 ("eventdev/eth_rx: simplify event vector config") Fixes: 295c

Re: [dpdk-dev] [PATCH v2] kni: allow configuring the kni thread granularity

2021-11-02 Thread Stephen Hemminger
On Tue, 2 Nov 2021 17:51:13 +0200 Tudor Cornea wrote: > +#ifdef RTE_KNI_PREEMPT_DEFAULT > +module_param(min_scheduling_interval, long, 0644); > +MODULE_PARM_DESC(min_scheduling_interval, > +"Kni thread min scheduling interval (default=100 microseconds):\n" > +"\t\t" > +); Why the non-standard n

Re: [dpdk-dev] [PATCH v2 1/1] vfio: add page-by-page mapping API

2021-11-02 Thread Burakov, Anatoly
On 28-Oct-21 3:09 PM, Anatoly Burakov wrote: Currently, there is no way to map memory for DMA in a way that allows unmapping it partially later, because some IOMMU's do not support partial unmapping. There is a workaround of mapping all of these segments separately, but this is inconvenient and s

[dpdk-dev] [PATCH 1/9] common/cnxk: add code to write CPT CTX through microcode op

2021-11-02 Thread Nithin Dabilpuram
From: Srujana Challa Adds APIs to write CPT CTX through microcode op(SET_CTX/WRITE_SA). Signed-off-by: Srujana Challa --- drivers/common/cnxk/hw/cpt.h | 2 - drivers/common/cnxk/roc_cpt.c | 83 +-- drivers/common/cnxk/roc_cpt.h | 8 ++- dri

[dpdk-dev] [PATCH 2/9] common/cnxk: add CPT CTX sync mailbox API

2021-11-02 Thread Nithin Dabilpuram
From: Srujana Challa Add CPT CTX sync mailbox API and flush IPsec inbound entries at application exit. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_mbox.h| 1 + drivers/common/cnxk/roc_nix.c | 14 ++ drivers/common/cnxk/roc_nix.h | 1 + driver

[dpdk-dev] [PATCH 3/9] common/cnxk: support flow control on LBK

2021-11-02 Thread Nithin Dabilpuram
Support flow control enable/disable on LBK VF's as HW supports backpressure on LBK links. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.c| 6 ++ drivers/common/cnxk/roc_nix_fc.c | 27 --- 2 files changed, 26 insertions(+), 7 deletions(-) diff

[dpdk-dev] [PATCH 4/9] common/cnxk: enable tm to listen on Rx pause frames

2021-11-02 Thread Nithin Dabilpuram
Enable tm topology to listen on backpressure received when Rx pause frame is enabled. Only one TM node in Tl3/TL2 per channel can listen on backpressure on that channel. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.c | 3 + drivers/common/cnxk/roc_nix.h |

[dpdk-dev] [PATCH 5/9] common/cnxk: enable bp on CPT with inline inbound

2021-11-02 Thread Nithin Dabilpuram
Enable backpressure on CPT with inline inbound enabled. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_mbox.h | 4 drivers/common/cnxk/roc_nix_fc.c | 28 2 files changed, 32 insertions(+) diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/co

[dpdk-dev] [PATCH 6/9] common/cnxk: support changing drop re flag after lf alloc

2021-11-02 Thread Nithin Dabilpuram
Add API to toggle drop_re flag after nix_lf_alloc() so that it can be used to toggle it runtime. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_mbox.h | 1 + drivers/common/cnxk/roc_nix.c | 1 + drivers/common/cnxk/roc_nix.h | 1 + drivers/common/cnxk/roc_nix_ops.c

[dpdk-dev] [PATCH 7/9] net/cnxk: write CPT CTX through microcode op

2021-11-02 Thread Nithin Dabilpuram
From: Srujana Challa Adds support to write CPT CTX through microcode op(SET_CTX/WRITE_SA) for cn10k inline mode. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev_sec.c | 59 + drivers/net/cnxk/cnxk_ethdev.c | 49 +-

[dpdk-dev] [PATCH 8/9] net/cnxk: allow fc on lbk and enable tm bp on Rx pause

2021-11-02 Thread Nithin Dabilpuram
Allow flow control on LBK VF's and enable TM to listen on backpressure when Rx pause is enabled. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_ethdev.c | 12 ++-- drivers/net/cnxk/cnxk_ethdev_ops.c | 14 +- 2 files changed, 19 insertions(+), 7 deletions(-) d

[dpdk-dev] [PATCH 9/9] event/cnxk: disable drop re on vector enable for cn10k a0

2021-11-02 Thread Nithin Dabilpuram
Disable drop_re i.e dropping packets with receive errors on vector enable for few cn10k revisions due to HW errata. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cnxk_eventdev_adptr.c | 8 drivers/net/cnxk/cn10k_ethdev.c | 11 --- drivers/net/cnxk/cnxk_ethdev

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-02 Thread Andrew Rybchenko
On 11/2/21 6:45 PM, Thomas Monjalon wrote: 01/11/2021 10:41, Andrew Rybchenko: On 10/27/21 12:00 PM, Ivan Malov wrote: There are PMDs which do not support flow offloads at all. In such cases, the API in question returns ENOTSUP. This is too loud. Restructure the code to avoid spamming logs. Fi

Re: [dpdk-dev] [PATCH] doc: remove deprecation notices for eventdev

2021-11-02 Thread Thomas Monjalon
02/11/2021 16:49, jer...@marvell.com: > From: Jerin Jacob > > All deprecation notice targeted for v21.11 of eventdev has been > committed in the following commits, remove deprecation notices. > > Fixes: 3c838062b91 ("eventdev: introduce event vector Rx capability") > Fixes: 929ebdd5430 ("eventde

[dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-27

2021-11-02 Thread Ananyev, Konstantin
Minutes of Technical Board Meeting, 2021-Oct-27 Members Attending --- -Aaron -Ferruh -Hemant -Honnappa -Jerin -Kevin -Konstantin (Chair) -Maxime -Stephen -Thomas NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/ice: save meta on switch filter creation

2021-11-02 Thread Ferruh Yigit
On 11/1/2021 8:45 AM, dapengx...@intel.com wrote: From: Dapeng Yu The meta is abandoned when switch filter is created in original implementation. What is 'meta', do you mean 'metadata'? Can you please clarify which metadata you are referring to? This patch saved the meta in RTE flow for fut

Re: [dpdk-dev] [PATCH] doc: remove deprecation notices for eventdev

2021-11-02 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 9:31 PM Thomas Monjalon wrote: > > 02/11/2021 16:49, jer...@marvell.com: > > From: Jerin Jacob > > > > All deprecation notice targeted for v21.11 of eventdev has been > > committed in the following commits, remove deprecation notices. > > > > Fixes: 3c838062b91 ("eventdev:

Re: [dpdk-dev] [PATCH] meson.build: replace tabs with spaces

2021-11-02 Thread Bruce Richardson
On Tue, Nov 02, 2021 at 08:50:55AM -0700, Stephen Hemminger wrote: > Per the meson recommendation the meson.build file > should be indented with spaces not tabs. > This patch is semi-automatically generated by running > all the meson.build files through expand command. > > Signed-off-by: Stephen H

Re: [dpdk-dev] [PATCH v9 0/4] enable protocol agnostic flow offloading in FDIR

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 5:39 AM, Junfeng Guo wrote: Protocol agnostic flow offloading in Flow Director is enabled by this patch set based on the Parser Library using existing rte_flow raw API. [PATCH v9 1/4] net/ice/base: add method to disable FDIR SWAP option. [PATCH v9 2/4] net/ice/base: add function to

Re: [dpdk-dev] [PATCH v3] net/af_packet: fix ignoring full ring on tx

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 3:47 PM, Tudor Cornea wrote: The poll call can return POLLERR which is ignored, or it can return POLLOUT, even if there are no free frames in the mmap-ed area. We can account for both of these cases by re-checking if the next frame is empty before writing into it. We have attempted

[dpdk-dev] [PATCH v6 0/6] Flow entites behavior on port restart

2021-11-02 Thread Dmitry Kozlyuk
It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD would keep indirect actions. In the end, appli

[dpdk-dev] [PATCH v6 1/6] ethdev: add capability to keep flow rules on restart

2021-11-02 Thread Dmitry Kozlyuk
Previously, it was not specified what happens to the flow rules when the device is stopped, possibly reconfigured, then started. If flow rules were kept, it could be convenient for application developers, because they wouldn't need to save and restore them. However, due to the number of flows and p

[dpdk-dev] [PATCH v6 2/6] ethdev: add capability to keep shared objects on restart

2021-11-02 Thread Dmitry Kozlyuk
rte_flow_action_handle_create() did not mention what happens with an indirect action when a device is stopped and started again. It is natural for some indirect actions, like counter, to be persistent. Keeping others at least saves application time and complexity. However, not all PMDs can support

[dpdk-dev] [PATCH v6 3/6] net: advertise no support for keeping flow rules

2021-11-02 Thread Dmitry Kozlyuk
When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, the specified behavior is the same as it had been before this bit was introduced. Explicitly reset it in all PMDs supporting rte_flow API in order to attract the attention of maintainers, who should eventually choose to advertise the new

[dpdk-dev] [PATCH v6 4/6] net/mlx5: discover max flow priority using DevX

2021-11-02 Thread Dmitry Kozlyuk
Maximum available flow priority was discovered using Verbs API regardless of the selected flow engine. This required some Verbs objects to be initialized in order to use DevX engine. Make priority discovery an engine method and implement it for DevX using its API. Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH v6 5/6] net/mlx5: create drop queue using DevX

2021-11-02 Thread Dmitry Kozlyuk
Drop queue creation and destruction were not implemented for DevX flow engine and Verbs engine methods were used as a workaround. Implement these methods for DevX so that there is a valid queue ID that can be used regardless of queue configuration via API. Cc: sta...@dpdk.org Signed-off-by: Dmitr

[dpdk-dev] [PATCH v6 6/6] net/mlx5: preserve indirect actions on restart

2021-11-02 Thread Dmitry Kozlyuk
MLX5 PMD uses reference counting to manage RX queue resources. After port stop shared RSS actions kept references to RX queues, preventing resource release. As a result, internal PMD mempool for such queues had been exhausted after a number of port restarts. Diagnostic message from rte_eth_dev_star

Re: [dpdk-dev] [PATCH v5 0/6] Flow entites behavior on port restart

2021-11-02 Thread Dmitry Kozlyuk
> -Original Message- > From: Ferruh Yigit [...] > > v5: > > 1. Fix rebase conflicts. > > I am still getting conflicts. Did you rebase it on top of next-net? Sorry, I was rebasing onto main instead of next-net. Sent v6 rebased onto: commit 87f4496c74e644d4466233315b2497e7b1acca6d (

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko wrote: > >> IMHO, spamming of testpmd logs in described case should be fixed > >> in testpmd itself to avoid logs in the case of ENOTSUP. That's it. > > > > I think we should not call this API in testpmd > > if not doing rte_flow transfer rule. > > >

Re: [dpdk-dev] [PATCH v9 4/4] net/ice: enable protocol agnostic flow offloading in FDIR

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 5:39 AM, Junfeng Guo wrote: @@ -1733,6 +1862,101 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, &input_set_i : &input_set_o; switch (item_type) { + case RTE_FLOW_ITEM_TYPE_RAW: + raw_spec = item-

Re: [dpdk-dev] [PATCH v2] ci: fix aarch64 cross compilation in GHA

2021-11-02 Thread David Marchand
On Fri, Oct 29, 2021 at 3:37 PM Aaron Conole wrote: > > CC_FOR_BUILD is a Travis env variable. > > This results in GHA aarch64 cross compilation jobs building x86 > > binaries. > > > > Example in a recent job on main branch: > > 2021-10-28T09:51:06.4976495Z + .ci/linux-build.sh > > 2021-10-28T09:5

Re: [dpdk-dev] [PATCH] bonding: show xmit policy for 802.3AD mode

2021-11-02 Thread Ferruh Yigit
On 10/25/2021 4:15 AM, Min Hu (Connor) wrote: As balance xmit policy is supported in bonding mode 4(802.3AD). This patch adds balance xmit policy show in testpmd commands for mode 4. Like: testpmd> show bonding config 2 Bonding mode: 4 Balance Xmit Policy: BALANCE_XMIT_POLICY_LA

Re: [dpdk-dev] [PATCH v2] net/af_xdp: use bpf link for XDP programs

2021-11-02 Thread Ferruh Yigit
On 10/22/2021 11:42 AM, Ciara Loftus wrote: Since v0.4.0, if the underlying kernel supports it, libbpf uses 'bpf link' to manage the programs on the interfaces of the xsks. This has two repercussions for the PMD. 1. In the case where the PMD asks libbpf to load the default XDP program, the PMD n

Re: [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer

2021-11-02 Thread David Marchand
On Mon, Nov 1, 2021 at 4:37 AM Lin, Xueqin wrote: > > ASan is a really interesting tool, but there are still issues in some > > components. > > I caught a few and opened bugs. > > Are they DPDK bugs or this tool code bugs? DPDK bugs that I started reporting some weeks ago. I mentionned it during

Re: [dpdk-dev] [PATCH v5 2/2] eal: add additional info if core mask too long

2021-11-02 Thread David Marchand
On Thu, Sep 23, 2021 at 1:03 PM David Hunt wrote: > > If the user requests to use an lcore above 128 using -c, > the eal will exit with "EAL: invalid coremask syntax" and > very little else useful information. > > This patch adds some extra information suggesting to use --lcores > so that physical

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread David Marchand
On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson wrote: > I wonder is there ever any scenario where we want to allow tabs on a line? > If not, then rather than using regex, the check could be simplified to: > > if '\t' in line: I am not sure. I considered cases with tabs in log messages.

Re: [dpdk-dev] [PATCH v6 0/6] Flow entites behavior on port restart

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 5:01 PM, Dmitry Kozlyuk wrote: It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread Bruce Richardson
On Tue, Nov 02, 2021 at 06:48:07PM +0100, David Marchand wrote: > On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson > wrote: > > I wonder is there ever any scenario where we want to allow tabs on a line? > > If not, then rather than using regex, the check could be simplified to: > > > > if

Re: [dpdk-dev] [PATCH v2] buildtools: fix build with meson 0.60

2021-11-02 Thread Dmitry Kozlyuk
2021-11-01 17:03 (UTC+), Bruce Richardson: > Meson 0.60 switched the format of uninstalled static libraries > to thin archives, that is, they contain only paths to object files, > not the files themselves. Files cannot be extracted in this case, > resulting in build errors: > > ar: `x' can

Re: [dpdk-dev] [PATCH v2 3/4] dma/cnxk: add dma channel operations

2021-11-02 Thread Radha Mohan
On Tue, Nov 2, 2021 at 5:00 AM fengchengwen wrote: > > On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > > Add functions for the dmadev vchan setup and DMA operations. > > > > Signed-off-by: Radha Mohan Chintakuntla > > ... > > > > > +static int > > +cnxk_dmadev_info_get(const struct rte_dma_

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread Stephen Hemminger
On Fri, 22 Oct 2021 22:55:31 +0200 David Marchand wrote: > The rule for indentation in Meson in DPDK is 4 spaces. > > Any tab should be flagged as an issue, let's extend the check and fix > existing offenders. > > Fixes: 4ad4b20a7905 ("drivers: change indentation in build files") > Fixes: 24577

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 7:16 PM Stephen Hemminger wrote: > > On Fri, 22 Oct 2021 22:55:31 +0200 > David Marchand wrote: > > > The rule for indentation in Meson in DPDK is 4 spaces. > > > > Any tab should be flagged as an issue, let's extend the check and fix > > existing offenders. > > > > Fixes:

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread David Marchand
On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson wrote: > > On Fri, Oct 22, 2021 at 10:55:31PM +0200, David Marchand wrote: > > The rule for indentation in Meson in DPDK is 4 spaces. > > > > Any tab should be flagged as an issue, let's extend the check and fix > > existing offenders. > > > > Fixe

Re: [dpdk-dev] [PATCH 1/7] net/sfc: do not allow flow rules to refer to VF representors

2021-11-02 Thread Ferruh Yigit
On 10/25/2021 12:04 PM, Ivan Malov wrote: VF representors do not own dedicated m-ports and thus cannot be referred to as traffic endpoints in flow items or actions. Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure") Fixes: f55b61cec94a ("net/sfc: support port representor flow

[dpdk-dev] [PATCH v8 0/4] optimized Toeplitz hash implementation

2021-11-02 Thread Vladimir Medvedkin
This patch series adds a new optimized implementation for the Toeplitz hash function using Galois Fields New instruction (GFNI). The main use case of this function is to calculate the hash value for a single data, so there is no bulk implementation. For performance reasons, the implementation was p

[dpdk-dev] [PATCH v8 1/4] hash: add new toeplitz hash implementation

2021-11-02 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 172 ++ doc/api/doxy-api-index.md | 1 + do

[dpdk-dev] [PATCH v8 2/4] hash: add bulk toeplitz hash implementation

2021-11-02 Thread Vladimir Medvedkin
This patch adds a bulk version for the Toeplitz hash implemented with Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 67 - doc/guides/prog_guide/toeplitz_hash_lib

[dpdk-dev] [PATCH v8 3/4] hash: enable gfni thash implementation

2021-11-02 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files chan

[dpdk-dev] [PATCH v8 4/4] test/thash: add performance tests for the Toeplitz hash

2021-11-02 Thread Vladimir Medvedkin
This patch adds performance tests for the following Toeplitz hash function implementations: Scalar: - rte_softrss() - rte_softrss_be() Vector using gfni: - rte_thash_gfni() - rte_thash_gfni_bulk() Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/t

[dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush

2021-11-02 Thread David Marchand
Building DPDK without JSON, warnings get displayed when stopping testpmd without entering any flex flow rule. Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") Signed-off-by: David Marchand --- app/test-pmd/cmd_flex_item.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH] eal/linux: fix uevent message parsing

2021-11-02 Thread David Marchand
Caught with ASan: ==9727==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f0daa2fc0d0 at pc 0x7f0daeefacb2 bp 0x7f0daa2fadd0 sp 0x7f0daa2fa578 READ of size 1 at 0x7f0daa2fc0d0 thread T1 #0 0x7f0daeefacb1 (/lib64/libasan.so.5+0xbacb1) #1 0x115eba1 in dev_uev_parse ../lib/eal/

[dpdk-dev] [PATCH 0/4] raw/cnxk_bphy: sync with local changes

2021-11-02 Thread Tomasz Duszynski
This series does not introduce any new features. Just a few improvements and fixes. Jakub Palider (1): raw/cnxk_bphy: remove deps from internal headers Tomasz Duszynski (3): raw/cnxk_bphy: keep leading zero in device name raw/cnxk_bphy: add headers that provide used APIs doc: add BPHY to

[dpdk-dev] [PATCH 1/4] raw/cnxk_bphy: remove deps from internal headers

2021-11-02 Thread Tomasz Duszynski
From: Jakub Palider This patch resolves problem with internal header inclusion. In addition prevents C++ name mangling. Signed-off-by: Jakub Palider Reviewed-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/raw/cnxk_bphy/cnxk_bphy_irq.c | 2 +- drivers/raw/cnxk_bphy/c

[dpdk-dev] [PATCH 2/4] raw/cnxk_bphy: keep leading zero in device name

2021-11-02 Thread Tomasz Duszynski
Device naming might be misleading which is especially true if one takes it from lspci output. In order to keep naming consistent keep leading zero in front of pci bus number. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran Reviewed-by: Jakub Palider --- doc/guides/rawdev

[dpdk-dev] [PATCH 3/4] raw/cnxk_bphy: add headers that provide used APIs

2021-11-02 Thread Tomasz Duszynski
Generally it is good practice to include all headers that provide APIs which are being used. This is especially true in situations where 3rd party apps include our public headers and assume that all should work out of the box. Including all headers explicitly helps to achieve that. Signed-off-by:

[dpdk-dev] [PATCH 4/4] doc: add BPHY to the list of platform blocks

2021-11-02 Thread Tomasz Duszynski
Add BPHY to the list of platform hardware accelerator blocks. Signed-off-by: Tomasz Duszynski --- doc/guides/platform/cnxk.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/platform/cnxk.rst b/doc/guides/platform/cnxk.rst index d7adf43165..845ae46064 100644 --- a/doc/guides/pl

Re: [dpdk-dev] [PATCH] eal/linux: fix uevent message parsing

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 7:41 PM David Marchand wrote: > > Caught with ASan: > ==9727==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x7f0daa2fc0d0 at pc 0x7f0daeefacb2 bp 0x7f0daa2fadd0 sp 0x7f0daa2fa578 > READ of size 1 at 0x7f0daa2fc0d0 thread T1 > #0 0x7f0daeefacb1 (/lib64/l

Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar wrote: > > -Dcpu_instruction_set=znverX meson option can be used > to build dpdk for AMD platforms. Supported options are > znver1, znver2 and znver3. > > Signed-off-by: Aman Kumar > --- > config/x86/meson.build | 9 + > doc/guides/l

[dpdk-dev] [PATCH] common/cnxk: fix a few typos

2021-11-02 Thread Tomasz Duszynski
Fix typos here and there. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_api.h | 2 +- drivers/common/cnxk/roc_nix_irq.c | 2 +- drivers/common/cnxk/roc_se.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH] ip_frag: increase default value for config parameter

2021-11-02 Thread Konstantin Ananyev
Increase default value for config parameter RTE_LIBRTE_IP_FRAG_MAX_FRAG from 4 to 8. This parameter controls maximum number of fragments per packet in ip reassembly table. Increasing this value from 4 to 8 will allow users to cover common case with jumbo packet size of 9KB and fragments with defaul

Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform

2021-11-02 Thread Thomas Monjalon
02/11/2021 19:45, David Marchand: > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar wrote: > > > > -Dcpu_instruction_set=znverX meson option can be used > > to build dpdk for AMD platforms. Supported options are > > znver1, znver2 and znver3. > > > > Signed-off-by: Aman Kumar > > --- > > config/x86/me

Re: [dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 8:40 PM Gregory Etelson wrote: > I posted a patch for that issue in > https://patchwork.dpdk.org/project/dpdk/patch/20211026152000.11665-1-getel...@nvidia.com/ Ok cool, withdrawing my patch. -- David Marchand

Re: [dpdk-dev] [PATCH] doc: remove deprecation notices for eventdev

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 5:29 PM Jerin Jacob wrote: > > That's not an easy job, but we should really try to make such change > > in the related commits, like any other doc or test updates. > > I keep forgetting such things as well. > > +1 I missed the one on interrupt too. I see no easy way to chec

[dpdk-dev] [PATCH] net/bnxt: fix undefined shift in vers_get

2021-11-02 Thread Stephen Hemminger
UBSan testing revealed undefined shift here. The firmware returns the version in bytes; and shifting a 8 bit quantity here can lead to undefined behaviour or truncation. The fix is to promote the bytes to 32 bit before shifting. Bugzilla ID: 838 Fixes: 9a891c1764ea ("net/bnxt: update HWRM to vers

[dpdk-dev] [PATCH] ethdev: mark old macros as deprecated

2021-11-02 Thread Ferruh Yigit
Old macros kept for backward compatibility, but this cause old macro usage to sneak in silently. Marking old macros as deprecated. Downside is this will cause some noise for applications that are using old macros. Fixes: 295968d17407 ("ethdev: add namespace") Signed-off-by: Ferruh Yigit --- Cc:

[dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library

2021-11-02 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced q

[dpdk-dev] [PATCH v20 1/5] sched: add PIE based congestion management

2021-11-02 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Implement PIE based congestion management based on rfc8033 Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh -- Changes in V20: - Removed API conditional compilation - Added flag to indicate cman enabled/disabled - Fixed subm

[dpdk-dev] [PATCH v20 2/5] example/qos_sched: add PIE support

2021-11-02 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski patch add support enable PIE or RED by parsing config file. Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- config/rte_config.h| 1 - examples/qos_sched/cfg_file.c | 127 +++-- examples/qo

[dpdk-dev] [PATCH v20 3/5] example/ip_pipeline: add PIE support

2021-11-02 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Adding the PIE support for IP Pipeline Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- examples/ip_pipeline/tmgr.c | 142 +++- 1 file changed, 74 insertions(+), 68 deletions(-) diff --gi

[dpdk-dev] [PATCH v20 4/5] doc/guides/prog_guide: added PIE

2021-11-02 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Added PIE related information to documentation. Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- doc/guides/prog_guide/glossary.rst | 3 + doc/guides/prog_guide/qos_framework.rst | 64 +---

[dpdk-dev] [PATCH v20 5/5] app/test: add tests for PIE

2021-11-02 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Tests for PIE code added to test application. Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- app/test/meson.build |4 + app/test/test_pie.c | 1065 ++ lib/sched/rte_pie.c |

Re: [dpdk-dev] [PATCH] ethdev: mark old macros as deprecated

2021-11-02 Thread Stephen Hemminger
On Tue, 2 Nov 2021 23:44:34 + Ferruh Yigit wrote: > Old macros kept for backward compatibility, but this cause old macro > usage to sneak in silently. > > Marking old macros as deprecated. Downside is this will cause some noise > for applications that are using old macros. > > Fixes: 29596

[dpdk-dev] [PATCH v2 2/5] event/cnxk: use common XAQ pool APIs

2021-11-02 Thread pbhagavatula
From: Pavan Nikhilesh Use the common APIs to create and fre XAQ pool. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 4 +- drivers/event/cnxk/cn9k_eventdev.c | 6 +- drivers/event/cnxk/cnxk_eventdev.c | 129 drivers/event/cnxk/cnxk_e

[dpdk-dev] [PATCH v2 1/5] common/cnxk: add SSO XAQ pool create and free

2021-11-02 Thread pbhagavatula
From: Pavan Nikhilesh Add common API to create and free SSO XAQ pool. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Merge patchsets 19356,18614 to avoid merge conflicts. - Rebase onto main. drivers/common/cnxk/roc_sso.c | 124 drivers/common/cnxk/roc_s

[dpdk-dev] [PATCH v2 3/5] event/cnxk: fix packet Tx overflow

2021-11-02 Thread pbhagavatula
From: Pavan Nikhilesh The transmit loop incorrectly assumes that nb_mbufs is always a multiple of 4 when transmitting an event vector. The max size of the vector might not be reached and pushed out early due to timeout. Fixes: 761a321acf91 ("event/cnxk: support vectorized Tx event fast path") S

[dpdk-dev] [PATCH v2 4/5] event/cnxk: reduce workslot memory consumption

2021-11-02 Thread pbhagavatula
From: Pavan Nikhilesh SSO group base addresses are always are always contiguous we need not store all the base addresses in workslot memory, instead just store the base address and compute the group address offset when required. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_event

[dpdk-dev] [PATCH v2 5/5] event/cnxk: rework enqueue path

2021-11-02 Thread pbhagavatula
From: Pavan Nikhilesh Rework SSO enqueue path for CN9K make it similar to CN10K enqueue interface. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_eventdev.c| 28 ++- drivers/event/cnxk/cn9k_worker.c | 21 ++--- drivers/event/cnxk/cn9k_worker.h

[dpdk-dev] Question about RSS offload types

2021-11-02 Thread lihuisong (C)
Below macros are defined for RSS offload types in rte_ethdev.h. #define *ETH_RSS_IPV4 *  (1ULL << 2) #define ETH_RSS_FRAG_IPV4  (1ULL << 3) #define ETH_RSS_NONFRAG_IPV4_TCP   (1ULL << 4) #define ETH_RSS_NONFRAG_IPV4_UDP   (1ULL << 5) #define ETH_RSS_NONFRAG_IPV4_SCTP  (1ULL <<

[dpdk-dev] [PATCH v4] examples/vhost: fix failure to launch dpdk-vhost

2021-11-02 Thread Wenwu Ma
When the default max queue value of vhost is 128, dpdk-vhost will fail to launch with a 40G i40e port due to the mbuf allocation of the port queue fails. Therefore, we modify the default value of max queue from 128 to 512, it will ensure that there are enough mbufs. Fixes: 4796ad63ba1f ("examples/

Re: [dpdk-dev] [PATCH v9 4/4] net/ice: enable protocol agnostic flow offloading in FDIR

2021-11-02 Thread Guo, Junfeng
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 3, 2021 00:23 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Xu, Ting > Subject: Re: [PATCH v9 4/4] net/ice: enable protocol agnostic flow > offloading in FDIR > > On 11/2/20

[dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-02 Thread Joyce Kong
Change the 'IPV4' level to 'ETH' level in the comment as it was previously misdescribed. Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- examples/flow_filtering/flow_blocks.c | 2 +- 1 file changed,

[dpdk-dev] [PATCH] app/testpmd: fix set Rx offloads RSS hash off

2021-11-02 Thread Jie Wang
When we set Rx offloads RSS hash off in cmdline, then we start port, if dev->data->dev_conf.rxmode.mq_mode RSS enable(multiple queues mode), it will load RSS hash in driver and sync to port. After setting Rx offloads RSS hash off, this patch removes RTE_ETH_MQ_RX_RSS in port->dev_conf.rxmode.mq_mo

Re: [dpdk-dev] [PATCH v9 0/4] enable protocol agnostic flow offloading in FDIR

2021-11-02 Thread Guo, Junfeng
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 3, 2021 00:29 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Xu, Ting > Subject: Re: [PATCH v9 0/4] enable protocol agnostic flow offloading in > FDIR > > On 11/2/2021 5:39 A

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: add support for event vector

2021-11-02 Thread Nithin Dabilpuram
From: Srujana Challa Adds event vector support to inline protocol offload mode. By default vector support is disabled, it can be enabled by using the option --event-vector. Additional options to configure vector size and vector timeout are also implemented and can be used by specifying --vector-s

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/ice: save meta on switch filter creation

2021-11-02 Thread Yu, DapengX
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 3, 2021 12:11 AM > To: Yu, DapengX ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH 1/2] net/ice: save meta on switch filter > creation > > On 1

[dpdk-dev] [PATCH v10 0/4] enable protocol agnostic flow offloading in FDIR

2021-11-02 Thread Junfeng Guo
Protocol agnostic flow offloading in Flow Director is enabled by this patch set based on the Parser Library using existing rte_flow raw API. [PATCH v10 1/4] net/ice/base: add method to disable FDIR SWAP option. [PATCH v10 2/4] net/ice/base: add function to set HW profile for raw flow. [PATCH v10 3

[dpdk-dev] [PATCH v10 1/4] net/ice/base: add method to disable FDIR SWAP option

2021-11-02 Thread Junfeng Guo
In this patch, we introduced a new parameter to enable/disable the FDIR SWAP option by setting the swap and inset register set with certain values. Signed-off-by: Junfeng Guo Acked-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 44 ++-- drivers/net/ice/base/ice_

[dpdk-dev] [PATCH v10 2/4] net/ice/base: add function to set HW profile for raw flow

2021-11-02 Thread Junfeng Guo
Based on the parser library, we can directly set HW profile and associate the main/ctrl vsi. This patch set also updated the base code BSD release version. Signed-off-by: Junfeng Guo Acked-by: Qi Zhang --- drivers/net/ice/base/README | 2 +- drivers/net/ice/base/ice_flex_pipe.c | 49

[dpdk-dev] [PATCH v10 3/4] app/testpmd: update Max RAW pattern size to 512

2021-11-02 Thread Junfeng Guo
Update max size for pattern in struct rte_flow_item_raw to enable protocol agnostic flow offloading. Signed-off-by: Junfeng Guo Reviewed-by: Qi Zhang --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cm

[dpdk-dev] [PATCH v10 4/4] net/ice: enable protocol agnostic flow offloading in FDIR

2021-11-02 Thread Junfeng Guo
Protocol agnostic flow offloading in Flow Director is enabled by this patch based on the Parser Library, using existing rte_flow raw API. Note that the raw flow requires: 1. byte string of raw target packet bits. 2. byte string of mask of target packet. Here is an example: FDIR matching ipv4 dst

Re: [dpdk-dev] [v8] crypto/cnxk: add telemetry endpoints to cryptodev

2021-11-02 Thread Gowrishankar Muthukrishnan
Hi Akhil, > > Subject: [v8] crypto/cnxk: add telemetry endpoints to cryptodev > > > > Add telemetry endpoints to cryptodev. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > > Depends-on: patch-19601 ("cryptodev: add telemetry callbacks") > > Depends-on: patch-20006 ("cryptodev: add t

Re: [dpdk-dev] [PATCH v4] examples/vhost: fix failure to launch dpdk-vhost

2021-11-02 Thread Xia, Chenbo
Hi, > -Original Message- > From: Ma, WenwuX > Sent: Wednesday, November 3, 2021 10:17 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Yigit, > Ferruh ; Jiang, Cheng1 ; Hu, > Jiayu ; Yang, YvonneX ; Ma, WenwuX > ; sta...@dpdk.org > Subject: [PATCH v4] examples/vhost:

[dpdk-dev] [PATCH] doc: remove deprecation notice for vhost

2021-11-02 Thread Chenbo Xia
Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice. Fixes: 945ef8a04098 ("vhost: promote some APIs to stable") Signed-off-by: Chenbo Xia Reported-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 8 1 file cha

Re: [dpdk-dev] [PATCH] doc: remove deprecation notice for vhost

2021-11-02 Thread Xia, Chenbo
Hi, I notice that from the start, I should not send the notice.. as the abi policy said: For removing the experimental tag associated with an API, deprecation notice is not required. Sorry for the mistake. /Chenbo > -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Wedne

[dpdk-dev] [PATCH v2] test/crypto: fix: test vectors for zuc 256 bit key

2021-11-02 Thread Vidya Sagar Velumuri
Fix the test vectors added for zuc 256-bit key Add known vectores form ZUC 256 RFC. Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys) Signed-off-by: Vidya Sagar Velumuri diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 814a0b401d..38bbd6274b 100644 --- a

[dpdk-dev] [PATCH] pipeline: remove unreachable branch

2021-11-02 Thread David Marchand
A previous change blamed it on compiler/ASan, while this is a real (yet minor) issue. This return -EINVAL is never reached since we test all combinations of fidx and fcin booleans. All branches end up with a return 0, factorize them. Fixes: 84f5ac9418ea ("pipeline: fix build with ASan") Fixes: f3

<    1   2