Re: [dpdk-dev] [PATCH v3 0/3] Support iavf PMD on Windows

2021-09-30 Thread Thomas Monjalon
> Pallavi Kadam (3): > net/iavf: build on Windows > lib/net: fix support of random > doc: update iavf PMD and 21.11 release notes Applied with improvements and intel.com links fixed.

Re: [dpdk-dev] [PATCH] windows/netuio: add Intel Virtual Function device IDs

2021-09-30 Thread Thomas Monjalon
15/09/2021 21:07, Dmitry Kozlyuk: > 2021-09-14 17:51 (UTC-0700), Pallavi Kadam: > > Add Intel Ethernet Virtual Function device IDs to netuio inf file > > to support Intel 40GbE and 100GbE deives on Windows VM. > > Nit: why only VM? Can't VF be used from the host? > > > > > Signed-off-by: Pallavi

Re: [dpdk-dev] [kmods PATCH v2 0/4] windows/virt2phys: fix paging issue

2021-09-30 Thread Thomas Monjalon
23/06/2021 09:13, Thomas Monjalon: > 26/05/2021 23:01, Dmitry Kozlyuk: > > v2: > > * Following ofline review by DmitryM: > > - Add comment explaining tracking approach for validation team. > > - Replace deprecated allocation API calls. > > - Check properties of locked memory (

Re: [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version

2021-09-30 Thread Thomas Monjalon
11/08/2021 23:55, Dmitry Kozlyuk: > 2021-08-05 17:48 (UTC+), William Tu: > > When OVS inits, it calls rte_version to get the DPDK's version. > > The patch fixes the error below by exposing rte_version symbol. > > libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol > > rte_v

Re: [dpdk-dev] [kmods PATCH v2 0/4] windows/virt2phys: fix paging issue

2021-09-30 Thread Dmitry Kozlyuk
2021-09-30 22:24 (UTC+0200), Thomas Monjalon: > 23/06/2021 09:13, Thomas Monjalon: > > 26/05/2021 23:01, Dmitry Kozlyuk: > > > v2: > > > * Following ofline review by DmitryM: > > > - Add comment explaining tracking approach for validation team. > > > - Replace deprecated allocatio

Re: [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API

2021-09-30 Thread Thomas Monjalon
01/09/2021 21:35, Menon, Ranjit: > On 8/28/2021 7:16 PM, Dmitry Kozlyuk wrote: > > Some functions were not exported, and UUID API not even built on Windows > > for no compelling reason. This hasn't been an issue so far, because only > > static build is currently available on Windows, however: > > 1

[dpdk-dev] [PATCH 02/18] common/mlx5: share basic probing with the internal drivers

2021-09-30 Thread michaelba
From: Michael Baum Create common probing structure that includes, for now, basic probing information detected by the common driver and share it with all the internal drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 4 +- drivers/commo

[dpdk-dev] [PATCH 06/18] common/mlx5: move basic probing functions to common

2021-09-30 Thread michaelba
From: Michael Baum Move open IBV/DevX device function to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c| 86 ++ drivers/common/mlx5/linux/mlx5_common_os.h| 3 + drivers/common/mlx5/linux/mlx5_common_verbs.c | 70 +

[dpdk-dev] [PATCH 04/18] common/mlx5: share memory related devargs

2021-09-30 Thread michaelba
From: Michael Baum Add device configure structure and function to parse user device arguments into it. Move parsing and management of relevant device arguments to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 184 ++

[dpdk-dev] [PATCH 00/18] mlx5: sharing global MR cache between drivers

2021-09-30 Thread michaelba
From: Michael Baum The MLNX PMD supports 5 classes (net, RegEx, vDPA, Compress and Crypto). The various drivers are registered under the common driver, and managed by it. In the common driver probing, it calls in a loop the probe function of each driver registered to it. Each driver creates for i

[dpdk-dev] [PATCH 01/18] net/mlx5/windows: fix miss callback register for mem event

2021-09-30 Thread michaelba
From: Michael Baum In device initialization, the driver registers to free hugepages events. When husepage is released, this callback frees all its related MRs. In Windows initialization, this callback is not registered what may cause to use invalid memory. This patch adds memory event callback

[dpdk-dev] [PATCH 03/18] common/mlx5: share common definitions

2021-09-30 Thread michaelba
From: Michael Baum Create MACRO definitions file in the common driver as preparation for MR and basic probe sharing. Move relevant definitions from the net driver to the above file. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 1 + drivers/co

[dpdk-dev] [PATCH 05/18] net/mlx5/windows: rearrange probing code

2021-09-30 Thread michaelba
From: Michael Baum Rearrange device detection code. Rearrange configuration structures filling. Remove unneeded variables. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_os.c | 224 - 1 file changed, 94 insertions(+), 130 deleti

[dpdk-dev] [PATCH 07/18] net/mlx5: remove redundant flag in device config

2021-09-30 Thread michaelba
From: Michael Baum Device configure structure has flag named devx as same as SH structure with the same meaning. Remove the flag from the configuration structure and move all the usages to the SH flag. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c |

[dpdk-dev] [PATCH 10/18] common/mlx5: share the protection domain object

2021-09-30 Thread michaelba
From: Michael Baum Create shared Protection Domain in common area and add it and its PDN as fields of common device structure. Use this Protection Domain in all drivers and remove the PD and PDN fields from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- driver

[dpdk-dev] [PATCH 09/18] common/mlx5: add ROCE disable in context device creation

2021-09-30 Thread michaelba
From: Michael Baum Add option to get IB device after disabling RoCE. It is relevant if there is vDPA class in device arguments list. Use common device context in vDPA driver and remove the ctx field from its private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/com

[dpdk-dev] [PATCH 12/18] net/mlx5: remove redundancy in MR file

2021-09-30 Thread michaelba
From: Michael Baum This patch remove two redundant things from MR file: 1. mr_find_contig_memsegs_data structure which is moved to common file before. 2. External memory mechanism - mlx5_tx_update_ext_mp function. Since commit [1] which added support for DMA map and unmap, external mem

[dpdk-dev] [PATCH 15/18] common/mlx5: share MR top-half search function

2021-09-30 Thread michaelba
From: Michael Baum Add function to search in local liniar cache and use it in the drivers instead of their functions. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h| 9 drivers/common/mlx5/mlx5_common_mr.c | 52 +++

[dpdk-dev] [PATCH 08/18] common/mlx5: share device context object

2021-09-30 Thread michaelba
From: Michael Baum Create shared context device in common area and add it as a field of common device. Use this context device in all drivers and remove the ctx field from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c

[dpdk-dev] [PATCH 13/18] common/mlx5: add MR ctrl init function

2021-09-30 Thread michaelba
From: Michael Baum Add function for MR control structure initialization. This function include: - btree initialization. - dev_gen_ptr initialization. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c| 28 + drivers/common/

[dpdk-dev] [PATCH 11/18] common/mlx5: share the HCA capabilities handle

2021-09-30 Thread michaelba
From: Michael Baum Add HCA attributes structure as a field of device config structure. It query in common probing, and updates the timestamp format fields. Each driver use HCA attributes from common device config structure, instead of query it for itself. Signed-off-by: Michael Baum Acked-by:

[dpdk-dev] [PATCH 14/18] common/mlx5: add global MR cache create function

2021-09-30 Thread michaelba
From: Michael Baum Add function for global shared MR cache structure initialization. This function include: - btree initialization. - set callbacks for reg and dereg MR. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_verbs.c | 15 +++ drivers

[dpdk-dev] [PATCH 16/18] common/mlx5: share MR management

2021-09-30 Thread michaelba
From: Michael Baum Add global shared MR cache as a field of common device structure. Move MR management to use this global cache for all drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c| 54 - drivers/common/mlx5/mlx5_com

[dpdk-dev] [PATCH 17/18] common/mlx5: support device DMA map and unmap

2021-09-30 Thread michaelba
From: Michael Baum Since MR management has moved to the common area, there is no longer a need for the DMA map and unmap function for each driver. This patch share those functions. For most drivers it supports these operations for the first time. Signed-off-by: Michael Baum Acked-by: Matan Azra

[dpdk-dev] [PATCH 18/18] common/mlx5: share MR mempool registration

2021-09-30 Thread michaelba
From: Michael Baum Expand the use of mempool registration to MR management for other drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 148 ++ drivers/common/mlx5/mlx5_common.h | 9 ++ drivers/common/mlx5/mlx5_

Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support

2021-09-30 Thread Srikanth K
Sure, I will follow the Windows support approach. Regarding the patches organization, they were arranged logically to the best of my knowledge. The approach followed is to take Linux PMD code and replace the Linux dependent part with the FreeBSD compatible code. All the removals are of this Linux

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Ajit, On 01/10/2021 00:48, Ajit Khaparde wrote: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17e..7a8da3d7ab 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1485,10 +1485,36 @@ static void init_config_port_offloads(portid_t pid, uint32

Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing

2021-09-30 Thread Menon, Ranjit
Hi Dmitry, On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: WPP tracing [1] allows kernel drivers to print logs that can be viewed without attaching a debugger to the running system. Traces are colelcted only when enabled. Instrument virt2phys with traces: * ERROR: failures that prevent the driver

Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing

2021-09-30 Thread Menon, Ranjit
Typo below: On 9/30/2021 3:07 PM, Menon, Ranjit wrote: Hi Dmitry, On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: WPP tracing [1] allows kernel drivers to print logs that can be viewed without attaching a debugger to the running system. Traces are colelcted only when enabled. Instrument virt2phys

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-09-30 Thread William Tu
On Mon, Sep 20, 2021 at 1:11 PM Narcisa Ana Maria Vasile wrote: > > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system library. > > (Not in POSIX.1,

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
On 01/10/2021 01:12, Ajit Khaparde wrote: On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov wrote: Hi Ajit, On 01/10/2021 00:48, Ajit Khaparde wrote: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17e..7a8da3d7ab 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test

Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

2021-09-30 Thread Kadam, Pallavi
On 9/30/2021 9:46 AM, Thomas Monjalon wrote: 10/09/2021 01:23, Pallavi Kadam: IAVF PMD needs to generate a random MAC address if it is not configured by host. 'random' is now supported on Windows. This patch can be the first of this series to respect the dependency order. Fixes: 16f0d03098c

Re: [dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan

2021-09-30 Thread Long Li
> Subject: Re: [PATCH 1/3] bus/vmbus: fix leak on device scan > > On Wed, Sep 29, 2021 at 10:57 PM Long Li wrote: > > > > > Subject: [PATCH 1/3] bus/vmbus: fix leak on device scan > > > > > > Caught running ASAN. > > > > > > The device name is leaked on scan. > > > rte_device name field being a c

[dpdk-dev] [PATCH] mempool/stack: build on Windows

2021-09-30 Thread Jie Zhou
Enable the build of mempool/stack on Windows Signed-off-by: Jie Zhou --- drivers/mempool/stack/meson.build | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build index 371cf131b1..580dde79eb 100644 --- a/drivers/mempool/stac

Re: [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit tests on Windows

2021-09-30 Thread Jie Zhou
On Thu, Sep 23, 2021 at 10:35:37AM +0300, Dmitry Kozlyuk wrote: > 2021-09-08 15:14 (UTC-0700), Jie Zhou: > > On Tue, Sep 07, 2021 at 09:43:56AM -0400, Aaron Conole wrote: > > > Jie Zhou writes: > > > > > > > Enable a subset of unit tests on Windows. Currently not all the > > > > dependencies (e

[dpdk-dev] [PATCH v2] mempool/stack: build on Windows

2021-09-30 Thread Jie Zhou
enable build mempool/stack on Windows V2 change: - enable build lib stack on Windows which mempool/stack depends on Signed-off-by: Jie Zhou --- drivers/mempool/stack/meson.build | 5 - lib/meson.build | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ajit Khaparde
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 97ae52e17e..7a8da3d7ab 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1485,10 +1485,36 @@ static void > init_config_port_offloads(portid_t pid, uint32_t socket_id) > { > struct rte_port

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ajit Khaparde
On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov wrote: > > Hi Ajit, > > On 01/10/2021 00:48, Ajit Khaparde wrote: > > > >> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > >> index 97ae52e17e..7a8da3d7ab 100644 > >> --- a/app/test-pmd/testpmd.c > >> +++ b/app/test-pmd/testpmd.c > >>

Re: [dpdk-dev] [PATCH 05/11] bus/vmbus: open subchannels

2021-09-30 Thread Long Li
> Subject: [PATCH 05/11] bus/vmbus: open subchannels > > [You don't often get email from srikant...@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > In FreeBSD, unlike Linux there is no sub-channel open callback that could be > called by HV_U

Re: [dpdk-dev] [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels

2021-09-30 Thread Long Li
> Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels > > [You don't often get email from srikant...@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel >

Re: [dpdk-dev] [PATCH 00/11] add FreeBSD support to VMBUS & NetVSC PMDs

2021-09-30 Thread Long Li
> Subject: [PATCH 00/11] add FreeBSD support to VMBUS & NetVSC PMDs > > [You don't often get email from srikant...@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > This patch series adds support to VMBUS & NetVSC PMDs run on FreeBSD > > Srik

Re: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get

2021-09-30 Thread Naga Harish K, S V
Hi Ganapati, > -Original Message- > From: dev On Behalf Of Ganapati Kundapura > Sent: Thursday, September 30, 2021 6:30 PM > To: jerinjac...@gmail.com; dev@dpdk.org > Cc: Jayatheerthan, Jay > Subject: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf > get The commit mes

[dpdk-dev] [PATCH v3] eventdev/rx-adapter: fix segfault in que conf get

2021-09-30 Thread Ganapati Kundapura
rte_event_eth_rx_adapter_queue_conf_get() segfaults if called without queue added to the Rx adapter. Added check to no queues in Rx adapter and error out on being called with no queue in Rx adapter. Added test case to call queue conf get without queues in Rx adapter. Fixes: b36879759b7f3ce ("eve

Re: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get

2021-09-30 Thread Kundapura, Ganapati
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: 01 October 2021 10:12 > To: Kundapura, Ganapati ; > jerinjac...@gmail.com; dev@dpdk.org > Cc: Jayatheerthan, Jay > Subject: RE: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue > conf get > > Hi Ganapati, >

[dpdk-dev] [PATCH v4] eventdev/rx-adapter: fix segfault in queue conf get

2021-09-30 Thread Ganapati Kundapura
rte_event_eth_rx_adapter_queue_conf_get() segfaults if called without queue added to the Rx adapter. Added check to no queues in Rx adapter and error out on being called with no queue in Rx adapter. Added test case to call queue conf get without queues in Rx adapter. Fixes: b36879759b7f3ce ("eve

Re: [dpdk-dev] [PATCH v2 00/28] net/cnxk: support for inline ipsec

2021-09-30 Thread Jerin Jacob
On Thu, Sep 30, 2021 at 10:32 PM Nithin Dabilpuram wrote: > > Support for inline ipsec in CN9K event mode and in Cn10K event mode and > poll mode. > > Kommula Shiva Shankar (1): > common/cnxk: add CQ enable support in NIX Tx path > > Nithin Dabilpuram (18): > common/cnxk: support CPT parse hea

Re: [dpdk-dev] [PATCH] lib: remove sched.h from public headers

2021-09-30 Thread Thomas Monjalon
24/09/2021 00:34, William Tu: > On Sat, Aug 28, 2021 at 3:13 PM Dmitry Kozlyuk > wrote: > > > > Public headers including POSIX-specific were unusable > > on Windows. These includes were superfluous, remove them. > > > > Signed-off-by: Dmitry Kozlyuk > > --- > > Write a program, include rte_eal

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-09-30 Thread Andrew Rybchenko
On 9/30/21 10:30 PM, Ivan Malov wrote: > Hi Thomas, > > On 30/09/2021 19:18, Thomas Monjalon wrote: >> 23/09/2021 13:20, Ivan Malov: >>> In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace >>> intending to add new flags, RSS_HASH and FLOW_MARK. Since then, >>> only the former has bee

Re: [dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan

2021-09-30 Thread David Marchand
On Thu, Sep 30, 2021 at 9:14 PM Long Li wrote: > > rte_device name only points at some location where the name is stored. > > In general this storage is in the bus object or (in some buses) the devarg > > that > > resulted in the rte_device object creation. > > > > If we won't store the name in t

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Andrew Rybchenko
On 9/30/21 10:07 PM, Ivan Malov wrote: > Hi Ori, > > On 30/09/2021 17:59, Ori Kam wrote: >> Hi Ivan, >> Sorry for jumping in late. > > No worries. That's OK. > >> I have a concern that this patch breaks other PMDs. > > It does no such thing. > >>> From the rst file " One should negotiate flag

<    1   2   3