Re: [dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings

On Fri, Sep 3, 2021 at 1:53 AM David Christensen wrote: > > Suppress the gcc warning "note: the layout of aggregates containing > vectors with 4-byte alignment has changed in GCC 5" on POWER systems > by setting "-Wno-psabi". Warning was originally added to gcc in > commit https://gcc.gnu.org/gi

Re: [dpdk-dev] [PATCH] eal/ppc: ignore gcc 10 stringop-overflow warnings

On Fri, Sep 3, 2021 at 12:15 AM David Christensen wrote: > > Suppress gcc warning "warning: writing 16 bytes into a region of > size 0" for users of the POWER rte_memcpy() function. Existing > rte_memcpy() code takes different code paths based on the actual > size of the move so the warning is al

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

On 9/13/21 9:56 AM, Xu, Rosen wrote: > Hi, > >> -Original Message- >> From: Anoob Joseph >> Sent: Wednesday, September 08, 2021 18:30 >> To: Yigit, Ferruh ; Xu, Rosen ; >> Andrew Rybchenko >> Cc: Nicolau, Radu ; Doherty, Declan >> ; hemant.agra...@nxp.com; >> ma...@nvidia.com; Ananyev, K

Re: [dpdk-dev] [PATCH] checkpatches: suppress warning about strlcpy

On Fri, Sep 10, 2021 at 10:54:43AM -0700, Stephen Hemminger wrote: > Latest versions of Linux kernel checkpatch now complain about > uses of strlcpy (kernel perfers strcspy). > > WARNING:STRLCPY: Prefer strscpy over strlcpy > > But DPDK does not have strcspy so suppress the warning.

[dpdk-dev] [PATCH] eal: promote rte_mcfg_get_single_file_segment to stable ABI

Signed-off-by: Jakub Grajciar jgraj...@cisco.com --- doc/guides/rel_notes/release_21_11.rst | 3 +++ lib/eal/include/rte_eal_memconfig.h| 4 lib/eal/version.map| 4 +--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/doc/guide

[dpdk-dev] Questions about rte_eth_link_speed_to_str API

Hi all, I have questions about rte_eth_link_speed_to_str API. The API converts link speed to string for display, But it only supports the following speeds, like that: case ETH_SPEED_NUM_NONE: return "None"; case ETH_SPEED_NUM_10M: return "10 Mbps"; case ETH

[dpdk-dev] [PATCH v2] net/iavf: fix QFI fields of GTPU UL and DL for FDIR

Fix QFI fields matching of GTPU UL/DL for FDIR. Fixes: 78e8a87f6324 ("net/iavf: fix GTPU UL and DL support for flow director") Cc: sta...@dpdk.org Signed-off-by: Junfeng Guo Signed-off-by: Lingyu Liu --- V2: * Fix coding style issue --- drivers/net/iavf/iavf_fdir.c | 12 +++- 1 file ch

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

Hi Nélio, On 9/10/21 4:16 PM, Nélio Laranjeiro wrote: > On Fri, Sep 10, 2021 at 01:06:53PM +0300, Andrew Rybchenko wrote: >> On 9/10/21 12:57 PM, Maxime Coquelin wrote: >>> >>> >>> On 9/10/21 11:51 AM, Andrew Rybchenko wrote: On 9/10/21 12:17 PM, Maxime Coquelin wrote: > port_rss_hash_key

Re: [dpdk-dev] [PATCH RFC 0/1] vhost-add-DMADEV-support-for-async-datapath

Just as FYI, An alternate approach is up on the OVS mailing list : http://patchwork.ozlabs.org/project/openvswitch/list/?series=261277

Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API

13/09/2021 10:45, Min Hu (Connor): > Hi all, > I have questions about rte_eth_link_speed_to_str API. > The API converts link speed to string for display, But it only > supports the following speeds, like that: > case ETH_SPEED_NUM_NONE: return "None"; > case ETH_SPEED_NUM_10

Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode

On Thu, Sep 09, 2021 at 04:56:25PM +0100, David Hunt wrote: > Add non-interactive mode to dpdk-telemetry.py so that a query string > can be supplied on the command line, and script dumps out data and > exits. Handing for calling from scripts. > > Signed-off-by: David Hunt > --- Hi Dave, I'm not

[dpdk-dev] [PATCH 0/3] improvements for telemetry script

Patch 1 fixes errors reported by flake8 in the telemetry python script. Inspired by the work by Dave Hunt [1] the final two patches look to adjust the script so that it works nicer when commands come from an input pipe rather than from an interactive terminal. Without this set: $ echo "/eal/para

[dpdk-dev] [PATCH 1/3] usertools/dpdk-telemetry: fix flake8 errors

Fix style errors reported by flake8. Fixes: 6a2967c112a3 ("usertools: add new telemetry script") Fixes: 2d9a697e41ca ("usertools: add file-prefix option for telemetry") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- usertools/dpdk-telemetry.py | 9 - 1 file changed, 4 insertion

[dpdk-dev] [PATCH 2/3] usertools/dpdk_telemetry: fix handling EOF for input pipe

To allow the script to take queries from input pipes e.g. "echo /ethdev/stats,0 | dpdk-telemetry.py", we need to handle the case of EOF correctly without crashing with an exception. Do this by using a try-except block around the input handling. Fixes: 6a2967c112a3 ("usertools: add new telemetry sc

[dpdk-dev] [PATCH 3/3] usertools/dpdk-telemetry: silence prompts for input pipes

When the input to the script is coming from a device which is not a TTY then we become less verbose and skip the prompts and helpful messages about what is happening. Signed-off-by: Bruce Richardson --- usertools/dpdk-telemetry.py | 15 ++- 1 file changed, 10 insertions(+), 5 deletio

Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode

On Mon, Sep 13, 2021 at 11:43:25AM +0100, Bruce Richardson wrote: > On Thu, Sep 09, 2021 at 04:56:25PM +0100, David Hunt wrote: > > Add non-interactive mode to dpdk-telemetry.py so that a query string > > can be supplied on the command line, and script dumps out data and > > exits. Handing for call

[dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts

Only a single DPDK process on the system can be using the /dev/contigmem mappings at a time, but this was never explicitly enforced, e.g. when using --in-memory flag on two processes. To prevent possible conflict issues, we lock the dev node when it's in use, preventing other DPDK processes from st

[dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

From: Viacheslav Galaktionov Getting a list of representors from a representor does not make sense. Instead, a parent device should be used. To this end, extend the rte_eth_dev_data structure to include the port ID of the backing device for representors. Signed-off-by: Viacheslav Galaktionov S

Re: [dpdk-dev] [PATCH 1/8] bus/pci: add new memory resource access APIs

On 10/09/2021 03:23, Chenbo Xia wrote: > Some applications wants to access PCI memory resource. Currently > applications use struct rte_pci_device to access it. Since the > structure will be made internal later, this patch adds two APIs > for memory resource access. > > Signed-off-by: Chenbo Xi

Re: [dpdk-dev] [PATCH 8/8] bus/pci: remove ABIs in PCI bus

On 10/09/2021 03:24, Chenbo Xia wrote: > As announced in the deprecation note, most of ABIs in PCI bus are > removed in this patch. Only the function rte_pci_dump is still ABI > and experimental APIs are kept for future promotion. > > This patch creates a new file named pci_driver.h and moves m

[dpdk-dev] [PATCH] examples: ipv4, udp and tcp checksum offload warning

Closes gracefully if IPV4 checksum offload is not available. Gives warning if UDP or TCP checksum offloads are not available. Signed-off-by: usamanadeem321 --- examples/l3fwd/main.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd/main

Re: [dpdk-dev] [RFC 1/1] net/mlx5: set txq affinity in round-robin

On 10/09/2021 05:23, Rongwei Liu wrote: > Previously, we set txq affinity to 0 and let firmware > to perform round-robin when bonding. Firmware uses a > global counter to assign txq affinity to different > physical ports accord to remainder after division. > > There are three dis-advantages: >

Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts

On 13-Sep-21 12:06 PM, Bruce Richardson wrote: Only a single DPDK process on the system can be using the /dev/contigmem mappings at a time, but this was never explicitly enforced, e.g. when using --in-memory flag on two processes. To prevent possible conflict issues, we lock the dev node when it'

Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts

On Mon, Sep 13, 2021 at 02:14:55PM +0100, Burakov, Anatoly wrote: > On 13-Sep-21 12:06 PM, Bruce Richardson wrote: > > Only a single DPDK process on the system can be using the /dev/contigmem > > mappings at a time, but this was never explicitly enforced, e.g. when > > using --in-memory flag on two

[dpdk-dev] [PATCH v2] net/af_packet: fix ignoring full ring on tx

The poll call can return POLLERR which is ignored, or it can return POLLOUT, even if there are no free frames in the mmap-ed area. We can account for both of these cases by re-checking if the next frame is empty before writing into it. Signed-off-by: Mihai Pogonaru Signed-off-by: Tudor Cornea -

Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts

2021-09-13 14:14 (UTC+0100), Burakov, Anatoly: > [...] > I'm a bit uneasy with --in-memory mode pretending > to work on FreeBSD and Windows, but that's a separate problem :) On Windows, --in-memory does not pretend to work, just the opposite, it is enabled implicitly as it's the only working mode

[dpdk-dev] [PATCH v2] eal/freebsd: lock memory device to prevent conflicts

Only a single DPDK process on the system can be using the /dev/contigmem mappings at a time, but this was never explicitly enforced, e.g. when using --in-memory flag on two processes. To prevent possible conflict issues, we lock the dev node when it's in use, preventing other DPDK processes from st

[dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status

We should eliminate the timestamp status from the packet status. This should only matter if timestamping is enabled on the socket, but we might hit a kernel bug, which is fixed in newer releases. For interfaces of type 'veth', the sent skb is forwarded to the peer and back into the network stack w

Re: [dpdk-dev] [PATCH 0/8] cryptodev: hide internal strutures

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 1/8] cryptodev: separate out internal structures

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 2/8] cryptodev: move inline APIs into separate structure

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 3/8] cryptodev: add helper functions for new datapath interface

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 4/8] cryptodev: use new API for datapath functions

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 5/8] drivers/crypto: use new framework for datapath

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 6/8] crypto/scheduler: rename enq-deq functions

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 7/8] crypto/scheduler: update for new datapath framework

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 8/8] cryptodev: move device specific structures

> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

[dpdk-dev] [PATCH] eal/freebsd: ignore in-memory option

The in-memory option is not supported on FreeBSD so print a warning and ignore the flag when it is specified for BSD apps. The lack of support is due to the different way in which memory is managed on FreeBSD using the contigmem driver rather than via a hugetlbfs filesystem. Fixes: 14de8734c401 ("

Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts

On 13-Sep-21 2:36 PM, Bruce Richardson wrote: On Mon, Sep 13, 2021 at 02:14:55PM +0100, Burakov, Anatoly wrote: On 13-Sep-21 12:06 PM, Bruce Richardson wrote: Only a single DPDK process on the system can be using the /dev/contigmem mappings at a time, but this was never explicitly enforced, e.g

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

On Mon, 13 Sep 2021 05:27:12 + "Peng, ZhihongX" wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Friday, September 10, 2021 10:48 AM > > To: Peng, ZhihongX > > Cc: Burakov, Anatoly ; Ananyev, Konstantin > > ; dev@dpdk.org; Lin, Xueqin > > > > Subject: Re: [PATCH]

Re: [dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status

On Mon, 13 Sep 2021 17:09:11 +0300 Tudor Cornea wrote: > +static inline bool tx_ring_status_unavailable(uint32_t tp_status) > +{ > +#if KERNEL_VERSION(5, 10, 0) > LINUX_VERSION_CODE No, having kernel dependent userspace in DPDK is not good practice. Distribution vendors don't number their kerne

Re: [dpdk-dev] [PATCH] examples: ipv4, udp and tcp checksum offload warning

On Mon, 13 Sep 2021 17:09:51 +0500 usamanadeem321 wrote: > > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_IPV4_CKSUM) > + local_port_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_IPV4_CKSUM; > + else { > + rte_

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

On Mon, Sep 13, 2021 at 08:05:58AM -0700, Stephen Hemminger wrote: > On Mon, 13 Sep 2021 05:27:12 + > "Peng, ZhihongX" wrote: > > > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Friday, September 10, 2021 10:48 AM > > > To: Peng, ZhihongX > > > Cc: Burakov, Anatoly

Re: [dpdk-dev] [DPDK] net/virtio: fix check scatter on all Rx queues

Hi Zhihong, On 8/4/21 10:31 AM, zhihongx.p...@intel.com wrote: > From: Zhihong Peng > > This patch fixes the wrong way to obtain virtqueue. > The end of virtqueue cannot be judged based on whether > the array is NULL. My understanding is that it is causing issue because it is confusing the cont

Re: [dpdk-dev] [PATCH 1/2] net/virtio: fix Tx cleanup functions to have same signature

On 8/18/21 4:13 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > There is a family of cleanup from completed transmits functions. > Fix packed virtqueues cleanup functions to have the same signature > as split virtqueues have. This lets all functions of the family to > match the same call

Re: [dpdk-dev] [PATCH 2/2] net/virtio: fix Tx completed mbufs leak on device stop

On 8/18/21 4:13 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Free Tx completed mbufs on device stop. Not completed Tx mbufs cannot be > freed since they are still in use. > > Fixes: c1f86306a02 ("virtio: add new driver") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Ilchenko > Sign

Re: [dpdk-dev] DPDK Max Mbuf Allocation

On 9/13/2021 5:56 AM, Kamaraj P wrote: > Hello All, > > Would like to understand or if there are any guidelines to allocate the max > no of mbuf per NIC ? > For example, if i have defined as below: > #define RX_RING_SIZE 1024 > #define TX_RING_SIZE 1024 > > The Maximum RX/TX queues can be defined

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

On Mon, 13 Sep 2021 16:22:13 +0100 Bruce Richardson wrote: > On Mon, Sep 13, 2021 at 08:05:58AM -0700, Stephen Hemminger wrote: > > On Mon, 13 Sep 2021 05:27:12 + > > "Peng, ZhihongX" wrote: > > > > > > -Original Message- > > > > From: Stephen Hemminger > > > > Sent: Friday, Sept

Re: [dpdk-dev] [PATCH] examples/vhost: change the default value of NIC's max queues

On 9/10/21 5:17 AM, Xia, Chenbo wrote: > Hi Wenwu, > >> -Original Message- >> From: Ma, WenwuX >> Sent: Friday, September 10, 2021 9:52 PM >> To: dev@dpdk.org >> Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Jiang, >> Cheng1 ; Hu, Jiayu ; Wang, Yinan >> ; Ma, WenwuX >> Subject: [PATCH

Re: [dpdk-dev] DPDK Max Mbuf Allocation

On Mon, 13 Sep 2021 16:43:18 +0100 Ferruh Yigit wrote: > On 9/13/2021 5:56 AM, Kamaraj P wrote: > > Hello All, > > > > Would like to understand or if there are any guidelines to allocate the max > > no of mbuf per NIC ? > > For example, if i have defined as below: > > #define RX_RING_SIZE 1024 >

Re: [dpdk-dev] [PATCH] vhost: promote some APIs to stable

On 9/9/21 1:19 PM, Kinsella, Ray wrote: > > > On 09/09/2021 03:13, Xia, Chenbo wrote: >> Hi Kevin, >> >>> -Original Message- >>> From: Kevin Traynor >>> Sent: Wednesday, September 8, 2021 8:01 PM >>> To: Xia, Chenbo ; dev@dpdk.org; >>> maxime.coque...@redhat.com >>> Cc: Liu, Changpeng

[dpdk-dev] [PATCH v2 00/18] fix spelling errors

After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments. v2 - more spelling fixes in bpf library Stephen Hemminger (18): node: fix typos ipsec: fix spelling errors eventdev: fix typo in comment power:

[dpdk-dev] [PATCH v2 01/18] node: fix typos

Spelling errors in comments including doxygen Signed-off-by: Stephen Hemminger --- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node/ethdev_rx_priv.h b/lib/node/ethde

[dpdk-dev] [PATCH v2 02/18] ipsec: fix spelling errors

Lots of typos in comments found by codespell Signed-off-by: Stephen Hemminger --- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c| 2 +- lib/ipsec/sa.h| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 03/18] eventdev: fix typo in comment

Typo in comment found by codespell Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index ee20b39f4b24..b5c2dc1427c6 100

[dpdk-dev] [PATCH v2 04/18] power: fix typo in comment

More spelling errors caught by codespell Signed-off-by: Stephen Hemminger --- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 1e8aeb84037c..402ed8c99b42 100644 --- a/lib/power

[dpdk-dev] [PATCH v2 05/18] rcu: fix typo in comment

Another codespell find. Signed-off-by: Stephen Hemminger --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 18811c1cc106..62a420a785fc 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.

[dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/bpf/bpf_

[dpdk-dev] [PATCH v2 07/18] acl: fix spelling errors

Lots of little typos in comments Signed-off-by: Stephen Hemminger --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 4089ab2a0462..f5739a475cf0 10064

[dpdk-dev] [PATCH v2 08/18] eal: fix typos in comments

Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[dpdk-dev] [PATCH v2 09/18] net: fix spelling error in gtp comment

More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 6a6f9b238db9..f22dbce47c65 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -64,9 +64,9 @@ s

[dpdk-dev] [PATCH v2 10/18] bbdev: fix typo in comment

Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index fc37236195be..49a0de49d8df 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/li

[dpdk-dev] [PATCH v2 11/18] pipeline: fix spellin error in comment

Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index cd395ac39dbb..9bfc69b2bb4f 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[dpdk-dev] [PATCH v2 12/18] hash: fix typo in comment

Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index d5a95a6e009a..f5e9111f0264 100644 --- a/lib/hash/rte_thash.c +++ b/lib/ha

[dpdk-dev] [PATCH v2 13/18] rib: fix typo in comment

Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index 96424e9c9f4f..4a6f29b0040d 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_ri

[dpdk-dev] [PATCH v2 14/18] sched: fix typo in comment

Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index a858f61f9548..329f4b2e7b48 100644 --- a/lib/sched/rte_sched.c +++ b/li

[dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment

Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index 8d875e932297..c36dfc705b04 100644 --- a/lib/vhost/rte_vhost.h +++

[dpdk-dev] [PATCH v2 16/18] ip_frag: fix typos

Minor typos in comment. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a 100644 --- a/lib/ip_frag/rte_

[dpdk-dev] [PATCH v2 17/18] test-pmd: fix spelling errors in comments

More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc75110..2628bd64dae6 100644

[dpdk-dev] [PATCH v2 18/18] test: fix spelling errors in comments

Lots of little typos. Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c

[dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to internal header file

Start to consolidate the data structures and inline functions required by the pipeline instructions into an internal header file. Signed-off-by: Cristian Dumitrescu --- Depends-on: series-18297 ("[V4,1/4] table: add support learner tables") V3: -fixed meson.build lib/pipeline/rte_swx_pipeline.

[dpdk-dev] [PATCH V3 02/24] pipeline: move thread inline functions to header file

Move the thread inline functions to the internal header file. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 56 -- lib/pipeline/rte_swx_pipeline_internal.h | 59 2 files changed, 59 insertions(+), 56 deletions(-) d

[dpdk-dev] [PATCH V3 03/24] pipeline: create inline functions for RX instruction

Create inline functions for the RX instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 38 -- lib/pipeline/rte_swx_pipeline_internal.h | 51 2 files changed, 51 insertions(+), 38 deletions(-) diff --git a/lib/pi

[dpdk-dev] [PATCH V3 04/24] pipeline: create inline functions for TX instruction

Create inline functions for the TX instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 86 +- lib/pipeline/rte_swx_pipeline_internal.h | 90 2 files changed, 92 insertions(+), 84 deletions(-) diff --git a/li

[dpdk-dev] [PATCH V3 06/24] pipeline: create inline functions for emit instruction

Create inline functions for the emit instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 162 - lib/pipeline/rte_swx_pipeline_internal.h | 170 +++ 2 files changed, 228 insertions(+), 104 deletions(-) diff --git

[dpdk-dev] [PATCH V3 05/24] pipeline: create inline functions for extract instruction

Create inline functions for the extract instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 130 - lib/pipeline/rte_swx_pipeline_internal.h | 178 +++ 2 files changed, 203 insertions(+), 105 deletions(-) diff --git a

[dpdk-dev] [PATCH V3 07/24] pipeline: create inline functions for validate instruction

Create inline functions for the validate and invalidate instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 12 ++--- lib/pipeline/rte_swx_pipeline_internal.h | 32 2 files changed, 34 insertions(+), 10 deletions(-) diff -

[dpdk-dev] [PATCH V3 08/24] pipeline: create inline functions for learn instruction

Create inline functions for the learn and forget instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 36 ++-- lib/pipeline/rte_swx_pipeline_internal.h | 55 2 files changed, 58 insertions(+), 33 deletions(-) diff -

[dpdk-dev] [PATCH V3 09/24] pipeline: create inline functions for extern instruction

Create inline functions for the extern instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 22 +++- lib/pipeline/rte_swx_pipeline_internal.h | 43 2 files changed, 47 insertions(+), 18 deletions(-) diff --git a/lib/pipe

[dpdk-dev] [PATCH V3 10/24] pipeline: create inline functions for move instruction

Create inline functions for the move instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 26 +++- lib/pipeline/rte_swx_pipeline_internal.h | 53 2 files changed, 58 insertions(+), 21 deletions(-) diff --git a/lib/pipeli

[dpdk-dev] [PATCH V3 11/24] pipeline: create inline functions for DMA instruction

Create inline functions for the DMA instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 80 ++ lib/pipeline/rte_swx_pipeline_internal.h | 100 +++ 2 files changed, 123 insertions(+), 57 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH V3 12/24] pipeline: create inline functions for ALU instructions

Create inline functions for the ALU instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 348 ++--- lib/pipeline/rte_swx_pipeline_internal.h | 616 +++ 2 files changed, 660 insertions(+), 304 deletions(-) diff --git a/lib/pi

[dpdk-dev] [PATCH V3 13/24] pipeline: create inline functions for register instructions

Create inline functions for the register instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 320 ++- lib/pipeline/rte_swx_pipeline_internal.h | 475 +++ 2 files changed, 502 insertions(+), 293 deletions(-) diff --git a

[dpdk-dev] [PATCH V3 15/24] pipeline: create inline functions for instruction operands

Create inline functions to get the instruction operands. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline_internal.h | 29 1 file changed, 29 insertions(+) diff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/pipeline/rte_swx_pipeline_interna

[dpdk-dev] [PATCH V3 14/24] pipeline: create inline functions for meter instructions

Create inline functions for the meter instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 457 +-- lib/pipeline/rte_swx_pipeline_internal.h | 541 +++ 2 files changed, 558 insertions(+), 440 deletions(-) diff --git

[dpdk-dev] [PATCH V3 16/24] pipeline: enable persistent instruction meta-data

Save the instruction meta-data for later use instead of freeing it up once the instruction translation is completed. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 9 ++--- lib/pipeline/rte_swx_pipeline_internal.h | 2 ++ 2 files changed, 8 insertions(+), 3

[dpdk-dev] [PATCH V3 17/24] pipeline: introduce action functions

For better performance, the option to run a single function per action is now provided, which requires a single function call per action that can be better optimized by the C compiler, as opposed to one function call per instruction. Special table lookup instructions are added to to support this fe

[dpdk-dev] [PATCH V3 18/24] pipeline: introduce custom instructions

For better performance, the option to create custom instructions when the program is translated and add them on-the-fly to the pipeline is now provided. Multiple regular instructions can now be consolidated into a single C function optimized by the C compiler directly. Signed-off-by: Cristian Dumi

[dpdk-dev] [PATCH V3 19/24] pipeline: introduce pipeline compilation

Lay the foundation to generate C code for the pipeline: C functions for actions and custom instructions are generated, built as shared object library and loaded into the pipeline. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 44 + 1 fil

[dpdk-dev] [PATCH V3 20/24] pipeline: export pipeline instructions to file

Export the array of translated instructions to a C file. There is one such array per action and one for the pipeline. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 1093 +++ 1 file changed, 1093 insertions(+) diff --git a/lib/pipeline/rte_s

[dpdk-dev] [PATCH V3 21/24] pipeline: generate action functions

Generate a C function for each action. For most instructions, the associated inline function is called directly. Special care is taken for TX, jump and return instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 662 1 file chang

[dpdk-dev] [PATCH V3 22/24] pipeline: generate custom instruction functions

Generate a C function for each custom instruction, which essentially consolidate multiple regular instructions into a single function call. The pipeline program is split into groups of instructions, and a custom instruction is generated for each group that has more than one instruction. Special car

[dpdk-dev] [PATCH V3 23/24] pipeline: build shared object for pipeline

Build the generated C file into a shared object library. Signed-off-by: Cristian Dumitrescu Signed-off-by: Cunming Liang --- lib/pipeline/rte_swx_pipeline.c | 131 +++ lib/pipeline/rte_swx_pipeline_internal.h | 1 + 2 files changed, 132 insertions(+) diff --git a

[dpdk-dev] [PATCH V3 24/24] pipeline: enable pipeline compilation

Commit the pipeline changes when the compilation process is successful: change the table lookup instructions to execute the action function for each action, replace the regular pipeline instructions with the custom instructions. Signed-off-by: Cristian Dumitrescu --- V3: -added more checks lib/

Re: [dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to internal header file

On Mon, 13 Sep 2021 17:44:20 +0100 Cristian Dumitrescu wrote: > Start to consolidate the data structures and inline functions required > by the pipeline instructions into an internal header file. > > Signed-off-by: Cristian Dumitrescu > --- > Depends-on: series-18297 ("[V4,1/4] table: add suppo

Re: [dpdk-dev] [PATCH v3 6/6] bbdev: reduce warning level for one scenario

> -Original Message- > From: Tom Rix > Sent: Sunday, September 12, 2021 5:55 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan > ; Joshi, Arun > Subject: Re: [PATCH v3 6/6] bbdev: reduce warning level for one

Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to internal header file

> -Original Message- > From: Richardson, Bruce > Sent: Friday, September 10, 2021 3:09 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to > internal header file > > On Fri, Sep 10, 2021 at 02:36:50PM +0100, Cri

[dpdk-dev] [PATCH v2] net/af_packet: remove timestamp from packet status

We should eliminate the timestamp status from the packet status. This should only matter if timestamping is enabled on the socket, but we might hit a kernel bug, which is fixed in newer releases. For interfaces of type 'veth', the sent skb is forwarded to the peer and back into the network stack w

Re: [dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status

Thanks for the observation. I have removed the compile-time kernel version check in v2 of the patch On Mon, 13 Sept 2021 at 18:09, Stephen Hemminger wrote: > On Mon, 13 Sep 2021 17:09:11 +0300 > Tudor Cornea wrote: > > > +static inline bool tx_ring_status_unavailable(uint32_t tp_status) > > +

[dpdk-dev] [PATCH] crypto/mlx5: fix crypto QP indexing

The crypto QP consumer (ci) and producer (pi) indexes are increased with each successful enqueue/dequeue operations. However the QP pi index is calculated with a wraparound the number of elements while the QP ci does not. This is causing incorrect engine calculation for encqueued WQ values (wq->p

  1   2   >