On Thu, Sep 09, 2021 at 04:56:25PM +0100, David Hunt wrote: > Add non-interactive mode to dpdk-telemetry.py so that a query string > can be supplied on the command line, and script dumps out data and > exits. Handing for calling from scripts. > > Signed-off-by: David Hunt <david.h...@intel.com> > --- Hi Dave,
I'm not sure I like the use of "-q" for adding a query mode - it's more a shortcut parameter for a "quiet" mode. If I may, I'd suggest an alternative approach here might be to improve support for piping the input commands to the script instead so that you can do e.g. "echo /ethdev/stats,0 | dpdk-telemetry.py" and have that work well in a script. I'll do up a patchset for improving that and upstream it for feedback. /Bruce
