[dpdk-dev] [Bug 794] [dpdk-19.11.10] loopback_multi_queues: core dumped when quit vhost testpmd

2021-09-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=794 linglix.c...@intel.com changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

[dpdk-dev] 回复: [RFC PATCH v1 0/5] add new API for wait until scheme

2021-09-03 Thread Feifei Wang
Hi, Stephen Thanks for the reviewing. I think it is a good comment. According to the comments, we plan to change this API as follow: #define wait_until_event_16(addr, mask, expected, op, memorder) uint16_t value __LOAD_EXC_16(addr, value, memorder) if ((value&mask) op expe

Re: [dpdk-dev] [PATCH v2 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-09-03 Thread David Marchand
On Thu, Sep 2, 2021 at 8:01 PM Apeksha Gupta wrote: > > ENETFEC (Fast Ethernet Controller) is a network poll mode driver > for NXP SoC i.MX 8M Mini. > > This patch adds skeleton for enetfec driver with probe function. > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta > --- > doc/g

[dpdk-dev] [PATCH 1/4] bus/dpaa: remove experimental tag and move to internal

2021-09-03 Thread Nipun Gupta
remove experimental tag from internal API dpaa_seqn. This API was introduced in DPDK 20.11 and is now moved to internal tag Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/rte_dpaa_bus.h | 5 + drivers/bus/dpaa/version.map| 1 + 2 files changed, 2 insertions(+), 4 deletions(-) diff --gi

[dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

2021-09-03 Thread Nipun Gupta
This API was introduced in 19.08, therefore removing experimental tag to promote them to stable state. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/fslmc_vfio.h | 1 - drivers/bus/fslmc/version.map | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fslmc/fs

[dpdk-dev] [PATCH 3/4] bus/fslmc: remove experimental and move to internal

2021-09-03 Thread Nipun Gupta
remove experimental tag from internal API dpaa2_seqn. This API was introduced in DPDK 20.11 and is now moved to internal tag Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/rte_fslmc.h | 5 + drivers/bus/fslmc/version.map | 1 + 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [PATCH 4/4] net/dpaa2: remove experimental tag from API

2021-09-03 Thread Nipun Gupta
These APIs were introduced in 19.02, therefore removing experimental tag to promote them to stable state. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/rte_pmd_dpaa2.h | 12 drivers/net/dpaa2/version.map | 8 +++- 2 files changed, 7 insertions(+), 13 deletions(-) diff -

[dpdk-dev] [PATCH v1] ethdev: clarify flow action PORT ID semantics

2021-09-03 Thread Andrew Rybchenko
From: Ivan Malov Definition of action PORT_ID is ambiguous. Documentation says "Directs matching traffic to a given DPDK port ID." It suggests that an application will receive corresponding traffic on the port using ethdev Rx burst API. Some network PMDs implement PORT_ID action this way. Howev

[dpdk-dev] [PATCH] vhost: call destroy_device always in vhost_destroy_device_notify

2021-09-03 Thread Li Feng
Vhost-user client must send the mem table, kick fd, call fd on all vas, then the device will be VIRTIO_DEV_RUNNING. If the vhost-user communication is initialized partly, e.g. - When initializing the vhost-user, try to restart the vhost-user backend; - Seabios only initialized the vhost-scsi r

[dpdk-dev] [PATCH v2] vhost: call destroy_device always in vhost_destroy_device_notify

2021-09-03 Thread Li Feng
Vhost-user client must send the mem table, kick fd, call fd on all virtqueues, then the device will be VIRTIO_DEV_RUNNING. If the vhost-user communication is initialized partly, e.g. - When initializing the vhost-user, try to restart the vhost-user backend; - Seabios only initialized the vhost

Re: [dpdk-dev] Intel FW 8.15 with DPDK 20.11 & 21.02

2021-09-03 Thread Ferruh Yigit
On 9/2/2021 10:40 PM, Korolevskiy, Igor wrote: > Dear DPDK community, > > Would you please help us to understand if we can use Intel 8.15 firmware with > DPDK 20.11 and 21.02 versions? > > We have huge demand on our servers with usage of Nokia SBC and DPDK, but > stuck on validation. > > Thank

Re: [dpdk-dev] Intel FW 8.15 with DPDK 20.11 & 21.02

2021-09-03 Thread Korolevskiy, Igor
Hi team, Thank you for your reply. Intel card in dual port X710 in PCI-e slot. Igor Korolevskiy | System Consultant @ Dell Technologies Data Center Sales Department m: +7(903)536-54-77 Planned OOO: 30 Aug-3 Sept 13 - 28 Sept Internal Use - Confidential -Original Message- From: Fe

[dpdk-dev] [PATCH v4] net/mlx5: fix mutex unlock in txpp cleanup

2021-09-03 Thread Chengfeng Ye
The lock sh->txpp.mutex was not correctly released if the function returned in these two branches, which may led to deadlock if the function was acquired again. Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") Cc: sta...@dpdk.org Signed-off-by: Chengfeng Ye --- drivers/net/m

Re: [dpdk-dev] |FAILURE| pw97277 [PATCH] [v4] eal: read data buffer on RTE_INTR_HANDLE_VFIO_REQ

2021-09-03 Thread Szwed, Maciej
Hi, I still need a help regarding this issue. Regards, Maciek -Original Message- From: dev On Behalf Of Szwed, Maciej Sent: Monday, August 30, 2021 11:34 AM To: dev@dpdk.org Subject: Re: [dpdk-dev] |FAILURE| pw97277 [PATCH] [v4] eal: read data buffer on RTE_INTR_HANDLE_VFIO_REQ Hi, I'm

Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to negotiate support for Rx meta information

2021-09-03 Thread Jerin Jacob
On Thu, Sep 2, 2021 at 7:54 PM Ivan Malov wrote: > > Per-packet meta information (flag, mark and the likes) might > be expensive to deliver in terms of small packet performance. > If the features are not enabled by default, enabling them at > short notice (for example, when a flow rule with action

Re: [dpdk-dev] [PATCH v3 1/5] test/crypto: add lookaside IPsec tests

2021-09-03 Thread Power, Ciara
Hi Anoob, Left some comments/questions inline. Thanks, Ciara >-Original Message- >From: Anoob Joseph >Sent: Friday 3 September 2021 05:47 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; >Ananyev, Konstantin >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >

Re: [dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests

2021-09-03 Thread Power, Ciara
Hi Anoob, >-Original Message- >From: Anoob Joseph >Sent: Friday 3 September 2021 05:47 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; >Ananyev, Konstantin >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >; Hemant Agrawal ; >Nicolau, Radu ; Power, Ciara >;

Re: [dpdk-dev] [PATCH] net/af_packet: try to reinsert the stripped vlan tag

2021-09-03 Thread Tudor Cornea
Thanks, I hope I understood correctly the above comments. I'm thinking of adding DEV_RX_OFFLOAD_VLAN_STRIP to dev_info->rx_offload_capa eth_dev_info() +dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP; then populating pmd_internals->vlan_strip with the vlan stripping option that the applic

Re: [dpdk-dev] [PATCH v3 1/5] test/crypto: add lookaside IPsec tests

2021-09-03 Thread Anoob Joseph
Hi Ciara, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Power, Ciara > Sent: Friday, September 3, 2021 3:09 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan ; Ananyev, Konstantin > > Cc: Jerin Jacob Kollanukkaran ; Archan

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD

2021-09-03 Thread Ferruh Yigit
On 8/18/2021 5:42 PM, Bruce Richardson wrote: > On Wed, Aug 18, 2021 at 05:38:15PM +0100, Bruce Richardson wrote: >> The common header file for vectorization is included in multiple files, >> and so must use macros for the current compilation unit, rather than the >> compiler-capability flag set fo

[dpdk-dev] [PATCH] net/ice: fix double free ACL flow entry

2021-09-03 Thread dapengx . yu
From: Dapeng Yu If call ice_flow_rem_entry() directly without checking entry_id, may cause an ACL flow entry to be freed more than once. This patch tries to find entry_id first, then call ice_flow_rem_entry() to avoid the defect. Fixes: 40d466fa9f76 ("net/ice: support ACL filter in DCF") Cc: st

Re: [dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests

2021-09-03 Thread Anoob Joseph
Hi Ciara, Please see inline. Thanks, Anoob > > External Email > > -- > Hi Anoob, > > >-Original Message- > >From: Anoob Joseph > >Sent: Friday 3 September 2021 05:47 > >To: Akhil Goyal ; Doherty, Declan > >; Zhang, R

Re: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5

2021-09-03 Thread Shahaf Shuler
Monday, August 23, 2021 5:51 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5 > > For net/mlx4: > - removing Shahaf Shuler > - adding Viacheslav Ovsiienko > > For net/mlx5: > - removing Shahaf Shuler > > Signed-off-by: Viacheslav Ovsiie

Re: [dpdk-dev] [PATCH v1 1/4] common/iavf: add QFI fields for GTPU UL and DL

2021-09-03 Thread Ferruh Yigit
On 8/17/2021 8:16 AM, Haiyue Wang wrote: > From: Junfeng Guo > > Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR. Can you please put what 'QFI' stands for in the commit log, I assume it is "QoS Flow Identifier"? What does it mean to add new protocol fields to the virtchnl? And commit log men

Re: [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for L4 checksum

2021-09-03 Thread Ferruh Yigit
On 8/17/2021 8:16 AM, Haiyue Wang wrote: > From: Alvin Zhang > > Add TCP/UDP/SCTP header checksum field selectors. > Hi Alvin, Haiyue, Can you please describe a little more, what is the impact of adding proto hdr checksum field selector? Is this also something related to the flow director as

[dpdk-dev] [PATCH v2 00/16] add dmadev driver for idxd devices

2021-09-03 Thread Kevin Laatz
This patchset adds a dmadev driver and associated documentation to support Intel Data Streaming Accelerator devices. This driver is intended to ultimately replace the current IDXD part of the IOAT rawdev driver. NOTE: This patchset has several dependencies: - v19 of the dmadev set [1] - v2 of t

[dpdk-dev] [PATCH v2 01/16] raw/ioat: only build if dmadev not present

2021-09-03 Thread Kevin Laatz
From: Bruce Richardson Only build the rawdev IDXD/IOAT drivers if the dmadev drivers are not present. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/meson.build | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/raw/ioat/meson.build b/dri

[dpdk-dev] [PATCH v2 02/16] doc: initial commit for dmadevs section

2021-09-03 Thread Kevin Laatz
Add new section to the programmer's guide for dmadev devices. Signed-off-by: Kevin Laatz --- doc/guides/dmadevs/index.rst | 14 ++ doc/guides/index.rst | 1 + 2 files changed, 15 insertions(+) create mode 100644 doc/guides/dmadevs/index.rst diff --git a/doc/guides/dmadevs/

[dpdk-dev] [PATCH v2 03/16] dma/idxd: add skeleton for VFIO based DSA device

2021-09-03 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- MAINTAINERS| 10 + doc/guides/dmadevs/idxd.rst

[dpdk-dev] [PATCH v2 04/16] dma/idxd: add bus device probing

2021-09-03 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- doc/guides/dma

[dpdk-dev] [PATCH v2 05/16] dma/idxd: create dmadev instances on bus probe

2021-09-03 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_bus.c | 20 - drivers/dma/idx

[dpdk-dev] [PATCH v2 06/16] dma/idxd: create dmadev instances on pci probe

2021-09-03 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_hw_defs.h | 71 drivers/dma/idxd/idxd_internal.h | 14 ++

[dpdk-dev] [PATCH v2 07/16] dma/idxd: add datapath structures

2021-09-03 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- v2: add completion status for invalid opcode --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33 ++ drivers/dma/idxd/i

[dpdk-dev] [PATCH v2 08/16] dma/idxd: add configure and info_get functions

2021-09-03 Thread Kevin Laatz
Add functions for device configuration. The info_get function is included here since it can be useful for checking successful configuration. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- v2: - fix reconfigure bug in idxd_vchan_setup() - add literal include comment for the

[dpdk-dev] [PATCH v2 09/16] dma/idxd: add start and stop functions for pci devices

2021-09-03 Thread Kevin Laatz
Add device start/stop functions for DSA devices bound to vfio. For devices bound to the IDXD kernel driver, these are not required since the IDXD kernel driver takes care of this. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_pci.c | 52 +++

[dpdk-dev] [PATCH v2 10/16] dma/idxd: add data-path job submission functions

2021-09-03 Thread Kevin Laatz
Add data path functions for enqueuing and submitting operations to DSA devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- doc/guides/dmadevs/idxd.rst | 64 +++ drivers/dma/idxd/idxd_common.c | 137 +++ drivers/dma/idxd/idxd_in

[dpdk-dev] [PATCH v2 11/16] dma/idxd: add data-path job completion functions

2021-09-03 Thread Kevin Laatz
Add the data path functions for gathering completed operations. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- v2: - fixed typo in docs - add completion status for invalid opcode --- doc/guides/dmadevs/idxd.rst | 25 drivers/dma/idxd/idxd_common.c | 237 +

[dpdk-dev] [PATCH v2 12/16] dma/idxd: add operation statistic tracking

2021-09-03 Thread Kevin Laatz
Add statistic tracking for DSA devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- doc/guides/dmadevs/idxd.rst | 11 +++ drivers/dma/idxd/idxd_bus.c | 2 ++ drivers/dma/idxd/idxd_common.c | 27 +++ drivers/dma/idxd/idxd_internal.h

[dpdk-dev] [PATCH v2 13/16] dma/idxd: add vchan idle function

2021-09-03 Thread Kevin Laatz
When testing dmadev drivers, it is useful to have the HW device in a known state. This patch adds the implementation of the function which will wait for the device to be idle (all jobs completed) before proceeding. Signed-off-by: Kevin Laatz --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/d

[dpdk-dev] [PATCH v2 14/16] dma/idxd: move dpdk_idxd_cfg.py from raw to dma

2021-09-03 Thread Kevin Laatz
From: Conor Walsh Move the example script for configuring IDXD devices bound to the IDXD kernel driver from raw to dma, and create a symlink to still allow use from raw. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz --- drivers/dma/idxd/dpdk_idxd_cfg.py | 117 +

[dpdk-dev] [PATCH v2 15/16] devbind: add dma device class

2021-09-03 Thread Kevin Laatz
Add a new class for DMA devices. Devices listed under the DMA class are to be used with the dmadev library. Signed-off-by: Kevin Laatz --- usertools/dpdk-devbind.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind

[dpdk-dev] [PATCH v2 16/16] devbind: move idxd device ID to dmadev class

2021-09-03 Thread Kevin Laatz
The dmadev library is the preferred abstraction for using IDXD devices and will replace the rawdev implementation in future. This patch moves the IDXD device ID to the dmadev class. Signed-off-by: Kevin Laatz --- usertools/dpdk-devbind.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH v2 02/16] doc: initial commit for dmadevs section

2021-09-03 Thread Bruce Richardson
On Fri, Sep 03, 2021 at 10:49:47AM +, Kevin Laatz wrote: > Add new section to the programmer's guide for dmadev devices. > > Signed-off-by: Kevin Laatz > --- Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] telemetry: add support for dicts of dicts

2021-09-03 Thread Radu Nicolau
Add support for dicts of dicts to telemetry library. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- lib/telemetry/telemetry.c | 43 +++--- lib/telemetry/telemetry_data.c | 2 +- 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/lib/

[dpdk-dev] [PATCH] net: add support for UDP segmentation case

2021-09-03 Thread Radu Nicolau
Add support to the ipv4/ipv6 pseudo-header function when TSO is enabled in the UDP case, eg PKT_TX_UDP_SEG is set in the mbuf ol_flags Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- lib/net/rte_ip.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/net/

Re: [dpdk-dev] [PATCH v10 2/3] devtools: script to send notifications of expired symbols

2021-09-03 Thread Kinsella, Ray
On 01/09/2021 13:46, Aaron Conole wrote: > Ray Kinsella writes: > >> Use this script with the output of the DPDK symbol tool, to notify >> maintainers of expired symbols by email. You need to define the environment >> variable DPDK_GETMAINTAINER_PATH for this tool to work. >> >> Use terminal o

Re: [dpdk-dev] [PATCH v10 0/3] devtools: scripts to count and track symbols

2021-09-03 Thread Kinsella, Ray
On 01/09/2021 20:04, Aaron Conole wrote: > Stephen Hemminger writes: > >> On Wed, 01 Sep 2021 08:31:27 -0400 >> Aaron Conole wrote: >> >>> $ flake8 ./usertools/dpdk-devbind.py | sed >>> 's@./usertools/dpdk-devbind.py[:0-9]* @@' | sort -u >>> E128 continuation line under-indented for visu

[dpdk-dev] [PATCH v2 00/10] dma: add dmadev driver for ioat devices

2021-09-03 Thread Conor Walsh
This patchset adds a dmadev driver and associated documentation to support Intel QuickData Technology devices, part of the Intel I/O Acceleration Technology (Intel I/OAT). This driver is intended to ultimately replace the current IOAT part of the IOAT rawdev driver NOTE: This patchset has several

[dpdk-dev] [PATCH v2 01/10] dma/ioat: add device probe and removal functions

2021-09-03 Thread Conor Walsh
Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh --- MAINTAINERS| 6 +++ doc/guides/dmadevs/index.rst | 1 + doc/guides/dmadevs/

[dpdk-dev] [PATCH v2 02/10] dma/ioat: create dmadev instances on PCI probe

2021-09-03 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh --- drivers/dma/ioat/ioat_dmadev.c | 108 ++- drivers/d

[dpdk-dev] [PATCH v2 03/10] dma/ioat: add datapath structures

2021-09-03 Thread Conor Walsh
Add data structures required for the data path of IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 61 - drivers/dma/ioat/ioat_hw_defs.h | 214 2 files changed, 274 insertions(+), 1 deletion(

[dpdk-dev] [PATCH v2 04/10] dma/ioat: add configuration functions

2021-09-03 Thread Conor Walsh
Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a configured device. Signed-off-by: Conor Walsh --- doc/guides/dmadevs/ioat.rst| 24

[dpdk-dev] [PATCH v2 05/10] dma/ioat: add start and stop functions

2021-09-03 Thread Conor Walsh
Add start, stop and recover functions for IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson --- doc/guides/dmadevs/ioat.rst| 3 ++ drivers/dma/ioat/ioat_dmadev.c | 87 ++ 2 files changed, 90 insertions(+) diff --git a/doc/guides/dmade

[dpdk-dev] [PATCH v2 06/10] dma/ioat: add data path job submission functions

2021-09-03 Thread Conor Walsh
Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh --- doc/guides/dmadevs/ioat.rst| 54 drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 146 insertions(+) diff --git a/doc/g

[dpdk-dev] [PATCH v2 07/10] dma/ioat: add data path completion functions

2021-09-03 Thread Conor Walsh
Add the data path functions for gathering completed operations from IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 48 ++- drivers/dma/ioat/ioat_dmadev.c | 141 + 2 files changed, 188 insertions(+

[dpdk-dev] [PATCH v2 08/10] dma/ioat: add statistics

2021-09-03 Thread Conor Walsh
Add statistic tracking for operations in IOAT. Signed-off-by: Conor Walsh --- doc/guides/dmadevs/ioat.rst| 23 +++ drivers/dma/ioat/ioat_dmadev.c | 40 ++ 2 files changed, 63 insertions(+) diff --git a/doc/guides/dmadevs/ioat.rst b/doc/guides/

[dpdk-dev] [PATCH v2 09/10] dma/ioat: add support for vchan idle function

2021-09-03 Thread Conor Walsh
Add support for the rte_dmadev_vchan_idle API call. Signed-off-by: Conor Walsh --- drivers/dma/ioat/ioat_dmadev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c index 743fb2f558..a09e60b27e 100644 --- a/drivers/

[dpdk-dev] [PATCH v2 10/10] devbind: move ioat device ID for ICX to dmadev category

2021-09-03 Thread Conor Walsh
Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices. Signed-off-by: Conor Walsh --- usertools/dpdk-devbind.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 98b698ccc0..afebc8cb62 100755 --- a/

[dpdk-dev] [PATCH 0/7] IPsec Sec GW new features

2021-09-03 Thread Radu Nicolau
Update the IPsec sample app with new features and updates: - NAT-T and TSO support - telemetry support - ol_flags support - reset callback, enable stats by default, initial SQN Depends on series 18279 ('new features for ipsec and security libraries') Radu Nicolau (7): examples/ipsec-secgw: add

[dpdk-dev] [PATCH 1/7] examples/ipsec-secgw: add ol_flags support

2021-09-03 Thread Radu Nicolau
Add support for ol_flags to the IPsec GW sample app. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipse

[dpdk-dev] [PATCH 2/7] examples/ipsec-secgw: add support for NAT-T

2021-09-03 Thread Radu Nicolau
Add support to the sample application to support IPsec NAT-T for both transport and tunnel modes, for both IPv4 and IPv6. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/esp.c | 7 +- examples/ipsec-secgw/ipsec-secgw.c | 3 - examples/ipsec-secgw/i

[dpdk-dev] [PATCH 3/7] examples/ipsec-secgw: add support for TSO

2021-09-03 Thread Radu Nicolau
Add support to allow user to specific MSS for TSO offload on a per SA basis. MSS configuration in the context of IPsec is only supported for outbound SA's in the context of an inline IPsec Crypto offload. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.h

[dpdk-dev] [PATCH 4/7] examples/ipsec-secgw: enable stats by default

2021-09-03 Thread Radu Nicolau
Enable stats screen by default Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.h b/examples/ipsec-secgw/ipsec-secgw.h index 96e22de45e..ede610bc

[dpdk-dev] [PATCH 5/7] examples/ipsec-secgw: add support for telemetry

2021-09-03 Thread Radu Nicolau
Add telemetry support to the IPsec GW sample app Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 370 +++-- examples/ipsec-secgw/ipsec-secgw.h | 31 +++ examples/ipsec-secgw/ipsec.h | 2 + examples/ipsec-secgw/m

[dpdk-dev] [PATCH 6/7] examples/ipsec-secgw: add support for defining initial sequence number value

2021-09-03 Thread Radu Nicolau
Add esn field to SA definition block to allow initial ESN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 5 + examples/ipsec-secgw/ipsec.h | 2 ++ examples/ipsec-secgw/sa.c| 15 +++ 3 files changed, 22 insertions(+) diff

[dpdk-dev] [PATCH 7/7] examples/ipsec-secgw: add ethdev reset callback

2021-09-03 Thread Radu Nicolau
Add event handler for ethdev reset callback Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 18 +++- examples/ipsec-secgw/ipsec.h | 4 +- examples/ipsec-secgw/sa.c | 130 +++-- 3 files changed, 139 inse

[dpdk-dev] [PATCH v2] net: introduce IPv4 ihl and version fields

2021-09-03 Thread getelson
From: Gregory Etelson RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplified code to match on the

[dpdk-dev] [PATCH v4 00/10] new features for ipsec and security libraries

2021-09-03 Thread Radu Nicolau
Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Radu Nicolau (10): securit

[dpdk-dev] [PATCH v4 01/10] security: add support for TSO on IPsec session

2021-09-03 Thread Radu Nicolau
Allow user to provision a per security session maximum segment size (MSS) for use when Transmit Segmentation Offload (TSO) is supported. The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG ol_flags are specified in mbuf. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Sign

[dpdk-dev] [PATCH v4 02/10] security: add UDP params for IPsec NAT-T

2021-09-03 Thread Radu Nicolau
Add support for specifying UDP port params for UDP encapsulation option. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/

[dpdk-dev] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-03 Thread Radu Nicolau
Update ipsec_xform definition to include ESN field. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/security/rte_security.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/security/rte_security

[dpdk-dev] [PATCH v4 04/10] mbuf: add IPsec ESP tunnel type

2021-09-03 Thread Radu Nicolau
Add tunnel type for IPsec ESP tunnels Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/mbuf/rte_mbuf_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.

[dpdk-dev] [PATCH v4 05/10] ipsec: add support for AEAD algorithms

2021-09-03 Thread Radu Nicolau
Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/crypto.h | 137 +++ lib/ipsec/esp_inb.c | 66 +

[dpdk-dev] [PATCH v4 06/10] ipsec: add transmit segmentation offload support

2021-09-03 Thread Radu Nicolau
Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off

[dpdk-dev] [PATCH v4 07/10] ipsec: add support for NAT-T

2021-09-03 Thread Radu Nicolau
Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/iph.h | 13 + lib/ipsec/rte_ipsec_sa.h | 8 +++- lib/ip

[dpdk-dev] [PATCH v4 08/10] ipsec: add support for SA telemetry

2021-09-03 Thread Radu Nicolau
Add telemetry support for ipsec SAs Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 1 + lib/ipsec/esp_outb.c | 12 +- lib/ipsec/meson.build | 2 +- lib/ipsec/rte_ipsec.h | 23

[dpdk-dev] [PATCH v4 09/10] ipsec: add support for initial SQN value

2021-09-03 Thread Radu Nicolau
Update IPsec library to support initial SQN value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_outb.c | 19 --- lib/ipsec/sa.c | 29 ++--- 2 files ch

[dpdk-dev] [PATCH v4 10/10] ipsec: add ol_flags support

2021-09-03 Thread Radu Nicolau
Set mbuff->ol_flags for IPsec packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- lib/ipsec/esp_inb.c | 17 -- lib/ipsec/esp_outb.c | 48 ++- lib/ipsec

Re: [dpdk-dev] [PATCH v19 1/7] dmadev: introduce DMA device library public APIs

2021-09-03 Thread Gagandeep Singh
Hi, > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Close a DMA device. > + * > + * The device cannot be restarted after this call. > + * > + * @param dev_id > + * The identifier of the device. > + * > + * @return > + * 0 on success. Othe

Re: [dpdk-dev] [PATCH v8] doc: add release milestones definition

2021-09-03 Thread Thomas Monjalon
02/09/2021 18:33, Ferruh Yigit: > On 8/26/2021 11:11 AM, Thomas Monjalon wrote: > > +rc1 > > +~~~ > > + > > +* Priority: libraries. No library feature should be accepted after -rc1. > > +* API changes or additions must be implemented in libraries. > > +* The API must include Doxygen documentation >

Re: [dpdk-dev] |FAILURE| pw97277 [PATCH] [v4] eal: read data buffer on RTE_INTR_HANDLE_VFIO_REQ

2021-09-03 Thread David Marchand
On Fri, Sep 3, 2021 at 10:59 AM Szwed, Maciej wrote: > -Original Message- > From: dev On Behalf Of Szwed, Maciej > Sent: Monday, August 30, 2021 11:34 AM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] |FAILURE| pw97277 [PATCH] [v4] eal: read data buffer > on RTE_INTR_HANDLE_VFIO_REQ > > Hi

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

2021-09-03 Thread David Marchand
On Wed, Sep 1, 2021 at 4:03 AM Xiaoyun Li wrote: > > Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API > that was introduced in 18.11 and have been around for 11 releases. > > Signed-off-by: Xiaoyun Li Odd that this API is used nowhere in-tree but it provides a simple alternat

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

2021-09-03 Thread Kinsella, Ray
On 03/09/2021 13:17, David Marchand wrote: > On Wed, Sep 1, 2021 at 4:03 AM Xiaoyun Li wrote: >> >> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API >> that was introduced in 18.11 and have been around for 11 releases. >> >> Signed-off-by: Xiaoyun Li > > Odd that this API

[dpdk-dev] RFC V2: Enhancements to Rx adapter for DPDK 21.11

2021-09-03 Thread Kundapura, Ganapati
Hi dpdk-dev, This is the updated RFC for enhancements to Rx adapter that was communicated earlier. Please find the details below. (1) Configure Rx event buffer size during adapter instance creation Add new api to specify the Rx event buffer size at adapter creation and allocate the ev

Re: [dpdk-dev] [PATCH v8] doc: add release milestones definition

2021-09-03 Thread Andrew Rybchenko
On 8/26/21 1:11 PM, Thomas Monjalon wrote: > From: Asaf Penso > > Adding more information about the release milestones. > This includes the scope of change, expectations, etc. > > Signed-off-by: Asaf Penso > Signed-off-by: Thomas Monjalon > Acked-by: John McNamara > Acked-by: Ajit Khaparde >

[dpdk-dev] [PATCH v1 0/7] make rte_intr_handle internal

2021-09-03 Thread Harman Kalra
Moving struct rte_intr_handle as an internal structure to avoid any ABI breakages in future. Since this structure defines some static arrays and changing respective macros breaks the ABI. Eg: Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 MSI-X interrupts that can be defined for

[dpdk-dev] [PATCH v1 1/7] eal: interrupt handle API prototypes

2021-09-03 Thread Harman Kalra
Defining protypes of get/set APIs for accessing/manipulating interrupt handle fields. Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, as APIs defined are moved to rte_interrupts.h and epoll specific definitions are moved to a new header rte_epoll.h. Later in the series rte_eal_in

[dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement get set APIs

2021-09-03 Thread Harman Kalra
Implementing get set APIs for interrupt handle fields. To make any change to the interrupt handle fields, one should make use of these APIs. Signed-off-by: Harman Kalra Acked-by: Ray Kinsella --- lib/eal/common/eal_common_interrupts.c | 506 + lib/eal/common/meson.build

[dpdk-dev] [PATCH v1 3/7] eal/interrupts: avoid direct access to interrupt handle

2021-09-03 Thread Harman Kalra
Making changes to the interrupt framework to use interrupt handle APIs to get/set any field. Direct access to any of the fields should be avoided to avoid any ABI breakage in future. Signed-off-by: Harman Kalra --- lib/eal/freebsd/eal_interrupts.c | 94 ++ lib/eal/linux/eal_interrupts.c

[dpdk-dev] [PATCH v1 4/7] test/interrupt: apply get set interrupt handle APIs

2021-09-03 Thread Harman Kalra
Updating the interrupt testsuite to make use of interrupt handle get set APIs. Signed-off-by: Harman Kalra --- app/test/test_interrupts.c | 237 - 1 file changed, 152 insertions(+), 85 deletions(-) diff --git a/app/test/test_interrupts.c b/app/test/test_inter

[dpdk-dev] [PATCH v1 6/7] eal/interrupts: make interrupt handle structure opaque

2021-09-03 Thread Harman Kalra
Moving interrupt handle structure definition inside the c file to make its fields totally opaque to the outside world. Dynamically allocating the efds and elist array os intr_handle structure, based on size provided by user. Eg size can be MSIX interrupts supported by a PCI device. Signed-off-by:

[dpdk-dev] [PATCH v1 7/7] eal/alarm: introduce alarm fini routine

2021-09-03 Thread Harman Kalra
Implementing alarm cleanup routine, where the memory allocated for interrupt instance can be freed. Signed-off-by: Harman Kalra --- lib/eal/common/eal_private.h | 11 +++ lib/eal/freebsd/eal.c| 1 + lib/eal/freebsd/eal_alarm.c | 7 +++ lib/eal/linux/eal.c | 1 +

Re: [dpdk-dev] [PATCH v4 05/10] ipsec: add support for AEAD algorithms

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 3, 2021 12:26 PM > To: Ananyev, Konstantin ; Iremonger, > Bernard ; Medvedkin, Vladimir > > Cc: dev@dpdk.org; m...@ashroe.eu; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; gak...@marvell.com; ano...

Re: [dpdk-dev] [PATCH v4 04/10] mbuf: add IPsec ESP tunnel type

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 3, 2021 12:26 PM > To: Olivier Matz > Cc: dev@dpdk.org; m...@ashroe.eu; Ananyev, Konstantin > ; Medvedkin, Vladimir > ; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; gak...@marvell.com; ano...@marvell.

Re: [dpdk-dev] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 3, 2021 12:26 PM > To: Akhil Goyal ; Doherty, Declan > > Cc: dev@dpdk.org; m...@ashroe.eu; Ananyev, Konstantin > ; Medvedkin, Vladimir > ; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; ano...@marvell.c

Re: [dpdk-dev] [PATCH v4 01/10] security: add support for TSO on IPsec session

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 3, 2021 12:26 PM > To: Akhil Goyal ; Doherty, Declan > > Cc: dev@dpdk.org; m...@ashroe.eu; Ananyev, Konstantin > ; Medvedkin, Vladimir > ; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; ano...@marvel

Re: [dpdk-dev] [PATCH 4/7] examples/ipsec-secgw: enable stats by default

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Friday, September 3, 2021 12:23 PM > To: Nicolau, Radu ; Akhil Goyal > > Cc: dev@dpdk.org; Doherty, Declan > Subject: [dpdk-dev] [PATCH 4/7] examples/ipsec-secgw: enable stats by > default > > Enable stats screen by d

Re: [dpdk-dev] [PATCH v4 02/10] security: add UDP params for IPsec NAT-T

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 3, 2021 12:26 PM > To: Akhil Goyal ; Doherty, Declan > > Cc: dev@dpdk.org; m...@ashroe.eu; Ananyev, Konstantin > ; Medvedkin, Vladimir > ; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; ano...@marvel

Re: [dpdk-dev] [PATCH v4 06/10] ipsec: add transmit segmentation offload support

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 3, 2021 12:26 PM > To: Ananyev, Konstantin ; Iremonger, > Bernard ; Medvedkin, Vladimir > > Cc: dev@dpdk.org; m...@ashroe.eu; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; gak...@marvell.com; ano...@ma

Re: [dpdk-dev] [PATCH v4 07/10] ipsec: add support for NAT-T

2021-09-03 Thread Zhang, Roy Fan
> -Original Message- > From: Nicolau, Radu > Sent: Friday, September 3, 2021 12:26 PM > To: Ananyev, Konstantin ; Iremonger, > Bernard ; Medvedkin, Vladimir > > Cc: dev@dpdk.org; m...@ashroe.eu; Richardson, Bruce > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com; gak...@marvell.com; ano...@ma

  1   2   >