Hi Anoob,
Left some comments/questions inline.
Thanks,
Ciara
>-----Original Message-----
>From: Anoob Joseph <ano...@marvell.com>
>Sent: Friday 3 September 2021 05:47
>To: Akhil Goyal <gak...@marvell.com>; Doherty, Declan
><declan.dohe...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>;
>Ananyev, Konstantin <konstantin.anan...@intel.com>
>Cc: Anoob Joseph <ano...@marvell.com>; Jerin Jacob <jer...@marvell.com>;
>Archana Muniganti <march...@marvell.com>; Tejasree Kondoj
><ktejas...@marvell.com>; Hemant Agrawal <hemant.agra...@nxp.com>;
>Nicolau, Radu <radu.nico...@intel.com>; Power, Ciara
><ciara.po...@intel.com>; Gagandeep Singh <g.si...@nxp.com>; dev@dpdk.org
>Subject: [PATCH v3 1/5] test/crypto: add lookaside IPsec tests
>
>Added test case for lookaside IPsec. Inbound known vector tests are added.
>
>Cipher list: AES-GCM 128, 192 & 256
>
>Signed-off-by: Anoob Joseph <ano...@marvell.com>
>Signed-off-by: Tejasree Kondoj <ktejas...@marvell.com>
>---
<snip>
> #ifdef RTE_LIB_SECURITY
> static int
>+ipsec_proto_testsuite_setup(void)
>+{
>+ struct crypto_testsuite_params *ts_params = &testsuite_params;
>+ struct crypto_unittest_params *ut_params = &unittest_params;
>+ struct rte_cryptodev_info dev_info;
>+
>+ rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
>+
>+ if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_SECURITY)) {
>+ RTE_LOG(INFO, USER1, "Feature flag requirements for IPsec
>Proto "
>+ "testsuite not met\n");
>+ return TEST_SKIPPED;
>+ }
>+
>+ /* Reconfigure to enable security */
>+ dev_configure_and_start(RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |
>+ RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO);
>+
Just a question on this - each testcase uses ut_setup_security which in turn
calls dev_configure_and_start,
Is the configuration resulting from this call just being redone when the first
testcase runs?
>+ /* Set action type */
>+ ut_params->type =
>RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL;
>+
>+ if (security_proto_supported(
>+ RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL,
>+ RTE_SECURITY_PROTOCOL_IPSEC) < 0) {
>+ RTE_LOG(INFO, USER1, "Capability requirements for IPsec Proto
>"
>+ "test not met\n");
>+ return TEST_SKIPPED;
If the test is skipped here, the device is not stopped, which I believe would
cause problems for the next testsuite setup configuring the device.
>+ }
>+
>+ /* Stop the device */
>+ rte_cryptodev_stop(ts_params->valid_devs[0]);
>+
>+ return 0;
>+}
