Re: [dpdk-dev] 19.11.10 patches review and test

2021-08-30 Thread Christian Ehrhardt
On Thu, Aug 26, 2021 at 3:04 PM Jiang, YuX wrote: > > Hi All, > > Testing with dpdk v19.11.10-rc1 from Intel is finished, one new issue is > found. > New issue: https://bugs.dpdk.org/show_bug.cgi?id=794 > # Basic Intel(R) NIC testing > * PF(i40e, ixgbe): test scenarios including rte_flow/TSO/Jumb

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-30 Thread Michał Krawczyk
czw., 19 sie 2021 o 04:19 William Tu napisał(a): > > So I finally set up everything on AWS and tested this patch. > Virt2phys and netuio (I added ena conf) load OK. > Finally, starting dpdk-testpmd, I got some errors below: > --- > PS C:\dpdk-kmods> cd c:\dpdk > PS C:\dpdk> .\build\app\dpdk-testpm

[dpdk-dev] Running DPDK application without non-previlege mode

2021-08-30 Thread Kamaraj P
Hello All, We are not able to run the DPDK allocation without using privilege option. Able to see the below erors: set_mempolicy: Operation not permitted set_mempolicy: Operation not permitted set_mempolicy: Operation not permitted set_mempolicy: Operation not permitted set_mempolicy: Operation

[dpdk-dev] [PATCH] net/bnxt: fix ring group free

2021-08-30 Thread Kalesh A P
From: Kalesh AP Added an invalid fw_grp_id check inside bnxt_hwrm_ring_grp_free(). This will prevent invalid fw_grp_id to be passed to the FW which can result in an error. This fixes the following failure in the "port stop" -> "port start" sequence: bnxt_hwrm_ring_grp_free(): error 2:0::

[dpdk-dev] [Bug 798] mlx5 hw flow performance problem

2021-08-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=798 Bug ID: 798 Summary: mlx5 hw flow performance problem Product: DPDK Version: 21.08 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: critical Priorit

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-30 Thread Kamaraj P
Hello All, Some more info. We are using DPDK 19.11. When we bringup application with --security-opt seccomp=unconfined option.. THe application bringup successfully and didnt observe any error when DPDK init logs. Will that --security-opt seccomp=unconfined option recommended for non-previlege mod

[dpdk-dev] [PATCH] examples/service_cores: fix lcore count check

2021-08-30 Thread Ruifeng Wang
The example has various profiles to run services on specified number of lcores. Due to incorrect boundary condition, service can be dispatched to a core that does not exist. This puts main core into endless wait. Max available number of service cores is all detected lcores excluding main core. Fi

[dpdk-dev] [PATCH RFC 1/2] net/ice/base: support drop any and steer all to queue

2021-08-30 Thread Yuying Zhang
This patch supports drop any and steer all to queue in switch filter. Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 73 +++- drivers/net/ice/base/ice_flex_pipe.h | 5 +- drivers/net/ice/base/ice_flex_type.h | 1 + drivers/net/ice/base/ic

[dpdk-dev] [PATCH RFC 2/2] net/ice: support drop any and steer all to queue

2021-08-30 Thread Yuying Zhang
This patch supports drop any and steer all to queue in switch filter. Support new rte_flow pattern any to handle all packets. The usage is listed below. 1. drop any: flow create 0 ingress pattern any / end actions drop / end All packets received in port 0 will be dropped. 2. steer all to queue: f

Re: [dpdk-dev] [PATCH 2/2] net/ice: fix generic build on FreeBSD

2021-08-30 Thread Rong, Leyi
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, August 19, 2021 12:38 AM > To: dev@dpdk.org > Cc: brian90...@gmail.com; Richardson, Bruce ; > Lu, Wenzhuo ; Rong, Leyi ; > sta...@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: [PATCH 2/2] net/ice: fix generic build on

Re: [dpdk-dev] [PATCH v17 8/8] maintainers: add for dmadev

2021-08-30 Thread Bruce Richardson
On Sat, Aug 28, 2021 at 04:25:33PM +0800, fengchengwen wrote: > I got checkpatch warning email of this patch, but there have none valid > information: > > Test-Label: checkpatch > Test-Status: WARNING > http://dpdk.org/patch/97493 > > _coding style issues_ > > > -

[dpdk-dev] [PATCH 1/3] net/hns3: fix queue flow action validation

2021-08-30 Thread Min Hu (Connor)
From: Chengchang Tang The used_rx_queues only takes effect after device is started, and its value is incorrect before the device is started. Therefore, it is not suitable for flow action to use it to verify the queue index before the device is started. E.g. Enable dedicated queue in bonding devi

[dpdk-dev] [PATCH 3/3] net/hns3: fix Tx push capability

2021-08-30 Thread Min Hu (Connor)
This patch fixes Tx push capability to be compatible with Kunpeng 920, as Tx push is only supported on Kunpeng 930. Fixes: 23e317dd1fbf ("net/hns3: support Tx push quick doorbell for performance") Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.c | 3 +++ drivers/net/hns3/hns3_cmd.

[dpdk-dev] [PATCH 2/3] net/hns3: fix new taskqueue pair reset command

2021-08-30 Thread Min Hu (Connor)
From: Chengchang Tang This new taskqueue pair reset command is used incorrectly, resulting in the new command not taking effect. This patch fix the incorrect use. Fixes: 6911e7c22c61 ("net/hns3: fix long task queue pairs reset time") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-o

[dpdk-dev] [PATCH 0/3] bugfixes for hns3 PMD

2021-08-30 Thread Min Hu (Connor)
This patch contains three bugfixes for hns3 PMD. Chengchang Tang (2): net/hns3: fix queue flow action validation net/hns3: fix new taskqueue pair reset command Min Hu (Connor) (1): net/hns3: fix Tx push capability drivers/net/hns3/hns3_cmd.c | 3 +++ drivers/net/hns3/hns3_cmd.h | 1 + d

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-30 Thread Kamaraj P
DPDK logs: Used system capability: --cap-add=NET_ADMIN --cap-add=SYS_RESOURCE --rm -v /dev:/dev to bring up the DPDK application Enabling IOVA mode set_mempolicy: Operation not permitted set_mempolicy: Operation not permitted set_mempolicy: Operation not permitted set_mempolicy: Operation not per

Re: [dpdk-dev] [PATCH 02/10] vdpa/sfc: add support for device initialization

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Add HW initialization and vDPA device registration support. > > Signed-off-by: Vijay Kumar Srivastava > --- > doc/guides/vdpadevs/sfc.rst | 6 + > drivers/vdpa/sfc/meson.build | 3 + > drivers/vdpa/

Re: [dpdk-dev] [RFC PATCH] ethdev: mtr: enhance input color table features

2021-08-30 Thread Jerin Jacob
Ping On Fri, Aug 20, 2021 at 1:56 PM wrote: > > From: Jerin Jacob > > Currently, meter object supports only DSCP based on input color table, > The patch enhance that to support VLAN based input color table, > color table based on inner field for the tunnel use case, and support > for fallback

Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt

2021-08-30 Thread Ferruh Yigit
On 7/22/2021 9:16 AM, mohamad.noor.alim.hus...@intel.com wrote: > From: Mohamad Noor Alim Hussin > > Finding with "librt" keyword would give the output with full path of librt > such > as /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/librt.so > instead of -lrt in libdpdk.pc pkg-confi

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-30 Thread Jerin Jacob
On Sat, Aug 28, 2021 at 7:46 PM Xueming(Steven) Li wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, August 26, 2021 7:58 PM > > To: Xueming(Steven) Li > > Cc: dpdk-dev ; Ferruh Yigit ; > > NBU-Contact-Thomas Monjalon ; > > Andrew Rybchenko > > Subject: Re:

Re: [dpdk-dev] |FAILURE| pw97277 [PATCH] [v4] eal: read data buffer on RTE_INTR_HANDLE_VFIO_REQ

2021-08-30 Thread Szwed, Maciej
Hi, I'm new to posting patches to DPDK repository. I've submitted a patch recently and one of the tests performed on it failed. I went through the failed test log and it looks like it does not have anything to do with my patch. You can check details below. What should be the next steps I should

Re: [dpdk-dev] [PATCH 03/10] vdpa/sfc: add support to get device and protocol features

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Implement vDPA ops get_feature and get_protocol_features. > This patch retrieves device supported features and enables > protocol features. > > Signed-off-by: Vijay Kumar Srivastava > --- > doc/guides/vdpadevs/fea

Re: [dpdk-dev] [PATCH 04/10] vdpa/sfc: get device supported max queue count

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Implement vDPA ops get_queue_num to get the maximum number > of queues supported by the device. > > Signed-off-by: Vijay Kumar Srivastava > --- > drivers/vdpa/sfc/sfc_vdpa_ops.c | 16 +--- > 1 file cha

Re: [dpdk-dev] [PATCH 05/10] vdpa/sfc: add support to get VFIO device fd

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Implement vDPA ops get_vfio_device_fd to get the VFIO device fd. > > Signed-off-by: Vijay Kumar Srivastava > --- > drivers/vdpa/sfc/sfc_vdpa_ops.c | 24 > 1 file changed, 24 insertions(+)

Re: [dpdk-dev] [PATCH 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-08-30 Thread Aman Kumar
Hi Jerin, Thanks for your comments and suggestions. I will try to update this in V2. On Mon, Aug 23, 2021 at 8:51 PM Jerin Jacob wrote: > On Mon, Aug 23, 2021 at 2:14 PM Aman Kumar wrote: > > > > This patch provides rte_memcpy* calls optimized for > > AMD EPYC Gen2 platforms. This option is dis

Re: [dpdk-dev] [PATCH v1] eventdev: change packet enqueue buffer in RX adapter to circular buffer

2021-08-30 Thread Jerin Jacob
On Fri, Aug 27, 2021 at 3:12 PM Ganapati Kundapura wrote: > > RX adapter user memove() to move unprocessed events to the beginning of > the packet enqueue buffer. The use memmove() was found to consume good > amount of CPU cycles (about 20%). > > This patch removes the use of memove() while implem

Re: [dpdk-dev] [PATCH v2] ethdev: add namespace

2021-08-30 Thread David Marchand
Hi Ferruh, On Fri, Aug 27, 2021 at 3:26 AM Ferruh Yigit wrote: > > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible For completeness, there are some struct renames too in this patch. > way. The macros for backward compatibility can be removed in next LTS. Olivier had pro

Re: [dpdk-dev] [PATCH] driver: i40evf device initialization

2021-08-30 Thread Ferruh Yigit
On 8/27/2021 7:28 AM, Xueming(Steven) Li wrote: > > >> -Original Message- >> From: Kevin Traynor >> Sent: Thursday, August 26, 2021 6:46 PM >> To: Ferruh Yigit ; Ben Magistro >> ; dev@dpdk.org; Beilei Xing ; >> Luca Boccassi ; Christian Ehrhardt >> ; Xueming(Steven) Li >> >> Cc: ben.m

Re: [dpdk-dev] [PATCH v1] eventdev: change packet enqueue buffer in RX adapter to circular buffer

2021-08-30 Thread Kundapura, Ganapati
> -Original Message- > From: Jerin Jacob > Sent: 30 August 2021 15:11 > To: Kundapura, Ganapati > Cc: Jayatheerthan, Jay ; dpdk-dev > > Subject: Re: [PATCH v1] eventdev: change packet enqueue buffer in RX > adapter to circular buffer > > On Fri, Aug 27, 2021 at 3:12 PM Ganapati Kundap

Re: [dpdk-dev] [RFC 01/15] eventdev: make driver interface as internal

2021-08-30 Thread Mattias Rönnblom
On 2021-08-24 09:43, Mattias Rönnblom wrote: > On 2021-08-23 21:40, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Mark all the driver specific functions as internal, remove >> `rte` prefix from `struct rte_eventdev_ops`. >> Remove experimental tag from internal functions. >> Remov

[dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen

2021-08-30 Thread Thomas Monjalon
A lot of flags are parts of a group but are documented alone. The Doxygen syntax @{ and @} for grouping is used to make flags appear together and have a common description. Some Rx/Tx offload flags and RSS definitions are not grouped because they need to be all properly documented first. Signed-o

Re: [dpdk-dev] [PATCH 02/10] vdpa/sfc: add support for device initialization

2021-08-30 Thread Xia, Chenbo
Hi Vijay, > -Original Message- > From: Vijay Srivastava > Sent: Wednesday, July 7, 2021 12:44 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH 02/10] vdpa/sfc: add support for device initializa

[dpdk-dev] [PATCH 0/8] Crypto adapter support for Marvell CNXK driver

2021-08-30 Thread Shijith Thotton
First three patches are to support crypto adapter implementation and the remaining patches add event crypto adapter OP_FORWARD mode support on Marvell CN9K and CN10K SOC. Shijith Thotton (8): net/cnxk: add flag to show CPT can enqueue events event/cnxk: add macro to set eventdev ops common/c

[dpdk-dev] [PATCH 1/8] net/cnxk: add flag to show CPT can enqueue events

2021-08-30 Thread Shijith Thotton
CPT can be told to submit events to SSO upon completion. Crypto adapter uses this feature and the new flag can be used to optimize receive path in those cases. Signed-off-by: Shijith Thotton --- drivers/net/cnxk/cn10k_rx.h | 5 +++-- drivers/net/cnxk/cn9k_rx.h | 3 ++- 2 files changed, 5 insert

[dpdk-dev] [PATCH 2/8] event/cnxk: add macro to set eventdev ops

2021-08-30 Thread Shijith Thotton
Added a common macro to set eventdev enqueue and dequeue operations to reduce code. Signed-off-by: Shijith Thotton Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 133 +- drivers/event/cnxk/cn9k_eventdev.c | 267 +++- 2 files chang

[dpdk-dev] [PATCH 3/8] common/cnxk: add API to check CPT IQ is full

2021-08-30 Thread Shijith Thotton
Added flow control based check to determine CPT IQ is full. Signed-off-by: Shijith Thotton --- drivers/common/cnxk/roc_cpt.c | 6 -- drivers/common/cnxk/roc_cpt.h | 11 +++ drivers/common/cnxk/roc_cpt_priv.h | 6 -- 3 files changed, 15 insertions(+), 8 deletions(-) d

[dpdk-dev] [PATCH 4/8] drivers: add cnxk crypto adapter eventdev ops

2021-08-30 Thread Shijith Thotton
Added eventdev ops required to initialize crypto adapter. Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 9 +++ drivers/event/cnxk/cn10k_eventdev.c | 46 drivers/event/cnxk/cn9k_eventdev.c | 45 drivers/event/cnxk/cnxk_eventdev

[dpdk-dev] [PATCH 5/8] crypto/cnxk: add cn9k crypto adapter fast path ops

2021-08-30 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 235 --- drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 6 + drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 28 +++ drivers/crypto/cnxk/meson

[dpdk-dev] [PATCH 6/8] event/cnxk: add cn9k crypto adapter fast path ops

2021-08-30 Thread Shijith Thotton
Set crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn9k_eventdev.c | 94 +++- drivers/event/cnxk/cn9k_worker.c | 22 + drivers/event/cnxk/cn9k_worker.h | 41 - drivers/eve

[dpdk-dev] [PATCH 7/8] crypto/cnxk: add cn10k crypto adapter fast path ops

2021-08-30 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN10K. Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 95 +++ drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 6 ++ drivers/crypto/cnxk/version.map | 2 + 3 files changed, 103 inse

[dpdk-dev] [PATCH 8/8] event/cnxk: add cn10k crypto adapter fast path ops

2021-08-30 Thread Shijith Thotton
Set crypto adapter enqueue and dequeue operations for CN10K. Signed-off-by: Shijith Thotton --- doc/guides/rel_notes/release_21_11.rst | 3 ++ drivers/event/cnxk/cn10k_eventdev.c | 45 +++- drivers/event/cnxk/cn10k_worker.c| 11 drivers/event/cnxk/cn10k_worker.h

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-30 Thread Ferruh Yigit
On 8/30/2021 8:52 AM, Kamaraj P wrote: > Hello All, > Some more info. > We are using DPDK 19.11. > > When we bringup application with --security-opt seccomp=unconfined > option.. > THe application bringup successfully and didnt observe any error when DPDK > init logs. > Will that --security-opt se

Re: [dpdk-dev] [PATCH 06/10] vdpa/sfc: add support for dev conf and dev close ops

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Implement vDPA ops dev_conf and dev_close for DMA mapping, > interrupt and virtqueue configurations. > > Signed-off-by: Vijay Kumar Srivastava > --- > drivers/vdpa/sfc/sfc_vdpa.c | 6 + > drivers/vdpa/sfc/sf

Re: [dpdk-dev] [PATCH 0/3] net/i40e: remove i40evf

2021-08-30 Thread David Marchand
On Mon, Aug 30, 2021 at 5:25 AM Robin Zhang wrote: > > In DPDK 21.05, iavf already became the default VF for i40e devices. > So remove i40evf due to it's no need to maintain now. > > Robin Zhang (3): > net/i40e: remove i40evf > net/iavf: remove i40evf devargs option > doc: remove old depreca

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-30 Thread Kamaraj P
Thanks Ferruh. One more option which we have figured out to resolve this error by adding SYS_NICE capability ( --cap-add=NET_ADMIN --cap-add=SYS_RESOURCE --cap-add=SYS_NICE). Not sure whether it will work for all the scenarios. However the above options will ensure DPDK application can run as non-p

Re: [dpdk-dev] [PATCH] vhost: Clean iotlb cache on vring stop

2021-08-30 Thread Xia, Chenbo
Hi Eugenio, > -Original Message- > From: Eugenio Pérez > Sent: Saturday, August 28, 2021 12:13 AM > To: Maxime Coquelin ; Xia, Chenbo > > Cc: dev@dpdk.org; Pei Zhang ; Jason Wang > > Subject: [PATCH] vhost: Clean iotlb cache on vring stop Clean -> clean > > Old IOVA cache entries are

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-30 Thread Thomas Monjalon
30/08/2021 13:26, Ferruh Yigit: > On 8/30/2021 8:52 AM, Kamaraj P wrote: > > Hello All, > > Some more info. > > We are using DPDK 19.11. > > > > When we bringup application with --security-opt seccomp=unconfined > > option.. > > THe application bringup successfully and didnt observe any error when

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix potential unreleased lock problem

2021-08-30 Thread Slava Ovsiienko
Hi, Chengfeng Thank you for the fix, we can adopt this (ie Upstream ML is not "wrong place" 😊) I have some minor comment about: - the problem should be described in past tense (should b e"sh->txpp.mutex WAS not correctly") - headline should be more specific, like "fix mutex unlock in txpp cleanup

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-30 Thread Thomas Monjalon
30/08/2021 13:45, Kamaraj P: > Thanks Ferruh. > One more option which we have figured out to resolve this error by adding > SYS_NICE capability ( --cap-add=NET_ADMIN --cap-add=SYS_RESOURCE > --cap-add=SYS_NICE). > Not sure whether it will work for all the scenarios. However the above > options will

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-08-30 Thread David Marchand
On Mon, Aug 30, 2021 at 1:59 PM Thomas Monjalon wrote: > > 30/08/2021 13:26, Ferruh Yigit: > > On 8/30/2021 8:52 AM, Kamaraj P wrote: > > > Hello All, > > > Some more info. > > > We are using DPDK 19.11. > > > > > > When we bringup application with --security-opt seccomp=unconfined > > > option..

Re: [dpdk-dev] [PATCH 21.11 v2 0/3] eal: add memory pre-allocation from existing files

2021-08-30 Thread Dmitry Kozlyuk
> -Original Message- > From: Dmitry Kozlyuk > Sent: August 9, 2021, 12:45 > [...] > Hi Anatoly, could you review please? Hi Anatoly, did you have time to look? Patch 1/3 may be useful on its own, because it makes adding and testing patches like [1] easier. [1]: http://patchwork.dpdk.or

[dpdk-dev] [PATCH v2] eventdev: rx-adapter: improve enqueue buffer to circular buffer

2021-08-30 Thread Ganapati Kundapura
v2: * Fixed typo in commit message * changed subject line v1: RX adapter uses memove() to move unprocessed events to the beginning of the packet enqueue buffer. The use memmove() was found to consume good amount of CPU cycles (about 20%). This patch removes the use of memove() while implementing

Re: [dpdk-dev] [PATCH 07/10] vdpa/sfc: add support to get queue notify area info

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Implement the vDPA ops get_notify_area to get the notify > area info of the queue. > > Signed-off-by: Vijay Kumar Srivastava > --- > drivers/vdpa/sfc/sfc_vdpa_ops.c | 166 > ++-

Re: [dpdk-dev] [PATCH 08/10] vdpa/sfc: add support for MAC filter config

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Add support for unicast and broadcast MAC filter configuration. I wonder whether we should not add an API to the vDPA framework for this MAC management, as this is something generic. What do you think? > Signed-of

[dpdk-dev] Question about virtio-net device on google cloud engine

2021-08-30 Thread William Tu
Hi, I'm testing DPDK on virtio device using a Linux VM (ubuntu 21.04) from google cloud. But I couldn't get it to work. I wonder 1. Is "no modern virtio pci device found." expected? 2. Should I use vfio-pci, instead uio_pci_generic? 3. maybe on the public cloud, promiscuous mode is not allowed?

[dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size

2021-08-30 Thread Ashwin Sekhar T K
NPA stack should be aligned to ROC cache line size. Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations") Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_npa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/comm

Re: [dpdk-dev] [PATCH 09/10] vdpa/sfc: add support to set vring state

2021-08-30 Thread Maxime Coquelin
On 7/6/21 6:44 PM, Vijay Srivastava wrote: > From: Vijay Kumar Srivastava > > Implements vDPA ops set_vring_state to configure vring state. > > Signed-off-by: Vijay Kumar Srivastava > --- > drivers/vdpa/sfc/sfc_vdpa_ops.c | 54 > ++--- > 1 file changed,

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-30 Thread William Tu
On Mon, Aug 30, 2021 at 12:12 AM Michał Krawczyk wrote: [...] > Hi William, > > It's great to hear that you're working on ENA support for Windows! > > ENA PMD uses admin interrupt for processing all the commands like > creating the IO queues, setting up the MTU, etc., and also for the > AENQ event

[dpdk-dev] [PATCH] common/cnxk: avoid using stype STSTP in batch alloc

2021-08-30 Thread Ashwin Sekhar T K
Avoid using stype STSTP in batch alloc. This is a workaround for errata IPBUNPA-37480. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_nix_queue.c | 5 + drivers/common/cnxk/roc_nix_tm_ops.c | 8 drivers/common/cnxk/roc_npa.h| 2 +- 3 files changed, 14 inserti

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-30 Thread Xueming(Steven) Li
> -Original Message- > From: Jerin Jacob > Sent: Monday, August 30, 2021 5:31 PM > To: Xueming(Steven) Li > Cc: dpdk-dev ; Ferruh Yigit ; > NBU-Contact-Thomas Monjalon ; > Andrew Rybchenko > Subject: Re: [PATCH v2 01/15] ethdev: introduce shared Rx queue > > On Sat, Aug 28, 2021 at 7

[dpdk-dev] [PATCH] net/virtio: handle Tx checksums correctly for tunnel packets

2021-08-30 Thread Ivan Malov
Tx prepare method calls rte_net_intel_cksum_prepare(), which handles tunnel packets correctly, but Tx burst path does not take tunnel presence into account when computing the offsets. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/virtio/virtqueue.h | 9 ++--- 1 fil

[dpdk-dev] [PATCH v6 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-30 Thread Igor Ryzhov
Current implementation doesn't allow us to update KNI carrier if the interface is not yet UP in kernel. It means that we can't use it in the same thread which is processing rte_kni_ops.config_network_if, which is very convenient, because it allows us to have correct carrier status of the interface

[dpdk-dev] [PATCH v6 2/3] kni: implement basic get_link_ksettings callback

2021-08-30 Thread Igor Ryzhov
It allows inspecting link parameters using ethtool. Signed-off-by: Igor Ryzhov --- kernel/linux/kni/kni_net.c | 25 + 1 file changed, 25 insertions(+) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index 611719b5ee27..931b9daf104f 100644 --- a/kerne

[dpdk-dev] [PATCH v6 3/3] app/test: fix return value of test_kni_link_change

2021-08-30 Thread Igor Ryzhov
If the child process returns -1, WEXITSTATUS converts to 255 because it takes only 8 least significant bits. As a result, the test is not considered failed when it should. Signed-off-by: Igor Ryzhov --- app/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/t

Re: [dpdk-dev] [PATCH RFC 0/1] vhost-add-DMADEV-support-for-async-datapath

2021-08-30 Thread Maxime Coquelin
Hi Sunil, On 8/23/21 11:53 AM, Sunil Pai G wrote: > Note to the reader: > --- > The intent of this patch is to explore possible different approaches > of async implementations. > Please consider this patch for discussions only and not for > merge/upstream. Thanks for sharing, that

[dpdk-dev] [PATCH] net/sfc: make EF100 native Rx datapath set FDIR bit for MARK

2021-08-30 Thread Ivan Malov
According to flow action MARK definition, PMDs must set both PKT_RX_FDIR and PKT_RX_FDIR_ID if the packet contains a mark. Fixes: 1aacc3d388d3 ("net/sfc: support user mark and flag Rx for EF100") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sf

Re: [dpdk-dev] [RFC 06/15] eventdev: use new API for inline functions

2021-08-30 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, August 24, 2021 1:10 AM > To: jer...@marvell.com; Gujjar, Abhinandan S ; > Jayatheerthan, Jay > Cc: Ananyev, Konstantin ; dev@dpdk.org; Pavan > Nikhilesh > Subject: [dpdk-dev] [RFC 06/15] eventdev: use new API for i

Re: [dpdk-dev] [RFC 10/15] eventdev: remove rte prefix for internal structs

2021-08-30 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, August 24, 2021 1:10 AM > To: jer...@marvell.com; Gujjar, Abhinandan S ; > Jayatheerthan, Jay > Cc: Ananyev, Konstantin ; dev@dpdk.org; Pavan > Nikhilesh > Subject: [dpdk-dev] [RFC 10/15] eventdev: remove rte prefix

Re: [dpdk-dev] [RFC 13/15] eventdev: promote event vector API to stable

2021-08-30 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, August 24, 2021 1:10 AM > To: jer...@marvell.com; Jayatheerthan, Jay ; Ray > Kinsella > Cc: Ananyev, Konstantin ; dev@dpdk.org; Pavan > Nikhilesh > Subject: [dpdk-dev] [RFC 13/15] eventdev: promote event vector API

Re: [dpdk-dev] [RFC 06/15] eventdev: use new API for inline functions

2021-08-30 Thread David Marchand
Hello Pavan, On Mon, Aug 23, 2021 at 9:41 PM wrote: > > From: Pavan Nikhilesh > > Use new driver interface for the fastpath enqueue/dequeue inline > functions. > > Signed-off-by: Pavan Nikhilesh > --- > lib/eventdev/rte_event_crypto_adapter.h | 13 +- > lib/eventdev/rte_event_eth_tx_adapte

Re: [dpdk-dev] [RFC 14/15] eventdev: make trace APIs internal

2021-08-30 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, August 24, 2021 1:10 AM > To: jer...@marvell.com; Gujjar, Abhinandan S ; > Jayatheerthan, Jay ; > Carrillo, Erik G > Cc: Ananyev, Konstantin ; dev@dpdk.org; Pavan > Nikhilesh > Subject: [dpdk-dev] [RFC 14/15] eventd

[dpdk-dev] [PATCH] net/virtio: reconfigure LSC handler when required

2021-08-30 Thread David Marchand
There is no reason to re-register a interrupt handler for LSC if this feature was not requested in the first place. A simple usecase is when asking for Rx interrupts without LSC interrupt. Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") Cc: sta...@dpdk.org Signed-off-by: David March

Re: [dpdk-dev] [PATCH 2/4] cryptodev: promote asym APIs to stable

2021-08-30 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Saturday, July 31, 2021 8:13 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; ma...@nvi

[dpdk-dev] [PATCH v2] event/cnxk: fix SSO and TIM argument parsing

2021-08-30 Thread Shijith Thotton
Type of kvargs value and handler function argument should match to avoid spilling memory. Fixes: 7ffa7379965e ("event/cnxk: add option to configure getwork mode") Signed-off-by: Shijith Thotton --- v2: * Rebased. drivers/event/cnxk/cnxk_eventdev.c | 6 +++--- drivers/event/cnxk/cnxk_tim_evdev

[dpdk-dev] [PATCH v2] event/cnxk: reduce max timer chunk pool cache size

2021-08-30 Thread Shijith Thotton
Reduced max chunk pool cache size from RTE_MEMPOOL_CACHE_MAX_SIZE(512) to 128. If chunk pool cache is empty, it gets filled during arm. Filling 512 entries at a time will fail arm if timeout is shorter. Fixes: 0e792433d051 ("event/cnxk: create and free timer adapter") Signed-off-by: Shijith Thot

[dpdk-dev] [PATCH 1/2] common/cnxk: update roc models

2021-08-30 Thread Ashwin Sekhar T K
Update roc models. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_model.c | 51 +++ drivers/common/cnxk/roc_model.h | 53 + 2 files changed, 67 insertions(+), 37 deletions(-) diff --git a/drivers/common/cnxk/roc_model.c b

[dpdk-dev] [PATCH 2/2] common/cnxk: avoid using stashing option of stype

2021-08-30 Thread Ashwin Sekhar T K
Avoid using stashing option of stype in NPA in cn10k-a0 stepping. This is a workaround for a HW Errata due to which NPA stashing operations will never result in writing the data into L2 cache. But instead, it will be written into LLC. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc

[dpdk-dev] [PATCH v3 1/2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-30 Thread Honnappa Nagarahalli
Remove the usage of pthread barrier and replace it with synchronization using atomic variable. This also removes the use of reference count required to synchronize freeing the memory. Signed-off-by: Honnappa Nagarahalli --- v3: 1) RFC to Patch 2) Changed commit log and API description [Olivier] 3

[dpdk-dev] [PATCH v3 2/2] test/eal: add a test for rte_ctrl_thread_create

2021-08-30 Thread Honnappa Nagarahalli
Add a testcase to test launching of control threads. Signed-off-by: Honnappa Nagarahalli --- app/test/test_lcores.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/test/test_lcores.c b/app/test/test_lcores.c index 19a7ab9fce..738148f339 100644 -

Re: [dpdk-dev] [PATCH v3 2/2] test/eal: add a test for rte_ctrl_thread_create

2021-08-30 Thread Stephen Hemminger
On Mon, 30 Aug 2021 11:34:13 -0500 Honnappa Nagarahalli wrote: > +static int > +test_crtl_thread(void) Is this a typo? Did you mean test_ctrl_thread?

Re: [dpdk-dev] [PATCH v3 2/2] test/eal: add a test for rte_ctrl_thread_create

2021-08-30 Thread Honnappa Nagarahalli
> > On Mon, 30 Aug 2021 11:34:13 -0500 > Honnappa Nagarahalli wrote: > > > +static int > > +test_crtl_thread(void) > > Is this a typo? Did you mean test_ctrl_thread? Yes, thanks

Re: [dpdk-dev] [PATCH v3 1/2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-30 Thread Stephen Hemminger
On Mon, 30 Aug 2021 11:34:12 -0500 Honnappa Nagarahalli wrote: > + /* Control thread status. > + * > + * _RTE_CTRL_THREAD_LAUNCHING - Yet to call pthread_create function > + * _RTE_CTRL_THREAD_RUNNING - Control thread is running successfully > + * _RTE_CTRL_THREAD_ERROR -

[dpdk-dev] KNI compilation

2021-08-30 Thread spyroot
Hi Folks, I troubleshooting already for a couple of hours but still not clear why exactly the build process failing on the KNI module. I've tried to disable KNI but it same issue. Any ideas what might be a root cause. It x86_64 [1/2] Generating rte_kni with a custom command FAILED: kernel/linu

Re: [dpdk-dev] [PATCH v2] ethdev: add namespace

2021-08-30 Thread Ferruh Yigit
On 8/30/2021 10:41 AM, David Marchand wrote: > Hi Ferruh, > > On Fri, Aug 27, 2021 at 3:26 AM Ferruh Yigit wrote: >> >> Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > > For completeness, there are some struct renames too in this patch. > ack, will add to the commit lo

[dpdk-dev] [Bug 800] rte_malloc fails to allocate memory block, but succeeds allocating bigger block

2021-08-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=800 Bug ID: 800 Summary: rte_malloc fails to allocate memory block, but succeeds allocating bigger block Product: DPDK Version: 18.11 Hardware: All OS: All S

[dpdk-dev] [PATCH v3] net/mlx5: fix mutex unlock in txpp cleanup

2021-08-30 Thread Chengfeng Ye
The lock sh->txpp.mutex was not correctly released if the function returned in these two branches, which may led to deadlock if the function was acquired again. Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") Cc: sta...@dpdk.org Signed-off-by: Chengfeng Ye --- drivers/net/ml

[dpdk-dev] [PATCH v4] net/mlx5: fix mutex unlock in txpp cleanup

2021-08-30 Thread Chengfeng Ye
The lock sh->txpp.mutex was not correctly released if the function returned in these two branches, which may led to deadlock if the function was acquired again. Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") Cc: sta...@dpdk.org Signed-off-by: Chengfeng Ye --- drivers/net/m

Re: [dpdk-dev] KNI compilation

2021-08-30 Thread Ferruh Yigit
On 8/30/2021 5:47 PM, spyroot wrote: > Hi Folks, > > I troubleshooting already for a couple of hours but still not clear why > exactly the build process > failing on the KNI module. I've tried to disable KNI but it same issue. > Any ideas what might be a root cause. It x86_64 > > > [1/2] Gener

Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-30 Thread Igor Ryzhov
On Thu, Aug 26, 2021 at 9:06 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Thu, 26 Aug 2021 20:46:47 +0300 > Igor Ryzhov wrote: > > > Could you please clarify where exactly do I need to use rtnl lock? > > From what I understand, netif_carrier_on/off can be called without the > lo

Re: [dpdk-dev] [PATCH] vhost: Clean iotlb cache on vring stop

2021-08-30 Thread Eugenio Perez Martin
On Mon, Aug 30, 2021 at 1:58 PM Xia, Chenbo wrote: > > Hi Eugenio, > Hi Chenbo, > > -Original Message- > > From: Eugenio Pérez > > Sent: Saturday, August 28, 2021 12:13 AM > > To: Maxime Coquelin ; Xia, Chenbo > > > > Cc: dev@dpdk.org; Pei Zhang ; Jason Wang > > > > Subject: [PATCH] v

Re: [dpdk-dev] KNI compilation

2021-08-30 Thread spyroot
Hi Ferruh, Sorry, I forgot to mention, Yes, I was compiling with -Denable_kmods=true. I just partially found a root cause. The target system Photon OS (It VMware distro) It has 4 kernels variation regular, RT, ESX, security. ( I was using ESX variation that optimized for ESXi but it looks lik

[dpdk-dev] [PATCH] examples/l3fwd: add changes to use event vector

2021-08-30 Thread Shijith Thotton
Added changes to receive packets as event vector. By default this is disabled and can be enabled using the option --enable-vector. Vector size and timeout to form the vector can be configured using options --vector-size and --vector-tmo-ns. Example: dpdk-l3fwd -l 0-3 -n 4 -- -p 0x03 --mode

[dpdk-dev] [PATCH] eventdev: update crypto adapter metadata structures

2021-08-30 Thread Shijith Thotton
In crypto adapter metadata, reserved bytes in request info structure is a space holder for response info. It enforces an order of operation if the structures are updated using memcpy to avoid overwriting response info. It is logical to move the reserved space out of request info. It also solves the

[dpdk-dev] [PATCH v2] eventdev: update crypto adapter metadata structures

2021-08-30 Thread Shijith Thotton
In crypto adapter metadata, reserved bytes in request info structure is a space holder for response info. It enforces an order of operation if the structures are updated using memcpy to avoid overwriting response info. It is logical to move the reserved space out of request info. It also solves the

[dpdk-dev] [RFC] eventdev: uninline inline API functions

2021-08-30 Thread Mattias Rönnblom
Replace the inline functions in the eventdev user application API with regular non-inline API calls. This allows for a cleaner and more simple API/ABI, but might well also cause performance regressions. The purpose of this RFC patch is to allow for performance testing. The rte_eventdev struct dec

Re: [dpdk-dev] [PATCH 3/8] cryptodev: add helper functions for new datapath interface

2021-08-30 Thread Zhang, Roy Fan
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@

Re: [dpdk-dev] [PATCH 1/4] test/crypto: remove illegal header include

2021-08-30 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, August 5, 2021 9:03 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; r

[dpdk-dev] [PATCH] app/test: fix event timer adapter create unit test

2021-08-30 Thread Shijith Thotton
Removed freeing of unallocated mempool in event timer adapter create unit test. Fixes: d1f3385d0076 ("test: add event timer adapter auto-test") Signed-off-by: Shijith Thotton --- app/test/test_event_timer_adapter.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_event_timer_a

Re: [dpdk-dev] [PATCH 2/4] cryptodev: change valid dev API

2021-08-30 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, August 5, 2021 9:03 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; r

Re: [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs

2021-08-30 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, August 11, 2021 9:20 AM > To: Matan Azrad ; dev@dpdk.org > Cc: Anoob Joseph ; Nicolau, Radu > ; Doherty, Declan ; > hemant.agra...@nxp.com; Ananyev, Konstantin > ; NBU-Contact-Thomas Monjalon > ; Zhang, Roy Fan ; > asoma...@amd.co

  1   2   >