> -----Original Message-----
> From: pbhagavat...@marvell.com <pbhagavat...@marvell.com>
> Sent: Tuesday, August 24, 2021 1:10 AM
> To: jer...@marvell.com; Gujjar, Abhinandan S <abhinandan.guj...@intel.com>;
> Jayatheerthan, Jay <jay.jayatheert...@intel.com>;
> Carrillo, Erik G <erik.g.carri...@intel.com>
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org; Pavan
> Nikhilesh <pbhagavat...@marvell.com>
> Subject: [dpdk-dev] [RFC 14/15] eventdev: make trace APIs internal
>
> From: Pavan Nikhilesh <pbhagavat...@marvell.com>
>
> Slowpath trace APIs are only used in rte_eventdev.c so make them
> as internal.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com>
> ---
> lib/eventdev/{rte_eventdev_trace.h => eventdev_trace.h} | 0
> lib/eventdev/eventdev_trace_points.c | 2 +-
> lib/eventdev/meson.build | 2 +-
> lib/eventdev/rte_event_crypto_adapter.c | 2 +-
> lib/eventdev/rte_event_eth_rx_adapter.c | 2 +-
> lib/eventdev/rte_event_eth_tx_adapter.c | 2 +-
> lib/eventdev/rte_event_timer_adapter.c | 2 +-
> lib/eventdev/rte_eventdev.c | 2 +-
> 8 files changed, 7 insertions(+), 7 deletions(-)
> rename lib/eventdev/{rte_eventdev_trace.h => eventdev_trace.h} (100%)
>
> diff --git a/lib/eventdev/rte_eventdev_trace.h b/lib/eventdev/eventdev_trace.h
> similarity index 100%
> rename from lib/eventdev/rte_eventdev_trace.h
> rename to lib/eventdev/eventdev_trace.h
> diff --git a/lib/eventdev/eventdev_trace_points.c
> b/lib/eventdev/eventdev_trace_points.c
> index 3867ec8008..237d9383fd 100644
> --- a/lib/eventdev/eventdev_trace_points.c
> +++ b/lib/eventdev/eventdev_trace_points.c
> @@ -4,7 +4,7 @@
>
> #include <rte_trace_point_register.h>
>
> -#include "rte_eventdev_trace.h"
> +#include "eventdev_trace.h"
>
> /* Eventdev trace points */
> RTE_TRACE_POINT_REGISTER(rte_eventdev_trace_configure,
> diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
> index f19b831edd..c750e0214f 100644
> --- a/lib/eventdev/meson.build
> +++ b/lib/eventdev/meson.build
> @@ -19,7 +19,6 @@ sources = files(
> )
> headers = files(
> 'rte_eventdev.h',
> - 'rte_eventdev_trace.h',
> 'rte_eventdev_trace_fp.h',
> 'rte_event_ring.h',
> 'rte_event_eth_rx_adapter.h',
> @@ -34,6 +33,7 @@ driver_sdk_headers += files(
> 'eventdev_pmd.h',
> 'eventdev_pmd_pci.h',
> 'eventdev_pmd_vdev.h',
> + 'eventdev_trace.h',
> 'event_timer_adapter_pmd.h',
> )
>
> diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> b/lib/eventdev/rte_event_crypto_adapter.c
> index 8a2a25c02e..93e7352c6e 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.c
> +++ b/lib/eventdev/rte_event_crypto_adapter.c
> @@ -16,7 +16,7 @@
>
> #include "rte_eventdev.h"
> #include "eventdev_pmd.h"
> -#include "rte_eventdev_trace.h"
> +#include "eventdev_trace.h"
> #include "rte_event_crypto_adapter.h"
>
> #define BATCH_SIZE 32
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index f8225ebd3d..7e97fbd21d 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -20,7 +20,7 @@
>
> #include "rte_eventdev.h"
> #include "eventdev_pmd.h"
> -#include "rte_eventdev_trace.h"
> +#include "eventdev_trace.h"
> #include "rte_event_eth_rx_adapter.h"
>
> #define BATCH_SIZE 32
Looks good to me.
Acked-by: Jay Jayatheerthan <jay.jayatheert...@intel.com>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c
> b/lib/eventdev/rte_event_eth_tx_adapter.c
> index 18c0359db7..ee3631bced 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -6,7 +6,7 @@
> #include <rte_ethdev.h>
>
> #include "eventdev_pmd.h"
> -#include "rte_eventdev_trace.h"
> +#include "eventdev_trace.h"
> #include "rte_event_eth_tx_adapter.h"
>
> #define TXA_BATCH_SIZE 32
Looks good to me.
Acked-by: Jay Jayatheerthan <jay.jayatheert...@intel.com>
> diff --git a/lib/eventdev/rte_event_timer_adapter.c
> b/lib/eventdev/rte_event_timer_adapter.c
> index c4dc7a5fd4..7404b0cbb2 100644
> --- a/lib/eventdev/rte_event_timer_adapter.c
> +++ b/lib/eventdev/rte_event_timer_adapter.c
> @@ -24,7 +24,7 @@
> #include "eventdev_pmd.h"
> #include "rte_event_timer_adapter.h"
> #include "rte_eventdev.h"
> -#include "rte_eventdev_trace.h"
> +#include "eventdev_trace.h"
>
> #define DATA_MZ_NAME_MAX_LEN 64
> #define DATA_MZ_NAME_FORMAT "rte_event_timer_adapter_data_%d"
> diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
> index b9b029edc4..3a393bd120 100644
> --- a/lib/eventdev/rte_eventdev.c
> +++ b/lib/eventdev/rte_eventdev.c
> @@ -36,7 +36,7 @@
>
> #include "rte_eventdev.h"
> #include "eventdev_pmd.h"
> -#include "rte_eventdev_trace.h"
> +#include "eventdev_trace.h"
>
> struct rte_eventdev *rte_eventdevs;
>
> --
> 2.17.1
