Re: [dpdk-dev] [PATCH] net/iavf: remove interrupt handler

2021-08-10 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, RobinX > Sent: Friday, July 23, 2021 3:47 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z ; Guo, Junfeng ; > Yang, SteveX ; Zhang, RobinX > > Subject: [PATCH] net/iavf: remove interrupt handler As you are not going to remo

[dpdk-dev] [PATCH] net/octeontx2: configure MTU value correctly

2021-08-10 Thread Hanumanth Reddy Pothula
Update MTU value based on PTP enable status and reserve eight bytes in TX path to accommodate VLAN tags. If PTP is enabled maximum allowed MTU is 9200 otherwise it's 9208. Signed-off-by: Hanumanth Reddy Pothula --- drivers/net/octeontx2/otx2_ethdev_ops.c | 8 +++- 1 file changed, 7 insertio

Re: [dpdk-dev] [External] Re: [PATCH v2] app/testpmd: flowgen support ip and udp fields

2021-08-10 Thread 王志宏
Hi Aman, On Mon, Aug 9, 2021 at 8:21 PM Singh, Aman Deep wrote: > > Hi Wang, > > On 8/9/2021 12:22 PM, Zhihong Wang wrote: > > This patch aims to: > 1. Add flexibility by supporting IP & UDP src/dst fields > 2. Improve multi-core performance by using per-core vars > > v2: fix assigning ip heade

[dpdk-dev] [PATCH v3 0/2] Use macro to print MAC address

2021-08-10 Thread Aman Singh
Added macros to simplyfy print of MAC address. The other method of first formatting mac address into a string and string printed, is avoided. Aman Singh (2): net: macro for MAC address print net: macro to extract MAC address bytes app/pdump/main.c | 5 +--- app/

[dpdk-dev] [PATCH v3 1/2] net: macro for MAC address print

2021-08-10 Thread Aman Singh
Added macro to print six bytes of MAC address. The MAC addresses will be printed in lower case hexdecimal format. In case there is a specific check for upper case MAC address, the user may need to make a change in such test case after this patch. Signed-off-by: Aman Singh --- app/test-pmd/cmdlin

[dpdk-dev] [PATCH v3 2/2] net: macro to extract MAC address bytes

2021-08-10 Thread Aman Singh
Added macros to simplyfy print of MAC address. The other method of first formatting mac address into a string and string printed, is avoided. Signed-off-by: Aman Singh --- The change in the document will be done in seperate patch. To ensure document has direct reference of the code. V2: Fix buil

Re: [dpdk-dev] [PATCH] net/iavf: support FDIR L3 fields for IP fragment packets

2021-08-10 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Monday, August 2, 2021 3:58 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; Zhang, Qi Z > Cc: Wu, Wenjun1 > Subject: [PATCH] net/iavf: support FDIR L3 fields for IP fragment packets > > Add support of FDIR L3 fields for both IPv

Re: [dpdk-dev] [PATCH] net/bonding:fix balance-xor link down stack overflow

2021-08-10 Thread Min Hu (Connor)
Hi, Your patch is OK, but the description is misleading and has syntax errors. Please fix it ,thanks. 在 2021/8/10 14:43, jilei 写道: When slave link down, deactivate_slave will internals->active_slaves and internals->active_slave_count.Active_slave in bond_ethdev_rx_burst may out of range

Re: [dpdk-dev] [PATCH] net/i40e: fix clang warning on non-x86

2021-08-10 Thread Zhang, Qi Z
> -Original Message- > From: Ruifeng Wang > Sent: Friday, July 30, 2021 5:33 PM > To: Xing, Beilei ; Yu, DapengX > ; Zhang, Qi Z > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > n...@arm.com; Ruifeng Wang > Subject: [PATCH] net/i40e: fix clang warning on non-x86 >

Re: [dpdk-dev] [External] Re: [PATCH v2] app/testpmd: flowgen support ip and udp fields

2021-08-10 Thread 王志宏
Thanks for the review Ferruh :) On Mon, Aug 9, 2021 at 11:18 PM Ferruh Yigit wrote: > > On 8/9/2021 7:52 AM, Zhihong Wang wrote: > > This patch aims to: > > 1. Add flexibility by supporting IP & UDP src/dst fields > > What is the reason/"use case" of this flexibility? The purpose is to emulate

[dpdk-dev] [Bug 786] dynamic memory model may cause potential DMA silent error

2021-08-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=786 Bug ID: 786 Summary: dynamic memory model may cause potential DMA silent error Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRM

[dpdk-dev] request for upstreaming MTU changes

2021-08-10 Thread Hanumanth Reddy Pothula
Hello Team, Please help in upstreaming the attached changes. With this change, MTU will be configured correctly. Regards, Hanumanth

[dpdk-dev] [PATCH] net/bonding:fix balance-xor link down stack overflow

2021-08-10 Thread jilei
When slave link down, deactivate_slave will internals->active_slaves and internals->active_slave_count.Active_slave in bond_ethdev_rx_burst may out of range in internals->active_slaves.It will get bond's port_id cause stack overflow Cc: sta...@dpdk.org Signed-off-by: jilei --- drivers/net/bondin

Re: [dpdk-dev] [RFC] ethdev: change queue release callback

2021-08-10 Thread Ferruh Yigit
On 8/10/2021 9:03 AM, Xueming(Steven) Li wrote: > Hi Singh and Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, August 9, 2021 11:31 PM >> To: Singh, Aman Deep ; Andrew Rybchenko >> ; Xueming(Steven) Li >> >> Cc: dev@dpdk.org; Slava Ovsiienko ; >> NBU-Contact-Thom

Re: [dpdk-dev] [External] Re: [PATCH v2] app/testpmd: flowgen support ip and udp fields

2021-08-10 Thread Ferruh Yigit
On 8/10/2021 8:57 AM, 王志宏 wrote: > Thanks for the review Ferruh :) > > On Mon, Aug 9, 2021 at 11:18 PM Ferruh Yigit wrote: >> >> On 8/9/2021 7:52 AM, Zhihong Wang wrote: >>> This patch aims to: >>> 1. Add flexibility by supporting IP & UDP src/dst fields >> >> What is the reason/"use case" of th

[dpdk-dev] [PATCH] net/bnxt: fix to reset Rx next consumer index

2021-08-10 Thread Somnath Kotur
In bnxt_init_one_rx_ring(), reset this variable internal to the driver ring to 0, so that there is no mismatch with actual value in HW on traffic resumption. Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion") Cc: sta...@dpdk.org Signed-off-by: Somnath Kotur Reviewed-by: Kalesh

Re: [dpdk-dev] [PATCH] net/mlx5: fix matching on eCPRI

2021-08-10 Thread Matan Azrad
From: Dmitry Kozlyuk > When an ETH or VLAN flow item directly preceding ECPRI (i. e. a pattern for > eCPRI over Ethernet) did not specify the eCPRI protocol, matches were not > restricted to eCPRI traffic. For example, "eth / ecpri / end" > pattern behaved as "eth / end". Implicitly add Ethernet

[dpdk-dev] [PATCH v14 0/6] support dmadev

2021-08-10 Thread Chengwen Feng
This patch set contains six patch for new add dmadev. Chengwen Feng (6): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DMA

[dpdk-dev] [PATCH v14 6/6] maintainers: add for dmadev

2021-08-10 Thread Chengwen Feng
This patch add Chengwen Feng as dmadev's maintainer. Signed-off-by: Chengwen Feng --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac..fd9feb1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -496,6 +496,11 @@ F: drivers/raw/skeleton/ F:

[dpdk-dev] [PATCH v14 2/6] dmadev: introduce DMA device library internal header

2021-08-10 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/

[dpdk-dev] [PATCH v14 3/6] dmadev: introduce DMA device library PMD header

2021-08-10 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h | 2 ++ lib/dmadev/rte_dmadev_pmd.h | 72 ++

[dpdk-dev] [PATCH v14 4/6] dmadev: introduce DMA device library implementation

2021-08-10 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- config/rte_config.h | 3 + lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmade

[dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-10 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/dmadev.rst | 126 doc/guides/prog_guide/img/dmadev.svg | 283 +++ doc/guides/prog_guide/index.rst | 1 + 3 files changed, 410 insertions(+) cr

[dpdk-dev] [PATCH v14 1/6] dmadev: introduce DMA device library public APIs

2021-08-10 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Jerin Jacob -

Re: [dpdk-dev] [RFC] ethdev: change queue release callback

2021-08-10 Thread Xueming(Steven) Li
Hi Singh and Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Monday, August 9, 2021 11:31 PM > To: Singh, Aman Deep ; Andrew Rybchenko > ; Xueming(Steven) Li > > Cc: dev@dpdk.org; Slava Ovsiienko ; > NBU-Contact-Thomas Monjalon > Subject: Re: [dpdk-dev] [RFC] ethdev: change

Re: [dpdk-dev] [RFC] ethdev: change queue release callback

2021-08-10 Thread Xueming(Steven) Li
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, August 10, 2021 4:54 PM > To: Xueming(Steven) Li ; Singh, Aman Deep > ; Andrew Rybchenko > > Cc: dev@dpdk.org; Slava Ovsiienko ; > NBU-Contact-Thomas Monjalon > Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callb

Re: [dpdk-dev] [PATCH v1] doc: fix CI typo warnings

2021-08-10 Thread Kinsella, Ray
yah - I would oblige. Ray K On 09/08/2021 15:43, Aaron Conole wrote: > Ray Kinsella writes: > >> Fix documentation typos that are generating spurious CI warnings. >> >> Signed-off-by: Ray Kinsella >> --- > > Looks like there are still a few errors. Ex: > > ioat: end-before not used anywhere

[dpdk-dev] [Bug 787] Vashikaran specialist near me

2021-08-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=787 Bug ID: 787 Summary: Vashikaran specialist near me Product: DPDK Version: 21.05 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Norm

[dpdk-dev] [Bug 787] Vashikaran specialist near me

2021-08-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=787 Ajit Khaparde (ajit.khapa...@broadcom.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[dpdk-dev] [PATCH v2] doc: fix CI typo warnings

2021-08-10 Thread Ray Kinsella
Fix documentation typos that are generating spurious CI warnings. Signed-off-by: Ray Kinsella --- v2: * Fix some additional typos pointed out by Aaron Conole doc/guides/rel_notes/deprecation.rst | 4 ++-- doc/guides/sample_app_ug/ioat.rst| 2 +- doc/guides/sample_app_ug/vm

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-10 Thread Walsh, Conor
[snip] Hi Chengwen, I have included some feedback to improve the grammar and readability of the docs inline. > +Device Management > +- > + > +Device Creation > +~~~ > + > +Physical DMA controller is discovered during the PCI probe/enumeration of ^ "controllers are" in

[dpdk-dev] [Bug 788] i40e: 16BYTE_RX_DESC build broken on FreeBSD-13

2021-08-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=788 Bug ID: 788 Summary: i40e: 16BYTE_RX_DESC build broken on FreeBSD-13 Product: DPDK Version: 21.08 Hardware: x86 OS: FreeBSD Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v2 0/4] cryptodev: expose driver interface as internal

2021-08-10 Thread Akhil Goyal
rte_cryptodev_pmd.* files are meant to be used for DPDK internal usage only, but it was used illegally by applications. There is one API which can be used by applications to check if the dev_id has a valid device or not. This API is exposed and modified as rte_cryptodev_is_valid_dev() from rte_cryp

[dpdk-dev] [PATCH v2 1/4] test/crypto: remove illegal header include

2021-08-10 Thread Akhil Goyal
rte_cryptodev_pmd.h is an interface between driver and library and it is mentioned in the file that application cannot use it directly. Hence, removing the include. Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 1 - app/test/test_cryptodev_asym.c | 1 - app/te

[dpdk-dev] [PATCH v2 2/4] cryptodev: change valid dev API

2021-08-10 Thread Akhil Goyal
The API rte_cryptodev_pmd_is_valid_dev, can be used by the application as well as PMD to check whether the device is valid or not. Hence, _pmd is removed from the API. The applications and drivers which use this API are also updated. Signed-off-by: Akhil Goyal --- .../net/softnic/rte_eth_softnic

[dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs

2021-08-10 Thread Akhil Goyal
Some of the cryptodev APIs are not allowed to be used by application directly. Hence removing the usage of 1. queue_pair_release: it is not required, as configure of queue pair release the previous queue pairs and the dev is not directly exposed to application, hence cannot use its ops fro

[dpdk-dev] [PATCH v2 4/4] cryptodev: expose driver interface as internal

2021-08-10 Thread Akhil Goyal
The rte_cryptodev_pmd.* files are for drivers only and should be private to DPDK, and not installed for app use. Signed-off-by: Akhil Goyal --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 2 +- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c

Re: [dpdk-dev] [PATCH] eal/windows: add sys/queue.h.

2021-08-10 Thread Nick Connolly
diff --git a/lib/eal/windows/include/meson.build b/lib/eal/windows/include/meson.build index b3534b025f..875cc1cf0d 100644 --- a/lib/eal/windows/include/meson.build +++ b/lib/eal/windows/include/meson.build @@ -8,3 +8,7 @@ headers += files( 'rte_virt2phys.h', 'rte_windows.h',

Re: [dpdk-dev] [PATCH] eal/windows: add sys/queue.h.

2021-08-10 Thread Dmitry Kozlyuk
2021-08-10 22:05 (UTC+0100), Nick Connolly: > > diff --git a/lib/eal/windows/include/meson.build > > b/lib/eal/windows/include/meson.build > > index b3534b025f..875cc1cf0d 100644 > > --- a/lib/eal/windows/include/meson.build > > +++ b/lib/eal/windows/include/meson.build > > @@ -8,3 +8,7 @@ headers

[dpdk-dev] [PATCH] build: fix install from arbitrary directory for meson 0.55

2021-08-10 Thread Dmitry Kozlyuk
Install command for meson >= 0.55.0 referenced the script by a plain string, assuming the build directory to be directly under the source tree root. This resulted in an error when the assumption did not hold: c:\python\python.exe: can't open file '../buildtools/symlink-drivers-solibs.py':

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-10 Thread fengchengwen
Many thanks, will fix in v15 On 2021/8/10 23:27, Walsh, Conor wrote: > [snip] > > Hi Chengwen, > I have included some feedback to improve the grammar and readability > of the docs inline. > [snip]

Re: [dpdk-dev] [PATCH 00/28] ice: base code update

2021-08-10 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, August 10, 2021 10:51 AM > To: Yang, Qiming > Cc: Guo, Junfeng ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 00/28] ice: base code update > > Summary: > > 1. Add new module to support 1588 timesync / PTP. > 2. Couple FDIR /

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-10 Thread Xia, Chenbo
Hi Vijay, > -Original Message- > From: Vijay Srivastava > Sent: Wednesday, July 7, 2021 12:44 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver > >

Re: [dpdk-dev] [External] Re: [PATCH v2] app/testpmd: flowgen support ip and udp fields

2021-08-10 Thread 王志宏
On Tue, Aug 10, 2021 at 5:12 PM Ferruh Yigit wrote: > > On 8/10/2021 8:57 AM, 王志宏 wrote: > > Thanks for the review Ferruh :) > > > > On Mon, Aug 9, 2021 at 11:18 PM Ferruh Yigit wrote: > >> > >> On 8/9/2021 7:52 AM, Zhihong Wang wrote: > >>> This patch aims to: > >>> 1. Add flexibility by suppor

[dpdk-dev] 回复: [PATCH v1 2/2] devtools: use absolute path for the build directory

2021-08-10 Thread Feifei Wang
Hi, Thomas Thanks for your reviewing. I agree with your comment. As your concern, this patch is simple but may have some negative effects. Thus I will drop it from series in the next version. Best Regards Feifei > -邮件原件- > 发件人: Thomas Monjalon > 发送时间: Friday, August 6, 2021 11:43 PM >

[dpdk-dev] DTS Workgroup: MoM 08/03/2021

2021-08-10 Thread Honnappa Nagarahalli
Attendees: Aaron Conole Brandon Lo Honnappa Nagarahalli Juraj Linkes Lijuan Tu Owen Hilyard The meeting announcements are sent to dev@dpdk.org. Minutes: 1) Move DTS to follow standard python practices of organizing the project. This will be done after the 21.08 release. A write-up would be sent

[dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check

2021-08-10 Thread Feifei Wang
Add relative path support for ABI compatibility check. v2: 1. delete the code simplification patch due to negative effects (Thomas) Phil Yang (1): devtools: add relative path support for ABI compatibility check devtools/test-meson-builds.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[dpdk-dev] [PATCH v2 1/1] devtools: add relative path support for ABI compatibility check

2021-08-10 Thread Feifei Wang
From: Phil Yang Because dpdk guide does not limit the relative path for ABI compatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative path: ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared ./test-meson-builds.sh And if the DESTDIR is not an absolute pat