Hi Aman, On Mon, Aug 9, 2021 at 8:21 PM Singh, Aman Deep <aman.deep.si...@intel.com> wrote: > > Hi Wang, > > On 8/9/2021 12:22 PM, Zhihong Wang wrote: > > This patch aims to: > 1. Add flexibility by supporting IP & UDP src/dst fields > 2. Improve multi-core performance by using per-core vars > > v2: fix assigning ip header cksum > > Signed-off-by: Zhihong Wang <wangzhihong....@bytedance.com> > --- > <snip> > > From defination of flowgen as per the documentation- > > flowgen: Multi-flow generation mode. Originates a number of flows (with > varying destination IP addresses), and terminate receive traffic. > > So changing the src IP address may not fit the defination of a source > generating real traffic. > > I would like to check this part further.
Thanks for the review. The purpose of introducing them is to emulate pkt generators behaviors. Do you think keeping cfg_n_ip_src & cfg_n_udp_src while setting them = 1 by default makes sense? Or maybe update the documentation?
