Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

2021-06-17 Thread Thomas Monjalon
> > Check Bucket key for all possible indices. > > > > Fixes: d0a00966618ba ("table: add exact match SWX table") > > Cc: sta...@dpdk.org > > Cc: Cristian Dumitrescu > > > > Signed-off-by: Thierry Herbelot [...] > > - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) > > +

Re: [dpdk-dev] [PATCH v8 1/2] config/arm: select most suitable -march for kunpeng soc

2021-06-17 Thread Thomas Monjalon
24/05/2021 15:23, Chengwen Feng: > Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve', > but some compiler doesn't recognize the march because it doesn't > support sve. > > To solve this bug we use the following scheme: > 1. Define 'march_base' tuple which defines support march,

Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thomas Monjalon
25/05/2021 10:24, Thierry Herbelot: > 0xc00 is for "SoC 2.0" Qualcom Centriq servers. > 0x800 is for "SoC 1.1". > > Cc: Jerin Jacob > Cc: Ruifeng Wang > Cc: Honnappa Nagarahalli > Cc: Juraj Linkeš > > Signed-off-by: Thierry Herbelot > -- > V2: add maintainers as Cc > --- > --- a/config/arm/m

Re: [dpdk-dev] [PATCH] fix Marvell maintainer email for atlantic

2021-06-17 Thread Thomas Monjalon
25/05/2021 11:57, Igor Russkikh: > Fixing ex-Aquantia email - it is now part of Marvell. > Removing Pavel Belous email - he is not in company now. > > Also adding Marvell company prefix to the driver names for > both atlantic and qede, to eliminate any confusion. QLogic may be in a separate patch

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

2021-06-17 Thread Thierry Herbelot
On 6/17/21 9:01 AM, Thomas Monjalon wrote: Check Bucket key for all possible indices. Fixes: d0a00966618ba ("table: add exact match SWX table") Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Signed-off-by: Thierry Herbelot [...] - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !

Re: [dpdk-dev] [PATCH 05/20] crypto/cnxk: add queue pair ops

2021-06-17 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, June 16, 2021 4:36 PM > To: Anoob Joseph ; Thomas Monjalon > > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > ; Tejasree Kondoj ; > dev@dpdk.org; Anoob Joseph ; Archana Muniganti >

Re: [dpdk-dev] [PATCH 3/4] crypto/cnxk: add security session ops

2021-06-17 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, June 17, 2021 1:41 AM > To: Anoob Joseph ; Thomas Monjalon > > Cc: Tejasree Kondoj ; Jerin Jacob Kollanukkaran > ; Ankur Dwivedi ; > dev@dpdk.org; Anoob Joseph ; Archana Muniganti > ;

Re: [dpdk-dev] [PATCH 2/2] examples: move vendor specific apps to drivers sub directory

2021-06-17 Thread Thomas Monjalon
26/05/2021 09:47, Hemant Agrawal: > As approved by DPDK technical board on 2021-03-24 NTB and IOAT > raw driver's example application will be moved to > example/drivers/raw/ to avoid PMD specific example application examples with a s :) > to show up in examples directory. > > Signed-off-by: Hema

Re: [dpdk-dev] [PATCH] raw/ioat: fix missing device name in idxd bus scan

2021-06-17 Thread Thomas Monjalon
> > > The device name is not being initialized during the idxd bus scan > > > which will cause segmentation faults when an appliation tries to > > > access this information. > > > > > > This patch adds the required initialization of the device name so that > > > it can be read without issues. > > >

Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread David Marchand
On Thu, Jun 17, 2021 at 9:07 AM Thomas Monjalon wrote: > > 25/05/2021 10:24, Thierry Herbelot: > > 0xc00 is for "SoC 2.0" Qualcom Centriq servers. Qualcomm* > > 0x800 is for "SoC 1.1". > > > > Cc: Jerin Jacob > > Cc: Ruifeng Wang > > Cc: Honnappa Nagarahalli > > Cc: Juraj Linkeš > > > > Sign

Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 17, 2021 3:07 PM > To: jer...@marvell.com; Ruifeng Wang ; > Honnappa Nagarahalli > Cc: dev@dpdk.org; Thierry Herbelot ; Juraj > Linkeš > Subject: Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 > part num

Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 17, 2021 3:07 PM > To: jer...@marvell.com; Ruifeng Wang ; > Honnappa Nagarahalli > Cc: dev@dpdk.org; Thierry Herbelot ; Juraj > Linkeš > Subject: Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 > part num

[dpdk-dev] Recall: [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Ruifeng Wang
Ruifeng Wang would like to recall the message, "[dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number".

Re: [dpdk-dev] [PATCH v3 0/2] extend idxd config script functionality

2021-06-17 Thread Thomas Monjalon
28/05/2021 15:55, Kevin Laatz: > This patchset extends the functionality of the idxd config script, the > additions are described in the individual patches. > > v3: >- minor commit log updates >- remove printing if the script is running config or reset > > Kevin Laatz (2): > raw/ioat:

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Jerin Jacob
On Thu, Jun 17, 2021 at 12:43 AM Bruce Richardson wrote: > > On Wed, Jun 16, 2021 at 11:38:08PM +0530, Jerin Jacob wrote: > > On Wed, Jun 16, 2021 at 11:01 PM Bruce Richardson > > wrote: > > > > > > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > > > > On 2021/6/16 0:38, Bruce Ric

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix SPDX tag

2021-06-17 Thread Thomas Monjalon
11/06/2021 18:38, Kevin Traynor: > A stray character got added. Remove it. > > Fixes: cb056611a8ed ("eal: rename lcore master and slave") > Cc: sta...@dpdk.org > > Signed-off-by: Kevin Traynor > --- > -o.. SPDX-License-Identifier: BSD-3-Clause > +.. SPDX-License-Identifier: BSD-3-Clause Appli

Re: [dpdk-dev] [PATCH] doc: fix default burst size

2021-06-17 Thread Thomas Monjalon
28/05/2021 19:45, Ajit Khaparde: > Default burst size in testpmd has been changed from 16 to 32 > for some time now. But the documentation had not been updated. > > Fixes: 836853d3d4cf7 ("app/testpmd: increase default burst size to 32") > Cc: sta...@dpdk.org > Cc: bruce.richard...@intel.com > Cc:

Re: [dpdk-dev] [PATCH] Add Armv7 support

2021-06-17 Thread Thomas Monjalon
10/06/2021 13:18, s.chandrak...@globaledgesoft.com: > From: Chandrakant Sharpa > > Adding support for Armv7 based platforms. > Used latest GNU cross compiler toolchain > version(10.2) for testing. > > Signed-off-by: Chandrakant Sharpa > --- > config/arm/arm_armv7a_linux_gcc | 17 ++

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 01:12:22PM +0530, Jerin Jacob wrote: > On Thu, Jun 17, 2021 at 12:43 AM Bruce Richardson > wrote: > > > > On Wed, Jun 16, 2021 at 11:38:08PM +0530, Jerin Jacob wrote: > > > On Wed, Jun 16, 2021 at 11:01 PM Bruce Richardson > > > wrote: > > > > > > > > On Wed, Jun 16, 2021

Re: [dpdk-dev] FreeBSD 13 Memory / Contigmem Issues With Booting

2021-06-17 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 04:24:05PM -0400, Brandon Lo wrote: > Hi everyone, > > I have been trying to expand the UNH IOL unit testing coverage over to > FreeBSD 13. > Following this documentation: > https://doc.dpdk.org/guides/freebsd_gsg/build_dpdk.html#loading-the-dpdk-contigmem-module > > I com

Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2021-06-17 Thread Singh, Aman Deep
Hi Ivan, Another option is to log these structures values (rte_flow_attr ,  rte_flow_item, rte_flow_action) as it is. Latter run a parsing script on these logs, to convets them into meaningful flow items. The completeness of the solution will depend on how well script is maintained. Rega

[dpdk-dev] [RFC 1/4] test/virtual_pmd: enable getting device operations

2021-06-17 Thread Ferruh Yigit
This will be used to overwrite the dev_ops for various tests. Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 14 -- app/test/virtual_pmd.h | 6 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 7036

[dpdk-dev] [RFC 2/4] test/virtual_pmd: clean rings on close

2021-06-17 Thread Ferruh Yigit
Not cleaning the rings prevents creating devices again, which breaks to run some unit tests multiple times. Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c ind

[dpdk-dev] [RFC 3/4] test/virtual_pmd: enable updating device flags

2021-06-17 Thread Ferruh Yigit
To be able to test various dev_flags. Signed-off-by: Ferruh Yigit --- app/test/virtual_pmd.c | 10 ++ app/test/virtual_pmd.h | 4 2 files changed, 14 insertions(+) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 17f28c5a304c..615243e19aed 100644 --- a/app/test/v

[dpdk-dev] [RFC 4/4] test: support ethdev

2021-06-17 Thread Ferruh Yigit
Added unit test for ethdev APIs, this unit test 'ethdev_api_autotest' can run without physical device. If there are physical devices probed, they will be ignored by the unit test. A few issues fixed or some clarification added in the ehtdev library with in this unit test patch. Signed-off-by: Fer

[dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine description --- config/arm/meson.bui

Re: [dpdk-dev] [PATCH v2 00/20] net/sfc: support flow API COUNT action

2021-06-17 Thread David Marchand
Hello Andrew, On Fri, Jun 4, 2021 at 4:24 PM Andrew Rybchenko wrote: > > Update base driver and support COUNT action in transfer flow rules. > > v2: > - add release notes > - add missing documentaion > - fix spelling > - handle query in stopped gracefully I see build issues in the CI. Can yo

Re: [dpdk-dev] [PATCH v2 1/2] examples/l2fwd: fix long option parsing

2021-06-17 Thread David Marchand
On Fri, Jun 11, 2021 at 12:05 PM SunChengLian wrote: > > For l2fwd, --no-mac-updating and --mac-updating are treated as invalid > arguments.Rework long options parsing to let --no-mac-updating and > --mac-updating options work well. > > Fixes: fa19eb20d212 ("examples/l2fwd: add forwarding port map

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 08:07:26PM +0530, Jerin Jacob wrote: > On Wed, Jun 16, 2021 at 3:47 PM fengchengwen wrote: > > > > On 2021/6/16 15:09, Morten Brørup wrote: > > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > >> Sent: Tuesday, 15 June 2021 18.39 > > >> > > >> On

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] examples/l2fwd: remove mac-updating option

2021-06-17 Thread David Marchand
On Fri, Jun 11, 2021 at 12:28 PM SunChengLian wrote: > > The "mac-updating" option can be removed since the associated mac_updating > variable is set to 1 by default. > > Signed-off-by: SunChengLian > --- > examples/l2fwd/main.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > >

[dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc

2021-06-17 Thread Raslan Darawsheh
Define new rte header for gtp PDU session container based on RFC 38415-g30 Signed-off-by: Raslan Darawsheh --- v6 : fixed typos fixed indentation of comments for fields --- lib/net/rte_gtp.h | 78 +++ 1 file changed, 78 insertions(+) diff --git a

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread fengchengwen
On 2021/6/17 1:31, Bruce Richardson wrote: > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: >> On 2021/6/16 0:38, Bruce Richardson wrote: >>> On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: This patch introduces 'dmadevice' which is a generic type of DMA devi

Re: [dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Ruifeng Wang
> -Original Message- > From: Thierry Herbelot > Sent: Thursday, June 17, 2021 4:16 PM > To: dev@dpdk.org > Cc: Thierry Herbelot ; tho...@monjalon.net; > jer...@marvell.com; Ruifeng Wang ; Honnappa > Nagarahalli ; Juraj Linkeš > > Subject: [PATCH V3] config/arm: add Qualcomm Centriq 2400 p

[dpdk-dev] [PATCH v2 0/5] Enable ETS-based Tx QoS for VF in DCF

2021-06-17 Thread Ting Xu
This patch enables the ETS-based Tx QoS for IAVF. Kernel tool is used to configure ETS first. DCF is used to set bandwidth limit for VFs of each TC. IAVF is supported to query QoS capability and set queue TC mapping. Traffic Management API is utilized to configure the QoS hierarchy scheduler tree.

[dpdk-dev] [PATCH v2 1/5] common/iavf: support ETS-based QoS offload configuration

2021-06-17 Thread Ting Xu
This patch adds new virtchnl opcodes and structures for QoS configuration, which includes: 1. VIRTCHNL_VF_OFFLOAD_TC, to negotiate the capability supporting QoS configuration. If VF and PF both have this flag, then the ETS-based QoS offload function is supported. 2. VIRTCHNL_OP_DCF_CONFIG_BW, DCF i

[dpdk-dev] [PATCH v2 2/5] net/ice/base: support DCF query port ETS adminq

2021-06-17 Thread Ting Xu
In the adminq command query port ETS function, the root node teid is needed. However, for DCF, the root node is not initialized, which will cause error when we refer to the variable. In this patch, we will check whether the root node is available or not first. Signed-off-by: Ting Xu --- drivers/

[dpdk-dev] [PATCH v2 3/5] net/ice: support DCF link status event handling

2021-06-17 Thread Ting Xu
When link status changes, DCF will receive virtchnl PF event message. Add support to handle this event, change link status and update link info. Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.h| 6 drivers/net/ice/ice_dcf_ethdev.c | 54 ++-- drivers/

[dpdk-dev] [PATCH v2 4/5] net/ice: support QoS config VF bandwidth in DCF

2021-06-17 Thread Ting Xu
This patch supports the ETS-based QoS configuration. It enables the DCF to configure bandwidth limits for each VF VSI of different TCs. A hierarchy scheduler tree is built with port, TC and VSI nodes. Signed-off-by: Qiming Yang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 6 +

[dpdk-dev] [PATCH v2 5/5] net/iavf: query QoS cap and set queue TC mapping

2021-06-17 Thread Ting Xu
This patch added the support for VF to config the ETS-based Tx QoS, including querying current QoS configuration from PF and config queue TC mapping. PF QoS is configured in advance and the queried info is provided to the user for future usage. VF queues are mapped to different TCs in PF through vi

[dpdk-dev] [PATCH v6 00/19] net: ngbe PMD

2021-06-17 Thread Jiawen Wu
This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. v6: - Correct style errors and re-split patches. v5: - Extend patches with device initialization and RxTx functions. v4: - Fix compile error. v3: - Use rte_ether functions to define marcos. v2: - Corre

[dpdk-dev] [PATCH v6 01/19] net/ngbe: add build and doc infrastructure

2021-06-17 Thread Jiawen Wu
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for ngbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS| 6 + doc/guides/nics/features/ngbe.ini | 10 + doc/guides/nics/index.rst | 1 + doc/guides

[dpdk-dev] [PATCH v6 02/19] net/ngbe: support probe and remove

2021-06-17 Thread Jiawen Wu
Add device IDs for Wangxun 1Gb NICs, map device IDs to register ngbe PMD. Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/base/meson.build | 18 +++ drivers/net/ngbe/base/ngbe_devids.h | 83 ++

[dpdk-dev] [PATCH v6 03/19] net/ngbe: add log type and error type

2021-06-17 Thread Jiawen Wu
Add log type and error type to trace functions. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst| 21 + drivers/net/ngbe/base/ngbe_status.h | 73 + drivers/net/ngbe/ngbe_ethdev.c | 14 ++ drivers/net/ngbe/ngbe_logs.h| 46 +

[dpdk-dev] [PATCH v6 04/19] net/ngbe: define registers

2021-06-17 Thread Jiawen Wu
Define all registers that will be used. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 1490 + 1 file changed, 1490 insertions(+) create mode 100644 drivers/net/ngbe/base/ngbe_regs.h diff --git a/drivers/net/ngbe/base/ngbe_regs.h b/drivers/net/ngb

[dpdk-dev] [PATCH v6 05/19] net/ngbe: set MAC type and LAN ID with device initialization

2021-06-17 Thread Jiawen Wu
Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy operation. Then initialize the shared code. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_dummy.h | 37 +

[dpdk-dev] [PATCH v6 06/19] net/ngbe: init and validate EEPROM

2021-06-17 Thread Jiawen Wu
Reset swfw lock before NVM access, init EEPROM and validate the checksum. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 2 + drivers/net/ngbe/base/ngbe_dummy.h | 23 drivers/net/ngbe/base/ngbe_eeprom.c | 203 drivers/net/ngbe/base/ngbe_e

[dpdk-dev] [PATCH v6 07/19] net/ngbe: add HW initialization

2021-06-17 Thread Jiawen Wu
Initialize the hardware by resetting the hardware in base code. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 21 +++ drivers/net/ngbe/base/ngbe_hw.c| 235 + drivers/net/ngbe/base/ngbe_hw.h| 9 ++ drivers/net/ngbe/base/ngbe_type.h | 30

[dpdk-dev] [PATCH v6 08/19] net/ngbe: identify PHY and reset PHY

2021-06-17 Thread Jiawen Wu
Identify PHY to get the PHY type, and perform a PHY reset. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build| 4 + drivers/net/ngbe/base/ngbe_dummy.h | 40 +++ drivers/net/ngbe/base/ngbe_hw.c | 40 ++- drivers/net/ngbe/base/ngbe_hw.h | 2 + drivers/net/ngbe/bas

[dpdk-dev] [PATCH v6 09/19] net/ngbe: store MAC address

2021-06-17 Thread Jiawen Wu
Store MAC addresses and init receive address filters. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 33 +++ drivers/net/ngbe/base/ngbe_hw.c| 323 + drivers/net/ngbe/base/ngbe_hw.h| 13 ++ drivers/net/ngbe/base/ngbe_type.h | 19 ++ drive

[dpdk-dev] [PATCH v6 10/19] net/ngbe: support link update

2021-06-17 Thread Jiawen Wu
Register to handle device interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 3 + doc/guides/nics/ngbe.rst | 5 + drivers/net/ngbe/base/ngbe_dummy.h | 6 + drivers/net/ngbe/base/ngbe_type.h | 11 + drivers/net/ngbe/ngbe_ethdev.c | 376 +

[dpdk-dev] [PATCH v6 11/19] net/ngbe: setup the check PHY link

2021-06-17 Thread Jiawen Wu
Setup PHY, determine link and speed status from PHY. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 18 +++ drivers/net/ngbe/base/ngbe_hw.c | 53 + drivers/net/ngbe/base/ngbe_hw.h | 6 + drivers/net/ngbe/base/ngbe_phy.c | 22 drivers/net/ngbe/

[dpdk-dev] [PATCH v6 12/19] net/ngbe: add Rx queue setup and release

2021-06-17 Thread Jiawen Wu
Setup device Rx queue and release Rx queue. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/meson.build | 1 + drivers/net/ngbe/ngbe_ethdev.c | 37 +++- drivers/net/ngbe/ngbe_ethdev.h | 16 ++ drivers/net/ngbe/ngbe_rxtx.c | 308 + drivers/net/ngbe/ngbe_rxtx.

[dpdk-dev] [PATCH v6 13/19] net/ngbe: add Tx queue setup and release

2021-06-17 Thread Jiawen Wu
Setup device Tx queue and release Tx queue. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 24 drivers/net/ngbe/ngbe_ethdev.h | 11 ++ drivers/net/ngbe/ngbe_rxtx.c | 206 + drivers/net/ngbe/ngbe_rxtx.h | 95 +++ 4 files chang

[dpdk-dev] [PATCH v6 15/19] net/ngbe: add simple Tx flow

2021-06-17 Thread Jiawen Wu
Initialize device with the simplest transmit functions. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 1 + drivers/net/ngbe/ngbe_ethdev.h | 3 + drivers/net/ngbe/ngbe_rxtx.c | 228 + drivers/net/ngbe/ngbe_rxtx.h | 27 4 files changed,

[dpdk-dev] [PATCH v6 14/19] net/ngbe: add simple Rx flow

2021-06-17 Thread Jiawen Wu
Initialize device with the simplest receive function. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 1 + drivers/net/ngbe/ngbe_ethdev.h | 3 + drivers/net/ngbe/ngbe_rxtx.c | 168 + drivers/net/ngbe/ngbe_rxtx.h | 81 4 file

[dpdk-dev] [PATCH v6 17/19] net/ngbe: add Tx queue start and stop

2021-06-17 Thread Jiawen Wu
Initializes transmit unit, support to start and stop transmit unit for specified queues. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/net/ngbe/ngbe_ethdev.c| 3 + drivers/net/ngbe/ngbe_ethdev.h| 7 ++ drive

[dpdk-dev] [PATCH v6 16/19] net/ngbe: add device start and stop operations

2021-06-17 Thread Jiawen Wu
Setup MSI-X interrupt, complete PHY configuration and set device link speed to start device. Disable interrupt, stop hardware and clear queues to stop device. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 16 + drivers/net/ngbe/base/ngbe_hw.c | 49 +++ drivers/net/ng

[dpdk-dev] [PATCH v6 18/19] net/ngbe: add Rx queue start and stop

2021-06-17 Thread Jiawen Wu
Initializes receive unit, support to start and stop receive unit for specified queues. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 15 ++ drivers/net/ngbe/base/ngbe_hw.c| 105 ++ drivers/net/ngbe/base/ngbe_hw.h| 4 + drivers/net/ngbe/base/ngbe_type.h

[dpdk-dev] [PATCH v6 19/19] net/ngbe: support to close and reset device

2021-06-17 Thread Jiawen Wu
Support to close and reset device. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 61 -- drivers/net/ngbe/ngbe_ethdev.h | 2 ++ drivers/net/ngbe/ngbe_rxtx.c | 20 +++ 3 files changed, 81 insertions(+), 2 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 0/7] vhost: Fix and improve NUMA reallocation

2021-06-17 Thread Maxime Coquelin
This patch series first fixes missing reallocations of some Virtqueue and device metadata. Then, it improves the numa_realloc function by using rte_realloc_socket API that takes care of the memcpy & freeing. The VQs NUMA IDs are also saved in the VQ metadata and used for every allocations so that

[dpdk-dev] [PATCH 2/7] vhost: fix missing guest pages table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the guest pages table was missing, which likely causes at least one cross-NUMA accesses for ever

[dpdk-dev] [PATCH 1/7] vhost: fix missing memory table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the Vhost memory table was missing, which likely causes iat least one cross-NUMA accesses for ev

[dpdk-dev] [PATCH 3/7] vhost: fix missing cache logging NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the log cache on the new NUMA node was not done. This patch fixes this by reallocating it if it

[dpdk-dev] [PATCH 4/7] vhost: fix NUMA reallocation with multiqueue

2021-06-17 Thread Maxime Coquelin
Since the Vhost-user device initialization has been reworked, enabling the application to start using the device as soon as the first queue pair is ready, NUMA reallocation no more happened on queue pairs other than the first one since numa_realloc() was returning early if the device was running.

[dpdk-dev] [PATCH 5/7] vhost: improve NUMA reallocation

2021-06-17 Thread Maxime Coquelin
This patch improves the numa_realloc() function by making use of rte_realloc_socket(), which takes care of the memory copy and freeing of the old data. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/vhost_user.c | 190 + 1 file

[dpdk-dev] [PATCH 6/7] vhost: allocate all data on same node as virtqueue

2021-06-17 Thread Maxime Coquelin
This patch saves the NUMA node the virtqueue is allocated on at init time, in order to allocate all other data on the same node. While most of the data are allocated before numa_realloc() is called and so the data will be reallocated properly, some data like the log cache are most likely allocated

[dpdk-dev] [PATCH 7/7] vhost: convert inflight data to DPDK allocation API

2021-06-17 Thread Maxime Coquelin
Inflight metadata are allocated using glibc's calloc. This patch converts them to rte_zmalloc_socket to take care of the NUMA affinity. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 4 +-- lib/vhost/vhost_user.c | 67 +++--- 2 files changed, 58

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 05:48:05PM +0800, fengchengwen wrote: > On 2021/6/17 1:31, Bruce Richardson wrote: > > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > >> On 2021/6/16 0:38, Bruce Richardson wrote: > >>> On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: > Th

Re: [dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
On 6/17/21 12:03 PM, Ruifeng Wang wrote: -Original Message- From: Thierry Herbelot Sent: Thursday, June 17, 2021 4:16 PM To: dev@dpdk.org Cc: Thierry Herbelot ; tho...@monjalon.net; jer...@marvell.com; Ruifeng Wang ; Honnappa Nagarahalli ; Juraj Linkeš Subject: [PATCH V3] config/arm: ad

[dpdk-dev] [PATCH V4] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine description V4: add new soc_centriq24

Re: [dpdk-dev] [PATCH] net/mlx5: fix modify field action order for MAC

2021-06-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 5:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix modify field action order for MAC > > MAC addresses are split into 2 p

Re: [dpdk-dev] [PATCH] net/mlx5: convert meta register to big-endian

2021-06-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 5:46 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] net/mlx5: convert meta register to big-endian > > Metadata is stored in the CPU order (little-endian

[dpdk-dev] [PATCH V5] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine description V4: add new soc_centriq24

Re: [dpdk-dev] [PATCH 2/3] net/virtio: add device config support to vDPA

2021-06-17 Thread Maxime Coquelin
On 6/16/21 2:26 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, June 8, 2021 10:14 PM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; >> david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH 2/3] net/virtio:

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Ferruh Yigit
On 6/14/2021 4:54 PM, Ananyev, Konstantin wrote: > > >>> >>> 14/06/2021 15:15, Bruce Richardson: On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Monday, 14 June 2021 12.59 >> >> Pe

[dpdk-dev] [Bug 742] intermittent func_reentrancy_autotest failures

2021-06-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=742 Bug ID: 742 Summary: intermittent func_reentrancy_autotest failures Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v2 0/3] net/virtio: add vdpa device config support

2021-06-17 Thread Maxime Coquelin
This patch adds vDPA device config space requests support. For now, it only adds MAC address get and set. It may be extended in next revision to support other configs like link state. Regarding the MAC selection strategy, if devargs MAC address is set by the user and valid, the driver tries to sto

[dpdk-dev] [PATCH v2 1/3] net/virtio: keep device and frontend features separated

2021-06-17 Thread Maxime Coquelin
This patch is preliminary rework to add support for getting and setting device's config space. In order to get or set a device config such as its MAC address, we need to know whether the device itself support the feature, or if it is emulated by the frontend. Signed-off-by: Maxime Coquelin Revie

[dpdk-dev] [PATCH v2 2/3] net/virtio: add device config support to vDPA

2021-06-17 Thread Maxime Coquelin
This patch introduces two virtio-user callbacks to get and set device's config, and implements it for vDPA backends. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h | 3 + drivers/net/virtio/virtio_user/vhost_vdpa.c | 69 + 2 files changed, 72

[dpdk-dev] [PATCH v2 3/3] net/virtio: add MAC device config getter and setter

2021-06-17 Thread Maxime Coquelin
This patch uses the new device config ops to get and set the MAC address if supported. If a valid MAC address is passed as devarg of the Virtio-user PMD, the driver will try to store it in the device config space. Otherwise the one provided in the device config space will be used, if available. S

[dpdk-dev] [PATCH] raw/ioat: fix memory leak in device configure

2021-06-17 Thread Kevin Laatz
During device configure, memory is allocated for "hdl_ring_flags". In the event of another call to the device configure function (reconfigure), a memory leak would occur. This patch fixes the memory leak by free'ing the memory before reallocating it. Fixes: 245efe544d8e ("raw/ioat: report status o

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 12:02:00PM +0100, Bruce Richardson wrote: > On Thu, Jun 17, 2021 at 05:48:05PM +0800, fengchengwen wrote: > > On 2021/6/17 1:31, Bruce Richardson wrote: > > > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > > >> On 2021/6/16 0:38, Bruce Richardson wrote: > >

[dpdk-dev] [PATCH] raw/ioat: fix missing ring pointer reset

2021-06-17 Thread Kevin Laatz
In the event of a device reconfigure, "hdls_avail" is not being reset. This can lead to miscalculations in rte_ioat_completed_ops(), causing the function to report an incorrect amount of completed operations. This patch fixes the issue by resetting "hdls_avail" during the device configure. Fixes:

Re: [dpdk-dev] [PATCH] raw/ioat: fix memory leak in device configure

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 02:17:52PM +, Kevin Laatz wrote: > During device configure, memory is allocated for "hdl_ring_flags". In the > event of another call to the device configure function (reconfigure), a > memory leak would occur. This patch fixes the memory leak by free'ing the > memory bef

Re: [dpdk-dev] [PATCH] raw/ioat: fix missing ring pointer reset

2021-06-17 Thread Bruce Richardson
On Thu, Jun 17, 2021 at 02:18:15PM +, Kevin Laatz wrote: > In the event of a device reconfigure, "hdls_avail" is not being reset. This > can lead to miscalculations in rte_ioat_completed_ops(), causing the > function to report an incorrect amount of completed operations. This patch > fixes the

Re: [dpdk-dev] [PATCH v2] app/testpmd: send failure logs to stderr

2021-06-17 Thread Andrew Rybchenko
Hi On 6/17/21 6:29 AM, Li, Xiaoyun wrote: > Hi > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Thursday, June 17, 2021 00:32 >> To: Li, Xiaoyun ; Ori Kam >> Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, >> Ferruh ; Singh, Aman Deep >> >> Subject: [PATCH v2] app/testpmd: send

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-06-17 Thread Tyler Retzlaff
On Thu, May 20, 2021 at 08:17:54PM +, Akhil Goyal wrote: > > > > Yes it makes more sense now. But ideally it should be fixed in windows. they won't be fixed in windows. it is extremely rare to withdraw something from a platform headers namespace and is avoided to maintain API compatibility

Re: [dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Ruifeng Wang
> -Original Message- > From: Thierry Herbelot > Sent: Thursday, June 17, 2021 7:25 PM > To: Ruifeng Wang ; dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; Honnappa Nagarahalli > ; Juraj Linkeš > ; nd > Subject: Re: [PATCH V3] config/arm: add Qualcomm Centriq 2400 part > number

Re: [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD

2021-06-17 Thread Andrew Rybchenko
On 6/15/21 3:47 AM, Min Hu (Connor) wrote: > > > 在 2021/6/14 22:43, Andrew Rybchenko 写道: >> On 6/13/21 5:31 AM, Min Hu (Connor) wrote: >>> This patch set contains 6 bugfixes for hns3 PMD. >>> >>> Chengchang Tang (1): >>>    net/hns3: fix VLAN strip log >>> >>> HongBo Zheng (2): >>>    net/hns3: m

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Ananyev, Konstantin
> >>> > >>> 14/06/2021 15:15, Bruce Richardson: > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > >> Sent: Monday, 14 June 2021 12.59 > >> > >> Performance of access in a fixed-size arr

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-17 Thread Tyler Retzlaff
On Thu, May 27, 2021 at 06:28:58PM +0300, Gregory Etelson wrote: > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h > index 4b728969c1..684bb028b2 100644 > --- a/lib/net/rte_ip.h > +++ b/lib/net/rte_ip.h > @@ -38,7 +38,21 @@ extern "C" { > * IPv4 Header > */ > struct rte_ipv4_hdr { > - uin

[dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine description V4: add new soc_centriq24

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-17 Thread Morten Brørup
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Thursday, 17 June 2021 16.59 > > > >>> > > >>> 14/06/2021 15:15, Bruce Richardson: > > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thoma

Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf

2021-06-17 Thread Andrew Rybchenko
On 6/15/21 4:34 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > Kunpeng 930 support Tx push mode which could improve performance, It > works like below: > 1. Add PCIe bar45 which support driver direct write the Tx descriptor > or tail reg to it. > 2. Support three operations: a) direct write

Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test

2021-06-17 Thread Tyler Retzlaff
On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > Since C11 memory model is adopted in DPDK now[1], use GCC's > atomic builtins in test cases. as previously discussed these atomics are not "C11" they are direct use of gcc builtins. please don't incorporate C11 into the title of the pa

[dpdk-dev] [PATCH v4 0/7] vhost: Fix and improve NUMA reallocation

2021-06-17 Thread Maxime Coquelin
This patch series first fixes missing reallocations of some Virtqueue and device metadata. Then, it improves the numa_realloc function by using rte_realloc_socket API that takes care of the memcpy & freeing. The VQs NUMA IDs are also saved in the VQ metadata and used for every allocations so that

[dpdk-dev] [PATCH v4 1/7] vhost: fix missing memory table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the Vhost memory table was missing, which likely causes iat least one cross-NUMA accesses for ev

[dpdk-dev] [PATCH v4 2/7] vhost: fix missing guest pages table NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the guest pages table was missing, which likely causes at least one cross-NUMA accesses for ever

[dpdk-dev] [PATCH v4 3/7] vhost: fix missing cache logging NUMA realloc

2021-06-17 Thread Maxime Coquelin
When the guest allocates virtqueues on a different NUMA node than the one the Vhost metadata are allocated, both the Vhost device struct and the virtqueues struct are reallocated. However, reallocating the log cache on the new NUMA node was not done. This patch fixes this by reallocating it if it

[dpdk-dev] [PATCH v4 4/7] vhost: fix NUMA reallocation with multiqueue

2021-06-17 Thread Maxime Coquelin
Since the Vhost-user device initialization has been reworked, enabling the application to start using the device as soon as the first queue pair is ready, NUMA reallocation no more happened on queue pairs other than the first one since numa_realloc() was returning early if the device was running.

  1   2   >