[dpdk-dev] [PATCH v1] net/ice/base: clean code of finding GTPU dummy pkt

2021-04-26 Thread Yuying Zhang
Four gtpu tunnel types are used twice to find gtpu dummy packets (ipv4_gtpu_ipv4/ipv6, ipv6_gtpu_ipv4/ipv6). Clean redundant code. Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_switch.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/net/ice/ba

Re: [dpdk-dev] [PATCH 0/4] common/iavf: update virtchnl

2021-04-26 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Saturday, April 24, 2021 2:04 PM > To: Xing, Beilei > Cc: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 0/4] common/iavf: update virtchnl > > Couple code refine and bug fix > > Qi Zhang (4): > common/iavf: fix duplica

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location

2021-04-26 Thread Ferruh Yigit
On 4/25/2021 6:07 PM, Thomas Monjalon wrote: Dim 25 avr 2021, à 19:01, Gregory Etelson a écrit : Hello Thomas, Dim 25 avr 2021, à 17:57, Gregory Etelson a écrit : Tunnel offload API requires application to query PMD for specific flow items and actions. Application uses these PMD specific el

Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming

2021-04-26 Thread Matan Azrad
From: Thomas Monjalon > The function pthread_setname_np is non-portable, so it may be unavailable in > old glibc or other systems. > The function rte_thread_setname is workarounding portability issues. > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad Thanks!

Re: [dpdk-dev] [PATCH v4 1/2] net/ice: clean redundant macro definition of filters

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Monday, April 26, 2021 1:38 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue > > Cc: Yan, Zhirun ; Guo, Junfeng > ; Zhang, Yuying > Subject: [PATCH v4 1/2] net/ice: clean redundant macro definition of filters > > The input set has b

Re: [dpdk-dev] [PATCH v4 2/2] net/ice: refactor input set fields for switch filter

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Monday, April 26, 2021 1:38 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue > > Cc: Yan, Zhirun ; Guo, Junfeng > ; Zhang, Yuying > Subject: [PATCH v4 2/2] net/ice: refactor input set fields for switch filter > > Input set has been

[dpdk-dev] [PATCH] examples/l2fwd-crypto: support cipher multiple data-unit

2021-04-26 Thread Matan Azrad
Patch [1] added a new API to support multiple data-units in cipher operations. Add a support for this API: - Add a new command-line argument to provide the data-unit length. - Set the length in the cipher xform. - Validate device capabilities for this feature. - Pad the AES-XTS operation length to

Re: [dpdk-dev] [PATCH 0/4] common/iavf: update virtchnl

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Monday, April 26, 2021 3:47 PM > To: Zhang, Qi Z > Cc: Wang, Haiyue ; dev@dpdk.org > Subject: RE: [PATCH 0/4] common/iavf: update virtchnl > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Saturday, April 24, 2021

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/vhost: fix potential overflow in args process

2021-04-26 Thread David Marchand
On Mon, Apr 19, 2021 at 7:59 AM Cheng Jiang wrote: > > Add args length check to fix potential overflow issue. > > Coverity issue: 363741 > Fixes: 965b06f0358 ("examples/vhost: enhance getopt_long usage") > Cc: sta...@dpdk.org No need for Cc: stable since this issue only affects the current releas

Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming

2021-04-26 Thread fengchengwen
On 2021/4/22 1:59, Thomas Monjalon wrote: > The function pthread_setname_np is non-portable, > so it may be unavailable in old glibc or other systems. > The function rte_thread_setname is workarounding portability issues. > > Signed-off-by: Thomas Monjalon Reviewed-by: Chengwen Feng

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Monday, April 26, 2021 1:30 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > AVX2 and SSE don't have the offload path. > Not necessary doing any check. Or the scala

[dpdk-dev] [Bug 238] [tree-wide] enhance getopt_long usage

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=238 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|RESOLVED|CONFIRMED Res

Re: [dpdk-dev] [PATCH v1] net/ice/base: fix inner L4 offset for gptu dummy packet

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Monday, April 26, 2021 2:02 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Zhang, Yuying ; sta...@dpdk.org > Subject: [PATCH v1] net/ice/base: fix inner L4 offset for gptu dummy packet > > Fix inner L4 offset of ipv6_gtpu_ipv6_tcp/udp dummy

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Jerin Jacob
On Sat, Apr 24, 2021 at 5:56 AM Honnappa Nagarahalli wrote: > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > Performance of L3fwd example application is one > > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix nfp multiport syntax

2021-04-26 Thread Ferruh Yigit
On 4/23/2021 5:18 PM, Ferruh Yigit wrote: On 3/1/2021 1:45 PM, Ferruh Yigit wrote: On 2/25/2021 11:46 AM, Heinrich Kuhn wrote: From: "Chaoyong.He" 1. Fixup the suffix of the PCI ID to be consistent with the code. 2. Add specification of using MAC address to identify port. Fixes: 979f2bae0 ("

Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information

2021-04-26 Thread Kinsella, Ray
On 25/04/2021 17:42, Thomas Monjalon wrote: > Kinsella, Ray: >> On 16/04/2021 10:57, Thomas Monjalon wrote: >>> 16/04/2021 11:41, Ferruh Yigit: On 4/16/2021 9:58 AM, Thomas Monjalon wrote: > 16/04/2021 10:46, Lijun Ou: >> Currently, upper-layer application could get queue state only

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix nfp multiport syntax

2021-04-26 Thread Ferruh Yigit
On 4/26/2021 10:46 AM, Ferruh Yigit wrote: On 4/23/2021 5:18 PM, Ferruh Yigit wrote: On 3/1/2021 1:45 PM, Ferruh Yigit wrote: On 2/25/2021 11:46 AM, Heinrich Kuhn wrote: From: "Chaoyong.He" 1. Fixup the suffix of the PCI ID to be consistent with the code. 2. Add specification of using MAC ad

[dpdk-dev] [PATCH v2 01/12] raw/ioat: add unit tests for completion batching

2021-04-26 Thread Bruce Richardson
Add in additional unit tests to verify that we can get completion reports of multiple batches in a single completed_ops() call. Also verify we can get smaller number of completions if that is requested too. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/ioat_rawdev_test.c | 199 +++

[dpdk-dev] [PATCH v2 00/12] ioat driver updates

2021-04-26 Thread Bruce Richardson
This set contains a series of updates to the ioat driver, described in each of the individual patchsets. Bruce Richardson (10): raw/ioat: add unit tests for completion batching raw/ioat: support limiting queues for idxd PCI device raw/ioat: add component prefix to log messages raw/ioat: ad

[dpdk-dev] [PATCH v2 03/12] raw/ioat: add component prefix to log messages

2021-04-26 Thread Bruce Richardson
Add the driver prefix "IOAT" to log messages for the driver. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/ioat_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ioat/ioat_private.h b/drivers/raw/ioat/ioat_private.h index 6c423811ec..f032d5fe3d 1006

[dpdk-dev] [PATCH v2 02/12] raw/ioat: support limiting queues for idxd PCI device

2021-04-26 Thread Bruce Richardson
When using a full device instance via vfio, allow the user to specify a maximum number of queues to configure rather than always using the max number of supported queues. Signed-off-by: Bruce Richardson --- doc/guides/rawdevs/ioat.rst | 8 drivers/raw/ioat/idxd_pci.c | 28 +

[dpdk-dev] [PATCH v2 04/12] raw/ioat: add explicit padding to descriptor struct

2021-04-26 Thread Bruce Richardson
Add an explicit padding field to the end of the descriptor structure so that when the batch descriptor is defined on the stack for perform-ops, the unused space is all zeroed appropriately. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/rte_ioat_rawdev_fns.h | 5 - 1 file changed, 4 in

[dpdk-dev] [PATCH v2 05/12] raw/ioat: fix script for configuring small number of queues

2021-04-26 Thread Bruce Richardson
The dpdk_idxd_cfg.py script included with the driver for convenience did not work properly where the number of queues to be configured was less than the number of groups or engines. This was because there would be configured groups/engines not assigned to queues. Fix this by limiting the engine and

[dpdk-dev] [PATCH v2 06/12] raw/ioat: make workqueue name configurable in script

2021-04-26 Thread Bruce Richardson
Add a "--name-prefix" parameter to the quick configuration script for DSA. This allows the queues configured on a DSA instance to be made available to only one DPDK process in a setup with multiple DPDK process instances. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/dpdk_idxd_cfg.py | 9

[dpdk-dev] [PATCH v2 07/12] raw/ioat: allow perform operations function to return error

2021-04-26 Thread Bruce Richardson
From: Kevin Laatz Change the return type for the rte_ioat_perform_ops() function from void to int to allow the possibility of returning an error code in future, should it be necessary. Signed-off-by: Kevin Laatz --- drivers/raw/ioat/rte_ioat_rawdev.h | 4 +++- drivers/raw/ioat/rte_ioat_ra

[dpdk-dev] [PATCH v2 08/12] raw/ioat: add bus driver for device scanning automatically

2021-04-26 Thread Bruce Richardson
Rather than using a vdev with args, DPDK can scan and initialize the devices automatically using a bus-type driver. This bus does not need to worry about registering device drivers, rather it can initialize the devices directly on probe. The device instances (queues) to use are detected from /dev

[dpdk-dev] [PATCH v2 09/12] raw/ioat: move idxd functions to separate file

2021-04-26 Thread Bruce Richardson
Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the data structures for the original ioat devices and the newer idxd ones can be kept separate from each other. This makes code management and rework easier. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/meson.build

[dpdk-dev] [PATCH v2 10/12] raw/ioat: rework SW ring layout

2021-04-26 Thread Bruce Richardson
The ring management in the idxd part of the driver is more complex than it needs to be, tracking individual batches in a ring and having null descriptors as padding to avoid having single-operation batches. This can be simplified by using a regular ring-based layout, with additional overflow at the

[dpdk-dev] [PATCH v2 11/12] raw/ioat: add API to query remaining ring space

2021-04-26 Thread Bruce Richardson
From: Kevin Laatz Add a new API to query remaining descriptor ring capacity. This API is useful, for example, when an application needs to enqueue a fragmented packet and wants to ensure that all segments of the packet will be enqueued together. Signed-off-by: Kevin Laatz Signed-off-by: Bruce R

[dpdk-dev] [PATCH v2 12/12] raw/ioat: report status of completed jobs

2021-04-26 Thread Bruce Richardson
Add improved error handling to rte_ioat_completed_ops(). This patch adds new parameters to the function to enable the user to track the completion status of each individual operation in a batch. With this addition, the function can help the user to determine firstly, how many operations may have fa

[dpdk-dev] [PATCH v3] build: fix symlink of drivers for Windows

2021-04-26 Thread Nick Connolly
The symlink-drivers-solibs.sh script was disabled as part of 'install' for Windows because there is no support for shell scripts. However, this means that driver related DLLs are not present in the installed 'libdir' directory. Add a python script to perform the install and use it for Windows if th

[dpdk-dev] [PATCH 2/2] net/bnxt: fix Rx FIFO pending bit

2021-04-26 Thread Somnath Kotur
Fix to clear the Rx FIFO while reading the timestamp. If the Rx FIFO has pending bit set, keep reading to clear it and return the last valid timestamp instead of unconditionally returning an error. Fixes: b11cceb83a34 ("net/bnxt: support timesync") Cc: sta...@dpdk.org Signed-off-by: Somnath Kotur

[dpdk-dev] [PATCH 1/2] net/bnxt: refactor multi queue Rx configuration

2021-04-26 Thread Somnath Kotur
Eliminate separate codepath/handling for single queue as the multiqueue code path takes care of it as well. The only difference being the end_grp_id being 1 now instead of 0 for single queue, but that does not matter for single queue and does not alter any functionality. Fixes: 6133f207970c ("net/

Re: [dpdk-dev] [PATCH v1 2/2] event/octeontx2: configure crypto adapter xaq pool

2021-04-26 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Shijith Thotton >Sent: Friday, April 16, 2021 12:40 AM >To: dev@dpdk.org >Cc: Shijith Thotton ; Jerin Jacob Kollanukkaran >; Akhil Goyal ; Anoob >Joseph ; Ankur Dwivedi >; Pavan Nikhilesh Bhagavatula > >Subject: [PATCH v1 2/2] event/octeontx2: configure crypto

Re: [dpdk-dev] [PATCH] net/kni: check rte kni init result

2021-04-26 Thread Ferruh Yigit
On 4/23/2021 11:17 AM, Ferruh Yigit wrote: On 4/21/2021 3:14 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch adds checking for rte_kni_init() result. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Ack

Re: [dpdk-dev] [PATCH] net/txgbe: fix memset type error

2021-04-26 Thread Ferruh Yigit
On 4/21/2021 4:36 AM, Min Hu (Connor) wrote: From: HongBo Zheng Fix memset type error in function txgbe_parse_rss_filter while clear rss_conf buffer. Fixes: 7a6d87fb8398 ("net/txgbe: parse RSS filter") Cc: sta...@dpdk.org Signed-off-by: HongBo Zheng Signed-off-by: Min Hu (Connor) Reviewed

Re: [dpdk-dev] [PATCH] net/txgbe: fix param misusage when set rte flow error

2021-04-26 Thread Ferruh Yigit
On 4/21/2021 7:31 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch fixes parameter misusage when set rte flow action error. Fixes: b7eeecb17556 ("net/txgbe: parse n-tuple filter") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh

[dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-04-26 Thread Bruce Richardson
This is a script to fix up minor formatting issues in meson files. It scans for, and can optionally fix, indentation issues and missing trailing commas in the lists in meson.build files. It also detects, and can fix, multi-line lists where more than one entry appears on a line. Signed-off-by: Bruc

[dpdk-dev] [PATCH v2 2/2] build: style fixup on meson files

2021-04-26 Thread Bruce Richardson
Running "./devtools/dpdk_meson_check.py --fix" on the DPDK repo fixes a number of issues with whitespace and formatting of files: * indentation of lists * missing trailing commas on final list element * multiple list entries per line when list is not all single-line Signed-off-by: Bruce Richardso

Re: [dpdk-dev] [PATCH 4/4] examples/l3fwd: make data struct to be memory efficient

2021-04-26 Thread Walsh, Conor
> >> There are some holes in data struct lcore_conf. The holes are > >> due to alignment requirement. > >> > >> For struct lcore_rx_queue, there is no need to make every element > >> of this type to be cache line aligned, because the data is not > >> shared between cores. > >> > >> Member len of s

Re: [dpdk-dev] [PATCH] drivers: fix indentation in build files

2021-04-26 Thread Bruce Richardson
On Thu, Apr 22, 2021 at 11:20:19AM +0200, Thomas Monjalon wrote: > 22/04/2021 10:39, Bruce Richardson: > > On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote: > > > A couple of mistakes slipped in the mass change. > > > > > > More mistakes could happen, especially when rebasing pendin

Re: [dpdk-dev] [PATCH] app/testpmd: fix division by zero bug

2021-04-26 Thread Ferruh Yigit
On 4/21/2021 12:38 PM, Min Hu (Connor) wrote: Variable total, which may be zero and result in segmentation fault. This patch fixed it. Fixes: 9b1249d9ff69 ("app/testpmd: support dumping socket memory") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 3 +++ 1

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix segment number check

2021-04-26 Thread Li, Xiaoyun
Hi > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, April 24, 2021 00:10 > To: Viacheslav Ovsiienko ; Li, Xiaoyun > ; Wei Hu (Xavier) ; > Chengchang Tang > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org; > Andrew Boyer > Subject: [PATCH v2] app/testpmd: fix segment number

[dpdk-dev] [Bug 689] RTE bus list not populated causing EAL: failed to parse device "XX:XX.X" on CentOS 7

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=689 Bug ID: 689 Summary: RTE bus list not populated causing EAL: failed to parse device "XX:XX.X" on CentOS 7 Product: DPDK Version: 20.11 Hardware: x86 OS: Linux

[dpdk-dev] [PATCH v2] app/testpmd: fix division by zero bug

2021-04-26 Thread Min Hu (Connor)
Variable total, which may be zero and result in segmentation fault. This patch fixed it. Fixes: 9b1249d9ff69 ("app/testpmd: support dumping socket memory") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH] app/testpmd: fix division by zero bug

2021-04-26 Thread Min Hu (Connor)
在 2021/4/21 19:38, Min Hu (Connor) 写道: Variable total, which may be zero and result in segmentation fault. This patch fixed it. Fixes: 9b1249d9ff69 ("app/testpmd: support dumping socket memory") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 3 +++ 1 fil

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net: fix FW version get

2021-04-26 Thread Ferruh Yigit
On 4/23/2021 3:19 AM, Jiawen Wu wrote: > On April 22, 2021 12:21 AM, Ferruh Yigit wrote: >> Fixes a few different things: >> * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is >> zero, 'fw_version' being NULL but 'fw_size' not zero condition checked >> in ethdev layer >> * Be

[dpdk-dev] [PATCH v2 0/2] event/octeontx2: fixes for crypto adapter

2021-04-26 Thread Shijith Thotton
Fixes for OCTEON TX2 crypto adapter implementation. v2: - Fixed adapter xae count updation. Shijith Thotton (2): event/octeontx2: fix crypto adapter queue pair ops event/octeontx2: configure crypto adapter xaq pool drivers/crypto/octeontx2/otx2_cryptodev_qp.h | 4 +- drivers/event/octeon

[dpdk-dev] [PATCH v2 1/2] event/octeontx2: fix crypto adapter queue pair ops

2021-04-26 Thread Shijith Thotton
Parameter queue_pair_id of crypto adapter queue pair add/del operation can be -1 to select all pre configured crypto queue pairs. Added support for the same in driver. Also added a member in cpt qp structure to indicate binding state of a queue pair to an event queue. Fixes: 29768f78d5a7 ("event/o

[dpdk-dev] [PATCH v2 2/2] event/octeontx2: configure crypto adapter xaq pool

2021-04-26 Thread Shijith Thotton
Configure xaq pool based on number of in-use crypto queues to avoid CPT add work failure due to xaq buffer run out. This patch configures OTX2_CPT_DEFAULT_CMD_QLEN number of xae entries per queue pair. Fixes: 29768f78d5a7 ("event/octeontx2: add crypto adapter framework") Signed-off-by: Shijith Th

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > The link fails code should be parsed using the structure > hns3_mbx_vf_to_pf_cmd, else it will parse fail. > > Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") > Cc: sta...@dpdk.org > > Signed-off-by:

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

2021-04-26 Thread fengchengwen
On 2021/4/26 20:26, Ferruh Yigit wrote: > On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> The link fails code should be parsed using the structure >> hns3_mbx_vf_to_pf_cmd, else it will parse fail. >> >> Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mai

[dpdk-dev] [PATCH 0/5] net/mlx5: add indirect count action

2021-04-26 Thread Michael Baum
Add support of indirect action API for count action. Michael Baum (5): net/mlx5: support flow count action handle app/testpmd: remove indirect RSS action query app/testpmd: support indirect counter action query net/mlx5: fix flow age event triggering net/mlx5: use aging by counter when c

[dpdk-dev] [PATCH 1/5] net/mlx5: support flow count action handle

2021-04-26 Thread Michael Baum
Existing API supports counter action to count traffic of a single flow. The user can share the count action among different flows using the shared flag and the same counter ID in the count action configuration. Recent patch [1] introduced the indirect action API. Using this API, an action can be c

[dpdk-dev] [PATCH 2/5] app/testpmd: remove indirect RSS action query

2021-04-26 Thread Michael Baum
The port_action_handle_query function supports query operation for indirect RSS action. No driver currently supports this operation, and this support is unnecessary. Remove it. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- app/test-pmd/config.c | 7 --- 1 file changed, 7 deletions

[dpdk-dev] [PATCH 3/5] app/testpmd: support indirect counter action query

2021-04-26 Thread Michael Baum
Counter action query was implemented as part of flow query, but was not implemented as part of indirect action query. This patch adds the required implementation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- app/test-pmd/config.c | 145 +++--

[dpdk-dev] [PATCH 5/5] net/mlx5: use aging by counter when counter is existed

2021-04-26 Thread Michael Baum
The driver support 2 mechanisms in order to support AGE action: 1. Aging by counter - HW counter will be configured to the flow traffic, the driver polls the counter values efficiently to detect flow timeout. 2. Aging by ASO flow hit bit - HW ASO flow-hit bit is allocated for the flow, the driver p

[dpdk-dev] [PATCH 4/5] net/mlx5: fix flow age event triggering

2021-04-26 Thread Michael Baum
A FLOW_AGE event should be invoked when a new aged-out flow is detected by the PMD after the last user get-aged query calling. The PMD manages 2 flags for this information and check them in order to decide if an event should be invoked: MLX5_AGE_EVENT_NEW - a new aged-out flow was detected. after t

[dpdk-dev] [PATCH v2] net/mlx5: workaround ASO memory region creation

2021-04-26 Thread Michael Baum
Due to kernel issue in direct MKEY creation using the DevX API for physical memory, this patch replaces the ASO MR creation to use Verbs API. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- v2: The sec

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

2021-04-26 Thread Ferruh Yigit
On 4/26/2021 1:41 PM, fengchengwen wrote: > > > On 2021/4/26 20:26, Ferruh Yigit wrote: >> On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: >>> From: Chengwen Feng >>> >>> The link fails code should be parsed using the structure >>> hns3_mbx_vf_to_pf_cmd, else it will parse fail. >>> >>> Fixes: 109e

[dpdk-dev] [PATCH v2] log: register with standardized names

2021-04-26 Thread David Marchand
Let's try to enforce the convention where drivers use a pmd. logtype with their class reflected in it and libraries use a lib. logtype. Introduce two new macros: - RTE_LOG_REGISTER_DEFAULT can be used when a single logtype is used in a component. It is associated to the default name provided b

Re: [dpdk-dev] [PATCH 0/4] bugfix for hns3 PMD

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: > This patchset contains four bugfixes for hns3 PMD. > > Chengwen Feng (4): > net/hns3: fix error mbx messages prompt errors > net/hns3: fix PF miss link status notify message > net/hns3: fix parse link fails code fail > net/hns3: delete unused

Re: [dpdk-dev] [PATCH] usertools/devbind: add dlb

2021-04-26 Thread McDaniel, Timothy
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, April 25, 2021 10:53 AM > To: McDaniel, Timothy > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Van > Haaren, Harry ; Ray Kinsella ; > Neil Horman ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; pbhagavat...@mar

Re: [dpdk-dev] [PATCH] net/bonding: fix kvlist memory leakage

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 3:05 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > If the bond device was created by vdev mode, the kvlist was not free > when the bond device removed. > > Fixes: 8d30fe7fa737 ("bonding: support port hotplug") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-

Re: [dpdk-dev] [PATCH 2/3] net/kni: fix rewritten return value

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > Return value of function 'eth_kni_dev_stop' passed to 'ret' is > rewritten later, and this is unreasonable. > > This patch fixes it. > > Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") > Cc: sta...@dpdk.org > > Signed-of

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

2021-04-26 Thread fengchengwen
On 2021/4/26 20:50, Ferruh Yigit wrote: > On 4/26/2021 1:41 PM, fengchengwen wrote: >> >> >> On 2021/4/26 20:26, Ferruh Yigit wrote: >>> On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: From: Chengwen Feng The link fails code should be parsed using the structure hns3_mbx_vf_to_p

Re: [dpdk-dev] [PATCH 1/3] kni: fix wrong comments

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > This patch changed 'subsytem' to 'subsystem'. > > Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") > Cc: sta...@dpdk.org > > Signed-off-by: Min Hu (Connor) This is not on the "kni:", which implies the kni library, but the kni unit te

Re: [dpdk-dev] [PATCH 3/3] kni: fix unchecked return value

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > Return value 'rte_kni_init' of a function is not checked. If > it fails, error handling (logging and return) should be done. > > This patch fixed it. > > Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") > Cc: sta...@dpdk.org > > Signe

[dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Konstantin Ananyev
gcc 11 with '-O2' complains about some variables being used without being initialized: In file included from ../lib/librte_acl/acl_run_avx512x8.h:201, from ../lib/librte_acl/acl_run_avx512.c:110: In function ‘start_flow_avx512x8’, inlined from ‘search_trie_avx512x8.constprop’

Re: [dpdk-dev] [PATCH 0/3] bugfix for kni

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > This patchset contains three bugfixes for kni. > > Min Hu (Connor) (3): > kni: fix wrong comments > net/kni: fix rewritten return value > kni: fix unchecked return value > Except from 2/3, Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-04-26 Thread Burakov, Anatoly
On 26-Apr-21 11:54 AM, Bruce Richardson wrote: This is a script to fix up minor formatting issues in meson files. It scans for, and can optionally fix, indentation issues and missing trailing commas in the lists in meson.build files. It also detects, and can fix, multi-line lists where more than

[dpdk-dev] [PATCH v2] net/hns3: fix parse link fails code fail

2021-04-26 Thread Min Hu (Connor)
From: Chengwen Feng The link fails code should be parsed using the structure hns3_mbx_vf_to_pf_cmd, else it will parse fail. Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- v2: * kept o

[dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

2021-04-26 Thread Anatoly Burakov
When .get_monitor_addr API was introduced, it was implemented in the i40e driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device structure. The i40e driver is not meant to use the VF portion a

[dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

2021-04-26 Thread Anatoly Burakov
When .get_monitor_addr API was introduced, it was implemented in the ixgbe driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device structure. Fixes: 3982b7967bb7 ("net/ixgbe: implement power ma

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix nfp multiport syntax

2021-04-26 Thread Thomas Monjalon
Lun 26 avr 2021, à 11:48, Ferruh Yigit a écrit : > Hi Thomas, David, Akhil, Jerin, Maxime, Qi, Raslan, Ajit, > > For the doc patches, the subsystem prefix 'doc:' is too wide, what do you > think > to extend it to include the component, like for this patch: > "doc/nics/nfp: fix multiport syntax"

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-04-26 Thread Bruce Richardson
On Mon, Apr 26, 2021 at 02:40:25PM +0100, Burakov, Anatoly wrote: > On 26-Apr-21 11:54 AM, Bruce Richardson wrote: > > This is a script to fix up minor formatting issues in meson files. > > It scans for, and can optionally fix, indentation issues and missing > > trailing commas in the lists in meso

Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

2021-04-26 Thread David Hunt
Hi Anatoly, On 26/4/2021 2:49 PM, Anatoly Burakov wrote: When .get_monitor_addr API was introduced, it was implemented in the ixgbe driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device str

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix max queue number when configure Tx offloads

2021-04-26 Thread Ferruh Yigit
On 4/25/2021 3:08 AM, Li, Xiaoyun wrote: > >> -Original Message- >> From: Min Hu (Connor) >> Sent: Thursday, April 22, 2021 15:04 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> >> Subject: [PATCH 2/2] app/testpmd: fix max queue number when configure Tx >> offloads >> >> From:

Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

2021-04-26 Thread David Hunt
Hi Anatoly, On 26/4/2021 2:49 PM, Anatoly Burakov wrote: When .get_monitor_addr API was introduced, it was implemented in the i40e driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device stru

Re: [dpdk-dev] [PATCH v2 1/2] event/octeontx2: fix crypto adapter queue pair ops

2021-04-26 Thread Ankur Dwivedi
>-Original Message- >From: Shijith Thotton >Sent: Monday, April 26, 2021 5:51 PM >To: dev@dpdk.org >Cc: Shijith Thotton ; Jerin Jacob Kollanukkaran >; Anoob Joseph ; Ankur Dwivedi >; Pavan Nikhilesh Bhagavatula > >Subject: [PATCH v2 1/2] event/octeontx2: fix crypto adapter queue pair op

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-04-26 Thread Burakov, Anatoly
On 26-Apr-21 3:05 PM, Bruce Richardson wrote: On Mon, Apr 26, 2021 at 02:40:25PM +0100, Burakov, Anatoly wrote: On 26-Apr-21 11:54 AM, Bruce Richardson wrote: This is a script to fix up minor formatting issues in meson files. It scans for, and can optionally fix, indentation issues and missing

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 8:12 AM, Min Hu (Connor) wrote: > From: Chengchang Tang > > The socket ID entered by user is cast to an unsigned integer. However, > the value may be an illegal negative value, which may cause some > problems. In this case, an error should be returned. > +1 to fix > In addition, t

Re: [dpdk-dev] [PATCH] bonding: fix overflow check

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 10:22 AM, Min Hu (Connor) wrote: > Buffer 'test_params->slave_port_ids' of size 6 accessed may > overflow, since its index 'i' can have value be is out of range. > > This patch fixed it. > > Fixes: 92073ef961ee ("bond: unit tests") > Cc: sta...@dpdk.org > > Signed-off-by: Min Hu (Co

Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Ali Alnubani
> -Original Message- > From: dev On Behalf Of Konstantin Ananyev > Sent: Monday, April 26, 2021 4:35 PM > To: dev@dpdk.org > Cc: Konstantin Ananyev ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11 > Thanks Konstantin, I don't see the acl build failures with t

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix log loss when state fails to be restored

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 12:27 PM, Min Hu (Connor) wrote: > From: Chengchang Tang > > After restoring the remote states, the return value of ioctl() is not > checked. Therefore, users cannot know whether the remote state is > restored successfully. > > This patch add log for restoring failure. > > Fixes: 4

Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Kevin Traynor
On 26/04/2021 16:24, Ali Alnubani wrote: >> -Original Message- >> From: dev On Behalf Of Konstantin Ananyev >> Sent: Monday, April 26, 2021 4:35 PM >> To: dev@dpdk.org >> Cc: Konstantin Ananyev ; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11 >> > > Thanks Ko

Re: [dpdk-dev] [PATCH 2/2] net/tap: fix tap interrupt vector array size

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 12:27 PM, Min Hu (Connor) wrote: > From: Chengchang Tang > > The size of the current interrupt vector array is fixed to an integer. > > This patch will create an interrupt vector array based on the number > of rxqs. > > Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt") > Cc: st

[dpdk-dev] [PATCH v2 1/1] usertools/devbind: add dlb

2021-04-26 Thread Timothy McDaniel
Add dlb to usertools/dpdk-devbind.py so that it shows up as an eventdev, and is identified as Intel dlb. Signed-off-by: Timothy McDaniel --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py inde

[dpdk-dev] [Bug 690] tap build failures on Fedora 35 with gcc 11

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=690 Bug ID: 690 Summary: tap build failures on Fedora 35 with gcc 11 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 691] test-pmd build failure on Fedora 35 with gcc 11

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=691 Bug ID: 691 Summary: test-pmd build failure on Fedora 35 with gcc 11 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Monday, April 26, 2021 6:31 PM > To: Ali Alnubani ; Konstantin Ananyev > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11 > > On 26/04/2021 16:24, Ali Alnubani wrote: > >> -Original

Re: [dpdk-dev] [PATCH v2] eal/windows: fix build warnings in MinGW

2021-04-26 Thread Dmitry Kozlyuk
2021-04-21 19:09 (UTC+0300), Tal Shnaiderman: > the strncasecmp macro defined in rte_os_shim.h is already > defined in MinGW-w64, as a result the compiler prints out > the warning below on function redefinition whenever compiling > a file including the header in debug mode. > > ..\lib/librte_eal/w

[dpdk-dev] [Bug 692] bnx2x build fail on Fedora 34 with gcc 11

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=692 Bug ID: 692 Summary: bnx2x build fail on Fedora 34 with gcc 11 Product: DPDK Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 0/2] bugfix for hns3 PMD

2021-04-26 Thread Ferruh Yigit
On 4/23/2021 10:27 AM, Min Hu (Connor) wrote: > This patch set contains two bugfixes for hns3 PMD. > > Min Hu (Connor) (2): > net/hns3: fix wrong word of comments > doc: fix runtime config options > Series applied to dpdk-next-net/main, thanks.

[dpdk-dev] [RFC PATCH] test/distributor: fix burst flush on worker quit

2021-04-26 Thread Stanislaw Kardach
While working on RISC-V port I have encountered a situation where worker threads get stuck in the rte_distributor_return_pkt() function in the burst test. After investigation some of the threads enter this function with flag RTE_DISTRIB_GET_BUF set in the d->retptr64[0]. At the same time main threa

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

2021-04-26 Thread Dave Burley
Hi Hemant Can I ask what the usage case is for RTE_BBDEV_LDPC_ENC_NETWORK_ORDER/RTE_BBDEV_LDPC_DEC_NETWORK_ORDER ? Thanks Dave From: dev on behalf of Hemant Agrawal Sent: 24 April 2021 11:36 To: dev@dpdk.org ; gak...@marvell.com ; nicolas.chau...@intel.co

[dpdk-dev] [PATCH v2 00/33] Marvell CNXK Event device Driver

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' driver. In future, CN9K a.k.a octeontx2 will also be supported by same driver when code is ready and 'event/octeontx2' will be deprecated. v2 Changes: - Split Rx/Tx adapter into seperate patch set to

[dpdk-dev] [PATCH v2 01/33] event/cnxk: add build infra and device setup

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add meson build infra structure along with the event device SSO initialization and teardown functions. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- MAINTAINERS| 6 +++ doc/guides/eventdevs/cnxk.rst | 55 +

[dpdk-dev] [PATCH v2 02/33] event/cnxk: add device capabilities function

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add the info_get function to return details on the queues, flow, prioritization capabilities, etc. which this device has. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev.c | 24 drivers/event/cnx

[dpdk-dev] [PATCH v2 05/33] event/cnxk: add platform specific device config

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add platform specific event device configuration that attaches the requested number of SSO HWS(event ports) and HWGRP(event queues) LFs to the RVU PF/VF. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 35 ++

  1   2   >