Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-13 Thread Dmitry Kozlyuk
Hi Ranjit, 2021-04-12 21:46 (UTC-0700), Ranjit Menon: [...] > The change to remove the networking shim breaks l2fwd compilation on > Windows, since l2fwd/main.c includes netinet/in.h explicitly. > > How do you propose we fix this, only for Windows? This include is redundant for this file on all

Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-13 Thread Maxime Coquelin
Hi Cheng, On 4/12/21 1:34 PM, Cheng Jiang wrote: > In order to improve code efficiency and readability when async packed > ring support is enabled. This patch abstract some functions like > shadow_ring_store and write_back_completed_descs_split. And improve > the efficiency of some pointer offset

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-13 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Subject: Re: [PATCH v2 1/2] ethdev: add packet integrity checks > > On 4/12/2021 8:26 PM, Ori Kam wrote: > > Hi Ferruh, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Subject: Re: [PATCH v2 1/2] ethdev: add packet

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread David Marchand
On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon wrote: > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran: > > http://dpdk.org/git/next/dpdk-next-eventdev > > Pulled, thanks. > > Note few changes in titles like uppercases for acronyms, > or "add support" simplified as "support", > and release note

Re: [dpdk-dev] [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump feature

2021-04-13 Thread Haifei Luo
HI Slava, Yes for "we define 36/72 bytes array?". Correction for my last comment, not byte , and it is one "int" for port_id , 8 "int" for flowptr. Sorry for the possible confusion. -Original Message- From: Haifei Luo Sent: Tuesday, April 13, 2021 9:29 AM To: Slava Ovsii

Re: [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API

2021-04-13 Thread Thomas Monjalon
13/04/2021 03:22, Bing Zhao: > From: Ferruh Yigit > > > Bing Zhao (4): > > >ethdev: introduce indirect action APIs > > >app/test-pmd: change to indirect action command > > >doc: update user guide for indirect action > > >net/mlx5: adaption to indirect action API > > > > > > > Hi B

Re: [dpdk-dev] [PATCH v1] net/ice: update QinQ switch filter handling

2021-04-13 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, April 13, 2021 1:15 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhang, Yuying > ; Wang, Haiyue ; Yang, > Qiming > Subject: [PATCH v1] net/ice: update QinQ switch filter handling > > The hardware oueter/inner VLAN protocol types

Re: [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API

2021-04-13 Thread Bing Zhao
Thanks, I will squash the commits. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 13, 2021 3:24 PM > To: Ferruh Yigit ; Bing Zhao > > Cc: Ori Kam ; andrew.rybche...@oktetlabs.ru; Matan > Azrad ; Slava Ovsiienko ; > dev@dpdk.org; ajit.khapa...@broadcom.com; Gregory Et

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread Thomas Monjalon
13/04/2021 09:15, David Marchand: > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon wrote: > > > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran: > > > http://dpdk.org/git/next/dpdk-next-eventdev > > > > Pulled, thanks. > > > > Note few changes in titles like uppercases for acronyms, > > or "add

Re: [dpdk-dev] [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump feature

2021-04-13 Thread Slava Ovsiienko
> -Original Message- > From: Haifei Luo > Sent: Tuesday, April 13, 2021 9:29 AM > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Ori Kam ; Raslan Darawsheh ; > Xueming(Steven) Li ; Matan Azrad > ; Shahaf Shuler > Subject: RE: [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump > feature

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add new ext hdr for gtp psc

2021-04-13 Thread Raslan Darawsheh
Hi and sorry for late response, > -Original Message- > From: Olivier Matz > Sent: Thursday, April 8, 2021 5:11 PM > To: Raslan Darawsheh > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Ori Kam ; > andrew.rybche...@oktetlabs.ru; ivan.ma...@oktetlabs.ru; > ying.a.w...@intel.com; Slava Ovsiie

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add packet mode in meter profile structure

2021-04-13 Thread Ajit Khaparde
On Mon, Apr 12, 2021 at 12:29 PM Jerin Jacob wrote: > > On Tue, Apr 13, 2021 at 12:54 AM Dumitrescu, Cristian > wrote: > > > > > > > > > -Original Message- > > > From: Li Zhang > > > Sent: Saturday, April 10, 2021 8:25 AM > > > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.

Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service

2021-04-13 Thread Shijith Thotton
On Tue, Apr 13, 2021 at 04:08:40AM +, Gujjar, Abhinandan S wrote: > > > > -Original Message- > > From: Shijith Thotton > > Sent: Monday, April 12, 2021 2:24 PM > > To: dev@dpdk.org > > Cc: Shijith Thotton ; Gujjar, Abhinandan S > > ; Jerin Jacob ; Akhil > > Goyal ; Anoob Joseph > >

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item

2021-04-13 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > > On 4/11/2021 6:34 PM, Gregory Etelson wrote: > > From: Ori Kam > > > > The integrity item allows the application to match > > on the integrity of a packet. > > > > use example: > > match that packet integrity checks are ok. The ch

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 8:12 AM, Ori Kam wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] ethdev: add packet integrity checks On 4/12/2021 8:26 PM, Ori Kam wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] ethdev: a

[dpdk-dev] [PATCH v4 0/3] support flow for IP fragment in ICE

2021-04-13 Thread Jeff Guo
Support RSS hash and FDIR for IP fragment packets in ICE PMD. v4: correct typo when define fragment v3: rebase code and fix some parsing issues. v2: add some input check Jeff Guo (3): net/ice/base: support IP fragment RSS and FDIR net/ice: support RSS hash for IP fragment net/ice: support F

[dpdk-dev] [PATCH v4 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-13 Thread Jeff Guo
Add support for IP fragment RSS hash and FDIR according to packet ID. Separate IP fragment and IP other packet types. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/ice/base/ice_fdir.c | 50 +++-- drivers/net/ice/base/ice_fdir.h | 22 ---

[dpdk-dev] [PATCH v4 3/3] net/ice: support FDIR for IP fragment packet

2021-04-13 Thread Jeff Guo
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo Signed-off-by: Ting Xu --- drivers/net/ice/base/ice_fdir.c| 4 +- drivers/net/ice/ice_fdir_filter.c | 116 ++--- drivers/net/ice/ice_generic_flow.c | 1 + 3 files chang

[dpdk-dev] [PATCH v4 2/3] net/ice: support RSS hash for IP fragment

2021-04-13 Thread Jeff Guo
New pattern and RSS hash flow parsing are added to handle fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_generic_flow.c | 21 + drivers/net/ice/ice_generic_flow.h | 6 drivers/net/ice/ice_hash.c | 48 +- 3 files

[dpdk-dev] [v2] test/mempool: fix heap buffer overflow

2021-04-13 Thread Wenwu Ma
Amount of allocated memory was not enough for mempool which cause buffer overflow when access fields of mempool private structure in the rte_pktmbuf_priv_size function. Fixes: 923ceaeac140 ("test/mempool: add unit test cases") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v2: - refine commit l

[dpdk-dev] [v2] test/mempool: fix heap buffer overflow

2021-04-13 Thread Wenwu Ma
Amount of allocated memory was not enough for mempool which cause buffer overflow when access fields of mempool private structure in the rte_pktmbuf_priv_size function. Fixes: 923ceaeac140 ("test/mempool: add unit test cases") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v2: - refine commit l

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 8:53 AM, Ori Kam wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit On 4/11/2021 6:34 PM, Gregory Etelson wrote: From: Ori Kam The integrity item allows the application to match on the integrity of a packet. use example: match that packet integrity checks are ok.

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: update qfi definition

2021-04-13 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 6, 2021 7:10 PM > To: Raslan Darawsheh ; dev@dpdk.org; Ori Kam > ; andrew.rybche...@oktetlabs.ru > Cc: ivan.ma...@oktetlabs.ru; ying.a.w...@intel.com; > olivier.m...@6wind.com; Slava Ovsiienko ; Shiri > Kuzin ; sta...@dp

[dpdk-dev] [PATCH v4 0/4] support flow for IP fragment in IAVF

2021-04-13 Thread Jeff Guo
support flow for IP fragment in IAVF v4: add some part which should not be deleted v3: rebase code and fix some parsing issues v2: refine some input check Jeff Guo (4): app/testpmd: add packet id for IP fragment common/iavf: add proto header for IP fragment net/iavf: support RSS hash for IP

[dpdk-dev] [PATCH v4 2/4] common/iavf: add proto header for IP fragment

2021-04-13 Thread Jeff Guo
Add new virtchnl protocol header type and fields for IP fragment packets to support RSS hash and FDIR. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/common/iavf/virtchnl.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iav

[dpdk-dev] [PATCH v4 4/4] net/iavf: support FDIR for IP fragment packet

2021-04-13 Thread Jeff Guo
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_fdir.c | 386 ++- drivers/net/iavf/iavf_generic_flow.h | 5 + 2 files changed, 267 insertions(+), 124 deletions(-) di

[dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-13 Thread Jeff Guo
Add the new items to support the flow configuration for IP fragment packets. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- app/test-pmd/cmdline_flow.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdlin

[dpdk-dev] [PATCH v4 3/4] net/iavf: support RSS hash for IP fragment

2021-04-13 Thread Jeff Guo
New pattern and RSS hash flow parsing are added to handle fragmented IPv4/IPv6 packet. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_generic_flow.c | 24 drivers/net/iavf/iavf_generic_flow.h | 3 + drivers/net/iavf/iavf_hash.c | 83 +

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-13 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Subject: Re: [PATCH v2 1/2] ethdev: add packet integrity checks > > On 4/13/2021 8:12 AM, Ori Kam wrote: > > Hi Ferruh, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Subject: Re: [PATCH v2 1/2] ethdev: add packet

Re: [dpdk-dev] [PATCH 0/4] l3fwd improvements

2021-04-13 Thread Ruifeng Wang
Hello, This patch series targeted to improve L3fwd example. Performance gain was observed on N1SDP platform. It would be good if you can run this series on your platforms and see if there is any performance impact. Thanks, Ruifeng > -Original Message- > From: Ruifeng Wang > Sent: Thu

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 9:18 AM, Ori Kam wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] ethdev: add packet integrity checks On 4/13/2021 8:12 AM, Ori Kam wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] ethdev: a

Re: [dpdk-dev] [PATCH] eal/linux: add operation LOCK_NB to flock()

2021-04-13 Thread Tonghao Zhang
On Thu, Mar 25, 2021 at 4:25 PM wrote: > > From: Tonghao Zhang ping > The hugepage of different size, 2MB, 1GB may be mounted on > the same directory (e.g /dev/hugepages). Then dpdk > primary process will be blocked. To address this issue, > add the LOCK_NB flags to flock(). > > $ cat /proc/mount

Re: [dpdk-dev] [PATCH] net/hns3: support trace Rx/Tx burst function

2021-04-13 Thread Ferruh Yigit
On 4/9/2021 11:26 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch adds debug info for Rx/Tx burst function which was choosing. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v5 2/4] vhost: add support for packed ring in async vhost

2021-04-13 Thread Maxime Coquelin
On 4/12/21 1:34 PM, Cheng Jiang wrote: > For now async vhost data path only supports split ring structure. In > order to make async vhost compatible with virtio 1.1 spec this patch > enables packed ring in async vhost data path. > > Signed-off-by: Cheng Jiang > --- > lib/librte_vhost/rte_vhos

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: modify rte API for single flow dump

2021-04-13 Thread Ajit Khaparde
On Tue, Apr 6, 2021 at 11:09 PM Haifei Luo wrote: > > Previous implementations support dump all the flows. Add new arg > rte_flow in rte_flow_dev_dump to dump one flow. > > Signed-off-by: Haifei Luo > --- > app/test-pmd/config.c| 2 +- > doc/guides/nics/mlx5.rst | 9

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-13 Thread Andrew Rybchenko
On 4/13/21 6:22 AM, Min Hu (Connor) wrote: > This patch adds more sanity checks in control path APIs. > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and > variables") > Fixes: 0366137722a0 ("ethdev: check f

[dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check

2021-04-13 Thread Thomas Monjalon
The eventdev driver DLB was removed in DPDK 21.05, breaking the ABI check. The exception was agreed so we just need to skip this check. Note: complete removal of a driver cannot be ignored in devtools/libabigail.abignore, so the script must be patched. Fixes: 698fa829415d ("event/dlb: remove driv

Re: [dpdk-dev] [PATCH] net/virtio: fix vhost_kernel_set_owner for multi-queue devices

2021-04-13 Thread Maxime Coquelin
Hi Thierry, On 4/8/21 2:37 PM, Thierry Herbelot wrote: > Restore the original code, where VHOST_SET_OWNER is applied to > all vhostfds of the device. > > Fixes: 06856cabb89b0 ("net/virtio: add virtio-user ops to set owner") > Cc: Maxime Coquelin > Cc: Chenbo Xia > Signed-off-by: Thierry Herbelo

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-13 Thread Thomas Monjalon
I would like to Cc those who are interested in the auxiliary bus, but it's difficult to know who will implement it. Can we expect some reviews? 13/04/2021 05:23, Xueming Li: > Auxiliary [1] provides a way to split function into child-devices > representing sub-domains of functionality. Each auxil

Re: [dpdk-dev] [PATCH] examples/vhost: fix ioat ring space in callbacks

2021-04-13 Thread Maxime Coquelin
On 4/7/21 9:54 AM, Hu, Jiayu wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, April 7, 2021 3:48 PM >> To: Jiang, Cheng1 ; Xia, Chenbo >> ; Thomas Monjalon >> Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX >> ; Wang, Yinan ; >> sta...@dpdk.org >> S

Re: [dpdk-dev] [PATCH v7 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-13 Thread Shijith Thotton
On Tue, Apr 13, 2021 at 03:34:50AM +, Gujjar, Abhinandan S wrote: > > > > -Original Message- > > From: Shijith Thotton > > Sent: Monday, April 12, 2021 1:14 PM > > To: dev@dpdk.org > > Cc: Shijith Thotton ; tho...@monjalon.net; > > jer...@marvell.com; Gujjar, Abhinandan S ; > > heman

[dpdk-dev] [PATCH v4 0/3] support flow for IP fragment in ICE

2021-04-13 Thread Jeff Guo
Support RSS hash and FDIR for IP fragment packets in ICE PMD. v4: correct typo when define fragment v3: rebase code and fix some parsing issues. v2: add some input check Jeff Guo (3): net/ice/base: support IP fragment RSS and FDIR net/ice: support RSS hash for IP fragment net/ice: support F

[dpdk-dev] [PATCH v4 2/3] net/ice: support RSS hash for IP fragment

2021-04-13 Thread Jeff Guo
New pattern and RSS hash flow parsing are added to handle fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_generic_flow.c | 21 + drivers/net/ice/ice_generic_flow.h | 6 drivers/net/ice/ice_hash.c | 48 +- 3 files

[dpdk-dev] [PATCH v4 3/3] net/ice: support FDIR for IP fragment packet

2021-04-13 Thread Jeff Guo
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo Signed-off-by: Ting Xu --- drivers/net/ice/ice_fdir_filter.c | 116 ++--- drivers/net/ice/ice_generic_flow.c | 1 + 2 files changed, 106 insertions(+), 11 deletions(-) diff

[dpdk-dev] [PATCH v4 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-13 Thread Jeff Guo
Add support for IP fragment RSS hash and FDIR according to packet ID. Separate IP fragment and IP other packet types. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/ice/base/ice_fdir.c | 50 +++-- drivers/net/ice/base/ice_fdir.h | 22 ---

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread Jerin Jacob
On Tue, Apr 13, 2021 at 12:46 PM David Marchand wrote: > > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon wrote: > > > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran: > > > http://dpdk.org/git/next/dpdk-next-eventdev > > > > Pulled, thanks. > > > > Note few changes in titles like uppercases fo

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-13 Thread Thomas Monjalon
13/04/2021 10:44, Andrew Rybchenko: > On 4/13/21 6:22 AM, Min Hu (Connor) wrote: > > @@ -678,6 +684,9 @@ rte_eth_dev_owner_set(const uint16_t port_id, > > { > > int ret; > > > > + if (owner == NULL) > > + return -EINVAL; > > + > > Here and in many-many cases below I think the or

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread Thomas Monjalon
13/04/2021 10:54, Jerin Jacob: > On Tue, Apr 13, 2021 at 12:46 PM David Marchand > wrote: > > > > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon > > wrote: > > > > > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran: > > > > http://dpdk.org/git/next/dpdk-next-eventdev > > > > > > Pulled, thanks.

Re: [dpdk-dev] [PATCH v4 0/3] support flow for IP fragment in ICE

2021-04-13 Thread Xu, Ting
Best Regards, Xu Ting > -Original Message- > From: Guo, Jia > Sent: Tuesday, April 13, 2021 4:48 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Xu, Ting ; Guo, Jia > Subject: [PATCH v4 0/3] support flow for IP fragment in ICE > > Support RSS hash and FDIR for IP fragment

Re: [dpdk-dev] [PATCH] net/hns3: support trace Rx/Tx burst function

2021-04-13 Thread David Marchand
On Tue, Apr 13, 2021 at 10:37 AM Ferruh Yigit wrote: > > On 4/9/2021 11:26 AM, Min Hu (Connor) wrote: > > From: Chengwen Feng > > > > This patch adds debug info for Rx/Tx burst function which was choosing. > > > > Signed-off-by: Chengwen Feng > > Signed-off-by: Min Hu (Connor) > > Applied to dp

Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-13 Thread Jiang, Cheng1
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, April 13, 2021 3:12 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong > Subject: Re: [PATCH v5 1/4] vhost: abstract and reorganize async split ring >

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread David Marchand
On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob wrote: > I was running the following script[1] to detect ABI issues. > Since the "./devtools/test-meson-builds.sh" did not return non zero value or > the error print was "Error: cannot find librte_event_dlb.dump", It is > missed from my side. > > @David

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread Thomas Monjalon
13/04/2021 11:07, David Marchand: > On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob wrote: > > I was running the following script[1] to detect ABI issues. > > Since the "./devtools/test-meson-builds.sh" did not return non zero value or > > the error print was "Error: cannot find librte_event_dlb.dump

Re: [dpdk-dev] [PATCH] net/hns3: support trace Rx/Tx burst function

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 10:03 AM, David Marchand wrote: On Tue, Apr 13, 2021 at 10:37 AM Ferruh Yigit wrote: On 4/9/2021 11:26 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch adds debug info for Rx/Tx burst function which was choosing. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Co

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-13 Thread David Marchand
On Tue, Apr 13, 2021 at 11:07 AM David Marchand wrote: > > On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob wrote: > > I was running the following script[1] to detect ABI issues. > > Since the "./devtools/test-meson-builds.sh" did not return non zero value or > > the error print was "Error: cannot fi

Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check

2021-04-13 Thread David Marchand
On Tue, Apr 13, 2021 at 10:45 AM Thomas Monjalon wrote: > > The eventdev driver DLB was removed in DPDK 21.05, > breaking the ABI check. > The exception was agreed so we just need to skip this check. > > Note: complete removal of a driver cannot be ignored > in devtools/libabigail.abignore, so the

Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 9:58 AM, Thomas Monjalon wrote: 13/04/2021 10:44, Andrew Rybchenko: On 4/13/21 6:22 AM, Min Hu (Connor) wrote: @@ -678,6 +684,9 @@ rte_eth_dev_owner_set(const uint16_t port_id, { int ret; + if (owner == NULL) + return -EINVAL; + Here and in many-many c

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: update qfi definition

2021-04-13 Thread Ori Kam
Hi Raslan, > -Original Message- > From: Raslan Darawsheh > Subject: RE: [PATCH v4 2/2] ethdev: update qfi definition > > Hi, > > > -Original Message- > > From: Ferruh Yigit > > Sent: Tuesday, April 6, 2021 7:10 PM > > To: Raslan Darawsheh ; dev@dpdk.org; Ori Kam > > ; andrew.ry

Re: [dpdk-dev] [PATCH v2 0/7] Bugfix for hns3 PMD

2021-04-13 Thread Ferruh Yigit
On 4/10/2021 2:11 AM, Min Hu (Connor) wrote: This set of patches contains seven bugfixes for hns3 PMD. Chengchang Tang (3): net/hns3: fix incorrect timing in resetting queues net/hns3: fix queue state when concurrent with reset net/hns3: fix configure FEC when concurrent with reset Che

Re: [dpdk-dev] [PATCH v4 0/4] support flow for IP fragment in IAVF

2021-04-13 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Tuesday, April 13, 2021 4:10 PM > To: or...@nvidia.com; Zhang, Qi Z ; Xing, Beilei > ; Li, Xiaoyun ; Wu, Jingjing > > Cc: dev@dpdk.org; Xu, Ting ; Guo, Jia > Subject: [PATCH v4 0/4] support flow for IP fragment in IAVF > > support flow fo

Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check

2021-04-13 Thread Thomas Monjalon
13/04/2021 11:15, David Marchand: > On Tue, Apr 13, 2021 at 10:45 AM Thomas Monjalon wrote: > > > > The eventdev driver DLB was removed in DPDK 21.05, > > breaking the ABI check. > > The exception was agreed so we just need to skip this check. > > > > Note: complete removal of a driver cannot be i

Re: [dpdk-dev] [PATCH 3/4] vhost: avoid deadlock on async register

2021-04-13 Thread Maxime Coquelin
On 3/30/21 3:20 AM, Hu, Jiayu wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, March 29, 2021 11:19 PM >> To: Hu, Jiayu ; dev@dpdk.org >> Cc: Xia, Chenbo ; Wang, Yinan >> ; Jiang, Cheng1 ; Pai G, >> Sunil >> Subject: Re: [PATCH 3/4] vhost: avoid de

[dpdk-dev] [PATCH v5 2/3] net/ice: support RSS hash for IP fragment

2021-04-13 Thread Jeff Guo
New pattern and RSS hash flow parsing are added to handle fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_generic_flow.c | 21 ++ drivers/net/ice/ice_generic_flow.h | 6 drivers/net/ice/ice_hash.c | 46 -- 3 file

[dpdk-dev] [PATCH v5 0/3] support flow for IP fragment in ICE

2021-04-13 Thread Jeff Guo
Support RSS hash and FDIR for IP fragment packets in ICE PMD. v5: rebase code. v4: correct typo when define fragment v3: rebase code and fix some parsing issues. v2: add some input check Jeff Guo (3): net/ice/base: support IP fragment RSS and FDIR net/ice: support RSS hash for IP fragment n

[dpdk-dev] [PATCH v5 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-13 Thread Jeff Guo
Add support for IP fragment RSS hash and FDIR according to packet ID. Separate IP fragment and IP other packet types. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/ice/base/ice_fdir.c | 50 +++-- drivers/net/ice/base/ice_fdir.h | 22 ---

[dpdk-dev] [PATCH v5 3/3] net/ice: support FDIR for IP fragment packet

2021-04-13 Thread Jeff Guo
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo Signed-off-by: Ting Xu --- drivers/net/ice/ice_fdir_filter.c | 116 ++--- drivers/net/ice/ice_generic_flow.c | 1 + 2 files changed, 106 insertions(+), 11 deletions(-) diff

Re: [dpdk-dev] [PATCH v5 0/3] support flow for IP fragment in ICE

2021-04-13 Thread Xu, Ting
> -Original Message- > From: Guo, Jia > Sent: Tuesday, April 13, 2021 5:39 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Xu, Ting ; Guo, Jia > Subject: [PATCH v5 0/3] support flow for IP fragment in ICE > > Support RSS hash and FDIR for IP fragment packets in ICE PMD. > > v

Re: [dpdk-dev] [EXT] [PATCH] examples/l2fwd-crypto: remove key size validation

2021-04-13 Thread Akhil Goyal
> In the example application the key can be provided by the user or > generated randomly by the example application. > > Then a validation is done in order to check if the key size is > supported in the algorithm capabilities. > > As a result of patch [1] application should support the case where

Re: [dpdk-dev] [PATCH] examples/vhost: fix ioat ring space in callbacks

2021-04-13 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, April 13, 2021 4:51 PM > To: Hu, Jiayu ; Jiang, Cheng1 ; > Xia, Chenbo ; Thomas Monjalon > > Cc: dev@dpdk.org; Yang, YvonneX ; Wang, Yinan > ; sta...@dpdk.org > Subject: Re: [PATCH] examples/vhost: fix ioat ring space in c

Re: [dpdk-dev] [EXT] [PATCH v3] cryptodev: formalize key wrap method in API

2021-04-13 Thread Akhil Goyal
> The Key Wrap approach is used by applications in order to protect keys > located in untrusted storage or transmitted over untrusted > communications networks. The constructions are typically built from > standard primitives such as block ciphers and cryptographic hash > functions. > > The Key Wr

Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix indication of MAE encap. support

2021-04-13 Thread Ferruh Yigit
On 4/10/2021 1:51 AM, Ivan Malov wrote: The indication fields in the MCDI response are individual bits, but the current code mistakenly compares the larger dword with 1. This breaks encap. type discovery. Fix that. Fixes: 891408c45a63 ("common/sfc_efx/base: indicate MAE support for encapsulatio

Re: [dpdk-dev] [PATCH] drivers: add missing headers

2021-04-13 Thread Ferruh Yigit
On 3/26/2021 4:46 PM, Ferruh Yigit wrote: These headers are used but not included explicitly, including them. "arpa/inet.h" is included for 'htons' and friends. "netinet/in.h" is included for 'IPPROTO_IP'. Signed-off-by: Ferruh Yigit Any comment/review?

Re: [dpdk-dev] [EXT] [PATCH v3 0/8] baseband: add NXP LA12xx driver

2021-04-13 Thread Akhil Goyal
Hi Nicholas, Could you please review this series? Regards, Akhil > This series introduces the BBDEV LA12xx poll mode driver (PMD) to support > an implementation for offloading High Phy processing functions like > LDPC Encode / Decode 5GNR wireless acceleration function, using PCI based > LA12xx

[dpdk-dev] [PATCH v6 3/3] net/ice: support FDIR for IP fragment packet

2021-04-13 Thread Jeff Guo
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo Signed-off-by: Ting Xu Reviewed-by: Ting Xu --- drivers/net/ice/ice_fdir_filter.c | 118 ++--- drivers/net/ice/ice_generic_flow.c | 1 + 2 files changed, 107 insertions(+),

[dpdk-dev] [PATCH v6 0/3] support flow for IP fragment in ICE

2021-04-13 Thread Jeff Guo
Support RSS hash and FDIR for IP fragment packets in ICE PMD. v6: fix uninitialize issue v5: rebase code. v4: correct typo when define fragment v3: rebase code and fix some parsing issues. v2: add some input check Jeff Guo (3): net/ice/base: support IP fragment RSS and FDIR net/ice: support R

[dpdk-dev] [PATCH v6 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-13 Thread Jeff Guo
Add support for IP fragment RSS hash and FDIR according to packet ID. Separate IP fragment and IP other packet types. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/ice/base/ice_fdir.c | 50 +++-- drivers/net/ice/base/ice_fdir.h | 22 ---

[dpdk-dev] [PATCH v6 2/3] net/ice: support RSS hash for IP fragment

2021-04-13 Thread Jeff Guo
New pattern and RSS hash flow parsing are added to handle fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_generic_flow.c | 21 ++ drivers/net/ice/ice_generic_flow.h | 6 drivers/net/ice/ice_hash.c | 46 -- 3 file

Re: [dpdk-dev] [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API

2021-04-13 Thread Akhil Goyal
Hi Fan, > This patch changes the experimental raw data path dequeue burst API. > Originally the API enforces the user to provide callback function > to get maximum dequeue count. This change gives the user one more > option to pass directly the expected dequeue count. > > Signed-off-by: Fan Zhang

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-13 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 11:30 AM > > On 4/13/2021 9:18 AM, Ori Kam wrote: > > Hi Ferruh, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Subject: Re: [PATCH v2 1/2] ethdev: add packet integrity checks > >> > >> On 4/13/

Re: [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data path

2021-04-13 Thread Rong, Leyi
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, April 9, 2021 6:40 PM > To: Rong, Leyi ; Yigit, Ferruh ; > Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data > path > > > > > > > > > Fill up dev

Re: [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 4:50 AM, Li Zhang wrote: Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specifie

[dpdk-dev] [PATCH v8 0/3] Enhancements to crypto adapter forward mode

2021-04-13 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application changes are added in third patch. v8: - Added metadata NULL check and op free. - events object - > event obje

[dpdk-dev] [PATCH v8 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-13 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v8 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-13 Thread Shijith Thotton
Use rte_event_crypto_adapter_enqueue() API to enqueue events to crypto adapter if forward mode is supported in driver. Signed-off-by: Shijith Thotton Acked-by: Abhinandan Gujjar --- app/test/test_event_crypto_adapter.c | 33 ++-- 1 file changed, 21 insertions(+), 12 dele

[dpdk-dev] [PATCH v8 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-13 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton Acked-by: Abhinandan Gujjar --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 49 +++ drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/oct

Re: [dpdk-dev] [PATCH] drivers: add missing headers

2021-04-13 Thread Andrew Rybchenko
On 3/26/21 7:46 PM, Ferruh Yigit wrote: > These headers are used but not included explicitly, including them. > > "arpa/inet.h" is included for 'htons' and friends. > "netinet/in.h" is included for 'IPPROTO_IP'. > > Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v1] net/enic: fix completion pointer calculation

2021-04-13 Thread Ferruh Yigit
On 4/12/2021 9:50 PM, John Daley wrote: The completion queue index could be implicitly extended past its uint16_t size when multiplied by the size of the descriptor. While this should not be a problem, coverity flags it. Do the extension explicitly by casting the index to uintptr_t. Coverity iss

Re: [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data path

2021-04-13 Thread Ananyev, Konstantin
> > > > > > > > > Fill up dev->tx_pkt_prepare to i40e_pkt_prepare when on vector > > > > > > > and simple data path selection, as the sanity check is needed > > > > > > > ideally. > > > > > > > > > > > > > > Signed-off-by: Leyi Rong > > > > > > > --- > > > > > > > drivers/net/i40e/i40e_rxtx.c

Re: [dpdk-dev] [dpdk-stable] [PATCH] license: fix typo

2021-04-13 Thread Thomas Monjalon
> >> Fixes: a4862c9e1a98 ("license: introduce SPDX identifiers") > >> Cc: sta...@dpdk.org > >> > >> Signed-off-by: Ferruh Yigit > > Acked-by: Stephen Hemminger > Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter

2021-04-13 Thread Li Zhang
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 6:25 PM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler ; > cristian.dumitre...@intel.com; lir...@marvell.com; jer...@marvell.com > Cc: dev@dpdk.org; NBU-Co

Re: [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 12:02 PM, Li Zhang wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Tuesday, April 13, 2021 6:25 PM To: Li Zhang ; dek...@nvidia.com; Ori Kam ; Slava Ovsiienko ; Matan Azrad ; Shahaf Shuler ; cristian.dumitre...@intel.com; lir...@marvell.com; jer...@marvell.co

Re: [dpdk-dev] [PATCH v2 1/4] vhost: fix uninitialized vhost queue

2021-04-13 Thread Maxime Coquelin
On 4/2/21 3:03 PM, Jiayu Hu wrote: > This patch allocates vhost queue by rte_zmalloc() to avoid > undefined values. > > Fixes: a277c7159876 ("vhost: refactor code structure") > Cc: sta...@dpdk.org > > Signed-off-by: Jiayu Hu > --- > lib/librte_vhost/vhost.c | 2 +- > 1 file changed, 1 insert

Re: [dpdk-dev] [PATCH v2 3/4] vhost: avoid deadlock on async register

2021-04-13 Thread Maxime Coquelin
On 4/2/21 3:04 PM, Jiayu Hu wrote: > Users can register async copy device in vring_state_changed(), > when vhost queue is enabled. However, a deadlock occurs inside > rte_vhost_async_channel_register(), if VHOST_USER_F_PROTOCOL_FEATURES > is not supported, as vhost_user_msg_handler() takes vq->a

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item

2021-04-13 Thread Ori Kam
Hi > -Original Message- > From: Ferruh Yigit > item > > On 4/13/2021 8:53 AM, Ori Kam wrote: > > Hi Ferruh, > > > >> -Original Message- > >> From: Ferruh Yigit > >> > >> On 4/11/2021 6:34 PM, Gregory Etelson wrote: > >>> From: Ori Kam > >>> > >>> The integrity item allows the a

Re: [dpdk-dev] [PATCH] vhost: don't track remaining packets separately

2021-04-13 Thread Maxime Coquelin
Hi Balazs, Your patch does not apply, it needs to be rebased: http://patches.dpdk.org/project/dpdk/patch/5ef3d4c29927ed241c7128819fe35ac1d95d8f24.1617892982.git.bnem...@redhat.com/ Can you please send a rebased version. Thanks, Maxime On 4/8/21 4:44 PM, Balazs Nemeth wrote: > The remained varia

Re: [dpdk-dev] [PATCH v2 00/14] base code update batch 2

2021-04-13 Thread Ferruh Yigit
On 4/13/2021 7:16 AM, Yang, Qiming wrote: -Original Message- From: Zhang, Qi Z Sent: 2021年4月13日 13:06 To: Yang, Qiming Cc: dev@dpdk.org; Zhang, Qi Z Subject: [PATCH v2 00/14] base code update batch 2 v2: - Added patch 9/14 - 14/14. Qi Zhang (14): net/ice/base: code cleanup ne

Re: [dpdk-dev] [PATCH] net/hns3: support trace Rx/Tx burst function

2021-04-13 Thread Min Hu (Connor)
在 2021/4/13 17:13, Ferruh Yigit 写道: On 4/13/2021 10:03 AM, David Marchand wrote: On Tue, Apr 13, 2021 at 10:37 AM Ferruh Yigit wrote: On 4/9/2021 11:26 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch adds debug info for Rx/Tx burst function which was choosing. Signed-off-by:

Re: [dpdk-dev] [PATCH v3] vhost: read last used index once

2021-04-13 Thread Maxime Coquelin
On 4/7/21 11:55 AM, Balazs Nemeth wrote: > Instead of calculating the address of a packed descriptor based on the > vq->desc_packed and vq->last_used_idx every time, store that base > address in desc_base. On arm, this saves 176 bytes in code size of > function in which vhost_flush_enqueue_batch

Re: [dpdk-dev] [PATCH v5 2/4] vhost: add support for packed ring in async vhost

2021-04-13 Thread Jiang, Cheng1
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, April 13, 2021 4:37 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong > Subject: Re: [PATCH v5 2/4] vhost: add support for packed ring in async vhost

[dpdk-dev] [PATCH 00/12] Bugfix for hns3 PMD

2021-04-13 Thread Min Hu (Connor)
This set of patches contains 12 bugfixes for hns3 PMD. Chengchang Tang (2): net/hns3: fix potentially incorrect timing in MBX net/hns3: fix incorrect use of CMD status enumeration type Chengwen Feng (10): net/hns3: delete mailbox arq ring net/hns3: fix possible mismatches response of mail

  1   2   3   4   >