Re: [dpdk-dev] [PATCH] net/virtio: fix vhost_kernel_set_owner for multi-queue devices

[Maxime Coquelin]

Hi Thierry,

On 4/8/21 2:37 PM, Thierry Herbelot wrote:
> Restore the original code, where VHOST_SET_OWNER is applied to
> all vhostfds of the device.
> 
> Fixes: 06856cabb89b0 ("net/virtio: add virtio-user ops to set owner")
> Cc: Maxime Coquelin <maxime.coque...@redhat.com>
> Cc: Chenbo Xia <chenbo....@intel.com>
> Signed-off-by: Thierry Herbelot <thierry.herbe...@6wind.com>
> ---
>  drivers/net/virtio/virtio_user/vhost_kernel.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c 
> b/drivers/net/virtio/virtio_user/vhost_kernel.c
> index 768db55a6c1f..58e66bb7b4ae 100644
> --- a/drivers/net/virtio/virtio_user/vhost_kernel.c
> +++ b/drivers/net/virtio/virtio_user/vhost_kernel.c
> @@ -101,9 +101,20 @@ vhost_kernel_ioctl(int fd, uint64_t request, void *arg)
>  static int
>  vhost_kernel_set_owner(struct virtio_user_dev *dev)
>  {
> +     int ret;
> +     uint32_t i;
>       struct vhost_kernel_data *data = dev->backend_data;
>  
> -     return vhost_kernel_ioctl(data->vhostfds[0], VHOST_SET_OWNER, NULL);
> +     for (i = 0; i < dev->max_queue_pairs; ++i) {
> +             if (data->vhostfds[i] < 0)
> +                     continue;
> +
> +             ret = vhost_kernel_ioctl(data->vhostfds[i], VHOST_SET_OWNER, 
> NULL);
> +             if (ret < 0)
> +                     return ret;
> +     }
> +
> +     return 0;
>  }
>  
>  static int
> 

Thanks for the fix, we indeed have to set owner for all the queue pairs.

Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>

Thanks,
Maxime