Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-23 Thread Andrew Rybchenko
On 3/23/21 9:22 AM, Gabriel Ganne wrote: > Hi, > > Thanks for the review. > > I have some reservations about those TODO: they are about > rewriting the same functionality with a newer meson feature. > No functional change is expected. => Why not write a commit that > implements such a TODO and bu

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-23 Thread Andrew Rybchenko
On 3/23/21 6:17 AM, Li, Xiaoyun wrote: > Hi > >> -Original Message- >> From: Lijun Ou >> Sent: Friday, March 5, 2021 18:22 >> To: Yigit, Ferruh >> Cc: Li, Xiaoyun ; dev@dpdk.org; >> linux...@openeuler.org >> Subject: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd >> >> From: Hongbo Zhe

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-23 Thread Dmitry Kozlyuk
2021-03-23 07:22 (UTC+0100), Gabriel Ganne: > Hi, > > Thanks for the review. > > I have some reservations about those TODO: they are about > rewriting the same functionality with a newer meson feature. > No functional change is expected. => Why not write a commit that > implements such a TODO and

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-23 Thread Tu, Lijuan
> -Original Message- > From: Andrew Rybchenko > Sent: 2021年3月23日 15:25 > To: Li, Xiaoyun ; Lijun Ou ; Yigit, > Ferruh ; Tu, Lijuan > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd > > On 3/23/21 6:17 AM, Li, Xiaoyun w

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-03-23 Thread Li, Xiaoyun
Hi > -Original Message- > From: Lijun Ou > Sent: Friday, March 5, 2021 18:22 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; dev@dpdk.org; > linux...@openeuler.org > Subject: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx > and Tx > > From: Huisong Li > The commit message

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-23 Thread oulijun
在 2021/3/23 15:46, Tu, Lijuan 写道: -Original Message- From: Andrew Rybchenko Sent: 2021年3月23日 15:25 To: Li, Xiaoyun ; Lijun Ou ; Yigit, Ferruh ; Tu, Lijuan Cc: dev@dpdk.org; linux...@openeuler.org Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd On 3/23/21

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-23 Thread Li, Xiaoyun
> -Original Message- > From: oulijun > Sent: Tuesday, March 23, 2021 15:52 > To: Tu, Lijuan ; Andrew Rybchenko > ; Li, Xiaoyun ; Yigit, > Ferruh > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd > > > > 在 2021/3/23 1

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-23 Thread Tu, Lijuan
> -Original Message- > From: oulijun > Sent: 2021年3月23日 15:52 > To: Tu, Lijuan ; Andrew Rybchenko > ; Li, Xiaoyun ; Yigit, > Ferruh > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd > > > > 在 2021/3/23 15:46, Tu, Lij

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Akhil Goyal
Hi Konstantin, > Hi, > > Adding lookaside IPsec UDP encapsulation support > > for NAT traversal. > > Added --udp-encap option for application to specify > > if UDP encapsulation need to be enabled. > > Example secgw command with UDP encapsultation enabled: > > -c 0x1 -- -P -p 0x1 --config "(0,0,0)

Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer

2021-03-23 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Lijun Ou > Sent: Wednesday, March 10, 2021 9:36 AM > To: tho...@monjalon.net; ferruh.yi...@intel.com > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 > implementer > > Here ad

Re: [dpdk-dev] [RFC PATCH] log: track log level changes

2021-03-23 Thread David Marchand
Hello Lukasz, On Thu, Jul 9, 2020 at 2:16 AM Lukasz Wojciechowski wrote: > > > W dniu 26.06.2020 o 16:46, Andrew Rybchenko pisze: > > On 6/26/20 2:47 PM, David Marchand wrote: > >> Add a log message when changing log levels to be sure of which logtype > >> is enabled. > >> > > although I think th

[dpdk-dev] [PATCH v3] meson: update minimum required meson version

2021-03-23 Thread Gabriel Ganne
Bump meson required version to 0.49.2 which is chosen to be the same as in both redhat-8 and debian-10. Update documentation and travis setup script accordingly. This fixes the following warning: WARNING: Project targeting '>= 0.47.1' but tried to use feature introduced in '0.48.0': cons

Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option

2021-03-23 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, March 23, 2021 1:24 AM > To: Thomas Monjalon ; Zhang, Qi Z > ; Andrew Rybchenko > Cc: dev@dpdk.org; Wang, Xiao W ; Wu, Jingjing > ; Xing, Beilei ; Guo, Jia > ; Yang, Qiming ; Wang, Haiyue > ; Richardson, Bruce > Subject: Re: [

[dpdk-dev] [PATCH v3 1/4] event/octeontx2: simplify timer bucket estimation

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Simplify timer bucket estimation we need not align buckets to power of 2 instead use reciprocal division to compute mod. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 78 - drivers/event/octeontx2/otx2_tim_evdev.h | 84

[dpdk-dev] [PATCH v3 2/4] event/octeontx2: optimize timer arm routine

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Use relaxed load exclusive when polling for other threads or hardware to complete. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Fix incorrect asm register usage detected by clang. drivers/event/octeontx2/otx2_tim_worker.c | 1 + drivers/event/octeontx2/otx2_tim_w

[dpdk-dev] [PATCH v3 3/4] event/octeontx2: reduce chunk pool memory usage

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Reduce amount of memory used by chunk pool when the mempool used is OCTEONTX2 NPA. Previously, the number of chunks configured when NPA is used is equal to the number of timers requested plus the number of buckets and if the max timeout is long enough w.r.t. resolution reque

[dpdk-dev] [PATCH v3 4/4] event/octeontx2: timer always use virtual counter

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Use virtual counter for estimating current bucket as PMU cannot be reliably used to estimate time. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Use __rte_arm64_cntvct and __rte_arm64_cntfrq instead of reimplementing asm. drivers/event/octeontx2/otx2_tim_evdev.c

Re: [dpdk-dev] [PATCH v3 3/3] vhost: optimize vhost virtqueue struct

2021-03-23 Thread Maxime Coquelin
On 3/18/21 4:23 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, March 18, 2021 1:09 AM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; >> david.march...@redhat.com; olivier.m...@6wind.com; bnem...@redhat.com >> Cc: Maxime

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread Li, Xiaoyun
Hi > -Original Message- > From: Lijun Ou > Sent: Friday, March 5, 2021 18:22 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; dev@dpdk.org; > linux...@openeuler.org > Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test > > From: Huisong Li > The commit message is too l

[dpdk-dev] [PATCH v4 0/3] vhost: make virtqueue cache-friendly

2021-03-23 Thread Maxime Coquelin
As done for Virtio PMD, this series improves cache utilization of the vhost_virtqueue struct by removing unused field, make the live-migration cache dynamically allocated at live-migration setup time and by moving fields around so that hot fields are on the first cachelines. With this series, The

[dpdk-dev] [PATCH v4 1/3] vhost: remove unused Vhost virtqueue field

2021-03-23 Thread Maxime Coquelin
This patch removes the "backend" field of the vhost_virtqueue struct, which is not used by the library. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/vhost.c | 2 -- lib/librte_vhost/vhost.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/librte_vhost/vho

[dpdk-dev] [PATCH v4 2/3] vhost: move dirty logging cache out of the virtqueue

2021-03-23 Thread Maxime Coquelin
This patch moves the per-virtqueue's dirty logging cache out of the virtqueue struct, by allocating it dynamically only when live-migration is enabled. It saves 8 cachelines in vhost_virtqueue struct. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/vhost.c | 13

[dpdk-dev] [PATCH v4 3/3] vhost: optimize vhost virtqueue struct

2021-03-23 Thread Maxime Coquelin
This patch moves vhost_virtqueue struct fields in order to both optimize packing and move hot fields on the first cachelines. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 6 ++-- lib/librte_vhost/vhost.h | 54 ++- lib/librte_vhost/vhost

Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode

2021-03-23 Thread Kinsella, Ray
On 22/03/2021 23:32, Dmitry Kozlyuk wrote: > 2021-03-16 20:45 (UTC+0800), Xueming Li: > [...] >> diff --git a/lib/librte_eal/common/eal_common_bus.c >> b/lib/librte_eal/common/eal_common_bus.c >> index baa5b532af..ebbb3995f6 100644 >> --- a/lib/librte_eal/common/eal_common_bus.c >> +++ b/lib/li

Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode

2021-03-23 Thread Kinsella, Ray
On 23/03/2021 09:33, Kinsella, Ray wrote: > > > On 22/03/2021 23:32, Dmitry Kozlyuk wrote: >> 2021-03-16 20:45 (UTC+0800), Xueming Li: >> [...] [SNIP] >>> rte_mem_page_size; >> >> New function is private to EAL, so it doesn't need exporting. >> > > Right - it is annotated as INTERNAL. >

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-23 Thread Bruce Richardson
On Tue, Mar 23, 2021 at 07:22:00AM +0100, Gabriel Ganne wrote: >Hi, >Thanks for the review. >I have some reservations about those TODO: they are about >rewriting the same functionality with a newer meson feature. >No functional change is expected. => Why not write a commit that

Re: [dpdk-dev] [PATCH v3] meson: update minimum required meson version

2021-03-23 Thread Bruce Richardson
On Tue, Mar 23, 2021 at 09:36:18AM +0100, Gabriel Ganne wrote: > Bump meson required version to 0.49.2 which is chosen to be the same as > in both redhat-8 and debian-10. > > Update documentation and travis setup script accordingly. > > This fixes the following warning: > WARNING: Project targeti

[dpdk-dev] [PATCH v4] meson: update minimum required meson version

2021-03-23 Thread Gabriel Ganne
Bump meson required version to 0.49 which is chosen so as to be provided by both redhat-8 and debian-10. Update documentation and travis setup script accordingly. This fixes the following warning: WARNING: Project targeting '>= 0.47.1' but tried to use feature introduced in '0.48.0': con

Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode

2021-03-23 Thread Dmitry Kozlyuk
2021-03-23 09:34 (UTC+), Kinsella, Ray: > On 23/03/2021 09:33, Kinsella, Ray wrote: > > > > > > On 22/03/2021 23:32, Dmitry Kozlyuk wrote: > >> 2021-03-16 20:45 (UTC+0800), Xueming Li: > >> [...] > [SNIP] > >>> rte_mem_page_size; > >> > >> New function is private to EAL, so it doesn't

Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode

2021-03-23 Thread Kinsella, Ray
On 23/03/2021 09:57, Dmitry Kozlyuk wrote: > 2021-03-23 09:34 (UTC+), Kinsella, Ray: >> On 23/03/2021 09:33, Kinsella, Ray wrote: >>> >>> >>> On 22/03/2021 23:32, Dmitry Kozlyuk wrote: 2021-03-16 20:45 (UTC+0800), Xueming Li: [...] >> [SNIP] > rte_mem_page_size; >>

Re: [dpdk-dev] [PATCH v7 00/17] Alpine/musl build support

2021-03-23 Thread Thomas Monjalon
19/03/2021 15:57, Thomas Monjalon: > These patches fix some build errors/warning for Alpine Linux, > using musl and busybox. > Few improvements are added on the way. Applied with a small last minute change in a script as discussed. Alpine is now supported in DPDK. Next step: add a test in our CI.

Re: [dpdk-dev] [PATCH v4] meson: update minimum required meson version

2021-03-23 Thread Bruce Richardson
On Tue, Mar 23, 2021 at 10:52:19AM +0100, Gabriel Ganne wrote: > Bump meson required version to 0.49 which is chosen so as to be provided > by both redhat-8 and debian-10. > > Update documentation and travis setup script accordingly. > > This fixes the following warning: > WARNING: Project target

Re: [dpdk-dev] [PATCH v4] meson: update minimum required meson version

2021-03-23 Thread Andrew Rybchenko
On 3/23/21 1:11 PM, Bruce Richardson wrote: > On Tue, Mar 23, 2021 at 10:52:19AM +0100, Gabriel Ganne wrote: >> Bump meson required version to 0.49 which is chosen so as to be provided >> by both redhat-8 and debian-10. >> >> Update documentation and travis setup script accordingly. >> >> This fixe

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-23 Thread Ferruh Yigit
On 3/22/2021 6:53 PM, Ananyev, Konstantin wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, March 22, 2021 5:08 PM To: Ananyev, Konstantin ; Yigit, Ferruh ; Lijun Ou ; tho...@monjalon.net Cc: dev@dpdk.org; linux...@openeuler.org; Andrew Rybchenko ; David Marchand ; Ray

[dpdk-dev] [PATCH 0/3] Track log level changes

2021-03-23 Thread David Marchand
Here is a little series, following RFC [1]. No change in behavior expected, but reviews welcome ! :-) 1: https://patchwork.dpdk.org/project/dpdk/list/?series=10632 Changes since RFC: - added unit test, - logged level changes in rte_log_register, - fixed double evaluation of --log-level options,

[dpdk-dev] [PATCH 1/3] test/log: check levels

2021-03-23 Thread David Marchand
Add checks on log levels: - default values for rte_log_register and RTE_LOG_REGISTER, - level changes with rte_log_set_level and consorts Signed-off-by: David Marchand --- app/test/test_logs.c | 53 +--- 1 file changed, 50 insertions(+), 3 deletions(-) di

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 10:13 AM, Ferruh Yigit wrote: On 3/22/2021 6:53 PM, Ananyev, Konstantin wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, March 22, 2021 5:08 PM To: Ananyev, Konstantin ; Yigit, Ferruh ; Lijun Ou ; tho...@monjalon.net Cc: dev@dpdk.org; linux...@openeuler.o

[dpdk-dev] [PATCH 2/3] log: track log level changes

2021-03-23 Thread David Marchand
Add a log message when changing log levels. Example: $ DPDK_TEST=logs_autotest ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug ... RTE>>logs_autotest == dynamic log types EAL: logtype1 logtype level changed from disabled to info EAL: logtype2 logtype level changed from di

[dpdk-dev] [PATCH 3/3] eal: fix evaluation of log level option

2021-03-23 Thread David Marchand
--log-level option is handled early, no need to reevaluate it later in EAL init. Before: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level cha

Re: [dpdk-dev] How about add rte flow get capablity APIs

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 12:52 AM, Fengchengwen wrote: Hi, Ori and Ferruh   Currently, the rte flow APIs lack of get capability APIs, upper-application could not get the device capability unless look doc or code or even test it.   Maybe it's a good idea to add the get capability like traffic manager fr

Re: [dpdk-dev] [PATCH v4 0/3] vhost: make virtqueue cache-friendly

2021-03-23 Thread David Marchand
On Tue, Mar 23, 2021 at 10:02 AM Maxime Coquelin wrote: > > As done for Virtio PMD, this series improves cache utilization > of the vhost_virtqueue struct by removing unused field, > make the live-migration cache dynamically allocated at > live-migration setup time and by moving fields > around so

Re: [dpdk-dev] [PATCH v5 1/8] net/hns3: support runtime config to select IO burst func

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 3:31 AM, fengchengwen wrote: On 2021/3/22 21:58, Ferruh Yigit wrote: On 3/19/2021 1:07 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Mo

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 7:58 AM, Li, Xiaoyun wrote: -Original Message- From: oulijun Sent: Tuesday, March 23, 2021 15:52 To: Tu, Lijuan ; Andrew Rybchenko ; Li, Xiaoyun ; Yigit, Ferruh Cc: dev@dpdk.org; linux...@openeuler.org Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in test

[dpdk-dev] [PATCH v5 1/8] ether: refine debug build option

2021-03-23 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. The patch introduces below build options for data path debug, so PMD can choose to reuse them to av

[dpdk-dev] [PATCH v5 0/8] ether: refine debug build option

2021-03-23 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for data path debug in ether layer, PMD can choose to reu

[dpdk-dev] [PATCH v5 2/8] net/fm10k: refine debug build option

2021-03-23 Thread Qi Zhang
1. replace RTE_LIBRTE_FM10K_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_FM10K_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_FM10K_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/fm10k/fm10k_ethdev.c | 7 ++-

[dpdk-dev] [PATCH v5 3/8] net/e1000: refine debug build option

2021-03-23 Thread Qi Zhang
1. replace RTE_LIBRTE_E1000_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_E1000_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_E1000_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/e1000/e1000_logs.c | 17 --

[dpdk-dev] [PATCH v5 5/8] net/iavf: refine debug build option

2021-03-23 Thread Qi Zhang
1. replace RTE_LIBRTE_IAVF_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IAVF_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IAVF_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 7 ++- driv

[dpdk-dev] [PATCH v5 4/8] net/i40e: refine debug build option

2021-03-23 Thread Qi Zhang
1. replace RTE_LIBRTE_I40E_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_I40E_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_I40E_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 7 ++- driv

[dpdk-dev] [PATCH v5 6/8] net/ice: refine debug build option

2021-03-23 Thread Qi Zhang
1. replace RTE_LIBRTE_ICE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_ICE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ICE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 7 ++- drivers/n

[dpdk-dev] [PATCH v5 7/8] net/ixgbe: refine debug build option

2021-03-23 Thread Qi Zhang
1. replace RTE_LIBRTE_IXGBE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IXGBE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IXGBE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 7 +--- dr

[dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option

2021-03-23 Thread Qi Zhang
1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/igc/igc_logs.h | 4 ++-- drivers/net/igc/igc_txrx.c | 2 +- 2 files changed,

Re: [dpdk-dev] [PATCH] ethdev: add queue state when retrieve queue information

2021-03-23 Thread Ananyev, Konstantin
> > Note: The hairpin queue is not supported with above > rte_eth_*x_queue_info_get, so the queue state could be > RTE_ETH_QUEUE_STATE_STARTED or RTE_ETH_QUEUE_STATE_STOPPED. > Note: After add queue_state field, the 'struct rte_eth_rxq_info' size > >>

Re: [dpdk-dev] [PATCH v5 0/8] ether: refine debug build option

2021-03-23 Thread Zhang, Qi Z
Sorry, forgot adding change log v5: - Remove RTE_ETHDEV_DEBUG - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG_RX|TX for backward compatibility. v4: - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG in ethdev library for backward compatibility. - Not replace RTE_LIBRTE_ETHDEV_DEBUG in

Re: [dpdk-dev] [PATCH v4 1/8] eventdev: introduce event vector capability

2021-03-23 Thread Jerin Jacob
On Sat, Mar 20, 2021 at 2:27 AM wrote: > > From: Pavan Nikhilesh > > Introduce rte_event_vector datastructure which is capable of holding > multiple uintptr_t of the same flow thereby allowing applications > to vectorize their pipeline and reducing the complexity of pipelining > the events across

Re: [dpdk-dev] [PATCH v4 6/7] examples/vhost: enhance getopt_long usage

2021-03-23 Thread Maxime Coquelin
On 2/4/21 8:34 AM, Ibtisam Tariq wrote: > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and co

[dpdk-dev] [PATCH v6 8/8] net/hns3: support query Rx descriptor status

2021-03-23 Thread Min Hu (Connor)
From: Hongbo Zheng Add support for query Rx descriptor status in hns3 driver. Check the descriptor specified and provide the status information of the corresponding descriptor. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + doc/gu

[dpdk-dev] [PATCH v6 0/8] features and bugfixes for hns3

2021-03-23 Thread Min Hu (Connor)
This series add four features according to the 21.05 roadmap, and also two cleanups added. v6: * Adjust the styles of hns3.rst about runtime config options. v5: * Document hns3.rst about description of vec, common and simple. v4: * Rename variable name oq_glb_drop_cnt to oq_drop_cnt. v3: * Chan

[dpdk-dev] [PATCH v6 5/8] net/hns3: support imissed stats for PF/VF

2021-03-23 Thread Min Hu (Connor)
This patch added function level imissed stats for PF and VF. In kunpeng920, imissed is supported, only including RPU drop stats in PF. In kunpeng930, imissed is supported,including RPU drop stats and SSU drop stats in PF. Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.h | 13

[dpdk-dev] [PATCH v6 7/8] net/hns3: support query Tx descriptor status

2021-03-23 Thread Min Hu (Connor)
From: Hongbo Zheng Add support for query Tx descriptor status in hns3 driver. Check the descriptor specified and provide the status information of the corresponding descriptor. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + doc/gu

[dpdk-dev] [PATCH v6 2/8] net/hns3: support for outer UDP cksum

2021-03-23 Thread Min Hu (Connor)
From: Chengchang Tang Kunpeng930 support outer UDP cksum, this patch add support for it. Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- doc/guides/rel_notes/release_21_05.rst | 1 + drivers/net/hns3/hns3_cmd.c| 3 ++ drivers/net/hns3/hns3_ethdev.c | 3

[dpdk-dev] [PATCH v6 6/8] net/hns3: support oerrors stats in PF

2021-03-23 Thread Min Hu (Connor)
This patch added oerrors stats for PF in kunpeng930. Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/hns3/hns3_stats.c | 64 +- 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethd

[dpdk-dev] [PATCH v6 3/8] net/hns3: adjust the format of RAS related structures

2021-03-23 Thread Min Hu (Connor)
From: Hongbo Zheng Adjust the format of hns3 RAS related structures to resolve the static check warnings. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_intr.c | 2126 -- 1 file changed, 1224 insertions(+), 902 dele

[dpdk-dev] [PATCH v6 4/8] net/hns3: delete redundant xstats RAS statistics

2021-03-23 Thread Min Hu (Connor)
From: Hongbo Zheng The current RAS code stores the reported RAS statistics in xstats. This part of statistics is of little use in practice, and because of the change of RAS scheme on Kunpeng930, the driver can not obtain the RAS information any more, so this patch delete these redundant RAS stati

[dpdk-dev] [PATCH v6 1/8] net/hns3: support runtime config to select IO burst func

2021-03-23 Thread Min Hu (Connor)
From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate function based on offload configuration. Most applications such as l2fwd/l3fwd don't provide the means to change offload configuration, so it will use the auto selection's io b

Re: [dpdk-dev] [PATCH v5 1/8] net/hns3: support runtime config to select IO burst func

2021-03-23 Thread Min Hu (Connor)
在 2021/3/23 18:31, Ferruh Yigit 写道: On 3/23/2021 3:31 AM, fengchengwen wrote: On 2021/3/22 21:58, Ferruh Yigit wrote: On 3/19/2021 1:07 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, the driver support multiple IO burst function and auto selection of the most appropriate func

Re: [dpdk-dev] [PATCH v4 7/7] examples/vhost_crypto: enhance getopt_long usage

2021-03-23 Thread Maxime Coquelin
On 2/4/21 8:34 AM, Ibtisam Tariq wrote: > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and co

Re: [dpdk-dev] [PATCH v2] usertools: check 0-division with hugepage size

2021-03-23 Thread Burakov, Anatoly
On 21-Mar-21 9:09 AM, Thomas Monjalon wrote: The default page size can be None, and the page size from user request can be 0 kB if lower than 1024. In these cases, a division will fail. In order to avoid a Python exception, the page size is checked and an error message "Invalid page size" is prin

Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

2021-03-23 Thread David Marchand
On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readab

[dpdk-dev] [PATCH] ethdev: update qfi definition

2021-03-23 Thread Raslan Darawsheh
qfi field is 8 bits which represent single bit for PPP (paging Policy Presence) single bit for RQI (Reflective QoS Indicator) and 6 bits for qfi (QoS Flow Identifier) This update the doxygen format and the mask for qfi to properly identify the full 8 bits of the field. note: changing the default

Re: [dpdk-dev] [PATCH v6 0/8] features and bugfixes for hns3

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 11:20 AM, Min Hu (Connor) wrote: This series add four features according to the 21.05 roadmap, and also two cleanups added. v6: * Adjust the styles of hns3.rst about runtime config options. v5: * Document hns3.rst about description of vec, common and simple. v4: * Rename variable

[dpdk-dev] [PATCH v2 0/1] fix coredump when in secondary process

2021-03-23 Thread Guoyang Zhou
Some apps, such as fstack, will use secondary process to access the memory of eth_dev_ops, and they want to get the info of dev, but hinic driver does not initialized it when in secondary process. -- v1->v2: - modify the patch title v1: - fix coredump when PMD used by fstack Guoyang Zhou (1)

[dpdk-dev] [PATCH v2 1/1] net/hinic: fix coredump when in secondary process

2021-03-23 Thread Guoyang Zhou
Some apps, such as fstack, will use secondary process to access the memory of eth_dev_ops, and they want to get the info of dev, but hinic driver does not initialized it when in secondary process. Fixes: 66f64dd6dc86 ("net/hinic: fix secondary process") Cc: sta...@dpdk.org Signed-off-by: Guoyang Z

[dpdk-dev] [PATCH] net/mlx5: add Rx checksum offload flag return bad

2021-03-23 Thread Jiawei Zhu
From: Jiawei Zhu When open the rx checksum offload and receive the wrong checksum, add the ol_flags return bad. And it's not best to use multiplication and division here. Signed-off-by: Jiawei Zhu --- drivers/net/mlx5/mlx5_rxtx.c | 17 ++--- drivers/net/mlx5/mlx5_utils.h | 6

Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-23 Thread Nick Connolly
Threads is a dummy dependency for Clang. For MinGW without pthread it still adds -pthread switch (and it comes to libdpdk.pc), but executable doesn't require pthread library to run. I can imagine DPDK built by MinGW without pthread be linked via pkg-config to an app built by MinGW with pthread,

Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help

2021-03-23 Thread David Marchand
On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon wrote: > > The option --log-level was not completely described in the usage text, > and it was difficult to guess the names of the log types and levels. > > A new value "help" is accepted after --log-level to give more details > about the syntax and

[dpdk-dev] [PATCH 1/6] net/hns3: fix the reporting of undefined speed

2021-03-23 Thread Min Hu (Connor)
From: Huisong Li There may be a case in future that the speed obtained from firmware is undefined(such as, 400G or other rate), and link status of device is up. At this case, PMD driver will reports 100Mbps to the user in the "hns3_dev_link_update" API, which is unreasonable. Besides, if the spee

[dpdk-dev] [PATCH 0/6] bugfixes for hns3

2021-03-23 Thread Min Hu (Connor)
This series added six bugfix patches. Chengchang Tang (3): net/hns3: fix TCP SEG and TCP CKSUM flag set net/hns3: fix Tx checksum for UDP packets with special port net/hns3: fix the long taskqueue pairs reset time Huisong Li (3): net/hns3: fix the reporting of undefined speed net/hns3:

[dpdk-dev] [PATCH 5/6] net/hns3: fix link update when failed to get link info

2021-03-23 Thread Min Hu (Connor)
From: Huisong Li In the "hns3_dev_link_update" API, the link information of the port is obtained first, and then 'dev_link' in dev->data is updated. When the driver is resetting or fails to obtain link info, the current driver still reports the previous link info to the user. This may cause that

[dpdk-dev] [PATCH 6/6] net/hns3: fix the long taskqueue pairs reset time

2021-03-23 Thread Min Hu (Connor)
From: Chengchang Tang Currently, the queue reset process needs to be performed one by one, which is inefficient. However, the queues reset in the same function is almost at the same stage. To optimize the queue reset process, a new function has been added to the firmware command HNS3_OPC_CFG_RST_

[dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

2021-03-23 Thread Min Hu (Connor)
From: Huisong Li The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. However, the modification in the SVE algorithm is omitted. As a result, the driver fails to be compiled when the SVE algorithm is used. Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath") Signed-o

[dpdk-dev] [PATCH 3/6] net/hns3: fix TCP SEG and TCP CKSUM flag set

2021-03-23 Thread Min Hu (Connor)
From: Chengchang Tang Currently, if the PKT_TX_TCP_SEG and PKT_TX_TCP_CKSUM set in the same time, hns3 PMD can not process the descriptors correctly. This patch fix it by adding the processing of this situation. Fixes: fb6eb9009f41 ("net/hns3: fix Tx checksum with fixed header length") Cc: sta.

[dpdk-dev] [PATCH 4/6] net/hns3: fix Tx checksum for UDP packets with special port

2021-03-23 Thread Min Hu (Connor)
From: Chengchang Tang For Kunpeng920 network engine, UDP packets with destination port 6081, 4789 or 4790 will be identified as tunnel packets. If the UDP CKSUM offload is set in the mbuf, and the TX tunnel mask is not set, the CKSUM of these packets will be wrong. In this case, the upper layer u

Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer

2021-03-23 Thread oulijun
在 2021/3/23 16:07, Ruifeng Wang 写道: -Original Message- From: dev On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: tho...@monjalon.net; ferruh.yi...@intel.com Cc: dev@dpdk.org; linux...@openeuler.org Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng9

Re: [dpdk-dev] [PATCH] app/testpmd: fix the miss configuration for NVGRE encap

2021-03-23 Thread Ferruh Yigit
On 3/16/2021 4:18 AM, Jiawei Wang wrote: For NVGRE protocol, the default value of c_k_s_rsvd0_ver must be 0x2000, and protocol type must be 0x6558 in the NVGRE header. This patch updates these two configuraitons while parser the nvgre encap. Fixes: dcd962fc6b ("app/testpmd: add NVGRE encap/deca

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread oulijun
在 2021/3/23 16:55, Li, Xiaoyun 写道: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test From: Huisong Li The c

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread oulijun
在 2021/3/23 16:55, Li, Xiaoyun 写道: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test From: Huisong Li The c

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread oulijun
在 2021/3/23 16:55, Li, Xiaoyun 写道: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test From: Huisong Li The c

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Ananyev, Konstantin
Hi Akhil, > Hi Konstantin, > > Hi, > > > Adding lookaside IPsec UDP encapsulation support > > > for NAT traversal. > > > Added --udp-encap option for application to specify > > > if UDP encapsulation need to be enabled. > > > Example secgw command with UDP encapsultation enabled: > > > -c 0x1

Re: [dpdk-dev] [PATCH v5 1/8] ether: refine debug build option

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 11:07 AM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. The patch introduces below build options for data path deb

Re: [dpdk-dev] [PATCH v5 2/8] net/fm10k: refine debug build option

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 11:07 AM, Qi Zhang wrote: 1. replace RTE_LIBRTE_FM10K_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_FM10K_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. s/whth/with can fix while merging 3. merge RTE_LIBRTE_FM10K_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG

Re: [dpdk-dev] [PATCH v5 0/8] ether: refine debug build option

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 11:07 AM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for data path de

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > Adding lookaside IPsec UDP encapsulation support > > > > for NAT traversal. > > > > Added --udp-encap option for application to specify > > > > if UDP encapsulation need to be enabled. > > > > Example secgw command with UDP encapsultation enabled: > > > > -c 0

Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help

2021-03-23 Thread Thomas Monjalon
23/03/2021 14:37, David Marchand: > On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon wrote: > > > > The option --log-level was not completely described in the usage text, > > and it was difficult to guess the names of the log types and levels. > > > > A new value "help" is accepted after --log-lev

Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer

2021-03-23 Thread Ruifeng Wang
> -Original Message- > From: oulijun > Sent: Tuesday, March 23, 2021 9:52 PM > To: Ruifeng Wang ; tho...@monjalon.net; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; linux...@openeuler.org; nd > Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon > kunpeng920 implementer > >

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Ananyev, Konstantin
> Hi Konstantin, > > > > Hi Akhil, > > > > > Adding lookaside IPsec UDP encapsulation support > > > > > for NAT traversal. > > > > > Added --udp-encap option for application to specify > > > > > if UDP encapsulation need to be enabled. > > > > > Example secgw command with UDP encapsultation enabl

Re: [dpdk-dev] [PATCH v2 01/10] eal: add thread id and simple thread functions

2021-03-23 Thread Tyler Retzlaff
On Mon, Mar 22, 2021 at 07:54:19PM -0700, Stephen Hemminger wrote: > On Mon, 22 Mar 2021 17:20:26 -0700 > Narcisa Ana Maria Vasile wrote: > > > @@ -59,7 +92,7 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > > * > > * @return > > * On success, zero. > > - * On failure, a negati

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal: fix evaluation of log level option

2021-03-23 Thread Thomas Monjalon
23/03/2021 11:19, David Marchand: > --log-level option is handled early, no need to reevaluate it later in > EAL init. > > Before: > $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ > --log-level=lib.eal:debug \ > --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ > |& gre

Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

2021-03-23 Thread Thomas Monjalon
09/03/2021 17:10, Savinay Dharmappa: > tc ov watermark is initialized with computed value of > max tc ov watermark. Sorry I don't understand what the change is doing. Was there an issue? In the title, please avoid "tc ov" which is meaningless for most of readers I guess. > --- a/lib/librte_sched

Re: [dpdk-dev] [PATCH] port: add ring SWX port

2021-03-23 Thread Thomas Monjalon
28/01/2021 19:55, Cristian Dumitrescu: > --- a/lib/librte_port/version.map > +++ b/lib/librte_port/version.map > @@ -44,4 +44,8 @@ EXPERIMENTAL { > + #added in 21.02 21.05 now > + rte_swx_port_ring_reader_ops; > + rte_swx_port_ring_writer_ops; Applied, thanks.

  1   2   >