[dpdk-dev] [PATCH v5 9/9] kvargs: update parser to support lists

2021-01-18 Thread Xueming Li
This patch updates kvargs parser to support lists on top of range, allow multiple lists or range: k1=a[1,2]b[3-5] Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko Acked-by: Thomas Monjalon --- app/test/test_kvargs.c | 46 +-- lib/librte_kvargs/rte_kvargs.c | 101

[dpdk-dev] [PATCH v5 6/9] ethdev: support multi-host in representor

2021-01-18 Thread Xueming Li
The NIC can have multiple PCIe links and can be attached to the multiple hosts, for example the same single NIC can be shared for multiple server units in the rack. On each PCIe link NIC can provide multiple PFs and VFs/SFs based on these ones. To provide the unambiguous identification of the PCIe

[dpdk-dev] [PATCH v5 8/9] ethdev: add capability of sub-function representor

2021-01-18 Thread Xueming Li
Old DPDK version or some drivers didn't support SubFunction representor. For application to adapt different DPDK version automatically, or to be used for different NICs, this patch introduces new eth device capability of supporting SubFunction representor device. Signed-off-by: Xueming Li Acked-b

[dpdk-dev] [PATCH v1] net/ice/base: add ethertype offset for QinQ dummy pkt

2021-01-18 Thread Yuying Zhang
Add the ethertype offset for QinQ switch rule dummy packet to allow matching the corresponding field. Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_switch.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/

Re: [dpdk-dev] [PATCH] doc: add ixgbe known issue with RSS

2021-01-18 Thread Wang, Haiyue
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, January 19, 2021 15:02 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Xing, Beilei > Subject: [PATCH] doc: add ixgbe known issue with RSS > > From: Beilei Xing > > Currently, IXGBE doesn't support RSS when double VLAN > is enabled due

Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type

2021-01-18 Thread Andrew Rybchenko
On 1/18/21 2:16 PM, Xueming Li wrote: > To support more representor type, this patch introduces representor type > enum. The enum is subject to extend for new types upcoming. > > Signed-off-by: Xueming Li > Acked-by: Viacheslav Ovsiienko One nit below and a question below. In any case: Acked-

[dpdk-dev] [PATCH v4 3/8] net/mlx5: revert setting bonding representor to first PF

2021-01-18 Thread Xueming Li
With kernel bonding, representors on second PF are being probed by devargs: ,representor=pf1vf No need to save primary PF port ID and lookup when probing sibling ports, revert patch [1] [1]: commit e6818853c022 ("net/mlx5: set representor to first PF in bonding mode") Signed-off-by: Xuemi

[dpdk-dev] [PATCH v4 7/8] net/mlx5: fix setting VF default MAC through representor

2021-01-18 Thread Xueming Li
With kernel bonding, there was an error when setting VF MAC address through representor. The Netlink api requires ifindex of owner PF, not bonding device ifindex. Uses owner PF ifindex to modify VF default MAC in case of bonding device. Fixes: c21e5facf7d2 ("net/mlx5: use bond index for netdev op

[dpdk-dev] [PATCH v4 6/8] net/mlx5: save bonding member ports information

2021-01-18 Thread Xueming Li
Since kernel bonding netdev doesn't provide statistics counter that reflects all member ports, PMD has to manually summarize counters from each member ports. As a preparation, this patch collects bonding member port information and saves to shared context data. Signed-off-by: Xueming Li Acked-by

[dpdk-dev] [PATCH v4 2/8] net/mlx5: support representor of sub function

2021-01-18 Thread Xueming Li
This patch adds support for SF representor. Similar to VF representor, switch port name of SF representor in phys_port_name sysfs key is "pfsf". Device representor argumnt is "representors=sf[list]", list member could be mix of instance and range. Example: representors=sf[0,2,4,8-12,-1] To prob

[dpdk-dev] [PATCH v4 0/8] net/mlx5: support SubFunction representor

2021-01-18 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports E-Switch representation offload similar to existing PF and VF representors. A SF shares PCI level resources with other SFs and/or with its parent PCI function. This patch set in

[dpdk-dev] [PATCH v4 4/8] net/mlx5: refactor bonding representor probe

2021-01-18 Thread Xueming Li
To probe representor on 2nd PF of kernel bonding device, had to specify PF1 BDF in devarg: ,representor=0 When closing bonding device, all representors had to be closed together and this implies all representors have to use primary PF of bonding device. So after probing representor port on 2nd PF

[dpdk-dev] [PATCH v4 1/8] common/mlx5: update representor name parsing

2021-01-18 Thread Xueming Li
This patch updates representor name parsing for SF. In sysfs, representor name stored under "phys_port_name" sysfs key, similar to VF representor, switch port name of SF representor is "pfsf". For netlink message, net SF type is supported. Examples: pf0sf1 pf0sf[0-3] Signed-off-by: Xueming Li

[dpdk-dev] [PATCH v4 5/8] net/mlx5: support representor from multiple PFs

2021-01-18 Thread Xueming Li
To probe representors from different kernel bonding PFs, had to specify 2 separate devargs like this: -a 03:00.0,representor=pf0vf[0-3] -a 03:00.0,representor=pf1vf[0-3] This patch supports range or list of PF section in devargs, so the alternative short devargs of above is: -a 03:00.0,rep

[dpdk-dev] [PATCH v4 8/8] net/mlx5: improve bonding xstats

2021-01-18 Thread Xueming Li
In case of kernel bonding device, counter was read from first bonding PF member. This patch reads all member PFs and sums to get bond xstats. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 127 +++- 1 file changed, 102

Re: [dpdk-dev] [PATCH v5 7/9] devarg: change representor ID to bitmap

2021-01-18 Thread Wang, Haiyue
> -Original Message- > From: Xueming Li > Sent: Tuesday, January 19, 2021 15:15 > Cc: dev@dpdk.org; Viacheslav Ovsiienko ; > xuemi...@nvidia.com; Asaf Penso > ; Ajit Khaparde ; Somnath Kotur > ; Daley, John ; Hyong Youb > Kim ; > Xing, Beilei ; Guo, Jia ; Wang, > Haiyue > ; Matan Azrad

Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type

2021-01-18 Thread Xueming(Steven) Li
Hi Andrew, >-Original Message- >From: Andrew Rybchenko >Sent: Tuesday, January 19, 2021 3:25 PM >To: Xueming(Steven) Li ; NBU-Contact-Thomas >Monjalon ; Ferruh Yigit ; >Olivier Matz >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > >Subject: Re: [PATCH v4 1/9] ethdev: introduce represent

Re: [dpdk-dev] [PATCH v1] net/e1000: fix the invalid flow control mode setting

2021-01-18 Thread Guo, Jia
Hi, Wenjun > -Original Message- > From: Wu, Wenjun1 > Sent: Tuesday, January 19, 2021 2:59 PM > To: dev@dpdk.org; Guo, Jia ; Zhang, Qi Z > ; Zhang, Yuying > Cc: Wu, Wenjun1 ; sta...@dpdk.org > Subject: [PATCH v1] net/e1000: fix the invalid flow control mode setting > > E1000_CTRL regist

Re: [dpdk-dev] [PATCH v4 2/9] ethdev: support representor port list

2021-01-18 Thread Andrew Rybchenko
On 1/18/21 2:16 PM, Xueming Li wrote: > To support extended representor syntax, this patch extends the > representor list parsing to support for representor port range in > devargs, examples: >representor=[1,2,3] - single list >representor=[1,3-5,7,9-11] - list with singles and ran

Re: [dpdk-dev] [PATCH v5 2/9] ethdev: support representor port list

2021-01-18 Thread Andrew Rybchenko
On 1/19/21 10:14 AM, Xueming Li wrote: > To support extended representor syntax, this patch extends the > representor list parsing to support for representor port range in > devargs, examples: >representor=[1,2,3] - single list >representor=[1,3-5,7,9-11] - list with singles and ra

Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type

2021-01-18 Thread Andrew Rybchenko
On 1/19/21 10:37 AM, Xueming(Steven) Li wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, January 19, 2021 3:25 PM >> To: Xueming(Steven) Li ; NBU-Contact-Thomas >> Monjalon ; Ferruh Yigit ; >> Olivier Matz >> Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf

Re: [dpdk-dev] [PATCH v5 3/9] ethdev: support new VF representor syntax

2021-01-18 Thread Andrew Rybchenko
On 1/19/21 10:14 AM, Xueming Li wrote: > Current VF representor syntax: > representor=2 - single representor > representor=[0-3] - single range > > To prepare for more representor types, this patch adds compatible VF > representor devargs syntax: > > vf#: > representor=vf2

Re: [dpdk-dev] [PATCH v5 4/9] ethdev: support sub function representor

2021-01-18 Thread Andrew Rybchenko
On 1/19/21 10:14 AM, Xueming Li wrote: > SubFunction is a portion of the PCI device, created on demand, a SF > netdev has its own dedicated queues(txq, rxq). A SF netdev supports > eswitch representation offload similar to existing PF and VF > representors. > > To support SF representor, this patc

Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type

2021-01-18 Thread Xueming(Steven) Li
>-Original Message- >From: Andrew Rybchenko >Sent: Tuesday, January 19, 2021 3:49 PM >To: Xueming(Steven) Li ; NBU-Contact-Thomas >Monjalon ; Ferruh Yigit ; >Olivier Matz >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > >Subject: Re: [PATCH v4 1/9] ethdev: introduce representor type >

<    1   2   3