[dpdk-dev] [PATCH] net/ice: fix GTPU header incorrectly parsed

2021-01-14 Thread Xuan Ding
Refine the GTPU template to avoid incorrect header type be parsed. Some indentation is adjusted. Signed-off-by: Xuan Ding --- drivers/net/ice/ice_hash.c | 165 + 1 file changed, 113 insertions(+), 52 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/driv

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix device detach

2021-01-14 Thread David Marchand
On Wed, Jan 13, 2021 at 5:29 PM Michael Baum wrote: > > When mlx4 device is probed, 2 different ethdev ports may be created for > the 2 physical ports of the device. > > Wrongly, when the device is removed, the created ports are not released. > > Close and release the ethdev ports in remove proces

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread David Marchand
On Fri, Jan 8, 2021 at 9:48 AM David Marchand wrote: > > I wonder if it would be possible and cleaner to disable cancellation on > > the thread while the mutex is held? > > +1 IEEE Std 1003.1-2001/Cor 2-2004, item XBD/TC2/D6/26 is applied, adding pthread_t to the list of types that are not requir

Re: [dpdk-dev] [Bug 613] [21.02] rule lost after port stopped

2021-01-14 Thread Ferruh Yigit
On 1/14/2021 7:15 AM, bugzi...@dpdk.org wrote: https://bugs.dpdk.org/show_bug.cgi?id=613 Bug ID: 613 Summary: [21.02] rule lost after port stopped Product: DPDK Version: unspecified Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH 17/40] net/virtio: move features definition to generic header

2021-01-14 Thread Maxime Coquelin
On 12/30/20 4:14 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subje

Re: [dpdk-dev] [PATCH 20/40] net/virtio: make interrupt handling more generic

2021-01-14 Thread Maxime Coquelin
On 12/30/20 4:17 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subje

Re: [dpdk-dev] [PATCH 22/40] net/virtio: remove last PCI refs in non-PCI code

2021-01-14 Thread Maxime Coquelin
On 12/30/20 4:25 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subje

[dpdk-dev] 回复: [EXT] [PATCH v3] examples/eventdev: refactor ethdev port stop

2021-01-14 Thread Feifei Wang
> -邮件原件- > 发件人: Feifei Wang > 发送时间: 2021年1月14日 14:24 > 收件人: Pavan Nikhilesh Bhagavatula ; Harry > van Haaren ; Nikhil Rao > ; Pavan Nikhilesh > > 抄送: dev@dpdk.org; jer...@marvell.com; nd ; > sta...@dpdk.org; Ruifeng Wang ; Honnappa > Nagarahalli ; nd > 主题: 回复: [EXT] [PATCH v3] examples/

Re: [dpdk-dev] [PATCH 02/40] net/virtio: Introduce Virtio bus type

2021-01-14 Thread Maxime Coquelin
On 1/5/21 10:15 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> >> This patch is preliminary work for introducing a bus layer >> in Virtio PMD, in order to improve Virtio-user integration. >> >> A new bus type is added to provide a unified way to disting

Re: [dpdk-dev] [PATCH 03/40] net/virtio: refactor virtio-user device

2021-01-14 Thread Maxime Coquelin
On 1/5/21 10:16 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> >> This patch moves the virtio_hw structure into the virtio_user_dev >> structure, with the goal of making virtio_hw bus-agnostic. >> >> Signed-off-by: Maxime Coquelin > > Just one comment

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF

2021-01-14 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker > flags with COFF > > External email: Use caution opening links or attachments > > > 13/01/2021 21:27, Ranjit Menon: > > On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote: > > > The --export-dynamic linker option is only a

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF

2021-01-14 Thread Thomas Monjalon
14/01/2021 10:27, Tal Shnaiderman: > > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only > > linker > > flags with COFF > > > > External email: Use caution opening links or attachments > > > > > > 13/01/2021 21:27, Ranjit Menon: > > > On 1/11/2021 4:36 PM, Dmitry Kozlyuk w

Re: [dpdk-dev] [PATCH v16 00/11] Add PMD power management

2021-01-14 Thread David Marchand
On Tue, Jan 12, 2021 at 6:37 PM Anatoly Burakov wrote: > > This patchset proposes a simple API for Ethernet drivers to cause the > CPU to enter a power-optimized state while waiting for packets to > arrive. There are multiple proposed mechanisms to achieve said power > savings: simple frequency sc

[dpdk-dev] [PATCH v3 00/22] fix rx packets dropped issue

2021-01-14 Thread Steve Yang
The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, this fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead. When the MTU(1500) set, the frame type of rx packet will be different if used different overhead, it will cause the consistency issue, and the normal p

[dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-14 Thread Steve Yang
Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since the application/driver used Ethernet overhead is different than the ethdev one, check result is wrong. If the driver is using Ether

[dpdk-dev] [PATCH v3 02/22] app/testpmd: fix max rx packet length for VLAN packets

2021-01-14 Thread Steve Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Removed the rx_offloads assignment for jumbo frame during command line parsing, and set the correct jumbo frame flag if MTU size is larger t

[dpdk-dev] [PATCH v3 03/22] net/dpaa: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead

[dpdk-dev] [PATCH v3 04/22] net/dpaa2: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead

[dpdk-dev] [PATCH v3 05/22] net/e1000: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead

[dpdk-dev] [PATCH v3 07/22] net/i40e: fix the jumbo frame flag condition

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 06/22] net/hns3: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'HSN3_DEFAULT_FRAME_LE

[dpdk-dev] [PATCH v3 09/22] net/ice: fix the jumbo frame flag condition

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 08/22] net/iavf: fix the jumbo frame flag condition

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 11/22] net/octeontx: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 13/22] net/qede: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 14/22] net/sfc: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU', that perhap

[dpdk-dev] [PATCH v3 15/22] net/thunderx: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v3 16/22] net/ixgbe: fix the jumbo frame flag condition

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v3 17/22] net/cxgbe: fix the jumbo frame flag condition

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v3 18/22] net/axgbe: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v3 19/22] net/enetc: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v3 20/22] net/hinic: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v3 21/22] net/nfp: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU', that perhaps

[dpdk-dev] [PATCH v3 22/22] net/liquidio: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH] net/ixgbe: fix configuration of max frame size

2021-01-14 Thread Zhang,Alvin
From: Alvin Zhang For 82599 NIC, jumbo frame feature is not supported in IOV mode, but if a VF requests to configure the frame size to that not bigger than RTE_ETHER_MAX_LEN, the PMD should not return -1. This patch keeps ixgbe PMD's handling mode consistent with kernel driver in above situation.

Re: [dpdk-dev] [PATCH v16 03/11] eal: change API of power intrinsics

2021-01-14 Thread Burakov, Anatoly
On 13-Jan-21 6:01 PM, Ananyev, Konstantin wrote: On 13-Jan-21 1:01 PM, Ananyev, Konstantin wrote: Instead of passing around pointers and integers, collect everything into struct. This makes API design around these intrinsics much easier. Signed-off-by: Anatoly Burakov Acked-by: Konstantin

Re: [dpdk-dev] [PATCH v3 5/5] net/iavf: fix vector mapping with queue

2021-01-14 Thread Xie, WeiX
Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jingjing Wu > Sent: Thursday, January 7, 2021 4:27 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; Xia, Chenbo ; Lu, Xiuchun > > Subject: [

Re: [dpdk-dev] [PATCH v16 00/11] Add PMD power management

2021-01-14 Thread Burakov, Anatoly
On 14-Jan-21 9:36 AM, David Marchand wrote: On Tue, Jan 12, 2021 at 6:37 PM Anatoly Burakov wrote: This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive. There are multiple proposed mechanisms to achieve s

Re: [dpdk-dev] [PATCH v3 03/22] net/dpaa: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 04/22] net/dpaa2: fix the jumbo frame flag condition for mtu set

2021-01-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF

2021-01-14 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker > flags with COFF > > External email: Use caution opening links or attachments > > > 14/01/2021 10:27, Tal Shnaiderman: > > > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using > > > ELF-only linker flag

[dpdk-dev] [PATCH v4 0/3] fix bugs for examples/evnentdev

2021-01-14 Thread Feifei Wang
Fix some bugs for eventdev pipeline example. v2: 1. Delete unused variable to fix build error 2. Reduce commit message length to fix coding style issues v3: 1. Title improvement (Van Haaren) v4: 1. fix core enabled bug 2. add info typo for main core Feifei Wang (3): doc: fix core enabled bug

[dpdk-dev] [PATCH v4 1/3] doc: fix core enabled bug for eventdev pipeline example

2021-01-14 Thread Feifei Wang
In the case that the cores are isolated, if "-l" or "-c" parameter is not added, the cores will not be enabled and can not launch worker function correctly. In the meanwhile, no error information is reported. For example: totally CPUs:16 isolated CPUs:1-8 command: sudo gdb -args ./dpdk-eventdev_pi

[dpdk-dev] [PATCH v4 2/3] examples/eventdev: add info output for main core

2021-01-14 Thread Feifei Wang
When the main core is set as tx/rx/sched/worker core, it also needs to print some information to show this. Thus, add info output for the main core, and add a "dump" function to print core information for the sake of code simplicity and easy maintenance. In the meanwhile, fix the count error. For

[dpdk-dev] [PATCH v4 3/3] examples/eventdev: move eth stop to the end

2021-01-14 Thread Feifei Wang
Move eth stop code from "signal_handler" function to the end of "main" function. There are two reasons for this: First, this improves code maintenance and makes code look simple and clear. Based on this change, after receiving the interrupt signal, "fdata->done" is set as 1. Then the main thread w

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix device detach

2021-01-14 Thread David Marchand
On Thu, Jan 14, 2021 at 9:32 AM David Marchand wrote: > > On Wed, Jan 13, 2021 at 5:29 PM Michael Baum wrote: > > > > When mlx4 device is probed, 2 different ethdev ports may be created for > > the 2 physical ports of the device. > > > > Wrongly, when the device is removed, the created ports are

[dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script

2021-01-14 Thread Ciara Power
This patchset introduces a python script to run various crypto performance test cases, and graph the results in a consumable manner. The test suites are configured via JSON file. Some config files are provided, or the user may create one. Currently throughput and latency ptests for devices crypto_q

[dpdk-dev] [PATCH v2 1/4] test/cryptodev: fix latency test csv output

2021-01-14 Thread Ciara Power
The csv output for the latency performance test had an extra header, "Packet Size", which is a duplicate of "Buffer Size", and had no corresponding value in the output. This is now removed. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Cc: pablo.de.lara.gua...@intel.com Cc: sta.

[dpdk-dev] [PATCH v2 2/4] test/cryptodev: fix csv output format

2021-01-14 Thread Ciara Power
The csv output for each ptest type used ";" instead of ",". This has now been fixed to use the comma format that is used in the csv headers. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode") Fixes: da40ebd6d383 (

[dpdk-dev] [PATCH v2 3/4] usertools: add script to graph crypto perf results

2021-01-14 Thread Ciara Power
The python script introduced in this patch runs the crypto performance test application for various test cases, and graphs the results. Test cases are defined in config JSON files, this is where parameters are specified for each test. Currently there are various test cases for devices crypto_qat,

[dpdk-dev] [PATCH v2 4/4] maintainers: update crypto perf app maintainers

2021-01-14 Thread Ciara Power
This patch adds a maintainer for the crypto perf test application, to cover the new perf test graphing script. Signed-off-by: Ciara Power --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 52265e7b02..17b7ad176a 100644 --- a/MAINTAINERS +++ b/MAIN

Re: [dpdk-dev] [PATCH 02/40] net/virtio: Introduce Virtio bus type

2021-01-14 Thread Maxime Coquelin
On 1/14/21 10:24 AM, Maxime Coquelin wrote: > > > On 1/5/21 10:15 PM, David Marchand wrote: >> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin >> wrote: >>> >>> This patch is preliminary work for introducing a bus layer >>> in Virtio PMD, in order to improve Virtio-user integration. >>> >>>

Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *

2021-01-14 Thread Bruce Richardson
On Thu, Jan 14, 2021 at 10:05:57AM +0300, Dmitry Kozlyuk wrote: > On Wed, 13 Jan 2021 21:45:49 -0800, Tyler Retzlaff wrote: > > On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote: > > > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote: > > > > Explicitly cast void * to type *

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2021-01-14 Thread Maxime Coquelin
On 1/5/21 10:16 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> >> This patch initiate refactoring of Virtio PCI, by introducing >> a new device structure for PCI-specific metadata. > > This works, but this patch seems artificial. > > The eth_virtio_de

[dpdk-dev] [PATCH 00/20] ensure headers have correct includes

2021-01-14 Thread Bruce Richardson
As a general principle, each header file should include any other headers it needs to provide data type definitions or macros. For example, any header using the uintX_t types in structures or function prototypes should include "stdint.h" to provide those type definitions. In practice, while many,

[dpdk-dev] [PATCH 01/20] eal: fix missing header inclusion

2021-01-14 Thread Bruce Richardson
The rte_reciprocal header file used standard __rte_always_inline from rte_common.h but does not include that header file, leading to compiler errors when the reciprocal header is included alone. Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH 02/20] telemetry: fix missing header include

2021-01-14 Thread Bruce Richardson
The telemetry header file uses the rte_cpuset_t type, but does not include any header providing that type. Include rte_os.h to provide the necessary type. Fixes: febbebf7f255 ("telemetry: keep threads separate from data plane") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_

[dpdk-dev] [PATCH 03/20] ethdev: fix missing header include

2021-01-14 Thread Bruce Richardson
The define for RTE_ETH_FLOW_MAX is defined in rte_ethdev.h, so that header should be included in rte_eth_ctrl.h to allow it to be compiled independently. Fixes: 7fa96d696f2c ("ethdev: unification of flow types") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ethdev/rte_eth_c

[dpdk-dev] [PATCH 04/20] ring: fix missing includes for c11 model header

2021-01-14 Thread Bruce Richardson
Add in the missing includes into the header file for c11 memory model, so it can be compiled up independently of the other headers. Fixes: 39368ebfc606 ("ring: introduce C11 memory model barrier option") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring_c11_mem.h

[dpdk-dev] [PATCH 05/20] net: fix missing header include

2021-01-14 Thread Bruce Richardson
The Geneve protocol header file is missing the rte_byteorder.h header. Fixes: ea0e711b8ae0 ("app/testpmd: add GENEVE parsing") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_net/rte_geneve.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_net/rte_geneve.h b/li

[dpdk-dev] [PATCH 06/20] mbuf: fix missing header include

2021-01-14 Thread Bruce Richardson
The rte_mbuf_dyn.h header file uses a number of types and macros without including the required header files to get the definitions of those macros/types. Similarly, the rte_mbuf_core.h file was missing an include for rte_byteorder.h header. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and

[dpdk-dev] [PATCH 07/20] bitratestats: fix missing header include

2021-01-14 Thread Bruce Richardson
The rte_compat.h header file must be included to get the definition of __rte_experimental. Fixes: f030bff72f81 ("bitrate: add free function") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_bitratestats/rte_bitrate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/lib

[dpdk-dev] [PATCH 08/20] rib: fix missing header includes

2021-01-14 Thread Bruce Richardson
The standard integer types, and the size_t types are missing their required header includes in the rib header file. Fixes: 5a5793a5ffa2 ("rib: add RIB library") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_rib/rte_rib.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[dpdk-dev] [PATCH 09/20] vhost: fix missing header includes

2021-01-14 Thread Bruce Richardson
The vhost header files were missing definitions from headers to allow them to be compiled up individually. Fixes: d7280c9fffcb ("vhost: support selective datapath") Fixes: a49f758d1170 ("vhost: split vDPA header file") Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: st

[dpdk-dev] [PATCH 10/20] ipsec: fix missing header include

2021-01-14 Thread Bruce Richardson
The rte_ipsec_sad.h header used the standard uintXX_t types, but did not include stdint.h header for them. Fixes: 401633d9c112 ("ipsec: add inbound SAD API") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ipsec/rte_ipsec_sad.h | 1 + 1 file changed, 1 insertion(+) diff --gi

[dpdk-dev] [PATCH 11/20] fib: fix missing header includes

2021-01-14 Thread Bruce Richardson
Add stdint.h to get definitions of standard integer types Fixes: 39e927248416 ("fib: add FIB library") Fixes: 40d41a8a7b34 ("fib: support IPv6") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_fib/rte_fib.h | 1 + lib/librte_fib/rte_fib6.h | 1 + 2 files changed, 2 insertion

[dpdk-dev] [PATCH 12/20] table: fix missing header include

2021-01-14 Thread Bruce Richardson
The rte_lru_x86.h header, included from the main rte_lru.h header, uses the RTE_CC_IS_GNU macro from rte_common.h but fails to include that header file. Fixes: 0c9a5735a947 ("eal: fix compiler detection in public headers") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_table

[dpdk-dev] [PATCH 13/20] pipeline: fix missing header includes

2021-01-14 Thread Bruce Richardson
The stdio.h header needs to be included to get the definition of the FILE type. Fixes: b32c0a2c5e4c ("pipeline: add SWX table update high level API") Fixes: 3ca60ceed79a ("pipeline: add SWX pipeline specification file") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_pipeline

[dpdk-dev] [PATCH 14/20] metrics: fix variable declaration in header

2021-01-14 Thread Bruce Richardson
The global variable "tel_met_data" was declared in a header file, rather than in a C file, leading to duplicate definitions if more than one C file included the header. Fixes: c5b7197f662e ("telemetry: move some functions to metrics library") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson -

[dpdk-dev] [PATCH 15/20] node: fix missing header include

2021-01-14 Thread Bruce Richardson
The rte_compat header file is needed for the '__rte_experimental' macro. Fixes: f00708c2aa53 ("node: add IPv4 rewrite and lookup control") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_node/rte_node_ip4_api.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_no

[dpdk-dev] [PATCH 16/20] app: fix extra include paths for app builds

2021-01-14 Thread Bruce Richardson
The "includes" variable in the app/meson.build file was ignored when building the executable, meaning that apps couldn't pass additional include paths directly back. Fix this to align with drivers and libs. Fixes: fa036e70d794 ("app: generalize meson build") Cc: sta...@dpdk.org Signed-off-by: Bru

[dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers

2021-01-14 Thread Bruce Richardson
To verify that all DPDK headers are ok for inclusion directly in a C file, and are not missing any other pre-requisite headers, we can auto-generate for each header an empty C file that includes that header. Compiling these files will throw errors if any header has unmet dependencies. Signed-off-b

[dpdk-dev] [PATCH 18/20] eal: add missing include to mcslock

2021-01-14 Thread Bruce Richardson
Include 'rte_branch_prediction.h' to get the likely/unlikely macro definitions. Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_eal/include/generic/rte_mcslock.h | 1 + 1 file changed, 1 insertion(+) diff --

[dpdk-dev] [PATCH 19/20] eal/x86: add architecture-specific headers to chkincs

2021-01-14 Thread Bruce Richardson
Ensure the architecture-specific header files for x86 have all necessary includes in them. Signed-off-by: Bruce Richardson --- app/chkincs/gen_c_file_for_header.py | 4 lib/librte_eal/x86/include/meson.build | 1 + 2 files changed, 5 insertions(+) diff --git a/app/chkincs/gen_c_file_for_

[dpdk-dev] [PATCH 20/20] test-meson-builds: add includes check to default x86 build

2021-01-14 Thread Bruce Richardson
Since the includes check is disabled by default, we need to explicitly enable it to have it run. To minimise any extra build time when running the test-meson-builds script, we just add it to the default x86 build. Signed-off-by: Bruce Richardson --- devtools/test-meson-builds.sh | 2 +- 1 file c

Re: [dpdk-dev] [PATCH v2 4/4] test/lpm: improve coverage on tbl8

2021-01-14 Thread Medvedkin, Vladimir
On 14/01/2021 06:59, Ruifeng Wang wrote: Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more than 256 groups in tests can improve the coverage. Coverage was not ex

[dpdk-dev] [PATCH] doc: fix testpmd sample qinq flow rules

2021-01-14 Thread Bernard Iremonger
In the Testpmd Flow rules management section, correct the TPID values in the Sample QinQ flow rules sub section. Fixes: bef3bfe7d5f4 ("doc: revise sample testpmd flow commands") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++-- 1 file

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Matan Azrad
Hi Maxime and David Thank you for Review. From: David Marchand > On Fri, Jan 8, 2021 at 9:48 AM David Marchand > wrote: > > > I wonder if it would be possible and cleaner to disable cancellation > > > on the thread while the mutex is held? Yes, we can cause thread to return by some global varia

Re: [dpdk-dev] [PATCH 02/40] net/virtio: Introduce Virtio bus type

2021-01-14 Thread David Marchand
On Thu, Jan 14, 2021 at 11:55 AM Maxime Coquelin wrote: > >>> @@ -1919,7 +1918,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) > >>> eth_dev->rx_descriptor_done = virtio_dev_rx_queue_done; > >>> > >>> if (rte_eal_process_type() == RTE_PROC_SECONDARY) { > >>> - i

Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute

2021-01-14 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Wednesday, January 13, 2021 2:43 PM > To: Van Haaren, Harry ; mattias.ronnblom > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work > attribute > > Hello Harry, Mattias, > > On Fri, Oct 16, 2

Re: [dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers

2021-01-14 Thread David Marchand
On Thu, Jan 14, 2021 at 12:09 PM Bruce Richardson wrote: > > To verify that all DPDK headers are ok for inclusion directly in a C > file, and are not missing any other pre-requisite headers, we can > auto-generate for each header an empty C file that includes that header. > Compiling these files w

[dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-14 Thread Bruce Richardson
When querying the link status via telemetry interface, we don't want the client to have to wait for multiple seconds for a reply. Therefore use "rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry callback. Cc: sta...@dpdk.org Fixes: c190daedb9b1 ("ethdev: add telemetry ca

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: introduce generic copy rte flow action

2021-01-14 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, January 13, 2021 7:08 PM > Subject: [PATCH v4 1/2] ethdev: introduce generic copy rte flow action > > Implement a generic copy flow API to allow copying of an arbitrary > header field (as well as mark, metada

Re: [dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers

2021-01-14 Thread Bruce Richardson
On Thu, Jan 14, 2021 at 01:16:58PM +0100, David Marchand wrote: > On Thu, Jan 14, 2021 at 12:09 PM Bruce Richardson > wrote: > > > > To verify that all DPDK headers are ok for inclusion directly in a C > > file, and are not missing any other pre-requisite headers, we can > > auto-generate for each

Re: [dpdk-dev] [PATCH v16 03/11] eal: change API of power intrinsics

2021-01-14 Thread Ananyev, Konstantin
> > On 13-Jan-21 6:01 PM, Ananyev, Konstantin wrote: > > > >> On 13-Jan-21 1:01 PM, Ananyev, Konstantin wrote: > >>> > > Instead of passing around pointers and integers, collect everything > into struct. This makes API design around these intrinsics much easier. > > Sign

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Maxime Coquelin
Hi Matan, On 1/14/21 12:49 PM, Matan Azrad wrote: > Hi Maxime and David > > Thank you for Review. > > From: David Marchand >> On Fri, Jan 8, 2021 at 9:48 AM David Marchand >> wrote: I wonder if it would be possible and cleaner to disable cancellation on the thread while the mutex is h

Re: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16

2021-01-14 Thread 李伟峰
your commit log is better. thanks. | | 李伟峰 | | 邮箱:liweifen...@126.com | 签名由 网易邮箱大师 定制 On 01/14/2021 12:50, Zhang, Qi Z wrote: > -Original Message- > From: dev On Behalf Of Zhang, Qi Z > Sent: Wednesday, January 13, 2021 12:09 PM > To: Weifeng Li ; Xing, Beilei ; > Guo, Jia > Cc: dev

[dpdk-dev] DPDK Release Status Meeting 14/01/2021

2021-01-14 Thread Ferruh Yigit
Meeting minutes of 14 January 2021 -- Agenda: * Release Dates * Subtrees * LTS * Opens Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * NXP * Red Hat Release Dates - * v21.02 dates * -rc1 pushed to *Friday, 19 Januar

Re: [dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers

2021-01-14 Thread David Marchand
On Thu, Jan 14, 2021 at 1:28 PM Bruce Richardson wrote: > > Can we instead flag those headers from the libraries themselves? > > In addition of the headers current variable, something like a > > internal_headers or private_headers variable? > > > > Yes, we could do that, though we need a suitable

Re: [dpdk-dev] DPDK Release Status Meeting 14/01/2021

2021-01-14 Thread Ferruh Yigit
On 1/14/2021 12:48 PM, Ferruh Yigit wrote: Meeting minutes of 14 January 2021 -- <...> Release Dates - * v21.02 dates   * -rc1 pushed to  *Friday, 19 January 2021*   * -rc2:   Friday, 29 January 2021   * Release:    Friday, 5 February

Re: [dpdk-dev] [PATCH 04/20] ring: fix missing includes for c11 model header

2021-01-14 Thread David Marchand
On Thu, Jan 14, 2021 at 12:07 PM Bruce Richardson wrote: > > Add in the missing includes into the header file for c11 memory model, > so it can be compiled up independently of the other headers. > > Fixes: 39368ebfc606 ("ring: introduce C11 memory model barrier option") > Cc: sta...@dpdk.org > > S

Re: [dpdk-dev] [PATCH v16 07/11] power: add PMD power management API and callback

2021-01-14 Thread Burakov, Anatoly
On 13-Jan-21 5:29 PM, Burakov, Anatoly wrote: On 13-Jan-21 12:58 PM, Ananyev, Konstantin wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, January 12, 2021 5:37 PM To: dev@dpdk.org Cc: Ma, Liang J ; Hunt, David ; Ray Kinsella ; Neil Horman ; tho...@monjalon.net; Ananye

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Matan Azrad
From: Maxime Coquelin > Hi Matan, > > On 1/14/21 12:49 PM, Matan Azrad wrote: > > Hi Maxime and David > > > > Thank you for Review. > > > > From: David Marchand > >> On Fri, Jan 8, 2021 at 9:48 AM David Marchand > >> wrote: > I wonder if it would be possible and cleaner to disable > c

Re: [dpdk-dev] [Bug 613] [21.02] rule lost after port stopped

2021-01-14 Thread Asaf Penso
>-Original Message- >From: dev On Behalf Of Ferruh Yigit >Sent: Thursday, January 14, 2021 10:38 AM >To: Gregory Etelson ; Ori Kam >Cc: bugzi...@dpdk.org; dev@dpdk.org; Ajit Khaparde > >Subject: Re: [dpdk-dev] [Bug 613] [21.02] rule lost after port stopped > >On 1/14/2021 7:15 AM, bugzi..

Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed

2021-01-14 Thread Jerin Jacob
On Tue, Jan 12, 2021 at 11:25 AM Rasesh Mody wrote: > > > From: Jerin Jacob > > Sent: Tuesday, January 12, 2021 10:21 AM > > > > On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody wrote: > > > > > > > From: dev On Behalf Of Igor Russkikh > > > > Sent: Monday, January 4, 2021 6:15 PM > > > > > > > > > W

Re: [dpdk-dev] [ovs-dev] ovs-vswitchd with DPDK crashed when guest VM restarts network service

2021-01-14 Thread Alex Yeh (ayeh)
Hi Kevin, Stokes, Resending just to make sure the email is not lost. Thanks and looking forward to your suggestion, Alex -Original Message- From: Alex Yeh (ayeh) Sent: Friday, January 08, 2021 11:36 AM To: Kevin Traynor ; Stokes, Ian ; dev@dpdk.org Cc: Yegappan Lakshmanan (yega)

[dpdk-dev] [Bug 615] testpmd gets stuck when deleting an FDIR flow

2021-01-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=615 Bug ID: 615 Summary: testpmd gets stuck when deleting an FDIR flow Product: DPDK Version: 18.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH 8/8] net/hns3: remove unused assignment for RSS key

2021-01-14 Thread Lijun Ou
The default RSS key does not need to be configured repeatedly when call hns3_dev_configure function with the NULL RSS key because the default RSS key has been configured when the PMD driver run hns3_do_start function with starting device. Besides, it will not overwrite the inited key if rte_eth_de

  1   2   3   >