> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker > flags with COFF > > External email: Use caution opening links or attachments > > > 13/01/2021 21:27, Ranjit Menon: > > On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote: > > > The --export-dynamic linker option is only applicable to ELF. > > > On Windows, where COFF is used, it causes warnings: > > > > > > x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported > > > for PE+ targets, did you mean --export-all-symbols? (MinGW) > > > > > > LINK : warning LNK4044: unrecognized option '/-export-dynamic'; > > > ignored (clang) > > > > > > Don't add --export-dynamic on Windows anywhere. > > > > > > Fixes: b031e13d7f0d ("build: fix plugin load on static build") > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > > > --- > > > Using TLS variables with DLLs is problematic on Windows for now, so > > > not attempting to check or solve the issue with plugin load. > > > > Acked-by: Ranjit Menon <ranjit.me...@intel.com> > > Applied, thanks > > Why we didn't catch it in advance in CI? >
I think Windows CI still passes on builds with warnings, maybe we can change it now that we cleared all of them.