Re: [dpdk-dev] [PATCH 0/9] ice base update batch 2

2021-01-08 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Friday, January 8, 2021 2:05 PM > To: Zhang, Qi Z > Cc: Wang, Haiyue ; Guo, Jia ; > dev@dpdk.org; Yigit, Ferruh > Subject: RE: [PATCH 0/9] ice base update batch 2 > > Acked-by: Qiming Yang > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH v4 3/3] net/i40e: refactor RSS flow

2021-01-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang,Alvin > Sent: Friday, January 8, 2021 1:36 PM > To: Guo, Jia ; Xing, Beilei ; Zhang, > Qi Z ; Su, Simei ; Yang, Qiming > > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v4 3/3] net/i40e: refactor RSS flow > > From: Alvin Zhang > > 1. Delete or

Re: [dpdk-dev] [PATCH v4 2/3] net/i40e: fix return value

2021-01-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang,Alvin > Sent: Friday, January 8, 2021 1:36 PM > To: Guo, Jia ; Xing, Beilei ; Zhang, > Qi Z ; Su, Simei ; Yang, Qiming > > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v4 2/3] net/i40e: fix return value > > From: Alvin Zhang >

[dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes

2021-01-08 Thread Ruifeng Wang
This series fixed bug in lpm4 vector lookup implementations. When more than 256 tbl8 groups are created, lookupx4 could retrieve next hop data from wrong group. The bug is there since next_hop field was expanded from 8-bit to 24-bit, and inherited by other implementations. Also updated test case t

[dpdk-dev] [PATCH 1/4] lpm: fix vector lookup for Arm

2021-01-08 Thread Ruifeng Wang
rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group been searched. Issue fixed by applying proper

[dpdk-dev] [PATCH 2/4] lpm: fix vector lookup for x86

2021-01-08 Thread Ruifeng Wang
rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group been searched. Issue fixed by applying proper

[dpdk-dev] [PATCH 3/4] lpm: fix vector lookup for ppc64

2021-01-08 Thread Ruifeng Wang
rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group been searched. Issue fixed by applying proper

[dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-08 Thread Ruifeng Wang
Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more than 256 groups in tests can improve the coverage. Coverage was not expanded to reach the max supported group number

Re: [dpdk-dev] [PATCH v4 1/3] doc: fix testpmd command for i40e RSS flow

2021-01-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang,Alvin > Sent: Friday, January 8, 2021 1:36 PM > To: Guo, Jia ; Xing, Beilei ; Zhang, > Qi Z ; Su, Simei ; Yang, Qiming > > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v4 1/3] doc: fix testpmd command for i40e RSS flow > > From

Re: [dpdk-dev] [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly

2021-01-08 Thread Maxime Coquelin
Hi Chenbo, On 1/8/21 3:50 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, December 22, 2020 12:15 AM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; >> david.march...@redhat.com; olivier.m...@6wind.com >> Cc: Maxime Coquelin

[dpdk-dev] [PATCH v2 0/5] lpm lookup with sve support

2021-01-08 Thread Ruifeng Wang
Added lpm4 lookupx4 implementation by using Arm SVE extension. The SVE is Scalable Vector Extension which is exposed to the user with a vector length agnostic interface. Refer to [1] for more information about SVE. Configuration was added for Neoverse N2 CPU which has SVE support. Some bugs were

[dpdk-dev] [PATCH v2 1/5] lpm: add sve support for lookup on Arm platform

2021-01-08 Thread Ruifeng Wang
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set. Signed-off-by: Ruifeng Wang --- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build| 2 +- lib/librte_lpm/rte_lpm.h | 4

[dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled

2021-01-08 Thread Ruifeng Wang
Building with SVE extension enabled stopped with error: error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’ 18 | #define PG64_256BIT svwhilelt_b64(0, 4) This is caused by unintentional cflags reset. Fixed the issue by appending required flag to cflags instead of overriding

[dpdk-dev] [PATCH v2 3/5] net/octeontx: fix build with sve enabled

2021-01-08 Thread Ruifeng Wang
Building with gcc 10.2 with SVE extension enabled got error: {standard input}: Assembler messages: {standard input}:91: Error: selected processor does not support `addvl x4,x8,#-1' {standard input}:95: Error: selected processor does not support `ptrue p1.d,all' {standard input}:135: Error: select

[dpdk-dev] [PATCH v2 4/5] common/octeontx2: fix build with sve enabled

2021-01-08 Thread Ruifeng Wang
Building with gcc 10.2 with SVE extension enabled got error: {standard input}: Assembler messages: {standard input}:4002: Error: selected processor does not support `mov z3.b,#0' {standard input}:4003: Error: selected processor does not support `whilelo p1.b,xzr,x7' {standard input}:4005: Error:

[dpdk-dev] [PATCH v2 5/5] config: add Arm Neoverse N2

2021-01-08 Thread Ruifeng Wang
Add Arm Neoverse N2 cpu support. Signed-off-by: Ruifeng Wang --- config/arm/arm64_n2_linux_gcc | 17 + config/arm/meson.build| 11 ++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 config/arm/arm64_n2_linux_gcc diff --git a/config/arm/arm64

Re: [dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump overlapping

2021-01-08 Thread Jiawei(Jonny) Wang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, January 6, 2021 11:55 PM > To: Jiawei(Jonny) Wang > Cc: ferruh.yi...@intel.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com; Ori Kam ; Slava > Ovsiienko ; NBU-Contact-Thomas Monjalon > ; Ra

Re: [dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump overlapping

2021-01-08 Thread Jiawei(Jonny) Wang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, January 6, 2021 11:56 PM > To: Jiawei(Jonny) Wang > Cc: ferruh.yi...@intel.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com; Ori Kam ; Slava > Ovsiienko ; NBU-Contact-Thomas Monjalon > ; Ra

[dpdk-dev] [PATCH] net/mlx5: enlarge maximal flow priority value

2021-01-08 Thread Dong Zhou
Currently, the maximal flow priority in non-root table to user is 4, it's not enough for user to do some flow match by priority, such as LPM, for one IPV4 address, we need 32 priorities for each bit of 32 mask length. PMD will manage 3 sub-priorities per user priority according to L2, L3 and L4. T

[dpdk-dev] [PATCH] net/i40e: i40e PMD APIs add input pointer null check

2021-01-08 Thread Murphy Yang
Pointer 'NULL' check for 'mac_addr' or 'conf' within i40e PMD APIs. Fixes: 66c78f4799ff ("net/i40e: add support for packet template to flow director") Fixes: 04b443fb2c43 ("net/i40e: fix port id type") Signed-off-by: Murphy Yang --- drivers/net/i40e/rte_pmd_i40e.c | 6 ++ 1 file changed, 6

[dpdk-dev] [PATCH] test/event_crypto_adapter: set cipher operation in transform

2021-01-08 Thread Ankur Dwivedi
The cipher operation in the transform should be set to encrypt. Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration") Signed-off-by: Ankur Dwivedi --- app/test/test_event_crypto_adapter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_event_crypto_adapter.c

[dpdk-dev] [PATCH] net/ice: refactor PF RSS

2021-01-08 Thread Xuan Ding
This patch refactors the PF RSS code based on the below design: 1. ice_pattern_match_item->input_set_mask is the superset of ETH_RSS_xxx. 2. ice_pattern_match_item->meta is the ice_rss_hash_cfg template. 3. ice_hash_parse_pattern will generate pattern hint. 4. ice_hash_parse_action will refine t

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-08 Thread David Marchand
On Thu, Jan 7, 2021 at 7:09 PM Maxime Coquelin wrote: > On 1/6/21 7:43 AM, Matan Azrad wrote: > > When the vDPA device is closed, the driver polling thread is canceled. > > The polling thread locks the configuration mutex while it polls the CQs. > > > > When the cancellation happens, it may termin

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Ferruh Yigit
On 1/8/2021 1:41 AM, Zhang, Qi Z wrote: -Original Message- From: Thomas Monjalon Sent: Friday, January 8, 2021 12:59 AM To: Guo, Jia ; Zhang, Qi Z Cc: Wu, Jingjing ; Yang, Qiming ; Wang, Haiyue ; dev@dpdk.org; Yigit, Ferruh ; andrew.rybche...@oktetlabs.ru; or...@nvidia.com; getel...@

Re: [dpdk-dev] [PATCH v2 5/6] app/regex: support performance measurements per QP

2021-01-08 Thread Thomas Monjalon
20/12/2020 11:41, Ophir Munk: > Up to this commit measuring the parsing elapsed time and Giga bits per > second performance was done on the aggregation of all QPs (per core). > This commit separates the time measurements per individual QP. > > Signed-off-by: Ophir Munk > --- > --- a/app/test-rege

[dpdk-dev] [v3 PATCH] usertools: show an error message if unable to reserve requested hugepages

2021-01-08 Thread Sarosh Arif
Sometimes the system is unable to reserve the requested hugepages because enough space is not available in the RAM. In that case, currently the script displays no error message hence the user can be under the delusion that the hugepages requested are all successfully reserved. This patch displays a

Re: [dpdk-dev] [PATCH v1 0/4] Vectorize packed ring RX/TX path with NEON

2021-01-08 Thread Maxime Coquelin
On 11/17/20 11:06 AM, Joyce Kong wrote: > This patch set introduces vectorized RX/TX path for packed ring with NEON > intrinsics. > > With this patch set, PVP case has 1.5% perf uplift for the packed vectorized > NEON path compared with the non-vector packed path, under 0.001% acceptable > loss

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-08 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Hi, Pavan > > > >> -邮件原件- > >> 发件人: Pavan Nikhilesh Bhagavatula > >> 发送时间: 2021年1月5日 17:29 > >> 收件人: Feifei Wang ; jer...@marvell.com; >Harry > >> van Haaren > >> 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > >> ; sta...@dpdk.org; Ruifeng Wang > >> ; nd > >> 主题: RE: [RFC PAT

Re: [dpdk-dev] [PATCH 1/4] vdpa/mlx5: set polling mode default delay to zero

2021-01-08 Thread Maxime Coquelin
On 12/3/20 12:36 AM, Xueming Li wrote: > To improve throughput and latency, this patch allows Rx polling timer > delay to 0us. > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > doc/guides/vdpadevs/mlx5.rst | 3 +-- > drivers/vdpa/mlx5/mlx5_vdpa.c | 9 +++-- > 2 files changed

Re: [dpdk-dev] [PATCH 2/4] vdpa/mlx5: default polling mode delay time to zero

2021-01-08 Thread Maxime Coquelin
On 12/3/20 12:36 AM, Xueming Li wrote: > To improve performance and latency, this patch set Rx polling mode > default delay time to zero. > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > drivers/vdpa/mlx5/mlx5_vdpa.h | 2 +- > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 3 ++- >

Re: [dpdk-dev] [PATCH 3/4] vdpa/mlx5: add cpu core parameter to bind polling thread

2021-01-08 Thread Maxime Coquelin
On 12/3/20 12:36 AM, Xueming Li wrote: > This patch adds new device argument to specify cpu core affinity to > event polling thread for better latency and throughput. The thread > could be also located by name "vDPA-mlx5-". > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > doc/gu

Re: [dpdk-dev] [PATCH 4/4] vdpa/mlx5: set default event mode to polling

2021-01-08 Thread Maxime Coquelin
On 12/3/20 12:36 AM, Xueming Li wrote: > For better performance and latency, this patch sets default event > handling mode to polling mode which uses dedicate thread per device to > poll and process event. > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > doc/guides/vdpadevs/mlx5

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix run close(0) and close callfd

2021-01-08 Thread Maxime Coquelin
On 12/11/20 6:11 PM, Jiawei Zhu wrote: > From: Jiawei Zhu > > When i < VIRTIO_MAX_VIRTQUEUES and j == i, > dev->callfds[i] and dev->kickfds[i] are default 0. > So it will close(0), close the standard input (stdin). > And when the code fails in kickfd creation, > it will leaves one callfd not c

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix advertising of protocol features

2021-01-08 Thread Maxime Coquelin
On 12/18/20 2:23 PM, Olivier Matz wrote: > When connected to a vhost-user backend, the flag > VHOST_USER_F_PROTOCOL_FEATURES is not advertised, preventing to do > multiqueue (the VHOST_USER_PROTOCOL_F_MQ protocol feature is ignored by > some backends if the VHOST_USER_F_PROTOCOL_FEATURES feature

Re: [dpdk-dev] [PATCH v1 0/8] replace smp barriers in vhost with C11 atomic

2021-01-08 Thread Maxime Coquelin
On 12/21/20 4:50 PM, Joyce Kong wrote: > This patchset is to replace rte smp barriers in vhost with C11 atomic > built-ins. > > The rte_smp_*mb APIs provide full barrier functionality. However, many > use cases do not require full barriers. To support such use cases, DPDK > will adopt C11 barri

Re: [dpdk-dev] [PATCH v1 0/4] replace smp barriers in virtio with C11 atomic

2021-01-08 Thread Maxime Coquelin
On 12/21/20 3:23 PM, Joyce Kong wrote: > This patchset is to replace rte smp barriers in virtio with C11 atomic > built-ins. > > The rte_smp_*mb APIs provide full barrier functionality. However, many > use cases do not require full barriers. To support such use cases, DPDK > will adopt C11 barr

Re: [dpdk-dev] [PATCH v2 0/3] vhost: vhost_user_set_mem_table refactoring

2021-01-08 Thread Maxime Coquelin
On 1/5/21 1:57 PM, Maxime Coquelin wrote: > The goal of this series is to refactor vhost_user_set_mem_table > function, to make it easier to understand and maintain. > > Changes in v2: > == > - Tag unused args when userfaultfd disabled (Chenbo). > > Maxime Coquelin (3): > vhost:

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: support vDPA completion queue moderation

2021-01-08 Thread Maxime Coquelin
On 1/6/21 4:06 AM, Xueming Li wrote: > This patch introduces new parameters for VirtQ CQ moderation, used for > performance tuning. > > Signed-off-by: Xueming Li > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ > drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ > drivers/common/mlx5/mlx5_pr

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: hardware queue moderation

2021-01-08 Thread Maxime Coquelin
On 1/6/21 4:06 AM, Xueming Li wrote: > The next parameters control the HW queue moderation feature. > This feature helps to control the traffic performance and latency > tradeoff. > > Each packet completion report from HW to SW requires CQ processing by SW > and triggers interrupt for the guest

Re: [dpdk-dev] [PATCH v2] net/virtio: improve logs in Vhost-vDPA DMA mapping

2021-01-08 Thread Maxime Coquelin
On 1/5/21 4:34 PM, Maxime Coquelin wrote: > This patch adds debug logs in vhost_vdpa_dma_map() and > vhost_vdpa_dma_unmap() to ease debugging. > > Signed-off-by: Maxime Coquelin > --- > > Changes in v2: > - fix i686 build (Chenbo) > > drivers/net/virtio/virtio_user/vhost_vdpa.c | 6 ++

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Ferruh Yigit
On 1/7/2021 1:33 PM, Thomas Monjalon wrote: 07/01/2021 13:47, Zhang, Qi Z: -Original Message- From: Thomas Monjalon Sent: Thursday, January 7, 2021 6:12 PM To: Guo, Jia Cc: Zhang, Qi Z ; Wu, Jingjing ; Yang, Qiming ; Wang, Haiyue ; dev@dpdk.org; Yigit, Ferruh ; andrew.rybche...@oktet

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Andrew Rybchenko
On 1/8/21 11:57 AM, Ferruh Yigit wrote: On 1/8/2021 1:41 AM, Zhang, Qi Z wrote: -Original Message- From: Thomas Monjalon Sent: Friday, January 8, 2021 12:59 AM To: Guo, Jia ; Zhang, Qi Z Cc: Wu, Jingjing ; Yang, Qiming ; Wang, Haiyue ; dev@dpdk.org; Yigit, Ferruh ; andrew.rybche...@

[dpdk-dev] [PATCH v8 0/4] raw/ifpga: add extra OPAE APIs

2021-01-08 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v7: - Add guide document for how to run ifpga example Wei

[dpdk-dev] [PATCH v8 1/4] raw/ifpga: add fpga rsu function

2021-01-08 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates flash with specific image file. 2. ifpga_

[dpdk-dev] [PATCH v8 2/4] raw/ifpga: add fpga property get function

2021-01-08 Thread Wei Huang
There are three types of property can be got from FPGA, they are implemented in below functions: 1. ifpga_rawdev_get_fme_property() get property of FME (FPGA Management Engine). 2. ifpga_rawdev_get_port_property() get property of FPGA port. 3. ifpga_rawdev_get_bmc_property() get property of BMC

[dpdk-dev] [PATCH v8 3/4] raw/ifpga: add opae API for Cyborg

2021-01-08 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE type APIs to manage PACs (Programmable Acceleration Card) with Intel FPGA. Below major functions are added to meets Cyborg requirements. 1. opae_init_eal() set up EAL environment. 2. opae_cleanup_eal() clean up EAL environment. 3. opae_enumerate() sea

[dpdk-dev] [PATCH v8 4/4] examples/ifpga: add example for opae ifpga API

2021-01-08 Thread Wei Huang
An example application shows how to use opae ifpga APIs. You can test each API by running corresponding command. A guide is also added to show how to run the example. Signed-off-by: Wei Huang --- v2: fix coding style issue in commands.c --- v3: add guide for running example --- doc/guides/sample

[dpdk-dev] [PATCH v3 0/2] Vhost-vDPA fixes

2021-01-08 Thread Maxime Coquelin
Vhost-vDPA support in Virtio-user PMD was lacking backend features negotiation and IOTLB batching support, causing intialization issues with Mellanox vDPA device managed by Kernel vDPA framework. Changes in v3: = - Fix protocol features negotiation condition (Chenbo) - Fixup comment in

[dpdk-dev] [PATCH v3 1/2] net/virtio: fix missing backend features negotiation

2021-01-08 Thread Maxime Coquelin
This patch adds missing backend features negotiation for in Vhost-vDPA. Without it, IOTLB messages v2 could be sent by Virtio-user PMD while not supported by the backend. Fixes: 6b901437056e ("net/virtio: introduce vhost-vDPA backend") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- driv

[dpdk-dev] [PATCH v3 2/2] net/virtio: fix memory init with vDPA backend

2021-01-08 Thread Maxime Coquelin
This patch fixes an overhead met with mlx5-vdpa Kernel driver, where for every page in the mapped area, all the memory tables gets updated. For example, with 2MB hugepages, a single IOTLB_UPDATE for a 1GB region causes 512 memory updates on mlx5-vdpa side. Using batching mode, the mlx5 driver will

[dpdk-dev] [RFC] app/testpmd: support multi-process

2021-01-08 Thread Lijun Ou
This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./testpmd -w xxx --file-prefix=xx -l 0-1 -n 2 -- -i\ --rxq=16 --txq=16 --num-procs=2 --proc-id=0 the secondary cmd: ./testpmd -w xxx --file-prefix=xx -l 2-3 -n 2 -- -i\ --rxq=16 --txq=16 --num-procs

Re: [dpdk-dev] [PATCH 1/4] vdpa/mlx5: set polling mode default delay to zero

2021-01-08 Thread Xueming(Steven) Li
Hi Maxime, >-Original Message- >From: Maxime Coquelin >Sent: Friday, January 8, 2021 5:13 PM >To: Xueming(Steven) Li ; Matan Azrad >; Slava Ovsiienko >Cc: dev@dpdk.org; Asaf Penso >Subject: Re: [PATCH 1/4] vdpa/mlx5: set polling mode default delay to zero > > > >On 12/3/20 12:36 AM, Xue

[dpdk-dev] [PATCH] net/iavf: fix vector id assignment

2021-01-08 Thread dapengx . yu
From: YU DAPENG The number of MSI-X interrupts on Rx shall be the minimal value of the number of available MSI-X interrupts per VF - 1 (the 1 is for miscellaneous interrupt) and the number of configured Rx queues. The current code break the rule because the number of available MSI-X interrupts is

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Thomas Monjalon
08/01/2021 10:22, Ferruh Yigit: > On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > > 07/01/2021 13:47, Zhang, Qi Z: > >> From: Thomas Monjalon > >>> 07/01/2021 10:32, Guo, Jia: > From: Thomas Monjalon > > Sorry, it is a nack. > > BTW, it is probably breaking the ABI because of RTE_TUNNE

Re: [dpdk-dev] [RFC] app/testpmd: support multi-process

2021-01-08 Thread Ferruh Yigit
On 1/8/2021 9:46 AM, Lijun Ou wrote: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./testpmd -w xxx --file-prefix=xx -l 0-1 -n 2 -- -i\ --rxq=16 --txq=16 --num-procs=2 --proc-id=0 the secondary cmd: ./testpmd -w xxx --file-prefix=xx -l 2-3 -n

Re: [dpdk-dev] [EXT] [PATCH v2 4/5] common/octeontx2: fix build with sve enabled

2021-01-08 Thread Pavan Nikhilesh Bhagavatula
Hi Ruifeng, >Building with gcc 10.2 with SVE extension enabled got error: > >{standard input}: Assembler messages: >{standard input}:4002: Error: selected processor does not support `mov >z3.b,#0' >{standard input}:4003: Error: selected processor does not support >`whilelo p1.b,xzr,x7' >{standard

Re: [dpdk-dev] [dpdk-stable] [v21.02 v3 05/10] net/pcap: remove local variable shadowing outer one

2021-01-08 Thread David Marchand
On Thu, Nov 19, 2020 at 1:01 PM Ferruh Yigit wrote: > > 'ret' is already defined in the function scope, removing the 'ret' in > the block scope. > > Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit Reviewed-by: David M

Re: [dpdk-dev] [v21.02 v3 06/10] net/bonding: remove local variable shadowing outer one

2021-01-08 Thread David Marchand
On Thu, Nov 19, 2020 at 1:01 PM Ferruh Yigit wrote: > > 'retval' is already defined in the function scope, removing the 'retval' > in the block scope. > > Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit Reviewed-

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Thomas Monjalon
08/01/2021 10:29, Andrew Rybchenko: > On 1/8/21 11:57 AM, Ferruh Yigit wrote: > > On 1/8/2021 1:41 AM, Zhang, Qi Z wrote: > >> From: Thomas Monjalon > >>> 07/01/2021 16:24, Zhang, Qi Z: > From: Thomas Monjalon > > 07/01/2021 13:47, Zhang, Qi Z: > >> From: Thomas Monjalon > >>> 0

Re: [dpdk-dev] [v21.02 v3 01/10] app/procinfo: fix redundant condition

2021-01-08 Thread David Marchand
On Thu, Nov 19, 2020 at 12:59 PM Ferruh Yigit wrote: > > '_filters' is compared twice, second one will be always false, removing > it using the message more relevant to the '_filters'. > > Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") > Cc: sta...@dpdk.org > > Signed-off-by

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Ferruh Yigit
On 1/8/2021 10:23 AM, Thomas Monjalon wrote: 08/01/2021 10:22, Ferruh Yigit: On 1/7/2021 1:33 PM, Thomas Monjalon wrote: 07/01/2021 13:47, Zhang, Qi Z: From: Thomas Monjalon 07/01/2021 10:32, Guo, Jia: From: Thomas Monjalon Sorry, it is a nack. BTW, it is probably breaking the ABI because

[dpdk-dev] 回复: [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-08 Thread Feifei Wang
Hi, Pavan > -邮件原件- > 发件人: Pavan Nikhilesh Bhagavatula > 发送时间: 2021年1月8日 17:13 > 收件人: Feifei Wang ; jer...@marvell.com; Harry > van Haaren > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; sta...@dpdk.org; Ruifeng Wang > ; nd ; nd > 主题: RE: [RFC PATCH v1 4/6] app/eventdev: add release ba

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-08 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Hi, Pavan > >> -邮件原件- >> 发件人: Pavan Nikhilesh Bhagavatula >> 发送时间: 2021年1月8日 17:13 >> 收件人: Feifei Wang ; jer...@marvell.com; >Harry >> van Haaren >> 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli >> ; sta...@dpdk.org; Ruifeng Wang >> ; nd ; nd >> 主题: RE: [RFC PATCH v1 4/6] app/

Re: [dpdk-dev] [PATCH v2 04/35] common/mlx5/windows: add DevX UAR getters

2021-01-08 Thread Ferruh Yigit
On 12/28/2020 12:32 PM, Tal Shnaiderman wrote: From: Ophir Munk The following getters are added: mlx5_os_get_devx_uar_mmap_offset, mlx5_os_get_devx_uar_base_addr, mlx5_os_get_devx_uar_reg_addr, mlx5_os_get_devx_uar_page_id. This commit is the Windows equivalent of the Linux implementation in [

Re: [dpdk-dev] [PATCH v3 2/8] app/testpmd: add GENEVE option item support

2021-01-08 Thread Suanming Mou
Hi, > -Original Message- > From: dev On Behalf Of Shiri Kuzin > Sent: Thursday, January 7, 2021 4:39 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; NBU-Contact-Adrien Mazarguil > ; Ori Kam ; > ferruh.yi...@intel.com; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh > Subject: [dpdk-dev] [

Re: [dpdk-dev] [RFC] ethdev: introduce copy_field rte flow action

2021-01-08 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 7, 2021 19:06 > To: Alexander Kozyrev > Cc: dev@dpdk.org; Slava Ovsiienko ; Ori Kam > ; ferruh.yi...@intel.com; > andrew.rybche...@oktetlabs.ru; ajit.khapa...@broadcom.com; > jer...@marvell.com > Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH v3 2/8] app/testpmd: add GENEVE option item support

2021-01-08 Thread Slava Ovsiienko
Hi, > -Original Message- > From: Suanming Mou > Sent: Friday, January 8, 2021 14:11 > To: Shiri Kuzin ; dev@dpdk.org > Cc: Slava Ovsiienko ; NBU-Contact-Adrien Mazarguil > ; Ori Kam ; > ferruh.yi...@intel.com; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh > Subject: RE: [dpdk-dev] [PA

[dpdk-dev] VIRTIO PMD DRVIER

2021-01-08 Thread kumaraparameshwaran rathinavel
Hi All, In drivers/net/virtio/virtio_ethdev.c, I see that that drv_flags is set to 0 and not other flags (RTE_PCI_DRV_NEED_MAPPING). Is this intended? I understand internally that when the vtpci_init is called the mapping is done. Is the value set to 0 to avoid mapping two times? 2170 static str

[dpdk-dev] [PATCH v8] raw/ioat: add secondary process support

2021-01-08 Thread Kumar Amber
Add support for secondary processes in ioat devices. The update allocates a memzone for a primary process or returns it in a secondary process. Signed-off-by: Kumar Amber --- v5 * add error check for memzone lookup v6 * fix compilation v7 * include dev ops for secondary v8 * fix wrong memzone al

Re: [dpdk-dev] [PATCH v8] raw/ioat: add secondary process support

2021-01-08 Thread Bruce Richardson
On Fri, Jan 08, 2021 at 07:14:56PM +0530, Kumar Amber wrote: > Add support for secondary processes in ioat devices. The update > allocates a memzone for a primary process or returns it in a > secondary process. > > Signed-off-by: Kumar Amber > > --- > v5 > * add error check for memzone lookup >

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Thomas Monjalon
08/01/2021 11:43, Ferruh Yigit: > On 1/8/2021 10:23 AM, Thomas Monjalon wrote: > > 08/01/2021 10:22, Ferruh Yigit: > >> On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > >>> 07/01/2021 13:47, Zhang, Qi Z: > From: Thomas Monjalon > > 07/01/2021 10:32, Guo, Jia: > >> From: Thomas Monjalon

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Thomas Monjalon
08/01/2021 15:07, Kinsella, Ray: > From: Thomas Monjalon > > 08/01/2021 11:43, Ferruh Yigit: > > > On 1/8/2021 10:23 AM, Thomas Monjalon wrote: > > > > 08/01/2021 10:22, Ferruh Yigit: > > > >> On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > > > >>> 07/01/2021 13:47, Zhang, Qi Z: > > > From: Tho

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-08 Thread Ferruh Yigit
On 1/8/2021 12:38 PM, Kinsella, Ray wrote: -Original Message- From: Thomas Monjalon Sent: Friday 8 January 2021 10:24 To: Guo, Jia ; Zhang, Qi Z ; Yigit, Ferruh Cc: Wu, Jingjing ; Yang, Qiming ; Wang, Haiyue ; dev@dpdk.org; andrew.rybche...@oktetlabs.ru; or...@nvidia.com; getel...@nv

[dpdk-dev] [PATCH 0/6] power: fix make build for power apps

2021-01-08 Thread David Hunt
The power example applications that uses the virtio-serial method of communication cannot currently be built with make, and can only be built using meson/ninja. The guest channel message definitions and functions in guest_channel.h are needed by applications and need to be made public. This worke

[dpdk-dev] [PATCH v2 1/6] power: create guest channel public header file

2021-01-08 Thread David Hunt
From: Bruce Richardson In preparation for making the header file public, we first rename channel_commands.h as rte_power_guest_channel.h. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH v2 3/6] power: rename public structs

2021-01-08 Thread David Hunt
From: Bruce Richardson rename the public structs to have an rte_power_ prefix. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Signed-off-by: David Hunt -

[dpdk-dev] [PATCH v2 4/6] power: rename defines

2021-01-08 Thread David Hunt
From: Bruce Richardson Rename the #defines to have an RTE_POWER_ prefix Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Signed-off-by: David Hunt --- exa

[dpdk-dev] [PATCH v2 5/6] power: add new header file to export list

2021-01-08 Thread David Hunt
From: Bruce Richardson Adjust meson.build so that 'ninja install' copies the new header file into the installation directory. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v2 2/6] power: make channel msg functions public

2021-01-08 Thread David Hunt
From: Bruce Richardson Move the 2 public functions into rte_power_guest_channel.h Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Signed-off-by: David Hunt

[dpdk-dev] [PATCH v2 6/6] power: clean up includes

2021-01-08 Thread David Hunt
From: Bruce Richardson re-organise the including of the new public header file and remove un-needed includes Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2 24/35] net/mlx5/windows: introduce flow support

2021-01-08 Thread Ferruh Yigit
On 12/28/2020 12:32 PM, Tal Shnaiderman wrote: From: Ophir Munk This patch adds the initial flow framework under Windows OS. It supports a subset of filters (ETH, IPV4, UDP) and a QUEUE action. It is based on DevX mechanism to send commands to the NIC through the kernel. It does not support st

[dpdk-dev] [PATCH v1 0/7] eal: support global syntax

2021-01-08 Thread Xueming Li
New Global device syntax [1] is used to identify a device with full bus, class and driver description, example: -a bus=pci,id=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 This patch enables global syntax with backward compatibility by trying new global syntax firstly and fallback to legacy parsing.

[dpdk-dev] [PATCH v1 1/7] devargs: fix data buffer storage type

2021-01-08 Thread Xueming Li
The data field fo struct devargs is used as data scratch buffer, not a const, remove. Also fixes references to data field of struct devargs. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization") Cc: gaetan.ri...

[dpdk-dev] [PATCH v1 2/7] devargs: fix memory leak on parsing error

2021-01-08 Thread Xueming Li
This patch fixes memory leak in parsing error handling. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_devargs.c | 5 + 1 file changed, 5 insertions(+) diff -

Re: [dpdk-dev] [PATCH v2 24/35] net/mlx5/windows: introduce flow support

2021-01-08 Thread Thomas Monjalon
08/01/2021 15:38, Ferruh Yigit: > On 12/28/2020 12:32 PM, Tal Shnaiderman wrote: > > From: Ophir Munk > > > > This patch adds the initial flow framework under Windows OS. It supports > > a subset of filters (ETH, IPV4, UDP) and a QUEUE action. It is based on > > DevX mechanism to send commands t

[dpdk-dev] [PATCH v1 3/7] devargs: fix memory leak in legacy parser

2021-01-08 Thread Xueming Li
Data field was designed as parser buffer, will be released once in releasing struct memory. The duplicated device arguments was not saved to data and this caused memory leak. This patch fixes this leak by saving to new allocated memory to data field. Fixes: 4969f5914c9e ("devargs: introduce new p

[dpdk-dev] [PATCH v1 4/7] devargs: fix buffer data memory leak

2021-01-08 Thread Xueming Li
Struct rte_devargs data buffer was changed from args to data field, not all references were changed accordingly, memory leak happened when releasing devargs. Free data field of devargs struct. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta.

[dpdk-dev] [PATCH v1 5/7] kvargs: add get by key function

2021-01-08 Thread Xueming Li
Adds a new function to get value of a specific key from kvargs list. Signed-off-by: Xueming Li --- lib/librte_kvargs/rte_kvargs.c | 20 lib/librte_kvargs/rte_kvargs.h | 14 ++ lib/librte_kvargs/version.map | 1 + 3 files changed, 35 insertions(+) diff --git a/

[dpdk-dev] [PATCH v1 6/7] devargs: support new global device syntax

2021-01-08 Thread Xueming Li
When parsing a device syntax, try to parse new global syntax firstly, then try to parse as legacy syntax if failed. Example of new global syntax: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_devargs.c | 17 +++

[dpdk-dev] [PATCH v1 7/7] bus/pci: add new global device syntax support

2021-01-08 Thread Xueming Li
With new global device syntax, this patch tries to get PCI BDF firstly from bus "addr" argument, fallback to name if not found. Example: -w bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 Signed-off-by: Xueming Li --- drivers/bus/pci/pci_common.c | 18 +++--- 1 file changed

[dpdk-dev] [PATCH v1 1/2] common/mlx5: support device global syntax

2021-01-08 Thread Xueming Li
This patch support new device global syntax: bus=,k=v,,,/class=,k=v,,,/driver=,k=v To reuse class name of global syntax, this patch also changes internal class name introduced by commit [1] to algin with RTE class name. [1] 8a41f4deccc3: common/mlx5: introduce layer for multiple class drivers

[dpdk-dev] [PATCH v1 0/2] mlx5: support global syntax

2021-01-08 Thread Xueming Li
New Global device syntax [1] is used to identify a device with full bus, class and driver description, example: -a bus=pci,id=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 This patchset enables global syntax in mlx5 PMD. Depends-on: patch-86058 ("ethdev: refactor representor infrastructure") Depen

[dpdk-dev] [PATCH v1 2/2] net/mlx5: support new device global syntax

2021-01-08 Thread Xueming Li
This patch support new device global syntax like: bus=pci,addr=BB:DD.F/class=eth/driver=mlx5,devargs,.. Ignore "driver" key as part of new global device syntax in devargs. The representor devarg is supposed to come from either class section or driver section. Signed-off-by: Xueming Li -

Re: [dpdk-dev] [PATCH v2 04/35] common/mlx5/windows: add DevX UAR getters

2021-01-08 Thread Ophir Munk
> -Original Message- > From: Ferruh Yigit > Sent: Friday, January 8, 2021 2:08 PM > To: Tal Shnaiderman ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Raslan Darawsheh ; Ophir > Munk > Subject: Re: [dpdk-dev] [PATCH v2 04/35] common/mlx5/windows: add DevX > UAR gette

Re: [dpdk-dev] [PATCH v2 24/35] net/mlx5/windows: introduce flow support

2021-01-08 Thread Ophir Munk
The following lines were originally removed from the commit message and should not have been sent (please consider it a typo mistake): * Alarm API: mlx5_os_alarm_cancel() and mlx5_os_alarm_set() are implemented in Windows to match their Linux counterpart, see [1]. Currently they return -ENOTSUP.

[dpdk-dev] [PATCH v9] raw/ioat: add secondary process support

2021-01-08 Thread Kumar Amber
Add support for secondary processes in ioat devices. The update allocates a memzone for a primary process or returns it in a secondary process. Signed-off-by: Kumar Amber --- v5 * add error check for memzone lookup v6 * fix compilation v7 * include dev ops for secondary v8 * fix wrong memzone al

Re: [dpdk-dev] [PATCH v12 06/11] ethdev: add simple power management API

2021-01-08 Thread Burakov, Anatoly
On 28-Dec-20 11:00 AM, Andrew Rybchenko wrote: On 12/17/20 5:05 PM, Anatoly Burakov wrote: From: Liang Ma Add a simple API to allow getting the monitor conditions for power-optimized monitoring of the RX queues from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signe

Re: [dpdk-dev] [PATCH v12 00/11] Add PMD power management

2021-01-08 Thread Burakov, Anatoly
On 17-Dec-20 4:12 PM, David Marchand wrote: On Thu, Dec 17, 2020 at 3:06 PM Anatoly Burakov wrote: This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive. This is achieved through cooperation with the NIC d

[dpdk-dev] [PATCH v9] raw/ioat: add secondary process support

2021-01-08 Thread Kumar Amber
Add support for secondary processes in ioat devices. The update allocates a memzone for a primary process or returns it in a secondary process. Signed-off-by: Kumar Amber --- v5 * add error check for memzone lookup v6 * fix compilation v7 * include dev ops for secondary v8 * fix wrong memzone al

Re: [dpdk-dev] [PATCH v1 2/4] net/virtio: add vectorized packed ring Rx NEON path

2021-01-08 Thread Ferruh Yigit
On 11/17/2020 10:06 AM, Joyce Kong wrote: + /** +* Update data length and packet length for descriptor. +* structure of pkt_mb: +* +* |32 bits pkt_type|32 bits pkt_len|16 bits data_len|1

  1   2   >