08/01/2021 10:22, Ferruh Yigit: > On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > > 07/01/2021 13:47, Zhang, Qi Z: > >> From: Thomas Monjalon <tho...@monjalon.net> > >>> 07/01/2021 10:32, Guo, Jia: > >>>> From: Thomas Monjalon <tho...@monjalon.net> > >>>>> Sorry, it is a nack. > >>>>> BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX. > >> > >> Yes that may break the ABI but fortunately the checking-abi-compatibility > >> tool shows negative :) , thanks Ferruh' s guide. > >> https://github.com/ferruhy/dpdk/actions/runs/468859673 > > > > That's very strange. An enum value is changed. > > Why it is not flagged by libabigail? > > As long as the enum values not sent to the application and kept within the > library, changing their values shouldn't be problem.
But RTE_TUNNEL_TYPE_MAX is part of lib/librte_ethdev/rte_ethdev.h so it is exposed to the application. I think it is a case of ABI breakage.
