Re: [dpdk-dev] [PATCH v2 16/22] net/ixgbe: fix the jumbo frame flag condition

2020-12-17 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Steve Yang > Sent: Thursday, December 17, 2020 5:23 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; asoma...@amd.com; > rahul.lakkire...@chelsio.com; hemant.agra...@nxp.com; > sachin.sax...@oss.nxp.com; Guo

Re: [dpdk-dev] [PATCH v2 07/22] net/i40e: fix the jumbo frame flag condition

2020-12-17 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Steve Yang > Sent: Thursday, December 17, 2020 5:23 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; asoma...@amd.com; > rahul.lakkire...@chelsio.com; hemant.agra...@nxp.com; > sachin.sax...@oss.nxp.com; Guo

Re: [dpdk-dev] 19.11.6 patches review and test

2020-12-17 Thread Yu, DapengX
Hi Luca, The patch "net/iavf: enable port reset" has been validated by the QA team, and confirmed the test case passes. Best regards, Yu Dapeng -Original Message- From: Luca Boccassi [mailto:bl...@debian.org] Sent: Thursday, December 17, 2020 7:00 PM To: Yu, PingX ; Chen, BoX C ; sta.

[dpdk-dev] [PATCH v2] net/iavf: fix negative GTP-U flow rules create successfully

2020-12-17 Thread Murphy Yang
Currently, when use 'flow' command to create a negative GTP-U rule, it will be created successfully. The list shows the impacted outer and inner 'ipv4' GTP-U patterns with 'ipv4' or 'gtpu' type: - iavf_pattern_eth_ipv4_gtpu_ipv4_udp - iavf_pattern_eth_ipv4_gtpu_eh_ipv4_udp - iavf_pattern_eth_ip

Re: [dpdk-dev] [PATCH 2/7] net/hns3: fix xstats statistics with id

2020-12-17 Thread oulijun
在 2020/12/17 23:20, Ferruh Yigit 写道: On 12/13/2020 8:03 AM, Lijun Ou wrote: From: Huisong Li Number of xstats item in rte_eth_xstats_get_by_id is obtained by the eth_dev_get_xstats_count API, and the xstats_get_by_id ops of the driver only needs to report the corresponding stats item result

Re: [dpdk-dev] [PATCH] net/i40e: fix Rx-bytes statistics

2020-12-17 Thread Zhou, JunX W
Tested-by: Zhou, Jun -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang,Alvin Sent: Tuesday, December 15, 2020 5:51 PM To: Guo, Jia ; Xing, Beilei Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH] net/i40e: fix Rx-bytes statistics

[dpdk-dev] [PATCH 0/9] Introduce vfio-user library

2020-12-17 Thread Chenbo Xia
This series enables DPDK to be an alternative I/O device emulation library of building virtualized devices in separate processes outside QEMU. It introduces a new library for device emulation (librte_vfio_user). *librte_vfio_user* library is an implementation of VFIO-over-socket[1] (also known as

[dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-17 Thread Chenbo Xia
This patch introduces vfio-user library, which follows vfio-user protocol v1.0. As vfio-user has server and client implementaion, this patch introduces basic structures and internal functions that will be used by both server and client. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- MA

[dpdk-dev] [PATCH 2/9] vfio_user: implement lifecycle related APIs

2020-12-17 Thread Chenbo Xia
This patch implements three lifecycle related APIs for vfio-user server, which are rte_vfio_user_register(), rte_vfio_user_unregister() and rte_vfio_user_start(). Socket an device management is implemented along with the API introduction. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu ---

[dpdk-dev] [PATCH 3/9] vfio_user: implement device and region related APIs

2020-12-17 Thread Chenbo Xia
This patch introduces device and region related APIs, which are rte_vfio_user_set_dev_info() and rte_vfio_user_set_reg_info(). The corresponding vfio-user command handling is also added with the definition of all vfio-user command identity. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu ---

[dpdk-dev] [PATCH 4/9] vfio_user: implement DMA table and socket address API

2020-12-17 Thread Chenbo Xia
This patch introduces an API called rte_vfio_user_get_mem_table() for emulated devices to acquire DMA memory table from vfio-user library. Notify operations are also introduced to notify the emulated devices of several events. Another socket address API is introduced for translation between device

[dpdk-dev] [PATCH 5/9] vfio_user: implement interrupt related APIs

2020-12-17 Thread Chenbo Xia
This patch implements two interrupt related APIs, which are rte_vfio_user_get_irq() and rte_vfio_user_set_irq_info(). The former is for devices to get interrupt configuration (e.g., irqfds). The latter is for setting interrupt information before vfio-user starts. Signed-off-by: Chenbo Xia Signed-

[dpdk-dev] [PATCH 6/9] vfio_user: add client APIs of device attach/detach

2020-12-17 Thread Chenbo Xia
This patch implements two APIs, rte_vfio_user_attach_dev() and rte_vfio_user_detach_dev() for vfio-user client to connect to or disconnect from a vfio-user device on server side. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- lib/librte_vfio_user/meson.build| 3 +- lib/librte

[dpdk-dev] [PATCH 7/9] vfio_user: add client APIs of DMA/IRQ/region

2020-12-17 Thread Chenbo Xia
This patch introduces nine APIs - Device related: rte_vfio_user_get_dev_info and rte_vfio_user_reset - DMA related: rte_vfio_user_dma_map/unmap - Region related: rte_vfio_user_get_reg_info and rte_vfio_user_region_read/write - IRQ related: rte_vfio_user_get_irq_info and rte_vfio_user_set_ir

[dpdk-dev] [PATCH 8/9] test/vfio_user: introduce functional test

2020-12-17 Thread Chenbo Xia
This patch introduces functional test for vfio_user client and server. Note that the test can only be run with server and client both started and server should be started first. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- app/test/meson.build | 4 + app/test/test_vfio_user.c

[dpdk-dev] [PATCH 9/9] doc: add vfio-user library guide

2020-12-17 Thread Chenbo Xia
Add vfio-user library guide and update release notes. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/vfio_user_lib.rst | 215 doc/guides/rel_notes/release_21_02.rst | 11 ++ 3 files change

[dpdk-dev] [Bug 603] The variable drivers/regex/octeontx2/otx2_regexdev.c:pci_id_ree_table is not initialized, which will cause the global variable to overflow, which is a security risk.

2020-12-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=603 Bug ID: 603 Summary: The variable drivers/regex/octeontx2/otx2_regexdev.c:pci_id_ree_tab le is not initialized, which will cause the global variable to overflow, which is a

[dpdk-dev] [PATCH 0/4] regex/mlx5: pmd improvements

2020-12-17 Thread Ori Kam
This series adds a few fixes and improvements to the Nvidia RegEx PMD. Ori Kam (4): regex/mlx5: fix memory rule alignment regex/mlx5: add support for combined rule file regex/mlx5: fix support for group id regex/mlx5: add support for priority match drivers/regex/mlx5/mlx5_regex.c

[dpdk-dev] [PATCH 1/4] regex/mlx5: fix memory rule alignment

2020-12-17 Thread Ori Kam
Due to Kernel requirement the memory allocated must be aligned to 2M. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_rxp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regex/mlx5/mlx

[dpdk-dev] [PATCH 4/4] regex/mlx5: add support for priority match

2020-12-17 Thread Ori Kam
The high priority match request flags means that the RegEx engine should stop on the first match. This commit add this flag check to the RegEx engine. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex_fastpath.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH 3/4] regex/mlx5: fix support for group id

2020-12-17 Thread Ori Kam
In order to know which groups in the RegEx engine should be used there is a need to check the req_flags. This commit adds the missing check. Cc: sta...@dpdk.org Fixes: 4d4e245ad637 ("regex/mlx5: support enqueue") Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex_fastpath.c | 21 +++

[dpdk-dev] [PATCH 2/4] regex/mlx5: add support for combined rule file

2020-12-17 Thread Ori Kam
The rof file holds programming instructions for a given HW version. In order to support future generation of HW it was decided that the rof file will hold number of rule configurations, and the driver will use the one that matches the HW version. In current code we force sync after each write bloc

[dpdk-dev] [PATCH v2 1/1] devtools: adjust verbosity of ABI check

2020-12-17 Thread Thomas Monjalon
The scripts gen-abi.sh and check-abi.sh are updated to print error messages to stderr so they are likely never ignored. When called from test-meson-builds.sh, the standard messages on stdout can be more quiet depending on the verbosity settings. The beginning of the ABI check is announced in verbo

Re: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action

2020-12-17 Thread Chen, BoX C
Hi, Beilei If you merge this patch, some common rules will fail to set on fvl, such as: flow create 0 ingress pattern eth / ipv4 / udp / end actions rss types ipv4-udp end queues end / end Regards, Chen Bo > -Original Message- > From: Xing, Beilei > Sent: December 17, 2020 11:20 > To:

[dpdk-dev] [PATCH v2 00/22] fix rx packets dropped issue

2020-12-17 Thread Steve Yang
The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, this fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead. When the MTU(1500) set, the frame type of rx packet will be different if used different overhead, it will cause the consistency issue, and the normal p

[dpdk-dev] [PATCH v2 01/22] ethdev: fix MTU size exceeds max rx packet length

2020-12-17 Thread Steve Yang
If max rx packet length is smaller then MTU + Ether overhead, that will drop all MTU size packets. Update the MTU size according to the max rx packet and Ether overhead. Fixes: 59d0ecdbf0e1 ("ethdev: MTU accessors") Signed-off-by: Steve Yang --- lib/librte_ethdev/rte_ethdev.c | 21

[dpdk-dev] [PATCH v2 02/22] app/testpmd: fix max rx packet length for VLAN packets

2020-12-17 Thread Steve Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Removed the rx_offloads assignment for jumbo frame during command line parsing, and set the correct jumbo frame flag if MTU size is larger t

[dpdk-dev] [PATCH v2 03/22] net/dpaa: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead

[dpdk-dev] [PATCH v2 04/22] net/dpaa2: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead

[dpdk-dev] [PATCH v2 05/22] net/e1000: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead

[dpdk-dev] [PATCH v2 06/22] net/hns3: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'HSN3_DEFAULT_FRAME_LE

[dpdk-dev] [PATCH v2 07/22] net/i40e: fix the jumbo frame flag condition

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 08/22] net/iavf: fix the jumbo frame flag condition

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 09/22] net/ice: fix the jumbo frame flag condition

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 11/22] net/octeontx: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 13/22] net/qede: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 14/22] net/sfc: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU'. Fixes: ff6

[dpdk-dev] [PATCH v2 15/22] net/thunderx: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU' and ov

[dpdk-dev] [PATCH v2 16/22] net/ixgbe: fix the jumbo frame flag condition

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v2 17/22] net/cxgbe: fix the jumbo frame flag condition

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v2 18/22] net/axgbe: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v2 19/22] net/enetc: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v2 20/22] net/hinic: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

[dpdk-dev] [PATCH v2 21/22] net/nfp: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU'. Fixes: d4a2

[dpdk-dev] [PATCH v2 22/22] net/liquidio: fix the jumbo frame flag condition for mtu set

2020-12-17 Thread Steve Yang
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will normalize the boundary condition with 'RTE_ETHER_MTU' and overhe

Re: [dpdk-dev] 19.11.6 patches review and test

2020-12-17 Thread Luca Boccassi
On Wed, 2020-12-16 at 20:34 +, Ali Alnubani wrote: > Hi, > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Thursday, December 3, 2020 11:39 AM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Akhil Goyal ; Ali Alnubani ; > > benjamin.wal...@intel

Re: [dpdk-dev] 19.11.6 patches review and test

2020-12-17 Thread Yu, PingX
+ Dapeng, > > > new issue: Failed to execute 'reset port 0' command on CVL VF. > > > > Qi and Qiming, can we have more details on this issue in the ICE pmd? > > Is it specific to 19.11 or was it observed on main too? Luca, This issue is for 19.11 specific and passed on main. We are working on

Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offload rules validation on VF representor.

2020-12-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Friday, December 11, 2020 4:46 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Slava Ovsiienko ; Shahaf Shuler > > Subject: [PATCH] net/mlx5: fix tunnel offload rules validation on

Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers

2020-12-17 Thread Luca Boccassi
On Wed, 2020-12-16 at 13:52 +, Ferruh Yigit wrote: > On 12/16/2020 1:41 PM, Liron Himi wrote: > > -Original Message- > > From: Ferruh Yigit > > Sent: Wednesday, 16 December 2020 15:37 > > To: Liron Himi > > Cc: dev@dpdk.org; Luca Boccassi ; Kevin Traynor > > ; Akhil Goyal > > Subjec

Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers

2020-12-17 Thread Ferruh Yigit
On 12/17/2020 10:06 AM, Luca Boccassi wrote: On Wed, 2020-12-16 at 13:52 +, Ferruh Yigit wrote: On 12/16/2020 1:41 PM, Liron Himi wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, 16 December 2020 15:37 To: Liron Himi Cc: dev@dpdk.org; Luca Boccassi ; Kevin Traynor ;

[dpdk-dev] [PATCH 0/2] regexdev: add new response flag

2020-12-17 Thread Ori Kam
The RegEx engine is using HW resources that may reach some limit for different reasons. In current API the RegEx can report only on max threads reached. This commit introduce a new flag to report to the app that some HW resource limit has been reached. Ori Kam (2): regexdev: add resource limit

[dpdk-dev] [PATCH 1/2] regexdev: add resource limit reached rsp flag

2020-12-17 Thread Ori Kam
When scanning a buffer it is possible that the scan will abort due to some internal resource limit. This commit adds such response flag, so application can handle such cases. Signed-off-by: Francis Kelly Signed-off-by: Ori Kam --- lib/librte_regexdev/rte_regexdev.h | 5 + 1 file changed, 5

[dpdk-dev] [PATCH 2/2] regex/mlx5: add regex response flags

2020-12-17 Thread Ori Kam
This commit propagate the response flags from the regex engine. Signed-off-by: Francis Kelly Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex_fastpath.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c

Re: [dpdk-dev] 19.11.6 patches review and test

2020-12-17 Thread Yu, DapengX
Hi All, The patch: net/iavf: enable port reset, has been sent to sta...@dpdk.org. Best regards, Yu Dapeng -Original Message- From: Yu, PingX Sent: Thursday, December 17, 2020 5:51 PM To: Luca Boccassi ; Chen, BoX C ; sta...@dpdk.org; Zhang, Qi Z ; Yang, Qiming ; Yu, DapengX Cc: dev@d

Re: [dpdk-dev] [dpdk-stable] [v1, 2/2] bonding: fix PCI address comparison on non-pci ports

2020-12-17 Thread Ferruh Yigit
On 12/16/2020 12:14 PM, Min Hu (Connor) wrote: Hi,     sorry for late reply.     I know what you mean. But "find_port_id_by_pci_addr" is one static type funtion. it is only used in the function "parse_port_id". what you modified in "find_port_id_by_pci_addr" is totally done before "find_port_id

Re: [dpdk-dev] 19.11.6 patches review and test

2020-12-17 Thread Luca Boccassi
On Thu, 2020-12-17 at 09:50 +, Yu, PingX wrote: > + Dapeng, > > > > > new issue: Failed to execute 'reset port 0' command on CVL VF. > > > > > > Qi and Qiming, can we have more details on this issue in the ICE pmd? > > > Is it specific to 19.11 or was it observed on main too? > Luca, > T

[dpdk-dev] [v2 PATCH] usertools: show an error message if unable to reserve requested hugepages

2020-12-17 Thread Sarosh Arif
Sometimes the system is unable to reserve the requested hugepages because enough space is not available in the RAM. In that case, currently the script displays no error message hence the user can be under the delusion that the hugepages he requested are all successfully reserved. This patch display

[dpdk-dev] DPDK Release Status Meeting 17/12/2020

2020-12-17 Thread Ferruh Yigit
Meeting minutes of 17 December 2020 --- Agenda: * Release Dates * Highlights * Subtrees * LTS * OvS * Opens Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * NXP * Red Hat Release Dates - * v21.02 dates * Proposal/V1:

[dpdk-dev] [PATCH v1] power: fix make build for power apps

2020-12-17 Thread David Hunt
From: Bruce Richardson The guest channel message definitions and commands in guest_channel.h file are needed by applications and need to be made public. This patch is needed because make is broken for the power_mgmt apps, as the channel commands API is private. This previously built within DPDK,

[dpdk-dev] [PATCH 05/17] net/mlx5: move rearm and clock queue CQ creation to common

2020-12-17 Thread Michael Baum
Using common function for CQ creation at rearm queue and clock queue. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 9 +-- drivers/net/mlx5/mlx5_rxtx.c | 2 +- drivers/net/mlx5/mlx5_txpp.c | 147 +++ 3 files chan

[dpdk-dev] [PATCH 03/17] regex/mlx5: move DevX CQ creation to common

2020-12-17 Thread Michael Baum
Using common function for DevX CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/regex/mlx5/mlx5_regex.c | 6 --- drivers/regex/mlx5/mlx5_regex.h | 9 +--- drivers/regex/mlx5/mlx5_regex_control.c | 91 ++-- drivers/regex/

[dpdk-dev] [PATCH 02/17] common/mlx5: share DevX CQ creation

2020-12-17 Thread Michael Baum
The CQ object in DevX is created in several places and in several different drivers. In all places almost all the details are the same, and in particular the allocations of the required resources. Add a structure that contains all the resources, and provide creation and release functions for it.

[dpdk-dev] [PATCH 04/17] vdpa/mlx5: move DevX CQ creation to common

2020-12-17 Thread Michael Baum
Using common function for DevX CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.h | 10 + drivers/vdpa/mlx5/mlx5_vdpa_event.c | 81 +++-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 2 +- 3 files changed, 26 inse

[dpdk-dev] [PATCH 01/17] net/mlx5: fix ASO SQ creation error flow

2020-12-17 Thread Michael Baum
In ASO SQ creation, the PMD allocates umem buffer for SQ. When umem buffer allocation is fails, the MR and CQ memory are not freed what caused a memory leak. Free it. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: M

[dpdk-dev] [PATCH 08/17] net/mlx5: move Rx CQ creation to common

2020-12-17 Thread Michael Baum
Using common function for Rx CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 8 --- drivers/net/mlx5/mlx5.h | 3 +- drivers/net/mlx5/mlx5_devx.c | 142 +-- drivers/net/mlx5/mlx5_rxtx.h | 4 -- 4

[dpdk-dev] [PATCH 06/17] net/mlx5: move ASO CQ creation to common

2020-12-17 Thread Michael Baum
Use common function for ASO CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 8 +--- drivers/net/mlx5/mlx5_flow_age.c | 81 +--- 2 files changed, 19 insertions(+), 70 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 17/17] common/mlx5: remove doorbell allocation API

2020-12-17 Thread Michael Baum
The mlx5_devx_dbr_page structure was used to allocate and release the umem of the doorbells. Since doorbell and buffer have used same umem, this structure is useless. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 122 --

[dpdk-dev] [PATCH 10/17] common/mlx5: share DevX SQ creation

2020-12-17 Thread Michael Baum
The SQ object in DevX is created in several places and in several different drivers. In all places almost all the details are the same, and in particular the allocations of the required resources. Add a structure that contains all the resources, and provide creation and release functions for it.

[dpdk-dev] [PATCH 07/17] net/mlx5: move Tx CQ creation to common

2020-12-17 Thread Michael Baum
Using common function for Tx CQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 6 +- drivers/net/mlx5/mlx5_devx.c | 182 +++ 2 files changed, 31 insertions(+), 157 deletions(-) diff --git a/drivers/net/ml

[dpdk-dev] [PATCH 09/17] common/mlx5: enhance page size configuration

2020-12-17 Thread Michael Baum
The PRM calculates page size in 4K, so need to reduce the log_wq_pg_sz attribute. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 53 drivers/net/mlx5/mlx5_devx.c | 13 + 2 files changed, 30 insert

[dpdk-dev] [PATCH 00/17] common/mlx5: share DevX resources creations

2020-12-17 Thread Michael Baum
Due to many instances of creating CQ SQ and RQ on DevX, they move to common. Michael Baum (17): net/mlx5: fix ASO SQ creation error flow common/mlx5: share DevX CQ creation regex/mlx5: move DevX CQ creation to common vdpa/mlx5: move DevX CQ creation to common net/mlx5: move rearm and clo

[dpdk-dev] [PATCH 16/17] net/mlx5: move Rx RQ creation to common

2020-12-17 Thread Michael Baum
Using common function for Rx RQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 4 +- drivers/net/mlx5/mlx5_devx.c | 178 +-- drivers/net/mlx5/mlx5_rxtx.h | 4 - 3 files changed, 37 insertions(+), 149 del

[dpdk-dev] [PATCH 14/17] net/mlx5: move ASO SQ creation to common

2020-12-17 Thread Michael Baum
Using common function for ASO SQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_devx.h | 1 + drivers/net/mlx5/mlx5.h| 8 +-- drivers/net/mlx5/mlx5_flow_age.c | 94 ++ 3 files changed, 30 in

[dpdk-dev] [PATCH 15/17] common/mlx5: share DevX RQ creation

2020-12-17 Thread Michael Baum
The RQ object in DevX is used currently only in net driver, but it share for future. Add a structure that contains all the resources, and provide creation and release functions for it. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_devx.c | 116 ++

[dpdk-dev] [PATCH 11/17] regex/mlx5: move DevX SQ creation to common

2020-12-17 Thread Michael Baum
Using common function for DevX SQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/regex/mlx5/mlx5_regex.h | 8 +- drivers/regex/mlx5/mlx5_regex_control.c | 153 ++- drivers/regex/mlx5/mlx5_regex_fastpath.c | 14 +-- 3 files change

[dpdk-dev] [PATCH 13/17] net/mlx5: move Tx SQ creation to common

2020-12-17 Thread Michael Baum
Using common function for Tx SQ creation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 8 +-- drivers/net/mlx5/mlx5_devx.c | 160 ++- 2 files changed, 40 insertions(+), 128 deletions(-) diff --git a/drivers/net/m

[dpdk-dev] [PATCH 12/17] net/mlx5: move rearm and clock queue SQ creation to common

2020-12-17 Thread Michael Baum
Using common function for DevX SQ creation for rearm and clock queue. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 8 +-- drivers/net/mlx5/mlx5_txpp.c | 147 +++ 2 files changed, 36 insertions(+), 119 deletions(-)

Re: [dpdk-dev] [PATCH v1 0/6] regex multi Q with multi cores support

2020-12-17 Thread Ori Kam
Hi Ophir, You should also update the testregex.rst file. Best, Ori > -Original Message- > From: Ophir Munk > Sent: Wednesday, December 16, 2020 6:49 PM > Subject: [PATCH v1 0/6] regex multi Q with multi cores support > > This patchset enhances the regex application to support multi Q w

[dpdk-dev] 18.11.11 (LTS) patches review and test

2020-12-17 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.11. The planned date for the final release is 19th January. Note, this is the last planned release of 18.11 LTS, and it will be unmaintained after this release, so I encourage anyone who is using 18.11 LTS to test. Please help wit

Re: [dpdk-dev] [PATCH v3] meson: update meson build for armada drivers

2020-12-17 Thread Ferruh Yigit
On 12/16/2020 9:36 PM, lir...@marvell.com wrote: From: Liron Himi With pkg-config support available within musdk library (from musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' can be removed. PKG_CONFIG_PATH environment variable should be set appropriately to use the musdk

[dpdk-dev] [PATCH v12 00/11] Add PMD power management

2020-12-17 Thread Anatoly Burakov
This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive. This is achieved through cooperation with the NIC driver that will allow us to know address of wake up event, and wait for writes on it. On IA, this

[dpdk-dev] [PATCH v12 01/11] eal: uninline power intrinsics

2020-12-17 Thread Anatoly Burakov
Currently, power intrinsics are inline functions. Make them part of the ABI so that we can have various internal data associated with them without exposing said data to the outside world. Signed-off-by: Anatoly Burakov --- .../arm/include/rte_power_intrinsics.h| 6 +- .../include/gener

[dpdk-dev] [PATCH v12 02/11] eal: avoid invalid API usage in power intrinsics

2020-12-17 Thread Anatoly Burakov
Currently, the API documentation mandates that if the user wants to use the power management intrinsics, they need to call the `rte_cpu_get_intrinsics_support` API and check support for specific intrinsics. However, if the user does not do that, it is possible to get illegal instruction error beca

[dpdk-dev] [PATCH v12 03/11] eal: change API of power intrinsics

2020-12-17 Thread Anatoly Burakov
Instead of passing around pointers and integers, collect everything into struct. This makes API design around these intrinsics much easier. Signed-off-by: Anatoly Burakov --- drivers/event/dlb/dlb.c | 10 ++-- drivers/event/dlb2/dlb2.c | 10 ++-- .../arm

[dpdk-dev] [PATCH v12 05/11] eal: add monitor wakeup function

2020-12-17 Thread Anatoly Burakov
Now that we have everything in a C file, we can store the information about our sleep, and have a native mechanism to wake up the sleeping core. This mechanism would however only wake up a core that's sleeping while monitoring - waking up from `rte_power_pause` won't work. Signed-off-by: Anatoly B

[dpdk-dev] [PATCH v12 04/11] eal: remove sync version of power monitor

2020-12-17 Thread Anatoly Burakov
Currently, the "sync" version of power monitor intrinsic is supposed to be used for purposes of waking up a sleeping core. However, there are better ways to achieve the same result, so remove the unneeded function. Signed-off-by: Anatoly Burakov --- .../arm/include/rte_power_intrinsics.h

[dpdk-dev] [PATCH v12 06/11] ethdev: add simple power management API

2020-12-17 Thread Anatoly Burakov
From: Liang Ma Add a simple API to allow getting the monitor conditions for power-optimized monitoring of the RX queues from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v6: - Rebase on t

[dpdk-dev] [PATCH v12 07/11] power: add PMD power management API and callback

2020-12-17 Thread Anatoly Burakov
From: Liang Ma Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timest

[dpdk-dev] [PATCH v12 09/11] net/i40e: implement power management API

2020-12-17 Thread Anatoly Burakov
From: Liang Ma Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40

[dpdk-dev] [PATCH v12 08/11] net/ixgbe: implement power management API

2020-12-17 Thread Anatoly Burakov
From: Liang Ma Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 +

[dpdk-dev] [PATCH v12 10/11] net/ice: implement power management API

2020-12-17 Thread Anatoly Burakov
From: Liang Ma Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + dri

[dpdk-dev] [PATCH v12 11/11] examples/l3fwd-power: enable PMD power mgmt

2020-12-17 Thread Anatoly Burakov
From: Liang Ma Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- Notes: v6: - Fixed typos in documentation .../sample_app_ug/l3_forward_power_man.rst| 35 examples/l3fwd-power/main.c

Re: [dpdk-dev] [PATCH 1/2] eal/hotplug: allow monitor to be setup by multiple places

2020-12-17 Thread Luca Boccassi
On Mon, 2020-11-30 at 23:56 -0800, Long Li wrote: > From: Stephen Hemminger > > In some cases, a device or infrastructure may want to enable hotplug > but application may also try and start hotplug as well. Therefore > change the monitor_started from a boolean into a reference count. > > Signed-

Re: [dpdk-dev] [PATCH 2/7] net/hns3: fix xstats statistics with id

2020-12-17 Thread Ferruh Yigit
On 12/13/2020 8:03 AM, Lijun Ou wrote: From: Huisong Li Number of xstats item in rte_eth_xstats_get_by_id is obtained by the eth_dev_get_xstats_count API, and the xstats_get_by_id ops of the driver only needs to report the corresponding stats item result. However, a redundant code for reporting

Re: [dpdk-dev] [PATCH v12 00/11] Add PMD power management

2020-12-17 Thread David Marchand
On Thu, Dec 17, 2020 at 3:06 PM Anatoly Burakov wrote: > > This patchset proposes a simple API for Ethernet drivers to cause the > CPU to enter a power-optimized state while waiting for packets to > arrive. This is achieved through cooperation with the NIC driver that > will allow us to know addre

[dpdk-dev] [Bug 585] Direct PCI access violation with VFIO and lockdown mode

2020-12-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=585 Luca Boccassi (luca.bocca...@gmail.com) changed: What|Removed |Added Resolution|--- |INVALID Stat

[dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset

2020-12-17 Thread Simon Ellmann
ixgbe devices support up to 8 Rx and Tx queues per virtual function. Currently, the registers of only seven queues are set to default when resetting a VF. Signed-off-by: Simon Ellmann --- drivers/net/ixgbe/base/ixgbe_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[dpdk-dev] [PATCH 02/35] mlx5/windows: add mlx5 macros for fs name and path

2020-12-17 Thread Tal Shnaiderman
From: Ophir Munk ibdev_name and ibdev_path sizes are defined in Windows DevX differently from the sizes used in Linux with IBV_SYSFS_NAME_MAX and IBV_SYSFS_PATH_MAX. Added MLX5_FS_NAME_MAX and MLX5_FS_NAME_PATH in mlx5_os.h for both OSs. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --

  1   2   >