[dpdk-dev] [PATCH 0/2] gcc build fix

2020-11-27 Thread Ruifeng Wang
This series fixed issues found when building project with Gcc '-O0' option. Ruifeng Wang (2): eal/arm: fix gcc build for optimization level 0 net/igc: fix gcc build for optimization level 0 drivers/net/igc/base/meson.build | 3 ++- lib/librte_eal/arm/include/rte_atomic_64.h | 4 +++

[dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Ruifeng Wang
Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set failed for: ../lib/librte_efd/rte_efd.c Assembler messages: 3866: Error: selected processor does not support `crc32cb w0,w0,w1' 3890: Error: selected processor does not support `crc32ch w0,w0,w1' 3914: Error: selected processor do

[dpdk-dev] [PATCH 2/2] net/igc: fix gcc build for optimization level 0

2020-11-27 Thread Ruifeng Wang
Gcc build with '-O0' failed for: ../drivers/net/igc/base/igc_api.c Assembler messages: 29: Error: selected processor does not support `casp x0,x1,x2,x3,[x4]' 82: Error: selected processor does not support `caspa x0,x1,x2,x3,[x4]' 135: Error: selected processor does not support `caspl x0,x1,x2,x3,

Re: [dpdk-dev] [RFC PATCH v1] build: add platform meson option

2020-11-27 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Thursday, November 26, 2020 5:03 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; honnappa.nagaraha...@arm.com; dev@dpdk.org > Subject: Re: [RFC PATCH v1] build: add platform meson option > > On Thu, Nov 26, 2020 at 04:47:29PM +0100

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wrote: > > Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set > failed for: > ../lib/librte_efd/rte_efd.c > Assembler messages: > 3866: Error: selected processor does not support `crc32cb w0,w0,w1' > 3890: Error: selected processor doe

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Jerin Jacob
On Fri, Nov 27, 2020 at 2:09 PM David Marchand wrote: > > On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wrote: > > > > Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set > > failed for: > > ../lib/librte_efd/rte_efd.c > > Assembler messages: > > 3866: Error: selected processor do

Re: [dpdk-dev] [PATCH 2/2] net/igc: fix gcc build for optimization level 0

2020-11-27 Thread Jerin Jacob
On Fri, Nov 27, 2020 at 1:40 PM Ruifeng Wang wrote: > > Gcc build with '-O0' failed for: > ../drivers/net/igc/base/igc_api.c > Assembler messages: > 29: Error: selected processor does not support `casp x0,x1,x2,x3,[x4]' > 82: Error: selected processor does not support `caspa x0,x1,x2,x3,[x4]' >

Re: [dpdk-dev] [PATCH 2/2] net/igc: fix gcc build for optimization level 0

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wrote: > > Gcc build with '-O0' failed for: > ../drivers/net/igc/base/igc_api.c > Assembler messages: > 29: Error: selected processor does not support `casp x0,x1,x2,x3,[x4]' > 82: Error: selected processor does not support `caspa x0,x1,x2,x3,[x4]' >

Re: [dpdk-dev] [PATCH v1] doc: update release notes for 20.11

2020-11-27 Thread Thomas Monjalon
24/11/2020 21:45, Mcnamara, John: > > Fix grammar, spelling and formatting of DPDK 20.11 release notes. Thanks for the improvements. > Note, the "Known Issues" section can probably be removed from the final > version. OK I did few more adjustments for re-ordering some drivers. Applied, thanks.

Re: [dpdk-dev] [PATCH v2] doc: add tested Intel platforms with Intel NICs

2020-11-27 Thread Thomas Monjalon
20/11/2020 21:46, Xueqin Lin: > From: Chen Bo > > Add tested Intel platforms with Intel NICs to v20.11 release note. > > Signed-off-by: Chen Bo Applied, thanks

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 9:51 AM Jerin Jacob wrote: > > On Fri, Nov 27, 2020 at 2:09 PM David Marchand > wrote: > > > > On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wrote: > > > > > > Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set > > > failed for: > > > ../lib/librte_efd/rte

Re: [dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2020-11-27 Thread Thomas Monjalon
24/11/2020 10:54, Raslan Darawsheh: > Signed-off-by: Raslan Darawsheh Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add tested platforms for Broadcom NICs

2020-11-27 Thread Thomas Monjalon
24/11/2020 15:13, Ajit Khaparde: > Add tested platforms for Broadcom NICs to the 20.11 release notes. > > Signed-off-by: Ajit Khaparde Applied, thanks

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Jerin Jacob
On Fri, Nov 27, 2020 at 2:56 PM David Marchand wrote: > > On Fri, Nov 27, 2020 at 9:51 AM Jerin Jacob wrote: > > > > On Fri, Nov 27, 2020 at 2:09 PM David Marchand > > wrote: > > > > > > On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wrote: > > > > > > > > Gcc build with '-O0' on platforms with R

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Friday, November 27, 2020 4:39 PM > To: Ruifeng Wang ; jer...@marvell.com > Cc: Honnappa Nagarahalli ; dev > ; nd ; Feifei Wang > Subject: Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization > level 0 > > On Fri, Nov 27,

Re: [dpdk-dev] [RFC v2] doc: announce max Rx packet len fielddeprecation

2020-11-27 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad > Sent: Thursday, November 26, 2020 7:31 PM > > Hi > > Looks very good direction - it will do some order here. > > Will be also good to define what is MTU exactly: > Maximum Rx packet size \ Maximum Tx packet size \ both? If we

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Andrew Rybchenko
On 11/27/20 12:25 PM, David Marchand wrote: > On Fri, Nov 27, 2020 at 9:51 AM Jerin Jacob wrote: >> >> On Fri, Nov 27, 2020 at 2:09 PM David Marchand >> wrote: >>> >>> On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wrote: Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set

Re: [dpdk-dev] [PATCH] maintainers: update maintainers for event ethdev rx/tx adapters

2020-11-27 Thread Thomas Monjalon
24/09/2020 01:45, Thomas Monjalon: > > Jay is the new maintainer since Nikhil no longer works on DPDK. > > > > Signed-off-by: Nikhil Rao > [...] > > Eventdev Ethdev Rx Adapter API > > -M: Nikhil Rao > > +M: Jay Jayatheerthan > > T: git://dpdk.org/next/dpdk-next-eventdev > > F: lib/librte_eve

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 10:34 AM Jerin Jacob wrote: > > On Fri, Nov 27, 2020 at 2:56 PM David Marchand > wrote: > > > > On Fri, Nov 27, 2020 at 9:51 AM Jerin Jacob wrote: > > > > > > On Fri, Nov 27, 2020 at 2:09 PM David Marchand > > > wrote: > > > > > > > > On Fri, Nov 27, 2020 at 9:10 AM Ruif

[dpdk-dev] Build error with mingw in debug mode

2020-11-27 Thread David Marchand
This is introduced by e8428a9d89f1 ("eal/windows: add some basic functions and macros"). So sending to you guys: Caught while compiling all my envs with --buildtype=debug rather than debugoptimized: ninja: Entering directory `/home/dmarchan/builds/build-x86-mingw' ... Build targets in project: 70

Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

2020-11-27 Thread Ferruh Yigit
On 11/26/2020 6:31 PM, David Marchand wrote: On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit wrote: script is checking the existing of the kernel module file, but in some distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'. Since this script expects modprobe to be installed (

Re: [dpdk-dev] Build error with mingw in debug mode

2020-11-27 Thread Nick Connolly
The root cause here is that rte_windows.h shouldn't be injecting 'missing' POSIX functionality into the environment.  The header is included indirectly in application code via rte_os.h, but deciding how to implement the 'missing' functionality should be the applications responsibility. There a

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Friday, November 27, 2020 5:45 PM > To: Jerin Jacob > Cc: Ruifeng Wang ; Andrew Rybchenko > ; jer...@marvell.com; Honnappa > Nagarahalli ; dev ; nd > ; Feifei Wang > Subject: Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimiz

Re: [dpdk-dev] Build error with mingw in debug mode

2020-11-27 Thread Nick Connolly
Errata: the definition is in rte_os.h rather than rte_windows.h On 27/11/2020 10:05, Nick Connolly wrote: The root cause here is that rte_windows.h shouldn't be injecting 'missing' POSIX functionality into the environment.  The header is included indirectly in application code via rte_os.h, but

[dpdk-dev] [PATCH v2 0/2] gcc build fix

2020-11-27 Thread Ruifeng Wang
This series fixed issues found when building project with Gcc '-O0' option. Ruifeng Wang (2): eal/arm: fix gcc build for optimization level 0 net/igc: fix gcc build for optimization level 0 drivers/net/igc/base/meson.build | 3 ++- lib/librte_eal/arm/include/rte_atomic_64.h | 2 +-

[dpdk-dev] [PATCH v2 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Ruifeng Wang
Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set failed for: ../lib/librte_efd/rte_efd.c Assembler messages: 3866: Error: selected processor does not support `crc32cb w0,w0,w1' 3890: Error: selected processor does not support `crc32ch w0,w0,w1' 3914: Error: selected processor do

[dpdk-dev] [PATCH v2 2/2] net/igc: fix gcc build for optimization level 0

2020-11-27 Thread Ruifeng Wang
Gcc build with '-O0' failed for: ../drivers/net/igc/base/igc_api.c Assembler messages: 29: Error: selected processor does not support `casp x0,x1,x2,x3,[x4]' 82: Error: selected processor does not support `caspa x0,x1,x2,x3,[x4]' 135: Error: selected processor does not support `caspl x0,x1,x2,x3,

Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Jerin Jacob
On Fri, Nov 27, 2020 at 3:35 PM Ruifeng Wang wrote: > > > -Original Message- > > From: David Marchand > > Sent: Friday, November 27, 2020 5:45 PM > > To: Jerin Jacob > > Cc: Ruifeng Wang ; Andrew Rybchenko > > ; jer...@marvell.com; Honnappa > > Nagarahalli ; dev ; nd > > ; Feifei Wang >

[dpdk-dev] [PATCH] windows: build error with mingw debug

2020-11-27 Thread Nick Connolly
Compiling with MinGW in --buildtype=debug produces a redefinition error for strncasecmp. The root cause is that rte_os.h shouldn't be injecting POSIX definitions into the environment. It is the applications responsibility to decide how to handle missing functionality. Resolving this properly wil

[dpdk-dev] [PATCH] windows: build warnings with clang

2020-11-27 Thread Nick Connolly
Compiling with Clang (11.0, --buildtype=debug) for Windows produces deprecated warnings related to secure crt functions. Disable this by defining -D_CRT_SECURE_NO_WARNINGS. It is unclear exactly which commit this fixes. It is probably a consequence of building more libraries for Windows. Signed

[dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang

2020-11-27 Thread Nick Connolly
When building with clang (11.0,--buildtype=debug), eal_lcore.c produces a -Wformat-nonliteral warning from the vfprintf call in log_early. Disable the warning for log_early when building with clang. MinGW does not seem to detect the warning. Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA

Re: [dpdk-dev] Build error with mingw in debug mode

2020-11-27 Thread Nick Connolly
I've created a patch for this and also for a couple of build warnings that showed up doing a similar test with clang. On 27/11/2020 10:07, Nick Connolly wrote: Errata: the definition is in rte_os.h rather than rte_windows.h On 27/11/2020 10:05, Nick Connolly wrote: The root cause here is that

Re: [dpdk-dev] [PATCH 2/2] net/igc: fix gcc build for optimization level 0

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 10:02 AM David Marchand wrote: > > On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wrote: > > > > Gcc build with '-O0' failed for: > > ../drivers/net/igc/base/igc_api.c > > Assembler messages: > > 29: Error: selected processor does not support `casp x0,x1,x2,x3,[x4]' > > 82

Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition

2020-11-27 Thread Andrew Rybchenko
On 11/24/20 8:46 PM, Ferruh Yigit wrote: > On 11/3/2020 9:07 AM, Yang, SteveX wrote: >>> -Original Message- >>> From: Ananyev, Konstantin >>> Sent: Tuesday, November 3, 2020 12:05 AM >>> To: Yigit, Ferruh ; Andrew Rybchenko >>> ; Yang, SteveX ; >>> dev@dpdk.org >>> Cc: Xing, Beilei ; Lu, W

Re: [dpdk-dev] [PATCH v3] eal: fix create user mem map repeatedly when it exists

2020-11-27 Thread Burakov, Anatoly
On 20-Oct-20 3:09 PM, Thomas Monjalon wrote: 16/10/2020 11:28, wangyunjian: From: Yunjian Wang Currently, a issue that a container has many devices and the application will map the same memory many times. The kernel driver returns EEXIST as long as there are overlapping memory areas. As a resu

Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup

2020-11-27 Thread Burakov, Anatoly
On 22-Nov-20 6:16 PM, Thomas Monjalon wrote: That's a pity we didn't get this patch in DPDK 20.11. Anatoly, Stephen, what happened? It is not interesting anymore? Anyone else to review? It is a good patch and should be merged. I wanted to get it into LTS but no such luck apparently. 20/

Re: [dpdk-dev] [PATCH v2 1/2] eal/arm: fix gcc build for optimization level 0

2020-11-27 Thread Ruifeng Wang
> -Original Message- > From: Ruifeng Wang > Sent: Friday, November 27, 2020 6:15 PM > To: jer...@marvell.com; Ruifeng Wang ; > Honnappa Nagarahalli > Cc: dev@dpdk.org; nd ; Feifei Wang > > Subject: [PATCH v2 1/2] eal/arm: fix gcc build for optimization level 0 > > Gcc build with '-O0' o

Re: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts set

2020-11-27 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 26, 2020 14:38 > To: Slava Ovsiienko ; NBU-Contact-Thomas > Monjalon ; Wei Hu (Xavier) > > Cc: dev@dpdk.org; xavier.hu...@huawei.com > Subject: Re: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on > txpkts se

Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup

2020-11-27 Thread Thomas Monjalon
27/11/2020 13:56, Burakov, Anatoly: > On 22-Nov-20 6:16 PM, Thomas Monjalon wrote: > > That's a pity we didn't get this patch in DPDK 20.11. > > > > Anatoly, Stephen, what happened? It is not interesting anymore? > > > > Anyone else to review? > > > > It is a good patch and should be merged. I

Re: [dpdk-dev] [PATCH v2 0/2] gcc build fix

2020-11-27 Thread Thomas Monjalon
27/11/2020 11:15, Ruifeng Wang: > This series fixed issues found when building project > with Gcc '-O0' option. > > Ruifeng Wang (2): > eal/arm: fix gcc build for optimization level 0 > net/igc: fix gcc build for optimization level 0 No comment on the v2? Ruifeng, why nobody was Cc'ed? You do

Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

2020-11-27 Thread Thomas Monjalon
27/11/2020 10:55, Ferruh Yigit: > On 11/26/2020 6:31 PM, David Marchand wrote: > > On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit wrote: > >> > >> script is checking the existing of the kernel module file, but in some > >> distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'. > >

Re: [dpdk-dev] [PATCH 0/6] update dpdk-setup.sh

2020-11-27 Thread Burakov, Anatoly
On 25-Nov-20 7:19 PM, Ferruh Yigit wrote: This is an effort to update the dpdk-setup.sh script and keep it one more year until whole functionality of it is replaced. Other option is to remove it completely, please comment. This script has been largely unmaintained for a long time, so my perso

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

2020-11-27 Thread Thomas Monjalon
06/10/2020 00:41, Thomas Monjalon: > 15/09/2020 16:47, Stephen Hemminger: > > Ferruh Yigit wrote: > > > On 9/15/2020 3:03 AM, Stephen Hemminger wrote: > > > > Vdev_netvsc has been around for several years. It no longer needs > > > > to be marked experimental. > > > > > > > > Signed-off-by: Stephe

Re: [dpdk-dev] [PATCH 0/3] MAINTAINERS changes related to netvsc

2020-11-27 Thread Thomas Monjalon
15/09/2020 04:03, Stephen Hemminger: > Breakout three small changes to netvsc maintainers > > Stephen Hemminger (3): > MAINTAINERS remove experimental tag from vdev_netvsc > MAINTAINERS - drop Kys and Haiyang > MAINTAINERS - remove expermental tag of netvsd PMD Squashed patches 2 and 3, and

Re: [dpdk-dev] [RFC PATCH v1] build: add platform meson option

2020-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2020 at 08:31:47AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Thursday, November 26, 2020 5:03 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; honnappa.nagaraha...@arm.com; dev@dpdk.org > > Subject: Re: [RFC PATCH v1]

Re: [dpdk-dev] [PATCH v2 0/2] gcc build fix

2020-11-27 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 27, 2020 9:36 PM > To: Ruifeng Wang > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; nd ; jer...@marvell.com; > bruce.richard...@intel.com; ferruh.yi...@intel.com; Vimal Chungath > ; hemant.agra...@nxp.com; > konstantin.ana

Re: [dpdk-dev] [PATCH 0/6] update dpdk-setup.sh

2020-11-27 Thread Thomas Monjalon
27/11/2020 14:57, Burakov, Anatoly: > On 25-Nov-20 7:19 PM, Ferruh Yigit wrote: > > This is an effort to update the dpdk-setup.sh script and keep it one > > more year until whole functionality of it is replaced. > > > > Other option is to remove it completely, please comment. > > This script has

Re: [dpdk-dev] [PATCH] doc: clarify abi reference version to use in patches

2020-11-27 Thread David Marchand
On Mon, Aug 10, 2020 at 11:24 AM Ray Kinsella wrote: > > Clarify the ABI reference version (DPDK_ABI_REF_VERSION) tag, to use > when testing builds with devtools/test_build[_meson].sh before devtools/test-meson-builds.sh* > submitting patches. > > Signed-off-by: Ray Kinsella Reviewed-by: David

Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide

2020-11-27 Thread David Marchand
On Fri, Jul 3, 2020 at 7:15 PM Ferruh Yigit wrote: > > Signed-off-by: Ferruh Yigit Acked-by: Ray Kinsella Sample sounds odd to me, but applied as is. Thanks. -- David Marchand

Re: [dpdk-dev] [PATCH 2/2] net/igc: fix gcc build for optimization level 0

2020-11-27 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Friday, November 27, 2020 20:14 > To: Richardson, Bruce ; Yigit, Ferruh > > Cc: Guo, Jia ; Wang, Haiyue ; > Zhang, AlvinX > ; dev ; Honnappa Nagarahalli > ; nd > ; Ruifeng Wang ; Feifei Wang > > Subject: Re: [dpdk-dev] [PATCH 2/2] n

[dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread David Marchand
This old script relied on deprecated stuff, and especially make. It also applied some scary 666 permissions on files under /dev/vfio. Its deprecation had been notified in a previous release, remove it. Signed-off-by: David Marchand --- doc/guides/bbdevs/acc100.rst | 15 +- doc/gu

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2020 at 04:07:10PM +0100, David Marchand wrote: > This old script relied on deprecated stuff, and especially make. > It also applied some scary 666 permissions on files under /dev/vfio. > > Its deprecation had been notified in a previous release, remove it. > > Signed-off-by: Davi

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread Thomas Monjalon
> > This old script relied on deprecated stuff, and especially make. > > It also applied some scary 666 permissions on files under /dev/vfio. > > > > Its deprecation had been notified in a previous release, remove it. > > > > Signed-off-by: David Marchand > > --- > No objection to removal > > A

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 4:07 PM David Marchand wrote: > > This old script relied on deprecated stuff, and especially make. > It also applied some scary 666 permissions on files under /dev/vfio. > > Its deprecation had been notified in a previous release, remove it. > > Signed-off-by: David Marchan

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 2/2] doc/linux_gsg: update information on using hugepages

2020-11-27 Thread Thomas Monjalon
19/11/2020 11:52, Anatoly Burakov: > Current information regarding hugepage usage is a little out of date. > Update it to include information on in-memory mode, as well as on > default mountpoints provided by systemd. > > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov > Acked-by: Bruce R

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread Ferruh Yigit
On 11/27/2020 3:13 PM, Thomas Monjalon wrote: This old script relied on deprecated stuff, and especially make. It also applied some scary 666 permissions on files under /dev/vfio. Its deprecation had been notified in a previous release, remove it. Signed-off-by: David Marchand --- No objectio

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread Maxime Coquelin
On 11/27/20 4:07 PM, David Marchand wrote: > This old script relied on deprecated stuff, and especially make. > It also applied some scary 666 permissions on files under /dev/vfio. > > Its deprecation had been notified in a previous release, remove it. > > Signed-off-by: David Marchand > ---

Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

2020-11-27 Thread Ferruh Yigit
On 11/27/2020 1:56 PM, Thomas Monjalon wrote: 27/11/2020 10:55, Ferruh Yigit: On 11/26/2020 6:31 PM, David Marchand wrote: On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit wrote: script is checking the existing of the kernel module file, but in some distros kernel modules are stored compressed,

Re: [dpdk-dev] [PATCH v3 4/4] doc: add VFIO troubleshooting section

2020-11-27 Thread Thomas Monjalon
19/11/2020 12:32, Anatoly Burakov: > There are common problems with VFIO that get asked over and over on the > mailing list. Document common problems with VFIO and how to fix them or > at least figure out what went wrong. > > Signed-off-by: Anatoly Burakov Thanks for the effort. It hope there wi

Re: [dpdk-dev] [PATCH v3 3/4] doc: add VFIO no-IOMMU Linux GSG section

2020-11-27 Thread Bruce Richardson
On Thu, Nov 19, 2020 at 11:32:31AM +, Anatoly Burakov wrote: > Currently, we have no documentation on how to use VFIO in no-IOMMU mode. > Add such documentation. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v2: > - Fixed the noiommu parameter name > > doc/guides/linux_gsg/

Re: [dpdk-dev] [PATCH v3 4/4] doc: add VFIO troubleshooting section

2020-11-27 Thread Bruce Richardson
On Thu, Nov 19, 2020 at 11:32:32AM +, Anatoly Burakov wrote: > There are common problems with VFIO that get asked over and over on the > mailing list. Document common problems with VFIO and how to fix them or > at least figure out what went wrong. > > Signed-off-by: Anatoly Burakov > --- One

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd flows left before port stop.

2020-11-27 Thread Andrew Rybchenko
On 11/26/20 7:43 PM, Gregory Etelson wrote: > According to RTE flow user guide, PMD will not keep flow rules after > port stop. Application resources that refer to flow rules become > obsolete after port stop and must not be used. > Testpmd maintains linked list of active flows for each port. Entri

Re: [dpdk-dev] [PATCH 0/2] gcc build fix

2020-11-27 Thread Thomas Monjalon
27/11/2020 09:09, Ruifeng Wang: > This series fixed issues found when building project > with Gcc '-O0' option. > > Ruifeng Wang (2): > eal/arm: fix gcc build for optimization level 0 > net/igc: fix gcc build for optimization level 0 Series v1 applied with Cc:stable, thanks.

Re: [dpdk-dev] [PATCH v2] ethdev: deprecate shared counters using action attribute

2020-11-27 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 01:21:20PM +, Ferruh Yigit wrote: > On 11/3/2020 2:26 PM, Andrew Rybchenko wrote: > > A new generic shared actions API may be used to create shared > > counter. There is no point to keep duplicate COUNT action specific > > capability to create shared counters. > > > > S

Re: [dpdk-dev] [PATCH v2] ethdev: deprecate shared counters using action attribute

2020-11-27 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 01:21:20PM +, Ferruh Yigit wrote: > On 11/3/2020 2:26 PM, Andrew Rybchenko wrote: > > A new generic shared actions API may be used to create shared > > counter. There is no point to keep duplicate COUNT action specific > > capability to create shared counters. > > > > S

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 4:07 PM David Marchand wrote: > > This old script relied on deprecated stuff, and especially make. > It also applied some scary 666 permissions on files under /dev/vfio. > > Its deprecation had been notified in a previous release, remove it. > > Signed-off-by: David Marchan

Re: [dpdk-dev] [PATCH v2] doc: announce flow API matching pattern struct changes

2020-11-27 Thread Bruce Richardson
On Tue, Nov 24, 2020 at 01:15:35PM +, Ferruh Yigit wrote: > Proposing to replace protocol header fields in the ``rte_flow_item_*`` > structures with the protocol structs. > > This is both for documenting the intention and to be sure > ``rte_flow_item_*`` always starts with complete protocol he

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread Chautru, Nicolas
Hi David I don’t believe that the patch should also remove from doc the side note related to vfio-pci which is not specific to that setup script. Not at my desk, sorry for bad email formatting. Nic From: David Marchand Sent: Friday, November 27, 2020 8:12:01 AM

Re: [dpdk-dev] [PATCH v3 4/4] doc: add VFIO troubleshooting section

2020-11-27 Thread Burakov, Anatoly
On 27-Nov-20 3:30 PM, Thomas Monjalon wrote: 19/11/2020 12:32, Anatoly Burakov: There are common problems with VFIO that get asked over and over on the mailing list. Document common problems with VFIO and how to fix them or at least figure out what went wrong. Signed-off-by: Anatoly Burakov

Re: [dpdk-dev] [PATCH] remove dpdk-setup.sh

2020-11-27 Thread David Marchand
On Fri, Nov 27, 2020 at 5:20 PM Chautru, Nicolas wrote: > > Hi David > I don’t believe that the patch should also remove from doc the side note > related to vfio-pci which is not specific to that setup script. Indeed, fixed. Thanks! -- David Marchand

Re: [dpdk-dev] [PATCH v3 4/4] doc: add VFIO troubleshooting section

2020-11-27 Thread Kevin Traynor
On 19/11/2020 11:32, Anatoly Burakov wrote: > There are common problems with VFIO that get asked over and over on the > mailing list. Document common problems with VFIO and how to fix them or > at least figure out what went wrong. > > Signed-off-by: Anatoly Burakov > --- > doc/guides/linux_gsg/l

Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition

2020-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2020 at 03:19:43PM +0300, Andrew Rybchenko wrote: > On 11/24/20 8:46 PM, Ferruh Yigit wrote: > > On 11/3/2020 9:07 AM, Yang, SteveX wrote: > >>> -Original Message- > >>> From: Ananyev, Konstantin > >>> Sent: Tuesday, November 3, 2020 12:05 AM > >>> To: Yigit, Ferruh ; Andre

Re: [dpdk-dev] [PATCH v3 4/4] doc: add VFIO troubleshooting section

2020-11-27 Thread Thomas Monjalon
27/11/2020 17:29, Kevin Traynor: > On 19/11/2020 11:32, Anatoly Burakov wrote: > > There are common problems with VFIO that get asked over and over on the > > mailing list. Document common problems with VFIO and how to fix them or > > at least figure out what went wrong. > > > > Signed-off-by: Ana

Re: [dpdk-dev] [PATCH] doc: update vector mode information

2020-11-27 Thread Thomas Monjalon
27/11/2020 04:21, Ajit Khaparde: > PMD can support vector mode when jumbo is enabled as long as MTU is not > arge enough to require scattered RX (which also depends on the mbuf size). > > Signed-off-by: Ajit Khaparde Applied, thanks

Re: [dpdk-dev] [PATCH v2] doc: announce flow API matching pattern struct changes

2020-11-27 Thread Thomas Monjalon
24/11/2020 15:29, Ajit Khaparde: > On Tue, Nov 24, 2020 at 5:15 AM Ferruh Yigit wrote: > > > > Proposing to replace protocol header fields in the ``rte_flow_item_*`` > > structures with the protocol structs. > > > > This is both for documenting the intention and to be sure > > ``rte_flow_item_*``

Re: [dpdk-dev] [PATCH v2] ethdev: deprecate shared counters using action attribute

2020-11-27 Thread Thomas Monjalon
> > > > A new generic shared actions API may be used to create shared > > > > counter. There is no point to keep duplicate COUNT action specific > > > > capability to create shared counters. > > > > > > > > Signed-off-by: Andrew Rybchenko > > > > Reviewed-by: Ferruh Yigit > > > > --- > > > > Cc:

Re: [dpdk-dev] [RFC v2] doc: announce max Rx packet len field deprecation

2020-11-27 Thread Thomas Monjalon
26/11/2020 13:34, Ferruh Yigit: > On 11/26/2020 11:28 AM, Andrew Rybchenko wrote: > > On 11/24/20 8:36 PM, Ferruh Yigit wrote: > >> Signed-off-by: Ferruh Yigit > >> Acked-by: Konstantin Ananyev > > > > A couple of questions below, but anyway: > > > > Acked-by: Andrew Rybchenko > > > >> Anothe

[dpdk-dev] [RFC] net: make eCPRI header host network order

2020-11-27 Thread Ferruh Yigit
Other protocol structs are in the host byte order, having eCPRI in network byte order is insistent and error prone. Making eCPRI protocol header host byte order. Signed-off-by: Haiyue Wang Signed-off-by: Ferruh Yigit --- Cc: Stephen Hemminger Cc: Bing Zhao Cc: Olivier Matz --- lib/librte_ne

[dpdk-dev] Windows support

2020-11-27 Thread Nick Connolly
[Apologies if this is off-topic - just thought it might be of interest] Thanks to the excellent work that has been done to get DPDK running on Windows, it's now possible to build and run SPDK on Windows! (The SPDK is a high performance user space storage stack based around the NVMe protocol. 

[dpdk-dev] [dpdk-announce] DPDK 20.11 released

2020-11-27 Thread Thomas Monjalon
A new major release is available: https://fast.dpdk.org/rel/dpdk-20.11.tar.xz Our Thanksgiving gift is the biggest DPDK release ever: 2195 commits from 214 authors 2665 files changed, 269546 insertions(+), 107426 deletions(-) The branch 20.11 should be supported for at lea

Re: [dpdk-dev] [PATCH v2] ethdev: deprecate shared counters using action attribute

2020-11-27 Thread Ajit Khaparde
On Fri, Nov 27, 2020 at 8:08 AM Bruce Richardson wrote: > On Thu, Nov 12, 2020 at 01:21:20PM +, Ferruh Yigit wrote: > > On 11/3/2020 2:26 PM, Andrew Rybchenko wrote: > > > A new generic shared actions API may be used to create shared > > > counter. There is no point to keep duplicate COUNT ac

Re: [dpdk-dev] [RFC] net: make eCPRI header host network order

2020-11-27 Thread Bing Zhao
Hi Ferruh & Haiyue, Have you checked other headers? Like: rte_ipv4_hdr rte_ipv6_hdr rte_tcp_hdr ... Also [ITEM_UDP_SRC] = { .name = "src", .help = "UDP source port", .next = NEXT(item_udp, NEXT_ENTRY(UNSIGNED), item_param), .a

Re: [dpdk-dev] [RFC] net: make eCPRI header host network order

2020-11-27 Thread Wang, Haiyue
Hi Bing, These definition just use the basic data type, not use the bit field method. BR, Haiyue > -Original Message- > From: Bing Zhao > Sent: Saturday, November 28, 2020 11:18 > To: Yigit, Ferruh ; Olivier Matz > > Cc: dev@dpdk.org; Wang, Haiyue ; Stephen Hemminger > > Subject: RE

Re: [dpdk-dev] [RFC] net: make eCPRI header host network order

2020-11-27 Thread Wang, Haiyue
Hi Bing, > -Original Message- > From: Bing Zhao > Sent: Saturday, November 28, 2020 11:18 > To: Yigit, Ferruh ; Olivier Matz > > Cc: dev@dpdk.org; Wang, Haiyue ; Stephen Hemminger > > Subject: RE: [RFC] net: make eCPRI header host network order > > Hi Ferruh & Haiyue, > Have you chec