Re: [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command

On Thu, Nov 19, 2020 at 7:50 PM Thomas Monjalon wrote: > > 16/11/2020 11:06, David Marchand: > > All EAL flags tests are run by calling the "eal_flags_autotest" command. > > There is no compatibility to maintain for sub commands only called by > > meson. > > > > Fixes: db27370b5720 ("eal: replace

Re: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming

On Mon, Nov 16, 2020 at 11:12 AM Gaetan Rivet wrote: > > The original triple negative was hard to read and the attempt > to improve the formulation was commendable, unfortunately the new > comment is the inverse of correct. > > Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enu

[dpdk-dev] [PATCH v2 1/1] net/hinic: fix the problem of hugepage memory leaks

The nic_io memory sets to NULL before free it, this is wrong, and the freeing of some private port resources should be moved from the ".remove(device)" function to the ".dev_close(port)" function. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") Cc: sta...@dpdk.o

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS

On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman wrote: > > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4. > > The definition of ETOOMANYREFS is reverted as it breaks build of > external applications already defining it. > > Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANY

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS

On Fri, Nov 20, 2020 at 10:12 AM David Marchand wrote: > > On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman wrote: > > > > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4. > > > > The definition of ETOOMANYREFS is reverted as it breaks build of > > external applications already defini

Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

On Thu, Nov 19, 2020 at 11:42 AM Anatoly Burakov wrote: > > Currently, when building sphinx documentation, the build will only > succeed if being run from the build system, because the conf.py script > expects DPDK_VERSION environment variable to be set, and crashes if it > is not. > > However, th

Re: [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS

On Thu, 19 Nov 2020 17:43:10 +0200, Tal Shnaiderman wrote: > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4. > > The definition of ETOOMANYREFS is reverted as it breaks build of > external applications already defining it. > > Fixes: c917b54b0c ("eal/windows: add definition of ETOOM

[dpdk-dev] [PATCH 1/1] ethdev: rename a flow shared action error code

In the experimental function rte_flow_shared_action_destroy() introduced in DPDK 20.11, the errno ETOOMANYREFS was used. This errno is not always available on Windows, so it is preferred using EBUSY instead. Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- lib/librte_

Re: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference

> -Original Message- > From: dev On Behalf Of Timothy McDaniel > Sent: Monday, November 16, 2020 5:41 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com; tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] event/dlb: fix potential NULL derefe

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

On Fri, Nov 20, 2020 at 04:33:12AM +, Honnappa Nagarahalli wrote: > > > > > > > > 18/11/2020 15:19, Juraj Linkeš: > > > > > > > From: Thomas Monjalon > > > > > > > > 16/11/2020 10:13, Bruce Richardson: > > > > > > > > > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon > > wrote: > >

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

On Fri, Nov 20, 2020 at 10:15:42AM +, Bruce Richardson wrote: > On Fri, Nov 20, 2020 at 04:33:12AM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > 18/11/2020 15:19, Juraj Linkeš: > > > > > > > > From: Thomas Monjalon > > > > > > > > > 16/11/2020 10:13, Bruce Richardson: > > > > > >

[dpdk-dev] [RFC V3] app/testpmd: fix queue stats mapping configuration

From: Huisong Li Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But there is no failure message after executing the command "set stat_qmap rx 0 2 2". 2) Once queue mapping is set, unrelated and unmapped queues are also displa

[dpdk-dev] [PATCH v2] event/octeontx2: fix unconditional Tx flush

From: Pavan Nikhilesh Fix unconditional Tx flush, handle packet retransmit cases where flush has to be differed. Fixes: cb7ee83b6365 ("event/octeontx2: improve single flow performance") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 1 + driver

[dpdk-dev] [PATCH V1] doc: add tested Intel platforms with Intel NICs

From: ChenBo Add tested Intel platforms with Intel NICs to v20.11 release note. Signed-off-by: ChenBo --- doc/guides/rel_notes/release_20_11.rst | 122 + 1 file changed, 122 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/relea

Re: [dpdk-dev] [PATCH v4] usertools/devbind: fix binding for built-in kernel drivers

On 20-Nov-20 2:22 AM, Yongxin Liu wrote: A driver can be loaded as a dynamic module or a built-in module. In commit 681a67288655 ("usertools: check if module is loaded before binding"), script only checks modules in /sys/module/. However, for built-in kernel driver, it only shows up in /sys/modu

Re: [dpdk-dev] [PATCH v4 2/2] doc/linux_gsg: update information on using hugepages

On 19-Nov-20 9:03 PM, David Marchand wrote: On Thu, Nov 19, 2020 at 11:53 AM Anatoly Burakov wrote: -Once the hugepage memory is reserved, to make the memory available for DPDK use, perform the following steps:: +If secondary process support is not required, DPDK is able to use hugepages +with

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update

On 11/19/2020 6:42 PM, Thomas Monjalon wrote: 19/11/2020 18:48, Ferruh Yigit: On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: From: Benoît Ganne mlx5 PMD refuses to update link state if link speed is defined but status is down or if link speed is undefined but status is up, even if the ioctl()

Re: [dpdk-dev] [PATCH 1/1] ethdev: rename a flow shared action error code

> Subject: [PATCH 1/1] ethdev: rename a flow shared action error code > > External email: Use caution opening links or attachments > > > In the experimental function rte_flow_shared_action_destroy() introduced > in DPDK 20.11, the errno ETOOMANYREFS was used. > This errno is not always available

Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation

On 11/18/2020 3:34 PM, Raslan Darawsheh wrote: Hi, -Original Message- From: dev On Behalf Of Dekel Peled Sent: Wednesday, November 18, 2020 11:24 AM To: Slava Ovsiienko ; Shahaf Shuler ; Matan Azrad Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation

[dpdk-dev] [PATCH 2/4] net/hns3: fix unused queues with not disabled

From: Chengchang Tang For kupeng 930, there are 3 registers to control the enable status of a TQP(i.e. task queue pair, include a txq and a rxq). One of them controls whether the TQP is enabled, and the other two controls whether the rxq and txq are enabled. The registers used to control the enab

[dpdk-dev] [PATCH 1/4] net/hns3: fix segment fault with the multi-TC

From: Huisong Li The HW and SW DCB configurations need to be updated only after the DCB configuration information changed. But the change of tx/rx queue number is ignored. If user decreases the number of tx queue after configuring multi-TC, the queue mapping information in hns3_tc_queue_info can

[dpdk-dev] [PATCH 0/4] hns3 fixes

Here series are fixes for hns3 PMD driver. Chengchang Tang (1): net/hns3: fix unused queues with not disabled Huisong Li (1): net/hns3: fix segment fault with the multi-TC Lijun Ou (1): net/hns3: adjust printing MAC addresses in log Min Hu (Conor) (1): net/hns3: fix FEC state query dr

[dpdk-dev] [PATCH 3/4] net/hns3: adjust printing MAC addresses in log

Here the printing of MAC addresses is adjusted. After the modification, only some bytes of the MAC address are displayed. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_ethdev.c| 53 +++ drivers/net/hns3/hns3_ethdev.h

[dpdk-dev] [PATCH 4/4] net/hns3: fix FEC state query

From: "Min Hu (Conor)" As FEC is not supported below 10 Gbps, CMD(0x031A) offered from Firmware read will return fail in 10 Gbps device. This patch will prevent read this CMD when below 10 Gbps, as this is non-sense. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-

Re: [dpdk-dev] [PATCH v4] usertools/devbind: fix binding for built-in kernel drivers

On 20-Nov-20 2:22 AM, Yongxin Liu wrote: A driver can be loaded as a dynamic module or a built-in module. In commit 681a67288655 ("usertools: check if module is loaded before binding"), script only checks modules in /sys/module/. However, for built-in kernel driver, it only shows up in /sys/modu

[dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration

From: Huisong Li Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But there is no failure message after executing the command "set stat_qmap rx 0 2 2". 2) Once queue mapping is set, unrelated and unmapped queues are also displa

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

> -Original Message- > From: Bruce Richardson > Sent: Friday, November 20, 2020 11:20 AM > To: Honnappa Nagarahalli > Cc: Juraj Linkeš ; tho...@monjalon.net; Ruifeng > Wang ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khapa

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

On Fri, Nov 20, 2020 at 11:56:44AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, November 20, 2020 11:20 AM > > To: Honnappa Nagarahalli > > Cc: Juraj Linkeš ; tho...@monjalon.net; Ruifeng > > Wang ; Phil Yang ; > > vcchu...@amazon.co

Re: [dpdk-dev] [PATCH] doc: fix typing error in example/l3_forward_access_ctrl

On Thu, Nov 5, 2020 at 9:54 AM David Marchand wrote: > On Mon, Nov 2, 2020 at 12:20 PM Ibtisam Tariq > wrote: > > > > Add "--" and remove extra spaces in l3fwd-acl commands. > > > > Fixes: d0dff9ba4 ("doc: sample application user guide") Cc: sta...@dpdk.org > > > > Signed-off-by: Ibtisam Tariq

Re: [dpdk-dev] [PATCH] app/testpmd: revert setting MTU explicitly after configure

On 11/20/2020 1:51 AM, Chen, BoX C wrote: -Original Message- From: dev On Behalf Of Ferruh Yigit Sent: November 17, 2020 3:04 To: Lu, Wenzhuo ; Xing, Beilei ; Iremonger, Bernard ; Zhang, Qi Z ; Andrew Rybchenko Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org Subject: [dpdk-dev] [PA

[dpdk-dev] [PATCH v13 00/12] Arm build options rework

The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

[dpdk-dev] [PATCH v13 01/12] build: rename Arm build variables

Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v13 02/12] build: remove unused or superfluous variables

Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

[dpdk-dev] [PATCH v13 03/12] build: reformat and move Arm config and comments

Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v13 04/12] build: simplify how Arm flags are processed

Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build

[dpdk-dev] [PATCH v13 05/12] build: organize Arm config into dict

Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v13 06/12] build: isolate configuration for Arm generic build

Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v13 07/12] build: use native machine args in Arm native build

Letting the compiler decide is going to yield the best results for native builds, so use native machine args usable for both GCC and Clang. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 54 ++ 1 file changed, 28 insertions(+), 26 deletions(-) d

[dpdk-dev] [PATCH v13 08/12] build: add core and NUMA counts to cross files

Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc

[dpdk-dev] [PATCH v13 09/12] build: disable drivers in Arm builds

A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works and remove unneeded driver options ported from the old makefile system, since they don't work

[dpdk-dev] [PATCH v13 10/12] build: disable libnuma in cross builds

Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disable NUMA in Arm cross files. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1

[dpdk-dev] [PATCH v13 11/12] build: add Arm SoC meson option

Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš Reviewed-by: Honnapp

[dpdk-dev] [PATCH v13 12/12] config: fix Arm implementer and its SoCs

Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

Re: [dpdk-dev] [PATCH v3] examples/qos_sched: update profile config file

On Tue, Nov 17, 2020 at 11:06 AM Savinay Dharmappa wrote: > > update the qos_sched user guide and profile config file > with default subport profile. > > Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") > > Signed-off-by: Savinay Dharmappa > Acked-by: Cristian Dumitresc

Re: [dpdk-dev] [PATCH v2] doc: update ip pipeline sample application

On Tue, Nov 17, 2020 at 11:16 AM Savinay Dharmappa wrote: > > update the user guide of ip pipeline sample application > to reflect the changes in command line arguments. > > Fixes: 54a298e5f7f4 ("examples/ip_pipeline: update subport rate dynamically") > > Signed-off-by: Savinay Dharmappa > Acked-

Re: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference

On Fri, Nov 20, 2020 at 3:33 PM Mcnamara, John wrote: > > > > > -Original Message- > > From: dev On Behalf Of Timothy McDaniel > > Sent: Monday, November 16, 2020 5:41 PM > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > > ; Van Haaren, Harry ; > > jer...@marvell.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v2] event/octeontx2: unlink queues during port release

On Thu, Nov 19, 2020 at 2:17 PM Shijith Thotton wrote: > > Unlinking queues from port should be done during port release. Doing it > during device re-configuration could result in segfault as ports array > is re-allocated based on new number of ports. > > Fixes: f7ac8b66b23c ("event/octeontx2: sup

Re: [dpdk-dev] [PATCH v2 2/2] event/octeontx: remove selftest from dev args

On Thu, Nov 19, 2020 at 7:28 PM wrote: > > From: Pavan Nikhilesh > > Since selftest now depends on dynamic mbuf fields it is not > feasible to run selftest on device probe. > > Signed-off-by: Pavan Nikhilesh Series applied to dpdk-next-eventdev/for-main. Thanks. > --- > doc/guides/eventdevs

[dpdk-dev] [PATCH v1 1/1] build: alias default build as generic

The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

Re: [dpdk-dev] [PATCH v2] event/octeontx2: fix unconditional Tx flush

On Fri, Nov 20, 2020 at 4:12 PM wrote: > > From: Pavan Nikhilesh > > Fix unconditional Tx flush, handle packet retransmit cases where > flush has to be differed. > > Fixes: cb7ee83b6365 ("event/octeontx2: improve single flow performance") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh

[dpdk-dev] [pull-request] next-eventdev 20.11 rc5

The following changes since commit 2069f9eefca06190377bbff14734e2326439df42: version: 20.11-rc4 (2020-11-16 00:14:43 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 08c8e18b9cf78472dd0bcfdf484f0ff27b541020: event/o

[dpdk-dev] [PATCH v2] doc: add tested Intel platforms with Intel NICs

From: Chen Bo Add tested Intel platforms with Intel NICs to v20.11 release note. Signed-off-by: Chen Bo --- doc/guides/rel_notes/release_20_11.rst | 122 + 1 file changed, 122 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/rel

[dpdk-dev] [PATCH v1 1/1] build: optional NUMA and cpu counts detection

Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

Re: [dpdk-dev] [PATCH 1/1] ethdev: rename a flow shared action error code

On 11/20/2020 10:54 AM, Tal Shnaiderman wrote: Subject: [PATCH 1/1] ethdev: rename a flow shared action error code External email: Use caution opening links or attachments In the experimental function rte_flow_shared_action_destroy() introduced in DPDK 20.11, the errno ETOOMANYREFS was used. T

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update

20/11/2020 11:51, Ferruh Yigit: > On 11/19/2020 6:42 PM, Thomas Monjalon wrote: > > 19/11/2020 18:48, Ferruh Yigit: > >> On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: > >>> From: Benoît Ganne > >>> > >>> mlx5 PMD refuses to update link state if link speed is defined but > >>> status is down or if

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update

On 11/20/2020 1:50 PM, Thomas Monjalon wrote: 20/11/2020 11:51, Ferruh Yigit: On 11/19/2020 6:42 PM, Thomas Monjalon wrote: 19/11/2020 18:48, Ferruh Yigit: On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: From: Benoît Ganne mlx5 PMD refuses to update link state if link speed is defined but st

Re: [dpdk-dev] [PATCH 3/4] net/hns3: adjust printing MAC addresses in log

On 11/20/2020 11:27 AM, Lijun Ou wrote: Here the printing of MAC addresses is adjusted. After the modification, only some bytes of the MAC address are displayed. Why logging only some bytes of the MAC address? Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hn

Re: [dpdk-dev] [PATCH 4/4] net/hns3: fix FEC state query

On 11/20/2020 11:27 AM, Lijun Ou wrote: From: "Min Hu (Conor)" As FEC is not supported below 10 Gbps, CMD(0x031A) offered from Firmware read will return fail in 10 Gbps device. This patch will prevent read this CMD when below 10 Gbps, as this is non-sense. Fixes: 9bf2ea8dbc65 ("net/hns3: supp

Re: [dpdk-dev] [PATCH 4/4] net/hns3: fix FEC state query

On 11/20/2020 2:33 PM, Ferruh Yigit wrote: On 11/20/2020 11:27 AM, Lijun Ou wrote: From: "Min Hu (Conor)" As FEC is not supported below 10 Gbps, CMD(0x031A) offered from Firmware read will return fail in 10 Gbps device. This patch will prevent read this CMD when below 10 Gbps, as this is non-

Re: [dpdk-dev] [PATCH 0/4] hns3 fixes

On 11/20/2020 11:27 AM, Lijun Ou wrote: Here series are fixes for hns3 PMD driver. Chengchang Tang (1): net/hns3: fix unused queues with not disabled Huisong Li (1): net/hns3: fix segment fault with the multi-TC Lijun Ou (1): net/hns3: adjust printing MAC addresses in log Min Hu (Con

[dpdk-dev] [PATCH v3] net/mlx5: check the reg available for metadata action

From: Tonghao Zhang If user don't set the dv_xmeta_en to 1 or 2, in the flow_dv_convert_action_set_meta function: - flow_dv_get_metadata_reg may return the REG_NONE, when MLX5_METADATA_FDB enabled for metadata set action. - reg_to_field(REG_NONE) returns MLX5_MODI_OUT_NONE, that is invalid

Re: [dpdk-dev] [PATCH 0/4] hns3 fixes

Hi，Ferruh the first and second patch are critical. 欧丽军 Mobile：+86-18899774289 Email：ouli...@huawei.com 发件人： Ferruh Yigitmailto:ferruh.yi...@intel.com>> 收件人： oulijunmailto:ouli...@huawei.com>> 抄送： devmailto:dev@dpdk.org>>;Linuxarmmai

Re: [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS

On Fri, Nov 20, 2020 at 10:26 AM Dmitry Kozlyuk wrote: > > On Thu, 19 Nov 2020 17:43:10 +0200, Tal Shnaiderman wrote: > > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4. > > > > The definition of ETOOMANYREFS is reverted as it breaks build of > > external applications already definin

Re: [dpdk-dev] [PATCH v2 1/1] devtools: rename build test verbosity variables

On Wed, Nov 18, 2020 at 11:56 AM David Marchand wrote: > On Tue, Nov 17, 2020 at 11:38 AM Thomas Monjalon wrote: > > > > The verbosity was meant to be set with options -v and -vv, > > or possibly with the environment variables TEST_MESON_BUILD_VERBOSE > > and TEST_MESON_BUILD_VERY_VERBOSE. > > >

Re: [dpdk-dev] [PATCH 1/1] build: align wording of non-support reasons

On Mon, Nov 16, 2020 at 2:49 PM David Marchand wrote: > On Fri, Nov 6, 2020 at 6:09 PM Thomas Monjalon wrote: > > > > Reasons for building not supported generally start with lowercase > > because printed as the second part of a line. > > > > Other changes: > > - "linux" should be "Linux"

Re: [dpdk-dev] [PATCH 0/4] hns3 fixes

On 11/20/2020 2:58 PM, oulijun wrote: < Moved to the bottom, please do not top post > 欧丽军 Mobile：+86-18899774289 Email：ouli...@huawei.com *发件人： *Ferruh Yigitmailto:ferruh.yi...@inte

Re: [dpdk-dev] [PATCH v2 1/1] net/hinic: fix the problem of hugepage memory leaks

On 11/20/2020 9:11 AM, Guoyang Zhou wrote: The nic_io memory sets to NULL before free it, this is wrong, and the freeing of some private port resources should be moved from the ".remove(device)" function to the ".dev_close(port)" function. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

> > > > > > > > > 18/11/2020 15:19, Juraj Linkeš: > > > > > > > > From: Thomas Monjalon > > > > > > > > > 16/11/2020 10:13, Bruce Richardson: > > > > > > > > > > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas > > > > > > > > > > Monjalon > > > wrote: > > > > > > > > > > > 13/11/2020 15:31, Jura

Re: [dpdk-dev] [PATCH v2] examples/multi_process: fix missing SPDX headers

On Mon, Nov 16, 2020 at 10:36 AM Bruce Richardson wrote: > > The makefiles for some of the multi_process example files were missing > SPDX license headers, so add them. These Makefiles completely replaced > the older makefiles and were written from scratch, not based on previous > versions, so add

[dpdk-dev] [PATCH DPDK-KMODS] doc: allow external build

Currently, when building sphinx documentation, the build will only succeed if being run from the build system, because the conf.py script expects DPDK_VERSION environment variable to be set, and crashes if it is not. However, there are certain external tools (such as sphinx documentation preview e

Re: [dpdk-dev] [PATCH DPDK-KMODS] doc: allow external build

On 20-Nov-20 4:41 PM, Anatoly Burakov wrote: Currently, when building sphinx documentation, the build will only succeed if being run from the build system, because the conf.py script expects DPDK_VERSION environment variable to be set, and crashes if it is not. However, there are certain externa

[dpdk-dev] [PATCH DPDK-KMODS] igb_uio: add compile instructions

Currently, compilation instructions for igb_uio are missing. Add them, as well as a top-level INSTALL file referring users to per-OS subdirectories. Signed-off-by: Anatoly Burakov --- INSTALL | 5 + linux/README.rst | 45 + 2 files change

Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration

On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: From: Huisong Li Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But there is no failure message after executing the command "set stat_qmap rx 0 2 2". 2) Once queue mapping is

[dpdk-dev] [PATCH v3] app/testpmd: fix testpmd packets dump overlapping

When testpmd enabled the verbosity for the received packets, if two packets were received at the same time, for example, sampling packet and normal packet, the dump output of these packets may be overlapping due to multiple core handling the multiple queues simultaneously. The patch uses one strin

Re: [dpdk-dev] [v21.02 v3 10/10] net/avp: remove always true condition

On 2020-11-19 6:59 a.m., Ferruh Yigit wrote: There is already a break above for the case "count >= 1", so at this stage 'count' should be always '0'. Fixes: 1a85922369c4 ("net/avp: add device configuration") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- drivers/net/avp/avp_ethdev.c |

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd packets dump overlapping

On 11/20/2020 5:35 PM, Jiawei Wang wrote: When testpmd enabled the verbosity for the received packets, if two packets were received at the same time, for example, sampling packet and normal packet, the dump output of these packets may be overlapping due to multiple core handling the multiple queu

Re: [dpdk-dev] [PATCH 0/4] hns3 fixes

On 11/20/2020 3:38 PM, Ferruh Yigit wrote: On 11/20/2020 2:58 PM, oulijun wrote: < Moved to the bottom, please do not top post > 欧丽军 Mobile：+86-18899774289 Email：ouli...@huawei.com

[dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

Linking with the 'pci' driver when building with MinGW on Windows fails with undefined symbol 'GUID_DEVCLASS_NET'. This occurs because devguid.h is included in rte_windows.h before INITGUID is defined. Resolved by moving the include of devguid.h after the definition of INITGUID. Fixes: b762221ac2

Re: [dpdk-dev] [PATCH] doc: announce end of support for some Broadcom devices

On Fri, Nov 6, 2020 at 12:59 PM Ajit Khaparde wrote: > > > > On Fri, Nov 6, 2020 at 11:22 AM Kevin Traynor wrote: >> >> On 03/11/2020 17:26, Ajit Khaparde wrote: >> > On Tue, Nov 3, 2020 at 2:50 AM Kevin Traynor wrote: >> >> >> >> Hi Ajit, >> >> >> >> On 26/10/2020 21:46, Ajit Khaparde wrote: >>

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

> Subject: [PATCH] eal/windows: fix link error with MinGW > > Linking with the 'pci' driver when building with MinGW on Windows fails with > undefined symbol 'GUID_DEVCLASS_NET'. > This occurs because devguid.h is included in rte_windows.h before INITGUID > is defined. > Hi Nick, I can't seem

Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration

On Fri, 20 Nov 2020 17:26:55 + Ferruh Yigit wrote: > On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: > > From: Huisong Li > > > > Currently, the queue stats mapping has the following problems: > > 1) Many PMD drivers don't support queue stats mapping. But there is no > > failure message af

Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration

On 11/20/2020 11:21 PM, Stephen Hemminger wrote: On Fri, 20 Nov 2020 17:26:55 + Ferruh Yigit wrote: On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: From: Huisong Li Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But t

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

I can't seem to reproduce the link error you've mentioned (I'm building hello_world on master). can you share more information on how to reproduce it? (MinGW version, build env variables, build OS). Thanks, Tal. Hi Tal, Sure - latest MinGW-w64 (v8.0.0 I believe, but the versioning isn't

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

Build OS is Windows 10 2004

[dpdk-dev] [PATCH] devtools: add acronyms in dictionary for commit checks

ICMP -> Internet Control Message Protocol IPv4 -> Internet Protocol version 4 IPv6 -> Internet Protocol version 6 Signed-off-by: Ferruh Yigit --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index f3eb4bb60d88..8

[dpdk-dev] [PATCH v1] raw/ioat: add secondary process support

add the secondart process support in dsa and ioat for cbdma Signed-off-by: Kumar Amber --- drivers/raw/ioat/ioat_common.c | 18 +++--- drivers/raw/ioat/ioat_rawdev.c | 19 +++ 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/raw/ioat/ioat_common

[dpdk-dev] [PATCH] net/mlx5: fix mbufs overflow in vectorized MPRQ

Changing the allocation scheme to improve mbufs locality caused mbufs overrun in some cases. Revert the previous replenish logic back. Calculate a number of unused mbufs and replenish max this number of mbufs. Mark the last 4 mbufs as fake mbufs to prevent overflowing into consumed mbufs in the fu

Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration

On Fri, 20 Nov 2020 23:33:40 + Ferruh Yigit wrote: > On 11/20/2020 11:21 PM, Stephen Hemminger wrote: > > On Fri, 20 Nov 2020 17:26:55 + > > Ferruh Yigit wrote: > > > >> On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: > >>> From: Huisong Li > >>> > >>> Currently, the queue stats map