09/11/2020 06:18, Jerin Jacob:
> On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon wrote:
> > 07/11/2020 20:05, Jerin Jacob:
> > > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon
> > > wrote:
> > > > 07/11/2020 18:12, Jerin Jacob:
> > > > > On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon
> > > >
+CC techboard
> From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> Sent: Monday, November 9, 2020 6:18 AM
>
> On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon
> wrote:
> >
> > 07/11/2020 20:05, Jerin Jacob:
> > > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon
> wrote:
> > > > 07/11/2020 18:12, J
Hi,
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Wednesday, November 4, 2020 4:25 PM
> To: Slava Ovsiienko ; Shahaf Shuler
> ; Matan Azrad
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix use of local array for global error
>
> Recent patch uses a loca
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Friday, November 6, 2020 5:02 AM
> To: Slava Ovsiienko ; Matan Azrad
>
> Cc: Raslan Darawsheh ; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix invalid entry assert
>
> The entry variable assert in the mlx5_hlist_register() function is
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Friday, November 6, 2020 5:08 AM
> To: Slava Ovsiienko ; Matan Azrad
>
> Cc: Raslan Darawsheh ; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix shared RSS action release
>
> As shared RSS action is global standalone action, the shared a
On Mon, Nov 9, 2020 at 1:34 PM Thomas Monjalon wrote:
>
> 09/11/2020 06:18, Jerin Jacob:
> > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon wrote:
> > > 07/11/2020 20:05, Jerin Jacob:
> > > > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon
> > > > wrote:
> > > > > 07/11/2020 18:12, Jerin Jacob:
Tested-by: Han, Yingya
-Original Message-
From: dev On Behalf Of Jeff Guo
Sent: Monday, November 9, 2020 2:05 PM
To: Wu, Jingjing ; Zhang, Qi Z ;
Xing, Beilei
Cc: dev@dpdk.org; Guo, Jia
Subject: [dpdk-dev] [PATCH v1] net/iavf: fix rxdid configure
On 11/2/20 12:38 PM, Ibtisam Tariq wrote:
> Add new line character(\n) in the usage of vhost_crypto example for
> better readability
>
> Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core")
> Cc: roy.fan.zh...@intel.com
>
> Signed-off-by: Ibtisam Tariq
> ---
> examples/vhost_cryp
On 11/3/20 6:35 AM, Patrick Fu wrote:
> Async inflight packet counter should take failed packets into account.
> Failed packets will be deducted in the error handling logic.
>
> Fixes: 6b3c81db8bb7 ("vhost: simplify async copy completion")
> Fixes: cd6760da1076 ("vhost: introduce async enqueue
在 2020/11/7 0:38, Ferruh Yigit 写道:
On 11/6/2020 3:51 AM, Lijun Ou wrote:
From: Hongbo Zheng
According to bit operator reliability style, variables in
the right expression participating int bit operation
cannot be of unsigned type.
Assuming this is talking about BIT() ("#define BIT(nr) (1U
+ Dev@dpdk.org
Regards,
Yu Ping
> -Original Message-
> From: Yu, PingX
> Sent: Monday, November 9, 2020 5:06 PM
> To: Thomas Monjalon ; annou...@dpdk.org
> Cc: Yigit, Ferruh ; O'Hare, Cathal
> ; Devlin, Michelle
> Subject: RE: [dpdk-announce] release candidate 20.11-rc3
>
> All,
> Updat
在 2020/11/7 0:38, Ferruh Yigit 写道:
On 11/6/2020 3:51 AM, Lijun Ou wrote:
From: Hongbo Zheng
According to bit operator reliability style, variables in
the right expression participating int bit operation
cannot be of unsigned type.
Assuming this is talking about BIT() ("#define BIT(nr) (1U
在 2020/11/7 0:44, Ferruh Yigit 写道:
On 11/6/2020 3:51 AM, Lijun Ou wrote:
From: Hongbo Zheng
Here adjusts some code style for making the lines more
compact and removes some static check tool warnings.
Signed-off-by: Hongbo Zheng
Signed-off-by: Lijun Ou
---
V1->V2:
- fix checkpatch warning
> -Original Message-
> From: Huang, Wei
> Sent: Thursday, November 5, 2020 10:06 AM
> To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z
>
> Cc: sta...@dpdk.org; Huang, Wei
> Subject: [PATCH v2 0/2] raw/ifpga/base: fix defects found by coverity scan
>
> Two issues are introduced from previous
On Mon, Nov 09, 2020 at 01:57:26PM +0530, Jerin Jacob wrote:
> On Mon, Nov 9, 2020 at 1:34 PM Thomas Monjalon wrote:
> >
> > 09/11/2020 06:18, Jerin Jacob:
> > > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon
> > > wrote:
> > > > 07/11/2020 20:05, Jerin Jacob:
> > > > > On Sun, Nov 8, 2020 at 12
> -Original Message-
> From: dev On Behalf Of Guo, Jia
> Sent: Monday, November 9, 2020 2:24 PM
> To: Prateek Agarwal
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern
> "C". Library headers work directly in cpp code. Linking errors thrown
Minutes of Technical Board Meeting, 2020-11-04
Members Attending
-
-Bruce
-Ferruh
-Hemant
-Honnappa
-Jerin
-Kevin (Chair)
-Konstantin
-Maxime
-Olivier
-Stephen
-Thomas
NOTE: The technical board meetings every second Wednesday in
https://meet.jit.si/DPDK at 3 pm UTC.
Meetings are p
Hi,
In vfio_enable_msi api the count value passed to the kernel is hardcoded
to ‘1’. Is there any specific reason behind this?
I believe this can be set to more than 1.
Any information on this would be helpful.
Thanks,
Vikas
On Tue, Oct 27, 2020 at 6:39 PM Bruce Richardson
wrote:
>
> To test the installation process of DPDK using "ninja install"
> test-meson-builds.sh builds a subset of the examples using "make". To allow
> more flexibility for people testing, allow the set of examples chosen for
> this make test to b
On 11/3/2020 2:27 PM, Ferruh Yigit wrote:
On 11/3/2020 1:20 PM, Xiaoyu Min wrote:
From: Xiaoyu Min
The rte_flow_item_eth and rte_flow_item_vlan items are refined [1].
The structs do not exactly represent the packet bits captured on the wire
anymore so set raw_encap/decap commands should only c
On Mon, Nov 09, 2020 at 09:16:27AM +0100, Morten Brørup wrote:
> +CC techboard
>
> > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > Sent: Monday, November 9, 2020 6:18 AM
> >
> > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon
> > wrote:
> > >
> > > 07/11/2020 20:05, Jerin Jacob:
> > > > On
On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote:
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Saturday, November 7, 2020 4:53 PM
> >
> > The mempool pointer in the mbuf struct is moved
> > from the second to the first half.
> > It should increase performance on mo
From: Viacheslav Ovsiienko
> The Rx queue completion consumer index got temporary wrong value pointing
> to the midst of the compressed CQE session. If application crashed at the
> moment the next queue restart caused handling wrong CQEs pointed by index
> and losing consuming index synchronizat
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Monday, November 9, 2020 11:06 AM
>
> On Mon, Nov 09, 2020 at 09:16:27AM +0100, Morten Brørup wrote:
> > +CC techboard
> >
> > > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > > Sent: Monday, November 9, 2020 6:1
On 11/7/2020 5:30 PM, Matan Azrad wrote:
Hi Ferruh
From: Ferruh Yigit
On 11/5/2020 9:32 PM, Matan Azrad wrote:
When an age action becomes aged-out the rte_flow_get_aged_flows should
return the action context supplied by the configuration structure.
In case the age action created by the shared
From: Viacheslav Ovsiienko
> The Tx queue completion production index was not reset on Tx queue stop and
> there were completions remaining from the previous queue run. This caused
> the wrong completion queue operating and overall Tx queue malfunction on
> queue restart.
>
> Fixes: 161d103b231
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Monday, November 9, 2020 11:09 AM
>
> On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote:
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Sent: Saturday, November 7, 2020 4:53 PM
> > >
> > > The mempool
> On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote:
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Sent: Saturday, November 7, 2020 4:53 PM
> > >
> > > The mempool pointer in the mbuf struct is moved
> > > from the second to the first half.
> > > It should increase p
On Mon, Nov 09, 2020 at 10:33:41AM +, Ananyev, Konstantin wrote:
>
>
> > On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote:
> > > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > > Sent: Saturday, November 7, 2020 4:53 PM
> > > >
> > > > The mempool pointer in the mbuf s
From: Ferruh Yigit
> On 11/7/2020 5:30 PM, Matan Azrad wrote:
> > Hi Ferruh
> >
> > From: Ferruh Yigit
> >> On 11/5/2020 9:32 PM, Matan Azrad wrote:
> >>> When an age action becomes aged-out the rte_flow_get_aged_flows
> >>> should return the action context supplied by the configuration structure
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Sunday, November 8, 2020 8:46 PM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khapa..
On 11/9/2020 9:32 AM, oulijun wrote:
在 2020/11/7 0:44, Ferruh Yigit 写道:
On 11/6/2020 3:51 AM, Lijun Ou wrote:
From: Hongbo Zheng
Here adjusts some code style for making the lines more
compact and removes some static check tool warnings.
Signed-off-by: Hongbo Zheng
Signed-off-by: Lijun Ou
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Sunday, November 8, 2020 9:19 PM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khapa..
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Monday, November 9, 2020 1:25 AM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khapa..
On 11/9/2020 10:38 AM, Matan Azrad wrote:
From: Ferruh Yigit
On 11/7/2020 5:30 PM, Matan Azrad wrote:
Hi Ferruh
From: Ferruh Yigit
On 11/5/2020 9:32 PM, Matan Azrad wrote:
When an age action becomes aged-out the rte_flow_get_aged_flows
should return the action context supplied by the confi
Hi Ferruh,
Sorry for the late response, we are checking for additional impacts of this
change.
Looks like there is another fix needed, after all checks are completed we'll
submit all relevant patches.
Regards,
Dekel
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, November 9,
On 11/9/2020 11:14 AM, Dekel Peled wrote:
Hi Ferruh,
Sorry for the late response, we are checking for additional impacts of this
change.
Looks like there is another fix needed, after all checks are completed we'll
submit all relevant patches.
Thanks Dekel, appreciated.
Regards,
Dekel
--
> > > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > > Sent: Saturday, November 7, 2020 4:53 PM
> > > >
> > > > The mempool pointer in the mbuf struct is moved
> > > > from the second to the first half.
> > > > It should increase performance on most systems having 64-byte cache
> > > >
This series fixes several leaks in Vhost-user requests
handling.
Thanks to Xuan Ding from Intel for reporting these
issues.
Changes in v2:
- Fix typos in commit messages. (Chenbo)
- Remove useless closing of fds inset_log_base. (Chenbo)
Maxime Coquelin (3):
vhost: fix error path when setting m
If an error is encountered before the memory regions are
parsed, the file descriptors for these shared buffers are
leaked.
This patch fixes this by closing the message file descriptors
on error, taking care of avoiding double closing of the file
descriptors. guest_pages is also freed, even though
This patch fixes a file descriptor leak which happens
in the error path of vhost_user_set_log_base().
Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
Cc: sta...@dpdk.org
Reported-by: Xuan Ding
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/vhost_user.c | 8 +
This patch fixes a file descriptor leak which happens
in the error path of vhost_user_set_vring_kick().
Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
lib/librte_vhost/vhost_user.c | 6 ++
Device name parsing is done on all buses during device iterations at
either EAL or ethdev levels.
When a bus implements device name parsing slowly, all iterations are
impacted. Efficient implementation is important.
The DPAA bus device name parsing has two issues: it allocates dynamic
memory and
On 09/11/20 12:31 +0100, Gaetan Rivet wrote:
> Device name parsing is done on all buses during device iterations at
> either EAL or ethdev levels.
>
> When a bus implements device name parsing slowly, all iterations are
> impacted. Efficient implementation is important.
>
> The DPAA bus device na
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Monday, November 9, 2020 3:40 AM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khapa..
When it comes to comparing HW switch ID strings,
use strncmp to avoid reading past the buffer.
Fixes: e86b48aa46d4 ("net/sfc: add HW switch ID helpers")
Signed-off-by: Ivan Malov
---
drivers/net/sfc/sfc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc.
Improve the clarity of the code.
Fixes: 833cfcd590e2 ("common/sfc_efx/base: add API for querying board info")
Fixes: 312191e86eb0 ("common/sfc_efx/base: refactor version / boot info get
helper")
Signed-off-by: Ivan Malov
---
drivers/common/sfc_efx/base/efx_mcdi.c | 61 ++---
On 11/9/20 2:46 PM, Ivan Malov wrote:
> Improve the clarity of the code.
>
> Fixes: 833cfcd590e2 ("common/sfc_efx/base: add API for querying board info")
> Fixes: 312191e86eb0 ("common/sfc_efx/base: refactor version / boot info get
> helper")
>
> Signed-off-by: Ivan Malov
Acked-by: Andrew Rybc
On 11/9/20 2:46 PM, Ivan Malov wrote:
> When it comes to comparing HW switch ID strings,
> use strncmp to avoid reading past the buffer.
>
> Fixes: e86b48aa46d4 ("net/sfc: add HW switch ID helpers")
>
> Signed-off-by: Ivan Malov
Acked-by: Andrew Rybchenko
On Mon, Nov 9, 2020 at 12:32 PM Gaetan Rivet wrote:
> + delta = 0;
> + if (strncmp(name, "dpaa_bus:", 9) == 0) {
> + delta = 9;
> + } else if (strncmp(name, "name=", 5) == 0) {
> + delta = 5;
> + }
> +
> + if (sscanf(&name[delta], "fm%u-mac
On Mon, Nov 9, 2020 at 3:17 PM Bruce Richardson
wrote:
>
> On Mon, Nov 09, 2020 at 01:57:26PM +0530, Jerin Jacob wrote:
> > On Mon, Nov 9, 2020 at 1:34 PM Thomas Monjalon wrote:
> > >
> > > 09/11/2020 06:18, Jerin Jacob:
> > > > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon
> > > > wrote:
> >
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Monday, November 9, 2020 7:26 PM
> To: dev@dpdk.org; Ding, Xuan ;
> step...@networkplumber.org; tho...@monjalon.net; sta...@dpdk.org; Xia,
> Chenbo
> Cc: Maxime Coquelin
> Subject: [PATCH v2 2/3] vhost: fix fd leak in dirty
On 11/9/20 1:07 PM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Monday, November 9, 2020 7:26 PM
>> To: dev@dpdk.org; Ding, Xuan ;
>> step...@networkplumber.org; tho...@monjalon.net; sta...@dpdk.org; Xia,
>> Chenbo
>> Cc: Maxime Coquelin
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Saturday, November 7, 2020 12:53 AM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khap
This series fixes several leaks in Vhost-user requests
handling.
Thanks to Xuan Ding from Intel for reporting these
issues.
Changes in v3:
- Remove the right closing of fds. (Chenbo)
Changes in v2:
- Fix typos in commit messages. (Chenbo)
- Remove useless closing of fds in set_log_base. (Chenbo)
If an error is encountered before the memory regions are
parsed, the file descriptors for these shared buffers are
leaked.
This patch fixes this by closing the message file descriptors
on error, taking care of avoiding double closing of the file
descriptors. guest_pages is also freed, even though
This patch fixes a file descriptor leak which happens
in the error path of vhost_user_set_log_base().
Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
Cc: sta...@dpdk.org
Reported-by: Xuan Ding
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/vhost_user.c | 8 +
This patch fixes a file descriptor leak which happens
in the error path of vhost_user_set_vring_kick().
Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
lib/librte_vhost/vhost_user.c | 6 ++
On Fri, Oct 23, 2020 at 1:23 PM Maxime Coquelin
wrote:
> On 10/22/20 10:59 AM, Cheng Jiang wrote:
> > This patch set makes vhost-vswitch be able to use vhost async APIs
> > for enqueue operations. Demonstrated how the application
> > leverage IOAT DMA channel with vhost async APIs.
> >
> > We intr
On Mon, Nov 09, 2020 at 12:12:48PM +, Juraj Linkeš wrote:
>
>
> > -Original Message-
> > From: Honnappa Nagarahalli
> > Sent: Saturday, November 7, 2020 12:53 AM
> > To: Juraj Linkeš ; bruce.richard...@intel.com;
> > Ruifeng Wang ; Phil Yang ;
> > vcchu...@amazon.com; Dharmik Thakkar
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Sunday, November 8, 2020 3:51 AM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khapa..
09/11/2020 13:01, Jerin Jacob:
> Hi @Thomas Monjalon
>
> Any specific reason why you removed the static assert from octeontx2.
I have a build failure when cross-compiling for octeontx2.
> I am not able to compilation issue with that static assert.
There is no issue when compiling for x86.
> Th
32 bit still uses the pkgconfig file for 64-bits libraries, from the
build log:
"
Using DPDK_TARGET i386-pc-linux-gnu
meson -Dexamples=l3fwd --buildtype=debugoptimized --werror
-Dc_args=-m32 -Dc_link_args=-m32
/tmp/dpdk_maintain/self/dpdk/devtools/.. ./build-32b
...
Using 'PKG_CONFIG_PATH' from e
09/11/2020 14:00, Ferruh Yigit:
> 32 bit still uses the pkgconfig file for 64-bits libraries, from the
> build log:
>
> "
> Using DPDK_TARGET i386-pc-linux-gnu
> meson -Dexamples=l3fwd --buildtype=debugoptimized --werror
> -Dc_args=-m32 -Dc_link_args=-m32
> /tmp/dpdk_maintain/self/dpdk/devtools/.
On 11/9/2020 1:19 PM, Thomas Monjalon wrote:
09/11/2020 14:00, Ferruh Yigit:
32 bit still uses the pkgconfig file for 64-bits libraries, from the
build log:
"
Using DPDK_TARGET i386-pc-linux-gnu
meson -Dexamples=l3fwd --buildtype=debugoptimized --werror
-Dc_args=-m32 -Dc_link_args=-m32
/tmp/dp
'uint64_t' is used to hold the pointer, for 32-bits build this
assumption is wrong and giving following build error:
rte_eth_af_xdp.c: In function ‘xdp_umem_configure’:
rte_eth_af_xdp.c:970:15:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
970
On Mon, Nov 09, 2020 at 01:24:28PM +, Ferruh Yigit wrote:
> On 11/9/2020 1:19 PM, Thomas Monjalon wrote:
> > 09/11/2020 14:00, Ferruh Yigit:
> > > 32 bit still uses the pkgconfig file for 64-bits libraries, from the
> > > build log:
> > >
> > > "
> > > Using DPDK_TARGET i386-pc-linux-gnu
> > >
On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote:
>
> 09/11/2020 13:01, Jerin Jacob:
> > Hi @Thomas Monjalon
> >
> > Any specific reason why you removed the static assert from octeontx2.
>
> I have a build failure when cross-compiling for octeontx2.
I am trying the below command, I am not abl
On 09/11/20 12:58 +0100, David Marchand wrote:
> On Mon, Nov 9, 2020 at 12:32 PM Gaetan Rivet wrote:
> > + delta = 0;
> > + if (strncmp(name, "dpaa_bus:", 9) == 0) {
> > + delta = 9;
> > + } else if (strncmp(name, "name=", 5) == 0) {
> > + delta = 5;
>
Device name parsing is done on all buses during device iterations at
either EAL or ethdev levels.
When a bus implements device name parsing slowly, all iterations are
impacted. Efficient implementation is important.
The DPAA bus device name parsing has two issues: it allocates dynamic
memory and
在 2020/11/7 0:45, Ferruh Yigit 写道:
On 11/6/2020 3:51 AM, Lijun Ou wrote:
Here adds a check for the return value when calling
rte_pci_write_config.
Coverity issue: 363714
Fixes: cea37e513329 ("net/hns3: fix FLR reset")
Cc: sta...@dpdk.org
Signed-off-by: Lijun Ou
---
V1->V2:
- rte_pci_wirte_
On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote:
> This patch renames the enum values in the EAL include files.
> As a backward compatible temporary migration tool, define
> a replacement mapping for old values.
>
> The old names relating to blacklist and whitelist are replaced
>
09/11/2020 14:35, Bruce Richardson:
> On Mon, Nov 09, 2020 at 01:24:28PM +, Ferruh Yigit wrote:
> > On 11/9/2020 1:19 PM, Thomas Monjalon wrote:
> > > 09/11/2020 14:00, Ferruh Yigit:
> > > > 32 bit still uses the pkgconfig file for 64-bits libraries, from the
> > > > build log:
> > > >
> > > >
09/11/2020 14:35, Jerin Jacob:
> On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote:
> >
> > 09/11/2020 13:01, Jerin Jacob:
> > > Hi @Thomas Monjalon
> > >
> > > Any specific reason why you removed the static assert from octeontx2.
> >
> > I have a build failure when cross-compiling for octeontx
On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote:
>
> 09/11/2020 14:35, Jerin Jacob:
> > On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote:
> > >
> > > 09/11/2020 13:01, Jerin Jacob:
> > > > Hi @Thomas Monjalon
> > > >
> > > > Any specific reason why you removed the static assert from octe
Unlike TCP, UDP checksums are optional and may be zero to indicate "not
set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add
this special case to the checksum offload emulation in net/tap.
Signed-off-by: Michael Pfeiffer
---
drivers/net/tap/rte_eth_tap.c | 13 +++--
1
在 2020/11/7 0:57, Ferruh Yigit 写道:
On 11/6/2020 3:51 AM, Lijun Ou wrote:
From: Chengchang Tang
The FLR will resets the queue enabling status. In the
current code, the queue enabling status is not restored
after the reset. Therefore, if upper layer users have
called queue start/stop function
Here adds a check for the return value when calling
rte_pci_write_config.
Coverity issue: 363714
Fixes: cea37e513329 ("net/hns3: fix FLR reset")
Cc: sta...@dpdk.org
Signed-off-by: Lijun Ou
---
V2->V3:
- drop the un-related change
V1->V2:
- no fix
---
drivers/net/hns3/hns3_ethdev_vf.c | 8 +
From: Hongbo Zheng
According to bit operator reliability style, variables in
the right expression participating int bit operation
must be an unsigned type.
Signed-off-by: Hongbo Zheng
Signed-off-by: Lijun Ou
---
V2->V3:
- fix commit log for correct descriptions
- fix unnecessary variable decla
Here series include four coverity tool warnings fixes
and a bug fixes.
V2->V3:
1. fix some checkpatch warnings for patch[3]
2. split patch[3/6] into two independent patchse[3/6]
and patch[6/6] according to Ferruh Yigit's advice
3. rewrite commit log for patch[5/5]
4. rewrite the patch title for
From: Hongbo Zheng
According to the rule of the used static check tool,
each member is initialized on a separate lines when
struct and union members are initialized, here is
tempting to adjust some code lines in order to remove
the warning.
Signed-off-by: Hongbo Zheng
Signed-off-by: Lijun Ou
-
From: Chengchang Tang
FLR operation will reset the queue enabling state and
the driver needs to restore the state after reset. As
a result, it will result in unpredictable behavior with
reseted when user start or stop queue by calling the
relatived function if the driver does not do this.
This p
According to the rule of the static check tools
that arrange blank lines properly to keep the
code compact, here remove some unncessary blank
line to fix the above rule warning.
Signed-off-by: Lijun Ou
---
drivers/net/hns3/hns3_cmd.c| 1 -
drivers/net/hns3/hns3_ethdev.c | 6 +-
drivers
From: Hongbo Zheng
In current driver print log function, some print format
symbols does not match with the actual variable types.
Signed-off-by: Hongbo Zheng
Signed-off-by: Lijun Ou
---
drivers/net/hns3/hns3_dcb.c | 10 +-
drivers/net/hns3/hns3_ethdev.c| 32 -
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Friday, November 6, 2020 7:16 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Alexander Kozyrev
> ; Matan Azrad ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix Rx queues completion index consistency
>
> The Rx queue comple
09/11/2020 15:08, Jerin Jacob:
> On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote:
> > 09/11/2020 14:35, Jerin Jacob:
> > > Are you facing the issue with 32bit? Could you share the steps to
> > > reproduce and gcc version?
> >
> > Oh you're right, the issue was with 32-bit build,
>
> Thanks
>
On Mon, Nov 9, 2020 at 8:12 PM Thomas Monjalon wrote:
>
> 09/11/2020 15:08, Jerin Jacob:
> > On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote:
> > > 09/11/2020 14:35, Jerin Jacob:
> > > > Are you facing the issue with 32bit? Could you share the steps to
> > > > reproduce and gcc version?
> >
If the 'PKG_CONFIG_PATH' is set in the environment before script run,
32 bit still uses that value for 64-bits libraries.
>From the build log:
"
Using DPDK_TARGET i386-pc-linux-gnu
meson -Dexamples=l3fwd --buildtype=debugoptimized --werror
-Dc_args=-m32 -Dc_link_args=-m32
/tmp/dpdk_maintain/self
Any EAL memory allocation often goes through eal_get_virtual_area()
function, which will print a warning whenever the resulting allocation
didn't match the specified address requirements. This is useful for
when we have requested a specific base virtual address, to let the user
know that the mappin
09/11/2020 15:55, Ferruh Yigit:
> If the 'PKG_CONFIG_PATH' is set in the environment before script run,
> 32 bit still uses that value for 64-bits libraries.
>
> From the build log:
>
> "
> Using DPDK_TARGET i386-pc-linux-gnu
> meson -Dexamples=l3fwd --buildtype=debugoptimized --werror
> -Dc_arg
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Friday, November 6, 2020 6:58 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Alexander Kozyrev
> ; Matan Azrad ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix Tx queue completions on stop
>
> The Tx queue completion produ
On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote:
> 09/11/2020 15:55, Ferruh Yigit:
> > If the 'PKG_CONFIG_PATH' is set in the environment before script run,
> > 32 bit still uses that value for 64-bits libraries.
> >
> > From the build log:
> >
> > "
> > Using DPDK_TARGET i386-pc-
Any EAL memory allocation often goes through eal_get_virtual_area()
function, which will print a warning whenever the resulting allocation
didn't match the specified address requirements. This is useful for
when we have requested a specific base virtual address, to let the user
know that the mappin
On Mon, 9 Nov 2020 13:49:31 +
Bruce Richardson wrote:
> On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote:
> > This patch renames the enum values in the EAL include files.
> > As a backward compatible temporary migration tool, define
> > a replacement mapping for old values.
>
On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger
wrote:
> > This patch causes build failures which persist until patch 3, because of
> > these deprecations. I think you need to define the backward-compatibility
> > macros here, but only mark them deprecated at the end of the set.
> >
> > /Bruce
>
On Mon, Nov 09, 2020 at 07:54:40AM -0800, Stephen Hemminger wrote:
> On Mon, 9 Nov 2020 13:49:31 +
> Bruce Richardson wrote:
>
> > On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote:
> > > This patch renames the enum values in the EAL include files.
> > > As a backward compatib
On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote:
> On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger
> wrote:
> > > This patch causes build failures which persist until patch 3, because of
> > > these deprecations. I think you need to define the backward-compatibility
> > > macros he
On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson
wrote:
>
> On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote:
> > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger
> > wrote:
> > > > This patch causes build failures which persist until patch 3, because of
> > > > these deprecations. I
On Mon, Nov 09, 2020 at 05:07:16PM +0100, David Marchand wrote:
> On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson
> wrote:
> >
> > On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote:
> > > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger
> > > wrote:
> > > > > This patch causes build
09/11/2020 16:44, Bruce Richardson:
> On Mon, Nov 09, 2020 at 04:28:16PM +0100, Thomas Monjalon wrote:
> > 09/11/2020 15:55, Ferruh Yigit:
> > > If the 'PKG_CONFIG_PATH' is set in the environment before script run,
> > > 32 bit still uses that value for 64-bits libraries.
> > >
> > > From the buil
1 - 100 of 167 matches
Mail list logo
