Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Andrew Rybchenko
On 11/5/20 10:46 AM, Olivier Matz wrote: > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: >> >> Hi Olivier, >> >>> m->nb_seg must be reset on mbuf free whatever the value of m->next, >>> because it can happen that m->nb_seg is != 1. For instance in this >>> case: >>> >>> m

Re: [dpdk-dev] [PATCH v5 0/5] replace blacklist/whitelist with block/allow

2020-11-05 Thread David Marchand
On Sat, Oct 24, 2020 at 3:02 AM Stephen Hemminger wrote: > > This is a revised version of the earlier RFC patch set for changing > the blacklist/whitelist terms in DPDK. > > The first patch is a duplicate from the other patch set about > use of master/slave in API. > > Note: > This may cause some

[dpdk-dev] [PATCH v1] net/iavf: fix reset VF doesn't notify PF to reset

2020-11-05 Thread Steve Yang
When VF closed, the VF should notify PF to close/reset relative resources from PF side. Check the VF RSS offload flag and ignore relative operation when iavf hash uninit to avoid reset/close error. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Signed-off-by: Steve Yang --- drivers/common/iav

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Thursday, November 5, 2020 8:46 AM > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > > Hi Olivier, > > > > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > > > because it

[dpdk-dev] [PATCH] doc: fix typo in ipsec-secgw guide

2020-11-05 Thread David Marchand
Fixes: 02dc5b7d58c7 ("doc: update ipsec-secgw guide and release notes") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- doc/guides/sample_app_ug/ipsec_secgw.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sa

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask

2020-11-05 Thread Di, ChenxuX
Hi, jia > -Original Message- > From: Di, ChenxuX > Sent: Wednesday, November 4, 2020 5:49 PM > To: Guo, Jia ; dev@dpdk.org > Cc: Xing, Beilei ; Wang, Haiyue > > Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask > > Hi, Jia > > > -Original Message- > > From: Guo, Ji

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Andrew Rybchenko
On 11/4/20 11:39 PM, Thomas Monjalon wrote: > 04/11/2020 21:19, Ferruh Yigit: >> On 11/4/2020 5:55 PM, Thomas Monjalon wrote: >>> 04/11/2020 18:07, Ferruh Yigit: On 11/4/2020 4:51 PM, Thomas Monjalon wrote: > 03/11/2020 14:29, Ferruh Yigit: >> On 11/2/2020 11:48 AM, Ferruh Yigit wrote:

Re: [dpdk-dev] [PATCH] doc: fix typing error in example/l3_forward_access_ctrl

2020-11-05 Thread David Marchand
On Mon, Nov 2, 2020 at 12:20 PM Ibtisam Tariq wrote: > > Add "--" and remove extra spaces in l3fwd-acl commands. > > Fixes: d0dff9ba4 ("doc: sample application user guide") > Cc: bernard.iremon...@intel.com > > Signed-off-by: Ibtisam Tariq > --- > doc/guides/sample_app_ug/l3_forward_access_ctrl.

Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD

2020-11-05 Thread Jiawen Wu
On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > 27/10/2020 12:37, Ferruh Yigit: > > >> On 10/27/2020 2:39 AM, Jiawen Wu wrote: > > >>> On Monday, October 26, 2020 10:56 PM, F

Re: [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage

2020-11-05 Thread David Marchand
On Mon, Nov 2, 2020 at 12:56 PM Ibtisam Tariq wrote: > > Add new line character(\n) in the usage of vhost_crypto example for > better readability > > Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core") > Cc: roy.fan.zh...@intel.com > > Signed-off-by: Ibtisam Tariq > --- > examples/v

Re: [dpdk-dev] [PATCH] example/qos_sched: fix option -i in usage

2020-11-05 Thread David Marchand
On Mon, Nov 2, 2020 at 12:59 PM Ibtisam Tariq wrote: > > The short option written for interactive mode is --i in usage of > this qos_sched example. Actually, it is -i. > > Fixes: cfd5c971e5e ("examples/qos_sched: add stats") > > Signed-off-by: Ibtisam Tariq > --- > examples/qos_sched/args.c | 2

Re: [dpdk-dev] [PATCH 1/8] examples/fips_validation: enhance getopt_long usage

2020-11-05 Thread David Marchand
Hello Ibtisam, On Wed, Nov 4, 2020 at 11:00 AM Ibtisam Tariq wrote: > > + case MBUF_DATAROOM_KEYWORD_NUM: > > + { > > + uint32_t data_room_size; > > Here, I don't think we need a temp storage. > If the value is invalid, the parsing and then init w

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 09:33:58AM +0100, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > Sent: Thursday, November 5, 2020 8:46 AM > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > > > > Hi Olivier, > > > > > > > m->nb

[dpdk-dev] [PATCH v2 0/3] fix issue with partial DMA unmap

2020-11-05 Thread Nithin Dabilpuram
Partial DMA unmap is not supported by VFIO type1 IOMMU in Linux. Though the return value is zero, the returned DMA unmap size is not same as expected size. So add test case and fix to both heap triggered DMA mapping and user triggered DMA mapping/unmapping. Refer vfio_dma_do_unmap() in drivers/vfi

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

2020-11-05 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Thursday, November 5, 2020 1:26 AM > > > > > Hi, > > > > On Tue, Nov 03, 2020 at 04:03:46PM +0100, Morten Brørup wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slava > Ovsiienko > > > > Sent:

[dpdk-dev] [PATCH v2 1/3] vfio: revert changes for map contiguous areas in one go

2020-11-05 Thread Nithin Dabilpuram
In order to save DMA entries limited by kernel both for externel memory and hugepage memory, an attempt was made to map physically contiguous memory in one go. This cannot be done as VFIO IOMMU type1 does not support partially unmapping a previously mapped memory region while Heap can request for m

[dpdk-dev] [PATCH v2 3/3] test: add test case to validate VFIO DMA map/unmap

2020-11-05 Thread Nithin Dabilpuram
Test case mmap's system pages and tries to performs a user DMA map and unmap both partially and fully. Signed-off-by: Nithin Dabilpuram --- app/test/meson.build | 1 + app/test/test_vfio.c | 103 +++ 2 files changed, 104 insertions(+) create mod

[dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va

2020-11-05 Thread Nithin Dabilpuram
Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will not be same as expected. So check for returned unmap size and return error. For IOVA as PA, DMA mapping is already at memseg size granularity. Do the same even for

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Andrew Rybchenko
Just resend with lost Cc restored. On 11/5/20 10:46 AM, Olivier Matz wrote: > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: >> >> Hi Olivier, >> >>> m->nb_seg must be reset on mbuf free whatever the value of m->next, >>> because it can happen that m->nb_seg is != 1. For in

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > On 11/5/20 10:46 AM, Olivier Matz wrote: > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > >> > >> Hi Olivier, > >> > >>> m->nb_seg must be reset on mbuf free whatever the value of m->next, > >>> because

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-11-05 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, November 3, 2020 10:45 AM > To: Honnappa Nagarahalli > Cc: Juraj Linkeš ; Ruifeng Wang > ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@dpdk.org; nd > > Subject:

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2020-11-05 Thread Rong, Leyi
> -Original Message- > From: Jerin Jacob > Sent: Thursday, November 5, 2020 3:15 PM > To: Rong, Leyi > Cc: David Marchand ; Zhang, Qi Z > ; dev > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on > a lcore > > On Wed, Nov 4, 2020 at 2:34 PM Rong, Leyi wrote:

Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD

2020-11-05 Thread Thomas Monjalon
+Cc Konstantin and Honnappa for guidance 05/11/2020 09:55, Jiawen Wu: > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > When pulling in the main branch, I see some che

[dpdk-dev] [Bug 541] [dpdk-20.11] loopback_virtio_user_server_mode/Basic_test_for_packed_ring_server_mode: loopback throughput is zero

2020-11-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=541 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: unlock mutex when nios init fail

2020-11-05 Thread Zhang, Tianfei
> -Original Message- > From: dev On Behalf Of Wei Huang > Sent: 2020年11月5日 9:49 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Huang, Wei > Subject: [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: unlock mutex when nios > init fail > > In fme_nios_spi_init(), a mutex

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

2020-11-05 Thread Morten Brørup
There is a simple alternative for applications with a single mbuf pool to avoid accessing m->pool. We could add a global variable pointing to the single mbuf pool. It would be NULL by default. It would be set by rte_pktmbuf_pool_create() on first invocation, and reset back to NULL on following

Re: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter before derefence

2020-11-05 Thread Zhang, Tianfei
> -Original Message- > From: dev On Behalf Of Wei Huang > Sent: 2020年11月5日 9:49 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Huang, Wei > Subject: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter > before derefence > > In opae_adapter_destroy(),

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

2020-11-05 Thread Dharmappa, Savinay
-Original Message- From: Dumitrescu, Cristian Sent: Tuesday, October 27, 2020 3:16 PM To: Dharmappa, Savinay ; Singh, Jasvinder ; dev@dpdk.org Subject: RE: [PATCH v2] examples/qos_sched: update profile oversubscribe config file > -Original Message- > From: Dharmappa, Savin

[dpdk-dev] [PATCH v1] app/testpmd: fix the overhead overflow issue

2020-11-05 Thread Steve Yang
If "dev_info.max_mtu" isn't set by driver, the rte_ethdev will set default value "UINT16_MAX", that will cause the overhead value overflow. Add more strict condition to ensure the overhead valid. Fixes: bed05536c8f8 ("app/testpmd: fix max Rx packet length for VLAN packets") Signed-off-by: Steve

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix rxq object allocation with MPRQ

2020-11-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ophir Munk > Sent: Wednesday, November 4, 2020 9:55 AM > To: dev@dpdk.org; Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko > Cc: Ophir Munk > Subject: [PATCH v1] net/mlx5: fix rxq object allocation with MPRQ > > The space for extra buffer pointers us

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

2020-11-05 Thread Thomas Monjalon
05/11/2020 10:39, Dharmappa, Savinay: > Acked-by: Cristian Dumitrescu > Hi Thomas, > I see that this patch is not applied on rc2. When can this will be applied ? > will it be part of rc3 ?. Please let me know -rc2 was very busy, and examples were low priority. Will look into examples for -rc3.

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

2020-11-05 Thread Bruce Richardson
On Thu, Nov 05, 2020 at 10:35:45AM +0100, Morten Brørup wrote: > There is a simple alternative for applications with a single mbuf pool to > avoid accessing m->pool. > > We could add a global variable pointing to the single mbuf pool. > > It would be NULL by default. > > It would be set by rte_

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Ferruh Yigit
On 11/5/2020 9:33 AM, Yang, SteveX wrote: -Original Message- From: Andrew Rybchenko Sent: Thursday, November 5, 2020 4:54 PM To: Thomas Monjalon ; Yang, SteveX ; Yigit, Ferruh Cc: dev@dpdk.org; Ananyev, Konstantin ; Xing, Beilei ; Lu, Wenzhuo ; Iremonger, Bernard ; Yang, Qiming ; m..

[dpdk-dev] [PATCH v2] raw/ioat: fix queue index calculation

2020-11-05 Thread Bruce Richardson
Coverity flags a possible problem where the 8-bit wq_idx value may have errors when shifted and sign-extended to pointer size. Since this can only occur if the shift index is larger than any expected value from hardware, it's unlikely to cause any real problems, but we can eliminate any possible er

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Thomas Monjalon
05/11/2020 11:37, Ferruh Yigit: > On 11/5/2020 9:33 AM, Yang, SteveX wrote: > > > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Thursday, November 5, 2020 4:54 PM > >> To: Thomas Monjalon ; Yang, SteveX > >> ; Yigit, Ferruh > >> Cc: dev@dpdk.org; Ananyev, Konstantin ;

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Thomas Monjalon
+ more maintainers Cc'ed We have a critical issue with testpmd in -rc2. It is blocking a lot of testing. Would be good to do a -rc3 today. Please see below. 05/11/2020 11:44, Thomas Monjalon: > 05/11/2020 11:37, Ferruh Yigit: > > On 11/5/2020 9:33 AM, Yang, SteveX wrote: > > > From: Andrew Rybche

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Ferruh Yigit
On 11/5/2020 10:44 AM, Thomas Monjalon wrote: 05/11/2020 11:37, Ferruh Yigit: On 11/5/2020 9:33 AM, Yang, SteveX wrote: -Original Message- From: Andrew Rybchenko Sent: Thursday, November 5, 2020 4:54 PM To: Thomas Monjalon ; Yang, SteveX ; Yigit, Ferruh Cc: dev@dpdk.org; Ananyev, K

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Ferruh Yigit
On 11/5/2020 10:48 AM, Thomas Monjalon wrote: + more maintainers Cc'ed We have a critical issue with testpmd in -rc2. It is blocking a lot of testing. Would be good to do a -rc3 today. Please see below. 05/11/2020 11:44, Thomas Monjalon: 05/11/2020 11:37, Ferruh Yigit: On 11/5/2020 9:33 AM, Y

[dpdk-dev] [PATCH] test-meson-builds: add a 32-bit build

2020-11-05 Thread Bruce Richardson
It's reasonably common for patches to have issues when built on 32-bits, so to prevent this, we can add a 32-bit build (if supported) to the "test-meson-builds.sh" script. The tricky bit is using a valid PKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that should point to in

Re: [dpdk-dev] [PATCH] test-meson-builds: add a 32-bit build

2020-11-05 Thread Thomas Monjalon
05/11/2020 12:07, Bruce Richardson: > It's reasonably common for patches to have issues when built on 32-bits, so > to prevent this, we can add a 32-bit build (if supported) to the > "test-meson-builds.sh" script. The tricky bit is using a valid > PKG_CONFIG_LIBDIR, so for now we use two common pos

Re: [dpdk-dev] [PATCH] test-meson-builds: add a 32-bit build

2020-11-05 Thread Bruce Richardson
On Thu, Nov 05, 2020 at 12:13:37PM +0100, Thomas Monjalon wrote: > 05/11/2020 12:07, Bruce Richardson: > > It's reasonably common for patches to have issues when built on 32-bits, so > > to prevent this, we can add a 32-bit build (if supported) to the > > "test-meson-builds.sh" script. The tricky b

Re: [dpdk-dev] [PATCH v2 2/2] raw/ifpga/base: check pointer adapter before dereference

2020-11-05 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Thursday, November 05, 2020 10:06 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Huang, Wei > Subject: [PATCH v2 2/2] raw/ifpga/base: check pointer adapter before > dereference > > In opae_adapter_destroy(), poin

Re: [dpdk-dev] [PATCH v2 1/2] raw/ifpga/base: unlock mutex when nios init fail

2020-11-05 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Thursday, November 05, 2020 10:06 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Huang, Wei > Subject: [PATCH v2 1/2] raw/ifpga/base: unlock mutex when nios init fail > > In fme_nios_spi_init(), a mutex is locked

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Ananyev, Konstantin
> On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > >> > > >> Hi Olivier, > > >> > > >>> m->nb_seg must be reset on mbuf free whatever the value of m->next,

[dpdk-dev] [PATCH 0/3] vhost: fix fd an memory leaks

2020-11-05 Thread Maxime Coquelin
This series fixes several leaks in Vhost-user requests handling. Thanks to Xuan Ding from Intel for reporting these issues. Maxime Coquelin (3): vhost: fix error path when setting memory tables vhost: fix fd leak in dirty logging setup vhost: fix fd leak in kick setup lib/librte_vhost/vho

[dpdk-dev] [PATCH 1/3] vhost: fix error path when setting memory tables

2020-11-05 Thread Maxime Coquelin
If the an error is encountered before the memory regions are parsed, the file descriptors for these shared buffers is leaked. This patch fixes this by closing the message file descriptors on error, taking care of avoiding double closing of the file descriptors. guest_pages is also freed, even thou

[dpdk-dev] [PATCH 3/3] vhost: fix fd leak in kick setup

2020-11-05 Thread Maxime Coquelin
This patch fixes a file descriptor leak which happens in the error path of vhost_user_set_vring_kick(). Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 6 +- 1 file changed, 5 i

[dpdk-dev] [PATCH 2/3] vhost: fix fd leak in dirty logging setup

2020-11-05 Thread Maxime Coquelin
This patch fixes a file descriptor leak which happens in the error path of vhost_user_set_log_base(). Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") Cc: sta...@dpdk.org Reported-by: Xuan Ding Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 10

Re: [dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing

2020-11-05 Thread Xu, Rosen
Hi, > -Original Message- > From: David Marchand > Sent: Wednesday, November 04, 2020 17:41 > To: dev@dpdk.org > Cc: Richardson, Bruce ; > robin.ja...@6wind.com; step...@networkplumber.org; > olivier.m...@6wind.com; Neil Horman ; Xu, > Rosen ; Andrew Rybchenko > ; Luca Boccassi > Subject:

Re: [dpdk-dev] [PATCH v3] usertools: fix pmdinfo parsing

2020-11-05 Thread Bruce Richardson
On Wed, Nov 04, 2020 at 05:48:27PM +0100, David Marchand wrote: > On Wed, Nov 4, 2020 at 5:36 PM Bruce Richardson > wrote: > > > > On Wed, Nov 04, 2020 at 04:57:21PM +0100, David Marchand wrote: > > > This script inspects an ELF file (binary or shared library) and its > > > linked dependencies by

Re: [dpdk-dev] [PATCH] mlx5/net: fix release of SQ resources in error flow

2020-11-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Tal Shnaiderman > Sent: Wednesday, October 28, 2020 7:11 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] mlx5/net: fix release of S

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > >> > > > >> Hi Olivier,

[dpdk-dev] [PATCH v4] build: add pkg-config validation

2020-11-05 Thread Gregory Etelson
DPDK relies on pkg-config(1) to provide correct parameters for compiler and linker used in application build. Inaccurate build parameters, produced by pkg-config from DPDK .pc files could fail application build or cause unpredicted results during application runtime. This patch validates host pkg-

[dpdk-dev] DPDK Release Status Meeting 5/11/2020

2020-11-05 Thread Ferruh Yigit
Meeting minutes of 5 November 2020 -- Agenda: * Release Dates * Highlights * -rc2 status * Subtrees Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * NXP * Red Hat Release Dates - * v20.11 dates * -rc2 is released on

Re: [dpdk-dev] [PATCH] test-meson-builds: add a 32-bit build

2020-11-05 Thread Thomas Monjalon
05/11/2020 12:21, Bruce Richardson: > On Thu, Nov 05, 2020 at 12:13:37PM +0100, Thomas Monjalon wrote: > > 05/11/2020 12:07, Bruce Richardson: > > > It's reasonably common for patches to have issues when built on 32-bits, > > > so > > > to prevent this, we can add a 32-bit build (if supported) to

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Ananyev, Konstantin
> > On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > > >> > >

Re: [dpdk-dev] [PATCH v4] build: add pkg-config validation

2020-11-05 Thread Bruce Richardson
On Thu, Nov 05, 2020 at 02:37:03PM +0200, Gregory Etelson wrote: > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. > Inaccurate build parameters, produced by pkg-config from DPDK .pc > files could fail application build or cause unpred

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 01:14:07PM +, Ananyev, Konstantin wrote: > > > > > > On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > > > > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > >

Re: [dpdk-dev] [PATCH v2] common/mlx5: free MR resource while device DMA unmap

2020-11-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei Wang > Sent: Monday, November 2, 2020 4:22 AM > To: Slava Ovsiienko ; Matan Azrad > ; Shahaf Shuler ; Ori Kam > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v2] common/mlx5: free MR resource while device DMA > unmap >

Re: [dpdk-dev] [PATCH v3] cmdline: avoid name clash with Windows system types

2020-11-05 Thread Olivier Matz
On Fri, Oct 30, 2020 at 04:01:26AM +0300, Dmitry Kozlyuk wrote: > cmdline_numtype member names clash with Windows system identifiers. > Add RTE_ prefix to cmdline constants to avoid this and possible > future conflicts. > > Suggested-by: Ranjit Menon > Signed-off-by: Dmitry Kozlyuk Acked-by: Ol

Re: [dpdk-dev] [PATCH v4] mbuf: minor cleanup

2020-11-05 Thread Olivier Matz
On Mon, Oct 26, 2020 at 03:42:01PM +0100, Morten Brørup wrote: > The mbuf header files had some commenting style errors that affected the > API documentation. > Also, the RTE_ prefix was missing on a macro and a definition. > > Note: This patch does not touch the offload and attachment flags that

[dpdk-dev] [PATCH] mempool: fix ignore return value Coverity issue

2020-11-05 Thread David Hunt
Coverity flags that rte_mempool_ops_dequeue_bulk() is called without checking the return value. This ignoring is intentional, so this patch gets the return code, then uses RTE_SET_USED so that Coverity will be happy. Coverity issue: 363744 Fixes: 449c49b93a6b ("mempool: support handler operations

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 10:50:45AM +, Ferruh Yigit wrote: > On 11/5/2020 10:48 AM, Thomas Monjalon wrote: > > + more maintainers Cc'ed > > > > We have a critical issue with testpmd in -rc2. > > It is blocking a lot of testing. > > Would be good to do a -rc3 today. > > Please see below. > > >

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Ananyev, Konstantin
> > > > > > > > On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > > > > > > > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, K

[dpdk-dev] [PATCH] BBDEV: add LDPC op parameters and flags to support CBGT

2020-11-05 Thread Aidan Goddard
This commit adds support to BBDEV for LDPC Code Block Group Transmission (CBGT) as defined in 3GPP TS 38.214. The following changes facilitate this: - add RTE_BBDEV_LDPC_[ENC/DEC]_CBGT feature flag - add CBGT input parameters to LDPC encode transport block op structure - add CBGT input and output p

Re: [dpdk-dev] [PATCH] mempool: fix ignore return value Coverity issue

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 01:51:14PM +, David Hunt wrote: > Coverity flags that rte_mempool_ops_dequeue_bulk() is called without > checking the return value. > > This ignoring is intentional, so this patch gets the return code, then > uses RTE_SET_USED so that Coverity will be happy. > > Coveri

[dpdk-dev] test: fix bypassed out of place test

2020-11-05 Thread Fan Zhang
This patch fixes bypassed out of place test for PMDs that support it. Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API") Cc: roy.fan.zh...@intel.com Signed-off-by: Fan Zhang --- app/test/test_cryptodev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/test/test_crypto

[dpdk-dev] [PATCH v7 01/14] build: alias default build as generic

2020-11-05 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

[dpdk-dev] [PATCH v7 00/14] Arm build options rework

2020-11-05 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds.

[dpdk-dev] [PATCH v7 03/14] build: remove unused or superfluous variables

2020-11-05 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/config/arm/meson.build b/config/arm/

[dpdk-dev] [PATCH v7 02/14] build: rename Arm build variables

2020-11-05 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v7 04/14] build: reformat and move Arm config and comments

2020-11-05 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v7 06/14] build: organize Arm config into dict

2020-11-05 Thread Juraj Linkeš
Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v7 05/14] build: simplify how Arm flags are processed

2020-11-05 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 05c

[dpdk-dev] [PATCH v7 07/14] build: isolate configuration for generic build

2020-11-05 Thread Juraj Linkeš
Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v7 09/14] ci: switch to generic Arm builds

2020-11-05 Thread Juraj Linkeš
Switch to generic build on arm Travis machines to avoid differences in build configuration caused by different Arm hardware. Signed-off-by: Juraj Linkeš --- .ci/linux-build.sh | 4 1 file changed, 4 insertions(+) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index d079801d7..7fe0fcf

[dpdk-dev] [PATCH v7 10/14] build: optional NUMA and cpu counts detection

2020-11-05 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

[dpdk-dev] [PATCH v7 08/14] build: use native machine args in Arm native build

2020-11-05 Thread Juraj Linkeš
Letting the compiler decide is going to yield the best results for native builds, so use native machine args. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 54 ++ 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/config/arm/meson.b

[dpdk-dev] [PATCH v7 11/14] build: add core and NUMA counts to cross files

2020-11-05 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc | 2 ++ config/arm/arm64_armv8_linux_gcc

[dpdk-dev] [PATCH v7 12/14] build: disable Arm drivers

2020-11-05 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Remove unneeded driver options ported from the old makefile system. Add support for removing

[dpdk-dev] [PATCH v7 13/14] build: disable libnuma in cross builds

2020-11-05 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disabled NUMA in Arm cross files. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 1 + config/arm/arm64_armv8_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1 + conf

[dpdk-dev] [PATCH v7 14/14] build: add Arm SoC meson option

2020-11-05 Thread Juraj Linkeš
Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš --- config/arm/arm6

Re: [dpdk-dev] test: fix bypassed out of place test

2020-11-05 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of Fan Zhang > Sent: Thursday, 5 November, 2020 14:59 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan > Subject: [dpdk-dev] test: fix bypassed out of place test > > This patch fixes bypassed out of place test for PMDs that support i

Re: [dpdk-dev] [PATCH v7 06/14] build: organize Arm config into dict

2020-11-05 Thread Juraj Linkeš
> -Original Message- > From: Juraj Linkeš > Sent: Thursday, November 5, 2020 2:59 PM > To: bruce.richard...@intel.com; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; phil.y...@arm.com; > vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH v7 07/14] build: isolate configuration for generic build

2020-11-05 Thread Juraj Linkeš
> -Original Message- > From: Juraj Linkeš > Sent: Thursday, November 5, 2020 2:59 PM > To: bruce.richard...@intel.com; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; phil.y...@arm.com; > vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com;

[dpdk-dev] [PATCH v2] BBDEV: add LDPC op parameters and flags to support CBGT

2020-11-05 Thread Aidan Goddard
This commit adds support to BBDEV for LDPC Code Block Group Transmission (CBGT) as defined in 3GPP TS 38.214. The following changes facilitate this: - add RTE_BBDEV_LDPC_[ENC/DEC]_CBGT feature flag - add CBGT input parameters to LDPC encode transport block op structure - add CBGT input and output p

[dpdk-dev] [PATCH 4/5] net/hns3: check PCI config space writes

2020-11-05 Thread Lijun Ou
Here adds a check for the return value when calling rte_pci_wirte_config. Coverity issue: 363714 Fixes: cea37e513329 ("net/hns3: fix FLR reset") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_ethdev_vf.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) di

[dpdk-dev] [PATCH 1/5] net/hns3: use correct logging format symbol

2020-11-05 Thread Lijun Ou
From: Hongbo Zheng In current driver print log function, some print format symbols does not match with the actual variable types. Signed-off-by: Hongbo Zheng Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_dcb.c | 10 +- drivers/net/hns3/hns3_ethdev.c| 32 -

[dpdk-dev] [PATCH 5/5] net/hns3: fix queue enabling status not store after FLR

2020-11-05 Thread Lijun Ou
From: Chengchang Tang The FLR will resets the queue enabling status. In the current code, the queue enabling status is not restored after the reset. Therefore, if upper layer users have called queue start/stop function before the reset, the behavior after the reset is not as expected. This patch

[dpdk-dev] [PATCH 0/5] bugfix and cleanups for hns3

2020-11-05 Thread Lijun Ou
Here series include four coverity tool warnings fixes and a bug fixes. Chengchang Tang (1): net/hns3: fix queue enabling status not store after FLR Hongbo Zheng (3): net/hns3: use correct logging format symbol net/hns3: use unsigned types for bit operator net/hns3: adjust some code style

[dpdk-dev] [PATCH 2/5] net/hns3: use unsigned types for bit operator

2020-11-05 Thread Lijun Ou
From: Hongbo Zheng According to bit operator reliability style, variables in the right expression participating int bit operation cannot be of unsigned type. Signed-off-by: Hongbo Zheng Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- drivers/net/hns3/hns3_rxtx_vec_n

[dpdk-dev] [PATCH 3/5] net/hns3: adjust some code style

2020-11-05 Thread Lijun Ou
From: Hongbo Zheng Here adjusts some code style for making the lines more compact and removes some static check tool warnings. Signed-off-by: Hongbo Zheng Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.c| 1 - drivers/net/hns3/hns3_ethdev.c | 2 - drivers/net/hns3/hns3_ethdev.h

[dpdk-dev] [PATCH v3] BBDEV: add LDPC op parameters and flags to support CBGT

2020-11-05 Thread Aidan Goddard
This commit adds support to BBDEV for LDPC Code Block Group Transmission (CBGT) as defined in 3GPP TS 38.214. The following changes facilitate this: - add RTE_BBDEV_LDPC_[ENC/DEC]_CBGT feature flag - add CBGT input parameters to LDPC encode transport block op structure - add CBGT input and output p

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix the overhead overflow issue

2020-11-05 Thread Ferruh Yigit
On 11/5/2020 9:51 AM, Steve Yang wrote: If "dev_info.max_mtu" isn't set by driver, the rte_ethdev will set default value "UINT16_MAX", that will cause the overhead value overflow. Add more strict condition to ensure the overhead valid. Fixes: bed05536c8f8 ("app/testpmd: fix max Rx packet length

Re: [dpdk-dev] [PATCH] net/mlx5: fix the eCPRI common header endianness

2020-11-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Tuesday, November 3, 2020 7:42 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the eCPRI common header endianness > > The input header of a RTE

Re: [dpdk-dev] [PATCH] net/mlx5: fix eCPRI previous layer checking

2020-11-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Tuesday, November 3, 2020 7:43 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix eCPRI previous layer checking > > Based on the specification, eC

Re: [dpdk-dev] [PATCH v10 1/5] net/bnxt: add support for aarch32

2020-11-05 Thread Ruifeng Wang
> -Original Message- > From: Lance Richardson > Sent: Thursday, November 5, 2020 9:42 PM > To: Ruifeng Wang > Cc: Juraj Linkeš ; tho...@monjalon.net; > Bruce Richardson ; acon...@redhat.com; > maicolgabr...@hotmail.com; dev@dpdk.org; nd > Subject: Re: [dpdk-dev] [PATCH v10 1/5] net/bnxt

[dpdk-dev] [PATCH] table: fix exact match lookup

2020-11-05 Thread Cristian Dumitrescu
Fix for the exact match lookup function. Fixes: d0a00966618b ("table: add exact match SWX table") Signed-off-by: Cristian Dumitrescu Signed-off-by: Churchill Khangar --- lib/librte_table/rte_swx_table_em.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_t

[dpdk-dev] [PATCH 2/2] doc: update build guide for armv8 crypto PMD

2020-11-05 Thread Dharmik Thakkar
Remove build steps about using meson option armv8_crypto_dir. Add build steps about using pkg-config. Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- doc/guides/cryptodevs/armv8.rst | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) di

[dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build

2020-11-05 Thread Dharmik Thakkar
With pkg-config support available within AArch64crypto library, meson option 'armv8_crypto_dir' can be removed. PKG_CONFIG_PATH environment variable should be set appropriately to use the crypto library. Refer [1] for build instructions. [1] https://doc.dpdk.org/guides/cryptodevs/armv8.html Sugg

  1   2   >