[dpdk-dev] [PATCH v4 02/16] mbuf: add Rx timestamp flag and helpers

There is already a dynamic field for timestamp, used only for Tx scheduling with the dedicated Tx offload flag. The same field can be used for Rx timestamp filled by drivers. A new dynamic flag is defined for Rx usage. A new function wraps the registration of both field and Rx flag. The type rte_m

[dpdk-dev] [PATCH v4 04/16] net/ark: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related dynamic mbuf flag is set, although was missing previously. The timestamp is set if configured for at least one device. Signed-off-by: Thomas Monjalon Acked-by: David Marchand ---

[dpdk-dev] [PATCH v4 05/16] net/dpaa2: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: Hemant Agrawal Acked-by: David Marchand --- drivers/net/dpaa2/dpaa2_ethdev.c | 11 +++ drivers/net/d

[dpdk-dev] [PATCH v4 07/16] net/mlx5: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. The dynamic offset and flag are stored in struct mlx5_rxq_data to favor cache locality. Signed-off-by: Thomas Monjalon Reviewed-by: Ruifeng Wang Revie

[dpdk-dev] [PATCH v4 06/16] net/mlx5: fix dynamic mbuf offset lookup check

The functions rte_mbuf_dynfield_lookup() and rte_mbuf_dynflag_lookup() can return an offset starting with 0 or a negative error code. In reality the first offsets are probably reserved forever, but for the sake of strict API compliance, the checks which considered 0 as an error are fixed. Fixes:

[dpdk-dev] [PATCH v4 09/16] net/octeontx2: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. The dynamic offset and flag are stored in struct otx2_timesync_info to favor cache locality. Signed-off-by: Thomas Monjalon Acked-by: David Marchand -

[dpdk-dev] [PATCH v4 10/16] net/pcap: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- drivers/net/pcap/rte_eth_pcap.c | 20 +--- 1 file changed, 17 insertions(+

[dpdk-dev] [PATCH v4 08/16] net/nfb: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- drivers/net/nfb/nfb_rx.c | 15 ++- drivers/net/nfb/nfb_rx.h | 21 +

[dpdk-dev] [PATCH v4 11/16] app/testpmd: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- app/test-pmd/util.c | 38 -- 1 file changed, 36 insert

[dpdk-dev] [PATCH v4 12/16] examples/rxtx_callbacks: switch timestamp to dynamic field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- examples/rxtx_callbacks/main.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/examples/rxtx_

[dpdk-dev] [PATCH v4 14/16] mbuf: remove deprecated timestamp field

As announced in the deprecation note, the field timestamp is removed to give more space to the dynamic fields. The related offload flag PKT_RX_TIMESTAMP is also removed. This is how the mbuf layout looks like (pahole-style): word type namebyte size

[dpdk-dev] [PATCH v4 13/16] ethdev: add doxygen comment for Rx timestamp API

The offload flag DEV_RX_OFFLOAD_TIMESTAMP had no documentation. After switching to dynamic mbuf flag and field, it becomes even more important to explicit the feature behaviour. A doxygen comment for the timesync API was mentioning the deprecated timestamp field, so it is also updated. Signed-off

[dpdk-dev] [PATCH v4 15/16] mbuf: add Tx timestamp registration helper

The function rte_mbuf_dyn_tx_timestamp_register() can be used to register the required field and flag. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- lib/librte_mbuf/rte_mbuf_dyn.c | 7 +++ lib/librte_mbuf/rte_mbuf_dyn.h | 22 ++ lib/librte_mbuf/version.map

[dpdk-dev] [PATCH v4 16/16] ethdev: include mbuf registration in Tx timestamp API

Previously, the Tx timestamp field and flag were registered in testpmd, as described in mlx5 guide. For consistency between Rx and Tx timestamps, managing mbuf registrations inside the driver, as properly documented, is a simpler expectation. The only driver to support this feature (mlx5) is updat

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix cpu crypto cipher auth

Hi Akhil, Pablo's patch actually fixed the problem I was trying to fix. I rejected this patch. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Monday, November 2, 2020 7:57 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Subject: RE: [PATCH] crypto/aesni_mb: fix cpu crypto ciphe

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

On Tue, Nov 03, 2020 at 01:10:05PM +0100, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, November 2, 2020 4:58 PM > > > > +Cc techboard > > > > We need benchmark numbers in order to take a decision. > > Please all, prepare some arguments and numbers

Re: [dpdk-dev] [PATCH v4 02/16] mbuf: add Rx timestamp flag and helpers

On 11/3/20 3:21 PM, Thomas Monjalon wrote: > There is already a dynamic field for timestamp, > used only for Tx scheduling with the dedicated Tx offload flag. > The same field can be used for Rx timestamp filled by drivers. > > A new dynamic flag is defined for Rx usage. > A new function wraps the

Re: [dpdk-dev] [PATCH 1/8] ionic: update documentation and MAINTAINERS

On 11/2/2020 6:35 PM, Andrew Boyer wrote: The ionic PMD is being actively maintained. Signed-off-by: Andrew Boyer --- MAINTAINERS | 5 +++-- doc/guides/nics/ionic.rst | 13 +++-- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[dpdk-dev] [PATCH v2 0/7] fix driver filenames in the docs

Since the driver filenames are now following a new standard naming convention some doc updates are necessary. V2: dropped patch 1, no longer necessary to fix meson.build file. added two additional fixes to crypto doc patch Bruce Richardson (7): doc: fix driver names in compress

[dpdk-dev] [PATCH v2 1/7] doc: fix driver names in compression devices guide

Since the built driver filenames have changed in DPDK 20.11, we need to update the driver doc to match. Fixes: a20b2c01a7a1 ("build: standardize component names and defines") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand --- doc/guides/compressdevs/isal.rst | 2 +- doc/guides

[dpdk-dev] [PATCH v2 2/7] doc: fix driver names in crypto devices guide

Since the built driver filenames have changed in DPDK 20.11, we need to update the driver doc to match. Fixes: a20b2c01a7a1 ("build: standardize component names and defines") Signed-off-by: Bruce Richardson --- V2: added two missed driver name changes --- doc/guides/cryptodevs/aesni_gcm.rst |

[dpdk-dev] [PATCH v2 3/7] doc: fix driver names in event devices guide

Since the built driver filenames have changed in DPDK 20.11, we need to update the driver doc to match. Fixes: a20b2c01a7a1 ("build: standardize component names and defines") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand --- doc/guides/eventdevs/octeontx.rst | 2 +- doc/guides/e

[dpdk-dev] [PATCH v2 5/7] doc: fix driver names in regex devices guide

Since the built driver filenames have changed in DPDK 20.11, we need to update the driver doc to match. Fixes: a20b2c01a7a1 ("build: standardize component names and defines") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand --- doc/guides/regexdevs/mlx5.rst | 4 ++-- doc/guides

[dpdk-dev] [PATCH v2 4/7] doc: fix driver names in NIC devices guide

Since the built driver filenames have changed in DPDK 20.11, we need to update the driver doc to match. Most drivers start their section with the driver filename highlighted in bold, while a number were missing the highlight. When updating the names, add the markers for bold text to any missing it

[dpdk-dev] [PATCH v2 7/7] doc: fix driver names in programmers guide

Since the built driver filenames have changed in DPDK 20.11, we need to update the programmers guide doc to match. Fixes: a20b2c01a7a1 ("build: standardize component names and defines") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand --- .../prog_guide/link_bonding_poll_mode_drv_li

Re: [dpdk-dev] [PATCH v4 04/16] net/ark: switch Rx timestamp to dynamic mbuf field

On 11/3/20 3:21 PM, Thomas Monjalon wrote: > The mbuf timestamp is moved to a dynamic field > in order to allow removal of the deprecated static field. > The related dynamic mbuf flag is set, although was missing previously. > > The timestamp is set if configured for at least one device. > > Sign

[dpdk-dev] [PATCH v2 6/7] doc: fix driver names in vDPA devices guide

Since the built driver filenames have changed in DPDK 20.11, we need to update the driver doc to match. Fixes: a20b2c01a7a1 ("build: standardize component names and defines") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand --- doc/guides/vdpadevs/mlx5.rst | 4 ++-- 1 file changed,

Re: [dpdk-dev] [PATCH v4 13/16] ethdev: add doxygen comment for Rx timestamp API

On 11/3/20 3:22 PM, Thomas Monjalon wrote: > The offload flag DEV_RX_OFFLOAD_TIMESTAMP had no documentation. > After switching to dynamic mbuf flag and field, > it becomes even more important to explicit the feature behaviour. > > A doxygen comment for the timesync API was mentioning > the depreca

Re: [dpdk-dev] [PATCH v4 15/16] mbuf: add Tx timestamp registration helper

On 11/3/20 3:22 PM, Thomas Monjalon wrote: > The function rte_mbuf_dyn_tx_timestamp_register() > can be used to register the required field and flag. > > Signed-off-by: Thomas Monjalon > Acked-by: David Marchand Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 3/8] ionic: update ionic_if.h to the latest version

On 11/2/2020 6:35 PM, Andrew Boyer wrote: This file contains the firmware interface definitions. Is the version number stored somewhere for documentation? Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_if.h | 1349 ++-- drivers/net/ionic/ionic_regs.h

Re: [dpdk-dev] [PATCH v4 16/16] ethdev: include mbuf registration in Tx timestamp API

On 11/3/20 3:22 PM, Thomas Monjalon wrote: > Previously, the Tx timestamp field and flag were registered in testpmd, > as described in mlx5 guide. > For consistency between Rx and Tx timestamps, > managing mbuf registrations inside the driver, as properly documented, > is a simpler expectation. >

Re: [dpdk-dev] [PATCH 7/8] ionic: warn if RTE tries to enable loopback mode

On 11/2/2020 6:35 PM, Andrew Boyer wrote: The ionic FW does not support loopback mode at this time. "RTE tries to enable"? what about, net/ionic: warn if loopback mode is requested Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test

> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, October 29, 2020 2:47 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; De Lara > Guarch, Pablo > Subject: [dpdk-dev v2] test: fix GMAC SGL test > > This patch fixes the GMAC SGL test that fails to bypass un

Re: [dpdk-dev] [PATCH v2 2/7] doc: fix driver names in crypto devices guide

On Tue, Nov 3, 2020 at 1:37 PM Bruce Richardson wrote: > > Since the built driver filenames have changed in DPDK 20.11, we need to > update the driver doc to match. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson Reviewed-by: David Ma

Re: [dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables

On 11/2/2020 6:35 PM, Andrew Boyer wrote: These are minor cleanups which did not deserve their own patches. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 10 -- drivers/net/ionic/ionic_lif.c| 22 ++--- drivers/net/ionic/ionic_main.c | 4 +-

Re: [dpdk-dev] [PATCH v4 04/16] net/ark: switch Rx timestamp to dynamic mbuf field

03/11/2020 13:37, Andrew Rybchenko: > On 11/3/20 3:21 PM, Thomas Monjalon wrote: > > --- a/drivers/net/ark/ark_ethdev.c > > +++ b/drivers/net/ark/ark_ethdev.c > > +uint64_t ark_timestamp_rx_dynflag; > > +int ark_timestamp_dynfield_offset = -1; > > int rte_pmd_ark_rx_userdata_dynfield_offset = -1;

Re: [dpdk-dev] [PATCH 0/8] net/ionic: minor updates and documentation

On 11/2/2020 6:35 PM, Andrew Boyer wrote: These patches make some minor changes to the ionic PMD. This is my first patch submission to DPDK, so please let me know if there is anything amiss. Andrew Boyer (8): ionic: update documentation and MAINTAINERS ionic: connect to the meson build sys

[dpdk-dev] [PATCH 0/2] fix build error on lower version GCC

These two patches fix the build error when -march=skylake-avx512 is not supported on lower version GCC in both ice and iavf PMD. Leyi Rong (2): net/ice: fix build error on lower version GCC net/iavf: fix build error on lower version GCC drivers/net/iavf/meson.build | 21 +++--

[dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC

Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") Signed-off-by: Leyi Rong --- drivers/net/ice/meson.build | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct

From: Xiaoyu Min The rte_flow_item_eth and rte_flow_item_vlan items are refined [1]. The structs do not exactly represent the packet bits captured on the wire anymore so set raw_encap/decap commands should only copy real header instead of the whole struct. Replace the rte_flow_item_* with the ex

[dpdk-dev] [PATCH 2/2] net/iavf: fix build error on lower version GCC

Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") Signed-off-by: Leyi Rong --- drivers/net/iavf/meson.build | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git

Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC

On Tue, Nov 03, 2020 at 08:56:28PM +0800, Leyi Rong wrote: > Fix the build error when -march=skylake-avx512 is not supported on > lower version GCC. > > Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") > > Signed-off-by: Leyi Rong > --- > drivers/net/ice/meson.build | 21 +++-

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

On 11/2/2020 11:48 AM, Ferruh Yigit wrote: On 11/2/2020 8:52 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether de

Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute

> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, November 3, 2020 1:56 AM > To: Slava Ovsiienko ; Ferruh Yigit > ; Xueming(Steven) Li ; > Andrew Rybchenko ; dev@dpdk.org; > declan.dohe...@intel.com > Cc: Andrey Vesnovaty ; NBU-Contact-Thomas > Monjalon ; Ray Kinsella ; Neil

[dpdk-dev] [PATCH] ethdev: fix check of rx configure

From: Yunjian Wang Coverity flags that 'rx_conf' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 363570 Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Signed-off-by: Yunjian Wang --- lib/librte_ethdev/rte_ethdev.c | 9 + 1 file ch

Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute

> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, November 3, 2020 1:56 AM > To: Slava Ovsiienko ; Ferruh Yigit > ; Xueming(Steven) Li ; > Andrew Rybchenko ; dev@dpdk.org; > declan.dohe...@intel.com > Cc: Andrey Vesnovaty ; NBU-Contact-Thomas > Monjalon ; Ray Kinsella ; Neil

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, November 3, 2020 1:26 PM > > On Tue, Nov 03, 2020 at 01:10:05PM +0100, Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Monday, November 2, 2020 4:58 PM > > > > > > +Cc techboard

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

On Tue, Nov 03, 2020 at 02:46:17PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, November 3, 2020 1:26 PM > > > > On Tue, Nov 03, 2020 at 01:10:05PM +0100, Morten Brørup wrote: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net

Re: [dpdk-dev] [PATCH] ethdev: fix check of rx configure

On 11/3/2020 1:31 PM, wangyunjian wrote: From: Yunjian Wang Coverity flags that 'rx_conf' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 363570 Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Signed-off-by: Yunjian Wang --- lib/librte_

Re: [dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables

> On Nov 3, 2020, at 8:06 AM, Ferruh Yigit wrote: > > On 11/2/2020 6:35 PM, Andrew Boyer wrote: >> These are minor cleanups which did not deserve their own patches. >> Signed-off-by: Andrew Boyer >> --- >> drivers/net/ionic/ionic_ethdev.c | 10 -- >> drivers/net/ionic/ionic_lif.c

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

Hi, Morten > -Original Message- > From: Morten Brørup > Sent: Tuesday, November 3, 2020 14:10 > To: NBU-Contact-Thomas Monjalon ; dev@dpdk.org; > techbo...@dpdk.org > Cc: Ajit Khaparde ; Ananyev, Konstantin > ; Andrew Rybchenko > ; dev@dpdk.org; Yigit, Ferruh > ; david.march...@redhat.com

Re: [dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables

On 11/3/2020 2:00 PM, Andrew Boyer wrote: On Nov 3, 2020, at 8:06 AM, Ferruh Yigit > wrote: On 11/2/2020 6:35 PM, Andrew Boyer wrote: These are minor cleanups which did not deserve their own patches. Signed-off-by: Andrew Boyer mailto:abo...@pensando.io>> ---  

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, November 3, 2020 2:50 PM > > On Tue, Nov 03, 2020 at 02:46:17PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Tuesday, November 3, 2020 1:26 PM > > > > > > On Tu

Re: [dpdk-dev] [PATCH v2 4/4] test/lpm: avoid code duplication in rcu qsbr perf

> On Nov 2, 2020, at 11:32 PM, Honnappa Nagarahalli > wrote: > > > Avoid code duplication by combining single and multi threaded tests Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 362 ++--

[dpdk-dev] [PATCH v5 00/16] remove mbuf timestamp

The mbuf field timestamp was announced to be removed for three reasons: - a dynamic field already exist, used for Tx only - this field always used 8 bytes even if unneeded - this field is in the first half (cacheline) of mbuf After this series, the dynamic field timestamp is used for both Rx

[dpdk-dev] [PATCH v5 01/16] eventdev: remove software Rx timestamp

This a revert of the commit 569758758dcd ("eventdev: add Rx timestamp"). If the Rx timestamp is not configured on the ethdev port, there is no reason to set one. Also the accuracy of the timestamp was bad because set at a late stage. Anyway there is no trace of the usage of this timestamp. Signed

[dpdk-dev] [PATCH v5 02/16] mbuf: add Rx timestamp flag and helpers

There is already a dynamic field for timestamp, used only for Tx scheduling with the dedicated Tx offload flag. The same field can be used for Rx timestamp filled by drivers. A new dynamic flag is defined for Rx usage. A new function wraps the registration of both field and Rx flag. The type rte_m

[dpdk-dev] [PATCH v5 04/16] net/ark: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related dynamic mbuf flag is set, although was missing previously. The timestamp is set if configured for at least one device. Signed-off-by: Thomas Monjalon Acked-by: David Marchand ---

[dpdk-dev] [PATCH v5 03/16] latency: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced with the dynamic one. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- lib/librte_latencystats/rte_latencystats.c | 30 ++---

[dpdk-dev] [PATCH v5 06/16] net/mlx5: fix dynamic mbuf offset lookup check

The functions rte_mbuf_dynfield_lookup() and rte_mbuf_dynflag_lookup() can return an offset starting with 0 or a negative error code. In reality the first offsets are probably reserved forever, but for the sake of strict API compliance, the checks which considered 0 as an error are fixed. Fixes:

[dpdk-dev] [PATCH v5 05/16] net/dpaa2: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: Hemant Agrawal Acked-by: David Marchand --- drivers/net/dpaa2/dpaa2_ethdev.c | 11 +++ drivers/net/d

[dpdk-dev] [PATCH v5 07/16] net/mlx5: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. The dynamic offset and flag are stored in struct mlx5_rxq_data to favor cache locality. Signed-off-by: Thomas Monjalon Reviewed-by: Ruifeng Wang Revie

[dpdk-dev] [PATCH v5 08/16] net/nfb: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- drivers/net/nfb/nfb_rx.c | 15 ++- drivers/net/nfb/nfb_rx.h | 21 +

[dpdk-dev] [PATCH v5 10/16] net/pcap: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- drivers/net/pcap/rte_eth_pcap.c | 20 +--- 1 file changed, 17 insertions(+

[dpdk-dev] [PATCH v5 09/16] net/octeontx2: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. The registration of field and flag is done in both otx2_nix_dev_start() and otx2_nix_timesync_enable(). The dynamic offset and flag are stored in struct

[dpdk-dev] [PATCH v5 12/16] examples/rxtx_callbacks: switch timestamp to dynamic field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- examples/rxtx_callbacks/main.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/examples/rxtx_

[dpdk-dev] [PATCH v5 11/16] app/testpmd: switch Rx timestamp to dynamic mbuf field

The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- app/test-pmd/util.c | 38 -- 1 file changed, 36 insert

[dpdk-dev] [PATCH v5 15/16] mbuf: add Tx timestamp registration helper

The function rte_mbuf_dyn_tx_timestamp_register() can be used to register the required field and flag. Signed-off-by: Thomas Monjalon Acked-by: David Marchand Acked-by: Andrew Rybchenko --- lib/librte_mbuf/rte_mbuf_dyn.c | 7 +++ lib/librte_mbuf/rte_mbuf_dyn.h | 22 ++

[dpdk-dev] [PATCH v5 14/16] mbuf: remove deprecated timestamp field

As announced in the deprecation note, the field timestamp is removed to give more space to the dynamic fields. The related offload flag PKT_RX_TIMESTAMP is also removed. This is how the mbuf layout looks like (pahole-style): word type namebyte size

[dpdk-dev] [PATCH v5 13/16] ethdev: add doxygen comment for Rx timestamp API

The offload flag DEV_RX_OFFLOAD_TIMESTAMP had no documentation. After switching to dynamic mbuf flag and field, it becomes even more important to explicit the feature behaviour. A doxygen comment for the timesync API was mentioning the deprecated timestamp field, so it is also updated. Signed-off

[dpdk-dev] [PATCH v5 16/16] ethdev: include mbuf registration in Tx timestamp API

Previously, the Tx timestamp field and flag were registered in testpmd, as described in mlx5 guide. For consistency between Rx and Tx timestamps, managing mbuf registrations inside the driver, as properly documented, is a simpler expectation. The only driver to support this feature (mlx5) is updat

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

Hi Ferruh, On 02/11/2020 21:54, Ferruh Yigit wrote: On 11/2/2020 11:43 AM, Ivan Malov wrote: In a flow rule, attribute "transfer" means operation level at which both traffic is matched and actions are conducted. Add the very same attribute to shared action configuration. If a driver needs to p

[dpdk-dev] [PATCH v2 0/2] fix build error on lower version GCC

These two patches fix the build error when -march=skylake-avx512 is not supported on lower version GCC in both ice and iavf PMD. --- v2: - Simplify the judgement by extracting the avx512_args. Leyi Rong (2): net/ice: fix build error on lower version GCC net/iavf: fix build error on lower vers

Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC

> -Original Message- > From: Bruce Richardson > Sent: Tuesday, November 3, 2020 9:28 PM > To: Rong, Leyi > Cc: Zhang, Qi Z ; Yigit, Ferruh > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version > GCC > > On Tue, Nov 03, 2020 at 08:56:28PM +

[dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC

Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") Signed-off-by: Leyi Rong --- drivers/net/ice/meson.build | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/i

[dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field

A crash is observed if dynamic mbuf timestamp field is registered in dev_start, as in most of the applications rte_eth_timesync_enable is called after dev_start due to which timestamp field did not get registered. Signed-off-by: Harman Kalra --- drivers/net/octeontx2/otx2_ethdev.c | 10 -

[dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC

Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") Signed-off-by: Leyi Rong --- drivers/net/iavf/meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i

Re: [dpdk-dev] [PATCH v5 00/16] remove mbuf timestamp

On Tue, Nov 03, 2020 at 03:09:15PM +0100, Thomas Monjalon wrote: > The mbuf field timestamp was announced to be removed for three reasons: > - a dynamic field already exist, used for Tx only > - this field always used 8 bytes even if unneeded > - this field is in the first half (cacheline) of

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

> -Original Message- > From: Ferruh Yigit > Sent: Monday, November 2, 2020 8:55 PM > To: Ivan Malov ; dev@dpdk.org; Andrey Vesnovaty > > Cc: Xueming(Steven) Li ; Ori Kam ; > NBU-Contact-Thomas Monjalon ; Andrew Rybchenko > > Subject: Re: [PATCH v3 1/2] ethdev: introduce transfer attribut

Re: [dpdk-dev] [EXT] Re: [PATCH v3 09/16] net/octeontx2: switch Rx timestamp to dynamic mbuf field

On Tue, Nov 03, 2020 at 01:21:01PM +0100, Thomas Monjalon wrote: > External Email > > -- > 03/11/2020 12:22, Thomas Monjalon: > > 03/11/2020 11:52, Harman Kalra: > > >With the following changes, ptpclient and testpmd(ieee1588

[dpdk-dev] Minutes of Technical Board Meeting, 2020-10-21

Minutes of Technical Board Meeting, 2020-10-21 Members Attending - -Bruce -Ferruh -Hemant -Honnappa -Jerin (Chair) -Kevin -Konstantin -Maxime -Olivier -Stephen -Thomas NOTE: The technical board meetings every second Wednesday in https://meet.jit.si/DPDK at 3 pm UTC. Meetings are

Re: [dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field

03/11/2020 15:16, Harman Kalra: > A crash is observed if dynamic mbuf timestamp field is > registered in dev_start, as in most of the applications > rte_eth_timesync_enable is called after dev_start due > to which timestamp field did not get registered. So you are not reading your emails? I was w

Re: [dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field

+Cc David and Olivier to make them laugh or cry. 03/11/2020 15:24, Thomas Monjalon: > 03/11/2020 15:16, Harman Kalra: > > A crash is observed if dynamic mbuf timestamp field is > > registered in dev_start, as in most of the applications > > rte_eth_timesync_enable is called after dev_start due > >

[dpdk-dev] [PATCH v2] ethdev: deprecate shared counters using action attribute

A new generic shared actions API may be used to create shared counter. There is no point to keep duplicate COUNT action specific capability to create shared counters. Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit --- Cc: Ori Kam Cc: Xueming(Steven) Li Cc: Slava Ovsiienko Right no

Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct

On 11/3/2020 1:20 PM, Xiaoyu Min wrote: From: Xiaoyu Min The rte_flow_item_eth and rte_flow_item_vlan items are refined [1]. The structs do not exactly represent the packet bits captured on the wire anymore so set raw_encap/decap commands should only copy real header instead of the whole struct

Re: [dpdk-dev] [PATCH 3/8] ionic: update ionic_if.h to the latest version

> On Nov 3, 2020, at 7:44 AM, Ferruh Yigit wrote: > > On 11/2/2020 6:35 PM, Andrew Boyer wrote: >> This file contains the firmware interface definitions. > > Is the version number stored somewhere for documentation? > No, it is controlled by our internal repository. >> Signed-off-by: Andre

Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC

On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote: > Fix the build error when -march=skylake-avx512 is not supported on > lower version GCC. > > Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") > > Signed-off-by: Leyi Rong Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH 1/8] ionic: update documentation and MAINTAINERS

> On Nov 3, 2020, at 7:35 AM, Ferruh Yigit wrote: > > On 11/2/2020 6:35 PM, Andrew Boyer wrote: >> The ionic PMD is being actively maintained. >> Signed-off-by: Andrew Boyer >> --- >> MAINTAINERS | 5 +++-- >> doc/guides/nics/ionic.rst | 13 +++-- >> 2 files changed, 10 i

Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC

On Tue, Nov 03, 2020 at 09:52:00PM +0800, Leyi Rong wrote: > Fix the build error when -march=skylake-avx512 is not supported on > lower version GCC. > > Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") > > Signed-off-by: Leyi Rong > --- > drivers/net/iavf/meson.build | 8 ++-- >

Re: [dpdk-dev] [PATCH v5 00/16] remove mbuf timestamp

03/11/2020 15:17, Olivier Matz: > On Tue, Nov 03, 2020 at 03:09:15PM +0100, Thomas Monjalon wrote: > > The mbuf field timestamp was announced to be removed for three reasons: > > - a dynamic field already exist, used for Tx only > > - this field always used 8 bytes even if unneeded > > - this

Re: [dpdk-dev] [PATCH 0/8] net/ionic: minor updates and documentation

> On Nov 3, 2020, at 8:11 AM, Ferruh Yigit wrote: > > On 11/2/2020 6:35 PM, Andrew Boyer wrote: >> These patches make some minor changes to the ionic PMD. This is my first >> patch submission to DPDK, so please let me know if there is anything amiss. >> Andrew Boyer (8): >> ionic: update doc

Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx2: register dynamic mbuf timestamp field

On Tue, Nov 03, 2020 at 03:26:17PM +0100, Thomas Monjalon wrote: > External Email > > -- > +Cc David and Olivier to make them laugh or cry. > > 03/11/2020 15:24, Thomas Monjalon: > > 03/11/2020 15:16, Harman Kalra: > > > A crash

Re: [dpdk-dev] [PATCH v2 0/7] fix driver filenames in the docs

On Tue, Nov 3, 2020 at 1:36 PM Bruce Richardson wrote: > > Since the driver filenames are now following a new standard naming convention > some doc updates are necessary. > > V2: > dropped patch 1, no longer necessary to fix meson.build file. > added two additional fixes to crypto

[dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

Coverity flags a possible problem where the 8-bit wq_idx value may have errors when shifted and sign-extended to 64-bits. Since this can only occur if the shift index is larger than any expected value from hardware, it's unlikely to cause any real problems, but we can eliminate any possible errors,

Re: [dpdk-dev] [PATCH v2 4/4] test/lpm: avoid code duplication in rcu qsbr perf

> > Avoid code duplication by combining single and multi threaded tests > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > app/test/test_lpm_perf.c | 362 > ++- > 1 file changed, 91 insertions(+)

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slava Ovsiienko > Sent: Tuesday, November 3, 2020 3:03 PM > > Hi, Morten > > > From: Morten Brørup > > Sent: Tuesday, November 3, 2020 14:10 > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Monday, November 2, 2020 4:

Re: [dpdk-dev] [PATCH v2] doc: add reference to companion configuration tool

On 11/2/20 12:53 PM, Nicolas Chautru wrote: > Adding reference to pf_bb_config in github to do > device configuration of the fpga_5gnr, fpga_lte and > acc100 devices and pmds. > > Signed-off-by: Nicolas Chautru > --- > doc/guides/bbdevs/acc100.rst| 19 +++ > doc/guides/b

[dpdk-dev] [PATCH] net/octeontx2: fix dynamic registration for timestamp

Registration of timestamp field should be done once and only when ptp kernel changes are successful. Fixes: 67b8f3220393 ("net/octeontx2: switch Rx timestamp to dynamic mbuf field") Signed-off-by: Harman Kalra --- drivers/net/octeontx2/otx2_ethdev.c | 10 -- drivers/net/octeontx2/otx2_p

Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC

On 11/3/2020 2:44 PM, Bruce Richardson wrote: On Tue, Nov 03, 2020 at 09:52:00PM +0800, Leyi Rong wrote: Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") Signed-off-by: Leyi Rong --- drivers/n

Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC

On 11/3/2020 2:42 PM, Bruce Richardson wrote: On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote: Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") Signed-off-by: Leyi Rong Acked-by: Bruce Ric

<    1   2   3   >