03/11/2020 13:37, Andrew Rybchenko: > On 11/3/20 3:21 PM, Thomas Monjalon wrote: > > --- a/drivers/net/ark/ark_ethdev.c > > +++ b/drivers/net/ark/ark_ethdev.c > > +uint64_t ark_timestamp_rx_dynflag; > > +int ark_timestamp_dynfield_offset = -1; > > int rte_pmd_ark_rx_userdata_dynfield_offset = -1; > > int rte_pmd_ark_tx_userdata_dynfield_offset = -1; > > It is a bit confusing that naming above differs so much and > put in the same block without empty lines in between. > I guess the reason is export/no-export. May be it would > be useful to highlight it in a comment.
I can add a blank line. Not sure it is worth an out of scope comment to explain that "rte_pmd_" prefixed variables are for the PMD-specific API.
