Re: [dpdk-dev] [dpdk-stable] [PATCH] common/qat: add missing kmod dependency

2020-10-23 Thread David Marchand
Salut Didier, On Fri, Oct 23, 2020 at 5:45 PM Didier Pallard wrote: > > Dependency on kmod needed to manage crypto devices is missing > in qat crypto pmd. > > Cc: sta...@dpdk.org > Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") The Fixes: tag goes first, then Cc:, then e

Re: [dpdk-dev] [PATCH v1] doc: update abi version references

2020-10-23 Thread David Marchand
On Fri, Oct 23, 2020 at 6:11 PM Ray Kinsella wrote: > > Updated references to abi versions in the contributors guide. Thanks for looking at it. I would keep the dpdk release version aligned with updated ABI ver. Caught 3 references in the first file. %s/19.11/20.11/g can fix this. Then: Review

[dpdk-dev] [PATCH v8 01/10] eal: add new x86 cpuid support for WAITPKG

2020-10-23 Thread Liang Ma
Add a new CPUID flag indicating processor support for UMONITOR/UMWAIT and TPAUSE instructions instruction. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- lib/librte_eal/x86/include/rte_cpuflags.h | 1 + lib/librte_eal/x86/rte_cpuflags.c | 2 ++

[dpdk-dev] [PATCH v8 02/10] eal: add power management intrinsics

2020-10-23 Thread Liang Ma
Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for these instructions. The power management instructions provide an ar

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/qat: add missing kmod dependency

2020-10-23 Thread Trahe, Fiona
> -Original Message- > From: David Marchand > Sent: Friday, October 23, 2020 5:32 PM > To: Didier Pallard > Cc: dev ; dpdk stable ; Griffin, John > ; Trahe, > Fiona ; Jain, Deepak K ; > Olivier Matz > ; Adrien Mazarguil > Subject: Re: [dpdk-stable] [PATCH] common/qat: add missing kmo

[dpdk-dev] [PATCH v8 03/10] eal: add intrinsics support check infrastructure

2020-10-23 Thread Liang Ma
Currently, it is not possible to check support for intrinsics that are platform-specific, cannot be abstracted in a generic way, or do not have support on all architectures. The CPUID flags can be used to some extent, but they are only defined for their platform, while intrinsics will be available

[dpdk-dev] [PATCH v8 04/10] ethdev: add simple power management API

2020-10-23 Thread Liang Ma
Add a simple API to allow getting address of next RX descriptor from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v8: - Rename version map file name. v7: - Fixed queue ID validatio

[dpdk-dev] [PATCH v8 05/10] power: add PMD power management API and callback

2020-10-23 Thread Liang Ma
Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or w

Re: [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options

2020-10-23 Thread Thomas Monjalon
23/10/2020 09:37, David Marchand: > On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon wrote: > > > > Below patches are cleaning traces of CONFIG_RTE_ after make removal, > > except one occurence in app/test/test_cryptodev.c (left as exercise). > > PS: In reality I don't know what must be done for t

[dpdk-dev] [PATCH v8 06/10] net/ixgbe: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/i

[dpdk-dev] [PATCH v8 07/10] net/i40e: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 1 + d

[dpdk-dev] [PATCH v8 08/10] net/ice: implement power management API

2020-10-23 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxt

[dpdk-dev] [PATCH v8 09/10] examples/l3fwd-power: enable PMD power mgmt

2020-10-23 Thread Liang Ma
Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v8: - Add return status check for queue enable v6: - Fixed typos in documentation --- .../sample_app_ug/l3_forward_power_

[dpdk-dev] [PATCH v8 10/10] doc: update programmer's guide for power library

2020-10-23 Thread Liang Ma
Update programmer's guide to document PMD power management usage. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 42 + 1 file changed, 42 insertions(+) diff --git a/doc/guides/prog_guide/power_m

[dpdk-dev] [PATCH] regex/octeontx2: fix driver name

2020-10-23 Thread Thomas Monjalon
Following the recent alignment of all driver names, this new driver get unaligned: librte_regex_octeontx2_regex.so The 'fmt_name' must be "octeontx2_regex", and if not provided, is taken from the 'name' variable. But the variable 'name' should not be overwritten, to keep the automatic valu

[dpdk-dev] [PATCH v3 01/23] event/dlb2: add documentation and meson build infrastructure

2020-10-23 Thread Timothy McDaniel
Adds the meson build infrastructure, which includes compile-time constants in rte_config.h. DLB2 is only supported on Linux X86 platforms at this time. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- MAINTAINERS | 5 +++ config/rte_config.h

[dpdk-dev] [PATCH v3 00/23] Add DLB2 PMD

2020-10-23 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB2 PMD adds support for the Intel Dynamic Load Balancer 2.0 (DLB2) hardware. The DLB2 is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters

[dpdk-dev] [PATCH v3 02/23] event/dlb2: add dynamic logging

2020-10-23 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 7 +++ drivers/event/dlb2/dlb2_log.h | 25 +

[dpdk-dev] [PATCH v3 04/23] event/dlb2: add definitions shared with LKM or shared code

2020-10-23 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH v3 03/23] event/dlb2: add private data structures and constants

2020-10-23 Thread Timothy McDaniel
The header file dlb2_priv.h is used internally by the PMD. It include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. The header file rte_pmd_dlb2.h will be exported in a subsequent patch, but is included he

[dpdk-dev] [PATCH v3 05/23] event/dlb2: add inline functions

2020-10-23 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel Reviewed-by: Gage

[dpdk-dev] [PATCH v3 08/23] event/dlb2: add probe-time hardware init

2020-10-23 Thread Timothy McDaniel
This commit adds probe-time low level hardware initialization. It also adds probe-time init for both primary and secondary DPDK processes. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 188 +++- drivers/event/dlb2/meson.build | 3

[dpdk-dev] [PATCH v3 07/23] event/dlb2: add flexible interface

2020-10-23 Thread Timothy McDaniel
This commit introduces the flexible interface. This interface allows the core code to operate in PF mode (direct hardware access) or bifurcated mode (hardware configured via kernel driver). This driver currently only supports PF mode but bifurcated mode will be added in a future DPDK patch-set. Not

[dpdk-dev] [PATCH v3 11/23] event/dlb2: add queue and port default conf

2020-10-23 Thread Timothy McDaniel
Add support for getting the queue and port default configuration. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index

[dpdk-dev] [PATCH v3 10/23] event/dlb2: add infos get and configure

2020-10-23 Thread Timothy McDaniel
Add support for configuring the DLB2 hardware. In particular, this patch configures the DLB2 hardware's scheduling domain, such that it is provisioned with the requested number of ports and queues, provided sufficient resources are available. Individual queues and ports are configured later in port

[dpdk-dev] [PATCH v3 09/23] event/dlb2: add xstats

2020-10-23 Thread Timothy McDaniel
Add support for DLB2 xstats. Perform initialization and add standard xstats entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads Reviewed-by: Chen, Mike Ximing --- drivers/event/dlb2/dlb2.c| 35 +- drivers/event/dlb2/dlb2_xstats.c | 1240 +

[dpdk-dev] [PATCH v3 12/23] event/dlb2: add queue setup

2020-10-23 Thread Timothy McDaniel
Load balanced (ldb) queues are setup here. Directed queues are not set up until link time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by: Timothy McDaniel Reviewed-by

[dpdk-dev] [PATCH v3 14/23] event/dlb2: add port link

2020-10-23 Thread Timothy McDaniel
Add port link entry point. Directed queues are identified and created at this stage. Their setup deferred until link-time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-b

[dpdk-dev] [PATCH v3 13/23] event/dlb2: add port setup

2020-10-23 Thread Timothy McDaniel
Configure the load balanded (ldb) or directed (dir) port. The consumer queue (CQ) and producer port (PP) are also set up here. Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb2.rst | 75 +++ drivers/event/dlb2/dlb2.c | 498 drivers/even

[dpdk-dev] [PATCH v3 16/23] event/dlb2: add eventdev start

2020-10-23 Thread Timothy McDaniel
Add support for the eventdev start entry point. We delay initializing some resources until eventdev start, since the number of linked queues can be used to determine if we are dealing with a ldb or dir resource. If this is a device restart, then the previous configuration will be reapplied. Signed

[dpdk-dev] [PATCH v3 15/23] event/dlb2: add port unlink and port unlinks in progress

2020-10-23 Thread Timothy McDaniel
Add supports for the port unlink(s) eventdev entry points. The unlink operation is an asynchronous operation executed by a control thread, and the unlinks-in-progress function reads a counter shared with the control thread. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/even

[dpdk-dev] [PATCH v3 18/23] event/dlb2: add dequeue and its burst variants

2020-10-23 Thread Timothy McDaniel
Add support for dequeue, dequeue_burst, ... DLB2 does not currently support interrupts, but instead use umonitor/umwait if supported by the processor. This allows the software to monitor and wait on writes to a cache-line. DLB2 supports normal and sparse cq mode. In normal mode the hardware will

[dpdk-dev] [PATCH v3 19/23] event/dlb2: add eventdev stop and close

2020-10-23 Thread Timothy McDaniel
Add support for eventdev stop and close entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 257 +++-- drivers/event/dlb2/dlb2_iface.c| 6 + drivers/event/dlb2/dlb2_iface.h| 6 +

[dpdk-dev] [PATCH v3 17/23] event/dlb2: add enqueue and its burst variants

2020-10-23 Thread Timothy McDaniel
Add support for enqueue and its variants. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- doc/guides/eventdevs/dlb2.rst | 118 + drivers/event/dlb2/dlb2.c | 578 ++ 2 files changed, 696 insertions(+) diff --git a/doc/guides/eventde

[dpdk-dev] [PATCH v3 22/23] event/dlb2: add queue and port release

2020-10-23 Thread Timothy McDaniel
DLB does not support reconfiguring individual queues or ports on the fly. The entire device must be reconfigured. Previously allocated port QE and memzone memory is freed in this patch. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 24 +++

[dpdk-dev] [PATCH v3 20/23] event/dlb2: add PMD's token pop public interface

2020-10-23 Thread Timothy McDaniel
The PMD uses a public interface to allow applications to control the token pop mode. Supported token pop modes are as follows, and they impact core scheduling affinity for ldb ports. AUTO_POP: Pop the CQ tokens immediately after dequeueing. DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) even

[dpdk-dev] [PATCH v3 21/23] event/dlb2: add PMD self-tests

2020-10-23 Thread Timothy McDaniel
Add a variety of self-tests for both ldb and directed ports/queues, as well as configure, start, stop, link, etc... Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- app/test/test_eventdev.c |7 + drivers/event/dlb2/dlb2.c |1 + drivers/event/dlb2/dlb2_selfte

[dpdk-dev] [PATCH v3 23/23] event/dlb2: add timeout ticks entry point

2020-10-23 Thread Timothy McDaniel
Adds the timeout ticks conversion function. Adds announcement of availabililty for the new driver for Intel Dynamic Load Balancer 2.0 hardware. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- doc/guides/rel_notes/release_20_11.rst | 5 + drivers/event/dlb2/dlb2.c |

[dpdk-dev] [PATCH v6 00/23] Add DLB PMD

2020-10-23 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters that co

[dpdk-dev] [PATCH v6 01/23] event/dlb: add documentation and meson infrastructure

2020-10-23 Thread Timothy McDaniel
Increased RTE_EVENT_MAX_QUEUES_PER_DEV config option from 64 to 255. Note that config/rte_config.h contains several configuration switches, providing for fine control of the PMD's runtime behaviour. The meson infrastructure is expanded as additional files are added to this patchset. Signed-off-b

[dpdk-dev] [PATCH v6 04/23] event/dlb: add definitions shared with LKM or shared code

2020-10-23 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH v6 05/23] event/dlb: add inline functions

2020-10-23 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel Reviewed-by: Gage

[dpdk-dev] [PATCH v6 02/23] event/dlb: add dynamic logging

2020-10-23 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 7 +++ drivers/event/dlb/dlb_log.h | 25 +++

[dpdk-dev] [PATCH v6 03/23] event/dlb: add private data structures and constants

2020-10-23 Thread Timothy McDaniel
Add headers used internally by the PMD. They include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb_priv.h | 508 +++

[dpdk-dev] [PATCH v6 06/23] event/dlb: add eventdev probe

2020-10-23 Thread Timothy McDaniel
Add the eventdev portion of probe, and parse command line options, but do not initialize hardware. Changes since v5 patch-set probe: Primary and secondary probe-time init has been removed, and will be introduced in subsequent patches contained in this patch-set. Hardware init has been moved to a

<    1   2   3