23/10/2020 09:37, David Marchand: > On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon <tho...@monjalon.net> wrote: > > > > Below patches are cleaning traces of CONFIG_RTE_ after make removal, > > except one occurence in app/test/test_cryptodev.c (left as exercise). > > PS: In reality I don't know what must be done for this case about QAT. > > It seems a reintroduction with raw datapath API merge. > > I would apply the same as Ciara previous: > https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505 > > I.e. > @@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv > __rte_unused, int argc __rte_unused*/) > RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)); > > if (gbl_driver_id == -1) { > - RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both " > - "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM " > - "are enabled in config file to run this testsuite.\n"); > + RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n"); > return TEST_SKIPPED; > }
Yes it seems the right thing to do. > The rest of the series looks good to me. > Acked-by: David Marchand <david.march...@redhat.com> Applied with above change
