[dpdk-dev] [PATCH v5] net/mlx5: support query of AGE action

2020-10-18 Thread Dekel Peled
Recent patch [1] adds to ethdev the API for query of age action. This patch implements in MLX5 PMD the query of age action using this API. [1] https://mails.dpdk.org/archives/dev/2020-October/184864.html --- v2: Update age resolution to seconds, v3: Replace rte_atomic ops with c11 atomics. v4: Re

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: Prevent alarm lost on failed device probe

2020-10-18 Thread Matan Azrad
From: Long Li > If a device probe fails, the alarm is canceled and will no longer work for > previously probed devices. > > Fix this by introducing a flag to track if alarm has been set. Because it's > possible that an alarm is triggered while probing is in progress that may > modify vdev_netvs

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Akhil Goyal
Hi Lukasz, > Hi Akhil, > > just one more thing, rest looks good > > > > diff --git a/app/test/test_security.c b/app/test/test_security.c > > index 77fd5adc6..62e4991eb 100644 > > --- a/app/test/test_security.c > > +++ b/app/test/test_security.c > > @@ -363,8 +392,13 @@ static struct mock_session

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-18 Thread Jerin Jacob
On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel wrote: > > Adds the meson build infrastructure, which includes > compile-time constants in rte_config.h. DLB2 is > only supported on Linux X86 platforms at this time. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads > --- > config/rt

Re: [dpdk-dev] [PATCH v2 11/11] ethdev: change stop device callback to return int

2020-10-18 Thread Xu, Rosen
On 10/15/2020 2:30 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Change eth_dev_stop_t return value from void to int. > Make eth_dev_stop_t implementations across all drivers to return > negative errno values if case of error conditions. > > Signed-off-by: Ivan Ilchenko > Signed-off-by:

Re: [dpdk-dev] [PATCH v2 02/22] event/dlb2: add dynamic logging

2020-10-18 Thread Jerin Jacob
On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel wrote: > > This commit adds base support for dynamic logging. > The default log level is NOTICE. Dynamic logging > is used exclusively throughout this patchset. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads > --- > drivers/event/d

Re: [dpdk-dev] [PATCH v2 05/22] event/dlb2: add inline functions

2020-10-18 Thread Jerin Jacob
On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel wrote: > > Add miscellaneous inline functions that may be called > from multiple files. These functions include inline > assembly of new x86 instructions, such as movdir64b, > since they are not available as builtin functions in > the minimum supp

Re: [dpdk-dev] [PATCH v2 18/22] event/dlb2: add PMD's token pop public interface

2020-10-18 Thread Jerin Jacob
On Sat, Oct 17, 2020 at 11:57 PM Timothy McDaniel wrote: > > The PMD uses a public interface to allow applications to > control the token pop mode. Supported token pop modes are > as follows, and they impact core scheduling affinity for > ldb ports. > > AUTO_POP: Pop the CQ tokens immediately afte

Re: [dpdk-dev] [PATCH v4 1/5] eal: add API for bus close

2020-10-18 Thread David Marchand
On Thu, Oct 8, 2020 at 5:31 PM wrote: > > From: Rohit Raj > > As per the current code we have API for bus probe, but the > bus close API is missing. This breaks the multi process > scenarios as objects are not cleaned while terminating the > secondary processes. > > This patch adds a new API rte_

Re: [dpdk-dev] [PATCH v5 7/8] build: standardize component names and defines

2020-10-18 Thread Xu, Rosen
On 10/15/20 6:05 PM, Bruce Richardson wrote: > As discussed on the dpdk-dev mailing list[1], we can make some easy > improvements in standardizing the naming of the various components in > DPDK, and their associated feature-enabled macros. > > Following this patch, each library will have the nam

Re: [dpdk-dev] [PATCH v2 22/22] doc: add new DLB2 eventdev driver to relnotes

2020-10-18 Thread Jerin Jacob
On Sat, Oct 17, 2020 at 11:58 PM Timothy McDaniel wrote: > > Added announcement of availabililty for the new driver > for Intel Dynamic Load Balancer 2.0 hardware. > > Signed-off-by: Timothy McDaniel > --- > MAINTAINERS| 5 + > doc/guides/rel_notes/release_20_11.r

Re: [dpdk-dev] [PATCH v5 8/8] build: replace use of old build macros

2020-10-18 Thread Xu, Rosen
On 10/15/20 6:05 PM, Bruce Richardson wrote: > Use the newer macros defined by meson in all DPDK source code, to > ensure there are no errors when the old non-standard macros are removed. > > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi Acked-by: Rosen Xu

Re: [dpdk-dev] [PATCH v5 5/8] build: remove library name from version map filename

2020-10-18 Thread Xu, Rosen
On 10/15/20 6:05 PM, Bruce Richardson wrote: > Since each version map file is contained in the subdirectory of the > library it refers to, there is no need to include the library name in the > filename. > This makes things simpler in case of library renaming. > > Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v4 2/5] examples/multi_process: cleanup bus objects while terminating app

2020-10-18 Thread David Marchand
On Thu, Oct 8, 2020 at 5:31 PM wrote: > > From: Rohit Raj > > Certain bus objects may need to be closed and re-acquired > while terminating and rerunning the client application. > Hence a signal handler is required to catch the termination > of the App and hence closing the bus objects. > > This

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/3] eal: add API for bus close

2020-10-18 Thread David Marchand
Hello Rohit, On Fri, Oct 9, 2020 at 6:53 AM Rohit Raj wrote: > Sorry, I missed you comment last time. I will send an updated patch series > after taking care of your suggested changes. Added few more comments. Waiting for a respin. Thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Lukasz Wojciechowski
Hi Akhil, If you replace mock_session_create_exp.ret with mock_session_destroy_exp.ret in mock_session_destroy() everything works fine and all test cases pass. W dniu 18.10.2020 o 10:47, Akhil Goyal pisze: > Hi Lukasz, >> Hi Akhil, >> >> just one more thing, rest looks good >> >> >>> diff --git

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Lukasz Wojciechowski
Just to be clear, these are the changes that will fix v4: diff --git a/app/test/test_security.c b/app/test/test_security.c index 62e4991eb..060cf1ffa 100644 --- a/app/test/test_security.c +++ b/app/test/test_security.c @@ -395,7 +395,7 @@ mock_session_destroy(void *device, struct rte_security_ses

[dpdk-dev] [PATCH v5] security: update session create API

2020-10-18 Thread Akhil Goyal
The API ``rte_security_session_create`` takes only single mempool for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead to wastage of memory as session private data need more memory compared to session. Hence the A

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Akhil Goyal
> Hi Akhil, > > If you replace mock_session_create_exp.ret with > mock_session_destroy_exp.ret > in mock_session_destroy() everything works fine and all test cases pass. > Thanks for pointing this out. V5 sent. > >>> @@ -1396,6 +1518,7 @@ test_session_destroy_success(void) > >>> mock_

Re: [dpdk-dev] [PATCH v6 1/2] net/iavf: add IAVF request queues function

2020-10-18 Thread Xu, Ting
> -Original Message- > From: Xing, Beilei > Sent: Friday, October 16, 2020 4:42 PM > To: Xu, Ting ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing > Subject: RE: [PATCH v6 1/2] net/iavf: add IAVF request queues function > > > > > -Original Message- > > From: Xu, Ting > > Sent:

[dpdk-dev] [PATCH v7 1/6] net/iavf: handle virtchnl event message without interrupt

2020-10-18 Thread Ting Xu
Currently, VF only handle virtchnl event message when interrupt is called. In some cases, event message is supposed to be handled with interrupt disabled, for example request queues. To solve this issue, virtchnl event message handling are added in reading message from PF in this patch. Signed-off

[dpdk-dev] [PATCH v7 0/6] enable large VF configuration

2020-10-18 Thread Ting Xu
This patchset supports to configure up to 256 queue pairs per VF. If large VF is supported after capability negotiation, VF will request queues from PF as needed. New virtual channel opcodes and structures are used to indicate 256 queues, so VF is designed to handle the new function of configure VS

[dpdk-dev] [PATCH v7 5/6] net/iavf: enable IRQ mapping configuration for large VF

2020-10-18 Thread Ting Xu
The current IRQ mapping configuration only supports max 16 queues and 16 MSIX vectors. Change the queue vector mapping structure to indicate up to 256 queues. A new opcode is used to handle the case with large number of queues. To avoid adminq buffer size limitation, we support to send the virtchnl

[dpdk-dev] [PATCH v7 2/6] net/iavf: add IAVF request queues function

2020-10-18 Thread Ting Xu
Add new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs, enable this request queues function. Since request queues command may return event message to report info, disable interrupt before

[dpdk-dev] [PATCH v7 3/6] net/iavf: negotiate large VF and request more queues

2020-10-18 Thread Ting Xu
Negotiate large VF capability with PF during VF initialization. If large VF is supported and the number of queues larger than 16 is required, VF requests additional queues from PF. Mark the state that large VF is supported. If the allocated queues number is larger than 16, the max RSS queue region

[dpdk-dev] [PATCH v7 4/6] net/iavf: enable multiple queues configurations for large VF

2020-10-18 Thread Ting Xu
Since the adminq buffer size has a 4K limitation, the current virtchnl command VIRTCHNL_OP_CONFIG_VSI_QUEUES cannot send the message only once to configure up to 256 queues. In this patch, we send the messages multiple times to make sure that the buffer size is less than 4K each time. Signed-off-b

[dpdk-dev] [PATCH v7 6/6] net/iavf: add enable/disable queues for large VF

2020-10-18 Thread Ting Xu
The current virtchnl structure for enable/disable queues only supports max 32 queue pairs. Use a new opcode and structure to indicate up to 256 queue pairs, in order to enable/disable queues in large VF case. Signed-off-by: Ting Xu --- drivers/net/iavf/iavf.h | 5 ++ drivers/net/iavf/iav

Re: [dpdk-dev] [PATCH v5] security: update session create API

2020-10-18 Thread Lukasz Wojciechowski
Hi Akhil, Thanks for your patience. I reviewed all files and run tests. IMO everything is OK now. W dniu 18.10.2020 o 11:40, Akhil Goyal pisze: > The API ``rte_security_session_create`` takes only single > mempool for session and session private data. So the > application need to create mempool f

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] examples/l3fwd-regex: add regex based l3fwd

2020-10-18 Thread Guy Kaneti
Sorry for the delayed response > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 14, 2020 11:47 AM > To: Guy Kaneti > Cc: or...@mellanox.com; dev@dpdk.org; Jerin Jacob Kollanukkaran > ; Smadar Fuks ; Dovrat Zifroni > ; bruce.richard...@intel.com; > konstantin.anan.

Re: [dpdk-dev] [PATCH v4 8/8] build: replace use of old build macros

2020-10-18 Thread Xu, Rosen
> Use the newer macros defined by meson in all DPDK source code, to ensure > there are no errors when the old non-standard macros are removed. > > Signed-off-by: Bruce Richardson > --- Reviewed-by: Rosen Xu

Re: [dpdk-dev] [PATCH v4 7/8] build: standardize component names and defines

2020-10-18 Thread Xu, Rosen
> Subject: [PATCH v4 7/8] build: standardize component names and defines > > As discussed on the dpdk-dev mailing list[1], we can make some easy > improvements in standardizing the naming of the various components in > DPDK, and their associated feature-enabled macros. > > Following this patch, e

Re: [dpdk-dev] [PATCH v4 5/8] build: remove library name from version map filename

2020-10-18 Thread Xu, Rosen
> Subject: [PATCH v4 5/8] build: remove library name from version map > filename > > Since each version map file is contained in the subdirectory of the library > it refers to, there is no need to include the library name in the filename. > This makes things simpler in case of library renaming. >

Re: [dpdk-dev] [PATCH 1/4] net/mlx5: fix Rx queue release

2020-10-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Thursday, October 15, 2020 9:38 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko > Subject: [dpdk-dev] [PATCH 1/4] net/mlx5: fix Rx queue release > > The HW objects of the Rx queue is created/destroyed in the device > star

[dpdk-dev] [PATCH v3 0/2] Add example l3fwd-regex

2020-10-18 Thread guyk
From: Guy Kaneti The L3 Forwarding with Regex application is a simple example of packet processing using DPDK Regex framework. The application performs L3 LPM based forwarding while using Regex framework for pre-filtering decision. v3: * Rebase. * fix typo v2: * Rebase. * Add release notes. * f

[dpdk-dev] [PATCH v3 1/2] examples/l3fwd-regex: add regex based l3fwd

2020-10-18 Thread guyk
From: Guy Kaneti Add regex based l3fwd application inline with normal l3fwd. only LPM is supported. Signed-off-by: Guy Kaneti --- MAINTAINERS|2 + examples/l3fwd-regex/l3fwd.h | 207 ++ examples/l3fwd-regex/l3fwd_lpm.c | 484 examples/l3fw

[dpdk-dev] [PATCH v3 2/2] doc: add l3fwd-regex application user guide

2020-10-18 Thread guyk
From: Guy Kaneti Adding the user guide for l3fwd regex application. Signed-off-by: Guy Kaneti --- MAINTAINERS | 1 + doc/guides/rel_notes/release_20_11.rst| 5 + doc/guides/sample_app_ug/index.rst| 1 + doc/guides/sample_app_ug/intro.

Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats

2020-10-18 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, October 14, 2020 10:27 > To: Yigit, Ferruh ; John W. Linville > ; Loftus, Ciara ; Zhang, Qi Z > ; Shepard Siegel ; > Ed Czeck ; John Miller > ; Igor Russkikh > ; Pavel Belous ; > Steven Webster ; Matt Peters > ; Somalapuram A

[dpdk-dev] [PATCH] ethdev: rename tunnel offload callbacks

2020-10-18 Thread Gregory Etelson
rename new rte_flow ops callbacks to emphasize relation to tunnel offload API. Signed-off-by: Gregory Etelson Acked-by: Ori Kam --- lib/librte_ethdev/rte_flow.c| 13 +++-- lib/librte_ethdev/rte_flow_driver.h | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] examples/l3fwd-regex: add regex based l3fwd

2020-10-18 Thread Thomas Monjalon
18/10/2020 13:53, Guy Kaneti: > From: Thomas Monjalon > > > From: Guy Kaneti > > > > > > Add regex based l3fwd application > > > inline with normal l3fwd. only LPM is supported. > > > > The trend is to reduce the number of example applications. > > Do you think regex could be an option in the or

[dpdk-dev] [PATCH 00/14] ethdev: remove legacy filter API

2020-10-18 Thread Andrew Rybchenko
Removal is aggressive and tries to cleanup all dead code from drivers. tep_termination example still uses TUNNEL filters. Functionality is broken when TUNNEL filter is removed and finally even build of the example is broken when API is removed. What to do with it? Andrew Rybchenko (14): ethdev:

[dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver

2020-10-18 Thread Andrew Rybchenko
net/i40e driver is the only user of the enum rte_mac_filter_type. Move the define to the driver and use i40e_ prefix instead of rte_. Signed-off-by: Andrew Rybchenko --- drivers/net/i40e/i40e_ethdev.c | 58 drivers/net/i40e/i40e_ethdev.h | 15 +++-- drive

[dpdk-dev] [PATCH 04/14] ethdev: remove legacy flexible filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Temporarily preserve helper defines in public interface. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 195 --- doc/guides/rel_notes/deprecation.rst | 2 +- drivers/net/e1000/igb_ethdev.c | 1

[dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 110 - doc/guides/rel_notes/deprecation.rst | 2 +- drivers/net/i40e/i40e_ethdev.c | 116 --- drivers/net/qede/qede_filter

[dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Move corresponding definitions to ethdev internal driver API since it is used by drivers internally. Preserve RTE_ETH_FILTER_ETHERTYPE because of it as well. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c| 115 --

[dpdk-dev] [PATCH 05/14] ethdev: move flexible filter type to e1000 driver

2020-10-18 Thread Andrew Rybchenko
net/e1000 driver is the only user of the struct rte_eth_flex_filter and helper defines. Move it to the driver and use igb_ prefix instead of rte_eth_. Signed-off-by: Andrew Rybchenko --- drivers/net/e1000/e1000_ethdev.h | 22 +-- drivers/net/e1000/igb_ethdev.c | 2 +- drivers

[dpdk-dev] [PATCH 06/14] ethdev: remove legacy SYN filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Move corresponding definitions to ethdev internal driver API since it is used by drivers internally. Preserve RTE_ETH_FILTER_SYN because of it as well. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c| 95 -

[dpdk-dev] [PATCH 07/14] ethdev: remove legacy N-tuple filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Preserve struct rte_eth_ntuple_filter in ethdev API since the structure and related defines are used in flow classify library and a number of drivers. Preserve RTE_ETH_FILTER_NTUPLE because of usage in drivers. Signed-off-by: Andrew Rybchenko --- app/

[dpdk-dev] [PATCH 08/14] ethdev: remove legacy TUNNEL filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Preserve struct rte_eth_ntuple_filter in ethdev API since the structure and related defines are used in flow classify library and a number of drivers. Preserve RTE_ETH_FILTER_TUNNEL because of usage in drivers. What to do with examples/tep_termination?

[dpdk-dev] [PATCH 10/14] ethdev: remove legacy L2_TUNNEL filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Preserve RTE_ETH_FILTER_L2_TUNNEL since it is used in drivers internally in RTE flow API support. rte_eth_l2_tunnel_conf structure is used in other ethdev API functions. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 123 --

[dpdk-dev] [PATCH 09/14] ethdev: remove legacy HASH filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Preserve RTE_ETH_FILTER_HASH since it is used in drivers internally in RTE flow API support. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 434 --- doc/guides/rel_notes/deprecation.rst | 4 +- driv

[dpdk-dev] [PATCH 13/14] app/testpmd: remove flow_director_flex_mask command

2020-10-18 Thread Andrew Rybchenko
The command uses FDIR filter information get API which is not supported any more. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 124 - 1 file changed, 124 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 9ce6c

[dpdk-dev] [PATCH 11/14] ethdev: remove legacy global filter configuration support

2020-10-18 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 57 -- drivers/net/i40e/i40e_ethdev.c | 45 --- drivers/net/sfc/sfc_ethdev.c | 3 -- 3 files changed, 105 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pm

[dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions

2020-10-18 Thread Andrew Rybchenko
The legacy filter API, including rte_eth_dev_filter_supported() and rte_eth_dev_filter_ctrl() is removed. Flow API should be used. examples/tep_termination build is broken. Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 6 doc/guides/rel_notes/release_20_11

[dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-18 Thread Andrew Rybchenko
RTE flow API should be used for filtering. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 897 +++ app/test-pmd/config.c| 15 +- app/test-pmd/testpmd.h | 2 + doc/guides/rel_notes/deprecation.rst | 4 +- drive

[dpdk-dev] [PATCH v1] app/regex: fix segfault in getopt_long call

2020-10-18 Thread Ophir Munk
getopt_long() parses command-line arguments. One of its arguments 'longopts' is a pointer to the first element of an array of struct option. The last element of the array has to be filled with zeros to mark the end of options. For example: struct option longopts[] = { { "help", 0, 0, ARG_HELP},

Re: [dpdk-dev] [PATCH v2 0/5] net/mlx5: support match on L3 fragmented packets

2020-10-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, October 15, 2020 5:06 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/5] net/mlx5: support match on L3 > fragmented packets > > Patch series [1]

Re: [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support

2020-10-18 Thread Ajit Khaparde
On Sun, Oct 18, 2020 at 7:09 AM Andrew Rybchenko wrote: > > RTE flow API should be used for filtering. > > Move corresponding definitions to ethdev internal driver API > since it is used by drivers internally. > Preserve RTE_ETH_FILTER_ETHERTYPE because of it as well. > > Signed-off-by: Andrew Ryb

Re: [dpdk-dev] [PATCH 08/14] ethdev: remove legacy TUNNEL filter type support

2020-10-18 Thread Ajit Khaparde
On Sun, Oct 18, 2020 at 7:09 AM Andrew Rybchenko wrote: > > RTE flow API should be used for filtering. > > Preserve struct rte_eth_ntuple_filter in ethdev API since > the structure and related defines are used in flow classify > library and a number of drivers. > > Preserve RTE_ETH_FILTER_TUNNEL b

Re: [dpdk-dev] [PATCH 07/14] ethdev: remove legacy N-tuple filter type support

2020-10-18 Thread Ajit Khaparde
On Sun, Oct 18, 2020 at 7:09 AM Andrew Rybchenko wrote: > > RTE flow API should be used for filtering. > > Preserve struct rte_eth_ntuple_filter in ethdev API since > the structure and related defines are used in flow classify > library and a number of drivers. > > Preserve RTE_ETH_FILTER_NTUPLE b

Re: [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-18 Thread Ajit Khaparde
On Sun, Oct 18, 2020 at 7:09 AM Andrew Rybchenko wrote: > > RTE flow API should be used for filtering. > > Signed-off-by: Andrew Rybchenko For bnxt PMD Acked-by: Ajit Khaparde > --- > app/test-pmd/cmdline.c | 897 +++ > app/test-pmd/config.c

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread yang_y_yi
At 2020-10-16 00:16:03, "Ananyev, Konstantin" wrote: > > >> >> > -Original Message- >> > From: Ananyev, Konstantin >> > Sent: Wednesday, October 14, 2020 8:06 PM >> > To: yang_y_yi ; Hu, Jiayu >> > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; >> > yangy...@inspur.com

[dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue

2020-10-18 Thread Yuying Zhang
i40evf_execute_vf_cmd() uses _atomic_set_cmd() to execute virtual channel commands safely in multi-process mode and multi-thread mode. However, it returns -1 when one process or thread is pending. Add rte_spinlock_trylock() to handle this issue in concurrent scenarios. Fixes: 4861cde46116 ("i40e:

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread yang_y_yi
At 2020-10-16 08:53:00, "Hu, Jiayu" wrote: > > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Friday, October 16, 2020 12:16 AM >> To: Hu, Jiayu ; yang_y_yi >> Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; >> yangy...@inspur.com >> Subject: RE: Re:RE: [PATCH

Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats

2020-10-18 Thread Min Hu (Connor)
在 2020/10/16 20:16, Ferruh Yigit 写道: On 10/14/2020 3:26 AM, Ferruh Yigit wrote: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. As a result of technical board discussion, decided to remove the queue stati

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, October 16, 2020 4:31 PM > To: Hu, Jiayu ; yang_y_yi > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; > yangy...@inspur.com > Subject: RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach to

Re: [dpdk-dev] [PATCH v6 4/4] doc: update release notes for vhost sample

2020-10-18 Thread Jiang, Cheng1
Hi Maxime, I noticed there are two errors reported in the CI system. And we think it may have nothing to do with us. Just for your information. Thanks, Cheng > -Original Message- > From: Jiang, Cheng1 > Sent: Friday, October 16, 2020 12:29 PM > To: maxime.coque...@redhat.com; Xia, Chen

[dpdk-dev] [PATCH v2] net/iavf: fix unchecked Tx cleanup error

2020-10-18 Thread Leyi Rong
Coverity complains of unchecked return value warning of iavf_xmit_cleanup, while this cleanup is opportunistic and will not cause problems if it fails. So instead of checking the return value of iavf_xmit_cleanup and return in case of cleanup failure, we directly cast it to void function to make th

Re: [dpdk-dev] [PATCH 05/14] ethdev: move flexible filter type to e1000 driver

2020-10-18 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 22:09 > To: Guo, Jia ; Wang, Haiyue ; > Thomas Monjalon > ; Yigit, Ferruh ; Andrew > Rybchenko > > Cc: dev@dpdk.org > Subject: [PATCH 05/14] ethdev: move flexible filter type to e1000 driver > > net/e1000 dr

Re: [dpdk-dev] [PATCH 04/14] ethdev: remove legacy flexible filter type support

2020-10-18 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 22:09 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Guo, > Jia ; Wang, Haiyue ; Rasesh Mody > ; Shahed > Shaikh ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject

Re: [dpdk-dev] [PATCH v11 1/8] eal/x86: introduce AVX 512-bit type

2020-10-18 Thread Kinsella, Ray
On 16/10/2020 16:42, Vladimir Medvedkin wrote: > New data type to manipulate 512 bit AVX values. > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Ananyev This patch has already been applied - need to drop it from the v12. Ray K

[dpdk-dev] [PATCH] net/mlx5: fix xstats reset reinitialization

2020-10-18 Thread Shiri Kuzin
The mlx5_xstats_reset clears the device extended statistics. In this function the driver may reinitialize the structures that are used to read device counters. In case of reinitialization, the number of counters may change, which wouldn't be taken into account by the reset API callback and can cau

Re: [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support

2020-10-18 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 22:09 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Ajit > Khaparde ; Somnath Kotur > ; Guo, Jia > ; Wang, Haiyue ; Ziyang Xuan > ; > Xiaoyun Wang ; Guoyang Zhou

Re: [dpdk-dev] [PATCH 10/14] ethdev: remove legacy L2_TUNNEL filter type support

2020-10-18 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 22:09 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Guo, > Jia ; Wang, Haiyue ; Rasesh Mody > ; Shahed > Shaikh > Cc: dev@dpdk.org > Subject: [PATCH 10/14] ethdev

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread yang_y_yi
At 2020-10-19 11:17:48, "Hu, Jiayu" wrote: > > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Friday, October 16, 2020 4:31 PM >> To: Hu, Jiayu ; yang_y_yi >> Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; >> yangy...@inspur.com >> Subject: RE: Re:RE: [PATCH]

Re: [dpdk-dev] [PATCH 06/14] ethdev: remove legacy SYN filter type support

2020-10-18 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 22:09 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Guo, > Jia ; Wang, Haiyue ; Rasesh Mody > ; Shahed > Shaikh ; Andrew Rybchenko > ; Thomas Monjalon > ; Yigit,

Re: [dpdk-dev] [PATCH 07/14] ethdev: remove legacy N-tuple filter type support

2020-10-18 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 22:09 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Ajit > Khaparde ; Somnath Kotur > ; Guo, Jia > ; Wang, Haiyue ; Rasesh Mody > ; Shahed > Shaikh ; Andrew Rybch

Re: [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-18 Thread Wang, Haiyue
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 22:09 > To: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard > ; Ray Kinsella ; Neil Horman > ; Ajit > Khaparde ; Somnath Kotur > ; John Daley > ; Hyong Youb Kim ; Guo, Jia > ; Wang, Haiyue > ; Matan Azrad