Re: [dpdk-dev] [PATCH v2 0/6] improve building docs

2020-09-30 Thread Thomas Monjalon
> When building the documentation, a lot of text is output, meaning that > any warnings can be missed in all the text. Unfortunately, ninja merges > both stderr and stdout of all tasks so one cannot just redirect stdout to > a separate location as part of the build command to rectify that. > Theref

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields

2020-09-30 Thread Ori Kam
Hi Li, PSB, Thanks, Ori > -Original Message- > From: Li Zhang > Sent: Monday, September 28, 2020 6:38 AM > Subject: [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields > > PRM expose fields "Icmp_header_data" in ICMP. > Update ICMP mask parameter with ICMP identifier and sequ

Re: [dpdk-dev] [PATCH] ethdev: support query of AGE action

2020-09-30 Thread Ori Kam
Hi Dekel, PSB, Best, Ori > -Original Message- > From: Dekel Peled > Sent: Wednesday, September 30, 2020 12:04 PM > Subject: [PATCH] ethdev: support query of AGE action > > Existing API supports AGE action to monitor the aging of a flow. > This patch implements RFC [1], introducing the

Re: [dpdk-dev] [PATCH 01/10] ethdev: add extensions attributes to IPv6 item

2020-09-30 Thread Ori Kam
> -Original Message- > From: Dekel Peled > Sent: Wednesday, September 30, 2020 5:10 PM > Subject: [PATCH 01/10] ethdev: add extensions attributes to IPv6 item > > Using the current implementation of DPDK, an application cannot match on > IPv6 packets, based on the existing extension hea

Re: [dpdk-dev] [PATCH 03/10] app/testpmd: support IPv4 fragments

2020-09-30 Thread Ori Kam
> -Original Message- > From: Dekel Peled > Sent: Wednesday, September 30, 2020 5:10 PM > Subject: [PATCH 03/10] app/testpmd: support IPv4 fragments > > This patch updates testpmd CLI to support fragment_offset field of > IPv4 header item. > > To match on non-fragmented IPv4 packets, n

Re: [dpdk-dev] [PATCH 02/10] ethdev: add IPv6 fragment extension header item

2020-09-30 Thread Ori Kam
> -Original Message- > From: Dekel Peled > Sent: Wednesday, September 30, 2020 5:10 PM > Subject: [PATCH 02/10] ethdev: add IPv6 fragment extension header item > > Applications handling fragmented IPv6 packets need to match on IPv6 > fragment extension header, in order to identify the

Re: [dpdk-dev] [PATCH 05/10] app/testpmd: support IPv6 fragment extension item

2020-09-30 Thread Ori Kam
> -Original Message- > From: Dekel Peled > Sent: Wednesday, September 30, 2020 5:10 PM > Cc: dev@dpdk.org > Subject: [PATCH 05/10] app/testpmd: support IPv6 fragment extension item > > rte_flow update, following RFC [1], added to ethdev the rte_flow item > ipv6_frag_ext. > This patch u

[dpdk-dev] [PATCH v2] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-09-30 Thread 谢华伟(此时此刻)
From c13f981e287254cd0877cc7b98ee2dd7b80c3b69 Mon Sep 17 00:00:00 2001 From: "huawei.xhw" Date: Wed, 30 Sep 2020 22:37:03 +0800 Subject: [PATCH v2] pci:  support both PIO and MMIO BAR for legacy virtio on  x86 Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virti

Re: [dpdk-dev] [PATCH v3 17/18] net: add checks for max SIMD bitwidth

2020-09-30 Thread Coyle, David
Hi Ciara, > From: dev On Behalf Of Ciara Power > When choosing a vector path to take, an extra condition must be satisfied to > ensure the max SIMD bitwidth allows for the CPU enabled path. > > The vector path was initially chosen in RTE_INIT, however this is no longer > suitable as we cannot ch

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-30 Thread Ferruh Yigit
On 9/17/2020 4:40 PM, Hemant Agrawal wrote: On 9/17/2020 5:29 PM, Ferruh Yigit wrote: On 9/17/2020 12:50 PM, Hemant Agrawal wrote: On 9/17/2020 5:08 PM, Ferruh Yigit wrote: On 9/17/2020 3:03 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, Septembe

Re: [dpdk-dev] [PATCH v3] net/af_xdp: custom XDP program loading

2020-09-30 Thread Ferruh Yigit
On 9/25/2020 10:20 AM, Ciara Loftus wrote: The new 'xdp_prog=' vdev arg allows the user to specify the path to a custom XDP program to be set on the device, instead of the default libbpf one. The program must have an XSK_MAP of name 'xsks_map' which will allow for the redirection of some packets

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields

2020-09-30 Thread Li Zhang
Hi Ori, Thanks for your comments, please take a look my reply inline. Regards, Li Zhang > -Original Message- > From: Ori Kam > Sent: Wednesday, September 30, 2020 10:46 PM > To: Li Zhang ; Dekel Peled ; Slava > Ovsiienko ; Matan Azrad > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ;

Re: [dpdk-dev] [PATCH 1/2] net/virtio: setup Tx region for packed ring

2020-09-30 Thread Maxime Coquelin
Hi Marvin, Thanks for taking care of this! I think we need to add Fixes tag On 9/28/20 10:20 AM, Marvin Liu wrote: > Add packed indirect descriptors format into virtio Tx region. When > initializing vring, packed indirect descriptors will be initialized if > ring type is packed. > > Signed-off-b

Re: [dpdk-dev] [PATCH 2/2] net/virtio: use indirect ring in packed datapath

2020-09-30 Thread Maxime Coquelin
On 9/28/20 10:20 AM, Marvin Liu wrote: > Like split ring, packed ring will utilize indirect ring elements when > queuing mbufs need multiple descriptors. Thus each packet will take only > one slot when having multiple segments. > > Signed-off-by: Marvin Liu > In this patch also I would add

Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-09-30 Thread Dmitry Kozlyuk
On Wed, 30 Sep 2020 09:11:41 +0100, Kinsella, Ray wrote: > On 05/08/2020 12:17, Dmitry Kozlyuk wrote: > > On Wed, 5 Aug 2020 10:31:31 +0100, Kinsella, Ray wrote: > >> On 30/07/2020 22:06, Dmitry Kozlyuk wrote: > >>> struct cmdline exposes platform-specific members it contains, most > >>> notabl

Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet

2020-09-30 Thread Ferruh Yigit
On 9/23/2020 10:04 AM, Ferruh Yigit wrote: On 9/9/2020 4:34 AM, Li Zhang wrote: From: lizh Ability to distinguish ICMP identifier fields in packets. Dstinguish ICMP sequence number field too. Already supports ICMP code and type fields in current version. Existing fields in ICMP header contain

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-30 Thread Maxime Coquelin
Hi, On 9/30/20 4:48 AM, Xia, Chenbo wrote: > Hi Fan & Maxime, > > I am thinking that should we move set_features outside of new_device callback > for crypto device? I see that net and blk devices both set features between > register > and start, and personally I think this makes sense that devic

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/sfc: fix RSS hash flag when offload is disabled

2020-09-30 Thread Ferruh Yigit
On 9/24/2020 1:40 PM, Andrew Rybchenko wrote: From: Igor Romanov Do not set RSS hash flag in the received mbufs when RSS hash offload is not enabled, which means that RSS hash value is invalid. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Cc: sta...@dpdk.org Signed-off-by

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields

2020-09-30 Thread Li Zhang
Hi Ori, Update my reply about split mlx5_flow_validate_item_icmp function inline Regards, Li Zhang > -Original Message- > From: Li Zhang > Sent: Wednesday, September 30, 2020 11:20 PM > To: Ori Kam ; Dekel Peled ; Slava > Ovsiienko ; Matan Azrad > Cc: dev@dpdk.org; NBU-Contact-Thomas Mon

Re: [dpdk-dev] [PATCH v3 17/18] net: add checks for max SIMD bitwidth

2020-09-30 Thread Singh, Jasvinder
> -Original Message- > From: Coyle, David > Sent: Wednesday, September 30, 2020 4:04 PM > To: Power, Ciara ; dev@dpdk.org > Cc: Power, Ciara ; Singh, Jasvinder > ; Olivier Matz ; > O'loingsigh, Mairtin ; Ryan, Brendan > ; Richardson, Bruce > > Subject: RE: [dpdk-dev] [PATCH v3 17/18] n

Re: [dpdk-dev] [RFC v2] ethdev: add VLAN attributes to ETH and VLAN items

2020-09-30 Thread Matan Azrad
Hi Maxime From: Maxime Leroy: > Hi Dekel, > > On Thu, Aug 6, 2020 at 12:40 PM Dekel Peled > wrote: > > > > In existing code the match on tagged/untagged packets is not explicit. > > Recent documentation update [1] describes the different patterns and > > clarifies the intended use of different

Re: [dpdk-dev] [PATCH 00/22] Add DLB2 PMD

2020-09-30 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, September 29, 2020 1:41 PM > To: McDaniel, Timothy > Cc: dpdk-dev ; Carrillo, Erik G ; > Eads, Gage ; Van Haaren, Harry > ; Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH 00/22] Add DLB2 PMD > > On Mon, Sep 21, 2020 at 10:45 PM M

Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility

2020-09-30 Thread Ferruh Yigit
On 9/16/2020 5:44 PM, Bruce Richardson wrote: As flagged previously on-list, there are a number of macros used to specify what libs and drivers are enabled in the build which differ from the equivalents used with make. This patchset is one possible approach to fixing these, but as part of the inv

Re: [dpdk-dev] [PATCH 00/22] Add DLB2 PMD

2020-09-30 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, September 29, 2020 1:46 PM > To: McDaniel, Timothy ; Thomas Monjalon > ; David Marchand ; > Ma, Liang J > Cc: dpdk-dev ; Carrillo, Erik G ; > Eads, Gage ; Van Haaren, Harry > ; Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH 00/22]

Re: [dpdk-dev] [PATCH v2] vhost: remove experimental tag on vDPA API

2020-09-30 Thread Maxime Coquelin
On 9/15/20 9:25 AM, Maxime Coquelin wrote: > As announced in v20.08, this patch makes the vDPA > and related Vhost API stable. > > Signed-off-by: Maxime Coquelin > --- > - v2: remove missed __rte_experimental tag > > lib/librte_vhost/rte_vdpa.h| 36 -- > l

Re: [dpdk-dev] [PATCH 1/2] net/virtio: set UNKNOWN as default speed

2020-09-30 Thread Maxime Coquelin
On 9/22/20 11:18 PM, Ivan Dyukov wrote: > rte_ethdev states new rule for NICs: they should return UNKNOWN > speed if speed is unknown and interface is up, in case of down > interface, NONE speed should be returned. > > Signed-off-by: Ivan Dyukov > --- > doc/guides/nics/virtio.rst | 4

Re: [dpdk-dev] [PATCH 2/2] net/virtio: sync a virtio speed capa with ethdev

2020-09-30 Thread Maxime Coquelin
On 9/22/20 11:18 PM, Ivan Dyukov wrote: > ethdev library was updated with new speed 200G > > Add 200G speed capa to virtio device > > Signed-off-by: Ivan Dyukov > --- > drivers/net/virtio/virtio_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) Applied to dpdk-next-virtio/main. Thanks, M

Re: [dpdk-dev] [PATCH 1/2] net/virtio: setup Tx region for packed ring

2020-09-30 Thread Maxime Coquelin
On 9/28/20 10:20 AM, Marvin Liu wrote: > Add packed indirect descriptors format into virtio Tx region. When > initializing vring, packed indirect descriptors will be initialized if > ring type is packed. > > Signed-off-by: Marvin Liu Applied to dpdk-next-virtio/main with suggested commit mes

Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility

2020-09-30 Thread Bruce Richardson
On Wed, Sep 30, 2020 at 05:12:50PM +0100, Ferruh Yigit wrote: > On 9/16/2020 5:44 PM, Bruce Richardson wrote: > > As flagged previously on-list, there are a number of macros used to specify > > what libs and drivers are enabled in the build which differ from the > > equivalents used with make. This

Re: [dpdk-dev] [PATCH] examples/vhost_blk: fix unchecked return value

2020-09-30 Thread Maxime Coquelin
On 9/25/20 1:22 PM, wangyunjian wrote: > From: Yunjian Wang > > This checks the return value from the function > rte_vhost_driver_start. > > Coverity issue: 362027 > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wa

Re: [dpdk-dev] [PATCH 2/2] net/virtio: use indirect ring in packed datapath

2020-09-30 Thread Maxime Coquelin
On 9/28/20 10:20 AM, Marvin Liu wrote: > Like split ring, packed ring will utilize indirect ring elements when > queuing mbufs need multiple descriptors. Thus each packet will take only > one slot when having multiple segments. > > Signed-off-by: Marvin Liu Applied to dpdk-next-virtio/main w

Re: [dpdk-dev] [PATCH v2 0/4] vhost: remove dequeue zero-copy support

2020-09-30 Thread Maxime Coquelin
On 9/28/20 11:17 AM, Maxime Coquelin wrote: > As announced in DPDK v20.08, this series removes > dequeue zero-copy support to Vhost library. > > Support for the feature is also being removed in OVS. > > Changes in v2: > -- > * Fix build issue due to unused symbol (Chenbo) > * Remo

Re: [dpdk-dev] [PATCH v3 0/8] virtio-user: introduce vhost-vdpa backend

2020-09-30 Thread Maxime Coquelin
On 9/29/20 6:13 PM, Maxime Coquelin wrote: > vhost-vDPA is a new vhost backend type introduced by vDPA kernel > framework, which provides abstruction to the vDPA devices and > exposes to userspace a unified control interface through char devs. > > This patch set adds vhost-vdpa backend type to

Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when used latency stats lib

2020-09-30 Thread Ferruh Yigit
On 9/15/2020 3:08 AM, SteveX Yang wrote: meson build cannot find the header rte_latencystats.h when build DPDK first time or never installed DPDK lib after build via meson/ninja. Because the corresponding header directory isn't included after enabled RTE_LIBRTE_LATENCY_STATS flag. Add the lib '

Re: [dpdk-dev] [PATCH v3] app/test-pmd: fix meson build failed when enabled pmd_bonded

2020-09-30 Thread Ferruh Yigit
On 9/15/2020 3:24 AM, SteveX Yang wrote: The depended pmd bond is missing for test-pmd. Add the pmd_bond to deps, and replace the relative MACRO name with new RTE_LIBRTE_BOND_PMD. Fixes: 2950a769315e ("bond: testpmd support") Signed-off-by: SteveX Yang This one too superseded for the generic

Re: [dpdk-dev] [PATCH] net/sfc: create virtual switch to enable VFs

2020-09-30 Thread Ferruh Yigit
On 9/24/2020 2:02 PM, Andrew Rybchenko wrote: PF driver is responsible for vSwitch creation and vPorts allocation for VFs. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-30 Thread Zhang, Roy Fan
Hi Chenbo and Maxime, Thanks for replying the email. > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 30, 2020 4:37 PM > To: Xia, Chenbo ; Zhang, Roy Fan > ; Liu, Changpeng ; > dev@dpdk.org > Cc: ma...@mellanox.com; Zawadzki, Tomasz ; > Yigit, Ferruh > Subject

[dpdk-dev] [PATCH v3 1/1] net/mlx5: support match ICMP identifier fields

2020-09-30 Thread Li Zhang
PRM expose fields "Icmp_header_data" in IPv4 ICMP. Update ICMP mask parameter with ICMP identifier and sequence number fields. ICMP sequence number spec with mask, Icmp_header_data low 16 bits are set. ICMP identifier spec with mask, Icmp_header_data high 16 bits are set. Signed-off-by: Li Zhang

Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility

2020-09-30 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, September 23, 2020 1:46 PM > To: Richardson, Bruce > Cc: Andrew Rybchenko ; > david.march...@redhat.com; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for > compati

Re: [dpdk-dev] [PATCH V15 3/3] app/testpmd: add FEC command

2020-09-30 Thread Ferruh Yigit
On 9/29/2020 2:03 AM, Min Hu (Connor) wrote: This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC

Re: [dpdk-dev] [PATCH v9 05/10] baseband/acc100: add LDPC processing functions

2020-09-30 Thread Tom Rix
On 9/28/20 5:29 PM, Nicolas Chautru wrote: > Adding LDPC decode and encode processing operations > > Signed-off-by: Nicolas Chautru > Acked-by: Liu Tianjiao > Acked-by: Dave Burley > --- > doc/guides/bbdevs/features/acc100.ini|8 +- > drivers/baseband/acc100/rte_acc100_pmd.c | 1625 >

Re: [dpdk-dev] [PATCH v2] net/ring: advertise multi segment TX and scatter RX.

2020-09-30 Thread Ferruh Yigit
On 9/29/2020 9:37 AM, Bruce Richardson wrote: On Mon, Sep 28, 2020 at 08:47:29PM +0200, Dumitru Ceara wrote: Even though ring interfaces don't support any other TX/RX offloads they do support sending multi segment packets and this should be advertised in order to not break applications that use

Re: [dpdk-dev] [PATCH v3 1/3] net: fix variable size of ethdev port id

2020-09-30 Thread Ferruh Yigit
On 9/30/2020 5:23 AM, Chenbo Xia wrote: The ethdev port id should be 16 bits now. This patch changes the variable size of port id in some net drivers from 8 bits to 16 bits. Fixes: 09b23f8b9df6 ("net/bnxt: fix port stop process and cleanup resources") Fixes: 769de16872ab ("net/bnxt: fix port def

Re: [dpdk-dev] [PATCH v9 06/10] baseband/acc100: add HARQ loopback support

2020-09-30 Thread Tom Rix
On 9/28/20 5:29 PM, Nicolas Chautru wrote: > Additional support for HARQ memory loopback > > Signed-off-by: Nicolas Chautru > Acked-by: Liu Tianjiao > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 158 > +++ > 1 file changed, 158 insertions(+) > > diff --git a/d

[dpdk-dev] [PATCH] doc: fix references to removed guide

2020-09-30 Thread Thomas Monjalon
The page "Development Kit Build System" was about make, so it has been removed. A better help is in the Linux guide (note: mlx4/mlx5 are supported on Linux only for now). Fixes: 3cc6ecfdfe85 ("build: remove makefiles") Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx4.rst | 4 ++-- doc/gu

Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility

2020-09-30 Thread Thomas Monjalon
30/09/2020 18:49, Richardson, Bruce: > From: Thomas Monjalon > > 18/09/2020 10:41, Bruce Richardson: > > > On Thu, Sep 17, 2020 at 08:59:26PM +0300, Andrew Rybchenko wrote: > > > > On 9/16/20 7:44 PM, Bruce Richardson wrote: > > > > > * We still have inconsistencies in our driver macro and naming

[dpdk-dev] [PATCH v2 0/5] cryptodev: remove list end enumerators

2020-09-30 Thread Arek Kusztal
This patchset removes enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END from symmetric crypto as well as RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END, RTE_CRYPTO_ASYM_OP_LIST_END, RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END enumerators from asymmetric crypto API to prevent

[dpdk-dev] [PATCH v2 2/5] crypto/qat: remove asym list end references

2020-09-30 Thread Arek Kusztal
This patch removes LIST_END enumerators references from Intel QuickAssist Technology asymmetric crypto PMD. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c index 85

[dpdk-dev] [PATCH v2 1/5] app/test: remove list end references from asym crypto

2020-09-30 Thread Arek Kusztal
This patch removes RTE_CRYPTO_ASYM_OP_LIST_END reference from asymmetric crypto tests. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index dc

[dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators

2020-09-30 Thread Arek Kusztal
This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent some problems that may arise when adding new crypto algorithms. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_sym.h | 12 +++- 1 file changed, 3 inse

[dpdk-dev] [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto api

2020-09-30 Thread Arek Kusztal
This patch removes RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END, RTE_CRYPTO_ASYM_OP_LIST_END, RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END enumerators from asymmetric crypto API. When asymmetric API will no more be experimental adding new entries will be possible without ABI breakage. Signed-off-by: Arek Kusztal

[dpdk-dev] [PATCH v2 5/5] doc: remove crypto list end deprecation notice

2020-09-30 Thread Arek Kusztal
This patch removes deprecation notice about removing LIST_END enumerators from Cryptodev. Signed-off-by: Arek Kusztal --- doc/guides/rel_notes/deprecation.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst inde

Re: [dpdk-dev] [PATCH v3 1/3] net: fix variable size of ethdev port id

2020-09-30 Thread Ajit Khaparde
On Tue, Sep 29, 2020 at 9:28 PM Chenbo Xia wrote: > > The ethdev port id should be 16 bits now. This patch changes the > variable size of port id in some net drivers from 8 bits to 16 > bits. > > Fixes: 09b23f8b9df6 ("net/bnxt: fix port stop process and cleanup resources") > Fixes: 769de16872ab ("

Re: [dpdk-dev] [PATCH v9 07/10] baseband/acc100: add support for 4G processing

2020-09-30 Thread Tom Rix
On 9/28/20 5:29 PM, Nicolas Chautru wrote: > Adding capability for 4G encode and decoder processing > > Signed-off-by: Nicolas Chautru > Acked-by: Liu Tianjiao > --- > doc/guides/bbdevs/features/acc100.ini|4 +- > drivers/baseband/acc100/rte_acc100_pmd.c | 1010 > +

Re: [dpdk-dev] [20.11] [PATCH v2] stack: remove experimental tag from API

2020-09-30 Thread David Marchand
On Thu, May 28, 2020 at 5:06 PM Gage Eads wrote: > > The stack library was first released in 19.05, and its interfaces have been > stable since their initial introduction. This commit promotes the full > interface to stable, starting with the 20.11 major version. > > Signed-off-by: Gage Eads > --

Re: [dpdk-dev] [PATCH v9 05/10] baseband/acc100: add LDPC processing functions

2020-09-30 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 9/28/20 5:29 PM, Nicolas Chautru wrote: > > Adding LDPC decode and encode processing operations > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Liu Tianjiao > > Acked-by: Dave Burley > > --- > > doc/guides/bbdevs/features/acc100.ini|8 +- > > drivers

Re: [dpdk-dev] [PATCH v9 06/10] baseband/acc100: add HARQ loopback support

2020-09-30 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 9/28/20 5:29 PM, Nicolas Chautru wrote: > > Additional support for HARQ memory loopback > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Liu Tianjiao > > --- > > drivers/baseband/acc100/rte_acc100_pmd.c | 158 > > +++ > > 1 file ch

Re: [dpdk-dev] [PATCH v9 08/10] baseband/acc100: add interrupt support to PMD

2020-09-30 Thread Tom Rix
On 9/28/20 5:29 PM, Nicolas Chautru wrote: > Adding capability and functions to support MSI > interrupts, call backs and inforing. > > Signed-off-by: Nicolas Chautru > Acked-by: Liu Tianjiao > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 288 > ++- > drivers/ba

Re: [dpdk-dev] [PATCH] doc: fix references to removed guide

2020-09-30 Thread David Marchand
On Wed, Sep 30, 2020 at 7:27 PM Thomas Monjalon wrote: > > The page "Development Kit Build System" was about make, > so it has been removed. A better help is in the Linux guide > (note: mlx4/mlx5 are supported on Linux only for now). > > Fixes: 3cc6ecfdfe85 ("build: remove makefiles") > > Signed-o

Re: [dpdk-dev] [PATCH v9 07/10] baseband/acc100: add support for 4G processing

2020-09-30 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 9/28/20 5:29 PM, Nicolas Chautru wrote: > > Adding capability for 4G encode and decoder processing > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Liu Tianjiao > > --- > > doc/guides/bbdevs/features/acc100.ini|4 +- > > drivers/baseband/acc100/rte_acc

Re: [dpdk-dev] [PATCH v2 0/4] test/stack: improve multithreaded test

2020-09-30 Thread David Marchand
On Wed, Aug 12, 2020 at 9:20 PM Steven Lariau wrote: > > The current multithread DPDK stack test is using atomics operations to > share information between threads. > The lockfree stack implementation also uses atomic operations. > This is an issue for testing. The atomics operations for the test

Re: [dpdk-dev] [PATCH v2 0/5] lib/stack: improve lockfree C11 implementation

2020-09-30 Thread David Marchand
On Fri, Sep 25, 2020 at 7:44 PM Steven Lariau wrote: > > One implementation of the DPDK stack library is lockfree, > based on C11 memory model for atomics. > Some of these atomic operations use unnecessary memory orders, > that can be relaxed. > This patch relax some of these operations in order t

Re: [dpdk-dev] [dpdk-stable] [PATCH] stack: fix possible uninitialized success variable

2020-09-30 Thread David Marchand
On Mon, Sep 28, 2020 at 12:29 PM David Marchand wrote: > > From: Yunjian Wang > > > > This patch fixes an issue that uninitialized 'success' > > is used to be compared with '0'. > > > > Coverity issue: 337676 > > Fixes: 3340202f5954 ("stack: add lock-free implementation") > > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v9 09/10] baseband/acc100: add debug function to validate input

2020-09-30 Thread Tom Rix
On 9/28/20 5:29 PM, Nicolas Chautru wrote: > Debug functions to validate the input API from user > Only enabled in DEBUG mode at build time > > Signed-off-by: Nicolas Chautru > Acked-by: Liu Tianjiao > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 424 > +++ > 1

[dpdk-dev] [PATCH v5 1/9] sched: add support profile table

2020-09-30 Thread Savinay Dharmappa
Add subport profile data structure, subport profile table to internal port data structure and update the port config function. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 197 ++- lib/librte_sched/rte_sched.h

[dpdk-dev] [PATCH v5 0/9] Enable dynamic config of subport bandwidth

2020-09-30 Thread Savinay Dharmappa
DPDK sched library allows runtime configuration of the pipe profiles to the pipes of the subport once scheduler hierarchy is constructed. However, to change the subport level bandwidth, existing hierarchy needs to be dismantled and whole process of building hierarchy under subport nodes needs to be

[dpdk-dev] [PATCH v5 2/9] sched: add subport profile add api

2020-09-30 Thread Savinay Dharmappa
Add api to add new subport profile. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 66 ++ lib/librte_sched/rte_sched.h | 23 + lib/librte_sched/rte_sched_version.map | 2 + 3 files changed,

[dpdk-dev] [PATCH v5 3/9] sched : add dynamic config of subport bandwidth

2020-09-30 Thread Savinay Dharmappa
This patch adds support for dynamic config of subport bandwidth. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 219 +++ lib/librte_sched/rte_sched.h | 23 2 files changed, 242 insertions(+) diff --git a/

[dpdk-dev] [PATCH v5 6/9] example/ip_pipeline: add dynamic config of subport

2020-09-30 Thread Savinay Dharmappa
Modify the ip_pipeline application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically Signed-off-by: Savinay Dharmappa --- examples/ip_pipeline/cli.c | 17 +-- examples/ip

[dpdk-dev] [PATCH v5 5/9] example/qos_sched: add dynamic config of subport

2020-09-30 Thread Savinay Dharmappa
Modify the qos_sched application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically. Signed-off-by: Savinay Dharmappa --- examples/qos_sched/cfg_file.c | 151 +++--

[dpdk-dev] [PATCH v5 4/9] sched: update grinder credit and pipe config function

2020-09-30 Thread Savinay Dharmappa
Credits are updated by fetching subport profile parameters from subport profile table. Similarly subport best effort tc is calculated in pipe config. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 55 +--- 1 fil

[dpdk-dev] [PATCH v5 7/9] drivers/softnic: add dynamic config of subport

2020-09-30 Thread Savinay Dharmappa
Modify the softnic drivers to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically. Signed-off-by: Savinay Dharmappa --- .../net/softnic/rte_eth_softnic_internals.h | 18 +- drivers/

[dpdk-dev] [PATCH v5 8/9] app/test_sched: add dynamic config of subport

2020-09-30 Thread Savinay Dharmappa
Modify the test_sched application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically Signed-off-by: Savinay Dharmappa --- app/test/test_sched.c | 17 ++--- 1 file chang

[dpdk-dev] [PATCH v5 9/9] sched : remove redundant code

2020-09-30 Thread Savinay Dharmappa
Remove redundant data structure fields references from functions and subport level data structures. It also update the release and deprecation note Signed-off-by: Savinay Dharmappa --- app/test/test_sched.c| 2 +- doc/guides/rel_notes/deprecation.rst | 6 - doc/guides

Re: [dpdk-dev] [PATCH v6 00/42] Pipeline alignment with the P4 language

2020-09-30 Thread David Marchand
On Wed, Sep 30, 2020 at 8:34 AM Cristian Dumitrescu wrote: > > This patch set introduces a new pipeline type that combines the DPDK > performance with the flexibility of the P4-16 language[1]. The new API > can be used either by itself to code a complete software switch (SWX) > or data plane app,

Re: [dpdk-dev] [PATCH v9 08/10] baseband/acc100: add interrupt support to PMD

2020-09-30 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 9/28/20 5:29 PM, Nicolas Chautru wrote: > > Adding capability and functions to support MSI interrupts, call backs > > and inforing. > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Liu Tianjiao > > --- > > drivers/baseband/acc100/rte_acc100_pmd.c | 288 > > +++

Re: [dpdk-dev] [PATCH v9 09/10] baseband/acc100: add debug function to validate input

2020-09-30 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 9/28/20 5:29 PM, Nicolas Chautru wrote: > > Debug functions to validate the input API from user Only enabled in > > DEBUG mode at build time > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Liu Tianjiao > > --- > > drivers/baseband/acc100/rte_acc100_pmd.c | 42

Re: [dpdk-dev] [PATCH v9 10/10] baseband/acc100: add configure function

2020-09-30 Thread Tom Rix
On 9/28/20 5:29 PM, Nicolas Chautru wrote: > Add configure function to configure the PF from within > the bbdev-test itself without external application > configuration the device. > > Signed-off-by: Nicolas Chautru > Acked-by: Liu Tianjiao > --- > app/test-bbdev/test_bbdev_perf.c

Re: [dpdk-dev] [PATCH v4 1/8] test/distributor: fix deadlock with freezed worker

2020-09-30 Thread Lukasz Wojciechowski
Hi Honnappa, Thank you very much for your review Reply inline below W dniu 28.09.2020 o 01:34, Honnappa Nagarahalli pisze: > Hi Lukasz, > Few comments inline > > > >> The sanity test with worker shutdown delegates all bufs to be processed by a >> single lcore worker, then it freezes one of

Re: [dpdk-dev] [PATCH v2 0/4] vhost: remove dequeue zero-copy support

2020-09-30 Thread Ferruh Yigit
On 9/28/2020 10:17 AM, Maxime Coquelin wrote: As announced in DPDK v20.08, this series removes dequeue zero-copy support to Vhost library. Support for the feature is also being removed in OVS. Changes in v2: -- * Fix build issue due to unused symbol (Chenbo) * Remove remaining zmbuf

Re: [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD

2020-09-30 Thread Ajit Khaparde
On Tue, Sep 29, 2020 at 1:59 PM Ajit Khaparde wrote: > > Patches for bnxt PMD to add support for RSS level > selection, update HWRM API. Patchset applied to dpdk-next-net-brcm. > > Ajit Khaparde (3): > net/bnxt: add support for RSS hash selection > net/bnxt: update HWRM structures > doc: fi

[dpdk-dev] [PATCH] ethdev: use rte_pktmbuf_free_bulk()

2020-09-30 Thread Stephen Hemminger
The mbuf library now has routine to free multiple buffers. Loop is no longer needed. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c

Re: [dpdk-dev] [PATCH v2] vhost: remove experimental tag on vDPA API

2020-09-30 Thread Ferruh Yigit
On 9/30/2020 5:17 PM, Maxime Coquelin wrote: On 9/15/20 9:25 AM, Maxime Coquelin wrote: As announced in v20.08, this patch makes the vDPA and related Vhost API stable. Signed-off-by: Maxime Coquelin --- - v2: remove missed __rte_experimental tag lib/librte_vhost/rte_vdpa.h| 36

Re: [dpdk-dev] [PATCH 3/3] doc: fix vector mode info for bnxt

2020-09-30 Thread Lance Richardson
On Tue, Sep 29, 2020 at 5:01 PM Ajit Khaparde wrote: > > Vector mode is disabled when jumbo frames are enabled. > This usage guide was reporting it incorrectly. > > Fixes: 1adaf0e0f2ee ("doc: update bnxt guide") > Cc:sta...@dpdk.org > > Signed-off-by: Ajit Khaparde > --- > doc/guides/nics/bnxt.r

Re: [dpdk-dev] [PATCH 3/3] doc: fix vector mode info for bnxt

2020-09-30 Thread Ajit Khaparde
On Wed, Sep 30, 2020 at 10:28 AM Lance Richardson wrote: > > On Tue, Sep 29, 2020 at 5:01 PM Ajit Khaparde > wrote: > > > > Vector mode is disabled when jumbo frames are enabled. > > This usage guide was reporting it incorrectly. > > > > Fixes: 1adaf0e0f2ee ("doc: update bnxt guide") > > Cc:sta..

[dpdk-dev] [PATCH] stack: remove experimental tag from API

2020-09-30 Thread Gage Eads
The stack library was first released in 19.05, and its interfaces have been stable since their initial introduction. This commit promotes the full interface to stable, starting with the 20.11 major version. Signed-off-by: Gage Eads Acked-by: David Marchand --- doc/guides/rel_notes/release_20_11

Re: [dpdk-dev] [PATCH v5 03/20] doc: remove references to make from Linux guide

2020-09-30 Thread Thomas Monjalon
Hi, Below are some comments. If you agree, I will do the changes myself while pushing to the main branch. 21/09/2020 15:59, Ciara Power: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > Reviewed-by: Bruce Rich

Re: [dpdk-dev] [PATCH 2/3] net/bnxt: update HWRM structures

2020-09-30 Thread Ferruh Yigit
On 9/29/2020 9:59 PM, Ajit Khaparde wrote: HWRM API to a newer 1.10.1.70 version. Few fields have been renamed because of this. rx_err_pkt -> rx_discard_pkts rx_drop_pkts -> rx_error_pkts tx_err_pkts -> tx_discard_pkts tx_drop_pkts -> tx_error_pkts link_signal_mode -> active_fec_signal_mode t

Re: [dpdk-dev] [PATCH] net/enic: share flow actions with the same signature

2020-09-30 Thread Ferruh Yigit
On 9/30/2020 4:45 AM, John Daley wrote: Flow actions are a limited resource on the Cisco VIC, but they can be shared between flows if they are exactly the same. Use a hash table and a reference count in the PMD to enable sharing actions with the same signature between flows. Signed-off-by: John

Re: [dpdk-dev] [PATCH v3] eventdev: support telemetry with xstats info

2020-09-30 Thread Bruni, Jesse
Tested-by: Jesse Bruni mailto:jesse.br...@intel.com>> Sincerely, Jesse Bruni Network Software Engineer jesse.br...@intel.com 1300 S. Mopac Expressway Austin, TX 78746

[dpdk-dev] FW: [SPDK] Re: Potential defect in pci_unplug()

2020-09-30 Thread Niu, Yawei
On 2020/9/28, 11:44 PM, "Harris, James R" wrote: Hi Niu, I agree, this doesn't look right. Could you file an SPDK issue for this to make sure we track it? And then try sending an e-mail to the DPDK mailing list? I'm open to submitting a patch to our DPDK submodule short-term,

Re: [dpdk-dev] [PATCH v2 7/9] net/hns3: support start and stop Tx or Rx queue

2020-09-30 Thread Ferruh Yigit
On 9/29/2020 1:01 PM, Wei Hu (Xavier) wrote: From: Chengchang Tang The new generation hns3 network engine supports independent enabling and disabling of a single Tx/Rx queue. So, it can support the queue start and stop feature. In addition, when different numbers of Tx and Rx queues need to be

Re: [dpdk-dev] [PATCH v9 10/10] baseband/acc100: add configure function

2020-09-30 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 9/28/20 5:29 PM, Nicolas Chautru wrote: > > Add configure function to configure the PF from within the > > bbdev-test itself without external application configuration the device. > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Liu Tianjiao > > --- > > app/t

Re: [dpdk-dev] [PATCH v2 7/9] net/hns3: support start and stop Tx or Rx queue

2020-09-30 Thread Ferruh Yigit
On 9/30/2020 11:49 PM, Ferruh Yigit wrote: On 9/29/2020 1:01 PM, Wei Hu (Xavier) wrote: From: Chengchang Tang The new generation hns3 network engine supports independent enabling and disabling of a single Tx/Rx queue. So, it can support the queue start and stop feature. In addition, when diffe

Re: [dpdk-dev] [PATCH v2 0/9] updates and fixes for hns3 PMD driver

2020-09-30 Thread Ferruh Yigit
On 9/29/2020 1:01 PM, Wei Hu (Xavier) wrote: This series are updates and fixes for hns3 PMD driver. Chengchang Tang (1): net/hns3: support start and stop Tx or Rx queue Hongbo Zheng (2): net/hns3: check return value when reading PCI config space net/hns3: remove redundant return value

Re: [dpdk-dev] [PATCH v9 01/10] drivers/baseband: add PMD for ACC100

2020-09-30 Thread Tom Rix
On 9/29/20 4:17 PM, Chautru, Nicolas wrote: > Hi Tom, > >> -Original Message- >> From: Tom Rix >> Sent: Tuesday, September 29, 2020 12:54 PM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: Richardson, Bruce ; Xu, Rosen >> ; dave.bur...@accelercomm.com; >> aidan.god

Re: [dpdk-dev] [PATCH v9 02/10] baseband/acc100: add register definition file

2020-09-30 Thread Tom Rix
On 9/29/20 4:30 PM, Chautru, Nicolas wrote: > Hi Tom, > >> From: Tom Rix >> On 9/28/20 5:29 PM, Nicolas Chautru wrote: >>> Add in the list of registers for the device and related >>> HW specs definitions. >>> >>> Signed-off-by: Nicolas Chautru >>> Reviewed-by: Rosen Xu >>> Acked-by: Liu Tianj

Re: [dpdk-dev] [PATCH v9 03/10] baseband/acc100: add info get function

2020-09-30 Thread Tom Rix
On 9/29/20 5:25 PM, Chautru, Nicolas wrote: > Hi Tom, > >> From: Tom Rix >> On 9/28/20 5:29 PM, Nicolas Chautru wrote: >>> Add in the "info_get" function to the driver, to allow us to query the >>> device. >>> No processing capability are available yet. >>> Linking bbdev-test to support the PMD

Re: [dpdk-dev] [PATCH v9 01/10] drivers/baseband: add PMD for ACC100

2020-09-30 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 9/29/20 4:17 PM, Chautru, Nicolas wrote: > > Hi Tom, > > > >> -Original Message- > >> From: Tom Rix > >> Sent: Tuesday, September 29, 2020 12:54 PM > >> To: Chautru, Nicolas ; dev@dpdk.org; > >> akhil.go...@nxp.com > >> Cc: Richardson, Bruce ; Xu, Rosen > >>

Re: [dpdk-dev] [PATCH v9 04/10] baseband/acc100: add queue configuration

2020-09-30 Thread Tom Rix
On 9/29/20 6:03 PM, Chautru, Nicolas wrote: > Hi Tom, > >> From: Tom Rix >> On 9/28/20 5:29 PM, Nicolas Chautru wrote: >>> Adding function to create and configure queues for the device. Still >>> no capability. >>> >>> Signed-off-by: Nicolas Chautru >>> Reviewed-by: Rosen Xu >>> Acked-by: Liu

<    1   2   3   >