[dpdk-dev] [PATCH 8/8] net/bnxt: fix seg fault during NAT configuration

2020-09-22 Thread Somnath Kotur
From: Kishore Padmanabha Initialize the global parms structure to avoid seg fault in the truflow global configuration set api. Fixes: 0a58be6f7c1e ("net/bnxt: add access to NAT global register") Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ajit Kumar Khaparde --

Re: [dpdk-dev] [PATCH v2 09/13] net/mlx5: add ICMP protocol number definition

2020-09-22 Thread Thomas Monjalon
> From: Ophir Munk > > Some Windows distributions do not include ICMP protocol definitions > IPPROTO_ICMP and IPPROTO_ICMPV6. This commit defines them if needed. It is already defined (recently) in lib/librte_eal/windows/include/netinet/in.h I will drop this patch while pulling next-net.

[dpdk-dev] [PATCH v2 03/17] net/hns3: add default branch to switch in Rx VLAN processing

2020-09-22 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch solves the static check warning as follow: "The switch statement must have a 'default' branch". Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/hn

[dpdk-dev] [PATCH v2 01/17] net/hns3: add VLAN configuration compatibility

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Because of hardware limitation based on the old version of hns3 network engine, there are some restrictions: a) HNS3 PMD driver needs select different processing mode for VLAN based on whether PVID is set which means our driver need sense the PVID states. b) For pack

[dpdk-dev] [PATCH v2 00/17] updates for hns3 PMD driver

2020-09-22 Thread Wei Hu (Xavier)
This series are updates for hns3 PMD driver. Chengchang Tang (2): net/hns3: fix default VLAN won't be deleted when set PF PVID net/hns3: add default branch to switch in Rx VLAN processing Chengwen Feng (1): net/hns3: support flow action of queue region Hongbo Zheng (3): net/hns3: add max

[dpdk-dev] [PATCH v2 04/17] net/hns3: add max number of segs compatibility

2020-09-22 Thread Wei Hu (Xavier)
From: Hongbo Zheng Kunpeng 920 supports the maximum nb_segs of non-tso packet is 8 in Tx direction, kunpeng 930 expands this limit value to 18, this patch sets the corresponding value by querying the maximum number of non-tso nb_segs supported by the device during initialization. Signed-off-by:

[dpdk-dev] [PATCH v2 02/17] net/hns3: fix default VLAN won't be deleted when set PF PVID

2020-09-22 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, the default VLAN (vlan id 0) will never be deleted from the hardware VLAN table based on hns3 PF device. As a result, even a non-zero PVID is set by calling rte_eth_dev_set_vlan_pvid based on hns3 PF device, packets with VLAN 0 and without VLAN are still received

[dpdk-dev] [PATCH v2 05/17] net/hns3: add TSO pseudo header calculation compatibility

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" In kunpeng 920, when process pkts which need TSO, the network driver need to erase the L4 len value of the TCP TSO pseudo header and recalculate the pseudo header checksum. kunpeng930 support not need to erase the L4 len value of the TCP TSO pseudo header. Signed-off-by:

[dpdk-dev] [PATCH v2 08/17] net/hns3: add break to exit loop when err stat item found

2020-09-22 Thread Wei Hu (Xavier)
From: Hongbo Zheng This patch solves the redundant operation during traversal. In the internal function named hns3_error_int_stats_add for adding error statistics, because only one statistical item will be found in the for loop statement, a break can be executed after finding the error statistica

[dpdk-dev] [PATCH v2 11/17] net/hns3: check input RSS type when creating flow with RSS

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch adds checking the input RSS type when creating a flow with RSS. If the input RSS type are not supported based on hns3 network engine, an error is returned. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 26 --

[dpdk-dev] [PATCH v2 13/17] net/hns3: fix config when creating RSS rule after flush

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou Currnetly, when user create a flow RSS rule and then flush the rule, driver will set 0 for the internal structure of hw->rss_info maintained in driver. And then user create a flow RSS rule without specified RSS hash key, driver configure a validate RSS hash key into hardware networ

[dpdk-dev] [PATCH v2 06/17] net/hns3: avoid accessing nonexistent VF reg when PF in FLR

2020-09-22 Thread Wei Hu (Xavier)
From: Hongbo Zheng According to the protocol of PCIe, FLR to a PF device resets the PF state as well as the SR-IOV extended capability including VF Enable which means that VFs no longer exist. When PF device is in FLR reset stage, at this time, the register state of VF device is not reliable, so

[dpdk-dev] [PATCH v2 07/17] net/hns3: add default branch to switch when parsing fd tuple

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch solves the static check warning in the internal function named hns3_fd_convert_tuple as follow: "The switch statement must have a 'default' branch". Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_fdir.c | 8 ++--

[dpdk-dev] [PATCH v2 15/17] net/hns3: fix flushing RSS rule

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou When user create a flow without RSS by calling rte_flow_create API and then destroy it by calling rte_flow_flush API, driver should not clear RSS rule. A reasonable handling method is that when user creates an RSS rule, the driver should clear the created RSS rule when flushing de

[dpdk-dev] [PATCH v2 12/17] net/hns3: set RSS hash type input configuration

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch support for hash type input set configuration. That is, upper level application can call the rte_flow_create or rte_eth_dev_rss_hash_update API to set the specified tuples by RSS types. As a result, the hardware can selectively use the tuples to perform hash calculation

[dpdk-dev] [PATCH v2 10/17] net/hns3: support querying RSS flow rule

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch enables to query some RSS configurations of the specified rule. For example, show RSS hash function and rss types. Signed-off-by: Lijun Ou Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 23 --- 1 fi

[dpdk-dev] [PATCH v2 09/17] net/hns3: support flow action of queue region

2020-09-22 Thread Wei Hu (Xavier)
From: Chengwen Feng Kunpeng 930 hardware support spread packets to region of queues which can be configured by FDIR rule, it means user can create one FDIR rule which action is one region of queues, and then RSS use the region info to spread packets. As we know, RTE_FLOW_ACTION_TYPE_RSS is used

[dpdk-dev] [PATCH v2 17/17] net/hns3: fix storing RSS info when creating flow action

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when calling the rte_flow_query API function to query the RSS information, the queue related information is not as expected. The root cause is that when application call the rte_flow_create API function to create RSS action, the operation of storing the data wh

[dpdk-dev] [PATCH v2 14/17] net/hns3: fix flow RSS queue num with 0

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" When user specifies RSS queue num for 0 in action list by flow create API, it should create a valid flow rule. The following flow rule should be success in the command line of the testpmd application: flow create 0 actions rss queues / end Fixes: c37ca66f2b27 ("net/hns3

[dpdk-dev] [PATCH v2 16/17] net/hns3: fix configuring device with RSS is enabled

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when running the following commands in the CLI of testpmd application, the driver reports an -EINVAL error when performing the No.3 step. 1) flow create 0 ingress pattern end actions rss key func simple_xor types all end / end 2) flow flush 0 3) port confi

Re: [dpdk-dev] [EXT] RE: [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

2020-09-22 Thread wangyunjian
> -Original Message- > From: Harman Kalra [mailto:hka...@marvell.com] > Sent: Tuesday, September 22, 2020 6:32 PM > To: wangyunjian > Cc: dev@dpdk.org; david.march...@redhat.com; ferruh.yi...@intel.com; > Thomas Monjalon ; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Subject: Re: [EX

Re: [dpdk-dev] [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs

2020-09-22 Thread Zhang, Roy Fan
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, September 22, 2020 11:18 AM > To: Zhang, Roy Fan ; Akhil Goyal > ; dev@dpdk.org; Thomas Monjalon > > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > ; Dybkowski, AdamX > ; Bronowski, PiotrX > ; Anoob Joseph > Subj

Re: [dpdk-dev] [PATCH V9 1/3] ethdev: introduce FEC API

2020-09-22 Thread Andrew Rybchenko
On 9/22/20 2:06 PM, Min Hu (Connor) wrote: > > > 在 2020/9/22 16:02, Andrew Rybchenko 写道: >> On 9/22/20 7:58 AM, Min Hu (Connor) wrote: >>> >>> >>> 在 2020/9/21 21:39, Andrew Rybchenko 写道: On 9/21/20 9:13 AM, Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support fo

Re: [dpdk-dev] [PATCH v2 09/13] net/mlx5: add ICMP protocol number definition

2020-09-22 Thread Ophir Munk
Great. Thanks. It will save me a fix patch in my next series. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, September 22, 2020 2:50 PM > To: Ophir Munk > Cc: dev@dpdk.org; Raslan Darawsheh ; > ferruh.yi...@intel.com; Matan Azrad > Subject: Re: [dpdk-dev] [PATCH v2 09/13]

Re: [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support

2020-09-22 Thread Ferruh Yigit
On 9/17/2020 6:02 PM, Stephen Hemminger wrote: On Thu, 17 Sep 2020 07:30:15 +0200 Michal Krawczyk wrote: Hi, this patchset contains upgrade of the of the HAL, which, beside some fixes, also adds possibility for reading ENI metrics from the device. Those are further exposed to the DPDK applic

Re: [dpdk-dev] [PATCH v6 11/12] app/testpmd: add port and encap support for sample action

2020-09-22 Thread Jiawei(Jonny) Wang
Yes, Nice catch. I will fix it. Thanks. B.R. Jonny > -Original Message- > From: Ajit Khaparde > Sent: Tuesday, September 22, 2020 6:28 AM > To: Jiawei(Jonny) Wang > Cc: Ori Kam ; Slava Ovsiienko ; > Matan Azrad ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Marko > Kovacevic ; Andrew

Re: [dpdk-dev] [PATCH v1 3/6] app/test: fix freeing mbufs in distributor tests

2020-09-22 Thread David Marchand
Hello Lukasz, David, On Tue, Sep 15, 2020 at 9:35 PM Lukasz Wojciechowski wrote: > diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c > index 0e49e3714..da13a9a3f 100644 > --- a/app/test/test_distributor.c > +++ b/app/test/test_distributor.c > @@ -277,24 +277,21 @@ handle_wor

Re: [dpdk-dev] [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs

2020-09-22 Thread Zhang, Roy Fan
Hi Akhil, Konstantin and I had an off-line discussion. Is this structure ok for you? /** * Crypto virtual and IOVA address descriptor. Used to describe cryptographic * data without * */ struct rte_crypto_va_iova_ptr { void *va; rte_iova_t *iova; }; /** * Raw data operation d

Re: [dpdk-dev] [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs

2020-09-22 Thread Akhil Goyal
Hi Fan, > Hi Akhil, > > Konstantin and I had an off-line discussion. Is this structure ok for you? > > /** > * Crypto virtual and IOVA address descriptor. Used to describe cryptographic > * data without The comment is incomplete, however the structure is fine. > * > */ > struct rte_crypto_v

Re: [dpdk-dev] [PATCH v4] net/ice: refactor the Rx FlexiMD handling

2020-09-22 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Tuesday, September 22, 2020 3:24 PM > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi ; Yang, Qiming > ; Sun, GuinanX ; Guo, > Junfeng > Subject: RE: [PATCH v4] net/ice: refactor the Rx FlexiMD handling > >

Re: [dpdk-dev] [PATCH v5] net/i40e: fix incorrect byte counters

2020-09-22 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Junyu Jiang > Sent: Tuesday, September 22, 2020 5:20 PM > To: dev@dpdk.org > Cc: Guo, Jia ; Xing, Beilei ; Yigit, > Ferruh ; Jiang, JunyuX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v5] net/i40e: fix incorrect byte counters > > This p

Re: [dpdk-dev] [dpdk-stable] [PATCH][V2] net/af_xdp: avoid deadlock due to empty fill queue

2020-09-22 Thread Ferruh Yigit
On 9/18/2020 12:32 PM, Li RongQing wrote: when receive packets, it is possible to fail to reserve fill queue, since buffer ring is shared between tx and rx, and maybe not available temporary. at last, both fill queue and rx queue are empty. then kernel side will be unable to receive packets due

Re: [dpdk-dev] [PATCH v4] net/iavf: support gtpu outer and inner co-exist

2020-09-22 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Friday, September 18, 2020 1:47 PM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v4] net/iavf: support gtpu outer and inner co-exist > > Although currently only the gtpu inner hash be ena

Re: [dpdk-dev] [PATCH] ethdev: add security flow item

2020-09-22 Thread Ori Kam
Hi Tejasree, PSB > -Original Message- > From: Tejasree Kondoj > Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item > > Please see inline. > > Thanks > Tejasree > > > -Original Message- > > From: Ori Kam > > Sent: Tuesday, September 22, 2020 1:22 PM > > To: Asaf Pen

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix the default RSS key configuration

2020-09-22 Thread oulijun
在 2020/9/22 17:51, Phil Yang 写道: -Original Message- From: dev On Behalf Of Lijun Ou Sent: Thursday, September 10, 2020 9:51 AM To: wenzhuo...@intel.com; beilei.x...@intel.com; adrien.mazarg...@6wind.com; ferruh.yi...@intel.com Cc: dev@dpdk.org; linux...@huawei.com Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH] build: enable packet data prefetch

2020-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2020 16:21:35 +0800 Marvin Liu wrote: > Data prefetch instruction can preload data into cpu’s hierarchical > cache before data access. Virtualized data paths like virtio utilized > this feature for acceleration. Since most modern cpus have support > prefetch function, we can enable

Re: [dpdk-dev] [PATCH] ethdev: add security flow item

2020-09-22 Thread Tejasree Kondoj
Hi Ori, Please see inline. Thanks, Tejasree > -Original Message- > From: Tejasree Kondoj > Sent: Tuesday, September 22, 2020 2:37 PM > To: Ori Kam ; Asaf Penso ; Stephen > Hemminger > Cc: Akhil Goyal ; Radu Nicolau > ; Declan Doherty ; > NBU-Contact-Thomas Monjalon ; Ferruh Yigit > ; An

Re: [dpdk-dev] [PATCH] net/ring: advertise multi segment support.

2020-09-22 Thread Ferruh Yigit
On 9/18/2020 11:36 AM, Dumitru Ceara wrote: Even though ring interfaces don't support any other TX/RX offloads they do support sending multi segment packets and this should be advertised in order to not break applications that use ring interfaces. > Does ring PMD support sending multi segmented

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

2020-09-22 Thread Stephen Hemminger
On Wed, 15 Jul 2020 12:01:27 +0200 Thomas Monjalon wrote: > 14/07/2020 07:33, Stephen Hemminger: > > On Fri, 10 Jul 2020 17:06:11 +0200 > > David Marchand wrote: > > > > > About deprecating existing API/EAL flags in this release, this should > > > go through the standard deprecation process.

[dpdk-dev] [PATCH 3/8] drivers: replace references to blacklist

2020-09-22 Thread Stephen Hemminger
Use the new terminology blocked to describe when devices are excluded from being used. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c| 7 +++ drivers/bus/fslmc/fslmc_bus.c | 9 - drivers/bus/fslmc/fsl

[dpdk-dev] [PATCH 2/8] eal: replace usage of blacklist/whitelist in enum

2020-09-22 Thread Stephen Hemminger
This patch renames the enum values in the EAL include files. As a backward compatible temporary migration tool, define a replacement mapping for old values. The old names relating to blacklist and whitelist are replaced by block list and allow list, but applications may be using the older compatib

[dpdk-dev] [PATCH 0/8] replace blacklist/whitelist with block/allow

2020-09-22 Thread Stephen Hemminger
This is a revised version of the earlier RFC patch set for changing the blacklist/whitelist terms in DPDK. The first patch is a duplicate from the other patch set about use of master/slave in API. Stephen Hemminger (8): eal: add macro to mark macros as deprecated eal: replace usage of blackli

[dpdk-dev] [PATCH 1/8] eal: add macro to mark macros as deprecated

2020-09-22 Thread Stephen Hemminger
Add a macro that causes GCC and CLANG to emit a warning when a deprecated macro is used. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_common.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_com

[dpdk-dev] [PATCH 4/8] eal: replace pci-whitelist/pci-blacklist options

2020-09-22 Thread Stephen Hemminger
Replace -w / --pci-whitelist with -a / --allow options and -b / --pci-blacklist with -b / --block. Allow the old options for now, but print a nag warning since old options are deprecated. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_eal/common/eal_common_options.c |

[dpdk-dev] [PATCH 6/8] doc: replace references to blacklist/whitelist

2020-09-22 Thread Stephen Hemminger
The terms blacklist and whitelist are no longer used. Most of this was automatic replacement, but in a couple of places the language was awkward before and have tried to improve the readabilty. The blacklist/whitelist changes to API will not be a breaking change for applications in this release b

[dpdk-dev] [PATCH 5/8] app/test: use new allowlist and blocklist

2020-09-22 Thread Stephen Hemminger
Test the renamed blocklist and allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- app/test/autotest.py| 16 ++-- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2 +- app/

[dpdk-dev] [PATCH 8/8] doc: replace -w with -a in the documentation

2020-09-22 Thread Stephen Hemminger
The -w option is deprecated and replaced with -a Signed-off-by: Stephen Hemminger --- doc/guides/cryptodevs/qat.rst | 6 ++--- doc/guides/nics/bnxt.rst | 2 +- doc/guides/nics/cxgbe.rst | 8 +++ doc/guides/nics/enic.rst

[dpdk-dev] [PATCH 7/8] doc: change reference to allowlist relative to MAC filtering

2020-09-22 Thread Stephen Hemminger
Avoid potential confusion in documentation around allow option for bus addresses by rewording the text around MAC address filtering. Signed-off-by: Stephen Hemminger --- doc/guides/nics/bnxt.rst | 11 --- doc/guides/nics/features.rst | 2 +- doc/guides/nics/mlx4.rst | 2 +- doc

Re: [dpdk-dev] [PATCH v3 1/6] app/testpmd: fix missing verification of port id

2020-09-22 Thread Ferruh Yigit
On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang To set Tx vlan offloads, it is required to stop port firstly. But before checking whether the port is stopped, the port id entered by the user is not checked for validity. When the port id is illegal, it would lead to a segment

Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-22 Thread Ferruh Yigit
On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang Currently, if nb_txd is not set, the txpkts is not allowed to be set because the nb_txd is used to avoid the numer of segments exceed the Tx ring size and the default value of nb_txd is 0. And there is a bug that nb_txd is the

Re: [dpdk-dev] [PATCH v3 5/6] app/testpmd: fix valid desc id check

2020-09-22 Thread Ferruh Yigit
On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang The number of desc is a per queue configuration. But in the check function, nb_txd & nb_rxd are used to check whether the desc_id is valid. nb_txd & nb_rxd are the global configuration of number of desc. If the queue configurat

Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet

2020-09-22 Thread Ferruh Yigit
On 9/9/2020 4:34 AM, Li Zhang wrote: From: lizh Ability to distinguish ICMP identifier fields in packets. Dstinguish ICMP sequence number field too. Already supports ICMP code and type fields in current version. Existing fields in ICMP header contain the required information. ICMP header alread

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix the default RSS key configuration

2020-09-22 Thread Phil Yang
dev On Behalf Of Lijun Ou writes: > >> Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix the default RSS key > >> configuration > > > > Hi Lijun, > > > > Please fix the coding style issues. > > > > "Must be a reply to the first patch (--in-reply-to)." > > > > > >> > >> When a user runs a flow crea

Re: [dpdk-dev] dev Digest, Vol 318, Issue 122

2020-09-22 Thread McDaniel, Timothy
Thanks for the heads up Tim > -Original Message- > From: dev On Behalf Of dev-requ...@dpdk.org > Sent: Tuesday, September 22, 2020 10:45 AM > To: dev@dpdk.org > Subject: dev Digest, Vol 318, Issue 122 > > Send dev mailing list submissions to > dev@dpdk.org > > To subscribe or uns

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

2020-09-22 Thread Thomas Monjalon
22/09/2020 16:28, Stephen Hemminger: > On Wed, 15 Jul 2020 12:01:27 +0200 > Thomas Monjalon wrote: > > > 14/07/2020 07:33, Stephen Hemminger: > > > On Fri, 10 Jul 2020 17:06:11 +0200 > > > David Marchand wrote: > > > > > > > About deprecating existing API/EAL flags in this release, this shoul

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

2020-09-22 Thread Thomas Monjalon
22/09/2020 18:16, Thomas Monjalon: > 22/09/2020 16:28, Stephen Hemminger: > > On Wed, 15 Jul 2020 12:01:27 +0200 > > Thomas Monjalon wrote: > > > > > 14/07/2020 07:33, Stephen Hemminger: > > > > On Fri, 10 Jul 2020 17:06:11 +0200 > > > > David Marchand wrote: > > > > > > > > > About deprecati

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: update Rx RSS HASH offload when setting MQ RSS

2020-09-22 Thread Ferruh Yigit
On 9/8/2020 3:16 AM, Wei Hu (Xavier) wrote: From: Huisong Li Currently, when starting testpmd application without '--disable-rss' and the number of Rx queue configured is greater than 1, ETH_MQ_RX_RSS flag is set in port->dev_conf.rxmode.mq_mode in testpmd application, and DEV_RX_OFFLOAD_RSS_HA

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

2020-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2020 18:16:58 +0200 Thomas Monjalon wrote: > 22/09/2020 16:28, Stephen Hemminger: > > On Wed, 15 Jul 2020 12:01:27 +0200 > > Thomas Monjalon wrote: > > > > > 14/07/2020 07:33, Stephen Hemminger: > > > > On Fri, 10 Jul 2020 17:06:11 +0200 > > > > David Marchand wrote: > > > >

[dpdk-dev] [PATCH v7 07/12] app/testpmd: add testpmd command for sample action

2020-09-22 Thread Jiawei Wang
Add a new testpmd command 'set sample_actions' that supports the multiple sample actions list configuration by using the index: set sample_actions The examples for the sample flow use case and result as below: 1. set sample_actions 0 mark id 0x8 / queue index 2 / end .. pattern eth / end action

[dpdk-dev] [PATCH v7 01/12] ethdev: introduce sample action for rte flow

2020-09-22 Thread Jiawei Wang
When using full offload, all traffic will be handled by the HW, and forwarded to the requested VF or wire and the control application does not see this traffic anymore. So there's a need for an action that enables the control application some forwarded traffic visibility. The solution introduces a

[dpdk-dev] [PATCH v7 09/12] net/mlx5: update validation for mirroring flow

2020-09-22 Thread Jiawei Wang
Mirroring flow using sample action with ratio is 1, and it doesn't support jump action with the same one flow. Sample action must have destination actions like port or queue for mirroring, and don't need split function as sampling flow. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko

[dpdk-dev] [PATCH v7 10/12] net/mlx5: update translate function for mirror

2020-09-22 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list. PMD will check the destination action number in current flow, if found multiple destination actions, then create the new destination array rdma action that group actions for each destination. Currently only sup

[dpdk-dev] [PATCH v7 03/12] common/mlx5: query sampler object capability via DevX

2020-09-22 Thread Jiawei Wang
Update function mlx5_devx_cmd_query_hca_attr() to add the NIC Flow Table attributes query, then get the log_max_flow_sampler_num from flow table properties. Add the related structs definition in mlx5_prm.h. Signed-off-by: Jiawei Wang Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- driver

[dpdk-dev] [PATCH v7 00/12] support the flow-based traffic sampling

2020-09-22 Thread Jiawei Wang
This patch set implement the flow sampling for mlx5 driver. The solution is introduced a new rte_flow action that will sample the incoming traffic and send a duplicated traffic with the specified ratio to the application, while the original packet will continue to the target destination. If the

[dpdk-dev] [PATCH v7 02/12] common/mlx5: glue for sample action

2020-09-22 Thread Jiawei Wang
The new DR sample action is supported since OFED version 5.1.2 or rdma-core version v32. MLX5 PMD adds the rdma-core command in glue to create this action. Sample action is used for creating the sample object to implement the sampling/mirroring function. Signed-off-by: Jiawei Wang Acked-by: Via

[dpdk-dev] [PATCH v7 06/12] net/mlx5: update translate function for sample action

2020-09-22 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list, then create the sample DR action. The metadata register value will be lost in the default path after Sampler in FDB due to CX5 HW limitation. Since source vport also be shared with metadata register c0, MLX5

[dpdk-dev] [PATCH v7 05/12] net/mlx5: split sample flow into two sub flows

2020-09-22 Thread Jiawei Wang
The flow with sample action will be splited into two sub flows: the prefix sub flow with the all actions preceding the sample action and sample action itself, and the suffix sub flow with the actions following the sample action. The original items remain in the prefix sub flow, add the implicit ta

[dpdk-dev] [PATCH v7 11/12] app/testpmd: add port and encap support for sample action

2020-09-22 Thread Jiawei Wang
Use sample action with ratio is 1 for mirroring flow, add supports to set the different port or encap action for mirrored packets. The example of test-pmd command: 1. set sample_actions 1 port_id id 1 / end flow create 0 ... pattern eth / end actions sample ratio 1 index 1 / port_id id

[dpdk-dev] [PATCH v7 12/12] doc: add E-Switch sample flow limitation description

2020-09-22 Thread Jiawei Wang
Add description about the E-Switch sample flow limitation. Due to Metadata register c0 is deleted while doing the loopback, so that only support forward the sampling packet into e-switch manager port, no additional action support in sample flow. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovs

[dpdk-dev] [PATCH v7 04/12] net/mlx5: add the validate sample action

2020-09-22 Thread Jiawei Wang
Add sample action validate function. Sample Flow is supported in NIC-RX and FDB domains. For the NIC-RX the Sample Flow action list must include the destination queue action. Only NIC-RX domain supports the optional actions list. FDB doesn't support any optional actions, the sampled packets is al

[dpdk-dev] [PATCH v7 08/12] common/mlx5: add glue function for mirroring

2020-09-22 Thread Jiawei Wang
The new DR destination array action is supported since the rdma-core version v32. Destination array action is used group DR actions to a single action, And it can be used for mirroring packet and forward to every destination (port or queue) in the array. Signed-off-by: Jiawei Wang Acked-by: Viac

[dpdk-dev] [PATCH] net/ring: fix unchecked return value

2020-09-22 Thread Kevin Laatz
Add a check for the return value of the sscanf call in parse_internal_args(), returning an error if we don't get the expected result. Coverity issue: 362049 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Cc: sta...@dpdk.org Signed-off-by: Kevin Laatz --- drivers/net/ring/rte

Re: [dpdk-dev] [PATCH v3] eventdev: support telemetry with xstats info

2020-09-22 Thread Eads, Gage
> -Original Message- > From: Chen, Mike Ximing > Sent: Friday, September 18, 2020 12:39 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Eads, Gage ; Vedantham, Sundar > ; Power, Ciara ; > Richardson, Bruce > Subject: [PATCH v3] eventdev: support telemetry with xstats info > > The telemetry

Re: [dpdk-dev] [PATCH 3/3] crypto/nitrox: support cipher only crypto operations

2020-09-22 Thread Akhil Goyal
Hi Nagadheeraj, > Subject: [PATCH 3/3] crypto/nitrox: support cipher only crypto operations > > This patch adds cipher only crypto operation support. > > Signed-off-by: Nagadheeraj Rottela > --- Could you please rebase this patch on latest TOT? I see a conflict in the last patch. You can also

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-09-22 Thread Akhil Goyal
Hi Arek, > > Hi Akhil, > > @Akhil: Is there a chance getting this change into 20.11? > > Any more comments or anyone see any potential issues with this approach? > I am ok to take this patch in 20.11 release. Could you please send a new version With complete patch, removing all references of

Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue

2020-09-22 Thread Akhil Goyal
Hi Abhinandan, > This patch updates the xform with right configuration. > For session based ops, sym session pool is created with > valid userdata size. > > Signed-off-by: Abhinandan Gujjar > --- The patch description do not match with the patch. I can see that you are changing the cipher algo f

Re: [dpdk-dev] [PATCH v4 00/11] bbdev PMD ACC100

2020-09-22 Thread Akhil Goyal
Hi Nicolas, > > Hi Akhil, > Just a heads up on this bbdev PMD which is ready and was reviewed for some > time by the community. > There is one warning on patchwork but it can be ignored (one ack email sent > with bad formatting). > Thanks and best regards, > Nic There are changes in Makefiles, wh

Re: [dpdk-dev] [PATCH v4 1/6] drivers: add generic API to find PCI extended cap

2020-09-22 Thread Jerin Jacob
On Tue, Jul 28, 2020 at 4:06 AM Gaëtan Rivet wrote: > > On 27/07/20 15:03 -0700, Manish Chopra wrote: > > By adding generic API, this patch removes individual > > functions/defines implemented by drivers to find extended > > PCI capabilities. > > > > Signed-off-by: Manish Chopra > > Signed-off-by

Re: [dpdk-dev] [PATCH v2] crypto/octeontx2: fix sessionless code

2020-09-22 Thread Akhil Goyal
> A temporary session is created for sessionless crypto operations. > rte_cryptodev_sym_session_create() should be used for creating the > temporary session as it initializes the session structure in the > correct way. Also the session should be set to 0 before freeing it. > > Fixes: 17ac2a72191b

Re: [dpdk-dev] [PATCH] app/test-sad: fix uninitialized variable

2020-09-22 Thread Akhil Goyal
> Coverity issue: 362055 > > Fixes: 908be0651a5a ("app/test-sad: add test application for IPsec SAD") > Cc: sta...@dpdk.org > > Signed-off-by: Vladimir Medvedkin > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

2020-09-22 Thread Wang, Han2
Cristian Thanks for updating the patch set. As I mentioned in my previous email, we are working on adding support for this as a new P4C CPU target. We plan to open source the compiler backend in the near future. Cheers, Han On 9/10/20, 8:27 AM, "dev on behalf of Cristian Dumitrescu" wrote:

Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

2020-09-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Wang, Han2 > Sent: Tuesday, September 22, 2020 9:06 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 > language > > Cristian > > Thanks for updating the patch set. As I mentioned in my pr

[dpdk-dev] [PATCH 1/2] net/virtio: set UNKNOWN as default speed

2020-09-22 Thread Ivan Dyukov
rte_ethdev states new rule for NICs: they should return UNKNOWN speed if speed is unknown and interface is up, in case of down interface, NONE speed should be returned. Signed-off-by: Ivan Dyukov --- doc/guides/nics/virtio.rst | 4 ++-- drivers/net/virtio/virtio_ethdev.c | 9 - 2

[dpdk-dev] Unknown speed

2020-09-22 Thread Ivan Dyukov
It's virtio support for 'ETH_SPEED_NUM_UNKNOWN' which was already merged to dpdk-next-net/main

[dpdk-dev] [PATCH 2/2] net/virtio: sync a virtio speed capa with ethdev

2020-09-22 Thread Ivan Dyukov
ethdev library was updated with new speed 200G Add 200G speed capa to virtio device Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 0ef88feda..4

Re: [dpdk-dev] [PATCH v4] windows/netuio: add Windows NetUIO kernel driver

2020-09-22 Thread Dmitry Kozlyuk
On Fri, 18 Sep 2020 19:52:33 -0700, Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > The Windows netuio kernel driver provides the DPDK userspace application > with direct access to hardware, by mapping the HW registers in userspace > and allowing read/write operations from/to the devic

[dpdk-dev] [PATCH 1/2] net/bnxt: fix drop en in rxq get information

2020-09-22 Thread Lance Richardson
Return correct value for rx_drop_en. Add per-queue field to track rx_drop_en configuration. Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_eth

[dpdk-dev] [PATCH 2/2] net/bnxt: fix rxq/txq offload information get op

2020-09-22 Thread Lance Richardson
Return current offloads in rxq_info_get()/txq_info_get(). Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 in

Re: [dpdk-dev] [PATCH v4] windows/netuio: add Windows NetUIO kernel driver

2020-09-22 Thread Ranjit Menon
On 9/18/2020 7:52 PM, Narcisa Ana Maria Vasile wrote: From: Narcisa Vasile The Windows netuio kernel driver provides the DPDK userspace application with direct access to hardware, by mapping the HW registers in userspace and allowing read/write operations from/to the device configuration spac

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix rxq/txq offload information get op

2020-09-22 Thread Lance Richardson
On Tue, Sep 22, 2020 at 1:30 PM Lance Richardson wrote: > Apologies for not sending a cover letter. I can resend if needed. Lance

Re: [dpdk-dev] [PATCH v4] eal: add cache-line demote support

2020-09-22 Thread Maslekar, Omkar
Hi Bruce, My comments are inline >-Original Message- >From: Bruce Richardson >Sent: Tuesday, September 22, 2020 1:28 AM >To: Maslekar, Omkar >Cc: dev@dpdk.org; Loftus, Ciara >Subject: Re: [PATCH v4] eal: add cache-line demote support > >On Mon, Sep 21, 2020 at 06:59:27PM -0700,

[dpdk-dev] Recent failure in autotest

2020-09-22 Thread Stephen Hemminger
The blacklist/whitelist documentation patch which is totally unrelated to this failed in the unit test. Looks like recent cmdline changes caused a problem? 10: [/home/jenkins-local/jenkins-agent/workspace/Ubuntu18.04-Unit-Test-DPDK/dpdk/build/app/test/dpdk-test(+0x3973a) [0x55acef45573a]] 9: [/

Re: [dpdk-dev] [PATCH v11 2/5] net/i40e: use WC store to update queue tail registers

2020-09-22 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Wednesday, August 26, 2020 5:56 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; > Richardson, Bruce ; Ananyev, Konstantin > ; jerinjac...@gmail.com; > david.march...@redhat.com; Trahe, Fiona ; Zhao1, > Wei ; ruif

Re: [dpdk-dev] [PATCH v11 4/5] net/ixgbe: use WC store to update queue tail registers

2020-09-22 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Wednesday, August 26, 2020 5:56 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; > Richardson, Bruce ; Ananyev, Konstantin > ; jerinjac...@gmail.com; > david.march...@redhat.com; Trahe, Fiona ; Zhao1, > Wei ; ruif

Re: [dpdk-dev] [PATCH v11 5/5] net/ice: use WC store to update queue tail registers

2020-09-22 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Wednesday, August 26, 2020 5:56 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; > Richardson, Bruce ; Ananyev, Konstantin > ; jerinjac...@gmail.com; > david.march...@redhat.com; Trahe, Fiona ; Zhao1, > Wei ; ruif

[dpdk-dev] [PATCH v2 2/8] app/test: synchronize statistics between lcores

2020-09-22 Thread Lukasz Wojciechowski
Statistics of handled packets are cleared and read on main lcore, while they are increased in workers handlers on different lcores. Without synchronization occasionally showed invalid values. This patch uses atomic acquire/release mechanisms to synchronize. Fixes: c3eabff124e6 ("distributor: add

[dpdk-dev] [PATCH v2 1/8] app/test: fix deadlock in distributor test

2020-09-22 Thread Lukasz Wojciechowski
The sanity test with worker shutdown delegates all bufs to be processed by a single lcore worker, then it freezes one of the lcore workers and continues to send more bufs. Problem occurred if freezed lcore is the same as the one that is processing the mbufs. The lcore processing mbufs might be dif

[dpdk-dev] [PATCH v2 0/8] fix distributor synchronization issues

2020-09-22 Thread Lukasz Wojciechowski
During review and verification of the patch created by Sarosh Arif: "test_distributor: prevent memory leakages from the pool" I found out that running distributor unit tests multiple times in a row causes fails. So I investigated all the issues I found. There are few synchronization issues that mi

[dpdk-dev] [PATCH v2 3/8] app/test: fix freeing mbufs in distributor tests

2020-09-22 Thread Lukasz Wojciechowski
Sanity tests with mbuf alloc and shutdown tests assume that mbufs passed to worker cores are freed in handlers. Such packets should not be returned to the distributor's main core. The only packets that should be returned are the packets send after completion of the tests in quit_workers function.

[dpdk-dev] [PATCH v2 4/8] app/test: collect return mbufs in distributor test

2020-09-22 Thread Lukasz Wojciechowski
During quit_workers function distributor's main core processes some packets to wake up pending worker cores so they can quit. As quit_workers acts also as a cleanup procedure for next test case it should also collect these packages returned by workers' handlers, so the cyclic buffer with returned p

  1   2   3   4   >