Great. Thanks. It will save me a fix patch in my next series.
> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Tuesday, September 22, 2020 2:50 PM
> To: Ophir Munk <ophi...@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasl...@nvidia.com>;
> ferruh.yi...@intel.com; Matan Azrad <ma...@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH v2 09/13] net/mlx5: add ICMP protocol
> number definition
>
> > From: Ophir Munk <ophi...@mellanox.com>
> >
> > Some Windows distributions do not include ICMP protocol definitions
> > IPPROTO_ICMP and IPPROTO_ICMPV6. This commit defines them if
> needed.
>
> It is already defined (recently) in
> lib/librte_eal/windows/include/netinet/in.h
>
> I will drop this patch while pulling next-net.
>
