Re: [dpdk-dev] [PATCH v4 2/5] app/testpmd: add Rx buffer size display in queue info query

2020-09-20 Thread Chengchang Tang
On 2020/9/18 16:54, Ferruh Yigit wrote: > On 9/5/2020 10:07 AM, Chengchang Tang wrote: >> Add Rx buffer size to queue info querry cmd so that the user can get the >> buffer length used by HW queue for receiving packets. >> >> Signed-off-by: Chengchang Tang >> Reviewed-by: Wei Hu (Xavier) >> --

Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path

2020-09-20 Thread Phil Yang
Juraj Linkeš writes: > > Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default > DESTDIR > > path > > > > If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative path. > > This will break ninja in the ABI check test. > > > > The commit message is not very clear. The probl

[dpdk-dev] [PATCH v6 2/7] test/ring: fix wrong number of enq/deq elements

2020-09-20 Thread Feifei Wang
The ring capacity is (RING_SIZE - 1), thus only (RING_SIZE - 1) number of elements can be enqueued into the ring. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli ---

[dpdk-dev] [PATCH v6 3/7] test/ring: fix wrong size used in memcmp

2020-09-20 Thread Feifei Wang
When using memcmp function to check data, the third param should be the size of all elements, rather than the number of the elements. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Review

[dpdk-dev] [PATCH v6 1/7] test/ring: fix wrong parameter passed to the enqueue APIs

2020-09-20 Thread Feifei Wang
When enqueue one element to ring in the performance test, a pointer should be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of void *pointers. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v6 4/7] test/ring: add check to validate dequeued objects

2020-09-20 Thread Feifei Wang
Add check in test_ring_basic_ex and test_ring_with_exact_size for single element enqueue and dequeue operations to validate the dequeued objects. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli --- app

[dpdk-dev] [PATCH v6 0/7]

2020-09-20 Thread Feifei Wang
Several bugs in ring unit tests were identified and fixed. Added data validation on objects after enqueue/dequeue operations for data integration check. Unit tests were enhanced by checking return value of enqueue/dequeue operations and validating data integrity of objects. v2: 1. add check to v

[dpdk-dev] [PATCH v6 7/7] test/ring: improve the application of macro

2020-09-20 Thread Feifei Wang
Add more parameters into the macro TEST_RING_VERIFY and expand the scope of application for it. Then replace all ring APIs check with TEST_RING_VERIFY to facilitate debugging. Furthermore, correct a spelling mistakes of the macro TEST_RING_FULL_EMTPY_ITER. Suggested-by: Honnappa Nagarahalli Sign

[dpdk-dev] [PATCH v6 6/7] test/ring: add new function to validate dequeue data

2020-09-20 Thread Feifei Wang
Do code clean up by moving repeated code inside 'test_ring_mem_cmp' function to validate data and print information of enqueue/dequeue elements if validation fails. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Dharmik Thakkar Reviewed-by: Honnappa Na

[dpdk-dev] [PATCH v6 5/7] test/ring: validate the return value of enq/deq elements

2020-09-20 Thread Feifei Wang
Validate the return value of single element enqueue/dequeue operation in the test. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- app/test/test_ring.c | 26 ++ 1 file changed, 22 insertions(+),

[dpdk-dev] 回复: [PATCH v5 7/7] test/ring: improve the application of macro

2020-09-20 Thread Feifei Wang
Hi, Konstantin > -邮件原件- > 发件人: Ananyev, Konstantin > 发送时间: 2020年9月18日 0:26 > 收件人: Feifei Wang ; Honnappa Nagarahalli > > 抄送: dev@dpdk.org; nd > 主题: RE: [PATCH v5 7/7] test/ring: improve the application of macro > > > > > Add more parameters into the macro TEST_RING_VERIFY and expand

Re: [dpdk-dev] 18.11.10 (LTS) patches review and test

2020-09-20 Thread Ali Alnubani
Hi, > -Original Message- > From: Kevin Traynor > Sent: Monday, September 7, 2020 1:12 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNama

Re: [dpdk-dev] [PATCH v6 0/7]

2020-09-20 Thread Ananyev, Konstantin
> Several bugs in ring unit tests were identified and fixed. > > Added data validation on objects after enqueue/dequeue operations for > data integration check. > > Unit tests were enhanced by checking return value of enqueue/dequeue > operations and validating data integrity of objects. > > v

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-20 Thread Xia, Chenbo
Hi, David & Ajit Yes, I will submit a patch to change all eth port id to uint16_t this week as I promised. Is this ok for you? Thanks, Chenbo > -Original Message- > From: Ajit Khaparde > Sent: Saturday, September 19, 2020 12:16 AM > To: David Marchand > Cc: Somnath Kotur ; Thierry Herb

[dpdk-dev] [PATCH v1] net/i40e: fix virtual channel confiliction issue

2020-09-20 Thread Yuying Zhang
i40evf_execute_vf_cmd() uses _atomic_set_cmd() to execute virtual channel commands safely in multi-process mode. However, it returns -1 when one process is pending. Add a spinlock to wait for the virtual channel will handle this issue in concurrent scenarios. Fixes: 4861cde46116 ("i40e: new poll m

Re: [dpdk-dev] [PATCH v4 05/11] baseband/acc100: add LDPC processing functions

2020-09-20 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:54:01 -0700, Nicolas Chautru wrote: > Adding LDPC decode and encode processing operations > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 1625 > +- > drivers/baseband/acc100/rte_acc100_pmd.h |3 + > 2

Re: [dpdk-dev] [PATCH v4 06/11] baseband/acc100: add HARQ loopback support

2020-09-20 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:54:02 -0700, Nicolas Chautru wrote: > Additional support for HARQ memory loopback > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 158 > +++ > 1 file changed, 158 insertions(+) Acked-by: Liu Tianjiao

Re: [dpdk-dev] [PATCH v4 07/11] baseband/acc100: add support for 4G processing

2020-09-20 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:54:03 -0700, Nicolas Chautru wrote: > Adding capability for 4G encode and decoder processing > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 1010 > -- > 1 file changed, 943 insertions(+), 67 deletions(-)

Re: [dpdk-dev] [PATCH v4 08/11] baseband/acc100: add interrupt support to PMD

2020-09-20 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:54:04 -0700, Nicolas Chautru wrote: > Adding capability and functions to support MSI interrupts, call backs and > inforing. > Signed-off-by: Nicolas Chautru > mailto:nicolas.chau...@intel.com>> > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 288 > +

Re: [dpdk-dev] [PATCH v4 09/11] baseband/acc100: add debug function to validate input

2020-09-20 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:54:05 -0700, Nicolas Chautru wrote: > Debug functions to validate the input API from user Only enabled in DEBUG > mode at build time > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 424 > +++ > 1 file chang

Re: [dpdk-dev] [PATCH v4 10/11] baseband/acc100: add configure function

2020-09-20 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:54:06 -0700, Nicolas Chautru wrote: > Add configure function to configure the PF from within the bbdev-test itself > without external application configuration the device. > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 72

Re: [dpdk-dev] [PATCH v4 11/11] doc: update bbdev feature table

2020-09-20 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:54:07 -0700, Nicolas Chautru wrote: > Correcting overview matrix to use acc100 name > > Signed-off-by: Nicolas Chautru > --- > doc/guides/bbdevs/features/acc100.ini | 14 ++ > doc/guides/bbdevs/features/mbc.ini| 14 -- > 2 files changed, 14 ins

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-20 Thread Jiang, JunyuX
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, September 18, 2020 9:42 PM > To: Igor Ryzhov ; Jiang, JunyuX > > Cc: dev@dpdk.org; Guo, Jia ; Xing, Beilei > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte > counters >

Re: [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port

2020-09-20 Thread Chengchang Tang
Hi, All These Patches improved procinfo was stuck in patchwork: https://patchwork.dpdk.org/patch/74960/ These patches look good for me. Will these be applied? I'm not sure what to do next. If these will be applied, I need modified the code. On 2020/9/19 6:11, Stephen Hemminger wrote: > On Mon, 7

[dpdk-dev] [PATCH V8 1/3] ethdev: introduce FEC API

2020-09-20 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang --- v7->v8: put AUTO just after NOFEC

[dpdk-dev] [PATCH V8 0/3] add FEC support

2020-09-20 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 219 +++ app/test-pmd/config.c| 54 app/test-pmd/te

[dpdk-dev] [PATCH V8 2/3] net/hns3: support FEC

2020-09-20 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

[dpdk-dev] [PATCH V8 3/3] app/testpmd: add FEC command

2020-09-20 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port 0

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-20 Thread Liu, Changpeng
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, September 18, 2020 5:54 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, > Tomasz > Subject: Re: [PATCH] vhost: return ready when at least 1 vring is configured > > Hi Changpe

[dpdk-dev] [PATCH V9 2/3] net/hns3: support FEC

2020-09-20 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

[dpdk-dev] [PATCH V9 1/3] ethdev: introduce FEC API

2020-09-20 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang Reviewed-by: Ajit Khaparde Acked-by:

[dpdk-dev] [PATCH V9 3/3] app/testpmd: add FEC command

2020-09-20 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port 0

[dpdk-dev] [PATCH V9 0/3] add FEC support

2020-09-20 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 219 +++ app/test-pmd/config.c| 54 app/test-pmd/te

Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path

2020-09-20 Thread Juraj Linkeš
> -Original Message- > From: Phil Yang > Sent: Sunday, September 20, 2020 11:32 AM > To: Juraj Linkeš ; david.march...@redhat.com; > dev@dpdk.org > Cc: Honnappa Nagarahalli ; Ruifeng Wang > ; nd ; nd > Subject: RE: [dpdk-dev] [PATCH] devtools: fix ninja break under default > DESTDIR >

Re: [dpdk-dev] [PATCH v6 1/3] gro: add UDP/IPv4 GRO support

2020-09-20 Thread Hu, Jiayu
> -Original Message- > From: yang_y...@163.com > Sent: Thursday, September 17, 2020 11:50 AM > To: dev@dpdk.org > Cc: Hu, Jiayu ; tho...@monjalon.net; > yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH v6 1/3] gro: add UDP/IPv4 GRO support > > From: Yi Yang > > UDP/IPv4 GRO can

Re: [dpdk-dev] [PATCH v1 4/5] vhost: add packed ring vectorized dequeue

2020-09-20 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Friday, September 18, 2020 9:45 PM > To: Liu, Yong ; Xia, Chenbo ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 4/5] vhost: add packed ring vectorized dequeue > > > > On 8/19/20 5:24 AM, Marvin Liu wrote: > > Optimiz

[dpdk-dev] [PATCH v2 2/5] vhost: reuse packed ring functions

2020-09-20 Thread Marvin Liu
Move parse_ethernet, offload, extbuf functions to header file. These functions will be reused by vhost vectorized path. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index b556eb3bf6..5a5c945551 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_v

[dpdk-dev] [PATCH v2 1/5] vhost: add vectorized data path

2020-09-20 Thread Marvin Liu
Packed ring operations are split into batch and single functions for performance perspective. Ring operations in batch function can be accelerated by SIMD instructions like AVX512. So introduce vectorized parameter in vhost. Vectorized data path can be selected if platform and ring format matched

[dpdk-dev] [PATCH v2 0/5] vhost add vectorized data path

2020-09-20 Thread Marvin Liu
Packed ring format is imported since virtio spec 1.1. All descriptors are compacted into one single ring when packed ring format is on. It is straight forward that ring operations can be accelerated by utilizing SIMD instructions. This patch set will introduce vectorized data path in vhost librar

[dpdk-dev] [PATCH v2 5/5] vhost: add packed ring vectorized enqueue

2020-09-20 Thread Marvin Liu
Optimize vhost packed ring enqueue path with SIMD instructions. Four descriptors status and length are batched handled with AVX512 instructions. Address translation operations are also accelerated by AVX512 instructions. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librt

[dpdk-dev] [PATCH v2 3/5] vhost: prepare memory regions addresses

2020-09-20 Thread Marvin Liu
Prepare memory regions guest physical addresses for vectorized data path. These information will be utilized by SIMD instructions to find matched region index. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 5a5c945551..4a81f18f01 100644 --- a/lib

[dpdk-dev] [PATCH v2 4/5] vhost: add packed ring vectorized dequeue

2020-09-20 Thread Marvin Liu
Optimize vhost packed ring dequeue path with SIMD instructions. Four descriptors status check and writeback are batched handled with AVX512 instructions. Address translation operations are also accelerated by AVX512 instructions. If platform or compiler not support vectorization, will fallback to