Hi, All
These Patches improved procinfo was stuck in patchwork:
https://patchwork.dpdk.org/patch/74960/
These patches look good for me. Will these be applied?
I'm not sure what to do next. If these will be applied, I need modified
the code.
On 2020/9/19 6:11, Stephen Hemminger wrote:
> On Mon, 7 Sep 2020 17:14:48 +0800
> Chengchang Tang <tangchengch...@huawei.com> wrote:
>
>> On 2020/9/6 0:59, Stephen Hemminger wrote:
>>> On Sat, 5 Sep 2020 17:07:32 +0800
>>> Chengchang Tang <tangchengch...@huawei.com> wrote:
>>>
>>>> printf("\t -- queue %d rx scatter %d"
>>>> " descriptors %d"
>>>> + " rx buffer size %d"
>>>> " offloads 0x%"PRIx64
>>>> " mempool socket %d\n",
>>>> j,
>>>> queue_info.scattered_rx,
>>>> queue_info.nb_desc,
>>>> + queue_info.rx_buf_size,
>>>> queue_info.conf.offloads,
>>>> queue_info.mp->socket_id);
>>>> }
>>>
>>> These should be using %u and need space after " for PRIx64
>>> Why not:
>>> printf("\t -- queue %u rx scatter %u"
>>> " descriptors %u"
>>> " rx buffer size %u"
>>> " offloads %#" PRIx64
>>> " mempool socket %d\n",
>>>
>>
>> OK, I will fix these in next version.
>>
>> Thanks
>
> NAK, these is superseded by.
>
> Please look at the new improved procinfo still stuck in patchwork
> https://patchwork.dpdk.org/patch/74960/
>
> Let's put the buffer size there.
>
> .
>
