Re: [dpdk-dev] [PATCH v2 1/1] net: fix TSO packets checksum incorrect

On 7/29/20 10:49 AM, Olivier Matz wrote: > On Tue, Jul 28, 2020 at 05:09:50PM +, Yuying Zhang wrote: >> The ol_flags check lacks of flag for IPv6 which causes checksum >> flag configuration error while IPv6/TCP TSO packet is sent. >> This patch fixes the issue by adding PKT_TX_TCP_SEG flag. >

Re: [dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests

> Hi Pablo/David, > > > > Hi David, > > > > > Hi Pablo, > > > > > > > -Original Message- > > > > From: De Lara Guarch, Pablo > > > > Sent: Friday, July 17, 2020 8:04 PM > > > > > @@ -48,6 +48,10 @@ cperf_set_ops_security(struct rte_crypto_op > **ops, > > > > > } else

Re: [dpdk-dev] [PATCH v2] app/crypto-perf: support security protocol in PMDCC mode

> > > > This patch adds support for DOCSIS and PDCP security protocols to the > > pmd-cyclecount mode of the crypto performance tool. Adding this support > > involves freeing the correct session type (i.e. security or cryptodev > > session) when the test ends, depending on the op_type specified. >

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

Hi Arek, Small typo below. > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 29, 2020 3:22 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > ano...@marvell.com; > shal...@marvell.com; Doherty, Declan ; Zhang, Roy > Fan > ; Ananyev, Konstantin > ;

Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param

> > > > When enqueue one element to the ring, the param "obj" should be the > > object to be added into the ring. The object is of type void*. > > I understand void * as a pointer to an object you don't know the type of. > I would keep the current description. > > Honnappa, Konstantin, Olivier ?

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

On 7/29/2020 1:42 AM, Ajit Khaparde wrote: > From: Randy Schacher > > Remove the memory management scheme for Extended Exact Match > using system memory. Using host memory scheme instead which > was the default anyway. > > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") > > Signed-o

Re: [dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx

On Fri, Jul 24, 2020 at 5:10 PM Ferruh Yigit wrote: > > From: jiancheng pei > > Store port_id in pmd_internals when eth kni device is created. > Then set packet port of rte_mbuf in function eth_kni_rx. LGTM. Is this fix worth a backport? A net driver is expected to set the port in all mbufs (m-

Re: [dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx

On 7/29/2020 6:02 PM, David Marchand wrote: > On Fri, Jul 24, 2020 at 5:10 PM Ferruh Yigit wrote: >> >> From: jiancheng pei >> >> Store port_id in pmd_internals when eth kni device is created. >> Then set packet port of rte_mbuf in function eth_kni_rx. > > LGTM. > > Is this fix worth a backport

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

On Tue, Jul 28, 2020 at 5:43 PM Ajit Khaparde wrote: > From: Randy Schacher > > Remove the memory management scheme for Extended Exact Match > using system memory. Using host memory scheme instead which > was the default anyway. > > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") > >

[dpdk-dev] [PATCH 0/4] bnxt patches

fixes and cleanups in bnxt TRUFlow Kishore Padmanabha (2): net/bnxt: configure loopback parif for full offload egress flows net/bnxt: enable lookup default action record parif entry Somnath Kotur (1): net/bnxt: cleanups and checks for ulp context allocation Venkat Duvvuru (1): net/bnxt:

[dpdk-dev] [PATCH 1/4] net/bnxt: configure loopback parif for full offload egress flows

From: Kishore Padmanabha The full offload egress flows for the VF rep interface should use loopback parif to offload missed flows. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle --- drivers/net/bnxt/tf_ulp/ulp_rte

[dpdk-dev] [PATCH 0/4] bnxt patches

fixes and cleanups in bnxt TRUFlow Kishore Padmanabha (2): net/bnxt: configure loopback parif for full offload egress flows net/bnxt: enable lookup default action record parif entry Somnath Kotur (1): net/bnxt: cleanups and checks for ulp context allocation Venkat Duvvuru (1): net/bnxt:

[dpdk-dev] [PATCH 2/4] net/bnxt: enable lookup default action record parif entry

From: Kishore Padmanabha The lookup default action record parif table is updated to catch the miss path for the entries in the exact match table. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Michael

[dpdk-dev] [PATCH 3/4] net/bnxt: cleanups and checks for ulp context allocation

Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor init is aborted if parent ulp context is not initialized. Also check for the same before creation of port default rules. Additional checks in VF rep dev ops for proper parent dev initialization Fixes: 322bd6e70272 ("net/bnxt: a

[dpdk-dev] [PATCH 1/4] net/bnxt: configure loopback parif for full offload egress flows

From: Kishore Padmanabha The full offload egress flows for the VF rep interface should use loopback parif to offload missed flows. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle --- drivers/net/bnxt/tf_ulp/ulp_rte

[dpdk-dev] [PATCH v4] app/test-regex: add RegEx test application

From: Yuval Avnery Following the new RegEx class. There is a need to create a dedicated test application in order to validate this class and PMD. Unlike net device this application loads data from a file. This commit introduces the new RegEx test app. The basic app flow: 1. Configure the RegEx

[dpdk-dev] [PATCH 4/4] net/bnxt: fix vfrep port add when it's endpoint interface is down

From: Venkat Duvvuru While adding vfrep port to OVS bridge, vnic & svif information of vfrep's endpoint(VF) would be needed to program default flow rules. However, if the endpoint interface is down when vfrep port is added, firmware will return invalid vnic & svif information. This patch fixes t

[dpdk-dev] Queue Management Support in DPDK

Hello everyone, We have been using DPDK's QoS framework over the last year and found that rte_sched and the provided qos_sched app work great for QoS. However, when we ventured into trying to add CoDel (to replace RED) as a dropper to the framework, we faced several challenges due to how tightly

Re: [dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests

>-Original Message- >From: Eads, Gage >Sent: Friday, July 10, 2020 3:43 PM >To: McDaniel, Timothy ; jer...@marvell.com >Cc: mattias.ronnb...@ericsson.com; dev@dpdk.org; Van Haaren, Harry > >Subject: RE: [PATCH 14/27] event/dlb: add PMD self-tests > >Hi Tim, > >> +#include >> +#include >>

Re: [dpdk-dev] long initialization time for EAL init

Hello, I tried by disabling mlockall and not do see long time for EAL init and is done quickly. Thanks for help. ovs-vswitchd unix:/var/run/openvswitch/db.sock -vconsole:emer -vsyslog:err -vfile:info --no-chdir --log-file=/var/log/openvswitch/ovs-vswitchd.log --pidfile=/var/run/openvswitch/ovs

Re: [dpdk-dev] Queue Management Support in DPDK

On Thu, 30 Jul 2020 00:07:29 +0530 Archit Pandey wrote: > Hello everyone, > > We have been using DPDK's QoS framework over the last year and found > that rte_sched and the provided qos_sched app work great for QoS. > > However, when we ventured into trying to add CoDel (to replace RED) as > a d

Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param

> Subject: RE: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the > param > > > > > > > When enqueue one element to the ring, the param "obj" should be the > > > object to be added into the ring. The object is of type void*. > > > > I understand void * as a pointer to an object you do

Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

> > > > On Wed, Jul 29, 2020 at 4:16 PM Feifei Wang > > wrote: > > > > Are we missing a check in the UT so that dequeued object is what > > > > had been enqueued? Yes, missing for single element enqueue/dequeue > > > > > > > > > > > Dequeue is not necessary to change because the param defined i

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

On 7/29/2020 10:24 PM, Ajit Khaparde wrote: > > > On Wed, Jul 29, 2020 at 9:25 AM Ferruh Yigit > wrote: > > On 7/29/2020 1:42 AM, Ajit Khaparde wrote: > > From: Randy Schacher > > > > > Remove the memory ma

Re: [dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx

On 7/29/2020 6:06 PM, Ferruh Yigit wrote: > On 7/29/2020 6:02 PM, David Marchand wrote: >> On Fri, Jul 24, 2020 at 5:10 PM Ferruh Yigit wrote: >>> >>> From: jiancheng pei >>> >>> Store port_id in pmd_internals when eth kni device is created. >>> Then set packet port of rte_mbuf in function eth_kn

[dpdk-dev] [PATCH v2 20.08 4/6] doc: announce deprecation blacklist/whitelist

Announce upcoming changes for 20.11. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/deprecation.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 7c60779f3e68..abfec0aeaa4b

[dpdk-dev] [PATCH v2 20.08 5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add

The comment used the term whitelist and was awkardly written. Replace it with simpler direct description of adding a new address. No code or API changes for this. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_ethdev/rte_ethdev.h | 3 +-- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH v2 20.08 0/6] inclusive language fixes and deprecation notices

This set annonuces the upcoming changes for 20.11 around master/slave and blacklist/whitelist. It also fixes several places in the current code where the wrong and confusing terminolgy was used. v2 - fix wording and checkpatch about whitespace Stephen Hemminger (6): doc: announce deprecation of

[dpdk-dev] [PATCH v2 20.08 3/6] doc: fix incorrect reference to master process

Correct terminolgy here is primary process. This is a bug in original doc. Fixes: fc1f2750a3ec ("doc: programmers guide") Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[dpdk-dev] [PATCH v2 20.08 2/6] kni: fix reference to master/slave process

In DPDK, the correct terms for process are primary/secondary. This is bugfix, not a change in terms for new release. Fixes: f2e7592c474c ("kni: fix multi-process support") Signed-off-by: Stephen Hemminger --- lib/librte_kni/rte_kni.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH v2 20.08 1/6] doc: announce deprecation of master lcore

Announce upcoming changes related to master/slave in reference to lcore. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/deprecation.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst i

[dpdk-dev] [PATCH v2 20.08 6/6] check_maintainers: change variable names

Change variable names in python script: replace whitelist with include_files and blacklist with exclude_files. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- devtools/check-maintainers.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/check-ma

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

On Wed, Jul 29, 2020 at 9:25 AM Ferruh Yigit wrote: > On 7/29/2020 1:42 AM, Ajit Khaparde wrote: > > From: Randy Schacher > > > > Remove the memory management scheme for Extended Exact Match > > using system memory. Using host memory scheme instead which > > was the default anyway. > > > > Fixes

Re: [dpdk-dev] [PATCH 0/4] bnxt patches

On Wed, Jul 29, 2020 at 7:09 AM Somnath Kotur wrote: > fixes and cleanups in bnxt TRUFlow > > Kishore Padmanabha (2): > net/bnxt: configure loopback parif for full offload egress flows > net/bnxt: enable lookup default action record parif entry > > Somnath Kotur (1): > net/bnxt: cleanups an

[dpdk-dev] [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets

The rte_net_intel_cksum_flags_prepare() function prepares the pseudoheader checksum in packet data when doing checksum or TSO offload. It does nothing when no checksum offload flag is set in mbuf. But in case of a IPv6/TCP TSO packet, it is not mandatory to have a checksum flag. We also need to ch

Re: [dpdk-dev] [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets

> -Original Message- > From: Zhang, Yuying > Sent: 2020年7月30日 10:01 > To: dev@dpdk.org; olivier.m...@6wind.com; Zhang, Qi Z > ; Yang, Qiming > Cc: Zhang, Yuying ; David Marchand > > Subject: [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets > > The rte_net_intel_cksum_flag

Re: [dpdk-dev] DPDK PDUMP Issue

Hi Dikshant, Summarizing the contents from earlier mails below 1. Issue-1 shared with PDUMP not working with testpmd - solution shared and suggested what needs to be added to fix the same. 2. Issue-2 shared for custom Makefile for application not working - pointed out possible cause and missin

Re: [dpdk-dev] [PATCH v4 1/3] eal: fix memory leak when removing event_cb

hi, yunjian The patch seems no problem, but when you update your patch, please add other guys who had comment on your patch and maintainer to see if they have other opinion, and --in-reply-to is also helpful for patch review, thanks. On 7/29/2020 7:47 PM, wangyunjian wrote: Ping for review.

[dpdk-dev] [RFC] lib: introduce traffic mirroring API

Network Test Access Point (TAP) is the network monitoring service commonly adotpted in SDN-based network infrastructures. When VMs are inter-connected over virtual switches, TAP requires vSwitch to mirror out network traffics from specific workload VM ports to the TAP device/VM ports. Classical mir

[dpdk-dev] [Bug 486] i40e driver has very bad performance when VXLAN TSO is enabled

https://bugs.dpdk.org/show_bug.cgi?id=486 Xiaoyun Li (xiaoyun...@intel.com) changed: What|Removed |Added CC||xiaoyun...@intel.com

Re: [dpdk-dev] [PATCH v4 3/3] net/vhost: fix interrupt mode

Tested-by: Xiao Qimai Regards, Xiao Qimai > -Original Message- > From: dev On Behalf Of Xia, Chenbo > Sent: Wednesday, July 29, 2020 10:19 PM > To: Maxime Coquelin ; dev@dpdk.org; > ma...@mellanox.com; Liu, Yong ; Wang, Yinan > > Cc: tho...@monjalon.net; Yigit, Ferruh ; > david.march..

Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API

30/07/2020 05:23, Patrick Fu: > Network Test Access Point (TAP) is the network monitoring service > commonly adotpted in SDN-based network infrastructures. When VMs are > inter-connected over virtual switches, TAP requires vSwitch to mirror > out network traffics from specific workload VM ports to

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue

Hi, all, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 29, 2020 10:53 PM > To: David Marchand > Cc: Xu, Ting ; dev ; dpdk stable > ; Kevin Traynor ; Luca Boccassi > > Subject: RE: [dpdk-stable] [dpdk-dev] [PATCH v4] lib/table: fix cache > alignment > issue >

<    1   2