Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove dead code

2020-07-22 Thread Jerin Jacob
On Wed, Jul 22, 2020 at 3:14 AM Rasesh Mody wrote: > > >From: wangyunjian > >Sent: Friday, July 17, 2020 4:16 AM > > > >From: Yunjian Wang > > > >This patch fixes (Logically dead code) coverity issue. > > > >Coverity issue: 261777, 261778 > >Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation s

Re: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq

2020-07-22 Thread Thomas Monjalon
22/07/2020 03:13, Pavan Nikhilesh Bhagavatula: > > >Subject: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq > > ./devtools/check-git-log.sh > Wrong headline uppercase: > app/test-eventdev: Fix pipeline atq > > Having a more informative commit title and message would be hel

[dpdk-dev] [PATCH v2 1/3] net/mlx5: separate aging counter pool range

2020-07-22 Thread Suanming Mou
Currently, when allocate the counter or counter based age from group 0, counter and age may share the same counter dcs ID range. Both age and pure counter need to sync up with each other's container to check if the ID range exists and update the min_dcs. It comes two disadvantages: 1. If the ID ra

Re: [dpdk-dev] [PATCH v2 2/2] crypto/aesni-mb: improve security instance setup

2020-07-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Monday, July 20, 2020 1:16 PM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, > Mairtin ; Coyle, David > Subject: [PATCH v2 2/2] crypto/aesni-mb: im

[dpdk-dev] [PATCH v2 2/3] common/mlx5: add counter batch query ID alignment define

2020-07-22 Thread Suanming Mou
The counter batch query requires ID to be aligned with 4. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index cb5f968..8565d25 100644 ---

[dpdk-dev] [PATCH v2 3/3] net/mlx5: fix invalid counter query

2020-07-22 Thread Suanming Mou
Currently, the counter query requires the counter ID should start with 4 aligned. In none-batch mode, the counter pool might have the chance to get the counter ID not 4 aligned. In this case, the counter should be skipped, or the query will be failed. Skip the counter with ID not 4 aligned as the

[dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx

2020-07-22 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 7 +-- doc/guides/rel_notes/release_20_08.rst | 8 +--- drivers/common/qat/qat_device.c| 6

[dpdk-dev] [PATCH v4 0/1] common/qat: support GEN2 QAT device 200xx

2020-07-22 Thread Adam Dybkowski
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). v2: * rename the device v3: * improve release notes v4: * simplify release notes Adam Dybkowski (1): common/qat: support GEN2 QAT device 200xx doc/guides/cryptodevs/qat.rst

Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue

2020-07-22 Thread Dumitrescu, Cristian
> +#ifdef RTE_ARCH_64 > struct rte_bucket_4_32 { > /* Cache line 0 */ > uint64_t signature[4 + 1]; > @@ -46,6 +47,22 @@ struct rte_bucket_4_32 { > /* Cache line 3 */ > uint8_t data[0]; > }; > +#else > +struct rte_bucket_4_32 { > + /* Cache line 0 */ > + uint64_t

Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue

2020-07-22 Thread Xu, Ting
Hi, Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 22, 2020 4:27 PM > To: Xu, Ting ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v4] lib/table: fix cache alignment issue > > > > > +#ifdef RTE_ARCH_64 > > struct rte_bucket_4_32 { > >

[dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table

2020-07-22 Thread Shougang Wang
The hash look up table (LUT) is managed by global register but it is not initialized when RSS is disabled. Once user wants to enable RSS during runtime, the LUT will not be initialized. This patch fixes the issue by initializing the LUT whether RSS enabled or not. Fixes: feaae285b342 ("net/i40e: s

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-22 Thread Jerin Jacob
On Wed, Jul 22, 2020 at 6:10 AM Thomas Monjalon wrote: > > In addition may I ask your opinion on the changes that are required > > before the library can be accepted? > > Very few contributors take time to look at it. > Clearly we want this feature. We really want it, > but we are not able to ded

Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue

2020-07-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Xu, Ting > Sent: Wednesday, July 22, 2020 3:16 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Xu, Ting > ; sta...@dpdk.org > Subject: [PATCH v4] lib/table: fix cache alignment issue > > When create softnic hash table with 16 keys, it failed on 32-bit >

Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue

2020-07-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Xu, Ting > Sent: Wednesday, July 22, 2020 9:31 AM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v4] lib/table: fix cache alignment issue > > Hi, Cristian, > > > -Original Message- > > From: Dumitrescu, Cristi

Re: [dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests

2020-07-22 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Monday, July 20, 2020 1:59 PM > To: De Lara Guarch, Pablo ; > akhil.go...@nxp.com; Doherty, Declan ; Trahe, > Fiona > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, > Mairtin > Subject: RE: [PATCH v1] app/crypto-perf: set mbuf

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-22 Thread Thomas Monjalon
22/07/2020 10:45, Jerin Jacob: > On Wed, Jul 22, 2020 at 6:10 AM Thomas Monjalon wrote: > > > > In addition may I ask your opinion on the changes that are required > > > before the library can be accepted? > > > > Very few contributors take time to look at it. > > Clearly we want this feature. We

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-22 Thread Burakov, Anatoly
On 20-Jul-20 7:51 PM, Stephen Hemminger wrote: On Mon, 20 Jul 2020 13:32:27 +0100 "Burakov, Anatoly" wrote: On 18-Jul-20 3:22 AM, Stephen Hemminger wrote: On Fri, 17 Jul 2020 16:21:37 +0100 "Burakov, Anatoly" wrote: On 16-Jul-20 11:04 PM, Stephen Hemminger wrote: On Thu, 16 Jul 2020 14

[dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over Bluefield

2020-07-22 Thread Raslan Darawsheh
When trying to set MAC address of an ethethet device and if it was a representor, PMD sets the MAC over the corresponding VF instead. For the case of HPF (Host PF representor on BluueField), PMD shouldn't attempt to set it, since it doesn't have any corresponding VF and fails. This will fix the i

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-22 Thread Jerin Jacob
On Wed, Jul 22, 2020 at 2:26 PM Thomas Monjalon wrote: > > 22/07/2020 10:45, Jerin Jacob: > > On Wed, Jul 22, 2020 at 6:10 AM Thomas Monjalon wrote: > > > > > > In addition may I ask your opinion on the changes that are required > > > > before the library can be accepted? > > > > > > Very few con

Re: [dpdk-dev] [PATCH] net/mlx5: fix rte flow items size calculation

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, July 16, 2020 3:15 PM > To: dev@dpdk.org > Cc: Dekel Peled ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix rte flow items size calculation > > flow_dv_get_item_len returns the actual header size of > an rte_flow item.

Re: [dpdk-dev] [PATCH v3] net/mlx5: return EAGAIN on premature disable interrupt calls

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ophir Munk > Sent: Tuesday, July 21, 2020 5:41 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Ophir Munk > ; Matan Azrad > Subject: [PATCH v3] net/mlx5: return EAGAIN on premature disable interrupt > calls > > RXQ interrupts under Linux are based on the

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell record size

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, July 21, 2020 2:11 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon ; > Dekel Peled ; sta...@dpdk.org > Subject: [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell record size > > When Rx/Tx

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-22 Thread Thomas Monjalon
22/07/2020 11:09, Jerin Jacob: > On Wed, Jul 22, 2020 at 2:26 PM Thomas Monjalon wrote: > > 22/07/2020 10:45, Jerin Jacob: > > > On Wed, Jul 22, 2020 at 6:10 AM Thomas Monjalon > > > wrote: > > > > > > > > In addition may I ask your opinion on the changes that are required > > > > > before the l

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-22 Thread Jerin Jacob
On Wed, Jul 22, 2020 at 2:57 PM Thomas Monjalon wrote: > > 22/07/2020 11:09, Jerin Jacob: > > On Wed, Jul 22, 2020 at 2:26 PM Thomas Monjalon wrote: > > > 22/07/2020 10:45, Jerin Jacob: > > > > On Wed, Jul 22, 2020 at 6:10 AM Thomas Monjalon > > > > wrote: > > > > > > > > > > In addition may I

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-22 Thread Burakov, Anatoly
On 22-Jul-20 10:05 AM, Burakov, Anatoly wrote: On 20-Jul-20 7:51 PM, Stephen Hemminger wrote: On Mon, 20 Jul 2020 13:32:27 +0100 "Burakov, Anatoly" wrote: On 18-Jul-20 3:22 AM, Stephen Hemminger wrote: On Fri, 17 Jul 2020 16:21:37 +0100 "Burakov, Anatoly" wrote: On 16-Jul-20 11:04 PM, Step

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-22 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, July 21, 2020 9:24 PM > To: David Marchand > Cc: Van Haaren, Harry ; dev@dpdk.org; > igor.roma...@oktetlabs.ru; Yigit, Ferruh ; nd > ; acon...@redhat.com; l.wojciec...@partner.samsung.com; Phil > Yang ; Honnappa Nagarahall

[dpdk-dev] [PATCH] crypto/scheduler: replace usage of master/slave

2020-07-22 Thread Adam Dybkowski
This patch replaces the usage of master/slave in QAT PMD and Scheduler PMD as well as in their docs. Also the test app was modified to use the new wording. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 16 +- doc/guides/cryptodevs/qat.rst |

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-22 Thread Fady Bader
> -Original Message- > From: Dmitry Kozlyuk > Sent: Monday, July 20, 2020 7:27 PM > To: Fady Bader > Cc: Narcisa Ana Maria Vasile ; dev@dpdk.org; > Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com; anand.ra.

Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on stopping lcore

2020-07-22 Thread Van Haaren, Harry
> -Original Message- > From: Phil Yang > Sent: Tuesday, July 21, 2020 9:39 AM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: david.march...@redhat.com; igor.roma...@oktetlabs.ru; Honnappa > Nagarahalli ; Yigit, Ferruh > ; nd ; acon...@redhat.com; > l.wojciec...@partner.samsung.com; nd > Sub

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-22 Thread Bruce Richardson
On Wed, Jul 22, 2020 at 10:20:48AM +, Fady Bader wrote: > > > > -Original Message- > > From: Dmitry Kozlyuk > > Sent: Monday, July 20, 2020 7:27 PM > > To: Fady Bader > > Cc: Narcisa Ana Maria Vasile ; dev@dpdk.org; > > Thomas Monjalon ; Tasnim Bashar > > ; Tal Shnaiderman ; Yohad T

[dpdk-dev] [PATCH v3 1/2] service: add API to retrieve service core active

2020-07-22 Thread Harry van Haaren
This commit adds a new experimental API which allows the user to retrieve the active state of an lcore. Knowing when the service lcore is completed its polling loop can be useful to applications to avoid race conditions when e.g. finalizing statistics. The service thread itself now has a variable

[dpdk-dev] [PATCH v3 2/2] test/service: fix race condition on stopping lcore

2020-07-22 Thread Harry van Haaren
This commit fixes a potential race condition in the tests where the lcore running a service would increment a counter that was already reset by the test-suite thread. The resulting race-condition incremented value could cause CI failures, as indicated by DPDK's CI. This patch fixes the race-condit

[dpdk-dev] [PATCH v1 0/2] update docs for vhost async API

2020-07-22 Thread patrick . fu
From: Patrick Fu update documentations for vhost async API Patrick Fu (2): doc: update guides for vhost async APIs doc: update release notes for vhost async APIs doc/guides/prog_guide/vhost_lib.rst| 86 +++--- doc/guides/rel_notes/release_20_08.rst | 5 ++ 2 files

[dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs

2020-07-22 Thread patrick . fu
From: Patrick Fu Update vhost guides to document vhost async APIs Signed-off-by: Patrick Fu --- doc/guides/prog_guide/vhost_lib.rst | 86 ++--- 1 file changed, 77 insertions(+), 9 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vh

[dpdk-dev] [PATCH v1 2/2] doc: update release notes for vhost async APIs

2020-07-22 Thread patrick . fu
From: Patrick Fu Update 20.08 release notes to include vhost async APIs Signed-off-by: Patrick Fu --- doc/guides/rel_notes/release_20_08.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index f19b74872

Re: [dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx

2020-07-22 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, July 22, 2020 9:07 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx > > This adds pci detection and documentation for In

Re: [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs

2020-07-22 Thread Xia, Chenbo
Hi Patrick, > -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 22, 2020 6:58 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v1 1/2] doc: update guides for vhost async APIs > > From: Patrick Fu > > Update vhost guides

Re: [dpdk-dev] [PATCH v1 2/2] doc: update release notes for vhost async APIs

2020-07-22 Thread Xia, Chenbo
Hi Patrick, > -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 22, 2020 6:58 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v1 2/2] doc: update release notes for vhost async APIs > > From: Patrick Fu > > Update 20.08

Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: separate aging counter pool range

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, July 22, 2020 10:59 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH v2 1/3] net/mlx5: separate aging counter pool range > > Currently, when allocate the counter or counter b

Re: [dpdk-dev] [PATCH] crypto/scheduler: replace usage of master/slave

2020-07-22 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Adam Dybkowski > Sent: Wednesday, July 22, 2020 11:15 AM > To: dev@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [dpdk-dev] [PATCH] crypto/scheduler: replace usage of > master/slave > > This patch replace

[dpdk-dev] [PATCH] doc: update release notes for hns3 driver

2020-07-22 Thread Wei Hu (Xavier)
Add release notes for Hisilicon hns3 PMD driver. Signed-off-by: Wei Hu (Xavier) --- doc/guides/rel_notes/release_20_08.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index d65f772..89822bc 100644 --

Re: [dpdk-dev] [PATCH] common/qat: remove unused fields

2020-07-22 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, July 21, 2020 2:37 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH] common/qat: remove unused fields > > This patch removes unused fields from structs qat_qp and > qat_qp_

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-22 Thread Phil Yang
Alexander Kozyrev writes: > > > > > > > Subject: RE: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for > > > > > multi- packet RQ buffer refcnt > > > > > > > > > > Hi Phil Yang, we noticed that this patch gives us 10% of > > > > > performance degradation on ARM. > > > > > x86 seems to be unaf

Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove dead code

2020-07-22 Thread wangyunjian
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, July 22, 2020 3:45 PM > To: Rasesh Mody > Cc: wangyunjian ; dev@dpdk.org; Shahed Shaikh > ; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [EXT] [dpdk-dev] [PATCH] net/qede: remove dea

Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove dead code

2020-07-22 Thread Ferruh Yigit
On 7/22/2020 1:15 PM, wangyunjian wrote: >> -Original Message- >> From: Jerin Jacob [mailto:jerinjac...@gmail.com] >> Sent: Wednesday, July 22, 2020 3:45 PM >> To: Rasesh Mody >> Cc: wangyunjian ; dev@dpdk.org; Shahed Shaikh >> ; Lilijun (Jerry) ; xudingke >> ; sta...@dpdk.org >> Subject:

Re: [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system

2020-07-22 Thread Thomas Monjalon
21/07/2020 17:39, Bruce Richardson: > When building the DPDK guide documents, the DPDK version information was > pulled using "make showversion", which meant there was a dependency on > the DPDK make-based build system. Change this to just read the data from > the VERSION file in the root directory

Re: [dpdk-dev] [PATCH 1/1] eal/linux: do not create user mem map repeatedly when it exists

2020-07-22 Thread wangyunjian
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Monday, July 20, 2020 7:46 PM > To: wangyunjian ; dev@dpdk.org; > david.march...@redhat.com > Cc: Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] eal/linux: do not c

[dpdk-dev] [PATCH 1/2] examples/l2fwd-jobstats: Free resources on exit

2020-07-22 Thread Ibtisam Tariq
When exiting the application, resources should be cleared. Signed-off-by: Ibtisam Tariq --- examples/l2fwd-jobstats/main.c | 49 +- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index

[dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on exit

2020-07-22 Thread Ibtisam Tariq
When exiting the application, resources should be cleared. Signed-off-by: Ibtisam Tariq --- examples/l2fwd-crypto/main.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e

Re: [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system

2020-07-22 Thread Bruce Richardson
On Wed, Jul 22, 2020 at 02:45:54PM +0200, Thomas Monjalon wrote: > 21/07/2020 17:39, Bruce Richardson: > > When building the DPDK guide documents, the DPDK version information was > > pulled using "make showversion", which meant there was a dependency on > > the DPDK make-based build system. Change

Re: [dpdk-dev] [PATCH v2 2/3] common/mlx5: add counter batch query ID alignment define

2020-07-22 Thread Ferruh Yigit
On 7/22/2020 8:58 AM, Suanming Mou wrote: > The counter batch query requires ID to be aligned with 4. > > Signed-off-by: Suanming Mou > Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_prm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/common/mlx5/mlx5_prm.h b/driv

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-22 Thread Stephen Hemminger
On Wed, 22 Jul 2020 10:05:09 +0100 "Burakov, Anatoly" wrote: > On 20-Jul-20 7:51 PM, Stephen Hemminger wrote: > > On Mon, 20 Jul 2020 13:32:27 +0100 > > "Burakov, Anatoly" wrote: > > > >> On 18-Jul-20 3:22 AM, Stephen Hemminger wrote: > >>> On Fri, 17 Jul 2020 16:21:37 +0100 > >>> "Burakov,

Re: [dpdk-dev] [PATCH v3 5/5] doc: add documentation for multi process crypto app

2020-07-22 Thread Kusztal, ArkadiuszX
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 15, 2020 8:22 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; tho...@monjalon.net > Subject: RE: [PATCH v3 5/5] doc: add documentation for multi process crypto > app > > Hi Arek, > > > Subject: [

[dpdk-dev] [PATCH] net/mlx5: fix UAR memory mapping type

2020-07-22 Thread Viacheslav Ovsiienko
The User Access Region is a special mechanism to provide direct access to the hardware registers, and is the part of PCI address space that is mapped to CPU virtual address. The mapping can be performed with the type "Write-Combining" or "Non-Cached", and these ones might be supported or not on dif

[dpdk-dev] [PATCH v2 0/2] update docs for vhost async APIs

2020-07-22 Thread patrick . fu
From: Patrick Fu update docs for vhost async APIs v2: - fix typos in vhost_lib.rst - minor rewording in vhost_lib.rst - add more detailed API notes in release notes - rebase the patch to 20.08 rc2 Patrick Fu (2): doc: update guides for vhost async APIs doc: update release notes for vho

[dpdk-dev] [PATCH v2 2/2] doc: update release notes for vhost async APIs

2020-07-22 Thread patrick . fu
From: Patrick Fu Update 20.08 release notes to include vhost async APIs Signed-off-by: Patrick Fu --- doc/guides/rel_notes/release_20_08.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index d65f7725

[dpdk-dev] [PATCH v2 1/2] doc: update guides for vhost async APIs

2020-07-22 Thread patrick . fu
From: Patrick Fu Update vhost guides to document vhost async APIs Signed-off-by: Patrick Fu --- doc/guides/prog_guide/vhost_lib.rst | 86 ++--- 1 file changed, 77 insertions(+), 9 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vh

Re: [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs

2020-07-22 Thread Fu, Patrick
Thanks for comments. v2 patch sent with all the changes suggested. Thanks, Patrick > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, July 22, 2020 7:21 PM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com > Subject: RE: [PATCH v1 1/2] doc: update guides for vhost

Re: [dpdk-dev] [PATCH v1 2/2] doc: update release notes for vhost async APIs

2020-07-22 Thread Fu, Patrick
Hi, > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, July 22, 2020 7:25 PM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com > Subject: RE: [PATCH v1 2/2] doc: update release notes for vhost async APIs > > Hi Patrick, > > > -Original Message- > > From: Fu

Re: [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for steering registers

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 2:57 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for steering > registers > > The mlx5_flow_action_cop

Re: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin splitter

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:00 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in > hairpin > splitter > > The flow_ha

Re: [dpdk-dev] [PATCH] net/mlx5: optimize critical section in device free

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:04 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx5: optimize critical section in device free > > When PMD releases shared IB device context,

Re: [dpdk-dev] [PATCH] net/mlx5: optimize stuck memory in probe

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:05 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx5: optimize stuck memory in probe > > The device configuration stuck is not small enough to

Re: [dpdk-dev] [PATCH] net/mlx5: fix NVGRE item mask handling

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 2:59 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix NVGRE item mask handling > > The flow_dv_translate_item_nvgre funct

Re: [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch info detection

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:03 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch info > detection > > In mlx5_sysfs_switch_

Re: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:01 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe > > The mlx4_pci_probe function set

Re: [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action conversion

2020-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:05 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action > conversion > > The flow_dv_conver

Re: [dpdk-dev] [PATCH] net/mlx5: optimize stuck memory in probe

2020-07-22 Thread Ferruh Yigit
On 7/22/2020 4:30 PM, Raslan Darawsheh wrote: > Hi, > >> -Original Message- >> From: dev On Behalf Of Michael Baum >> Sent: Tuesday, July 21, 2020 3:05 PM >> To: dev@dpdk.org >> Cc: Matan Azrad ; Slava Ovsiienko >> >> Subject: [dpdk-dev] [PATCH] net/mlx5: optimize stuck memory in probe >

Re: [dpdk-dev] [PATCH] net/mlx5: optimize stuck memory in probe

2020-07-22 Thread Ferruh Yigit
On 7/22/2020 5:33 PM, Ferruh Yigit wrote: > On 7/22/2020 4:30 PM, Raslan Darawsheh wrote: >> Hi, >> >>> -Original Message- >>> From: dev On Behalf Of Michael Baum >>> Sent: Tuesday, July 21, 2020 3:05 PM >>> To: dev@dpdk.org >>> Cc: Matan Azrad ; Slava Ovsiienko >>> >>> Subject: [dpdk-dev

Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides

2020-07-22 Thread Thomas Monjalon
21/07/2020 18:09, Ciara Power: > --- a/doc/guides/howto/telemetry.rst > +++ b/doc/guides/howto/telemetry.rst > @@ -1,6 +1,7 @@ > .. SPDX-License-Identifier: BSD-3-Clause > Copyright(c) 2020 Intel Corporation. > > +.. _telemetry: We don't need such anchor. The beginning of a page can be li

[dpdk-dev] [dpdk-announce] New DPDK White Paper + Userspace Registration Live

2020-07-22 Thread Jill Lovato
Hello DPDK Community, We are pleased to announce the publication of a new whitepaper, *"Myth-Busting DPDK in 2020: Revealed: The Past, Present, and Future of the W Most Popular Data Plane Development Kit in the World." *The paper was produced by research firm AvidThink, who also produced a seri

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-22 Thread Honnappa Nagarahalli
+ Gage (as I referring to his commit below) > > > > > > +/** > > > > > + * Reports if a service lcore is currently running. > > > > > + * @retval 0 Service thread is not active, and has been returned to > EAL. > > > > > + * @retval 1 Service thread is in the service core polling loop. > > > > >

[dpdk-dev] [PATCH] net/mlx5: fix vectorized mini-CQE prefetching

2020-07-22 Thread Alexander Kozyrev
There was an optimization work to prefetch all the CQEs before their invalidation. It allowed us to speed up the mini-CQE decompression process by preheating the cache in the vectorized Rx routine. Prefetching of the next mini-CQE, on the other hand, showed no difference in the performance on x86

Re: [dpdk-dev] [PATCH v3 1/2] service: add API to retrieve service core active

2020-07-22 Thread Honnappa Nagarahalli
> Subject: [PATCH v3 1/2] service: add API to retrieve service core active > > This commit adds a new experimental API which allows the user to retrieve > the active state of an lcore. Knowing when the service lcore is completed its > polling loop can be useful to applications to avoid race cond

Re: [dpdk-dev] [PATCH v3 2/2] test/service: fix race condition on stopping lcore

2020-07-22 Thread Honnappa Nagarahalli
> Subject: [PATCH v3 2/2] test/service: fix race condition on stopping lcore > > This commit fixes a potential race condition in the tests where the lcore > running a service would increment a counter that was already reset by the > test-suite thread. The resulting race-condition incremented v

Re: [dpdk-dev] [PATCH 2/2] doc: add deprecation notice for change of rawdev APIs

2020-07-22 Thread Xu, Rosen
Hi, -Original Message- From: dev On Behalf Of Bruce Richardson Sent: Monday, July 13, 2020 8:31 PM To: dev@dpdk.org Cc: Richardson, Bruce ; Nipun Gupta ; Hemant Agrawal Subject: [dpdk-dev] [PATCH 2/2] doc: add deprecation notice for change of rawdev APIs Add to the documentation for 2

Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table

2020-07-22 Thread Yang, Qiming
I don't understand why you add new function and new function mostly do the same thing. Why don't add fix in original code. > -Original Message- > From: dev On Behalf Of Shougang Wang > Sent: Wednesday, July 22, 2020 16:16 > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Shougan

Re: [dpdk-dev] [PATCH 1/2] test/mcslock: move performance test to perf tests

2020-07-22 Thread Phil Yang
Hi Aaron, It seems Travis CI cannot capture this timeout issue. But the local test records these two cases as TIMEOUT under the default timeout configuration. 1. The test results on x86 server (72 lcores online@ 2.60GHz) are: a. Default setting: $ sudo meson test -C build_test --suite DPDK:fast-

[dpdk-dev] [PATCH] net/iavf: disable function simple xor for AVF RSS

2020-07-22 Thread Junfeng Guo
Function simple_xor for AVF RSS is not required currently, thus we just return rte_flow error when the commandline has item simple_xor. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_hash.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/ia

[dpdk-dev] [PATCH v4 1/2] net/i40e: fix binding interrupt without msix vectors

2020-07-22 Thread Jiang Mao
The value of vsi->nb_msix shouldn`t be zero, otherwise, all of interrupts will be bind to vector 0. Fixes: 4861cde461 (i40e: new poll mode driver) Cc: sta...@dpdk.org Signed-off-by: Jiang Mao --- V3: Fix format issue. V4: Rebase this patch. --- drivers/net/i40e/i40e_ethdev.c | 25 ++

Re: [dpdk-dev] [PATCH v3 09/14] net/bnxt: change header to use SPDX license

2020-07-22 Thread Stephen Hemminger
On Sat, 18 Jul 2020 00:25:10 -0700 Ajit Khaparde wrote: > From: Randy Schacher > > Update cfa_resource_types.h to use SPDX license header. > > Reported-by: Stephen Hemminger > Signed-off-by: Randy Schacher > Signed-off-by: Somnath Kotur > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnx

Re: [dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker

2020-07-22 Thread Stephen Hemminger
On Tue, 14 Jul 2020 16:21:01 -0700 Stephen Hemminger wrote: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger All comments are addressed should be merged by now.

[dpdk-dev] [PATCH v4 2/2] net/i40e: fix fdir allocating msix resource error

2020-07-22 Thread Jiang Mao
Fdir allocating msix resource is not strictly necessary, if no resource left, jump the error. Fixes: 4861cde461 (i40e: new poll mode driver) Cc: sta...@dpdk.org Signed-off-by: Jiang Mao --- V3: Move type I40E_VSI_FDIR branch into !I40E_VSI_SRIOV branch. V4: Rebase this patch. --- drivers/net/i4

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-22 Thread Honnappa Nagarahalli
Hi Alexander, Thank you for testing this patch. Few comments below. > > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for > > multi-packet RQ buffer refcnt > > > > Hi, > > > > We are also doing C11 atomics converting for other components. > > Your insight would be much ap

[dpdk-dev] [Bug 513] [dpdk-20.08]tx_preparation/tx_preparation:IPV6/TCP packets TSO checksum incorrect

2020-07-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=513 Bug ID: 513 Summary: [dpdk-20.08]tx_preparation/tx_preparation:IPV6/TCP packets TSO checksum incorrect Product: DPDK Version: 20.08 Hardware: All OS: All

[dpdk-dev] [Bug 514] [dpdk-20.08]tx_preparation/tx_preparation:IPV6/TCP packets TSO checksum incorrect

2020-07-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=514 Bug ID: 514 Summary: [dpdk-20.08]tx_preparation/tx_preparation:IPV6/TCP packets TSO checksum incorrect Product: DPDK Version: 20.08 Hardware: All OS: All

[dpdk-dev] [Bug 513] [dpdk-20.08]tx_preparation/tx_preparation:IPV6/TCP packets TSO checksum incorrect

2020-07-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=513 xizhan4x (xix.zh...@intel.com) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCO

[dpdk-dev] [PATCH v1] vhost: fix vring disable fail in async transfer

2020-07-22 Thread patrick . fu
From: Patrick Fu Async inflight packets is checked when front end virtio requests to disable vring. If inflight packets exists, vring disabling will fail. However, there is no good way for application to get notified before vring is disabled and properly complete inflight packets. This patch move

[dpdk-dev] [PATCH v1] vhost: fix async callback return type define

2020-07-22 Thread patrick . fu
From: Patrick Fu The async copy device callbacks are used by async APIs to transfer data and check completion status. Async APIs return the number of packets successfully processed to the caller applications and no error (negative) value is allowed for API return value. Thus, negative return valu

Re: [dpdk-dev] [PATCH] net/iavf: disable function simple xor for AVF RSS

2020-07-22 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Thursday, July 23, 2020 7:10 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > ; Su, Simei > Subject: [PATCH] net/iavf: disable function simple xor for AVF RSS > > Function simple_xor for AVF RSS is not

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-22 Thread Phil Yang
> > > > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for > > > multi-packet RQ buffer refcnt > > > > > > Hi, > > > > > > We are also doing C11 atomics converting for other components. > > > Your insight would be much appreciated. > > > > > > Thanks, > > > Phil Yang > > > > > > >

Re: [dpdk-dev] [PATCH v1] vhost: fix vring disable fail in async transfer

2020-07-22 Thread Fu, Patrick
Hi, Sorry but I'd like to withdraw this patch as the issue could be addressed by applications to register a pre_msg_handler. Thanks, Patrick > -Original Message- > From: Fu, Patrick > Sent: Thursday, July 23, 2020 1:38 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo >