Hi, > -----Original Message----- > From: dev <[email protected]> On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:00 PM > To: [email protected] > Cc: Matan Azrad <[email protected]>; Slava Ovsiienko > <[email protected]>; [email protected] > Subject: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in > hairpin > splitter > > The flow_hairpin_split function defines a pointer called addr that > points to the list of items. > When the function wants to progress in the list, it adds the size of an > item to the pointer. > > At the end of the function, it precedes the pointer one more time even > though it is not used afterwards. In fact, this line is unaffected and > the operation of the function would have been no different without it. > > Remove the line where the pointer is preceded unnecessarily. > > Fixes: d85c7b5ea59f ("net/mlx5: split hairpin flows") > Cc: [email protected] > > Signed-off-by: Michael Baum <[email protected]> > Acked-by: Matan Azrad <[email protected]> > --- > drivers/net/mlx5/mlx5_flow.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index aba8f41..cf7052b 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -3518,7 +3518,6 @@ struct mlx5_flow_tunnel_info { > tag_item->data = UINT32_MAX; > tag_item->id = UINT16_MAX; > item->mask = tag_item; > - addr += sizeof(struct mlx5_rte_flow_item_tag); > item->last = NULL; > item++; > item->type = RTE_FLOW_ITEM_TYPE_END; > -- > 1.8.3.1
Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
