Re: [dpdk-dev] [PATCH v3] vhost: fix wrong async completion of multi-seg packets

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 9:40 AM, Maxime Coquelin wrote: > > > On 7/21/20 7:47 AM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> In async enqueue copy, a packet could be split into multiple copy >> segments. When polling the copy completion status, current async data >> path assumes the async device

Re: [dpdk-dev] [PATCH v4 2/4] build: use Python pmdinfogen

2020-07-21 Thread Dmitry Kozlyuk
On Tue, 21 Jul 2020 15:04:11 +0100, Bruce Richardson wrote: > On Thu, Jul 09, 2020 at 12:23:33AM +0300, Dmitry Kozlyuk wrote: [snip] > > diff --git a/buildtools/gen-pmdinfo-cfile.sh > > b/buildtools/gen-pmdinfo-cfile.sh > > index 43059cf36..109ee461e 100755 > > --- a/buildtools/gen-pmdinfo-cfile.s

Re: [dpdk-dev] [PATCH v2] vhost: fix double-free with zero-copy

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 10:16 AM, Maxime Coquelin wrote: > > > On 7/21/20 2:10 PM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> zmbufs should be set to NULL when getting freed to avoid double free on >> the same buffer pointer >> >> Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") >> >> Signed

Re: [dpdk-dev] Random failure in service_autotest

2020-07-21 Thread Honnappa Nagarahalli
> > > Thanks Lukasz & Phil for v2 reviews & Acks. > > > > >> return 0; > > > > Changing the implementation loop counting is one option - but > > > > changing the implementation as a workaround for a unit test seems > > > > like the wrong > > > way around. > > > I agree. We should fix

[dpdk-dev] [PATCH v2] crypto/qat: add DOCSIS performance optimization

2020-07-21 Thread David Coyle
DOCSIS protocol performance in the downlink direction can be improved significantly in the QAT SYM PMD, especially for larger packets, by pre-processing all CRC generations in a batch before building and enqueuing any requests to the HW. This patch adds this optimization. Fixes: 6f0ef237404b ("cry

[dpdk-dev] [PATCH v2] app/crypto-perf: support security protocol in PMDCC mode

2020-07-21 Thread David Coyle
This patch adds support for DOCSIS and PDCP security protocols to the pmd-cyclecount mode of the crypto performance tool. Adding this support involves freeing the correct session type (i.e. security or cryptodev session) when the test ends, depending on the op_type specified. Signed-off-by: David

Re: [dpdk-dev] [PATCH v2] crypto/qat: add DOCSIS performance optimization

2020-07-21 Thread Trahe, Fiona
> -Original Message- > From: Coyle, David > Sent: Tuesday, July 21, 2020 3:47 PM > To: Trahe, Fiona ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, Mairtin > ; Doherty, Declan ; > De Lara Guarch, Pablo > ; Coyle, David > Subject: [PATCH v2] crypto/qat: add DOCSI

Re: [dpdk-dev] Random failure in service_autotest

2020-07-21 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, July 21, 2020 4:09 PM > To: Van Haaren, Harry ; Lukasz Wojciechowski > ; Phil Yang ; Aaron > Conole > Cc: David Marchand ; Igor Romanov > ; dev ; Yigit, Ferruh > ; nd ; Honnappa Nagarahalli > ; nd > Subject: RE: [dpdk-dev

[dpdk-dev] [PATCH] doc/guides: remove dependency on make build system

2020-07-21 Thread Bruce Richardson
When building the DPDK guide documents, the DPDK version information was pulled using "make showversion", which meant there was a dependency on the DPDK make-based build system. Change this to just read the data from the VERSION file in the root directory. Signed-off-by: Bruce Richardson --- NOTE

Re: [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system

2020-07-21 Thread Bruce Richardson
On Tue, Jul 21, 2020 at 04:39:50PM +0100, Bruce Richardson wrote: > When building the DPDK guide documents, the DPDK version information was > pulled using "make showversion", which meant there was a dependency on > the DPDK make-based build system. Change this to just read the data from > the VERS

Re: [dpdk-dev] [PATCH v2] net: fix compilation with pedantic enabled

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 9:31 AM, Raslan Darawsheh wrote: > when trying to compile rte_mpls with pedantic enabled, > on old compilers like 4.8 it will complain about bit field definition. > > error: type of bit-field 'bs' is a GCC extension [-Werror=pedantic] > error: type of bit-field 'tc' is a GCC extension

Re: [dpdk-dev] [PATCH] examples: fix return value of function that parses portmask

2020-07-21 Thread Bruce Richardson
On Thu, Jun 11, 2020 at 05:36:24PM +0500, Sarosh Arif wrote: > Giving invalid or zero portmask as command line option to > these applications will have an unexpected response. > The reason behind this is that the return value of function > that parses portmask is stored in a variable whose datatyp

[dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides

2020-07-21 Thread Ciara Power
This patch adds examples to the Telemetry HowTo guide, to demonstrate commands that use parameters. The programmer's guide is also modified to include details on writing a callback function for a new command. Signed-off-by: Ciara Power --- v2: - Replaced examples of using commands in the progr

Re: [dpdk-dev] Random failure in service_autotest

2020-07-21 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > If I understand the intent of the test case correctly, the > > > > sequence of the calls needs to be: > > > > rte_service_runstate_set(id, 0) > > > > rte_service_component_runstate_set(id, 0); > > > > rte_service_may_be_active - loop till the service is not active >

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread Medvedkin, Vladimir
Hi Ruifeng, On 18/07/2020 10:22, Ruifeng Wang wrote: -Original Message- From: Medvedkin, Vladimir Sent: Saturday, July 18, 2020 1:12 AM To: Ruifeng Wang ; Bruce Richardson Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli ; Phil Yang Subject: Re: [PATCH v2] lpm: fix unchecked return value

Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 9:57 AM, Andrew Rybchenko wrote: > efx_types.h uses defines from efx_annote.h, but does not include the > header. As the result if efx_types.h is included by a driver first, > build fails. > > Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/sfc: avoid unnecessary actions on dummy default MAC set

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 9:58 AM, Andrew Rybchenko wrote: > Just an optimization to avoid extra reconfiguration when it > is not not actually required. > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/sfc: do not enforce RSS hash offload in RSS multi-queue

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 3:54 PM, Andrew Rybchenko wrote: > Rx RSS hash offload should be controlled by the user and should > not be enforced by RSS multi-queue Rx mode. > > Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko

[dpdk-dev] [PATCH v2] net/vhost: support queue update

2020-07-21 Thread Matan Azrad
The commit below changed the readiness condition of vhost device to fix multi-queues issues showed with QEMU versions. Now, the vhost device is ready when the first queue-pair is ready. When more queues are being ready, the queue state callback will be triggered to notify the vhost manager. In ca

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

2020-07-21 Thread Stephen Hemminger
On Fri, 17 Jul 2020 17:01:00 +0200 Thomas Monjalon wrote: > 15/07/2020 23:22, Stephen Hemminger: > > --- a/app/proc-info/Makefile > > +++ b/app/proc-info/Makefile > > +CFLAGS += -DALLOW_EXPERIMENTAL_API > > not needed in app/ > > > +CFLAGS += -O3 > > CFLAGS += $(WERROR_FLAGS) > > +CFLAGS +=

Re: [dpdk-dev] [PATCH v6 00/13] add Mellanox RegEx PMD

2020-07-21 Thread Thomas Monjalon
20/07/2020 08:26, Ori Kam: > This patch series introduce the Mellanox BF2 RegEx PMD. > > Mellanox BF2 RegEx PMD implement the API defined in the > regexdev lib [1]. > > This PMD allows a DPDK application to offload the RegEx functionality > to Mellanox BF2 RegEx engine. [...] > Francis Kelly (1):

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

2020-07-21 Thread Thomas Monjalon
21/07/2020 19:05, Stephen Hemminger: > On Fri, 17 Jul 2020 17:01:00 +0200 > Thomas Monjalon wrote: > > 15/07/2020 23:22, Stephen Hemminger: > > > + /* If no port mask was specified, one will be provided */ > > > > Would be nice to help the user by printing a port mask > > of owned and unowned p

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread Bruce Richardson
On Tue, Jul 21, 2020 at 05:23:02PM +0100, Medvedkin, Vladimir wrote: > Hi Ruifeng, > > On 18/07/2020 10:22, Ruifeng Wang wrote: > > > > > -Original Message- > > > From: Medvedkin, Vladimir > > > Sent: Saturday, July 18, 2020 1:12 AM > > > To: Ruifeng Wang ; Bruce Richardson > > > > > >

Re: [dpdk-dev] [PATCH v2] net/vhost: support queue update

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 5:38 PM, Matan Azrad wrote: > The commit below changed the readiness condition of vhost device to fix > multi-queues issues showed with QEMU versions. > > Now, the vhost device is ready when the first queue-pair is ready. > When more queues are being ready, the queue state callback wi

Re: [dpdk-dev] [PATCH v5 2/2] mempool/ring: add support for new ring sync modes

2020-07-21 Thread David Marchand
On Wed, Jul 15, 2020 at 4:59 PM Konstantin Ananyev wrote: > > Two new sync modes were introduced into rte_ring: > relaxed tail sync (RTS) and head/tail sync (HTS). > This change provides user with ability to select these > modes for ring based mempool via mempool ops API. > > Signed-off-by: Konsta

Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked

2020-07-21 Thread Honnappa Nagarahalli
> -Original Message- > From: dev On Behalf Of wangyunjian > Sent: Tuesday, July 21, 2020 8:32 AM > To: dev@dpdk.org > Cc: yipeng1.w...@intel.com; sameh.gobr...@intel.com; > bruce.richard...@intel.com; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Su

Re: [dpdk-dev] [PATCH v2] net/vhost: support queue update

2020-07-21 Thread Maxime Coquelin
Thanks Matan for the fix. On 7/21/20 6:38 PM, Matan Azrad wrote: > The commit below changed the readiness condition of vhost device to fix > multi-queues issues showed with QEMU versions. > > Now, the vhost device is ready when the first queue-pair is ready. > When more queues are being ready, th

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread David Marchand
On Tue, Jul 21, 2020 at 7:16 PM Bruce Richardson wrote: > > On Tue, Jul 21, 2020 at 05:23:02PM +0100, Medvedkin, Vladimir wrote: > > Hi Ruifeng, > > > > On 18/07/2020 10:22, Ruifeng Wang wrote: > > > > > > > -Original Message- > > > > From: Medvedkin, Vladimir > > > > Sent: Saturday, July

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

2020-07-21 Thread Stephen Hemminger
On Tue, 21 Jul 2020 19:08:57 +0200 Thomas Monjalon wrote: > 21/07/2020 19:05, Stephen Hemminger: > > On Fri, 17 Jul 2020 17:01:00 +0200 > > Thomas Monjalon wrote: > > > 15/07/2020 23:22, Stephen Hemminger: > > > > + /* If no port mask was specified, one will be provided */ > > > >

Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides

2020-07-21 Thread Bruce Richardson
On Tue, Jul 21, 2020 at 05:09:24PM +0100, Ciara Power wrote: > This patch adds examples to the Telemetry HowTo guide, to demonstrate > commands that use parameters. The programmer's guide is also modified to > include details on writing a callback function for a new command. > > Signed-off-by: Cia

Re: [dpdk-dev] [PATCH] event/dpaa: remove dead code

2020-07-21 Thread Jerin Jacob
On Fri, Jul 17, 2020 at 5:43 PM Hemant Agrawal wrote: > > Acked-by: Hemant Agrawal > > -Original Message- > From: dev On Behalf Of wangyunjian > Sent: Friday, July 17, 2020 5:02 PM > To: dev@dpdk.org > Cc: Hemant Agrawal ; Nipun Gupta > ; jerry.lili...@huawei.com; xudin...@huawei.com; Y

Re: [dpdk-dev] [PATCH v3 2/2] event/dpaa2: Add all type queue capability flag

2020-07-21 Thread Jerin Jacob
On Mon, Jul 13, 2020 at 5:14 PM Apeksha Gupta wrote: > > Event device capability flag added in event driver, > Event device is capable of enqueuing events of any type to any queue. Please change the subject to "event/dpaa2: add all type queue capability flag" Update git commit comment to below o

[dpdk-dev] [PATCH v4 0/8] app/proc-info enhancements

2020-07-21 Thread Stephen Hemminger
The current proc-info command is useful for diagnosing issues with external DPDK applications, but the display is limited and somewhat ugly. This patchset adds some enhancements which show more info and suppress unnecessary stuff. v4 - incorporate mempool display modify portmask for handling

[dpdk-dev] [PATCH v4 2/8] app/proc-info: eliminate useless borders

2020-07-21 Thread Stephen Hemminger
Printing extra borders does not improve readability, and is just unnecessary. Putting TSC hz in header also makes no sense here. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 35 +++ 1 file changed, 7 insertions(+), 28 delet

[dpdk-dev] [PATCH v4 1/8] app/proc-info: remove unused logtype #define

2020-07-21 Thread Stephen Hemminger
This logtype is defined but never used. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab438..69e3000616c0 100644 --- a/app/proc-info/main.c +++ b/ap

[dpdk-dev] [PATCH v4 4/8] app/proc-info: add more info to show_ports

2020-07-21 Thread Stephen Hemminger
Revise the display of port information to include more data and be more human friendly. * Display units for port speed, and decode link fields. * Show driver and device information * Show MAC address * Show flow control information * Combine lines if possible * Show all multicast mode

[dpdk-dev] [PATCH v4 6/8] app/proc-info: dump rx and tx descriptor info

2020-07-21 Thread Stephen Hemminger
Many drivers will report per queue info for both rx and tx as well as how many descriptors are in use. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 79 1 file changed, 66 insertions(+), 13 deletions(-) diff --

[dpdk-dev] [PATCH v4 3/8] app/proc-info: hide EAL info messages

2020-07-21 Thread Stephen Hemminger
The DPDK EAL info messages at the start of a diagnostic application are not helpful to end user. Suppress them by setting log-level by default. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) di

[dpdk-dev] [PATCH v4 7/8] app/proc-info: add crypto security context info

2020-07-21 Thread Stephen Hemminger
From: Hemant Agrawal If crypto context is not present, no point in displaying it. This patch adds the crypto based security context info. Also improve the flag printing to SECURITY OFFLOAD from INLINE. Use common code for displaying crypto context information when doing show_ports and show_cryp

[dpdk-dev] [PATCH v4 5/8] app/proc-info: enhance mempool to print ops name

2020-07-21 Thread Stephen Hemminger
From: Hemant Agrawal Enhance the mempool details to also print the ops index and name Signed-off-by: Hemant Agrawal Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 7c1276b7fbc1

[dpdk-dev] [PATCH v4 8/8] app/proc-info: provide way to request info on owned ports

2020-07-21 Thread Stephen Hemminger
There are cases where a port maybe owned by another (failsafe, netvsc, bond); but currently proc-info has no way to look at stats of those ports. This patch provides way for the user to explicitly ask for these ports. If no portmask is given the output is unchanged; it only shows the top level por

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread David Marchand
On Thu, Jul 16, 2020 at 5:49 PM Ruifeng Wang wrote: > > Coverity complains about unchecked return value of rte_rcu_qsbr_dq_enqueue. > By default, defer queue size is big enough to hold all tbl8 groups. When > enqueue fails, return error to the user to indicate system issue. > > Coverity issue: 360

Re: [dpdk-dev] [PATCH v2] bus/fslmc: fix memory leak in secondary process

2020-07-21 Thread David Marchand
On Fri, Jul 17, 2020 at 12:50 PM wangyunjian wrote: > > From: Yunjian Wang > > In fslmc_process_mcp(), we allocate memory for 'dev_name' but not > released before return in secondary process. And it is not used > since commit a69f79300262 ("bus/fslmc: support multi VFIO group"), > so it can be re

Re: [dpdk-dev] [PATCH v2] test/eal: check invalid cpu value

2020-07-21 Thread David Marchand
On Mon, Jul 20, 2020 at 1:08 PM Lukasz Wojciechowski wrote: > W dniu 20.07.2020 o 12:19, Kevin Traynor pisze: > > When using --lcores option, there is a limit of CPU_SETSIZE. > > Currently that allows 0..1023 on Linux. > > > > Check it is caught when this limit is exceeded. > Acked-by: Lukasz Woj

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-21 Thread Honnappa Nagarahalli
> Subject: [PATCH v2 1/2] service: add API to retrieve service core active > > This commit adds a new experimental API which allows the user to retrieve > the active state of an lcore. Knowing when the service lcore is completed its > polling loop can be useful to applications to avoid race cond

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-21 Thread David Marchand
On Tue, Jul 21, 2020 at 9:43 PM Honnappa Nagarahalli wrote: > > @@ -457,6 +458,8 @@ service_runner_func(void *arg) > > const int lcore = rte_lcore_id(); > > struct core_state *cs = &lcore_states[lcore]; > > > > + __atomic_store_n(&cs->thread_active, 1, __ATOMIC_RELAXED); > Essentia

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-21 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH v2 1/2] service: add API to retrieve service core active > > On Tue, Jul 21, 2020 at 9:43 PM Honnappa Nagarahalli > wrote: > > > @@ -457,6 +458,8 @@ service_runner_func(void *arg) > > > const int lcore = rte_lcore_id(); > > > struct core_state *cs = &lcore_states

Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked

2020-07-21 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, July 21, 2020 10:27 AM > To: wangyunjian ; dev@dpdk.org > Cc: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce ; > jerry.lili...@huawei.com; xudin...@huawei.com; sta...@dpdk.org; nd > ; Honnappa Nagarahalli ; > nd > Su

Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-21 Thread Thomas Monjalon
I vote for applying this patch series, because it does not change what we have, except printing a warning in case python3 is neither explicitly called, nor the default. I consider it is a good step, and I don't see the extra warning as a severe annoyance. 17/07/2020 18:24, Bruce Richardson: > On

Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-21 Thread David Marchand
On Tue, Jul 21, 2020 at 10:25 PM Thomas Monjalon wrote: > > I vote for applying this patch series, > because it does not change what we have, > except printing a warning in case python3 > is neither explicitly called, nor the default. > > I consider it is a good step, > and I don't see the extra w

Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-21 Thread David Marchand
On Fri, Jul 10, 2020 at 12:11 PM Louise Kilheeney wrote: > > This patchset adds deprecation notices to python scripts, > warning of the removal of python2 support from the DPDK 20.11 release. > > Louise Kilheeney (9): > usertools/cpu_layout: add python2 deprecation notice > usertools/dpdk-tele

Re: [dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue

2020-07-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Xu, Ting > Sent: Tuesday, July 21, 2020 6:16 AM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v3] lib/table: fix cache alignment issue > > Hi, Cristian > > > -Original Message- > > From: Dumitrescu, Cristian

Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove dead code

2020-07-21 Thread Rasesh Mody
>From: wangyunjian >Sent: Friday, July 17, 2020 4:16 AM > >From: Yunjian Wang > >This patch fixes (Logically dead code) coverity issue. > >Coverity issue: 261777, 261778 >Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") >Cc: sta...@dpdk.org > >Signed-off-by: Yunjian Wang >--- Ack

[dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option

2020-07-21 Thread Ajit Khaparde
Add an option in meson build to indicate the memory management scheme. bnxt_eem_system is set to false by default. Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 9 + drivers/net/bnxt/meson.build | 16 ++-- meson_options.txt| 2 ++ 3 files chang

[dpdk-dev] [PATCH 2/2] doc: update bnxt doc

2020-07-21 Thread Ajit Khaparde
Update bnxt doc to indicate support for VF-representors and some notes about rte_flow API implementation. Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 46 1 file changed, 46 insertions(+) diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 2/2] raw/ifpga/base: fix NIOS SPI initial

2020-07-21 Thread Thomas Monjalon
15/07/2020 13:21, Xu, Rosen: > From: Tianfei Zhang > > Add fecmode setting on NIOS SPI primary initialization. > this SPI is shared by NIOS core inside FPGA, NIOS will use this SPI primary > to do some one-time initialization after power up, and then release the > control to DPDK. > > Fix the

Re: [dpdk-dev] [PATCH] node: add pkt classifier node

2020-07-21 Thread Thomas Monjalon
07/06/2020 18:40, Nithin Dabilpuram: > This node classifies pkts based on packet type and > sends them to appropriate next node. This is node > helps in distribution of packets from ethdev_rx node > to different next node with a constant overhead for > all packet types. > > Currently all except no

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option

2020-07-21 Thread Ferruh Yigit
On 7/21/2020 6:47 PM, Ajit Khaparde wrote: > Add an option in meson build to indicate the memory management scheme. > bnxt_eem_system is set to false by default. > > Signed-off-by: Ajit Khaparde <...> > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -2,6 +2,8 @@ > > option('armv8_cry

Re: [dpdk-dev] [PATCH v2] mempool: fix memory allocation in memzones during retry.

2020-07-21 Thread Thomas Monjalon
14/07/2020 11:32, Burakov, Anatoly: > On 14-Jul-20 8:26 AM, Zhike Wang wrote: > > If allocation is successful on the first attempt, typically > > there is no problem since we allocated everything required and > > we'll terminate the loop (if memory chunk is really sufficient > > to populate require

Re: [dpdk-dev] [PATCH v3 1/2] power: fix power management env detection

2020-07-21 Thread Thomas Monjalon
17/07/2020 14:50, Bruce Richardson: > On Tue, Jul 14, 2020 at 11:30:01AM +0100, Anatoly Burakov wrote: > > Anything coming from sysfs has a newline at the end. Cut it off before > > comparing the strings. > > > > Fixes: 20ab67608a39 ("power: add environment capability probing") > > > > Signed-off

Re: [dpdk-dev] [PATCH] doc: fix minor typo for better display

2020-07-21 Thread Thomas Monjalon
08/06/2020 23:52, Honnappa Nagarahalli: > The display was not proper due to the missing space. Changed > arm64 to aarch64. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- > - ``intel_iommu=off`` or ``amd_iommu=off`` or ``intel_iommu=on iommu=pt``in > GRUB > - comma

Re: [dpdk-dev] [PATCH] doc: fix typing error

2020-07-21 Thread Thomas Monjalon
18/06/2020 04:06, Chautru, Nicolas: > From: Sarosh Arif : > > fixed typing error in doc/guides/tools/testbbdev.rst > > > > Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") > > Signed-off-by: Sarosh Arif > > Thanks. > Acked-by: Nic Chautru Applied, thanks

Re: [dpdk-dev] [PATCH] drivers/bus/vdev: corrected a typing error in header file

2020-07-21 Thread Thomas Monjalon
23/06/2020 15:26, Muhammad Bilal: > Here I have corrected a potential typing mistake in header file. > while Uninitalizing the driver the comment was mentioning > initializing instead of Uninitalizing in despription of parameter > > Fixes: d4a586d29e65 ("bus/vdev: move code from EAL into a new dr

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-21 Thread Thomas Monjalon
09/07/2020 10:43, Andrzej Ostruszka [C]: > First of all let me thank you all one again for the time you took > looking at this and summarize your feedback as I understand it. > > 1. Don't use interrupt thread because in heavy load scenarios this might > cause problems. Yes For this usage, and f

[dpdk-dev] [dpdk-announce] release candidate 20.08-rc2

2020-07-21 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v20.08-rc2 There are 201 new patches in this snapshot. Release notes: http://doc.dpdk.org/guides/rel_notes/release_20_08.html Highlights of 20.08-rc2: - new mempool ring modes (RTS/HTS)

Re: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq

2020-07-21 Thread Pavan Nikhilesh Bhagavatula
>Subject: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq ./devtools/check-git-log.sh Wrong headline uppercase: app/test-eventdev: Fix pipeline atq Having a more informative commit title and message would be helpful, Something like: " app/eventdev: fix capability check in

[dpdk-dev] [Bug 512] [dpdk-20.08]Crypto:fips_cryptodev test failed for TDES on aesni_mb, openssl and qat PMD

2020-07-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=512 Bug ID: 512 Summary: [dpdk-20.08]Crypto:fips_cryptodev test failed for TDES on aesni_mb, openssl and qat PMD Product: DPDK Version: 20.08 Hardware: All OS: Linux

[dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue

2020-07-21 Thread Ting Xu
When create softnic hash table with 16 keys, it failed on 32-bit environment, because the pointer field in structure rte_bucket_4_16 is only 32 bits. Add a padding field in 32-bit environment to keep the structure to a multiple of 64 bytes. Apply this to 8-byte and 32-byte key hash function as well

Re: [dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue

2020-07-21 Thread Xu, Ting
Hi, Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 22, 2020 5:17 AM > To: Xu, Ting ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v3] lib/table: fix cache alignment issue > > > > > -Original Message- > > From: Xu, Ting > > Sent:

Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked

2020-07-21 Thread wangyunjian
> -Original Message- > From: Wang, Yipeng1 [mailto:yipeng1.w...@intel.com] > Sent: Wednesday, July 22, 2020 4:24 AM > To: Honnappa Nagarahalli ; wangyunjian > ; dev@dpdk.org > Cc: Gobriel, Sameh ; Richardson, Bruce > ; Lilijun (Jerry) ; > xudingke ; sta...@dpdk.org; nd > Subject: RE: [dpdk

[dpdk-dev] [PATCH v2] hash: fix return value of null not checked

2020-07-21 Thread wangyunjian
From: Yunjian Wang The function rte_zmalloc_socket() could return NULL, the return value need to be checked. Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") Cc: sta...@dpdk.org Reported-by: Bin Huang Signed-off-by: Yunjian Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Yip

Re: [dpdk-dev] DPDK PDUMP Issue

2020-07-21 Thread Varghese, Vipin
Snipped > Dikshant Chitkara wrote: > > > Hi Team, > > > > We are facing an issue w.r.t to using DPDK PDUMP utility and want to check > > if > you can help us in this regard. > > > > This issue is specific to DPDK 19.05 version or may be newer versions and > was not found on DPDK 18.08 version.

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option

2020-07-21 Thread Ajit Khaparde
On Tue, Jul 21, 2020 at 4:09 PM Ferruh Yigit wrote: > On 7/21/2020 6:47 PM, Ajit Khaparde wrote: > > Add an option in meson build to indicate the memory management scheme. > > bnxt_eem_system is set to false by default. > > > > Signed-off-by: Ajit Khaparde > > <...> > > > --- a/meson_options.txt

Re: [dpdk-dev] [PATCH v3] net/ice: fix incorrect Rx/Tx bytes statistics

2020-07-21 Thread Zhang, Qi Z
> -Original Message- > From: Jiang, JunyuX > Sent: Tuesday, July 21, 2020 3:20 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Jiang, JunyuX ; > sta...@dpdk.org > Subject: [PATCH v3] net/ice: fix incorrect Rx/Tx bytes statistics > > This patch fixed the issue that rx/tx byte

Re: [dpdk-dev] [PATCH] net/ice: fix default RSS key configuration

2020-07-21 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Xiao W > Sent: Tuesday, July 21, 2020 5:03 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; Yao, Lei A > ; Wu, Jingjing ; Wang, Xiao W > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix default RSS key configuration > > There's chance that rt

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table

2020-07-21 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Shougang Wang > Sent: Tuesday, July 21, 2020 1:49 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > ShougangX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table > > The hash look up tabl

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table

2020-07-21 Thread Jeff Guo
hi, shougang On 7/21/2020 2:41 PM, Xie, WeiX wrote: Tested-by: Zhang, XiX Regards, Xie Wei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shougang Wang Sent: Tuesday, July 21, 2020 1:49 PM To: dev@dpdk.org Cc: Xing, Beilei ; Guo, Jia ; Wang, ShougangX ; sta.

[dpdk-dev] [PATCH v3 1/2] net/i40e: fix binding interrupt without msix vectors

2020-07-21 Thread Jiang Mao
The value of vsi->nb_msix shouldn`t be zero, otherwise, all of interrupts will be bind to vector 0. Fixes: 4861cde461 (i40e: new poll mode driver) Cc: sta...@dpdk.org Signed-off-by: Jiang Mao --- V3: fix format issue. --- drivers/net/i40e/i40e_ethdev.c | 31 +++ driv

[dpdk-dev] [PATCH v3 2/2] net/i40e: fix fdir allocating msix resource error

2020-07-21 Thread Jiang Mao
Fdir allocating msix resource is not strictly necessary, if no resource left, jump the error. Fixes: 4861cde461 (i40e: new poll mode driver) Cc: sta...@dpdk.org Signed-off-by: Jiang Mao --- V3: Move type I40E_VSI_FDIR branch into !I40E_VSI_SRIOV branch. --- drivers/net/i40e/i40e_ethdev.c | 10 +

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table

2020-07-21 Thread Wang, ShougangX
Hi, Qi > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 22, 2020 1:31 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > ShougangX ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table > > > > > --

Re: [dpdk-dev] [PATCH] lib/librte_eal: support SVE flag on ARM64

2020-07-21 Thread Ruifeng Wang
Hi Xavier, > -Original Message- > From: Wei Hu (Xavier) > Sent: Saturday, July 18, 2020 10:18 AM > To: Honnappa Nagarahalli ; > dev@dpdk.org > Cc: nd ; Ruifeng Wang ; Wei Hu > (Xavier) > Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal: support SVE flag on ARM64 > > Hi, Honnappa Nagarahal

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table

2020-07-21 Thread Wang, ShougangX
Hi, Jeff > -Original Message- > From: Guo, Jia > Sent: Wednesday, July 22, 2020 1:51 PM > To: Xie, WeiX ; Wang, ShougangX > ; dev@dpdk.org > Cc: Xing, Beilei ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table > > hi, shougang > > On 7/21/20

[dpdk-dev] [RFC v2 1/3] ethdev: add a field for rte_eth_rxq_info

2020-07-21 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in recieving pkts for hw. Signed-off-by: Chengchang Tang Acked-by: Andrew Rybchenko --- v1->v2: modify the name and add more comments. --- lib/librte_ethdev/rte_ethdev.h | 2 ++ 1 file changed, 2 insertions(+) d

[dpdk-dev] [RFC v2 2/3] net/hns3: add support for query of rx/tx queue info

2020-07-21 Thread Chengchang Tang
From: Huisong Li This patch adds support for query of rx/tx queue info for hns3. And the new field rx_buf_size in rte_eth_rxq_info is also filled. Signed-off-by: Huisong Li Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 2 ++ drivers/net/

[dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info

2020-07-21 Thread Chengchang Tang
In common practice, PMD configure the rx buffer size which indicate the buffer length could be used for hw in receiving packts according to the data room size of the object in mempool. But in fact the final value is related to the specifications of hw, and its values will affect the number of fragm

[dpdk-dev] [RFC v2 3/3] app/testpmd: Add RX buffer size dispaly in queue info querry

2020-07-21 Thread Chengchang Tang
Add RX buffer size to queue info querry cmd so that the user can get the buffer length used by hw queue for receiving packets. Signed-off-by: Chengchang Tang --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 30bee33.

<    1   2