Hi, Qi > -----Original Message----- > From: Zhang, Qi Z <qi.z.zh...@intel.com> > Sent: Wednesday, July 22, 2020 1:31 PM > To: Wang, ShougangX <shougangx.w...@intel.com>; dev@dpdk.org > Cc: Xing, Beilei <beilei.x...@intel.com>; Guo, Jia <jia....@intel.com>; Wang, > ShougangX <shougangx.w...@intel.com>; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table > > > > > -----Original Message----- > > From: dev <dev-boun...@dpdk.org> On Behalf Of Shougang Wang > > Sent: Tuesday, July 21, 2020 1:49 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei <beilei.x...@intel.com>; Guo, Jia > > <jia....@intel.com>; Wang, ShougangX <shougangx.w...@intel.com>; > > sta...@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up > > table > > > > The hash look up table(LUT) will not be initializing when starting > > testpmd with --disable-rss. So that some invalid queue indexes may > > still in the LUT. When enable RSS by creating RSS rule, some packets will > > not > be into the valid queues. > > This patch fixes this issue by initializing the LUT when creating an RSS > > rule. > > Could you explain why you only initialize the LUT when creating an RSS rule > but not at dev_init or dev_start? It is good to initialize the LUT at dev_start, I will fix it.
> What if user configure LUT table before create a RSS rule? Does that mean > the LUT table will be flushed? Yes. Thanks. Shougang