[dpdk-dev] [PATCH] net/ice/base: free memory for GTP-U before return status

2020-07-20 Thread Junfeng Guo
Add memory space free logic for adding and removing GTP-U before return success status, to aviod memory leak issue. Fixes: bed9bb3139ef ("net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist") Signed-off-by: Junfeng Guo --- drivers/net/ice/base/ice_flow.c | 12 1 file changed, 8 in

Re: [dpdk-dev] [PATCH v2] net/mlx5: add queue start and stop feature

2020-07-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Sunday, July 19, 2020 6:36 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon > Subject: [PATCH v2] net/mlx5: add queue start and stop feature > > The mlx5 PMD did not support queue_start and queue

Re: [dpdk-dev] [PATCH v10 0/3] generic rte atomic APIs deprecate proposal

2020-07-20 Thread Phil Yang
> -Original Message- > From: David Marchand > Sent: Friday, July 17, 2020 9:59 PM > To: Phil Yang > Cc: tho...@monjalon.net; dev ; Mcnamara, John > ; Honnappa Nagarahalli > ; David Christensen > ; jer...@marvell.com; Ananyev, Konstantin > ; Ola Liljedahl ; > Bruce Richardson ; Ruifeng Wan

[dpdk-dev] [PATCH] net/ice/base: free memory for GTP-U before return status

2020-07-20 Thread Junfeng Guo
Add memory space free logic for adding and removing GTP-U before return success status, to avoid memory leak issue. v2: - fix small typo in commit message. Fixes: bed9bb3139ef ("net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist") Signed-off-by: Junfeng Guo --- drivers/net/ice/base/ice_flow.

Re: [dpdk-dev] [dts] [PATCH] speed-capabilities: added Speed Capabilities test case

2020-07-20 Thread Tu, Lijuan
Applied, thanks > -Original Message- > From: dts On Behalf Of dkiric...@iol.unh.edu > Sent: 2020年7月7日 21:41 > To: d...@dpdk.org > Cc: m...@smartsharesystems.com; lylav...@iol.unh.edu; tho...@monjalon.net; > dev@dpdk.org; david.march...@redhat.com; Yigit, Ferruh > ; arybche...@solarflare.c

Re: [dpdk-dev] [PATCH] net/mlx5: fix file path location of HW counters

2020-07-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Shy Shyman > Sent: Wednesday, July 15, 2020 1:51 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix file path location of HW counters > > When debugging performance of a DPDK applicat

Re: [dpdk-dev] [PATCH] net/mlx5: fix push VLAN action on hairpin queue

2020-07-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Wednesday, July 15, 2020 10:31 AM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix push VLAN action on hairpin queue > > Push VLAN action is allowed on Tx on

Re: [dpdk-dev] [PATCH] net/mlx5: fix pop VLAN with decap action validate

2020-07-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Wednesday, July 15, 2020 10:31 AM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix pop VLAN with decap action validate > > The combination of decap action fo

Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel PMD flow prioriry

2020-07-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Thursday, July 16, 2020 10:40 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Shahaf Shuler ; Slava Ovsiienko > ; Ori Kam ; Yongseok > Koh > Subject: [PATCH] net/mlx5: fix tunnel

Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build

2020-07-20 Thread David Marchand
On Sun, Jul 19, 2020 at 5:17 PM Raslan Darawsheh wrote: > > @@ -15,6 +16,7 @@ > > #include > > > > #include "mlx5_glue.h" > > +#include "../mlx5_malloc.h" > > > > static int > > mlx5_glue_fork_init(void) > > -- > > 2.27.0 > > > Patch squashed into relevant commit in master-net-mlx, Raslan,

Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build

2020-07-20 Thread Raslan Darawsheh
Hi David, Yes I noticed it already, but it's coming from the fact that it's trying to apply it on a tree that doesn't have the patch which this patch is trying to fix. ../drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error: '../mlx5_malloc.h' file not found #include "../mlx5_malloc.h"

Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build

2020-07-20 Thread David Marchand
On Mon, Jul 20, 2020 at 10:38 AM Raslan Darawsheh wrote: > > Hi David, > > Yes I noticed it already, > but it's coming from the fact that it's trying to apply it on a tree that > doesn't have the patch which this patch is trying to fix. > > ../drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal er

Re: [dpdk-dev] [PATCH v8 1/4] eal: add WC store functions

2020-07-20 Thread Nicolau, Radu
On 7/20/2020 7:42 AM, Ruifeng Wang wrote: -Original Message- From: Radu Nicolau Sent: Friday, July 17, 2020 6:50 PM To: dev@dpdk.org Cc: beilei.x...@intel.com; jia@intel.com; bruce.richard...@intel.com; konstantin.anan...@intel.com; jerinjac...@gmail.com; david.march...@redhat.com;

Re: [dpdk-dev] [PATCH v8 2/4] net/i40e: use WC store to update queue tail registers

2020-07-20 Thread Nicolau, Radu
On 7/20/2020 7:46 AM, Ruifeng Wang wrote: -Original Message- From: Radu Nicolau Sent: Friday, July 17, 2020 6:50 PM To: dev@dpdk.org Cc: beilei.x...@intel.com; jia@intel.com; bruce.richard...@intel.com; konstantin.anan...@intel.com; jerinjac...@gmail.com; david.march...@redhat.com;

Re: [dpdk-dev] [DPDK] net/i40e: add the VLAN capabilities of NIC

2020-07-20 Thread Jeff Guo
hi,  zhihong On 7/20/2020 10:42 AM, zhihongx.p...@intel.com wrote: From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check whether the NIC has the set vlan feature. If it has not, it will return failure. So need "...has the set vlan feature..." , that need to refine. to a

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-20 Thread Gaëtan Rivet
On 19/07/20 14:17 +0530, Jerin Jacob wrote: > On Sun, Jul 19, 2020 at 1:12 AM Manish Chopra wrote: > > > > > -Original Message- > > > From: dev On Behalf Of Manish Chopra > > > Sent: Friday, July 17, 2020 2:19 AM > > > To: Gaëtan Rivet ; Thomas Monjalon > > > > > > Cc: Jerin Jacob ; Ferr

Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build

2020-07-20 Thread Raslan Darawsheh
> -Original Message- > From: David Marchand > Sent: Monday, July 20, 2020 11:52 AM > To: Raslan Darawsheh > Cc: Ali Alnubani ; dev@dpdk.org; Suanming Mou > ; Yigit, Ferruh ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build > > On Mon, Jul 20, 2020 at 10:38

[dpdk-dev] [PATCH] net/mlx5: fix the compatibility with MISC4

2020-07-20 Thread Bing Zhao
When eCPRI offloading is introduced, the support for misc parameters 4 of flow table entry (FTE) match set is needed. The structure of "mlx5_ifc_fte_match_param_bits" is extended with "mlx5_ifc_fte_match_set_misc4_bits" at the end of it. The total size of the FTE match set will be changed into 384

[dpdk-dev] [PATCH v9 2/4] net/i40e: use WC store to update queue tail registers

2020-07-20 Thread Radu Nicolau
Performance improvement: use a write combining store instead of a regular mmio write to update queue tail registers. Signed-off-by: Radu Nicolau Acked-by: Bruce Richardson --- drivers/net/i40e/base/i40e_osdep.h| 5 + drivers/net/i40e/i40e_rxtx.c | 8 drivers/net/i40e/i

[dpdk-dev] [PATCH v9 0/4] eal: add WC store functions

2020-07-20 Thread Radu Nicolau
Implement 2 new functions that will enable write combining stores depending on architecture. The functions are provided as a generic stub and a x86 specific implementation. The reason to implement these functions is to improve performance by reducing the overhead associated with regular mmio write

[dpdk-dev] [PATCH v9 3/4] common/qat: use WC store to update queue tail registers

2020-07-20 Thread Radu Nicolau
Performance improvement: use a write combining store instead of a regular mmio write to update queue tail registers. Signed-off-by: Radu Nicolau Acked-by: Fiona Trahe --- drivers/common/qat/qat_adf/adf_transport_access_macros.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v9 1/4] eal: add WC store functions

2020-07-20 Thread Radu Nicolau
Add rte_write32_wc and rte_write32_wc_relaxed functions that implement 32bit stores using write combining memory protocol. Provided generic stubs and x86 implementation. Signed-off-by: Radu Nicolau Acked-by: Bruce Richardson --- lib/librte_eal/arm/include/rte_io_64.h | 12 +++ lib/librte_e

[dpdk-dev] [PATCH v9 4/4] net/ixgbe: use WC store to update queue tail registers

2020-07-20 Thread Radu Nicolau
Performance improvement: use a write combining store instead of a regular mmio write to update queue tail registers. Signed-off-by: Radu Nicolau Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/base/ixgbe_osdep.h | 6 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 15 --- driv

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: enable rte_flow based packet distribution

2020-07-20 Thread Akhil Goyal
> From: Anoob Joseph > > RTE_FLOW API allows hardware parsing and steering of packets to specific > queues which helps in distributing ingress traffic across various cores. > Adding 'flow' rules allows user to specify the distribution required. > > Signed-off-by: Anoob Joseph > Acked-by: Akhil

[dpdk-dev] [dpdk-dev v1] net/ice: fix symmetric hash configuration

2020-07-20 Thread Jeff Guo
Some protocol don't support symmetric hash, need to handle these cases. When set an invalid symmetric hash rule, just return failed. Fixes: 7d0824387e63 ("net/ice: fix invalid RSS type") Signed-off-by: Jeff Guo --- drivers/net/ice/ice_hash.c | 13 - 1 file changed, 12 insertions(+),

Re: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases

2020-07-20 Thread Akhil Goyal
Hi All, > blockcipher cases are either returning TEST_SUCCESS > or TEST_FAILED as status, but the test may not be > supported by the PMD which is also a success case > for the PMD. Hence checking for status == TEST_FAILED > for setting the overall status as failed. > > Signed-off-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v2 2/7] drivers: add generic API to find PCI extended cap

2020-07-20 Thread Gaëtan Rivet
On 13/07/20 08:13 -0700, Manish Chopra wrote: > By adding generic API, this patch removes individual > functions/defines implemented by drivers to find PCI > extended capability. > > Signed-off-by: Manish Chopra > Signed-off-by: Igor Russkikh > --- > drivers/bus/pci/pci_common.c |

Re: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases

2020-07-20 Thread Bruce Richardson
On Mon, Jul 20, 2020 at 09:27:57AM +, Akhil Goyal wrote: > Hi All, > > > blockcipher cases are either returning TEST_SUCCESS > > or TEST_FAILED as status, but the test may not be > > supported by the PMD which is also a success case > > for the PMD. Hence checking for status == TEST_FAILED > >

Re: [dpdk-dev] [PATCH v2] net/ice: fix incorrect Rx/Tx bytes statistics

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: Jiang, JunyuX > Sent: Friday, July 17, 2020 10:18 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Jiang, JunyuX ; > sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix incorrect Rx/Tx bytes statistics > > This patch fixed the issue that rx/tx byte

Re: [dpdk-dev] [PATCH v3] net/i40e: fix fdir cannot receive rx writeback issue

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Friday, July 17, 2020 10:48 PM > To: Sun, Chenmin ; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] net/i40e: fix fdir cannot receive rx writeback issue > > > > > -Original Message- > > From: Sun, Chenmin > > Sent

Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

2020-07-20 Thread Ferruh Yigit
On 7/19/2020 9:10 PM, Thomas Monjalon wrote: > 17/07/2020 13:36, Ferruh Yigit: >> On 7/11/2020 9:17 AM, Hemant Agrawal wrote: >>> DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. >>> There are two ways to control it. >>> 1. Statically configure the queues and classification rules bef

Re: [dpdk-dev] [PATCH v2 0/2] fix MAC ctrl frame fwd get

2020-07-20 Thread Zhao1, Wei
Reviewed-by: Wei Zhao > -Original Message- > From: Sun, GuinanX > Sent: Saturday, May 23, 2020 1:23 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Yang, Qiming > ; Sun, GuinanX > Subject: [PATCH v2 0/2] fix MAC ctrl frame fwd get > > Fix incorrect MAC control frame forward. > Fix flow contr

Re: [dpdk-dev] [PATCH] net/ice/base: free memory for GTP-U before return status

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Monday, July 20, 2020 3:10 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > ; Su, Simei > Subject: [PATCH] net/ice/base: free memory for GTP-U before return status > > Add memory space free logic for a

Re: [dpdk-dev] [PATCH] net/i40e: fix missed i40e filter pctype

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Zhao1, Wei > Sent: Friday, July 17, 2020 3:30 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > ShougangX ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix missed i40e filter pctype > > Reviewed

[dpdk-dev] [PATCH] test/eal: check invalid cpu value

2020-07-20 Thread Kevin Traynor
When using --lcores option, there is a limit of CPU_SETSIZE. Currently that allows 0..1023 on Linux. Check it is caught when this limit is exceeded. Signed-off-by: Kevin Traynor --- app/test/test_eal_flags.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/test_e

Re: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases

2020-07-20 Thread Ankur Dwivedi
>-Original Message- >From: Akhil Goyal >Sent: Monday, July 20, 2020 2:58 PM >To: asoma...@amd.com; Anoob Joseph ; >roy.fan.zh...@intel.com; fiona.tr...@intel.com; Nagadheeraj Rottela >; Ankur Dwivedi ; >jianjay.z...@huawei.com; pablo.de.lara.gua...@intel.com; >adamx.dybkow...@intel.com;

[dpdk-dev] [PATCH v2] test/eal: check invalid cpu value

2020-07-20 Thread Kevin Traynor
When using --lcores option, there is a limit of CPU_SETSIZE. Currently that allows 0..1023 on Linux. Check it is caught when this limit is exceeded. Signed-off-by: Kevin Traynor --- app/test/test_eal_flags.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/test_e

Re: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases

2020-07-20 Thread Akhil Goyal
> >Hi All, > > > >> blockcipher cases are either returning TEST_SUCCESS or TEST_FAILED as > >> status, but the test may not be supported by the PMD which is also a > >> success case for the PMD. Hence checking for status == TEST_FAILED for > >> setting the overall status as failed. > >> > >> Signed

Re: [dpdk-dev] [PATCH] test/eal: check invalid cpu value

2020-07-20 Thread Kevin Traynor
On 09/07/2020 00:04, Lukasz Wojciechowski wrote: > > W dniu 12.06.2020 o 14:09, Kevin Traynor pisze: >> When using --lcores option, CPU_SETSIZE allows a range of >> 0-1023. Check it is not being exceeded. >> >> Signed-off-by: Kevin Traynor >> --- >> app/test/test_eal_flags.c | 6 +- >> 1 f

Re: [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio threshold per core

2020-07-20 Thread Sexton, Rory
Thanks for merge and thanks for feedback for next contribution. > > Series applied with minor changes and doc squashed. > > 2 more comments for next contributions: > - use a cover letter if there are multiple patches > - please use --in-reply-to to thread all versions with the first one

Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource error

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Jiang Mao > Sent: Thursday, July 9, 2020 3:53 AM > To: Ye, Xiaolong > Cc: dev@dpdk.org; sta...@dpdk.org; Jiang, MaoX > Subject: [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource > error > > Fdir allocating msix resource

Re: [dpdk-dev] [PATCH v2 0/2] fix MAC ctrl frame fwd get

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Saturday, May 23, 2020 1:23 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Yang, Qiming > ; Sun, GuinanX > Subject: [dpdk-dev] [PATCH v2 0/2] fix MAC ctrl frame fwd get > > Fix incorrect MAC control frame forward. > Fix flow c

Re: [dpdk-dev] [PATCH v2] test/eal: check invalid cpu value

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 12:19, Kevin Traynor pisze: > When using --lcores option, there is a limit of CPU_SETSIZE. > Currently that allows 0..1023 on Linux. > > Check it is caught when this limit is exceeded. > > Signed-off-by: Kevin Traynor > --- > app/test/test_eal_flags.c | 5 - > 1 file c

Re: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport bandwidth profile

2020-07-20 Thread Dumitrescu, Cristian
> -Original Message- > From: dev On Behalf Of Savinay Dharmappa > Sent: Wednesday, July 15, 2020 7:28 PM > To: Dharmappa, Savinay ; Singh, Jasvinder > ; dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport > bandwidth profile > > This patch modifies t

Re: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport bandwidth profile

2020-07-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Monday, July 20, 2020 12:21 PM > To: Savinay Dharmappa ; Dharmappa, > Savinay ; Singh, Jasvinder > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of > subport bandwidth profile > > > > >

[dpdk-dev] [PATCH v6 1/3] telemetry: support array values in data objects

2020-07-20 Thread Ciara Power
Arrays of type uint64_t/int/string can now be included within an array or dict. One level of embedded containers is supported. This is necessary to allow for instances such as the ethdev queue stats to be reported as a list of uint64_t values, rather than having multiple dict entries with one uint6

[dpdk-dev] [PATCH v6 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-20 Thread Ciara Power
From: Louise Kilheeney This patch adds tests for verifying telemetry data structures are converted to JSON as expected. Both flat and recursive data structures are tested, for all possible value types. The app connects to the telemetry socket as a client, and registers one command with a corresp

[dpdk-dev] [PATCH v6 0/3] add basic ethdev stats with data object recursion

2020-07-20 Thread Ciara Power
v6: - Fixed FreeBSD build failure for unit tests. - Added comments and expanded commit log. - Add loop to call test cases stored in a list. v5: Added unit tests for telemetry data to JSON conversion. v4: Added missing param description to Doxygen comment. v3: - Modified commit logs. - Cha

[dpdk-dev] [PATCH v6 3/3] ethdev: add common stats for telemetry

2020-07-20 Thread Ciara Power
The ethdev library now registers a telemetry command for common ethdev statistics. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.08.0-rc1", "pid": 14119, "max_output_len": 16384} --> /ethdev/stats,0 {"/ethdev/stats": {"ipackets": 0, "opack

Re: [dpdk-dev] [PATCH 2/2] doc: add deprecation notice for change of rawdev APIs

2020-07-20 Thread Ananyev, Konstantin
> Add to the documentation for 20.08 a notice about the changes of rawdev > APIs proposed by patchset [1]. > > [1] > http://inbox.dpdk.org/dev/20200709152047.167730-1-bruce.richard...@intel.com/ > > Cc: Nipun Gupta > Cc: Hemant Agrawal > > Signed-off-by: Bruce Richardson > --- > doc/guide

Re: [dpdk-dev] [PATCH 1/1] eal/linux: do not create user mem map repeatedly when it exists

2020-07-20 Thread Burakov, Anatoly
On 20-Jul-20 3:00 AM, wangyunjian wrote: -Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Friday, July 17, 2020 10:24 PM To: wangyunjian ; dev@dpdk.org; david.march...@redhat.com Cc: Lilijun (Jerry) ; xudingke ; sta...@dpdk.org Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v3 8/8] crypto/octeontx2: add cryptodev sec enqueue and dequeue routines

2020-07-20 Thread Ferruh Yigit
On 7/16/2020 9:39 AM, Tejasree Kondoj wrote: > From: Vamsi Attunuru > > This patch adds lookaside IPsec enqueue and dequeue routines. > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Tejasree Kondoj <...> > @@ -33,6 +34,13 @@ struct otx2_cpt_vf { > /**< CPT device capabilities */ >

[dpdk-dev] [PATCH] service: fix stop API to wait for service thread

2020-07-20 Thread Harry van Haaren
This commit improves the service_lcore_stop() implementation, waiting for the service core in question to return. The service thread itself now has a variable to indicate if its thread is active. When zero the service thread has completed its service, and has returned from the service_runner_func()

Re: [dpdk-dev] Random failure in service_autotest

2020-07-20 Thread Van Haaren, Harry
> -Original Message- > From: Phil Yang > Sent: Saturday, July 18, 2020 9:34 AM > To: Aaron Conole ; Lukasz Wojciechowski > > Cc: David Marchand ; Van Haaren, Harry > ; Igor Romanov ; > Honnappa Nagarahalli ; dev > ; Yigit, Ferruh ; nd ; nd > > Subject: RE: [dpdk-dev] Random failure in se

Re: [dpdk-dev] [PATCH] net/mlx5: fix the compatibility with MISC4

2020-07-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, July 20, 2020 12:04 PM > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix the compatibility with MISC4 > > When eCPRI offloading is introduced, the support fo

Re: [dpdk-dev] [PATCH v9 1/4] eal: add WC store functions

2020-07-20 Thread David Marchand
On Mon, Jul 20, 2020 at 11:12 AM Radu Nicolau wrote: > > Add rte_write32_wc and rte_write32_wc_relaxed functions > that implement 32bit stores using write combining memory protocol. > Provided generic stubs and x86 implementation. What is the difference of using this new API when compared to the

Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build

2020-07-20 Thread David Marchand
On Mon, Jul 20, 2020 at 10:59 AM Raslan Darawsheh wrote: > > > Yes I noticed it already, > > > but it's coming from the fact that it's trying to apply it on a tree that > > > doesn't > > have the patch which this patch is trying to fix. > > > > > > ../drivers/common/mlx5/linux/mlx5_glue.c:19:10:

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-20 Thread Burakov, Anatoly
On 18-Jul-20 3:22 AM, Stephen Hemminger wrote: On Fri, 17 Jul 2020 16:21:37 +0100 "Burakov, Anatoly" wrote: On 16-Jul-20 11:04 PM, Stephen Hemminger wrote: On Thu, 16 Jul 2020 14:41:41 +0100 "Burakov, Anatoly" wrote: On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: On Wed, 15 Jul 2020 14

Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_mb: improve security instance setup

2020-07-20 Thread Coyle, David
Hi Pablo > -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 17, 2020 8:29 PM > > > > #ifdef AESNI_MB_DOCSIS_SEC_ENABLED > > + struct rte_security_ctx *security_instance; > > security_instance = rte_malloc("aesni_mb_sec", > > sizeof(s

Re: [dpdk-dev] [PATCH v1 1/2] crypto/qat: improve security instance setup

2020-07-20 Thread Coyle, David
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Saturday, July 18, 2020 10:41 PM > > > > This patch makes some minor improvements to the security instance > > > > setup for the QAT SYM PMD. All of this setup code is now in one > > > > '#ifdef RTE_LIBRTE_SECURITY' block. Enablin

[dpdk-dev] [PATCH v2 0/2] improve security instance setup

2020-07-20 Thread David Coyle
These patches make some improvements to the security instance setup for the QAT SYM and AESNI-MB PMDs. David Coyle (2): crypto/qat: improve security instance setup crypto/aesni-mb: improve security instance setup drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 18 +- drivers/crypto/qat/

[dpdk-dev] [PATCH v2 1/2] crypto/qat: improve security instance setup

2020-07-20 Thread David Coyle
This patch makes some improvements to the security instance setup for the QAT SYM PMD, as follows: - fix potential memory leak where the security instance was not freed if an error occurred later in the device creation - tidy-up security instance initialization code by moving it all, including

[dpdk-dev] [PATCH v2 2/2] crypto/aesni-mb: improve security instance setup

2020-07-20 Thread David Coyle
This patch makes some improvements to the security instance setup for the AESNI-MB PMD, as follows: - fix potential memory leak where the security instance was not freed if an error occurred later in the device creation - tidy-up security instance initialization code by moving it all, including

Re: [dpdk-dev] Random failure in service_autotest

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 14:09, Van Haaren, Harry pisze: >> -Original Message- >> From: Phil Yang >> Sent: Saturday, July 18, 2020 9:34 AM >> To: Aaron Conole ; Lukasz Wojciechowski >> >> Cc: David Marchand ; Van Haaren, Harry >> ; Igor Romanov ; >> Honnappa Nagarahalli ; dev >> ; Yigit, Fer

Re: [dpdk-dev] [PATCH] service: fix stop API to wait for service thread

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 14:09, Harry van Haaren pisze: > This commit improves the service_lcore_stop() implementation, > waiting for the service core in question to return. The service > thread itself now has a variable to indicate if its thread is > active. When zero the service thread has completed

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-20 Thread Fady Bader
> > > Subject: Re: [PATCH v2 3/3] eal/windows: librte_net build on Windows > > > > > > > diff --git a/lib/librte_eal/common/meson.build > > > > b/lib/librte_eal/common/meson.build > > > > index e1bdaf024..05e40a26b 100644 > > > > --- a/lib/librte_eal/common/meson.build > > > > +++ b/lib/librte_ea

Re: [dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests

2020-07-20 Thread Coyle, David
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 17, 2020 8:04 PM > > @@ -48,6 +48,10 @@ cperf_set_ops_security(struct rte_crypto_op **ops, > > } else > > buf_sz = options->test_buffer_size; > > > > +

[dpdk-dev] Intel I350 support in DPDK 17.11

2020-07-20 Thread siddarth rai
Hi, I am using DPDK 17.11 in my application. I am facing an RX issue when running the application with an intel I350 NIC. Details of the NIC: driver: igb version: 5.4.0-k* firmware-version: 1.63, 0x8d58, 1.1099.0 Kernel - 3.10.0-957.5.1.el7.x86_64 >From the release notes, I found out that th

Re: [dpdk-dev] [PATCH v6 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-20 Thread Bruce Richardson
On Mon, Jul 20, 2020 at 12:19:06PM +0100, Ciara Power wrote: > From: Louise Kilheeney > > This patch adds tests for verifying telemetry data structures are > converted to JSON as expected. Both flat and recursive data structures > are tested, for all possible value types. > > The app connects to

Re: [dpdk-dev] [PATCH v6 0/2] introduce asynchronous data path for vhost

2020-07-20 Thread Maxime Coquelin
Hi Patrick, Thanks for the series. I think we miss a chapter in the Vhost lib documentation to explain what this new API is about. Do you think you can write something by -rc3? Thanks in advance, Maxime On 7/7/20 7:07 AM, patrick...@intel.com wrote: > From: Patrick Fu > > Performing large mem

Re: [dpdk-dev] [PATCH 1/2] doc: add deprecation notice for make build system removal

2020-07-20 Thread Ferruh Yigit
On 7/13/2020 1:31 PM, Bruce Richardson wrote: > Add in an official notice that the make build system is being removed in > 20.11 and provide a link to instructions on how to build using meson and > ninja instead. > > Cc: Thomas Monjalon > > Signed-off-by: Bruce Richardson > --- > doc/guides/re

Re: [dpdk-dev] [PATCH 1/2] doc: add deprecation notice for make build system removal

2020-07-20 Thread Andrew Rybchenko
On 7/20/20 4:28 PM, Ferruh Yigit wrote: > On 7/13/2020 1:31 PM, Bruce Richardson wrote: >> Add in an official notice that the make build system is being removed in >> 20.11 and provide a link to instructions on how to build using meson and >> ninja instead. >> >> Cc: Thomas Monjalon >> >> Signed-o

[dpdk-dev] [PATCH v7 1/3] telemetry: support array values in data objects

2020-07-20 Thread Ciara Power
Arrays of type uint64_t/int/string can now be included within an array or dict. One level of embedded containers is supported. This is necessary to allow for instances such as the ethdev queue stats to be reported as a list of uint64_t values, rather than having multiple dict entries with one uint6

[dpdk-dev] [PATCH v7 0/3] add basic ethdev stats with data object recursion

2020-07-20 Thread Ciara Power
v7: - Simplified connecting to socket by removing use of glob. - Fixed buffer overflow issue when reading from socket. - Split expected response strings over multiple lines. v6: - Fixed FreeBSD build failure for unit tests. - Added comments and expanded commit log. - Add loop to call te

[dpdk-dev] [PATCH v7 3/3] ethdev: add common stats for telemetry

2020-07-20 Thread Ciara Power
The ethdev library now registers a telemetry command for common ethdev statistics. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.08.0-rc1", "pid": 14119, "max_output_len": 16384} --> /ethdev/stats,0 {"/ethdev/stats": {"ipackets": 0, "opack

[dpdk-dev] [PATCH v7 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-20 Thread Ciara Power
From: Louise Kilheeney This patch adds tests for verifying telemetry data structures are converted to JSON as expected. Both flat and recursive data structures are tested, for all possible value types. The app connects to the telemetry socket as a client, and registers one command with a corresp

Re: [dpdk-dev] [PATCH v3 07/17] net/mlx5: create Tx queues with DevX

2020-07-20 Thread Ferruh Yigit
On 7/16/2020 9:23 AM, Viacheslav Ovsiienko wrote: > To provide the packet send schedule on mbuf timestamp the Tx > queue must be attached to the same UAR as Clock Queue is. > UAR is special hardware related resource mapped to the host > memory and provides doorbell registers, the assigning UAR > to

Re: [dpdk-dev] [PATCH] service: fix stop API to wait for service thread

2020-07-20 Thread Van Haaren, Harry
> -Original Message- > From: Lukasz Wojciechowski > Sent: Monday, July 20, 2020 1:52 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: david.march...@redhat.com; igor.roma...@oktetlabs.ru; > honnappa.nagaraha...@arm.com; Yigit, Ferruh ; > n...@arm.com; acon...@redhat.com > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v7 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-20 Thread Bruce Richardson
On Mon, Jul 20, 2020 at 03:04:02PM +0100, Ciara Power wrote: > From: Louise Kilheeney > > This patch adds tests for verifying telemetry data structures are > converted to JSON as expected. Both flat and recursive data structures > are tested, for all possible value types. > > The app connects to

Re: [dpdk-dev] Intel I350 support in DPDK 17.11

2020-07-20 Thread siddarth rai
+ igb maintainer On Mon, Jul 20, 2020 at 6:29 PM siddarth rai wrote: > Hi, > > I am using DPDK 17.11 in my application. I am facing an RX issue when > running the application with an intel I350 NIC. > Details of the NIC: > driver: igb > version: 5.4.0-k* > firmware-version: 1.63, 0x8d58, 1.1

[dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on stopping lcore

2020-07-20 Thread Harry van Haaren
This commit fixes a potential race condition in the tests where the lcore running a service would increment a counter that was already reset by the test-suite thread. The resulting race-condition incremented value could cause CI failures, as indicated by DPDK's CI. This patch fixes the race-condit

[dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-20 Thread Harry van Haaren
This commit adds a new experimental API which allows the user to retrieve the active state of an lcore. Knowing when the service lcore is completed its polling loop can be useful to applications to avoid race conditions when e.g. finalizing statistics. The service thread itself now has a variable

Re: [dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue

2020-07-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Xu, Ting > Sent: Thursday, July 9, 2020 2:48 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Xu, Ting > ; sta...@dpdk.org > Subject: [PATCH v3] lib/table: fix cache alignment issue > > When create softnic hash table with 16 keys, it failed on 32bit > env

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-20 Thread Maxime Coquelin
Hi Patrick, On 7/15/20 1:15 PM, patrick...@intel.com wrote: > From: Patrick Fu > > Vhost async enqueue assumes that all async copies should break at packet > boundary. i.e. if a packet is splited into multiple copy segments, the > async engine should always report copy completion when entire pac

Re: [dpdk-dev] [PATCH v3 07/17] net/mlx5: create Tx queues with DevX

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 3:18 PM, Ferruh Yigit wrote: > On 7/16/2020 9:23 AM, Viacheslav Ovsiienko wrote: >> To provide the packet send schedule on mbuf timestamp the Tx >> queue must be attached to the same UAR as Clock Queue is. >> UAR is special hardware related resource mapped to the host >> memory and pro

[dpdk-dev] Using C11 atomic semantic

2020-07-20 Thread Thomas Monjalon
In the techboard of April 22, it has been decided to block patches using rte_atomicNN_xx and rte_smp_*mb APIs, starting DPDK 20.08. Meeting minutes: http://mails.dpdk.org/archives/dev/2020-April/165143.html Deprecation notice: http://doc.dpdk.org/guides/rel_notes/deprecation.html S

Re: [dpdk-dev] Using C11 atomic semantic

2020-07-20 Thread Honnappa Nagarahalli
+Ruifeng > -Original Message- > From: Thomas Monjalon > Sent: Monday, July 20, 2020 10:34 AM > To: Honnappa Nagarahalli > Cc: ferruh.yi...@intel.com; david.march...@redhat.com; dev@dpdk.org; Phil > Yang ; techbo...@dpdk.org > Subject: Using C11 atomic semantic > > In the techboard of Ap

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-20 Thread Maxime Coquelin
Do you agree with below title? vhost: fix double-free with zero-copy Thanks, Maxime On 7/15/20 5:58 PM, patrick...@intel.com wrote: > From: Patrick Fu > > zmbufs should be set to NULL when getting freed to avoid double free on > the same buffer pointer > > Fixes: b0a985d1f340 ("vhost: add dequ

Re: [dpdk-dev] [PATCH v2] vhost: fix missing null dev pointer check

2020-07-20 Thread Maxime Coquelin
What about below title (we try to avoid passing variable names in commit titles)? vhost: fix missing device pointer validity check On 7/16/20 5:37 PM, patrick...@intel.com wrote: > From: Patrick Fu > > This patch adds the check of dev pointer in vhost async enqueue > completion poll. If a NULL d

Re: [dpdk-dev] [PATCH v1] vhost: add vq status check in async enqueue poll

2020-07-20 Thread Maxime Coquelin
What about this commit title? vhost: fix missing virtqueue status check in async path On 7/16/20 5:30 PM, patrick...@intel.com wrote: > From: Patrick Fu > > Vring should not be touched if vq is disabled. This patch adds the vq > status check in async enqueue polling to avoid accessing to a disab

[dpdk-dev] [PATCH v1] crypto/qat: add DOCSIS performance optimization

2020-07-20 Thread David Coyle
DOCSIS protocol performance in the downlink direction can be improved significantly in the QAT SYM PMD, especially for larger packets, by pre-processing all CRC generations in a batch before building and enqueuing any requests to the HW. This patch adds this optimization. Fixes: 6f0ef237404b ("cry

[dpdk-dev] [PATCH v1] app/crypto-perf: support security protocol in PMDCC mode

2020-07-20 Thread David Coyle
This patch adds support for DOCSIS and PDCP security protocols to the pmd-cyclecount mode of the crypto performance tool. Adding this support involves freeing the correct session type (i.e. security or cryptodev session) when the test ends, depending on the op_type specificed. Signed-off-by: David

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ferruh Yigit
On 7/17/2020 2:49 PM, Parav Pandit wrote: > Currently mlx5_common uses CLASS priority to initialize > common code before initializing the PMD. > However mlx5_common is not really a class, it is the pre-initialization > code needed for the PMDs. > > In subsequent patch a needed initialization seque

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-20 Thread Dmitry Kozlyuk
On Mon, 20 Jul 2020 12:54:08 +, Fady Bader wrote: [snip] > > Getting the same error with a setup similar to Dmitry's. My setup: SDK > > 10.0.18362, > > I'm sending v4 patch that should resolve this. > > > clang 9.0.0. What version of clang are you using on your system? > > You can try inst

Re: [dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path

2020-07-20 Thread Maxime Coquelin
The title could be improved, it is not very clear IMHO. On 7/20/20 4:52 AM, patrick...@intel.com wrote: > From: Patrick Fu > > Async copy fails when ring buffer cross two physical pages. This patch > fix the failure by letting copies occur in sync mode if crossing page > buffers are given. Woul

Re: [dpdk-dev] Using C11 atomic semantic

2020-07-20 Thread Thomas Monjalon
20/07/2020 17:44, Honnappa Nagarahalli: > From: Thomas Monjalon > > > > In the techboard of April 22, it has been decided to block patches using > > rte_atomicNN_xx and rte_smp_*mb APIs, starting DPDK 20.08. > > Meeting minutes: > > http://mails.dpdk.org/archives/dev/2020-April/165143.html >

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Thomas Monjalon
20/07/2020 18:21, Ferruh Yigit: > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > Currently mlx5_common uses CLASS priority to initialize > > common code before initializing the PMD. > > However mlx5_common is not really a class, it is the pre-initialization > > code needed for the PMDs. > > > > In

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 4:51 PM, Maxime Coquelin wrote: > Do you agree with below title? > vhost: fix double-free with zero-copy Existing commit dropped from next-net and patchwork status updated. > > Thanks, > Maxime > > On 7/15/20 5:58 PM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> zmbufs sh

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 3:58 PM, Maxime Coquelin wrote: > Hi Patrick, > > On 7/15/20 1:15 PM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> Vhost async enqueue assumes that all async copies should break at packet >> boundary. i.e. if a packet is splited into multiple copy segments, the >> async engi

Re: [dpdk-dev] [PATCH v1] vhost: add vq status check in async enqueue poll

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 4:57 PM, Maxime Coquelin wrote: > What about this commit title? > vhost: fix missing virtqueue status check in async path Existing commit dropped from next-net and patchwork status updated. > > On 7/16/20 5:30 PM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> Vring should n

  1   2   >