> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Savinay Dharmappa
> Sent: Wednesday, July 15, 2020 7:28 PM
> To: Dharmappa, Savinay <savinay.dharma...@intel.com>; Singh, Jasvinder
> <jasvinder.si...@intel.com>; dev@dpdk.org
> Subject: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport
> bandwidth profile
>
> This patch modifies the subport level data structures
> and add new API to allow dynamic configuration of the
> subport bandwidth profile.
>
> Signed-off-by: Savinay Dharmappa <savinay.dharma...@intel.com>
> Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com>
> ---
> lib/librte_sched/rte_sched.c | 486 ++++++++++++++++++++++++------
> ---
> lib/librte_sched/rte_sched.h | 82 +++++-
> lib/librte_sched/rte_sched_version.map | 2 +
> 3 files changed, 424 insertions(+), 146 deletions(-)
>
Hi Savinay,
Your patch makes sense, but it is very hard to review, as you put a massive
amount of changes (~500 LOCs) in a single patch file.
Can you please split your patch into a patchset with incremental changes that
can be reviewed easier? Some suggestions: split the internal changes in
multiple increments first before changing the API (like move the check code
into separate functions in individual patches, etc), change the API afterwards.
Thanks,
Cristian
