[dpdk-dev] [PATCH v3] lib/librte_timer:fix corruption with reset

2020-07-10 Thread Sarosh Arif
If the user tries to reset/stop some other timer in it's callback function, which is also about to expire, using rte_timer_reset_sync/rte_timer_stop_sync the application goes into an infinite loop. This happens because rte_timer_reset_sync/rte_timer_stop_sync loop until the timer resets/stops an

[dpdk-dev] [PATCH v7 01/25] ethdev: allow unknown link speed

2020-07-10 Thread Ivan Dyukov
From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is

[dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed

2020-07-10 Thread Ivan Dyukov
MAINTAINERS | 1 + app/proc-info/main.c | 9 ++ app/test-pipeline/init.c | 11 --- app/test-pmd/config.c| 20 - app/test-pmd

[dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

2020-07-10 Thread Ivan Dyukov
This commit add function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile| 3 + app/test/meson.build | 2 + app/test/test_ethd

[dpdk-dev] [PATCH v7 03/25] app: UNKNOWN link speed print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 9 +++-- app/test-pipeline/init.c | 11 +-- app/test-pmd/config.c| 20 app/test-pmd/testpmd.c | 9 + app/test/test_pmd_perf.c

[dpdk-dev] [PATCH v7 04/25] doc: update sample app with unknown speed

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- doc/guides/sample_app_ug/link_status_intr.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/li

[dpdk-dev] [PATCH v7 07/25] net/ice: return unknown speed in status

2020-07-10 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 - 1 file changed, 4 inser

[dpdk-dev] [PATCH v7 05/25] net/ixgbe: return unknown speed in status

2020-07-10 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe

[dpdk-dev] [PATCH v7 08/25] examples: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c| 12 --- examples/l2fwd-jobst

[dpdk-dev] [PATCH v7 06/25] net/i40e: return unknown speed in status

2020-07-10 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c| 5 - drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v7 10/25] examples/ioat: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..8bf80c262 100644 --- a/examp

[dpdk-dev] [PATCH v7 12/25] examples/ip_pipeline: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..ca461ea0c 100644 ---

[dpdk-dev] [PATCH v7 11/25] examples/ip_*: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 + examples/ip_reassembly/main.c| 12 examples/l3fwd-acl/main.

[dpdk-dev] [PATCH v7 13/25] examples/ipsec-secgw: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce

[dpdk-dev] [PATCH v7 09/25] examples/bbdev_app: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..44e6952e6 100644 --- a/examp

[dpdk-dev] [PATCH v7 14/25] examples/kni: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..8ad7fb532 100644 --- a/exa

[dpdk-dev] [PATCH v7 15/25] examples/l2fwd-crypt: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..7648ea027 1006

[dpdk-dev] [PATCH v7 17/25] examples/l2fwd: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..9d5f7307e 100644 --- a/examples/l2f

[dpdk-dev] [PATCH v7 16/25] examples/l2fwd-event: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..3e6d1c311 100644

[dpdk-dev] [PATCH v7 23/25] examples/qos_sched: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..4bb975fc9 100644 --- a/ex

[dpdk-dev] [PATCH v7 18/25] examples/l3fwd-graph: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..cd8e3aad1 1006

[dpdk-dev] [PATCH v7 22/25] example/performance*: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-

[dpdk-dev] [PATCH v7 19/25] examples/l3fwd-power: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..ba6bab4a5 100644

[dpdk-dev] [PATCH v7 20/25] examples/multi_proc*: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 14 +- examples/multi_process/symmetric_mp/main.c | 12 2 files changed, 9 insertions(+), 17 deletions(-) diff --g

[dpdk-dev] [PATCH v7 25/25] examples/vm_power_*: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..

[dpdk-dev] [PATCH v7 24/25] examples/server_nod*: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/ini

[dpdk-dev] [PATCH v7 21/25] examples/ntb: new link status print format

2020-07-10 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..84fe374c4 100644 --- a/examples/nt

Re: [dpdk-dev] [PATCH v3] eal: use c11 atomic built-ins for interrupt status

2020-07-10 Thread Dodji Seketeli
David Marchand writes: [...] >> --- a/devtools/libabigail.abignore >> +++ b/devtools/libabigail.abignore >> @@ -48,6 +48,10 @@ >> changed_enumerators = RTE_CRYPTO_AEAD_LIST_END >> [suppress_variable] >> name = rte_crypto_aead_algorithm_strings >> +; Ignore updates of epoll eve

[dpdk-dev] [Bug 505] [dpdk-20.08] meson build 32-bits failed on ubuntu20.04

2020-07-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=505 Bug ID: 505 Summary: [dpdk-20.08] meson build 32-bits failed on ubuntu20.04 Product: DPDK Version: 20.08 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: majo

Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors

2020-07-10 Thread Kinsella, Ray
On 08/07/2020 11:22, David Marchand wrote: > abidiff can provide some more information about the ABI difference it > detected. > In all cases, a discussion on the mailing must happen but we can give > some hints to know if this is a problem with the script calling abidiff, > a potential ABI brea

[dpdk-dev] Weird 2 KB MBUF data room requirement

2020-07-10 Thread Morten Brørup
Dear Ethernet PMD developers, According to rte_mbuf_core.h, RTE_MBUF_DEFAULT_DATAROOM is 2048 bytes because some NICs need at least 2 KB buffer to receive standard Ethernet frames without splitting them into multiple segments. This is a serious waste of memory, considering that standard Etherne

[dpdk-dev] [PATCH v5 1/2] rte_flow: add eCPRI key fields to flow API

2020-07-10 Thread Bing Zhao
Add a new item "rte_flow_item_ecpri" in order to match eCRPI header. eCPRI is a packet based protocol used in the fronthaul interface of 5G networks. Header format definition could be found in the specification via the link below: https://www.gigalight.com/downloads/standards/ecpri-specification.p

[dpdk-dev] [PATCH v5 2/2] app/testpmd: add eCPRI in flow creation patterns

2020-07-10 Thread Bing Zhao
In order to verify offloading of eCPRI protocol via flow rules, the command line of flow creation should support the parsing of the eCPRI pattern. Based on the specification, one eCPRI message will have the common header and payload. Payload format is various based on the type field of the common

[dpdk-dev] [PATCH v5 0/2] rte_flow: introduce eCPRI item for rte_flow

2020-07-10 Thread Bing Zhao
This patch set contains two commits. 1. header definition of the ethdev API 2. testpmd support for the eCPRI flow item --- v2: Add dw0 for the eCPRI common header to switch the endianess, and use fixed u32 value with big-endian for rte_flow_item_ecpri_mask. It is due to the fact that globa

Re: [dpdk-dev] 18.11.9 (LTS) patches review and test

2020-07-10 Thread Kevin Traynor
On 30/06/2020 11:02, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Tuesday, June 30, 2020 12:53 PM >> To: Ali Alnubani ; sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Akhil Goyal ; benjamin.wal...@intel.com; David >> Christensen ; Hemant Agrawal >>

[dpdk-dev] [Bug 506] i40e: Fix for rte_eth_dev_get_module_eeprom()

2020-07-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=506 Bug ID: 506 Summary: i40e: Fix for rte_eth_dev_get_module_eeprom() Product: DPDK Version: 20.05 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] DPDK hugepage memory fragmentation

2020-07-10 Thread Kamaraj P
Hello All, We are running to run DPDK based application in a container mode, When we do multiple start/stop of our container application, the DPDK initialization seems to be failing. This is because the hugepage memory fragementated and is not able to find the continuous allocation of the memory t

[dpdk-dev] [PATCH] eal/linux: truncate thread name

2020-07-10 Thread David Marchand
pthread_setname_np refuses names larger than 16 bytes (\0 included). Rather than return an error, truncate the name to this limit in the rte_thread_setname helper. Caught with ixgbe which creates control thread with name "ixgbe-link-handler": Configuring Port 0 (socket 0) EAL: Cannot set name for

[dpdk-dev] [PATCH v1 03/16] net/mlx5: fix UAR lock sharing for multiport devices

2020-07-10 Thread Viacheslav Ovsiienko
The master and representors might be created over the multiport Infiniband devices and the UAR resource allocated for sibling ports might belong to the same underlying Infiniband device. Hardware requires the write access to the UAR must be performed as atomic 64-bit write, on 32-bit systems this i

[dpdk-dev] [PATCH v1 01/16] common/mlx5: update common part to support packet pacing

2020-07-10 Thread Viacheslav Ovsiienko
This patch prepares the common part of the mlx5 PMDs to support packet send scheduling on mbuf timestamps: - the DevX routine to query the packet pacing HCA capabilities - packet pacing Send Queue attrubutes support - the hardware related definitions Signed-off-by: Viacheslav Ovsiienko ---

[dpdk-dev] [PATCH v1 04/16] net/mlx5: introduce shared UAR resource

2020-07-10 Thread Viacheslav Ovsiienko
This is preparation step before moving the Tx queue creation to the DevX approach. Some features require the shared UAR for Tx queues and scheduling completion queues, the patch manages the shared UAR. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 14 ++ drivers/n

[dpdk-dev] [PATCH v1 02/16] net/mlx5: introduce send scheduling devargs

2020-07-10 Thread Viacheslav Ovsiienko
This patch introduces the new devargs: tx_pp - enables accurate packet send scheduling on mbuf timestamps in the PMD. On the device start if "rte_dynflag_timestamp" dynamic flag is registered and this devarg non-zero value is specified, the driver initializes all necessary internal infrast

[dpdk-dev] [PATCH v1 07/16] net/mlx5: create Tx queues with DevX

2020-07-10 Thread Viacheslav Ovsiienko
To provide the packet send schedule on mbuf timestamp the Tx queue must be attached to the same UAR as Clock Queue is. UAR is special hardware related resource mapped to the host memory and provides doorbell registers, the assigning UAR to the queue being created is provided via DevX API only. Sig

[dpdk-dev] [PATCH v1 06/16] net/mlx5: create rearm queue for packet pacing

2020-07-10 Thread Viacheslav Ovsiienko
The dedicated Rearm Queue is needed to fire the work requests to the Clock Queue in realtime. The Clock Queue should never stop, otherwise the clock synchronization mignt be broken and packet send scheduling would fail. The Rearm Queue uses cross channel SEND_EN/WAIT operations to provides the requ

[dpdk-dev] [PATCH v1 05/16] net/mlx5: create clock queue for packet pacing

2020-07-10 Thread Viacheslav Ovsiienko
This patch creates the special completion queue providing reference completions to schedule packet send from other transmitting queues. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/linux/mlx5_os.c | 3 + drivers/net/mlx5/meson.build |

[dpdk-dev] [PATCH v1 08/16] net/mlx5: allocate packet pacing context

2020-07-10 Thread Viacheslav Ovsiienko
This patch allocates the Packet Pacing context from the kernel, configures one according to requested pace send scheduling granularuty and assigns to Clock Queue. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_txpp.c | 71 +

[dpdk-dev] [PATCH v1 10/16] net/mlx5: prepare Tx queue structures to support timestamp

2020-07-10 Thread Viacheslav Ovsiienko
The fields to support send scheduling on dynamic timestamp field are introduced and initialized on device start. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.h| 4 drivers/net/mlx5/mlx5_trigger.c | 2 ++ drivers/net/mlx5/mlx5_txq.c | 32 ++

[dpdk-dev] [PATCH v1 09/16] net/mlx5: introduce clock queue service routine

2020-07-10 Thread Viacheslav Ovsiienko
Service routine is invoked periodically on Rearm Queue completion interrupts, typically once per some milliseconds (1-16) to track clock jitter and wander in robust fashion. It performs the following: - fetches the completed CQEs for Rearm Queue - restarts Rearm Queue on errors - pushes new reques

[dpdk-dev] [PATCH v1 11/16] net/mlx5: convert timestamp to completion index

2020-07-10 Thread Viacheslav Ovsiienko
The application provides timestamps in Tx mbuf as clocks, the hardware performs scheduling on Clock Queue completion index match. This patch introduces the timestamp-to-completion-index inline routine. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5

[dpdk-dev] [PATCH v1 14/16] net/mlx5: add read device clock support

2020-07-10 Thread Viacheslav Ovsiienko
If send schedule feature is engaged there is the Clock Queue created, that reports reliable the currect device clock counter value. The device clock counter can be read directly from the Clock Queue CQE. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 4 ++- drivers/n

[dpdk-dev] [PATCH v1 13/16] net/mlx5: add scheduling support to send routine template

2020-07-10 Thread Viacheslav Ovsiienko
This patch adds send scheduling on timestamps into tx_burst routine template. The feature is controlled by static configuration flag, the actual routines supporting the new feature are generated over this updated template. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 16

[dpdk-dev] [PATCH v1 16/16] common/mlx5: add register access DevX routine

2020-07-10 Thread Viacheslav Ovsiienko
The DevX routine to read/write NIC registers via DevX API is added. This is the preparation step to check timestamp modes and units and gather the extended statistics. Signed-off-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c| 57 + drivers/

[dpdk-dev] [PATCH v1 12/16] net/mlx5: prepare Tx datapath to support sheduling

2020-07-10 Thread Viacheslav Ovsiienko
The new static control flag is introduced to control routine generating from template, enabling the scheduling on timestamps. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 72 ++-- drivers/net/mlx5/mlx5_txq.c | 2 ++ 2 files chan

[dpdk-dev] [PATCH v1 15/16] net/mlx5: provide the send scheduling error statistics

2020-07-10 Thread Viacheslav Ovsiienko
The mlx5 PMD exposes the following new introduced extended statistics counter to report the errors of packet send scheduling on timestamps: - txpp_err_miss_int - rearm queue interrupt was not handled was not handled in time and service routine might miss the completions - txpp_err_rea

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread David Marchand
On Wed, Jul 8, 2020 at 11:26 AM wrote: > > From: Alvin Zhang > > When mapping a PCI BAR containing an MSI-X table, some devices do not > need to actually map this BAR or only need to map part of them, which > may cause the mapping to fail. Now some checks are added and a non-NULL > initial value

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread Thomas Monjalon
10/07/2020 11:54, David Marchand: > On Wed, Jul 8, 2020 at 11:26 AM wrote: > > From: Alvin Zhang > > > > When mapping a PCI BAR containing an MSI-X table, some devices do not > > need to actually map this BAR or only need to map part of them, which > > may cause the mapping to fail. Now some chec

[dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
This patchset adds deprecation notices to python scripts, warning of the removal of python2 support from the DPDK 20.11 release. Louise Kilheeney (9): usertools/cpu_layout: add python2 deprecation notice usertools/dpdk-telemetry-client: python2 deprecation notice usertools/dpdk-devbind: add

[dpdk-dev] [PATCH 7/9] usertools/dpdk-pmdinfo: add python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
Cc: Neil Horman Signed-off-by: Louise Kilheeney --- usertools/dpdk-pmdinfo.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py index 12f20735e..f9ed75517 100755 --- a/usertools/dpdk-pmdinfo.py +++ b/usertools/dpdk-pmdin

[dpdk-dev] [PATCH 3/9] usertools/dpdk-devbind: add python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
add python2 deprecation notice Signed-off-by: Louise Kilheeney --- usertools/dpdk-devbind.py | 4 1 file changed, 4 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index dc008823f..86b6b53c4 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbin

[dpdk-dev] [PATCH 2/9] usertools/dpdk-telemetry-client: python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
add python2 depecation notice Cc: Kevin Laatz Signed-off-by: Louise Kilheeney --- usertools/dpdk-telemetry-client.py | 4 1 file changed, 4 insertions(+) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py index 35edb7cd2..98d28fa89 100755 --- a/usertool

[dpdk-dev] [PATCH 1/9] usertools/cpu_layout: add python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
add python2 deprecation notice Signed-off-by: Louise Kilheeney --- usertools/cpu_layout.py | 4 1 file changed, 4 insertions(+) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index 6f129b1db..5423c7965 100755 --- a/usertools/cpu_layout.py +++ b/usertools/cpu_layout.py @@ -1

[dpdk-dev] [PATCH 5/9] app/test-cmdline: add python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
Cc: Olivier Matz Signed-off-by: Louise Kilheeney --- app/test-cmdline/cmdline_test.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-cmdline/cmdline_test.py b/app/test-cmdline/cmdline_test.py index 3a8fac426..954428e2b 100755 --- a/app/test-cmdline/cmdline_test.py +++ b/app/tes

[dpdk-dev] [PATCH 6/9] app/test: add python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
add python2 deprecation notice Signed-off-by: Louise Kilheeney --- app/test/autotest.py | 4 1 file changed, 4 insertions(+) diff --git a/app/test/autotest.py b/app/test/autotest.py index b42f48879..cf7584ccd 100644 --- a/app/test/autotest.py +++ b/app/test/autotest.py @@ -17,6 +17,10 @@ d

[dpdk-dev] [PATCH 4/9] devtools/update_version_map: add python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
Cc: Neil Horman Cc: Ray Kinsella Signed-off-by: Louise Kilheeney --- devtools/update_version_map_abi.py | 4 1 file changed, 4 insertions(+) diff --git a/devtools/update_version_map_abi.py b/devtools/update_version_map_abi.py index e2104e61e..80a61641e 100755 --- a/devtools/update_versi

[dpdk-dev] [PATCH 9/9] app/test-bbdev: add python2 deprecation notice

2020-07-10 Thread Louise Kilheeney
Cc: Nicolas Chautru Signed-off-by: Louise Kilheeney --- app/test-bbdev/test-bbdev.py | 4 1 file changed, 4 insertions(+) diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py index e127fb2eb..5ae2dc6c4 100755 --- a/app/test-bbdev/test-bbdev.py +++ b/app/test-bbdev/test

[dpdk-dev] [PATCH 8/9] app/test-bbdev: python3 compatibility changes

2020-07-10 Thread Louise Kilheeney
use of the print function required for python3 compatibility. Cc: Nicolas Chautru Signed-off-by: Louise Kilheeney --- app/test-bbdev/test-bbdev.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py index 0194be04

Re: [dpdk-dev] Weird 2 KB MBUF data room requirement

2020-07-10 Thread Bruce Richardson
On Fri, Jul 10, 2020 at 10:21:40AM +0200, Morten Brørup wrote: > Dear Ethernet PMD developers, > > According to rte_mbuf_core.h, RTE_MBUF_DEFAULT_DATAROOM is 2048 bytes because > some NICs need at least 2 KB buffer to receive standard Ethernet frames > without splitting them into multiple segmen

Re: [dpdk-dev] DPDK hugepage memory fragmentation

2020-07-10 Thread Bruce Richardson
On Fri, Jul 10, 2020 at 02:52:16PM +0530, Kamaraj P wrote: > Hello All, > > We are running to run DPDK based application in a container mode, > When we do multiple start/stop of our container application, the DPDK > initialization seems to be failing. > This is because the hugepage memory fragemen

Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-10 Thread Bruce Richardson
On Fri, Jul 10, 2020 at 11:10:46AM +0100, Louise Kilheeney wrote: > This patchset adds deprecation notices to python scripts, > warning of the removal of python2 support from the DPDK 20.11 release. > > Louise Kilheeney (9): > usertools/cpu_layout: add python2 deprecation notice > usertools/dp

Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors

2020-07-10 Thread Neil Horman
On Wed, Jul 08, 2020 at 12:22:12PM +0200, David Marchand wrote: > abidiff can provide some more information about the ABI difference it > detected. > In all cases, a discussion on the mailing must happen but we can give > some hints to know if this is a problem with the script calling abidiff, > a

Re: [dpdk-dev] [PATCH 4/9] devtools/update_version_map: add python2 deprecation notice

2020-07-10 Thread Neil Horman
On Fri, Jul 10, 2020 at 11:10:50AM +0100, Louise Kilheeney wrote: > Cc: Neil Horman > Cc: Ray Kinsella > > Signed-off-by: Louise Kilheeney > --- > devtools/update_version_map_abi.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/devtools/update_version_map_abi.py > b/devtools/u

Re: [dpdk-dev] [PATCH 7/9] usertools/dpdk-pmdinfo: add python2 deprecation notice

2020-07-10 Thread Neil Horman
On Fri, Jul 10, 2020 at 11:10:53AM +0100, Louise Kilheeney wrote: > Cc: Neil Horman > > Signed-off-by: Louise Kilheeney > --- > usertools/dpdk-pmdinfo.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py > index 12

[dpdk-dev] [PATCH] net: fix checksum on big endian CPUs

2020-07-10 Thread Hongzhi Guo
With current code, the checksum of odd-length buffers is wrong on big endian CPUs: the last byte is not properly summed to the accumulator. Fix this by left-shifting the remaining byte by 8. For instance, if the last byte is 0x42, we should add 0x4200 to the accumulator on big endian CPUs. This c

[dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

2020-07-10 Thread Thomas Monjalon
The function pci_map_resource() returns MAP_FAILED in case of error. When replacing the call to mmap() by rte_mem_map(), the error code became NULL, breaking the API. This function is probably not used outside of DPDK, but it is still a problem for two reasons: - the deprecation process was

[dpdk-dev] [dpdk-announce] DPDK 18.11.9 (LTS) released

2020-07-10 Thread Kevin Traynor
Hi all, Here is a new LTS release: https://fast.dpdk.org/rel/dpdk-18.11.9.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=18.11 It has about 200 bugfixes since the prevsious release. Thanks to the authors who helped with backports and to the following who helpe

Re: [dpdk-dev] [PATCH] net: fix checksum on big endian CPUs

2020-07-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hongzhi Guo > Sent: Friday, July 10, 2020 1:43 PM > > With current code, the checksum of odd-length buffers is wrong on > big endian CPUs: the last byte is not properly summed to the > accumulator. > > Fix this by left-shifting the remaining

Re: [dpdk-dev] [PATCH v10 0/3] RCU integration with LPM library

2020-07-10 Thread David Marchand
On Fri, Jul 10, 2020 at 4:22 AM Ruifeng Wang wrote: > > This patchset integrates RCU QSBR support with LPM library. > > Resource reclaimation implementation was splitted from the original > series, and has already been part of RCU library. Rework the series > to base LPM integration on RCU reclaim

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread Thomas Monjalon
10/07/2020 12:07, Thomas Monjalon: > 10/07/2020 11:54, David Marchand: > > On Wed, Jul 8, 2020 at 11:26 AM wrote: > > > From: Alvin Zhang > > > > > > When mapping a PCI BAR containing an MSI-X table, some devices do not > > > need to actually map this BAR or only need to map part of them, which >

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: introduce accurate packet Tx scheduling

2020-07-10 Thread Slava Ovsiienko
Hi, Ferruh Thanks a lot for the review. > -Original Message- > From: Ferruh Yigit > Sent: Friday, July 10, 2020 2:47 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; olivier.m...@6wind.com; > bernard.iremon...@intel.com; tho...@monjalon.com; Andrew Rybchenko

Re: [dpdk-dev] [PATCH] net: fix checksum on big endian CPUs

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 02:20:08PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hongzhi Guo > > Sent: Friday, July 10, 2020 1:43 PM > > > > With current code, the checksum of odd-length buffers is wrong on > > big endian CPUs: the last byte is not properly s

[dpdk-dev] [PATCH v7 2/2] app/testpmd: add send scheduling test capability

2020-07-10 Thread Viacheslav Ovsiienko
This commit adds testpmd capability to provide timestamps on the packets being sent in the txonly mode. This includes: - SEND_ON_TIMESTAMP support new device Tx offload capability support added, example: testpmd> port config 0 tx_offload send_on_timestamp on - set txtimes, registers fi

[dpdk-dev] [PATCH v7 1/2] mbuf: introduce accurate packet Tx scheduling

2020-07-10 Thread Viacheslav Ovsiienko
There is the requirement on some networks for precise traffic timing management. The ability to send (and, generally speaking, receive) the packets at the very precisely specified moment of time provides the opportunity to support the connections with Time Division Multiplexing using the contempora

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > Per RFC768: > If the computed checksum is zero, it is transmitted as all ones. > An all zero transmitted checksum value means that the transmitter > generated no checksum. > > RFC793 for TCP has no such special treatment for the checks

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: add send scheduling test capability

2020-07-10 Thread Slava Ovsiienko
Hi Ferruh, Thanks a lot for the comments, addressed all of them. With best regards, Slava > -Original Message- > From: Ferruh Yigit > Sent: Friday, July 10, 2020 2:58 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; olivier.m...@6wind.com; > bernard.iremon..

Re: [dpdk-dev] [PATCH] eal/linux: truncate thread name

2020-07-10 Thread Thomas Monjalon
10/07/2020 11:45, David Marchand: > pthread_setname_np refuses names larger than 16 bytes (\0 included). > Rather than return an error, truncate the name to this limit in the > rte_thread_setname helper. [...] > --- a/lib/librte_eal/linux/eal_thread.c > +++ b/lib/librte_eal/linux/eal_thread.c > @@

Re: [dpdk-dev] [PATCH] eal/linux: truncate thread name

2020-07-10 Thread David Marchand
On Fri, Jul 10, 2020 at 2:41 PM Thomas Monjalon wrote: > > 10/07/2020 11:45, David Marchand: > > pthread_setname_np refuses names larger than 16 bytes (\0 included). > > Rather than return an error, truncate the name to this limit in the > > rte_thread_setname helper. > [...] > > --- a/lib/librte_

Re: [dpdk-dev] [dpdk-ci] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread Lincoln Lavoie
On Fri, Jul 10, 2020 at 6:08 AM Thomas Monjalon wrote: > 10/07/2020 11:54, David Marchand: > > On Wed, Jul 8, 2020 at 11:26 AM wrote: > > > From: Alvin Zhang > > > > > > When mapping a PCI BAR containing an MSI-X table, some devices do not > > > need to actually map this BAR or only need to map

Re: [dpdk-dev] [PATCH] mempool: return ENOMEM if initial alloc size can not be satisfied

2020-07-10 Thread 王志克
Thanks, you are right. Will send new patch. Br, Zhike Wang JDCloud, Product Development, IaaS   Mobile/+86 13466719566 E- mail/wangzh...@jd.com Address/5F Building A,North-Star Century Center,8 Beic

Re: [dpdk-dev] [PATCH v2] mempool/ring: add support for new ring sync modes

2020-07-10 Thread Olivier Matz
Hi Konstantin, On Thu, Jul 09, 2020 at 05:55:30PM +, Ananyev, Konstantin wrote: > Hi Olivier, > > > Hi Konstantin, > > > > On Mon, Jun 29, 2020 at 05:10:24PM +0100, Konstantin Ananyev wrote: > > > v2: > > > - update Release Notes (as per comments) > > > > > > Two new sync modes were introd

Re: [dpdk-dev] Weird 2 KB MBUF data room requirement

2020-07-10 Thread Olivier Matz
Hi, On Fri, Jul 10, 2020 at 11:26:09AM +0100, Bruce Richardson wrote: > On Fri, Jul 10, 2020 at 10:21:40AM +0200, Morten Brørup wrote: > > Dear Ethernet PMD developers, > > > > According to rte_mbuf_core.h, RTE_MBUF_DEFAULT_DATAROOM is 2048 bytes > > because some NICs need at least 2 KB buffer t

Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation

2020-07-10 Thread Yigit, Ferruh
On 7/10/2020 8:02 AM, Ivan Dyukov wrote: > This commit add function which treat link status structure > and format it to text representation. > > Signed-off-by: Ivan Dyukov <...> > +static int > +rte_eth_link_strf_parser(char *str, size_t len, const char *const fmt, > +c

[dpdk-dev] [PATCH v2] app/test-eventdev: Fix pipeline atq

2020-07-10 Thread Apeksha Gupta
if-check is required to check the capabilitiy of all type queue. Fixes: 6bf570a9911 ("app/eventdev: add pipeline atq test") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta --- app/test-eventdev/test_pipeline_atq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-eventdev/test_pip

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, July 10, 2020 2:41 PM > > On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > > Per RFC768: > > If the computed checksum is zero, it is transmitted as all ones. > > An all zero transmitted checksum value means that the

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 03:10:34PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, July 10, 2020 2:41 PM > > > > On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > > > Per RFC768: > > > If the computed checksum is zero, it is transmi

Re: [dpdk-dev] [PATCH v7 21/25] examples/ntb: new link status print format

2020-07-10 Thread Yigit, Ferruh
> -Original Message- > From: Ivan Dyukov > Sent: Friday, July 10, 2020 8:02 AM > To: dev@dpdk.org; i.dyu...@samsung.com; v.kurams...@samsung.com; > tho...@monjalon.net; david.march...@redhat.com; Yigit, Ferruh > ; arybche...@solarflare.com; Zhao1, Wei > ; Guo, Jia ; Xing, Beilei > ; Yang,

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, July 10, 2020 3:16 PM > > On Fri, Jul 10, 2020 at 03:10:34PM +0200, Morten Brørup wrote: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > Sent: Friday, July 10, 2020 2:41 PM > > > > > > On Fri, Jul 10, 2020 at 02:55

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

2020-07-10 Thread David Marchand
On Fri, Jul 10, 2020 at 1:53 PM Thomas Monjalon wrote: > > The function pci_map_resource() returns MAP_FAILED in case of error. > When replacing the call to mmap() by rte_mem_map(), > the error code became NULL, breaking the API. > This function is probably not used outside of DPDK, > but it is st

Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-10 Thread Robin Jarry
Hi Louise, 2020-07-10, Louise Kilheeney: > This patchset adds deprecation notices to python scripts, > warning of the removal of python2 support from the DPDK 20.11 release. While showing warnings to users about Python 2 support drop in 20.11 is good, it seems like the shebangs in a lot of these

Re: [dpdk-dev] [PATCH v3 3/3] lib/vhost: restrict pointer aliasing for packed vpmd

2020-07-10 Thread Adrian Moreno
On 7/10/20 4:38 AM, Joyce Kong wrote: > Restrict pointer aliasing to allow the compiler to vectorize loop > more aggressively. > > With this patch, a 9.6% improvement is observed in throughput for > the packed virtio-net PVP case, and a 2.8% improvement in throughput > for the packed virtio-use

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 03:29:36PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, July 10, 2020 3:16 PM > > > > On Fri, Jul 10, 2020 at 03:10:34PM +0200, Morten Brørup wrote: > > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > > Se

  1   2   3   >