> -----Original Message-----
> From: Ivan Dyukov <i.dyu...@samsung.com>
> Sent: Friday, July 10, 2020 8:02 AM
> To: dev@dpdk.org; i.dyu...@samsung.com; v.kurams...@samsung.com;
> tho...@monjalon.net; david.march...@redhat.com; Yigit, Ferruh
> <ferruh.yi...@intel.com>; arybche...@solarflare.com; Zhao1, Wei
> <wei.zh...@intel.com>; Guo, Jia <jia....@intel.com>; Xing, Beilei
> <beilei.x...@intel.com>; Yang, Qiming <qiming.y...@intel.com>; Lu,
> Wenzhuo <wenzhuo...@intel.com>; m...@smartsharesystems.com;
> step...@networkplumber.org; Chautru, Nicolas
> <nicolas.chau...@intel.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; Dumitrescu, Cristian
> <cristian.dumitre...@intel.com>; Nicolau, Radu <radu.nico...@intel.com>;
> akhil.go...@nxp.com; Doherty, Declan <declan.dohe...@intel.com>;
> sk...@marvell.com; pbhagavat...@marvell.com; jer...@marvell.com;
> kirankum...@marvell.com; Hunt, David <david.h...@intel.com>; Burakov,
> Anatoly <anatoly.bura...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>;
> Wu, Jingjing <jingjing...@intel.com>; Mcnamara, John
> <john.mcnam...@intel.com>; Singh, Jasvinder
> <jasvinder.si...@intel.com>; Marohn, Byron <byron.mar...@intel.com>;
> Wang, Yipeng1 <yipeng1.w...@intel.com>
> Subject: [PATCH v7 21/25] examples/ntb: new link status print format
> 
> Add usage of rte_eth_link_strf function to example applications
> 
> Signed-off-by: Ivan Dyukov <i.dyu...@samsung.com>
> ---
>  examples/ntb/ntb_fwd.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index
> eba8ebf9f..84fe374c4 100644
> --- a/examples/ntb/ntb_fwd.c
> +++ b/examples/ntb/ntb_fwd.c
> @@ -729,6 +729,7 @@ start_pkt_fwd(void)
>       struct rte_eth_link eth_link;
>       uint32_t lcore_id;
>       int ret, i;
> +     char link_status_text[60];
> 
>       ret = ntb_fwd_config_setup();
>       if (ret < 0) {
> @@ -747,11 +748,10 @@ start_pkt_fwd(void)
>                               return;
>                       }
>                       if (eth_link.link_status) {
> -                             printf("Eth%u Link Up. Speed %u Mbps -
> %s\n",
> -                                     eth_port_id, eth_link.link_speed,
> -                                     (eth_link.link_duplex ==
> -                                      ETH_LINK_FULL_DUPLEX) ?
> -                                     ("full-duplex") : ("half-duplex"));
> +                             rte_eth_link_strf(link_status_text, 60, NULL,
> +                                                 &link);

s/link/eth_link/

.../examples/ntb/ntb_fwd.c:752:11: error: passing argument 4 of 
‘rte_eth_link_strf’ from incompatible pointer type 
[-Werror=incompatible-pointer-types]
  752 |           &link);
      |           ^~~~~
      |           |
      |           int (*)(const char *, const char *)

> +                             printf("Eth%u %s", eth_port_id,
> +                                    link_status_text);
>                               break;
>                       }
>               }
> --
> 2.17.1

Reply via email to